src

Checkout Tools
  • last updated a few seconds ago
Constraints
Constraints: committers
 
Constraints: files
Constraints: dates
Improved XmlAdapter.ChangeValueInXml()

The old code did not replace all occurrences of a key when the different occurrences had different values.

Related to Issue [MWDAM-1294]

    • -13
    • +5
    ./Deltares.DamEngine.TestHelpers/XmlAdapter.cs
Replace type of SubSoilScenario.SegmentFailureMechanismType from FailureMechanismSystemType to SegmentFailureMechanismType in TestFiles

Related to Issue [MWDAM-1294]

Improved unit test

Related to Issue [MWDAM-1294]

Replace type of SubSoilScenario.SegmentFailureMechanismType from FailureMechanismSystemType to SegmentFailureMechanismType in TestFiles

Related to Issue [MWDAM-1294]

    • -1
    • +1
    ./Deltares.DamEngine.IntegrationTests/TestFiles/PipingVoorbeeld1_Sellmeijer4ForcesDesignHeightInputFile.xml
    • -1
    • +1
    ./Deltares.DamEngine.IntegrationTests/TestFiles/PipingVoorbeeld1_WtiSellmeijerRevisedDesignHeightInputFile.xml
    • -1
    • +1
    ./Deltares.DamEngine.IntegrationTests/TestFiles/PipingVoorbeeld1_WtiSellmeijerRevisedInputFile.xml
    • -1
    • +1
    ./Deltares.DamEngine.IntegrationTests/TestFiles/PipingVoorbeeld1_SellmeijerVNKDesignInputFile.xml
    • too large
    ./Deltares.DamEngine.IntegrationTests/TestFiles/Rechter Diezedijk_WtiSellmeijerRevisedInputFile.xml
    • -2
    • +2
    ./Deltares.DamEngine.IntegrationTests/TestFiles/Rechter Diezedijk_BlighDesignInputFile_1Location.xml
    • -1
    • +1
    ./Deltares.DamEngine.IntegrationTests/TestFiles/PipingVoorbeeld1_Sellmeijer4ForcesInputFile.xml
    • too large
    ./Deltares.DamEngine.IntegrationTests/TestFiles/Rechter Diezedijk_BlighInputFile.xml
    • -1
    • +1
    ./Deltares.DamEngine.IntegrationTests/TestFiles/PipingVoorbeeld1_SellmeijerVNKInputFile.xml
    • -1
    • +1
    ./Deltares.DamEngine.IntegrationTests/TestFiles/PipingVoorbeeld1_SellmeijerVNKDesignInputFileFail.xml
    • -2
    • +2
    ./Deltares.DamEngine.IntegrationTests/TestFiles/Rechter Diezedijk_WtiSellmeijerRevisedFailedDesignInputFile_1Location.xml
    • -1
    • +1
    ./Deltares.DamEngine.IntegrationTests/TestFiles/PipingVoorbeeld1_BlighDesignInputFile.xml
    • too large
    ./Deltares.DamEngine.IntegrationTests/TestFiles/RegionalAssessment2.xml
    • -2
    • +2
    ./Deltares.DamEngine.IntegrationTests/TestFiles/Rechter Diezedijk_NoStabilityInsideInputFile.xml
    • -1
    • +1
    ./Deltares.DamEngine.IntegrationTests/TestFiles/PipingVoorbeeld1_BlighInputFile.xml
  1. … 3 more files in changeset.
Improved unit test

Related to Issue [MWDAM-1294]

    • -0
    • +1
    ./Deltares.DamEngine.IntegrationTests/IntegrationTests/MultiCorePipingCalculationTests.cs
Replace type of SubSoilScenario.SegmentFailureMechanismType from FailureMechanismSystemType to SegmentFailureMechanismType in TestFiles

Related to Issue [MWDAM-1294]

    • -1
    • +1
    ./Deltares.DamEngine.IntegrationTests/TestFiles/PipingVoorbeeld1_WtiSellmeijerRevisedNoPipingInputFile.xml
    • -23
    • +23
    ./Deltares.DamEngine.IntegrationTests/TestFiles/MacroStabilityTutorialDesignInputFile1LocationWithAdaption.xml
    • -1
    • +1
    ./Deltares.DamEngine.IntegrationTests/TestFiles/Invoer10.xml
    • -1
    • +1
    ./Deltares.DamEngine.IntegrationTests/TestFiles/PipingVoorbeeld1_SellmeijerVNKDesignInputFileFail.xml
    • too large
    ./Deltares.DamEngine.IntegrationTests/TestFiles/RegionalAssessment2.xml
    • -1
    • +1
    ./Deltares.DamEngine.IntegrationTests/TestFiles/PipingVoorbeeld1_Sellmeijer4ForcesDesignInputFile.xml
    • -1
    • +1
    ./Deltares.DamEngine.IntegrationTests/TestFiles/PipingVoorbeeld1_SellmeijerVNKInputFile.xml
    • too large
    ./Deltares.DamEngine.IntegrationTests/TestFiles/Rechter Diezedijk_BlighDesignInputFile.xml
    • too large
    ./Deltares.DamEngine.IntegrationTests/TestFiles/DeltaDijkZoneringInwards.xml
    • too large
    ./Deltares.DamEngine.IntegrationTests/TestFiles/DeltaDijkInvoer3VNKAdaptionShoulderLength.xml
    • -1
    • +1
    ./Deltares.DamEngine.IntegrationTests/TestFiles/PipingVoorbeeld1_WtiSellmeijerRevisedInputFile.xml
    • -1
    • +1
    ./Deltares.DamEngine.IntegrationTests/TestFiles/PipingVoorbeeld1_BlighInputFile.xml
    • -1
    • +1
    ./Deltares.DamEngine.IntegrationTests/TestFiles/PipingVoorbeeld1_SellmeijerVNKDesignInputFile.xml
    • -1
    • +1
    ./Deltares.DamEngine.IntegrationTests/TestFiles/PipingVoorbeeld1_BlighDesignInputFile.xml
    • -23
    • +23
    ./Deltares.DamEngine.IntegrationTests/TestFiles/MacroStabilityTutorialDesignInputFile.xml
  1. … 15 more files in changeset.
Replace type of SubSoilScenario.SegmentFailureMechanismType from FailureMechanismSystemType to SegmentFailureMechanismType

Related to Issue [MWDAM-1294]

    • -0
    • +39
    ./Deltares.DamEngine.Interface/ConversionHelper.cs
    • -1
    • +1
    ./Deltares.DamEngine.Calculators/DikesDesign/DesignCalculator.cs
    • -8
    • +27
    ./Deltares.DamEngine.Interface.Tests/ConversionHelperTests.cs
  1. … 15 more files in changeset.
Fix failing compile

Related to Issue [MWDAM-1294]

    • -0
    • +1
    ./Deltares.DamEngine.IntegrationTests/IntegrationTests/MacroStabilityInwardsTests.cs
    • -0
    • +1
    ./Deltares.DamEngine.IntegrationTests/IntegrationTests/PipingSellmeijerVnkTests.cs
    • -0
    • +1
    ./Deltares.DamEngine.IntegrationTests/IntegrationTests/MacroStabilityOutwardsTests.cs
    • -0
    • +1
    ./Deltares.DamEngine.TestHelpers/Factories/FactoryForDamProjectData.cs
    • -0
    • +1
    ./Deltares.DamEngine.IntegrationTests/IntegrationTests/WtiPipingSellmeijerRevisedTests.cs
Introduce SegmentFailureMechanismType and also conversion method to convert FailureMechanismSystemType to SegmentFailureMechanismType

Related to Issue [MWDAM-1294]

    • -0
    • +1
    ./Deltares.DamEngine.Data.Tests/Deltares.DamEngine.Data.Tests.csproj
    • -0
    • +1
    ./Deltares.DamEngine.Data/Deltares.DamEngine.Data.csproj
    • -0
    • +43
    ./Deltares.DamEngine.Data/General/ConversionHelper.cs
    • -0
    • +41
    ./Deltares.DamEngine.Data.Tests/General/ConversionHelperTests.cs
Adapted to review

Related to Issue [MWDAM-1340]

    • -0
    • +1
    ./Deltares.DamEngine.Interface.Tests/FillDamFromXmlInputTests.cs
  1. … 1 more file in changeset.
Removed DamType as property from Location and xsd.

Related to Issue [MWDAM-1441]

    • too large
    ./Deltares.DamEngine.Io/DamInput.cs
    • -1
    • +1
    ./Deltares.DamEngine.Calculators.Tests/Uplift/UpliftLocationDeterminatorTest.cs
  1. … 1 more file in changeset.
Fixed TestGiveFeedBackWhenNoProfilesAreAvailable

Related to Issue [MWDAM-1231]

    • -1
    • +1
    ./Deltares.DamEngine.IntegrationTests/IntegrationTests/MacroStabilityInwardsTests.cs
Set message when no segments with the expected failure mechanism type were found

Related to Issue [MWDAM-1231]

    • -0
    • +68
    ./Deltares.DamEngine.IntegrationTests/TestFiles/PipingVoorbeeld1_WtiSellmeijerRevisedNoPipingInputFile.xml
    • -0
    • +384
    ./Deltares.DamEngine.IntegrationTests/TestFiles/Rechter Diezedijk_NoStabilityInsideInputFile.xml
    • -0
    • +7
    ./Deltares.DamEngine.IntegrationTests/Deltares.DamEngine.IntegrationTests.csproj
    • -0
    • +9
    ./Deltares.DamEngine.Calculators/Properties/Resources.Designer.cs
    • -22
    • +42
    ./Deltares.DamEngine.Calculators/DikesDesign/DesignCalculator.cs
    • -0
    • +53
    ./Deltares.DamEngine.IntegrationTests/IntegrationTests/DesignCalculatorTests.cs
    • -0
    • +3
    ./Deltares.DamEngine.Calculators/Properties/Resources.nl-NL.resx
Removed Location.DikeTableHeight from the interface as suggested by the reviewer.

Related to Issue [MWDAM-1410]

    • -1
    • +0
    ./Deltares.DamEngine.Interface/FillXmlInputFromDam.cs
    • -2
    • +0
    ./Deltares.DamEngine.TestHelpers/Factories/FactoryForDamProjectData.cs
    • -1
    • +0
    ./Deltares.DamEngine.Interface/FillDamFromXmlInput.cs
    • too large
    ./Deltares.DamEngine.Io/DamInput.cs
  1. … 1 more file in changeset.
Fixed failing test CreatePL2andPL4For1DGeometryWithExpertKnowledgeRRDWithAllWithSandLayerInBetweenAndPenetrationLengthInThisAquiferLayer

There is no longer a distinction between a regional and a primary location.

Related to Issue [MWDAM-1434]

    • too large
    ./Deltares.DamEngine.Calculators.Tests/PlLinesCreator/PlLinesCreatorTest.cs
Removed DamType from CreatePlLineByExpertKnowledge

Related to Issue [MWDAM-1434]

    • too large
    ./Deltares.DamEngine.Calculators/PlLinesCreator/PlLinesCreator.cs
    • too large
    ./Deltares.DamEngine.Calculators.Tests/PlLinesCreator/PlLinesCreatorTest.cs
Removed DamType from GetHeadPl4

Related to Issue [MWDAM-1434]

    • too large
    ./Deltares.DamEngine.Calculators/PlLinesCreator/PlLinesCreator.cs
Removed 'no hydraulic shortcut' from comment because it is no longer applicable. If no value for headPl4 then always use waterLevel.

Related to Issue [MWDAM-1434]

    • too large
    ./Deltares.DamEngine.Calculators/PlLinesCreator/PlLinesCreator.cs
Split test for Bligh MultiCore off so the tests for Sellmeijer4Forces and SellmeijerVNK are not ignored

Related to Issue [MWDAM-1020]

    • -2
    • +13
    ./Deltares.DamEngine.IntegrationTests/IntegrationTests/MultiCorePipingCalculationTests.cs
added calculation message to PerformSingleCalculation (NoAdaption) when calculation fails, as for PerformDesignCalculation (AdaptGeometry)

Related to Issue [MWDAM-1396]

    • -0
    • +1
    ./Deltares.DamEngine.Calculators/DikesDesign/DesignCalculatorSingle.cs
    • -6
    • +5
    ./Deltares.DamEngine.IntegrationTests/IntegrationTests/WtiPipingSellmeijerRevisedTests.cs
Removed obsolete PolderLevelLow and PolderLevelLowSpecified.

Related to Issue [MWDAM-1409]

    • too large
    ./Deltares.DamEngine.Io/DamInput.cs
    • -2
    • +0
    ./Deltares.DamEngine.Interface/FillXmlInputFromDam.cs
    • -1
    • +0
    ./Deltares.DamEngine.TestHelpers/Factories/FactoryForDamProjectData.cs
    • -2
    • +0
    ./Deltares.DamEngine.Interface/FillDamFromXmlInput.cs
  1. … 1 more file in changeset.
Moved exception classes to separate files.

Related to Issue [MWDAM-1394]

    • -13
    • +0
    ./Deltares.DamEngine.Data/General/Dike.cs
    • -0
    • +3
    ./Deltares.DamEngine.Data/Deltares.DamEngine.Data.csproj
    • -0
    • +37
    ./Deltares.DamEngine.Data/Geometry/CoordinateSystemConverterException.cs
    • -0
    • +38
    ./Deltares.DamEngine.Data/General/DikeException.cs
    • -0
    • +38
    ./Deltares.DamEngine.Data/General/PolyLineException.cs
    • -0
    • +2
    ./Deltares.DamEngine.Calculators/Deltares.DamEngine.Calculators.csproj
    • -0
    • +37
    ./Deltares.DamEngine.Calculators/Uplift/SoilVolumicMassCalculatorException.cs
    • -12
    • +0
    ./Deltares.DamEngine.Data/Geometry/CoordinateSystemConverter.cs
    • -12
    • +0
    ./Deltares.DamEngine.Calculators/Uplift/SoilVolumicMassCalculator.cs
Removed ObjectExtensions from Calculators, instead use ObjectExtensions from Standard. Added the missing methods from Calculators to Standard.

Related to Issue [MWDAM-1394]

    • -0
    • +7
    ./Deltares.DamEngine.Data/Standard/ConversionException.cs
    • -1
    • +0
    ./Deltares.DamEngine.Calculators/Deltares.DamEngine.Calculators.csproj
    • -1
    • +88
    ./Deltares.DamEngine.Data/Standard/ObjectExtensions.cs
refactored all Exception classes, removed methods that were not used, added comments

Related to Issue [MWDAM-1394]

    • -18
    • +10
    ./Deltares.DamEngine.Calculators/PlLinesCreator/SensorPlLineCreatorException.cs
    • -1
    • +5
    ./Deltares.DamEngine.Calculators/Uplift/SoilVolumicMassCalculator.cs
    • -4
    • +1
    ./Deltares.DamEngine.Data/General/Dike.cs
    • -3
    • +1
    ./Deltares.DamEngine.Calculators/DikesOperational/OperationalCalculatorException.cs
    • -1
    • +1
    ./Deltares.DamEngine.Interface/EngineInterfaceException.cs
    • -12
    • +10
    ./Deltares.DamEngine.Data/Standard/ConversionException.cs
    • -30
    • +2
    ./Deltares.DamEngine.Calculators/DikesDesign/SurfaceLineAdapterException.cs
    • -6
    • +4
    ./Deltares.DamEngine.Calculators/Stability/StabilityServiceAgentException.cs
  1. … 7 more files in changeset.
refactored WtiPipingSellmeijerRevisedException, removed methods that were not used, added comments

Related to Issue [MWDAM-1394]

Fixed test CanPerformWtiDesignNoAdaptionRechterDiezedijk

Related to Issue [MWDAM-1394]

    • -4
    • +7
    ./Deltares.DamEngine.IntegrationTests/IntegrationTests/WtiPipingSellmeijerRevisedTests.cs
After removing Assessment mode, cleaned code somewhat. Mainly getting rid of dead code.

Related to Issue [MWDAM-1410]

    • -1
    • +24
    ./Deltares.DamEngine.Data/General/MStabParameters.cs
    • -1
    • +1
    ./Deltares.DamEngine.Interface/FillXmlInputFromDam.cs
    • -12
    • +0
    ./Deltares.DamEngine.Data/Deltares.DamEngine.Data.csproj
    • -88
    • +0
    ./Deltares.DamEngine.Data/General/LocationJob.cs
    • -31
    • +1
    ./Deltares.DamEngine.Data/General/DamFailureMechanismeCalculationSpecification.cs
    • -494
    • +27
    ./Deltares.DamEngine.Data/Design/DesignScenario.cs
    • -11
    • +1
    ./Deltares.DamEngine.Calculators/DikesOperational/OperationalCalculator.cs
  1. … 12 more files in changeset.
Removed all Assessment mode enumerations now too see Issue [MWDAM-1282].

Related to Issue [MWDAM-1410]

    • -52
    • +2
    ./Deltares.DamEngine.Data/General/DAMEnumerations.cs
Removed Assessment mode from the Engine (code and xsd). Note: the enumerations belonging to this mode will be removed in next commit as this is part of two issues.

Related to Issue [MWDAM-1410]

    • -25
    • +1
    ./Deltares.DamEngine.Interface/FillXmlInputFromDam.cs
    • -5
    • +0
    ./Deltares.DamEngine.Calculators.Tests/Deltares.DamEngine.Calculators.Tests.csproj
    • -28
    • +28
    ./Deltares.DamEngine.IntegrationTests/IntegrationTests/PipingSellmeijerVnkTests.cs
    • -39
    • +39
    ./Deltares.DamEngine.IntegrationTests/IntegrationTests/WtiPipingSellmeijerRevisedTests.cs
    • -14
    • +14
    ./Deltares.DamEngine.IntegrationTests/IntegrationTests/MacroStabilityOutwardsTests.cs
    • -42
    • +42
    ./Deltares.DamEngine.IntegrationTests/IntegrationTests/PipingBlighTests.cs
    • -1
    • +0
    ./Deltares.DamEngine.IntegrationTests/Deltares.DamEngine.IntegrationTests.csproj
    • -7
    • +0
    ./Deltares.DamEngine.Data/Deltares.DamEngine.Data.csproj
    • -118
    • +1
    ./Deltares.DamEngine.Interface.Tests/ConversionHelperTests.cs
    • -87
    • +0
    ./Deltares.DamEngine.Data/General/RegionalAssessmentScenarioJobSettings.cs
    • too large
    ./Deltares.DamEngine.Calculators/PlLinesCreator/PlLinesCreator.cs
  1. … 65 more files in changeset.
Small fixes

Related to Issue [MWDAM-1340]

    • -1
    • +1
    ./Deltares.DamEngine.Interface/FillXmlInputFromDam.cs
    • -2
    • +2
    ./Deltares.DamEngine.Io/IdValidator.cs