Riskeer

Clone Tools

Stats

Commits this week: 0
Total Committers: 28
Last Commit: 26 Nov
Commits this week: 0

Lines of code count not available

Commit Activity

Commits By Day In Week
52 week commits volume
Commits By Day In Week
Commits by day
Commits By Day In Week
Commits by hour
Commits By Hour In Day
Commit calendar
 

Most active committers (90 days)

loading
loading
  • last updated a few seconds ago
All Commits Reviews
Constraints
Constraints: committers
 
Constraints: files
Constraints: dates
Wednesday 30 Nov 2016
9:54 am

bouvrie <bouvrie@example.com>

* Fixed bug in FailureMechanismContributionView where pressing Esc validated current value before reverting the value back to the value in the data model. * Improved XML docs. * Added preconditions for FailureMechanismContributionNormChangeHandler and create unit tests for whole implementation. * Improved resources. Related to Issue [WTI-791]

git-svn-id: https://repos.deltares.nl/repos/WettelijkToetsInstrumentarium/trunk@6922 5a3db67b-de53-47b5-99c8-a1c30a6650e2

Former-commit-id: d6242344bf1258f694ceb9d148134fdae6942472

Former-commit-id: 84e4151a0a239f6e693fe7720ef6b8efdc277fe9

Options
    • -2
    • +3
    /Ringtoets/Integration/src/Ringtoets.Integration.Forms/Views/FailureMechanismContributionView.cs
    • -1
    • +1
    /Ringtoets/Integration/src/Ringtoets.Integration.Forms/Views/FailureMechanismContributionView.resx
    • -2
    • +7
    /Ringtoets/Integration/src/Ringtoets.Integration.Forms/Views/IFailureMechanismContributionNormChangeHandler.cs
    • -12
    • +15
    /Ringtoets/Integration/src/Ringtoets.Integration.Plugin/Handlers/FailureMechanismContributionNormChangeHandler.cs
    • -7
    • +9
    /Ringtoets/Integration/src/Ringtoets.Integration.Plugin/Properties/Resources.Designer.cs
    • -3
    • +5
    /Ringtoets/Integration/src/Ringtoets.Integration.Plugin/Properties/Resources.resx
    • -1
    • +1
    /Ringtoets/Integration/test/Ringtoets.Integration.Forms.Test/Views/FailureMechanismContributionViewTest.cs
    • -1
    • +151
    /Ringtoets/Integration/test/Ringtoets.Integration.Plugin.Test/Handlers/FailureMechanismContributionNormChangeHandlerTest.cs
    • -7
    • +25
    /Ringtoets/Integration/test/Ringtoets.Integration.TestUtils/TestDataGenerator.cs
9:37 am

Dennis Tang <dennis.tang@deltares.nl>

Implement additional properties for the output: - Added a parser to the WaveConditionsCosineCalculator and the WaveConditionsCalculationOutput to store the parsed WaveDirection - Extended the WaveConditionsCalculationParser to parse the wave direction (wave angle w.r.t north) Related to Issue [WTI-897]

git-svn-id: https://repos.deltares.nl/repos/WettelijkToetsInstrumentarium/trunk@6921 5a3db67b-de53-47b5-99c8-a1c30a6650e2

Former-commit-id: c8603bb06bfa780fdce86d4ac4c2c326d6702ed4

Former-commit-id: 72631d97a690b881761c7786ab92d94286dda927

Options
    • -1
    • +16
    /Ringtoets/HydraRing/src/Ringtoets.HydraRing.Calculation/Calculator/IWaveConditionsCosineCalculator.cs
    • -0
    • +13
    /Ringtoets/HydraRing/src/Ringtoets.HydraRing.Calculation/Calculator/WaveConditionsCosineCalculator.cs
    • -3
    • +10
    /Ringtoets/HydraRing/src/Ringtoets.HydraRing.Calculation/Data/Output/WaveConditionsCalculationOutput.cs
    • -2
    • +17
    /Ringtoets/HydraRing/src/Ringtoets.HydraRing.Calculation/Parsers/WaveConditionsCalculationParser.cs
    • -0
    • +2
    /Ringtoets/HydraRing/test/Ringtoets.HydraRing.Calculation.Test/Calculator/WaveConditionsCosineCalculatorTest.cs
    • -2
    • +4
    /Ringtoets/HydraRing/test/Ringtoets.HydraRing.Calculation.Test/Data/Output/WaveConditionsCalculationOutputTest.cs
    • -0
    • +17
    /Ringtoets/HydraRing/test/Ringtoets.HydraRing.Calculation.Test/Parsers/WaveConditionsCalculationParserTest.cs
    • -0
    • +16
    /Ringtoets/HydraRing/test/Ringtoets.HydraRing.Calculation.Test/test-data/Parsers/WaveConditionsCalculationParser/output-no-waveDirection/1-output.txt
    • -0
    • +2
    /Ringtoets/HydraRing/test/Ringtoets.HydraRing.Calculation.TestUtil/Calculator/TestHydraRingCalculatorFactory.cs
Tuesday 29 Nov 2016
2:22 pm

Dennis Tang <dennis.tang@deltares.nl>

Removed local definitions of ReliabilityToProbability and ProbabilityToReliability. Make use of the defined methods in StatisticsConverter. Related to Issue [WTI-897]

git-svn-id: https://repos.deltares.nl/repos/WettelijkToetsInstrumentarium/trunk@6920 5a3db67b-de53-47b5-99c8-a1c30a6650e2

Former-commit-id: 0834ea288e00ce6a68f34973e94b06259a872f6d

Former-commit-id: e91300ce8de1ee6f17f6b2019da6029403b3fbd2

Options
    • -13
    • +3
    /Ringtoets/Common/src/Ringtoets.Common.Service/ProbabilityAssessmentService.cs
    • -17
    • +7
    /Ringtoets/Piping/src/Ringtoets.Piping.Service/PipingSemiProbabilisticCalculationService.cs
2:07 pm

Dennis Tang <dennis.tang@deltares.nl>

Extended tests for the StatisticsConverter: - Added more testcases between and including the maximum user input value - ReliabilityToProbability and vice versa explicitly covered Related to Issue [WTI-897]

git-svn-id: https://repos.deltares.nl/repos/WettelijkToetsInstrumentarium/trunk@6919 5a3db67b-de53-47b5-99c8-a1c30a6650e2

Former-commit-id: 1276667fb62af4e8bd7b3f8e591c1de7b1fef544

Former-commit-id: c9520ac05a7d49190cd8a2a2fd27e82f5a8a9bf9

Options
    • -3
    • +44
    /Core/Common/test/Core.Common.Utils.Test/StatisticsConverterTest.cs
1:33 pm

bouvrie <bouvrie@example.com>

* Made variable explicit. * Extracted result of method call for reuse. Related to Issue [WTI-989]

git-svn-id: https://repos.deltares.nl/repos/WettelijkToetsInstrumentarium/trunk@6918 5a3db67b-de53-47b5-99c8-a1c30a6650e2

Former-commit-id: efc628f5146da16db8f3d1f1bed0f1ad458ec42d

Former-commit-id: a02d349e3fd774ecf37675c4e6083b8802e5c12c

Options
    • -29
    • +29
    /Core/Common/test/Core.Common.Base.Test/Data/RoundedDoubleTest.cs
    • -2
    • +3
    /Ringtoets/Common/src/Ringtoets.Common.Forms/UITypeEditors/HydraulicBoundaryLocationEditor.cs
1:17 pm

Dennis Tang <dennis.tang@deltares.nl>

Renamed "norm" to "return period" in tests and calculation services/activities Related to Issue [WTI-897]

git-svn-id: https://repos.deltares.nl/repos/WettelijkToetsInstrumentarium/trunk@6917 5a3db67b-de53-47b5-99c8-a1c30a6650e2

Former-commit-id: 94ec0f8e41ace6785b246e12f15e2a85df72e391

Former-commit-id: 4c607ad28f55613dab77ba552e25de18d88cd466

Options
    • -5
    • +5
    /Ringtoets/Common/src/Ringtoets.Common.Service/ProbabilityAssessmentService.cs
    • -6
    • +6
    /Ringtoets/Common/test/Ringtoets.Common.Service.Test/ProbabilityAssessmentServiceTest.cs
    • -6
    • +6
    /Ringtoets/Piping/src/Ringtoets.Piping.Plugin/PipingPlugin.cs
    • -5
    • +5
    /Ringtoets/Piping/src/Ringtoets.Piping.Service/PipingCalculationActivity.cs
    • -5
    • +8
    /Ringtoets/Piping/src/Ringtoets.Piping.Service/PipingSemiProbabilisticCalculationService.cs
    • -2
    • +2
    /Ringtoets/Piping/test/Ringtoets.Piping.Service.Test/PipingCalculationActivityTest.cs
    • -14
    • +14
    /Ringtoets/Piping/test/Ringtoets.Piping.Service.Test/PipingSemiProbabilisticCalculationServiceTest.cs
1:09 pm

Robert Tangerman <robert.tangerman@deltares.nl>

Replace data of series instead of complete series.

git-svn-id: https://repos.deltares.nl/repos/WettelijkToetsInstrumentarium/branches/Chart-spike@6916 5a3db67b-de53-47b5-99c8-a1c30a6650e2

Former-commit-id: 9fb34293ea510ee41ee25fcf13b612d3e969eb37

Former-commit-id: f09b005184af6cfacddfe723f016b113bde020b4

Options
    • -4
    • +10
    /Core/Components/src/Core.Components.OxyPlot.Forms/ChartControl.cs
9:35 am

Robert Tangerman <robert.tangerman@deltares.nl>

Fixed GetChartDataRecursively

git-svn-id: https://repos.deltares.nl/repos/WettelijkToetsInstrumentarium/branches/Chart-spike@6915 5a3db67b-de53-47b5-99c8-a1c30a6650e2

Former-commit-id: 33a396dd61fe8f4295eb2c29fe98cdc177d8f3b6

Former-commit-id: a7640949901d6167ed54254a84f962cb74a9ed5f

Options
    • -4
    • +5
    /Core/Components/src/Core.Components.OxyPlot.Forms/ChartControl.cs
8:59 am

Dennis Tang <dennis.tang@deltares.nl>

Renamed "GetMechanismSpecificNorm" to "GetMechanismSpecificReturnPeriod" in tests and calculation services/activities Related to Issue [WTI-897]

git-svn-id: https://repos.deltares.nl/repos/WettelijkToetsInstrumentarium/trunk@6914 5a3db67b-de53-47b5-99c8-a1c30a6650e2

Former-commit-id: c48b2e65eab61f8ca170c90549f83b2c49754c44

Former-commit-id: da087483c433802af1e44e9fb0988606020446b2

Options
    • -4
    • +4
    /Ringtoets/GrassCoverErosionOutwards/src/Ringtoets.GrassCoverErosionOutwards.Data/GrassCoverErosionOutwardsFailureMechanismExtensions.cs
    • -7
    • +7
    /Ringtoets/GrassCoverErosionOutwards/src/Ringtoets.GrassCoverErosionOutwards.Forms/Views/GrassCoverErosionOutwardsDesignWaterLevelLocationsView.cs
    • -7
    • +7
    /Ringtoets/GrassCoverErosionOutwards/src/Ringtoets.GrassCoverErosionOutwards.Forms/Views/GrassCoverErosionOutwardsWaveHeightLocationsView.cs
    • -10
    • +10
    /Ringtoets/GrassCoverErosionOutwards/src/Ringtoets.GrassCoverErosionOutwards.Plugin/GrassCoverErosionOutwardsPlugin.cs
    • -1
    • +1
    /Ringtoets/GrassCoverErosionOutwards/src/Ringtoets.GrassCoverErosionOutwards.Service/GrassCoverErosionOutwardsWaveConditionsCalculationService.cs
    • -7
    • +7
    /Ringtoets/GrassCoverErosionOutwards/test/Ringtoets.GrassCoverErosionOutwards.Data.Test/GrassCoverErosionOutwardsFailureMechanismExtensionsTest.cs
    • -1
    • +1
    /Ringtoets/GrassCoverErosionOutwards/test/Ringtoets.GrassCoverErosionOutwards.Integration.Test/GrassCoverErosionOutwardsWaveConditionsCalculationActivityIntegrationTest.cs
    • -1
    • +1
    /Ringtoets/GrassCoverErosionOutwards/test/Ringtoets.GrassCoverErosionOutwards.Service.Test/GrassCoverErosionOutwardsWaveConditionsCalculationServiceTest.cs
8:38 am

Robert Tangerman <robert.tangerman@deltares.nl>

Changed labels category. Paired with kleijn Related to Issue [WTI-957]

git-svn-id: https://repos.deltares.nl/repos/WettelijkToetsInstrumentarium/trunk@6913 5a3db67b-de53-47b5-99c8-a1c30a6650e2

Former-commit-id: 18b3f61736fb938f5e7b59cf6b6a2ef86f0a1b7b

Former-commit-id: 7670a76a4cf28b43935a74bddb3bb4a64cb0d0c8

Options
    • -2
    • +2
    /Core/Plugins/src/Core.Plugins.Map/Properties/Resources.Designer.cs
    • -1
    • +1
    /Core/Plugins/src/Core.Plugins.Map/Properties/Resources.resx
    • -4
    • +4
    /Core/Plugins/test/Core.Plugins.Map.Test/PropertyClasses/FeatureBasedMapDataPropertiesTest.cs
8:31 am

Elmar Kleijn

Reverted some changes Related to Issue [WTI-1018]

git-svn-id: https://repos.deltares.nl/repos/WettelijkToetsInstrumentarium/trunk@6912 5a3db67b-de53-47b5-99c8-a1c30a6650e2

Former-commit-id: c027432b2fa22f31b00e5c39e4da44d841959ecb

Former-commit-id: 64e11d1547ba22008efacfe6f3f543587a43e83a

Options
    • -4
    • +17
    /Core/Components/src/Core.Components.DotSpatial.Forms/MapControl.cs
7:55 am

Robert Tangerman <robert.tangerman@deltares.nl>

Merged revision(s) 6871-6910 from trunk

git-svn-id: https://repos.deltares.nl/repos/WettelijkToetsInstrumentarium/branches/Chart-spike@6911 5a3db67b-de53-47b5-99c8-a1c30a6650e2

Former-commit-id: ad4c21c2913f65dffb69f6776c0f31baa15d152b

Former-commit-id: 46532fa71ed03a940b86f6675644aa806ae450d0

Options
Monday 28 Nov 2016
5:48 pm

Elmar Kleijn

Integrated new methods in MapFeatureLayerFactory Related to Issue [WTI-1018]

git-svn-id: https://repos.deltares.nl/repos/WettelijkToetsInstrumentarium/trunk@6910 5a3db67b-de53-47b5-99c8-a1c30a6650e2

Former-commit-id: 5a37e8eee11b06d82413e993c28da22f54ed0605

Former-commit-id: feee8d4a81cc92578b6fc225556013c0a259f231

Options
    • -17
    • +4
    /Core/Components/src/Core.Components.DotSpatial.Forms/MapControl.cs
5:40 pm

Elmar Kleijn

Extended MapFeatureLayerFactory with ConvertLayerFeatures and ConvertLayerProperties method Related to Issue [WTI-1018]

git-svn-id: https://repos.deltares.nl/repos/WettelijkToetsInstrumentarium/trunk@6909 5a3db67b-de53-47b5-99c8-a1c30a6650e2

Former-commit-id: 00d8af9ca276811b189426903a47fb38a5fe475b

Former-commit-id: 5273a14f0cffe3b32418d7708dbd41b7c60205ce

Options
    • -0
    • +47
    /Core/Components/src/Core.Components.DotSpatial/Converter/MapFeatureLayerFactory.cs
5:32 pm

Dennis Tang <dennis.tang@deltares.nl>

Fixed failing tests

Related to Issue [WTI-897]

git-svn-id: https://repos.deltares.nl/repos/WettelijkToetsInstrumentarium/trunk@6908 5a3db67b-de53-47b5-99c8-a1c30a6650e2

Former-commit-id: b565b99feefc8fdb74701ee3a28e6ef879ab03d2

Former-commit-id: afb12c16499c06564e5b9fb4e6957951e9c80c5f

Options
    • -5
    • +5
    /Ringtoets/HydraRing/test/Ringtoets.HydraRing.Calculation.Test/Integration/HydraRingConfigurationServiceIntegrationTest.cs
5:28 pm

Dennis Tang <dennis.tang@deltares.nl>

Renamed "norm" to "return period" in tests and calculation services/activities Related to Issue [WTI-897]

git-svn-id: https://repos.deltares.nl/repos/WettelijkToetsInstrumentarium/trunk@6907 5a3db67b-de53-47b5-99c8-a1c30a6650e2

Former-commit-id: f74f3304d2690808ceb1633064a3d9e6034c0810

Former-commit-id: 10d048122d4fccde0039b2fe542618e6a5733722

Options
    • -4
    • +4
    /Ringtoets/Common/src/Ringtoets.Common.Forms/GuiServices/HydraulicBoundaryLocationCalculationGuiService.cs
    • -4
    • +4
    /Ringtoets/Common/src/Ringtoets.Common.Forms/GuiServices/IHydraulicBoundaryLocationCalculationGuiService.cs
    • -5
    • +5
    /Ringtoets/Common/src/Ringtoets.Common.Service/DesignWaterLevelCalculationActivity.cs
    • -6
    • +6
    /Ringtoets/Common/src/Ringtoets.Common.Service/DesignWaterLevelCalculationService.cs
    • -5
    • +5
    /Ringtoets/Common/src/Ringtoets.Common.Service/WaveHeightCalculationActivity.cs
    • -6
    • +6
    /Ringtoets/Common/src/Ringtoets.Common.Service/WaveHeightCalculationService.cs
    • -4
    • +4
    /Ringtoets/Common/test/Ringtoets.Common.Service.Test/DesignWaterLevelCalculationActivityTest.cs
    • -5
    • +5
    /Ringtoets/Common/test/Ringtoets.Common.Service.Test/DesignWaterLevelCalculationServiceTest.cs
    • -4
    • +4
    /Ringtoets/Common/test/Ringtoets.Common.Service.Test/WaveHeightCalculationActivityTest.cs
    • -5
    • +5
    /Ringtoets/Common/test/Ringtoets.Common.Service.Test/WaveHeightCalculationServiceTest.cs
    • -2
    • +2
    /Ringtoets/GrassCoverErosionOutwards/src/Ringtoets.GrassCoverErosionOutwards.Service/GrassCoverErosionOutwardsWaveConditionsCalculationService.cs
    • -4
    • +4
    /Ringtoets/HydraRing/src/Ringtoets.HydraRing.Calculation/Data/Input/WaveConditions/WaveConditionsCalculationInput.cs
    • -3
    • +3
    /Ringtoets/HydraRing/src/Ringtoets.HydraRing.Calculation/Data/Input/WaveConditions/WaveConditionsCosineCalculationInput.cs
    • -3
    • +3
    /Ringtoets/HydraRing/src/Ringtoets.HydraRing.Calculation/Data/Input/WaveConditions/WaveConditionsTrapezoidCalculationInput.cs
    • -2
    • +2
    /Ringtoets/HydraRing/test/Ringtoets.HydraRing.Calculation.Test/Data/Input/WaveConditions/WaveConditionsCalculationInputTest.cs
  16. … 4 more files in changeset.
5:01 pm

Dennis Tang <dennis.tang@deltares.nl>

Renamed "norm" to "return period" in tests and HydraRing input classes

Related to Issue [WTI-897]

git-svn-id: https://repos.deltares.nl/repos/WettelijkToetsInstrumentarium/trunk@6906 5a3db67b-de53-47b5-99c8-a1c30a6650e2

Former-commit-id: 475e275411cd2b48378f9b62e2c19f307b31ddaf

Former-commit-id: 7e3c60bbe63bc728c622cceb71519f73a456b25b

Options
    • -3
    • +3
    /Ringtoets/HydraRing/src/Ringtoets.HydraRing.Calculation/Data/Input/Hydraulics/AssessmentLevelCalculationInput.cs
    • -3
    • +3
    /Ringtoets/HydraRing/src/Ringtoets.HydraRing.Calculation/Data/Input/Hydraulics/DikeHeightCalculationInput.cs
    • -3
    • +3
    /Ringtoets/HydraRing/src/Ringtoets.HydraRing.Calculation/Data/Input/Hydraulics/DunesBoundaryConditionsCalculationInput.cs
    • -3
    • +3
    /Ringtoets/HydraRing/src/Ringtoets.HydraRing.Calculation/Data/Input/Hydraulics/HydraulicLoadsCalculationInput.cs
    • -3
    • +3
    /Ringtoets/HydraRing/src/Ringtoets.HydraRing.Calculation/Data/Input/Hydraulics/OvertoppingRateCalculationInput.cs
    • -3
    • +3
    /Ringtoets/HydraRing/src/Ringtoets.HydraRing.Calculation/Data/Input/Hydraulics/WaveHeightCalculationInput .cs
    • -4
    • +4
    /Ringtoets/HydraRing/src/Ringtoets.HydraRing.Calculation/Data/Input/ReliabilityIndexCalculationInput.cs
    • -2
    • +2
    /Ringtoets/HydraRing/test/Ringtoets.HydraRing.Calculation.Test/Data/Input/Hydraulics/HydraulicLoadsCalculationInputTest.cs
    • -4
    • +4
    /Ringtoets/HydraRing/test/Ringtoets.HydraRing.Calculation.Test/Integration/HydraRingConfigurationServiceIntegrationTest.cs
4:52 pm

Dennis Tang <dennis.tang@deltares.nl>

- Extended StatisticsConverter with ProbabilityToReliability and ReliabilityToProbability - Renamed NormToBeta to ReturnPeriodToReliability - Renamed "norm" to "return period" in tests

Related to Issue [WTI-897]

git-svn-id: https://repos.deltares.nl/repos/WettelijkToetsInstrumentarium/trunk@6905 5a3db67b-de53-47b5-99c8-a1c30a6650e2

Former-commit-id: dafa27cc7d0aa3e142e1574957acefb7330f99f2

Former-commit-id: 069233ced8f4423accc35ea21b30e93cc8a95eea

Options
    • -4
    • +24
    /Core/Common/src/Core.Common.Utils/StatisticsConverter.cs
    • -3
    • +3
    /Core/Common/test/Core.Common.Utils.Test/StatisticsConverterTest.cs
    • -5
    • +5
    /Ringtoets/Common/src/Ringtoets.Common.Service/RingtoetsCommonDataCalculationService.cs
    • -7
    • +7
    /Ringtoets/Common/test/Ringtoets.Common.Service.Test/DesignWaterLevelCalculationActivityTest.cs
    • -5
    • +5
    /Ringtoets/Common/test/Ringtoets.Common.Service.Test/RingtoetsCommonDataCalculationServiceTest.cs
    • -7
    • +7
    /Ringtoets/Common/test/Ringtoets.Common.Service.Test/WaveHeightCalculationActivityTest.cs
    • -4
    • +4
    /Ringtoets/GrassCoverErosionOutwards/test/Ringtoets.GrassCoverErosionOutwards.Forms.Test/TreeNodeInfos/GrassCoverErosionOutwardsDesignWaterLevelLocationsContextTreeNodeInfoTest.cs
    • -4
    • +4
    /Ringtoets/GrassCoverErosionOutwards/test/Ringtoets.GrassCoverErosionOutwards.Forms.Test/TreeNodeInfos/GrassCoverErosionOutwardsWaveHeightLocationsContextTreeNodeInfoTest.cs
    • -1
    • +1
    /Ringtoets/HydraRing/src/Ringtoets.HydraRing.Calculation/Data/Input/ReliabilityIndexCalculationInput.cs
    • -1
    • +1
    /Ringtoets/HydraRing/src/Ringtoets.HydraRing.Calculation/Data/Input/WaveConditions/WaveConditionsCalculationInput.cs
    • -3
    • +3
    /Ringtoets/HydraRing/test/Ringtoets.HydraRing.Calculation.Test/Data/Input/Hydraulics/AssessmentLevelCalculationInputTest.cs
    • -3
    • +3
    /Ringtoets/HydraRing/test/Ringtoets.HydraRing.Calculation.Test/Data/Input/Hydraulics/DikeHeightCalculationInputTest.cs
    • -4
    • +3
    /Ringtoets/HydraRing/test/Ringtoets.HydraRing.Calculation.Test/Data/Input/Hydraulics/DunesBoundaryConditionsCalculationInputTest.cs
    • -3
    • +3
    /Ringtoets/HydraRing/test/Ringtoets.HydraRing.Calculation.Test/Data/Input/Hydraulics/HydraulicLoadsCalculationInputTest.cs
    • -3
    • +3
    /Ringtoets/HydraRing/test/Ringtoets.HydraRing.Calculation.Test/Data/Input/Hydraulics/OvertoppingRateCalculationInputTest.cs
  16. … 5 more files in changeset.
4:14 pm

bouvrie <bouvrie@example.com>

* Refactored logic statements involging && and || to have improved outlining. * Removed nesting of 'remarks' clause within 'summary' clause in XML docs. * Fixed typos. * Replaced empty array initializers with empty array constructor. Related to Issue [WTI-958]

git-svn-id: https://repos.deltares.nl/repos/WettelijkToetsInstrumentarium/trunk@6904 5a3db67b-de53-47b5-99c8-a1c30a6650e2

Former-commit-id: ca4049cc579a9c57aad121ecda5a5f8d606602e4

Former-commit-id: 2f244a555467f8b9e7467504077deb9f096e390a

Options
    • -6
    • +6
    /Core/Common/src/Core.Common.Controls.TreeView/DragDropHandler.cs
    • -2
    • +2
    /Core/Common/src/Core.Common.Controls.TreeView/TreeViewControl.cs
    • -5
    • +5
    /Core/Components/src/Core.Components.DotSpatial/Converter/MapDataConverter.cs
    • -2
    • +1
    /Core/Components/src/Core.Components.DotSpatial/Converter/MapLineDataConverter.cs
    • -2
    • +1
    /Core/Components/src/Core.Components.DotSpatial/Converter/MapPolygonDataConverter.cs
    • -3
    • +3
    /Ringtoets/Common/src/Ringtoets.Common.Forms/PropertyClasses/UseBreakWaterProperties.cs
    • -2
    • +2
    /Ringtoets/Common/src/Ringtoets.Common.Forms/Views/RingtoetsMapDataFeaturesFactory.cs
    • -2
    • +1
    /Ringtoets/Common/test/Ringtoets.Common.Forms.Test/PresentationObjects/CategoryTreeFolderTest.cs
    • -4
    • +4
    /Ringtoets/HydraRing/src/Ringtoets.HydraRing.Calculation/Services/HydraRingConfigurationService.cs
    • -3
    • +3
    /Ringtoets/Integration/src/Ringtoets.Integration.Plugin/RingtoetsPlugin.cs
    • -6
    • +6
    /Ringtoets/Revetment/src/Ringtoets.Revetment.Data/WaveConditionsInput.cs
3:43 pm

Robert Tangerman <robert.tangerman@deltares.nl>

Set hydraulicBoundaryDatabase observer when it's not set yet in the view. Related to Issue [WTI-957]

git-svn-id: https://repos.deltares.nl/repos/WettelijkToetsInstrumentarium/trunk@6903 5a3db67b-de53-47b5-99c8-a1c30a6650e2

Former-commit-id: 76a0fd9dfddc8ce70431bc1ea73d02f616fb8c97

Former-commit-id: f991634e0672541f223b5544caec53b59a1deb16

Options
    • -1
    • +8
    /Ringtoets/ClosingStructures/src/Ringtoets.ClosingStructures.Forms/Views/ClosingStructuresFailureMechanismView.cs
    • -6
    • +13
    /Ringtoets/Common/src/Ringtoets.Common.Forms/Views/FailureMechanismView.cs
    • -1
    • +8
    /Ringtoets/GrassCoverErosionInwards/src/Ringtoets.GrassCoverErosionInwards.Forms/Views/GrassCoverErosionInwardsFailureMechanismView.cs
    • -1
    • +8
    /Ringtoets/GrassCoverErosionOutwards/src/Ringtoets.GrassCoverErosionOutwards.Forms/Views/GrassCoverErosionOutwardsFailureMechanismView.cs
    • -1
    • +8
    /Ringtoets/HeightStructures/src/Ringtoets.HeightStructures.Forms/Views/HeightStructuresFailureMechanismView.cs
    • -1
    • +8
    /Ringtoets/Integration/src/Ringtoets.Integration.Forms/Views/AssessmentSectionView.cs
    • -1
    • +8
    /Ringtoets/Piping/src/Ringtoets.Piping.Forms/Views/PipingFailureMechanismView.cs
    • -1
    • +8
    /Ringtoets/StabilityPointStructures/src/Ringtoets.StabilityPointStructures.Forms/Views/StabilityPointStructuresFailureMechanismView.cs
    • -1
    • +8
    /Ringtoets/StabilityStoneCover/src/Ringtoets.StabilityStoneCover.Forms/Views/StabilityStoneCoverFailureMechanismView.cs
    • -1
    • +8
    /Ringtoets/WaveImpactAsphaltCover/src/Ringtoets.WaveImpactAsphaltCover.Forms/Views/WaveImpactAsphaltCoverFailureMechanismView.cs
3:28 pm

bouvrie <bouvrie@example.com>

* Fixed typos. * Refactored common code to new methods. * Fixed correct responsibility of filtering out duplicate observable notification. * Improved XML docs. * Improved returning all affected objects by some 'clear' methods of DataSynchronisationService classes. * Readded license header. * Simplified RhinoMock argument restraints. * Fixed test filename. * Fixed test structure of Integration tests conform coding conventions. Related to Issue [WTI-440]

git-svn-id: https://repos.deltares.nl/repos/WettelijkToetsInstrumentarium/trunk@6902 5a3db67b-de53-47b5-99c8-a1c30a6650e2

Former-commit-id: 575f790757a486d0efa5b560c8170dc02cefb1f5

Former-commit-id: 8f94dd18882a6eaa65a1a9ca5592839b0d8b8084

Options
    • -2
    • +2
    /Core/Common/src/Core.Common.Base/IO/FileImporterBase.cs
    • -19
    • +12
    /Ringtoets/ClosingStructures/src/Ringtoets.ClosingStructures.Service/ClosingStructuresDataSynchronizationService.cs
    • -22
    • +31
    /Ringtoets/ClosingStructures/test/Ringtoets.ClosingStructures.Service.Test/ClosingStructureDataSynchronizationServiceTest.cs
    • -1
    • +22
    /Ringtoets/Common/src/Ringtoets.Common.IO/Properties/Resources.Designer.cs
    • -1
    • +1
    /Ringtoets/Common/src/Ringtoets.Common.IO/ReferenceLines/ReferenceLineImporter.cs
    • -0
    • +24
    /Ringtoets/Common/src/Ringtoets.Common.Service/RingtoetsCommonDataSynchronizationService.cs
    • -0
    • +1
    /Ringtoets/Common/src/Ringtoets.Common.Utils/StructuresHelper.cs
    • -18
    • +10
    /Ringtoets/Common/test/Ringtoets.Common.IO.Test/ReferenceLines/ReferenceLineImporterTest.cs
    • -1
    • +5
    /Ringtoets/Common/test/Ringtoets.Common.Service.Test/Ringtoets.Common.Service.Test.csproj
    • -181
    • +0
    /Ringtoets/Common/test/Ringtoets.Common.Service.Test/RingtoetsCommonDataSynchronizationServices.Test.cs
    • -0
    • +234
    /Ringtoets/Common/test/Ringtoets.Common.Service.Test/RingtoetsCommonDataSynchronizationServicesTest.cs
    • -11
    • +4
    /Ringtoets/GrassCoverErosionInwards/src/Ringtoets.GrassCoverErosionInwards.Service/GrassCoverErosionInwardsDataSynchronizationService.cs
    • -9
    • +20
    /Ringtoets/GrassCoverErosionInwards/test/Ringtoets.GrassCoverErosionInwards.Utils.Test/GrassCoverErosionInwardsDataSynchronizationServiceTest.cs
    • -11
    • +4
    /Ringtoets/GrassCoverErosionOutwards/src/Ringtoets.GrassCoverErosionOutwards.Service/GrassCoverErosionOutwardsDataSynchronizationService.cs
    • -11
    • +17
    /Ringtoets/GrassCoverErosionOutwards/test/Ringtoets.GrassCoverErosionOutwards.Service.Test/GrassCoverErosionOutwardsDataSynchronizationServiceTest.cs
  16. … 19 more files in changeset.
3:26 pm

Robert Tangerman <robert.tangerman@deltares.nl>

Made SelectedMetaDataAttribute readonly when no meta data is present. Related to Issue [WTI-957]

git-svn-id: https://repos.deltares.nl/repos/WettelijkToetsInstrumentarium/trunk@6901 5a3db67b-de53-47b5-99c8-a1c30a6650e2

Former-commit-id: 6661d50e0682d7c813d4a1345735e4fec57d53ab

Former-commit-id: c14729c1bdb729672044e19d30734c2ec096d8b0

Options
    • -0
    • +1
    /Core/Plugins/src/Core.Plugins.Map/PropertyClasses/FeatureBasedMapDataProperties.cs
    • -3
    • +11
    /Core/Plugins/test/Core.Plugins.Map.Test/PropertyClasses/FeatureBasedMapDataPropertiesTest.cs
3:23 pm

Robert Tangerman <robert.tangerman@deltares.nl>

Fixed problem with typing in selectionEditor. Related to Issue [WTI-957]

git-svn-id: https://repos.deltares.nl/repos/WettelijkToetsInstrumentarium/trunk@6900 5a3db67b-de53-47b5-99c8-a1c30a6650e2

Former-commit-id: 76f35ac3785b292e03518267644c68776a5ce919

Former-commit-id: a9ee13a32c658300b596c662531f398b6ebe5a51

Options
    • -0
    • +1
    /Core/Plugins/src/Core.Plugins.Map/Core.Plugins.Map.csproj
    • -5
    • +5
    /Core/Plugins/src/Core.Plugins.Map/PropertyClasses/FeatureBasedMapDataProperties.cs
    • -5
    • +6
    /Core/Plugins/src/Core.Plugins.Map/PropertyClasses/IHasMetaData.cs
    • -3
    • +3
    /Core/Plugins/src/Core.Plugins.Map/UITypeEditors/MetaDataAttributeEditor.cs
    • -0
    • +93
    /Core/Plugins/src/Core.Plugins.Map/UITypeEditors/SelectableMetaDataAttribute.cs
    • -0
    • +1
    /Core/Plugins/test/Core.Plugins.Map.Test/Core.Plugins.Map.Test.csproj
    • -3
    • +7
    /Core/Plugins/test/Core.Plugins.Map.Test/PropertyClasses/FeatureBasedMapDataPropertiesTest.cs
    • -27
    • +43
    /Core/Plugins/test/Core.Plugins.Map.Test/UITypeEditors/MetaDataAttributeEditorTest.cs
    • -0
    • +181
    /Core/Plugins/test/Core.Plugins.Map.Test/UITypeEditors/SelectableMetaDataAttributeTest.cs
    • -1
    • +1
    /Ringtoets/Common/src/Ringtoets.Common.Forms/UITypeEditors/SelectableHydraulicBoundaryLocation.cs
3:22 pm

Elmar Kleijn

Extended IMapDataConverter with ConvertLayerFeatures and ConvertLayerProperties methods Related to Issue [WTI-1018]

git-svn-id: https://repos.deltares.nl/repos/WettelijkToetsInstrumentarium/trunk@6899 5a3db67b-de53-47b5-99c8-a1c30a6650e2

Former-commit-id: ac646c5504f67509ada51e07e066968ca98ef881

Former-commit-id: cc36abcba6c21063eb21cc7d363d8ada4956294c

Options
    • -0
    • +14
    /Core/Components/src/Core.Components.DotSpatial/Converter/IMapDataConverter.cs
    • -0
    • +28
    /Core/Components/src/Core.Components.DotSpatial/Converter/MapDataConverter.cs
    • -2
    • +2
    /Core/Components/src/Core.Components.DotSpatial/Converter/MapLineDataConverter.cs
    • -2
    • +2
    /Core/Components/src/Core.Components.DotSpatial/Converter/MapPointDataConverter.cs
    • -2
    • +2
    /Core/Components/src/Core.Components.DotSpatial/Converter/MapPolygonDataConverter.cs
    • -0
    • +10
    /Core/Components/test/Core.Components.DotSpatial.Test/Converter/MapDataConverterTest.cs
3:12 pm

Dennis Tang <dennis.tang@deltares.nl>

(Editorial) - Ran DeltaresClean to cleanup affected files of revision 6896 Related to Issue [WTI-989]

git-svn-id: https://repos.deltares.nl/repos/WettelijkToetsInstrumentarium/trunk@6898 5a3db67b-de53-47b5-99c8-a1c30a6650e2

Former-commit-id: e48118617685438924b7d392135a25978f0d489d

Former-commit-id: e12865f39101cbf083cc5bd7d3e60e005aa9e49d

Options
    • -10
    • +9
    /Ringtoets/Common/test/Ringtoets.Common.Forms.Test/UITypeEditors/SelectableHydraulicBoundaryLocationTest.cs
    • -1
    • +1
    /Ringtoets/Revetment/test/Ringtoets.Revetment.Forms.Test/PropertyClasses/WaveConditionsInputContextPropertiesTest.cs
3:07 pm

Dennis Tang <dennis.tang@deltares.nl>

- Renamed tests to reflect the situation better - Added some additional code in the SelectionEditor based on janssen input - Reverted proposed refactoring of selectableHydraulicBoundaryLocation, because distance was not visible anymore in the dropdown list after selecting an entry.

Reverse merged revision(s) 6890, 6854-6853 from trunk:

Incorporated comments kleijn, added missing tests to improve coverage:

- GetReferenceLocation()

- GetHydraulicBoundaryLocations()

Related to Issue [WTI-989]

........

Incorporated comments review 1223:

- Refactored IHasHydraulicBoundaryLocationProperty such that implemented classes do not depend on SelectableHydraulicBoundaryLocation

- Moved logic for generating the list of HBL to display in the dropdown menu to the HydraulicBoundaryLocationEditor. Added additional tests to verify behaviour

Related to Issue [WTI-989]

........

Incorporated comments review 1223:

- Extended SelectionEditor to convert from the PresentationType to a DomainType

Related to Issue [WTI-989]

........

git-svn-id: https://repos.deltares.nl/repos/WettelijkToetsInstrumentarium/trunk@6897 5a3db67b-de53-47b5-99c8-a1c30a6650e2

Former-commit-id: cfd7916a4cf41ecb058a1c35acee2e5cb966b362

Former-commit-id: f2caaca84d257cc42a597b921f552c644c6a1434

Options
    • -89
    • +36
    /Core/Common/src/Core.Common.Gui/UITypeEditors/SelectionEditor.cs
    • -63
    • +8
    /Core/Common/test/Core.Common.Gui.Test/UITypeEditors/SelectionEditorTest.cs
    • -11
    • +11
    /Ringtoets/Common/src/Ringtoets.Common.Forms/PropertyClasses/StructuresInputBaseProperties.cs
    • -28
    • +5
    /Ringtoets/Common/src/Ringtoets.Common.Forms/UITypeEditors/HydraulicBoundaryLocationEditor.cs
    • -10
    • +3
    /Ringtoets/Common/src/Ringtoets.Common.Forms/UITypeEditors/IHasHydraulicBoundaryLocationProperty.cs
    • -93
    • +189
    /Ringtoets/Common/test/Ringtoets.Common.Forms.Test/PropertyClasses/StructuresInputBasePropertiesTest.cs
    • -158
    • +17
    /Ringtoets/Common/test/Ringtoets.Common.Forms.Test/UITypeEditors/HydraulicBoundaryLocationEditorTest.cs
    • -12
    • +12
    /Ringtoets/GrassCoverErosionInwards/src/Ringtoets.GrassCoverErosionInwards.Forms/PropertyClasses/GrassCoverErosionInwardsInputContextProperties.cs
    • -39
    • +117
    /Ringtoets/GrassCoverErosionInwards/test/Ringtoets.GrassCoverErosionInwards.Forms.Test/PropertyClasses/GrassCoverErosionInwardsInputContextPropertiesTest.cs
    • -3
    • +5
    /Ringtoets/GrassCoverErosionOutwards/test/Ringtoets.GrassCoverErosionOutwards.Forms.Test/PropertyClasses/GrassCoverErosionOutwardsWaveConditionsInputContextPropertiesTest.cs
    • -10
    • +14
    /Ringtoets/Piping/src/Ringtoets.Piping.Forms/PropertyClasses/PipingInputContextProperties.cs
    • -25
    • +110
    /Ringtoets/Piping/test/Ringtoets.Piping.Forms.Test/PropertyClasses/PipingInputContextPropertiesTest.cs
    • -13
    • +11
    /Ringtoets/Revetment/src/Ringtoets.Revetment.Forms/PropertyClasses/WaveConditionsInputContextProperties.cs
    • -31
    • +99
    /Ringtoets/Revetment/test/Ringtoets.Revetment.Forms.Test/PropertyClasses/WaveConditionsInputContextPropertiesTest.cs
    • -3
    • +5
    /Ringtoets/StabilityStoneCover/test/Ringtoets.StabilityStoneCover.Forms.Test/PropertyClasses/StabilityStoneCoverWaveConditionsInputContextPropertiesTest.cs
    • -3
    • +6
    /Ringtoets/WaveImpactAsphaltCover/test/Ringtoets.WaveImpactAsphaltCover.Forms.Test/PropertyClasses/WaveImpactAsphaltCoverWaveConditionsInputContextPropertiesTest.cs
2:51 pm

Elmar Kleijn

Implemented custom equality logic in GrassCoverErosionOutwardsHydraulicBoundaryLocationContext

Paired with berg_jl

Related to Issue [WTI-956]

git-svn-id: https://repos.deltares.nl/repos/WettelijkToetsInstrumentarium/trunk@6896 5a3db67b-de53-47b5-99c8-a1c30a6650e2

Former-commit-id: 16a2c48bef87bbd4165ac6784b11e307564877da

Former-commit-id: 7ed979011219d982ff444a01ef32be07b28a49df

Options
    • -0
    • +10
    /Ringtoets/GrassCoverErosionOutwards/src/Ringtoets.GrassCoverErosionOutwards.Forms/PresentationObjects/GrassCoverErosionOutwardsHydraulicBoundaryLocationContext.cs
    • -0
    • +108
    /Ringtoets/GrassCoverErosionOutwards/test/Ringtoets.GrassCoverErosionOutwards.Forms.Test/PresentationObjects/GrassCoverErosionOutwardsHydraulicBoundaryLocationContextTest.cs
2:29 pm

Elmar Kleijn

Added TMapFeatureLayer type to MapDataConverter Related to Issue [WTI-1018]

git-svn-id: https://repos.deltares.nl/repos/WettelijkToetsInstrumentarium/trunk@6895 5a3db67b-de53-47b5-99c8-a1c30a6650e2

Former-commit-id: a938ccef76ee62592ce2a9931d6420c0efb4cf7c

Former-commit-id: 98651867dbfabd56e9b08e616b018c986a1a76d1

Options
    • -16
    • +25
    /Core/Components/src/Core.Components.DotSpatial/Converter/MapDataConverter.cs
    • -3
    • +2
    /Core/Components/src/Core.Components.DotSpatial/Converter/MapLineDataConverter.cs
    • -3
    • +2
    /Core/Components/src/Core.Components.DotSpatial/Converter/MapPointDataConverter.cs
    • -3
    • +2
    /Core/Components/src/Core.Components.DotSpatial/Converter/MapPolygonDataConverter.cs
    • -2
    • +3
    /Core/Components/test/Core.Components.DotSpatial.Test/Converter/MapDataConverterTest.cs
    • -1
    • +1
    /Core/Components/test/Core.Components.DotSpatial.Test/Converter/MapLineDataConverterTest.cs
    • -1
    • +1
    /Core/Components/test/Core.Components.DotSpatial.Test/Converter/MapPointDataConverterTest.cs
    • -1
    • +1
    /Core/Components/test/Core.Components.DotSpatial.Test/Converter/MapPolygonDataConverterTest.cs
11:56 am

Elmar Kleijn

Slightly adapted map data converters Related to Issue [WTI-1018]

git-svn-id: https://repos.deltares.nl/repos/WettelijkToetsInstrumentarium/trunk@6894 5a3db67b-de53-47b5-99c8-a1c30a6650e2

Former-commit-id: e1283fadcef782fa0320ed6721f6ac84407d0685

Former-commit-id: ca6eeb0377ac868a32ace2afb388344ce3c5e505

Options
    • -5
    • +5
    /Core/Components/src/Core.Components.DotSpatial/Converter/MapDataConverter.cs
    • -22
    • +22
    /Core/Components/src/Core.Components.DotSpatial/Converter/MapLineDataConverter.cs
    • -23
    • +23
    /Core/Components/src/Core.Components.DotSpatial/Converter/MapPointDataConverter.cs
    • -23
    • +24
    /Core/Components/src/Core.Components.DotSpatial/Converter/MapPolygonDataConverter.cs
11:54 am

Robert Tangerman <robert.tangerman@deltares.nl>

Improvements after review. Related to Issue [WTI-958]

git-svn-id: https://repos.deltares.nl/repos/WettelijkToetsInstrumentarium/trunk@6893 5a3db67b-de53-47b5-99c8-a1c30a6650e2

Former-commit-id: f13c8e61044fef1f92228c90798610eaba2e9db0

Former-commit-id: ed0dfd84142c7f056222face78429e348332b912

Options
    • -0
    • +76
    /Ringtoets/Common/src/Ringtoets.Common.Forms/PresentationObjects/MapCalculationData.cs
    • -0
    • +1
    /Ringtoets/Common/src/Ringtoets.Common.Forms/Ringtoets.Common.Forms.csproj
    • -141
    • +91
    /Ringtoets/Common/src/Ringtoets.Common.Forms/Views/RingtoetsMapDataFeaturesFactory.cs
    • -0
    • +116
    /Ringtoets/Common/test/Ringtoets.Common.Forms.Test/PresentationObjects/MapCalculationDataTest.cs
    • -0
    • +1
    /Ringtoets/Common/test/Ringtoets.Common.Forms.Test/Ringtoets.Common.Forms.Test.csproj
    • -89
    • +24
    /Ringtoets/Common/test/Ringtoets.Common.Forms.Test/Views/RingtoetsMapDataFeaturesFactoryTest.cs
    • -6
    • +8
    /Ringtoets/Common/test/Ringtoets.Common.Forms.TestUtil/MapDataTestHelper.cs
    • -5
    • +6
    /Ringtoets/GrassCoverErosionInwards/src/Ringtoets.GrassCoverErosionInwards.Forms/Views/GrassCoverErosionInwardsMapDataFeatureFactory.cs
    • -4
    • +5
    /Ringtoets/GrassCoverErosionOutwards/src/Ringtoets.GrassCoverErosionOutwards.Forms/Views/GrassCoverErosionOutwardsMapDataFeaturesFactory.cs
    • -2
    • +2
    /Ringtoets/Piping/src/Ringtoets.Piping.Forms/Views/PipingFailureMechanismView.cs
    • -16
    • +23
    /Ringtoets/Piping/src/Ringtoets.Piping.Forms/Views/PipingMapDataFeaturesFactory.cs
    • -2
    • +2
    /Ringtoets/Piping/test/Ringtoets.Piping.Forms.Test/Views/PipingMapDataFeaturesFactoryTest.cs
    • -4
    • +5
    /Ringtoets/StabilityStoneCover/src/Ringtoets.StabilityStoneCover.Forms/Views/StabilityStoneCoverMapDataFeaturesFactory.cs
    • -4
    • +5
    /Ringtoets/WaveImpactAsphaltCover/src/Ringtoets.WaveImpactAsphaltCover.Forms/Views/WaveImpactAsphaltCoverMapDataFeaturesFactory.cs