Riskeer

Clone Tools

Stats

Commits this week: 0
Total Committers: 28
Last Commit: 26 Nov
Commits this week: 0

Lines of code count not available

Commit Activity

Commits By Day In Week
52 week commits volume
Commits By Day In Week
Commits by day
Commits By Day In Week
Commits by hour
Commits By Hour In Day
Commit calendar
 

Most active committers (90 days)

loading
loading
  • last updated a few seconds ago
All Commits Reviews
Constraints
Constraints: committers
 
Constraints: files
Constraints: dates
Thursday 05 Jan 2017
1:37 pm

Dennis Tang <dennis.tang@deltares.nl>

Fixed tests of the FileImporterBase and Activity: - Checks on the states are made for the 4 different paths of the Import: -- Import successful, canceled or not -- Import not successful, canceled or not - Moved logging from the activity to the importer - Added tests to assert mentioned behaviour

Related to Issue [WTI-490]

git-svn-id: https://repos.deltares.nl/repos/WettelijkToetsInstrumentarium/branches/WTI-490@7617 5a3db67b-de53-47b5-99c8-a1c30a6650e2

Former-commit-id: b54ccb13a0780daf3321fcbc02998200ae3283da

Former-commit-id: 22fd647c89a1cc3b0d4f812e4018335057f64e80

Options
    • -6
    • +52
    /Core/Common/src/Core.Common.Base/IO/FileImporterBase.cs
    • -9
    • +2
    /Core/Common/src/Core.Common.Base/Service/FileImportActivity.cs
    • -7
    • +93
    /Core/Common/test/Core.Common.Base.Test/IO/FileImporterBaseTest.cs
    • -3
    • +29
    /Core/Common/test/Core.Common.Base.Test/Service/FileImportActivityTest.cs
1:28 pm

Joël van den Berg

Added changehandler call from StabilityPointStructuresFailureMechanismProperties. Introduced constructor parameters for StabilityPointStructuresFailureMechanismProperties. Related to Issue [WTI-974]

git-svn-id: https://repos.deltares.nl/repos/WettelijkToetsInstrumentarium/trunk@7616 5a3db67b-de53-47b5-99c8-a1c30a6650e2

Former-commit-id: a670b565a1dc408222b91fe217e198227e93259b

Former-commit-id: 3226913a6a51353107cc2ec6e4e287482c953360

Options
    • -0
    • +2
    /Ringtoets/ClosingStructures/test/Ringtoets.ClosingStructures.Forms.Test/PropertyClasses/ClosingStructuresFailureMechanismPropertiesTest.cs
    • -2
    • +6
    /Ringtoets/Common/test/Ringtoets.Common.Forms.TestUtil.Test/FailureMechanismSetPropertyValueAfterConfirmationParameterTesterTest.cs
    • -0
    • +2
    /Ringtoets/GrassCoverErosionInwards/test/Ringtoets.GrassCoverErosionInwards.Forms.Test/PropertyClasses/GrassCoverErosionInwardsFailureMechanismContextPropertiesTest.cs
    • -0
    • +2
    /Ringtoets/GrassCoverErosionOutwards/test/Ringtoets.GrassCoverErosionOutwards.Forms.Test/PropertyClasses/GrassCoverErosionOutwardsFailureMechanismPropertiesTest.cs
    • -0
    • +2
    /Ringtoets/HeightStructures/test/Ringtoets.HeightStructures.Forms.Test/PropertyClasses/HeightStructuresFailureMechanismPropertiesTest.cs
    • -2
    • +41
    /Ringtoets/StabilityPointStructures/src/Ringtoets.StabilityPointStructures.Forms/PropertyClasses/StabilityPointStructuresFailureMechanismProperties.cs
    • -4
    • +3
    /Ringtoets/StabilityPointStructures/src/Ringtoets.StabilityPointStructures.Plugin/StabilityPointStructuresPlugin.cs
    • -36
    • +108
    /Ringtoets/StabilityPointStructures/test/Ringtoets.StabilityPointStructures.Forms.Test/PropertyClasses/StabilityPointStructuresFailureMechanismPropertiesTest.cs
    • -0
    • +59
    /Ringtoets/StabilityPointStructures/test/Ringtoets.StabilityPointStructures.Plugin.Test/PropertyInfos/StabilityPointStructuresFailureMechanismContextPropertyInfoTest.cs
    • -0
    • +1
    /Ringtoets/StabilityPointStructures/test/Ringtoets.StabilityPointStructures.Plugin.Test/Ringtoets.StabilityPointStructures.Plugin.Test.csproj
1:08 pm

Joël van den Berg

Added changehandler call from HeightStructuresFailureMechanismProperties. Introduced constructor parameters for HeightStructuresFailureMechanismProperties. Related to Issue [WTI-972]

git-svn-id: https://repos.deltares.nl/repos/WettelijkToetsInstrumentarium/trunk@7615 5a3db67b-de53-47b5-99c8-a1c30a6650e2

Former-commit-id: 5467e36822d320cefc795f4706a4a452b8b11026

Former-commit-id: 167ed7a2e4cf64b98ad99747abce27f1f6c9115d

Options
    • -2
    • +41
    /Ringtoets/HeightStructures/src/Ringtoets.HeightStructures.Forms/PropertyClasses/HeightStructuresFailureMechanismProperties.cs
    • -4
    • +3
    /Ringtoets/HeightStructures/src/Ringtoets.HeightStructures.Plugin/HeightStructuresPlugin.cs
    • -37
    • +110
    /Ringtoets/HeightStructures/test/Ringtoets.HeightStructures.Forms.Test/PropertyClasses/HeightStructuresFailureMechanismPropertiesTest.cs
    • -0
    • +59
    /Ringtoets/HeightStructures/test/Ringtoets.HeightStructures.Plugin.Test/PropertyInfos/HeightStructuresFailureMechanismContextPropertyInfoTest.cs
    • -0
    • +1
    /Ringtoets/HeightStructures/test/Ringtoets.HeightStructures.Plugin.Test/Ringtoets.HeightStructures.Plugin.Test.csproj
1:08 pm

Robert Tangerman <robert.tangerman@deltares.nl>

Changes after review. Related to Issue [WTI-861]

git-svn-id: https://repos.deltares.nl/repos/WettelijkToetsInstrumentarium/trunk@7614 5a3db67b-de53-47b5-99c8-a1c30a6650e2

Former-commit-id: 06e5c3acb53e7d04b73f8a5b228c7bfda67ec726

Former-commit-id: 531fa12da465b3fceb56d7ff9335216eb02d94ee

Options
    • -3
    • +3
    /Ringtoets/Common/src/Ringtoets.Common.IO/DikeProfiles/DikeProfileDataReader.cs
    • -2
    • +2
    /Ringtoets/Common/src/Ringtoets.Common.IO/FileImporters/ProfilesImporter.cs
    • -4
    • +4
    /Ringtoets/Common/test/Ringtoets.Common.IO.Test/DikeProfiles/DikeProfileDataReaderTest.cs
12:11 pm

Joël van den Berg

Made use of nameof operator. Removed redundancy. Made types explicit in tests. Related to Issue [WTI-973]

git-svn-id: https://repos.deltares.nl/repos/WettelijkToetsInstrumentarium/trunk@7613 5a3db67b-de53-47b5-99c8-a1c30a6650e2

Former-commit-id: ae0a1774c3921e4893681196f73a6bfa1f084bc4

Former-commit-id: 0304bd841817e0d89abbbb8792162fb125eedae0

Options
    • -2
    • +2
    /Core/Common/test/Core.Common.Geometry.Test/AdvancedMath2DTest.cs
    • -1
    • +1
    /Core/Common/test/Core.Common.IO.Test/Readers/IDataReaderExtensionsTest.cs
    • -1
    • +0
    /Ringtoets/ClosingStructures/src/Ringtoets.ClosingStructures.Forms/PropertyClasses/ClosingStructuresFailureMechanismProperties.cs
    • -2
    • +2
    /Ringtoets/ClosingStructures/test/Ringtoets.ClosingStructures.Forms.Test/PropertyClasses/ClosingStructuresFailureMechanismPropertiesTest.cs
    • -1
    • +1
    /Ringtoets/ClosingStructures/test/Ringtoets.ClosingStructures.Forms.Test/PropertyClasses/ClosingStructuresInputContextPropertiesTest.cs
    • -0
    • +1
    /Ringtoets/ClosingStructures/test/Ringtoets.ClosingStructures.Plugin.Test/PropertyInfos/ClosingStructuresInputContextPropertyInfoTest.cs
    • -5
    • +5
    /Ringtoets/Common/src/Ringtoets.Common.Data/FailureMechanism/FailureMechanismBase.cs
    • -27
    • +27
    /Ringtoets/Common/src/Ringtoets.Common.Forms/Properties/Resources.Designer.cs
    • -3
    • +3
    /Ringtoets/Common/src/Ringtoets.Common.Forms/Properties/Resources.resx
    • -178
    • +169
    /Ringtoets/Common/src/Ringtoets.Common.Forms/PropertyClasses/StructuresInputBaseProperties.cs
    • -7
    • +6
    /Ringtoets/Common/src/Ringtoets.Common.Forms/PropertyClasses/VariationCoefficientDistributionPropertiesBase.cs
    • -1
    • +1
    /Ringtoets/Common/src/Ringtoets.Common.Service/RingtoetsCommonDataSynchronizationService.cs
    • -3
    • +3
    /Ringtoets/Common/test/Ringtoets.Common.Forms.Test/FailureMechanismPropertyChangeHandlerTest.cs
    • -15
    • +15
    /Ringtoets/Common/test/Ringtoets.Common.Forms.Test/PropertyClasses/StructuresInputBasePropertiesTest.cs
    • -3
    • +3
    /Ringtoets/GrassCoverErosionOutwards/test/Ringtoets.GrassCoverErosionOutwards.Forms.Test/GrassCoverErosionOutwardsFailureMechanismPropertyChangeHandlerTest.cs
  16. … 6 more files in changeset.
12:05 pm

Robert Tangerman <robert.tangerman@deltares.nl>

Fixed double run tests.

git-svn-id: https://repos.deltares.nl/repos/WettelijkToetsInstrumentarium/trunk@7612 5a3db67b-de53-47b5-99c8-a1c30a6650e2

Former-commit-id: dc4e55be9282c8001c596157213c12aaa831eac2

Former-commit-id: 9555ecda86a302f263b7998742ec7db133f77baa

Options
    • -12
    • +12
    /Ringtoets/ClosingStructures/test/Ringtoets.ClosingStructures.Forms.Test/PropertyClasses/ClosingStructuresInputContextPropertiesTest.cs
    • -3
    • +3
    /Ringtoets/GrassCoverErosionInwards/test/Ringtoets.GrassCoverErosionInwards.Forms.Test/PropertyClasses/GrassCoverErosionInwardsFailureMechanismContextPropertiesTest.cs
    • -14
    • +14
    /Ringtoets/GrassCoverErosionInwards/test/Ringtoets.GrassCoverErosionInwards.Forms.Test/PropertyClasses/GrassCoverErosionInwardsInputContextPropertiesTest.cs
11:23 am

Joël van den Berg

Added confirmation inquiry to other failure mechanisms. Removed unused methods from the IFailureMechanismPropertyChangeHandler. Related to Issue [WTI-967]

git-svn-id: https://repos.deltares.nl/repos/WettelijkToetsInstrumentarium/trunk@7610 5a3db67b-de53-47b5-99c8-a1c30a6650e2

Former-commit-id: 8e8ef9f7a0da1e8c09547d90dfcbd2c62f1c5042

Former-commit-id: 7239e460f2d71689a1576aa654c45bcce9557ad5

Options
    • -13
    • +14
    /Ringtoets/ClosingStructures/src/Ringtoets.ClosingStructures.Forms/PropertyClasses/ClosingStructuresFailureMechanismProperties.cs
    • -1
    • +1
    /Ringtoets/ClosingStructures/src/Ringtoets.ClosingStructures.Plugin/ClosingStructuresPlugin.cs
    • -68
    • +26
    /Ringtoets/ClosingStructures/test/Ringtoets.ClosingStructures.Forms.Test/PropertyClasses/ClosingStructuresFailureMechanismPropertiesTest.cs
    • -52
    • +64
    /Ringtoets/Common/src/Ringtoets.Common.Forms/FailureMechanismPropertyChangeHandler.cs
    • -16
    • +0
    /Ringtoets/Common/src/Ringtoets.Common.Forms/PropertyClasses/IFailureMechanismPropertyChangeHandler.cs
    • -94
    • +16
    /Ringtoets/Common/test/Ringtoets.Common.Forms.Test/FailureMechanismPropertyChangeHandlerTest.cs
    • -14
    • +14
    /Ringtoets/GrassCoverErosionInwards/src/Ringtoets.GrassCoverErosionInwards.Forms/PropertyClasses/GrassCoverErosionInwardsFailureMechanismContextProperties.cs
    • -1
    • +3
    /Ringtoets/GrassCoverErosionInwards/src/Ringtoets.GrassCoverErosionInwards.Plugin/GrassCoverErosionInwardsPlugin.cs
    • -65
    • +21
    /Ringtoets/GrassCoverErosionInwards/test/Ringtoets.GrassCoverErosionInwards.Forms.Test/PropertyClasses/GrassCoverErosionInwardsFailureMechanismContextPropertiesTest.cs
    • -3
    • +8
    /Ringtoets/GrassCoverErosionOutwards/src/Ringtoets.GrassCoverErosionOutwards.Forms/GrassCoverErosionOutwardsFailureMechanismPropertyChangeHandler.cs
    • -20
    • +18
    /Ringtoets/GrassCoverErosionOutwards/src/Ringtoets.GrassCoverErosionOutwards.Forms/PropertyClasses/GrassCoverErosionOutwardsFailureMechanismProperties.cs
    • -55
    • +93
    /Ringtoets/GrassCoverErosionOutwards/test/Ringtoets.GrassCoverErosionOutwards.Forms.Test/GrassCoverErosionOutwardsFailureMechanismPropertyChangeHandlerTest.cs
    • -61
    • +24
    /Ringtoets/GrassCoverErosionOutwards/test/Ringtoets.GrassCoverErosionOutwards.Forms.Test/PropertyClasses/GrassCoverErosionOutwardsFailureMechanismPropertiesTest.cs
    • -2
    • +2
    /Ringtoets/Piping/src/Ringtoets.Piping.Forms/PropertyClasses/PipingFailureMechanismContextProperties.cs
10:25 am

Marten Janssen <marten.janssen@deltares.nl>

Fixed typo in casing paired with bouvrie

Related to Issue [WTI-300]

git-svn-id: https://repos.deltares.nl/repos/WettelijkToetsInstrumentarium/trunk@7609 5a3db67b-de53-47b5-99c8-a1c30a6650e2

Former-commit-id: b39b8dbc35817f35bdc70ea2432dcce8c58a0eed

Former-commit-id: f1d3011d197454d0e57d5acb8bb68a7cc2008f36

Options
    • -1
    • +1
    /Core/Components/test/Core.Components.DotSpatial.Forms.Test/MapControlTest.cs
10:10 am

Joël van den Berg

Introduced FailureMechanismSetPropertyValueAfterConfirmationParameterTester, which is an implementation of the IFailureMechanismPropertyChangeHandler that can be used for testing whether the SetPropertyValueAfterConfirmationParameter method has been called with correct parameters. Replaced the stub in PropertyClasses/PipingFailureMechanismContextPropertiesTest with instances of this class. Related to Issue [WTI-967]

git-svn-id: https://repos.deltares.nl/repos/WettelijkToetsInstrumentarium/trunk@7608 5a3db67b-de53-47b5-99c8-a1c30a6650e2

Former-commit-id: 1620d4cfff387bab836d6faffb122335d9f9fb52

Former-commit-id: d31f4847bca00a60887b70a0b3626fb464eba23b

Options
    • -0
    • +113
    /Ringtoets/Common/test/Ringtoets.Common.Forms.TestUtil.Test/FailureMechanismSetPropertyValueAfterConfirmationParameterTesterTest.cs
    • -0
    • +9
    /Ringtoets/Common/test/Ringtoets.Common.Forms.TestUtil.Test/Ringtoets.Common.Forms.TestUtil.Test.csproj
    • -0
    • +71
    /Ringtoets/Common/test/Ringtoets.Common.Forms.TestUtil/FailureMechanismSetPropertyValueAfterConfirmationParameterTester.cs
    • -0
    • +5
    /Ringtoets/Common/test/Ringtoets.Common.Forms.TestUtil/Ringtoets.Common.Forms.TestUtil.csproj
    • -35
    • +11
    /Ringtoets/Piping/test/Ringtoets.Piping.Forms.Test/PropertyClasses/PipingFailureMechanismContextPropertiesTest.cs
10:02 am

Marten Janssen <marten.janssen@deltares.nl>

Review suggestions implemented paired with bouvrie Related to Issue [WTI-300]

git-svn-id: https://repos.deltares.nl/repos/WettelijkToetsInstrumentarium/trunk@7607 5a3db67b-de53-47b5-99c8-a1c30a6650e2

Former-commit-id: 2dac35bc9cf7f9a67d0b639268195ef33bc5399f

Former-commit-id: e59b3214abc66e2d40d23410d0d2ef31ed35f909

Options
    • -2
    • +2
    /Core/Components/src/Core.Components.DotSpatial.Forms/MapControl.cs
    • -6
    • +5
    /Core/Components/test/Core.Components.DotSpatial.Forms.Test/MapControlTest.cs
    • -2
    • +2
    /Core/Plugins/src/Core.Plugins.Map/Legend/MapLegendController.cs
    • -1
    • +1
    /Core/Plugins/src/Core.Plugins.Map/Legend/MapLegendView.cs
    • -1
    • +0
    /Core/Plugins/test/Core.Plugins.Map.Test/Legend/MapLegendViewTest.cs
    • -1
    • +0
    /Core/Plugins/test/Core.Plugins.Map.Test/Legend/MapLineDataTreeNodeInfoTest.cs
9:58 am

Robert Tangerman <robert.tangerman@deltares.nl>

Changed the log message for when failure mechanism contribution is zero. Related to Issue [WTI-777]

git-svn-id: https://repos.deltares.nl/repos/WettelijkToetsInstrumentarium/trunk@7606 5a3db67b-de53-47b5-99c8-a1c30a6650e2

Former-commit-id: c77e204f8e881e2c6155133b7acf54832702ee0f

Former-commit-id: ef70a113ba014154b93c39241fec8aec9f16f9c4

Options
    • -4
    • +1
    /Core/Common/src/Core.Common.Base/Service/Activity.cs
    • -1
    • +1
    /Ringtoets/DuneErosion/src/Ringtoets.DuneErosion.Service/DuneErosionBoundaryCalculationService.cs
    • -1
    • +1
    /Ringtoets/DuneErosion/src/Ringtoets.DuneErosion.Service/Properties/Resources.Designer.cs
    • -1
    • +1
    /Ringtoets/DuneErosion/src/Ringtoets.DuneErosion.Service/Properties/Resources.resx
    • -1
    • +1
    /Ringtoets/DuneErosion/test/Ringtoets.DuneErosion.Integration.Test/DuneErosionBoundaryCalculationActivityIntegrationTest.cs
    • -1
    • +1
    /Ringtoets/DuneErosion/test/Ringtoets.DuneErosion.Service.Test/DuneErosionBoundaryCalculationServiceTest.cs
9:12 am

Robert Tangerman <robert.tangerman@deltares.nl>

Added documentation for Hydra-Ring calculation process. Related to Issue [WTI-777]

git-svn-id: https://repos.deltares.nl/repos/WettelijkToetsInstrumentarium/trunk@7605 5a3db67b-de53-47b5-99c8-a1c30a6650e2

Former-commit-id: e5cf1d8d3a806018f43ab7bc2a0a7bd9390af16b

Former-commit-id: 70a9cfa92619125137e1418a1dede18d579bff46

Options
    • -3
    • +16
    /Ringtoets/ClosingStructures/src/Ringtoets.ClosingStructures.Service/ClosingStructuresCalculationService.cs
    • -2
    • +15
    /Ringtoets/Common/src/Ringtoets.Common.Service/DesignWaterLevelCalculationService.cs
    • -2
    • +17
    /Ringtoets/Common/src/Ringtoets.Common.Service/WaveHeightCalculationService.cs
    • -2
    • +15
    /Ringtoets/DuneErosion/src/Ringtoets.DuneErosion.Service/DuneErosionBoundaryCalculationService.cs
    • -2
    • +50
    /Ringtoets/GrassCoverErosionInwards/src/Ringtoets.GrassCoverErosionInwards.Service/GrassCoverErosionInwardsCalculationService.cs
    • -3
    • +17
    /Ringtoets/HeightStructures/src/Ringtoets.HeightStructures.Service/HeightStructuresCalculationService.cs
    • -0
    • +46
    /Ringtoets/HydraRing/src/Ringtoets.HydraRing.Calculation/Calculator/HydraRingCalculatorBase.cs
    • -0
    • +19
    /Ringtoets/HydraRing/src/Ringtoets.HydraRing.Calculation/Calculator/IDesignWaterLevelCalculator.cs
    • -0
    • +19
    /Ringtoets/HydraRing/src/Ringtoets.HydraRing.Calculation/Calculator/IDikeHeightCalculator.cs
    • -0
    • +19
    /Ringtoets/HydraRing/src/Ringtoets.HydraRing.Calculation/Calculator/IDunesBoundaryConditionsCalculator.cs
    • -0
    • +19
    /Ringtoets/HydraRing/src/Ringtoets.HydraRing.Calculation/Calculator/IOvertoppingCalculator.cs
    • -0
    • +19
    /Ringtoets/HydraRing/src/Ringtoets.HydraRing.Calculation/Calculator/IStructuresClosureCalculator.cs
    • -0
    • +19
    /Ringtoets/HydraRing/src/Ringtoets.HydraRing.Calculation/Calculator/IStructuresOvertoppingCalculator.cs
    • -0
    • +19
    /Ringtoets/HydraRing/src/Ringtoets.HydraRing.Calculation/Calculator/IStructuresStabilityPointCalculator.cs
    • -0
    • +19
    /Ringtoets/HydraRing/src/Ringtoets.HydraRing.Calculation/Calculator/IWaveConditionsCosineCalculator.cs
  16. … 5 more files in changeset.
9:02 am

Joël van den Berg

Moved SetPropertyValueAfterConfirmation to the FailureMechanismPropertyChangeHandler implementation (and defined method in interface), making it easier to test. Removed the responsibility of notifying affected objects, making this the responsibility of the caller. Related to Issue [WTI-967]

git-svn-id: https://repos.deltares.nl/repos/WettelijkToetsInstrumentarium/trunk@7604 5a3db67b-de53-47b5-99c8-a1c30a6650e2

Former-commit-id: c740892dac12b46cc6de6bf0342fe36d2b079dc6

Former-commit-id: 1c9e4743e7ec7b9d47d4acfa1e0693fe19dea07e

Options
    • -14
    • +10
    /Ringtoets/Common/src/Ringtoets.Common.Forms/FailureMechanismPropertyChangeHandler.cs
    • -11
    • +0
    /Ringtoets/Common/src/Ringtoets.Common.Forms/PropertyClasses/IFailureMechanismPropertyChangeHandler.cs
    • -38
    • +16
    /Ringtoets/Common/test/Ringtoets.Common.Forms.Test/FailureMechanismPropertyChangeHandlerTest.cs
8:43 am

Joël van den Berg

Moved SetPropertyValueAfterConfirmation to the FailureMechanismPropertyChangeHandler implementation (defined method in interface), making it easier to test. Removed the responsibility of notifying affected objects, making this the responsibility of the caller Related to Issue [WTI-967]

git-svn-id: https://repos.deltares.nl/repos/WettelijkToetsInstrumentarium/trunk@7603 5a3db67b-de53-47b5-99c8-a1c30a6650e2

Former-commit-id: 936f042130ff1cd70cf0ce6c04a253c4dc9b8356

Former-commit-id: a15b6b5b5618f31031cc5fcec2c1e6b07ea254cc

Options
    • -0
    • +50
    /Ringtoets/Common/src/Ringtoets.Common.Forms/FailureMechanismPropertyChangeHandler.cs
    • -81
    • +0
    /Ringtoets/Common/src/Ringtoets.Common.Forms/Helpers/IFailureMechanismPropertyChangeHandlerExtensions.cs
    • -1
    • +29
    /Ringtoets/Common/src/Ringtoets.Common.Forms/PropertyClasses/IFailureMechanismPropertyChangeHandler.cs
    • -1
    • +0
    /Ringtoets/Common/src/Ringtoets.Common.Forms/Ringtoets.Common.Forms.csproj
    • -0
    • +188
    /Ringtoets/Common/test/Ringtoets.Common.Forms.Test/FailureMechanismPropertyChangeHandlerTest.cs
    • -188
    • +0
    /Ringtoets/Common/test/Ringtoets.Common.Forms.Test/Helpers/IFailureMechanismPropertyChangeHandlerExtensionsTest.cs
    • -1
    • +0
    /Ringtoets/Common/test/Ringtoets.Common.Forms.Test/Ringtoets.Common.Forms.Test.csproj
    • -6
    • +16
    /Ringtoets/Piping/src/Ringtoets.Piping.Forms/PropertyClasses/PipingFailureMechanismContextProperties.cs
    • -1
    • +1
    /Ringtoets/Piping/src/Ringtoets.Piping.Plugin/PipingPlugin.cs
    • -119
    • +70
    /Ringtoets/Piping/test/Ringtoets.Piping.Forms.Test/PropertyClasses/PipingFailureMechanismContextPropertiesTest.cs
Wednesday 04 Jan 2017
4:07 pm

Robert Tangerman <robert.tangerman@deltares.nl>

Added null checks and documentation in stability points structures calculation service. Related to Issue [WTI-777]

git-svn-id: https://repos.deltares.nl/repos/WettelijkToetsInstrumentarium/trunk@7602 5a3db67b-de53-47b5-99c8-a1c30a6650e2

Former-commit-id: 82f3b5c1da2d35c2e365eed6a6c8378f56428084

Former-commit-id: d1d47d76bc45864467db764d647ec4eee233f239

Options
    • -0
    • +5
    /Ringtoets/StabilityPointStructures/src/Ringtoets.StabilityPointStructures.Service/Ringtoets.StabilityPointStructures.Service.csproj
    • -44
    • +76
    /Ringtoets/StabilityPointStructures/src/Ringtoets.StabilityPointStructures.Service/StabilityPointStructuresCalculationService.cs
    • -196
    • +288
    /Ringtoets/StabilityPointStructures/test/Ringtoets.StabilityPointStructures.Service.Test/StabilityPointStructuresCalculationServiceTest.cs
4:05 pm

Marten Janssen <marten.janssen@deltares.nl>

Fixed failing test paired with tang_ds

Related to Issue [WTI-770]

git-svn-id: https://repos.deltares.nl/repos/WettelijkToetsInstrumentarium/trunk@7601 5a3db67b-de53-47b5-99c8-a1c30a6650e2

Former-commit-id: e75b02715559b7fd8d466fed09cf62219c924e21

Former-commit-id: e003423edf25fc0c30b3c80f7ca12a8f30373f5e

Options
    • -2
    • +8
    /Ringtoets/DuneErosion/test/Ringtoets.DuneErosion.Data.TestUtil/TestDuneLocation.cs
    • -1
    • +11
    /Ringtoets/DuneErosion/test/Ringtoets.DuneErosion.Data.TestUtil/TestDuneLocationOutput.cs
3:45 pm

Robert Tangerman <robert.tangerman@deltares.nl>

Added null checks in piping calculation service.

Related to Issue [WTI-777]

git-svn-id: https://repos.deltares.nl/repos/WettelijkToetsInstrumentarium/trunk@7600 5a3db67b-de53-47b5-99c8-a1c30a6650e2

Former-commit-id: e2e731e8fc2b5997fd49e1bbcaefeba249b39a60

Former-commit-id: 836ea3a7b98ad248a81d5b6fb9e54c41aa2b525d

Options
    • -1
    • +14
    /Ringtoets/Piping/src/Ringtoets.Piping.Service/PipingCalculationService.cs
    • -49
    • +68
    /Ringtoets/Piping/test/Ringtoets.Piping.Service.Test/PipingCalculationServiceTest.cs
3:41 pm

Marten Janssen <marten.janssen@deltares.nl>

Changes after review: - Removed Create*ForExport methods and placed them in the relevant test classes. - XMLdoc updated paired with tang_ds Related to Issue [WTI-770]

git-svn-id: https://repos.deltares.nl/repos/WettelijkToetsInstrumentarium/trunk@7599 5a3db67b-de53-47b5-99c8-a1c30a6650e2

Former-commit-id: f80db440182cccb3e84c6284773e69562759092b

Former-commit-id: 495d49782b1336af3a6e911e943baaeb40a1ef47

Options
    • -26
    • +0
    /Ringtoets/DuneErosion/test/Ringtoets.DuneErosion.Data.TestUtil.Test/TestDuneLocationOutputTest.cs
    • -27
    • +0
    /Ringtoets/DuneErosion/test/Ringtoets.DuneErosion.Data.TestUtil.Test/TestDuneLocationTest.cs
    • -24
    • +2
    /Ringtoets/DuneErosion/test/Ringtoets.DuneErosion.Data.TestUtil/TestDuneLocation.cs
    • -27
    • +1
    /Ringtoets/DuneErosion/test/Ringtoets.DuneErosion.Data.TestUtil/TestDuneLocationOutput.cs
    • -6
    • +28
    /Ringtoets/DuneErosion/test/Ringtoets.DuneErosion.IO.Test/DuneLocationsExporterTest.cs
    • -7
    • +28
    /Ringtoets/DuneErosion/test/Ringtoets.DuneErosion.IO.Test/DuneLocationsWriterTest.cs
    • -32
    • +0
    /Ringtoets/Revetment/test/Ringtoets.Revetment.Data.TestUtil.Test/TestWaveConditionsOutputTest.cs
    • -19
    • +2
    /Ringtoets/Revetment/test/Ringtoets.Revetment.Data.TestUtil/TestWaveConditionsOutput.cs
    • -5
    • +13
    /Ringtoets/Revetment/test/Ringtoets.Revetment.IO.Test/WaveConditionsExporterBaseTest.cs
    • -3
    • +11
    /Ringtoets/Revetment/test/Ringtoets.Revetment.IO.Test/WaveConditionsWriterTest.cs
2:01 pm

Dennis Tang <dennis.tang@deltares.nl>

Initial commit of changes from kleijn: - Removed HandleUserCancellingImport: FileImporter should not decide on its own how to handle Canceled actions. Consequently removed the messages that are generated by these handles - Added logic to the importers: Cancelling is not possible when putting data on the data model. Action will always execute when it is in this stage - Added branching paths in the activity: Import() returns false when it has failed or is cancelled

Note: failing tests will be fixed in following commits

Related to Issue [WTI-490]

git-svn-id: https://repos.deltares.nl/repos/WettelijkToetsInstrumentarium/branches/WTI-490@7598 5a3db67b-de53-47b5-99c8-a1c30a6650e2

Former-commit-id: 409bfee1e3deebb4fe4368cb7010a8c4c37dae5e

Former-commit-id: 98175da77f6910f259097a90626bbb10450e2c8f

Options
    • -1
    • +17
    /Core/Common/src/Core.Common.Base/Service/FileImportActivity.cs
    • -12
    • +1
    /Core/Components/src/Core.Components.Gis.IO/Importers/FeatureBasedMapDataImporter.cs
    • -11
    • +1
    /Core/Components/src/Core.Components.Gis.IO/Properties/Resources.Designer.cs
    • -3
    • +0
    /Core/Components/src/Core.Components.Gis.IO/Properties/Resources.resx
    • -6
    • +0
    /Ringtoets/ClosingStructures/src/Ringtoets.ClosingStructures.IO/ClosingStructuresImporter.cs
    • -6
    • +0
    /Ringtoets/Common/src/Ringtoets.Common.IO/FileImporters/DikeProfilesImporter.cs
    • -14
    • +1
    /Ringtoets/Common/src/Ringtoets.Common.IO/FileImporters/FailureMechanismSectionsImporter.cs
    • -6
    • +0
    /Ringtoets/Common/src/Ringtoets.Common.IO/FileImporters/ForeshoreProfilesImporter.cs
    • -22
    • +2
    /Ringtoets/Common/src/Ringtoets.Common.IO/FileImporters/ProfilesImporter.cs
    • -23
    • +2
    /Ringtoets/Common/src/Ringtoets.Common.IO/FileImporters/StructuresImporter.cs
    • -46
    • +0
    /Ringtoets/Common/src/Ringtoets.Common.IO/Properties/Resources.Designer.cs
    • -15
    • +0
    /Ringtoets/Common/src/Ringtoets.Common.IO/Properties/Resources.resx
    • -14
    • +1
    /Ringtoets/Common/src/Ringtoets.Common.IO/ReferenceLines/ReferenceLineImporter.cs
    • -6
    • +0
    /Ringtoets/HeightStructures/src/Ringtoets.HeightStructures.IO/HeightStructuresImporter.cs
    • -24
    • +2
    /Ringtoets/Piping/src/Ringtoets.Piping.Plugin/FileImporter/PipingSoilProfilesImporter.cs
  16. … 6 more files in changeset.
1:55 pm

Robert Tangerman <robert.tangerman@deltares.nl>

Added null checks and documentation in height structures calculation service. Related to Issue [WTI-777]

git-svn-id: https://repos.deltares.nl/repos/WettelijkToetsInstrumentarium/trunk@7597 5a3db67b-de53-47b5-99c8-a1c30a6650e2

Former-commit-id: ac75354b641fed54c3aac29476b3e4ea6eee9b10

Former-commit-id: a3c5ec0f83e92f501192da0ede81c6181d033f67

Options
    • -5
    • +55
    /Ringtoets/HeightStructures/src/Ringtoets.HeightStructures.Service/HeightStructuresCalculationService.cs
    • -0
    • +5
    /Ringtoets/HeightStructures/src/Ringtoets.HeightStructures.Service/Ringtoets.HeightStructures.Service.csproj
    • -44
    • +136
    /Ringtoets/HeightStructures/test/Ringtoets.HeightStructures.Service.Test/HeightStructuresCalculationServiceTest.cs
1:24 pm

Robert Tangerman <robert.tangerman@deltares.nl>

Added null checks and documentation in all wave conditions calculation services. Related to Issue [WTI-777]

git-svn-id: https://repos.deltares.nl/repos/WettelijkToetsInstrumentarium/trunk@7596 5a3db67b-de53-47b5-99c8-a1c30a6650e2

Former-commit-id: 886bd35c50ed18f63d2578ac468b3a60023953df

Former-commit-id: 4871ff8324b67f561827d1b280a950bad94d3bec

Options
    • -1
    • +38
    /Ringtoets/GrassCoverErosionOutwards/src/Ringtoets.GrassCoverErosionOutwards.Service/GrassCoverErosionOutwardsWaveConditionsCalculationService.cs
    • -0
    • +5
    /Ringtoets/GrassCoverErosionOutwards/src/Ringtoets.GrassCoverErosionOutwards.Service/Ringtoets.GrassCoverErosionOutwards.Service.csproj
    • -43
    • +113
    /Ringtoets/GrassCoverErosionOutwards/test/Ringtoets.GrassCoverErosionOutwards.Service.Test/GrassCoverErosionOutwardsWaveConditionsCalculationServiceTest.cs
    • -0
    • +5
    /Ringtoets/Revetment/src/Ringtoets.Revetment.Service/Ringtoets.Revetment.Service.csproj
    • -11
    • +62
    /Ringtoets/Revetment/src/Ringtoets.Revetment.Service/WaveConditionsCalculationServiceBase.cs
    • -0
    • +3
    /Ringtoets/Revetment/src/Ringtoets.Revetment.Service/WaveConditionsService.cs
    • -28
    • +65
    /Ringtoets/Revetment/test/Ringtoets.Revetment.Service.Test/WaveConditionsCalculationServiceBaseTest.cs
    • -0
    • +5
    /Ringtoets/StabilityStoneCover/src/Ringtoets.StabilityStoneCover.Service/Ringtoets.StabilityStoneCover.Service.csproj
    • -0
    • +34
    /Ringtoets/StabilityStoneCover/src/Ringtoets.StabilityStoneCover.Service/StabilityStoneCoverWaveConditionsCalculationService.cs
    • -58
    • +139
    /Ringtoets/StabilityStoneCover/test/Ringtoets.StabilityStoneCover.Service.Test/StabilityStoneCoverWaveConditionsCalculationServiceTest.cs
    • -0
    • +5
    /Ringtoets/WaveImpactAsphaltCover/src/Ringtoets.WaveImpactAsphaltCover.Service/Ringtoets.WaveImpactAsphaltCover.Service.csproj
    • -0
    • +34
    /Ringtoets/WaveImpactAsphaltCover/src/Ringtoets.WaveImpactAsphaltCover.Service/WaveImpactAsphaltCoverWaveConditionsCalculationService.cs
    • -42
    • +112
    /Ringtoets/WaveImpactAsphaltCover/test/Ringtoets.WaveImpactAsphaltCover.Service.Test/WaveImpactAsphaltCoverWaveConditionsCalculationServiceTest.cs
11:55 am

Elmar Kleijn

Merged revision(s) 7537-7594 from trunk

git-svn-id: https://repos.deltares.nl/repos/WettelijkToetsInstrumentarium/branches/WTI-490@7595 5a3db67b-de53-47b5-99c8-a1c30a6650e2

Former-commit-id: 0e49e986e424f30ac8983bbd9ff957781d5f060f

Former-commit-id: 7523618d63c9353bd9232f1bb2106a31386d1ed0

Options
11:38 am

Elmar Kleijn

Reverted some changes Related to Issue [WTI-490]

git-svn-id: https://repos.deltares.nl/repos/WettelijkToetsInstrumentarium/trunk@7594 5a3db67b-de53-47b5-99c8-a1c30a6650e2

Former-commit-id: 393a81aac4454cde27f7e6d667c125be4feb4c81

Former-commit-id: 9f0e2dd030a3f7922b3d222910b7f7c36eff6e02

Options
    • -0
    • +5
    /Core/Common/src/Core.Common.Base/IO/FileImporterBase.cs
    • -1
    • +2
    /Core/Common/src/Core.Common.Base/IO/IFileImporter.cs
    • -4
    • +2
    /Core/Common/test/Core.Common.Base.Test/IO/FileImporterBaseTest.cs
    • -3
    • +2
    /Ringtoets/Common/test/Ringtoets.Common.IO.Test/ReferenceLines/ReferenceLineImporterTest.cs
    • -0
    • +7
    /Ringtoets/Piping/src/Ringtoets.Piping.Plugin/FileImporter/PipingSurfaceLinesCsvImporter.cs
11:34 am

Joël van den Berg

Extracted extension method for IFailureMechanismPropertyChangeHandler to execute the "ask confirmation if required then set property value and notify observers of changed instances" operation. Related to Issue [WTI-967]

git-svn-id: https://repos.deltares.nl/repos/WettelijkToetsInstrumentarium/trunk@7593 5a3db67b-de53-47b5-99c8-a1c30a6650e2

Former-commit-id: 49073a822c38803ae06f0275befa94de277327f1

Former-commit-id: ec4ac575b72421668847ca589c5017fc9222edee

Options
    • -0
    • +81
    /Ringtoets/Common/src/Ringtoets.Common.Forms/Helpers/IFailureMechanismPropertyChangeHandlerExtensions.cs
    • -0
    • +1
    /Ringtoets/Common/src/Ringtoets.Common.Forms/Ringtoets.Common.Forms.csproj
    • -0
    • +188
    /Ringtoets/Common/test/Ringtoets.Common.Forms.Test/Helpers/IFailureMechanismPropertyChangeHandlerExtensionsTest.cs
    • -0
    • +1
    /Ringtoets/Common/test/Ringtoets.Common.Forms.Test/Ringtoets.Common.Forms.Test.csproj
    • -26
    • +10
    /Ringtoets/Piping/src/Ringtoets.Piping.Forms/PropertyClasses/PipingFailureMechanismContextProperties.cs
11:32 am

Dennis Tang <dennis.tang@deltares.nl>

Incorporated comments review 1365: - Fixed typos and consistency in the tests - Changed algorithm for creating the MapFeatures of ForeshoreProfiles, DikeProfiles and Structures: -- Performance optimization -- Instead of copying the IEnumerable to an array and iterate it, retrieve the amount of elements in the IEnumerable and iterate through it directly

Paired with bouvrie

Related to Issue [WTI-1023]

git-svn-id: https://repos.deltares.nl/repos/WettelijkToetsInstrumentarium/trunk@7592 5a3db67b-de53-47b5-99c8-a1c30a6650e2

Former-commit-id: f377e49fd293d52a2c9d6608f81b55ea5ce51246

Former-commit-id: bf9ed11cff2f2d74eb143a47075e528a79f8cb16

Options
    • -19
    • +22
    /Ringtoets/Common/src/Ringtoets.Common.Forms/Views/RingtoetsMapDataFeaturesFactory.cs
    • -8
    • +13
    /Ringtoets/Common/test/Ringtoets.Common.Forms.Test/Views/RingtoetsMapDataFeaturesFactoryTest.cs
11:21 am

Robert Tangerman <robert.tangerman@deltares.nl>

Added null checks and documentation in grass cover erosion inwards calculation service. Related to Issue [WTI-777]

git-svn-id: https://repos.deltares.nl/repos/WettelijkToetsInstrumentarium/trunk@7591 5a3db67b-de53-47b5-99c8-a1c30a6650e2

Former-commit-id: 920a6317e1d0afb8ec56545a4dbf19ec594aa7db

Former-commit-id: 7474ea033c2b44812d44c1e0a77ea3e6efe8c8ea

Options
    • -12
    • +89
    /Ringtoets/GrassCoverErosionInwards/src/Ringtoets.GrassCoverErosionInwards.Service/GrassCoverErosionInwardsCalculationService.cs
    • -0
    • +5
    /Ringtoets/GrassCoverErosionInwards/src/Ringtoets.GrassCoverErosionInwards.Service/Ringtoets.GrassCoverErosionInwards.Service.csproj
    • -38
    • +132
    /Ringtoets/GrassCoverErosionInwards/test/Ringtoets.GrassCoverErosionInwards.Service.Test/GrassCoverErosionInwardsCalculationServiceTest.cs
11:05 am

Marten Janssen <marten.janssen@deltares.nl>

- Added feature to ignore unrelevant prfl files in the same folder as the shape file. Related to Issue [WTI-861]

git-svn-id: https://repos.deltares.nl/repos/WettelijkToetsInstrumentarium/trunk@7590 5a3db67b-de53-47b5-99c8-a1c30a6650e2

Former-commit-id: 20505421dc6b646a5e1049a6fe5d1fcb64aa478b

Former-commit-id: 251cbd2c64e22732e3878c704e210e200c7ea7f2

Options
    • -0
    • +27
    /Ringtoets/Common/src/Ringtoets.Common.IO/DikeProfiles/DikeProfileDataReader.cs
    • -4
    • +10
    /Ringtoets/Common/src/Ringtoets.Common.IO/FileImporters/ProfilesImporter.cs
    • -57
    • +123
    /Ringtoets/Common/test/Ringtoets.Common.IO.Test/DikeProfiles/DikeProfileDataReaderTest.cs
    • -0
    • +18
    /Ringtoets/Common/test/Ringtoets.Common.IO.Test/FileImporters/ProfilesImporterTest.cs
    • -1
    • +1
    /Ringtoets/Common/test/Ringtoets.Common.IO.Test/test-data/DikeProfiles/faulty_unexpectedText4.prfl
    • -1
    • +1
    /Ringtoets/Common/test/Ringtoets.Common.IO.Test/test-data/DikeProfiles/faulty_unexpectedText5.prfl
    • -1
    • +1
    /Ringtoets/Common/test/Ringtoets.Common.IO.Test/test-data/DikeProfiles/faulty_unexpectedText7.prfl
    • -1
    • +1
    /Ringtoets/Common/test/Ringtoets.Common.IO.Test/test-data/DikeProfiles/faulty_unparsableDijk_tooManyValues.prfl
    • -1
    • +1
    /Ringtoets/Common/test/Ringtoets.Common.IO.Test/test-data/DikeProfiles/faulty_unparsableVoorland_tooManyValues.prfl
    • -1
    • +1
    /Ringtoets/Common/test/Ringtoets.Common.IO.Test/test-data/DikeProfiles/faulty_voorlandHasRoughnessTooBig.prfl
    • -1
    • +1
    /Ringtoets/Common/test/Ringtoets.Common.IO.Test/test-data/DikeProfiles/faulty_voorlandHasRoughnessTooSmall.prfl
    • binary
    /Ringtoets/Integration/test/Ringtoets.Integration.Plugin.Test/test-data/DikeProfiles/OkTestDataWithUnrelatedPrfl/Voorland 12-2.dbf
    • -0
    • +1
    /Ringtoets/Integration/test/Ringtoets.Integration.Plugin.Test/test-data/DikeProfiles/OkTestDataWithUnrelatedPrfl/Voorland 12-2.prj
    • binary
    /Ringtoets/Integration/test/Ringtoets.Integration.Plugin.Test/test-data/DikeProfiles/OkTestDataWithUnrelatedPrfl/Voorland 12-2.shp
    • binary
    /Ringtoets/Integration/test/Ringtoets.Integration.Plugin.Test/test-data/DikeProfiles/OkTestDataWithUnrelatedPrfl/Voorland 12-2.shx
  16. … 6 more files in changeset.
10:32 am

Robert Tangerman <robert.tangerman@deltares.nl>

Added null checks and documentation in wave height and design water level calculation services. Related to Issue [WTI-777]

git-svn-id: https://repos.deltares.nl/repos/WettelijkToetsInstrumentarium/trunk@7589 5a3db67b-de53-47b5-99c8-a1c30a6650e2

Former-commit-id: 812dd2758cb194a06a84ec03ed6f471bf0ab46b6

Former-commit-id: c209567aed6722c4602ca3e051c06133fc74c6d1

Options
    • -5
    • +50
    /Ringtoets/Common/src/Ringtoets.Common.Service/DesignWaterLevelCalculationService.cs
    • -5
    • +50
    /Ringtoets/Common/src/Ringtoets.Common.Service/WaveHeightCalculationService.cs
    • -18
    • +34
    /Ringtoets/Common/test/Ringtoets.Common.Service.Test/DesignWaterLevelCalculationServiceTest.cs
    • -14
    • +30
    /Ringtoets/Common/test/Ringtoets.Common.Service.Test/WaveHeightCalculationServiceTest.cs
9:56 am

Robert Tangerman <robert.tangerman@deltares.nl>

Added null checks in dune erosion and closing structures calculation services. Related to Issue [WTI-777]

git-svn-id: https://repos.deltares.nl/repos/WettelijkToetsInstrumentarium/trunk@7588 5a3db67b-de53-47b5-99c8-a1c30a6650e2

Former-commit-id: 63f021f5741f4dae65ad82aa12c4593af72c8727

Former-commit-id: 19a06c73d09214b5c9422976aeb691946802d415

Options
    • -29
    • +70
    /Ringtoets/ClosingStructures/src/Ringtoets.ClosingStructures.Service/ClosingStructuresCalculationService.cs
    • -0
    • +5
    /Ringtoets/ClosingStructures/src/Ringtoets.ClosingStructures.Service/Ringtoets.ClosingStructures.Service.csproj
    • -82
    • +160
    /Ringtoets/ClosingStructures/test/Ringtoets.ClosingStructures.Service.Test/ClosingStructuresCalculationServiceTest.cs
    • -0
    • +11
    /Ringtoets/DuneErosion/src/Ringtoets.DuneErosion.Service/DuneErosionBoundaryCalculationService.cs
    • -0
    • +30
    /Ringtoets/DuneErosion/test/Ringtoets.DuneErosion.Service.Test/DuneErosionBoundaryCalculationServiceTest.cs
8:56 am

bouvrie <bouvrie@example.com>

* Variables explicit * Outlining of code * use of nameof operator Related to Issue [WTI-968]

git-svn-id: https://repos.deltares.nl/repos/WettelijkToetsInstrumentarium/trunk@7587 5a3db67b-de53-47b5-99c8-a1c30a6650e2

Former-commit-id: 7192e8774b1de4a73c557c01d1c0ee4fb05eb9c6

Former-commit-id: 046d4c257ed04d2bdedf293a610cf6297dbc4324

Options
    • -8
    • +8
    /Ringtoets/Common/src/Ringtoets.Common.Utils/AssignUnassignCalculations.cs
    • -11
    • +18
    /Ringtoets/Common/src/Ringtoets.Common.Utils/StructuresHelper.cs
    • -28
    • +28
    /Ringtoets/GrassCoverErosionInwards/src/Ringtoets.GrassCoverErosionInwards.Plugin/GrassCoverErosionInwardsPlugin.cs
    • -5
    • +5
    /Ringtoets/GrassCoverErosionInwards/src/Ringtoets.GrassCoverErosionInwards.Utils/GrassCoverErosionInwardsHelper.cs