Riskeer

Clone Tools
  • last updated a few seconds ago
Constraints
Constraints: committers
 
Constraints: files
Constraints: dates
* Disallow NaN as valid value for GeneralDuneInput.N * Added missing ArgumentNullException checks to DuneErosionFailureMechanismProperties. * Cleanup. Related to Issue [WTI-1042]

git-svn-id: https://repos.deltares.nl/repos/WettelijkToetsInstrumentarium/trunk@7673 5a3db67b-de53-47b5-99c8-a1c30a6650e2

Former-commit-id: 85c3868eaf4db6ffc14bc27937a6f359e6ea42fe

Former-commit-id: 75059c59afcba035c017d62bce99ccbca8cd22c0

Added tables DuneLocationEntity and DuneLocationOutputEntity Related to Issue [WTI-1043]

git-svn-id: https://repos.deltares.nl/repos/WettelijkToetsInstrumentarium/trunk@7672 5a3db67b-de53-47b5-99c8-a1c30a6650e2

Former-commit-id: 29c6db4c593477fa2bc1a790304141ff2d71d725

Former-commit-id: 05d56791514092bab6e41332e9645f51b3c5d57b

  1. … 55 more files in changeset.
Made {{CreateSinglePointMapFeature}} public, added test Used usings instead of full namespace in XMLdoc when no code is used of that namespace Related to Issue [WTI-1045]

git-svn-id: https://repos.deltares.nl/repos/WettelijkToetsInstrumentarium/trunk@7670 5a3db67b-de53-47b5-99c8-a1c30a6650e2

Former-commit-id: f00fd2a256da9c5d819495ab779f6636319d68a5

Former-commit-id: 8f8bfa381d37e53dac7a6cf3eeb0aefb92002766

Incorporated comments review 1385: (Editorial) - Made the spelling of "Canceled" or "Uncancelable (opposed to "Cancelled" or "Uncancellable") consistent throughout the application.

Note:

"Cancellation" is legit U.S. spelling and therefore unchanged. "Cancelation" is not common and rarely used.

Related to Issue [WTI-490]

git-svn-id: https://repos.deltares.nl/repos/WettelijkToetsInstrumentarium/trunk@7669 5a3db67b-de53-47b5-99c8-a1c30a6650e2

Former-commit-id: 665e259f03237740e63d6441088354043dae52f2

Former-commit-id: 98c98ae04c081843c7bab2c55946744a8d06dad2

    • -1
    • +1
    /Core/Common/src/Core.Common.Gui/GuiCore.cs
  1. … 21 more files in changeset.
Incorporated comments review 1385: - Improved FileImporterBase: -- Use null propagation -- Removed unnecessary setter -- Virtual method to abstract method, fixed affected failing tests - Improved StructuresImporter: -- Used nameof function -- Renamed private field parameter name conform coding standards - Minor editorial changes - Removed redundant aliases

Related to Issue [WTI-490]

git-svn-id: https://repos.deltares.nl/repos/WettelijkToetsInstrumentarium/trunk@7668 5a3db67b-de53-47b5-99c8-a1c30a6650e2

Former-commit-id: ae36ef10b17db21a36e1c42d2fff77760a8665d6

Former-commit-id: 125e339e8568945268976ffc402eba124269dfff

Restored separator test. Reviewed by: tang_ds Related to Issue [WTI-995]

git-svn-id: https://repos.deltares.nl/repos/WettelijkToetsInstrumentarium/trunk@7667 5a3db67b-de53-47b5-99c8-a1c30a6650e2

Former-commit-id: 007ee5dd395675081fe40e90b3248b87f425588a

Former-commit-id: 22857c81b84d14bfc2043bd48de8bb2bda82d06d

Ran Deltares cleanup after review. Related to Issue [WTI-300]

git-svn-id: https://repos.deltares.nl/repos/WettelijkToetsInstrumentarium/trunk@7666 5a3db67b-de53-47b5-99c8-a1c30a6650e2

Former-commit-id: 58b009daca251390231f6047673a0cdff81e1fd4

Former-commit-id: 08b023edb2f6da739215c551e58bc1868856dc8a

- Improved no features scenario and message. Related to Issue [WTI-300]

git-svn-id: https://repos.deltares.nl/repos/WettelijkToetsInstrumentarium/trunk@7665 5a3db67b-de53-47b5-99c8-a1c30a6650e2

Former-commit-id: d642a308ce2bca605ccde93d52618b937bc9f5ec

Former-commit-id: 426eebb1a01d491cd63a2f4fe823f0f264b911de

Removed unused references

Related to Issue [WTI-995]

git-svn-id: https://repos.deltares.nl/repos/WettelijkToetsInstrumentarium/trunk@7664 5a3db67b-de53-47b5-99c8-a1c30a6650e2

Former-commit-id: 67bf9fbe9a9eb76b3f8d86301b6d9c44ffd91382

Former-commit-id: 8a1288adefbc7c8cd7c2bddcab59ce7f0d56b7f2

Adapted some resources Related to Issue [WTI-300]

git-svn-id: https://repos.deltares.nl/repos/WettelijkToetsInstrumentarium/trunk@7663 5a3db67b-de53-47b5-99c8-a1c30a6650e2

Former-commit-id: ff07846421d51ee3a3783499615b75309193473b

Former-commit-id: 12b3ada125bc5f7d13efb93622cec5ba263cae2c

Implemented review suggestion to use a dedicated folder for a test that uses *DirectoryPermissionsRevoker* in an environment that does not use {{ApartmentState.STA}} paired with tangerma Related to Issue [WTI-777]

git-svn-id: https://repos.deltares.nl/repos/WettelijkToetsInstrumentarium/trunk@7662 5a3db67b-de53-47b5-99c8-a1c30a6650e2

Former-commit-id: 97d1615811088f2b76c365a8ae7f0f0e6f73ca35

Former-commit-id: be3db8ca7d022d956176faeb5d1b35e7e00e83f9

Get rid of AffectedNonTargetObservableInstances property in FileImporterBase Related to Issue [WTI-490]

git-svn-id: https://repos.deltares.nl/repos/WettelijkToetsInstrumentarium/trunk@7661 5a3db67b-de53-47b5-99c8-a1c30a6650e2

Former-commit-id: b4399ab53f7c2aac15418f5353df3a273c66df30

Former-commit-id: ad12f9acfead5c0cbdb94f1fdff36c99392b06e6

Consistent ordering of ContextMenus for the Q-variant calculations: - Removed "Hernoemen" item when the calculation folder is a root folder - Fixed affected tests

Related to Issue [WTI-995]

git-svn-id: https://repos.deltares.nl/repos/WettelijkToetsInstrumentarium/trunk@7660 5a3db67b-de53-47b5-99c8-a1c30a6650e2

Former-commit-id: f6e2a590f35ab6c97773359c9faed63b35a01e54

Former-commit-id: 8e7e971458a1de7020f2fec2b4027919256b44e5

Changed Tooltip of dunes calculate all. Reviewed by: berg_jl Related to Issue [WTI-777]

git-svn-id: https://repos.deltares.nl/repos/WettelijkToetsInstrumentarium/trunk@7659 5a3db67b-de53-47b5-99c8-a1c30a6650e2

Former-commit-id: c2590292da31a408341f55b41316f44738d9e854

Former-commit-id: 3e183d04bde72cd4ac938153967501faa9ee27f2

Refactored some methods in MapLegendView. Related to Issue [WTI-300]

git-svn-id: https://repos.deltares.nl/repos/WettelijkToetsInstrumentarium/trunk@7657 5a3db67b-de53-47b5-99c8-a1c30a6650e2

Former-commit-id: 323b099007461edbc1477a83b68f473c552052b2

Former-commit-id: 60af79edaaaea31a549504250c9f9c17bb27776f

Disable ZoomToExtent ContextMenuItem when FeatureBasedMapData within MapDataCollection doesn't contain features. Related to Issue [WTI-300]

git-svn-id: https://repos.deltares.nl/repos/WettelijkToetsInstrumentarium/trunk@7656 5a3db67b-de53-47b5-99c8-a1c30a6650e2

Former-commit-id: 42efc8464b28176d0c2db26d418b16d9a4a4bb4e

Former-commit-id: a72de67887d8b7656a130ec486046430de66f457

- Added NotifyProgress calls when adding data to the data model - Synchronised message values across all the importers

Note:

No tests are available to verify the cancel behaviour for the FeatureBasedMapData because it has no NotifyProgress (and consequently no SetProgress handle to set the Action it should execute during the import)

Related to Issue [WTI-490]

git-svn-id: https://repos.deltares.nl/repos/WettelijkToetsInstrumentarium/trunk@7655 5a3db67b-de53-47b5-99c8-a1c30a6650e2

Former-commit-id: ee82e9d839a1acfffb0ccb4ff219a30856c744e7

Former-commit-id: a79f8f2e64e63d1e9bac5672052dc8bc143bf91f

  1. … 4 more files in changeset.
Disable ZoomToExtent ContextMenuItem when a FeatureBasedMapData doesn't contain features. Related to Issue [WTI-300]

git-svn-id: https://repos.deltares.nl/repos/WettelijkToetsInstrumentarium/trunk@7654 5a3db67b-de53-47b5-99c8-a1c30a6650e2

Former-commit-id: 996d9426f2a52939fdf39dcd51d76a6656020079

Former-commit-id: d1226aea611847b52b3da7069ec2376bcfbb2b71

- Made extension methods for MapDataCollection. - Disable ZoomToAll in ContextMenu of MapDataCollection when all data is invisible. Related to Issue [WTI-300]

git-svn-id: https://repos.deltares.nl/repos/WettelijkToetsInstrumentarium/trunk@7653 5a3db67b-de53-47b5-99c8-a1c30a6650e2

Former-commit-id: 5bf000a9df2088b73a4ff102a9579eead8bc6020

Former-commit-id: 71e856a26de2e60db5a5a04de18787c2a841ec5d

Changed tooltips of ZoomToAll ContextMenuItem of map items. Related to Issue [WTI-300]

git-svn-id: https://repos.deltares.nl/repos/WettelijkToetsInstrumentarium/trunk@7652 5a3db67b-de53-47b5-99c8-a1c30a6650e2

Former-commit-id: 0817ffadb86933a560c9ca6149becffaf0ca3219

Former-commit-id: f7fe35e1658d056c6c5911885b3e936cb1bf8410

Changes after review. Related to Issue [WTI-974]

git-svn-id: https://repos.deltares.nl/repos/WettelijkToetsInstrumentarium/trunk@7651 5a3db67b-de53-47b5-99c8-a1c30a6650e2

Former-commit-id: 66b04501a623f2bf32a4610dabd032be8dfde33f

Former-commit-id: b8bd2d6d14ab65c043cf795b202adaf710e05a56

Implemented Reuse tests in the concrete implementations of the FileImporterBase Related to Issue [WTI-490]

git-svn-id: https://repos.deltares.nl/repos/WettelijkToetsInstrumentarium/trunk@7650 5a3db67b-de53-47b5-99c8-a1c30a6650e2

Former-commit-id: d766c4944786409b114582323cf947d60e99337f

Former-commit-id: 0ff0cb1b31a88afc319a093050888e49cd2428f5

Made ConstructionProperties get internal. Related to Issue [WTI-777]

git-svn-id: https://repos.deltares.nl/repos/WettelijkToetsInstrumentarium/trunk@7649 5a3db67b-de53-47b5-99c8-a1c30a6650e2

Former-commit-id: 1c081f9abe92db16f4e7d826bc603b4ce6c1b780

Former-commit-id: d023a12d4a7e18f01919ba166aba490bb55e12ea

Improvements after review. Related to Issue [WTI-777]

git-svn-id: https://repos.deltares.nl/repos/WettelijkToetsInstrumentarium/trunk@7648 5a3db67b-de53-47b5-99c8-a1c30a6650e2

Former-commit-id: c797f46ab1f6f4cf0dcc824a7a495f312e529b36

Former-commit-id: 55ee85a64cc1545c9c5dafe3c054b160a5df241e

  1. … 5 more files in changeset.
Fixed bug where the correct object (hydraulic boundary locations collection) was not notified after clearing the hydraulic boundary location results due to a change in the grass cover erosion outwards failure mechanism. Related to Issue [WTI-971]

git-svn-id: https://repos.deltares.nl/repos/WettelijkToetsInstrumentarium/trunk@7647 5a3db67b-de53-47b5-99c8-a1c30a6650e2

Former-commit-id: 4d060a4838a8e1bbcb2ca6f45d7a13b04df71364

Former-commit-id: 3762cff41548527b817fc5bdc11b9c64f112c172

Merged revision(s) 7595-7638 from branches/WTI-490:

Merged revision(s) 7537-7594 from trunk

........

Initial commit of changes from kleijn:

- Removed HandleUserCancellingImport: FileImporter should not decide on its own how to handle Canceled actions. Consequently removed the messages that are generated by these handles

- Added logic to the importers: Cancelling is not possible when putting data on the data model. Action will always execute when it is in this stage

- Added branching paths in the activity: Import() returns false when it has failed or is cancelled

Note: failing tests will be fixed in following commits

........

Fixed tests of the FileImporterBase and Activity:

- Checks on the states are made for the 4 different paths of the Import:

-- Import successful, canceled or not

-- Import not successful, canceled or not

- Moved logging from the activity to the importer

- Added tests to assert mentioned behaviour

........

Fixed tests of the PipingSurfaceLinesCsvImporter:

- Added test to verify behaviour when canceling at the two stages during the import

- Reverted changes related to HandleUserCancellingImport: messages are written by the LogImportCanceledMessage and handled adequately by the base

- Added resource value for the ImportActivity (missing file commit)

........

Fixed tests of the PipingSoilProfilesImporter:

- Added test to verify behaviour when canceling at the three stages during the import

- Reverted changes related to HandleUserCancellingImport: messages are written by the LogImportCanceledMessage and handled adequately by the base

- Cleaned redundant brackets

........

Fixed tests of the StructuresImporter:

- Added test to verify behaviour when canceling at the two stages during the import. Test regarding cancelling while Creating structures is missing

- Reverted changes related to HandleUserCancellingImport: messages are written by the LogImportCanceledMessage and handled adequately by the base

Adjusted test in PipingSoilProfilesImporterTest

- Changed initial value of the result to make clear that the value is set correctly

........

Fixed tests of the ProfilesImporters:

- Added test to verify behaviour when canceling at the two stages during the import. Test regarding cancelling while Creating structures is missing

- Reverted changes related to HandleUserCancellingImport: messages are written by the LogImportCanceledMessage and handled adequately by the base

- Removed obsolete Cancel call in the PipingSoilProfilesImporterTest

........

FileImporters should call Observers in case the import was successfull AND was cancelled at an uncancellable stage.

Note: test is missing to verify this behaviour

........

Fixed tests of the ProfilesImporters:

- Reverted changes related to HandleUserCancellingImport: messages are written by the LogImportCanceledMessage and handled adequately by the base

- Temporarily removed the Cancel tests, because the FeatureBasedMapDataImporter does not have a handle for NotifyProgress. Hence, Cancel method cannot be invoked when Import is running.

........

Fixed tests of the FailureMechanismSectionsImporter:

- Added test to verify behaviour when canceling at the three stages during the import

- Reverted changes related to HandleUserCancellingImport: messages are written by the LogImportCanceledMessage and handled adequately by the base

- Cleaned up tests in the StructuresImporterTest

........

Fixed tests of the ReferenceLineImporter:

- Added test to verify behaviour when canceling at the two stages during the import

- Reverted changes related to HandleUserCancellingImport: messages are written by the LogImportCanceledMessage and handled adequately by the base

........

Related to Issue [WTI-490]

git-svn-id: https://repos.deltares.nl/repos/WettelijkToetsInstrumentarium/trunk@7646 5a3db67b-de53-47b5-99c8-a1c30a6650e2

Former-commit-id: 1c355702dfbd410c7c4733529d8db9e243496eba

Former-commit-id: 75c614862d018947936ef85e3775a125c425c032

  1. … 12 more files in changeset.
Replace HydraulicBoundaryLocation with DuneLocation on the DuneErosionFailureMechanismView Related to Issue [WTI-1045]

git-svn-id: https://repos.deltares.nl/repos/WettelijkToetsInstrumentarium/trunk@7645 5a3db67b-de53-47b5-99c8-a1c30a6650e2

Former-commit-id: 078485c30d90398bc7d7b60f423475cccd85b67d

Former-commit-id: 859d403f3e7390da5676ae2efeacd02df66ea0a6

Changes after review. Related to Issue [WTI-970]

git-svn-id: https://repos.deltares.nl/repos/WettelijkToetsInstrumentarium/trunk@7644 5a3db67b-de53-47b5-99c8-a1c30a6650e2

Former-commit-id: e660720dab15dc5d11f02dba64713c7625bb6b94

Former-commit-id: f48e78a9ede89422458c21ada67f2b0cd08ea777

Added line with units in duneLocations export. Related to Issue [WTI-779]

git-svn-id: https://repos.deltares.nl/repos/WettelijkToetsInstrumentarium/trunk@7643 5a3db67b-de53-47b5-99c8-a1c30a6650e2

Former-commit-id: 77126740ce2b47430f3d1c3ff82f59fa70ac899a

Former-commit-id: 613047b8483a736ac788c2c441dcaf8e5680e655

Rows in message window are now resized when it is being narrowed. Reviewed by: kleijn

git-svn-id: https://repos.deltares.nl/repos/WettelijkToetsInstrumentarium/trunk@7642 5a3db67b-de53-47b5-99c8-a1c30a6650e2

Former-commit-id: 740ca9e71ce8a2eee126057272042db13728fcab

Former-commit-id: 9cc38c5ff9454af0abdea0f03503fb490fb422ce