Riskeer

Clone Tools

Stats

Commits this week: 0
Total Committers: 28
Last Commit: 26 Nov
Commits this week: 0

Lines of code count not available

Commit Activity

Commits By Day In Week
52 week commits volume
Commits By Day In Week
Commits by day
Commits By Day In Week
Commits by hour
Commits By Hour In Day
Commit calendar
 

Most active committers (90 days)

loading
loading
  • last updated a few seconds ago
All Commits Reviews
Constraints
Constraints: committers
 
Constraints: files
Constraints: dates
Wednesday 14 Feb 2018
11:56 am

Carlos Lubbers

Introduce helper method for determinging whether the simple assessment has passed. WTI-1617

Options
    • -0
    • +55
    /Ringtoets/Common/src/Ringtoets.Common.Forms/Helpers/FailureMechanismResultViewHelper.cs
    • -0
    • +1
    /Ringtoets/Common/src/Ringtoets.Common.Forms/Ringtoets.Common.Forms.csproj
    • -0
    • +86
    /Ringtoets/Common/test/Ringtoets.Common.Forms.Test/Helpers/FailureMechanismResultViewHelperTest.cs
    • -0
    • +1
    /Ringtoets/Common/test/Ringtoets.Common.Forms.Test/Ringtoets.Common.Forms.Test.csproj
    • -7
    • +3
    /Ringtoets/GrassCoverErosionInwards/src/Ringtoets.GrassCoverErosionInwards.Forms/Views/GrassCoverErosionInwardsFailureMechanismResultView.cs
    • -8
    • +4
    /Ringtoets/GrassCoverErosionOutwards/src/Ringtoets.GrassCoverErosionOutwards.Forms/Views/GrassCoverErosionOutwardsFailureMechanismResultView.cs
    • -8
    • +4
    /Ringtoets/Integration/src/Ringtoets.Integration.Forms/Views/SectionResultViews/GrassCoverSlipOffInwardsResultView.cs
    • -8
    • +4
    /Ringtoets/Integration/src/Ringtoets.Integration.Forms/Views/SectionResultViews/GrassCoverSlipOffOutwardsResultView.cs
    • -8
    • +4
    /Ringtoets/Integration/src/Ringtoets.Integration.Forms/Views/SectionResultViews/MacroStabilityOutwardsResultView.cs
    • -8
    • +4
    /Ringtoets/Integration/src/Ringtoets.Integration.Forms/Views/SectionResultViews/MicrostabilityResultView.cs
    • -8
    • +4
    /Ringtoets/Integration/src/Ringtoets.Integration.Forms/Views/SectionResultViews/PipingStructureResultView.cs
    • -8
    • +4
    /Ringtoets/Integration/src/Ringtoets.Integration.Forms/Views/SectionResultViews/StrengthStabilityLengthwiseConstructionResultView.cs
    • -8
    • +4
    /Ringtoets/Integration/src/Ringtoets.Integration.Forms/Views/SectionResultViews/TechnicalInnovationResultView.cs
    • -8
    • +4
    /Ringtoets/Integration/src/Ringtoets.Integration.Forms/Views/SectionResultViews/WaterPressureAsphaltCoverResultView.cs
    • -8
    • +4
    /Ringtoets/MacroStabilityInwards/src/Ringtoets.MacroStabilityInwards.Forms/Views/MacroStabilityInwardsFailureMechanismResultView.cs
  16. … 3 more files in changeset.
11:49 am

Dennis Tang <dennis.tang@deltares.nl>

Rewired SectionResult to the mirror property SectionResult2 for ClosingStructures in Data: - Adjusted the 2aAssessementResultExtensions - Adjusted Forms classes that depend on the extension method: -- Fixed compilation errors and tests for the failure mechanism result view

WTI-1621

Options
    • -1
    • +1
    /Ringtoets/ClosingStructures/src/Ringtoets.ClosingStructures.Data/ClosingStructuresFailureMechanismSection2aAssessmentResultExtensions.cs
    • -4
    • +4
    /Ringtoets/ClosingStructures/src/Ringtoets.ClosingStructures.Forms/Views/ClosingStructuresFailureMechanismResultView.cs
    • -5
    • +5
    /Ringtoets/ClosingStructures/src/Ringtoets.ClosingStructures.Forms/Views/ClosingStructuresFailureMechanismSectionResultRow.cs
    • -2
    • +2
    /Ringtoets/ClosingStructures/src/Ringtoets.ClosingStructures.Plugin/ClosingStructuresPlugin.cs
    • -6
    • +5
    /Ringtoets/ClosingStructures/test/Ringtoets.ClosingStructures.Data.Test/ClosingStructuresFailureMechanismSection2aAssessmentResultExtensionsTest.cs
    • -30
    • +31
    /Ringtoets/ClosingStructures/test/Ringtoets.ClosingStructures.Forms.Test/Views/ClosingStructuresFailureMechanismResultViewTest.cs
    • -10
    • +10
    /Ringtoets/ClosingStructures/test/Ringtoets.ClosingStructures.Forms.Test/Views/ClosingStructuresFailureMechanismSectionResultRowTest.cs
    • -2
    • +2
    /Ringtoets/ClosingStructures/test/Ringtoets.ClosingStructures.Plugin.Test/ClosingStructuresPluginTest.cs
    • -16
    • +17
    /Ringtoets/ClosingStructures/test/Ringtoets.ClosingStructures.Plugin.Test/ViewInfos/ClosingStructuresFailureMechanismResultViewInfoTest.cs
11:41 am

Robert Tangerman <robert.tangerman@deltares.nl>

Created new project Ringtoets.Common.Primitives. WTI-1616

Options
    • -86
    • +87
    /Application/Ringtoets/src/Application.Ringtoets.Setup/Licentie.rtf
    • -1
    • +33
    /Ringtoets.sln
    • -0
    • +25
    /Ringtoets/Common/src/Ringtoets.Common.Primitives/Properties/AssemblyInfo.cs
    • -0
    • +21
    /Ringtoets/Common/src/Ringtoets.Common.Primitives/Ringtoets.Common.Primitives.csproj
    • -0
    • +25
    /Ringtoets/Common/test/Ringtoets.Common.Primitives.Test/Properties/AssemblyInfo.cs
    • -0
    • +21
    /Ringtoets/Common/test/Ringtoets.Common.Primitives.Test/Ringtoets.Common.Primitives.Test.csproj
11:32 am

Elmar Kleijn

Review related changes => Unified unit tests for FailureMechanismCreateExtensions

WTI-1531

Options
    • -3
    • +2
    /Application/Ringtoets/test/Application.Ringtoets.Storage.Test/Create/ClosingStructures/ClosingStructuresFailureMechanismCreateExtensionsTest.cs
    • -3
    • +8
    /Application/Ringtoets/test/Application.Ringtoets.Storage.Test/Create/DuneErosion/DuneErosionFailureMechanismCreateExtensionsTest.cs
    • -1
    • +2
    /Application/Ringtoets/test/Application.Ringtoets.Storage.Test/Create/GrassCoverErosionInwards/GrassCoverErosionInwardsFailureMechanismCreateExtensionsTest.cs
    • -0
    • +8
    /Application/Ringtoets/test/Application.Ringtoets.Storage.Test/Create/GrassCoverErosionOutwards/GrassCoverErosionOutwardsFailureMechanismCreateExtensionsTest.cs
    • -1
    • +2
    /Application/Ringtoets/test/Application.Ringtoets.Storage.Test/Create/HeightStructures/HeightStructuresFailureMechanismCreateExtensionsTest.cs
    • -2
    • +2
    /Application/Ringtoets/test/Application.Ringtoets.Storage.Test/Create/Piping/PipingFailureMechanismCreateExtensionsTest.cs
    • -3
    • +3
    /Application/Ringtoets/test/Application.Ringtoets.Storage.Test/Create/PipingStructure/PipingStructureFailureMechanismCreateExtensionsTest.cs
    • -1
    • +2
    /Application/Ringtoets/test/Application.Ringtoets.Storage.Test/Create/StabilityPointStructures/StabilityPointStructuresFailureMechanismCreateExtensionsTest.cs
    • -1
    • +2
    /Application/Ringtoets/test/Application.Ringtoets.Storage.Test/Create/StabilityStoneCover/StabilityStoneCoverFailureMechanismCreateExtensionsTest.cs
    • -1
    • +1
    /Application/Ringtoets/test/Application.Ringtoets.Storage.Test/Create/WaveImpactAsphaltCover/WaveImpactAsphaltCoverFailureMechanismCreateExtensionsTest.cs
11:32 am

Carlos Lubbers

Rename resource and remove method from base result view. WTI-1617

Options
    • -1
    • +7
    /Ringtoets/ClosingStructures/src/Ringtoets.ClosingStructures.Forms/Views/ClosingStructuresFailureMechanismResultView.cs
    • -1
    • +2
    /Ringtoets/Common/src/Ringtoets.Common.Forms/Helpers/FailureMechanismSectionResultRowHelper.cs
    • -9
    • +9
    /Ringtoets/Common/src/Ringtoets.Common.Forms/Properties/Resources.Designer.cs
    • -1
    • +1
    /Ringtoets/Common/src/Ringtoets.Common.Forms/Properties/Resources.resx
    • -12
    • +0
    /Ringtoets/Common/src/Ringtoets.Common.Forms/Views/FailureMechanismResultView.cs
    • -1
    • +1
    /Ringtoets/Common/test/Ringtoets.Common.Forms.Test/Views/FailureMechanismResultViewTest.cs
    • -1
    • +1
    /Ringtoets/DuneErosion/src/Ringtoets.DuneErosion.Forms/Views/DuneErosionFailureMechanismResultView.cs
    • -1
    • +1
    /Ringtoets/GrassCoverErosionInwards/src/Ringtoets.GrassCoverErosionInwards.Forms/Views/GrassCoverErosionInwardsFailureMechanismResultView.cs
    • -1
    • +1
    /Ringtoets/GrassCoverErosionOutwards/src/Ringtoets.GrassCoverErosionOutwards.Forms/Views/GrassCoverErosionOutwardsFailureMechanismResultView.cs
    • -1
    • +7
    /Ringtoets/HeightStructures/src/Ringtoets.HeightStructures.Forms/Views/HeightStructuresFailureMechanismResultView.cs
    • -1
    • +1
    /Ringtoets/Integration/src/Ringtoets.Integration.Forms/Views/SectionResultViews/GrassCoverSlipOffInwardsResultView.cs
    • -1
    • +1
    /Ringtoets/Integration/src/Ringtoets.Integration.Forms/Views/SectionResultViews/GrassCoverSlipOffOutwardsResultView.cs
    • -1
    • +1
    /Ringtoets/Integration/src/Ringtoets.Integration.Forms/Views/SectionResultViews/MacroStabilityOutwardsResultView.cs
    • -1
    • +1
    /Ringtoets/Integration/src/Ringtoets.Integration.Forms/Views/SectionResultViews/MicrostabilityResultView.cs
    • -1
    • +1
    /Ringtoets/Integration/src/Ringtoets.Integration.Forms/Views/SectionResultViews/PipingStructureResultView.cs
  16. … 8 more files in changeset.
11:16 am

Dennis Tang <dennis.tang@deltares.nl>

Rewired SectionResult to the mirror property SectionResult2 for ClosingStructures in storage: - Adjusted Create and ReadExtensions - Adjusted Integration test (helpers)

WTI-1621

Options
    • -3
    • +3
    /Application/Ringtoets/src/Application.Ringtoets.Storage/Create/ClosingStructures/ClosingStructuresFailureMechanismCreateExtensions.cs
    • -4
    • +6
    /Application/Ringtoets/src/Application.Ringtoets.Storage/Create/ClosingStructures/ClosingStructuresFailureMechanismSectionResultCreateExtensions.cs
    • -3
    • +6
    /Application/Ringtoets/src/Application.Ringtoets.Storage/Read/ClosingStructures/ClosingStructuresSectionResultEntityReadExtensions.cs
    • -1
    • +1
    /Application/Ringtoets/src/Application.Ringtoets.Storage/Read/FailureMechanismEntityReadExtensions.cs
    • -4
    • +4
    /Application/Ringtoets/test/Application.Ringtoets.Storage.Test/Create/ClosingStructures/ClosingStructuresFailureMechanismSectionResultCreateExtensionsTest.cs
    • -4
    • +4
    /Application/Ringtoets/test/Application.Ringtoets.Storage.Test/IntegrationTests/StorageSqLiteIntegrationTest.cs
    • -4
    • +4
    /Application/Ringtoets/test/Application.Ringtoets.Storage.Test/Read/ClosingStructures/ClosingStructuresSectionResultEntityReadExtensionsTest.cs
    • -1
    • +1
    /Application/Ringtoets/test/Application.Ringtoets.Storage.TestUtil.Test/RingtoetsProjectTestHelperTest.cs
    • -3
    • +3
    /Application/Ringtoets/test/Application.Ringtoets.Storage.TestUtil/RingtoetsProjectTestHelper.cs
11:12 am

Elmar Kleijn

Review related changes => Fixed test names

WTI-1531

Options
    • -1
    • +1
    /Application/Ringtoets/test/Application.Ringtoets.Storage.Test/Read/ClosingStructures/ClosingStructuresFailureMechanismMetaEntityReadExtensionsTest.cs
    • -1
    • +1
    /Application/Ringtoets/test/Application.Ringtoets.Storage.Test/Read/DuneErosion/DuneErosionFailureMechanismMetaEntityReadExtensionsTest.cs
    • -2
    • +2
    /Application/Ringtoets/test/Application.Ringtoets.Storage.Test/Read/GrassCoverErosionInwards/GrassCoverErosionInwardsFailureMechanismMetaEntityReadExtensionsTest.cs
    • -2
    • +2
    /Application/Ringtoets/test/Application.Ringtoets.Storage.Test/Read/GrassCoverErosionOutwards/GrassCoverErosionOutwardsFailureMechanismMetaEntityReadExtensionsTest.cs
    • -1
    • +1
    /Application/Ringtoets/test/Application.Ringtoets.Storage.Test/Read/HeightStructures/HeightStructuresFailureMechanismMetaEntityReadExtensionsTest.cs
    • -3
    • +3
    /Application/Ringtoets/test/Application.Ringtoets.Storage.Test/Read/MacroStabilityInwards/MacroStabilityInwardsFailureMechanismMetaEntityReadExtensionsTest.cs
    • -3
    • +3
    /Application/Ringtoets/test/Application.Ringtoets.Storage.Test/Read/MacroStabilityOutwards/MacroStabilityOutwardsFailureMechanismMetaEntityReadExtensionsTest.cs
    • -4
    • +4
    /Application/Ringtoets/test/Application.Ringtoets.Storage.Test/Read/Piping/PipingFailureMechanismMetaEntityReadExtensionsTest.cs
    • -1
    • +1
    /Application/Ringtoets/test/Application.Ringtoets.Storage.Test/Read/StabilityPointStructures/StabilityPointStructuresFailureMechanismMetaEntityReadExtensionsTest.cs
    • -1
    • +1
    /Application/Ringtoets/test/Application.Ringtoets.Storage.Test/Read/StabilityStoneCover/StabilityStoneCoverFailureMechanismMetaEntityReadExtensionsTest.cs
    • -1
    • +1
    /Application/Ringtoets/test/Application.Ringtoets.Storage.Test/Read/WaveImpactAsphaltCover/WaveImpactAsphaltCoverFailureMechanismMetaEntityReadExtensionsTest.cs
    • -4
    • +4
    /Demo/Ringtoets/test/Demo.Ringtoets.Test/Commands/AddNewDemoAssessmentSectionCommandTest.cs
10:56 am

Robert Tangerman <robert.tangerman@deltares.nl>

Removed empty folders. WTI-1616

Options
    • -4
    • +0
    /Ringtoets/AssemblyTool/src/Ringtoets.AssemblyTool.Data/Ringtoets.AssemblyTool.Data.csproj
    • -4
    • +0
    /Ringtoets/AssemblyTool/test/Ringtoets.AssemblyTool.Data.Test/Ringtoets.AssemblyTool.Data.Test.csproj
10:51 am

Robert Tangerman <robert.tangerman@deltares.nl>

Revert 'Removed redundant AssemblyTool data project.' WTI-1616

Options
    • -103
    • +105
    /Application/Ringtoets/src/Application.Ringtoets.Setup/Licentie.rtf
    • -1
    • +33
    /Ringtoets.sln
    • -0
    • +25
    /Ringtoets/AssemblyTool/src/Ringtoets.AssemblyTool.Data/Properties/AssemblyInfo.cs
    • -0
    • +25
    /Ringtoets/AssemblyTool/src/Ringtoets.AssemblyTool.Data/Ringtoets.AssemblyTool.Data.csproj
    • -0
    • +5
    /Ringtoets/AssemblyTool/src/Ringtoets.AssemblyTool.KernelWrapper/Ringtoets.AssemblyTool.KernelWrapper.csproj
    • -0
    • +25
    /Ringtoets/AssemblyTool/test/Ringtoets.AssemblyTool.Data.Test/Properties/AssemblyInfo.cs
    • -0
    • +39
    /Ringtoets/AssemblyTool/test/Ringtoets.AssemblyTool.Data.Test/Ringtoets.AssemblyTool.Data.Test.csproj
    • -0
    • +26
    /Ringtoets/AssemblyTool/test/Ringtoets.AssemblyTool.Data.Test/packages.config
    • -0
    • +4
    /Ringtoets/AssemblyTool/test/Ringtoets.AssemblyTool.KernelWrapper.Test/Ringtoets.AssemblyTool.KernelWrapper.Test.csproj
    • -0
    • +4
    /Ringtoets/AssemblyTool/test/Ringtoets.AssemblyTool.KernelWrapper.TestUtil.Test/Ringtoets.AssemblyTool.KernelWrapper.TestUtil.Test.csproj
    • -0
    • +4
    /Ringtoets/AssemblyTool/test/Ringtoets.AssemblyTool.KernelWrapper.TestUtil/Ringtoets.AssemblyTool.KernelWrapper.TestUtil.csproj
    • -0
    • +5
    /Ringtoets/Common/src/Ringtoets.Common.Service/Ringtoets.Common.Service.csproj
    • -0
    • +4
    /Ringtoets/Common/test/Ringtoets.Common.Service.Test/Ringtoets.Common.Service.Test.csproj
10:47 am

Carlos Lubbers

Add simple assessment column to the grass cover erosion inwards result view WTI-1617

Options
    • -0
    • +40
    /Ringtoets/Common/src/Ringtoets.Common.Forms/Helpers/FailureMechanismSectionResultRowHelper.cs
    • -7
    • +157
    /Ringtoets/Common/test/Ringtoets.Common.Forms.Test/Helpers/FailureMechanismSectionResultRowHelperTest.cs
    • -9
    • +15
    /Ringtoets/GrassCoverErosionInwards/src/Ringtoets.GrassCoverErosionInwards.Forms/Views/GrassCoverErosionInwardsFailureMechanismResultView.cs
    • -1
    • +18
    /Ringtoets/GrassCoverErosionInwards/src/Ringtoets.GrassCoverErosionInwards.Forms/Views/GrassCoverErosionInwardsFailureMechanismSectionResultRow.cs
    • -39
    • +39
    /Ringtoets/GrassCoverErosionInwards/test/Ringtoets.GrassCoverErosionInwards.Forms.Test/Views/GrassCoverErosionInwardsFailureMechanismResultViewTest.cs
    • -1
    • +34
    /Ringtoets/GrassCoverErosionInwards/test/Ringtoets.GrassCoverErosionInwards.Forms.Test/Views/GrassCoverErosionInwardsFailureMechanismSectionResultRowTest.cs
10:43 am

Dennis Tang <dennis.tang@deltares.nl>

Introduced mirror property for ClosingStructures failure mechanism: - Used to remove the generic failure mechanism section result step by step

WTI-1621

Options
    • -0
    • +12
    /Ringtoets/ClosingStructures/src/Ringtoets.ClosingStructures.Data/ClosingStructuresFailureMechanism.cs
    • -0
    • +6
    /Ringtoets/ClosingStructures/test/Ringtoets.ClosingStructures.Data.Test/ClosingStructuresFailureMechanismTest.cs
10:01 am

Elmar Kleijn

Review related changes => Ensured WaveImpactAsphaltCoverFailureMechanismMetaEntityReadExtensions is actually used

WTI-1531

Options
    • -7
    • +10
    /Application/Ringtoets/src/Application.Ringtoets.Storage/Read/FailureMechanismEntityReadExtensions.cs
    • -8
    • +9
    /Application/Ringtoets/src/Application.Ringtoets.Storage/Read/PipingStructure/PipingStructureSectionResultEntityReadExtensions.cs
9:48 am

Carlos Lubbers

Add simple assessment column to the strength stability lengthwise construction result view WTI-1617

Options
    • -0
    • +17
    /Ringtoets/Integration/src/Ringtoets.Integration.Forms/Views/SectionResultRows/StrengthStabilityLengthwiseConstructionSectionResultRow.cs
    • -7
    • +14
    /Ringtoets/Integration/src/Ringtoets.Integration.Forms/Views/SectionResultViews/StrengthStabilityLengthwiseConstructionResultView.cs
    • -0
    • +29
    /Ringtoets/Integration/test/Ringtoets.Integration.Forms.Test/Views/SectionResultRows/StrengthStabilityLengthwiseConstructionSectionResultRowTest.cs
    • -19
    • +37
    /Ringtoets/Integration/test/Ringtoets.Integration.Forms.Test/Views/SectionResultViews/StrengthStabilityLengthwiseConstructionResultViewTest.cs
9:38 am

Robert Tangerman <robert.tangerman@deltares.nl>

Cleaned AssemblyToolCategoriesCalculationService. WTI-1616

Options
    • -3
    • +1
    /Ringtoets/Common/src/Ringtoets.Common.Service/AssemblyTool/AssemblyToolCategoriesCalculationService.cs
9:30 am

Elmar Kleijn

Review related changes => Made summaries consistent

WTI-1531

Options
    • -4
    • +4
    /Application/Ringtoets/src/Application.Ringtoets.Storage/Read/ClosingStructures/ClosingStructuresFailureMechanismMetaEntityReadExtensions.cs
    • -5
    • +4
    /Application/Ringtoets/src/Application.Ringtoets.Storage/Read/DuneErosion/DuneErosionFailureMechanismMetaEntityReadExtensions.cs
    • -4
    • +4
    /Application/Ringtoets/src/Application.Ringtoets.Storage/Read/GrassCoverErosionInwards/GrassCoverErosionInwardsFailureMechanismMetaEntityReadExtensions.cs
    • -5
    • +4
    /Application/Ringtoets/src/Application.Ringtoets.Storage/Read/GrassCoverErosionOutwards/GrassCoverErosionInwardsFailureMechanismMetaEntityReadExtensions.cs
    • -4
    • +4
    /Application/Ringtoets/src/Application.Ringtoets.Storage/Read/HeightStructures/HeightStructuresFailureMechanismMetaEntityReadExtensions.cs
    • -6
    • +5
    /Application/Ringtoets/src/Application.Ringtoets.Storage/Read/MacroStabilityInwards/MacroStabilityInwardsFailureMechanismMetaEntityReadExtensions.cs
    • -7
    • +6
    /Application/Ringtoets/src/Application.Ringtoets.Storage/Read/MacroStabilityOutwards/MacroStabilityOutwardsFailureMechanismMetaEntityReadExtensions.cs
    • -13
    • +13
    /Application/Ringtoets/src/Application.Ringtoets.Storage/Read/Piping/PipingFailureMechanismMetaEntityReadExtensions.cs
    • -4
    • +4
    /Application/Ringtoets/src/Application.Ringtoets.Storage/Read/StabilityPointStructures/StabilityPointStructureFailureMechanismMetaEntityReadExtensions.cs
    • -4
    • +4
    /Application/Ringtoets/src/Application.Ringtoets.Storage/Read/StabilityStoneCover/StabilityStoneCoverFailureMechanismMetaEntityReadExtensions.cs
    • -4
    • +4
    /Application/Ringtoets/src/Application.Ringtoets.Storage/Read/WaveImpactAsphaltCover/WaveImpactAsphaltCoverFailureMechanismMetaEntityReadExtensions.cs
9:02 am

Carlos Lubbers

Add simple assessment column to the technical innovations result view WTI-1617

Options
    • -0
    • +17
    /Ringtoets/Integration/src/Ringtoets.Integration.Forms/Views/SectionResultRows/TechnicalInnovationSectionResultRow.cs
    • -7
    • +14
    /Ringtoets/Integration/src/Ringtoets.Integration.Forms/Views/SectionResultViews/TechnicalInnovationResultView.cs
    • -0
    • +29
    /Ringtoets/Integration/test/Ringtoets.Integration.Forms.Test/Views/SectionResultRows/TechnicalInnovationSectionResultRowTest.cs
    • -19
    • +37
    /Ringtoets/Integration/test/Ringtoets.Integration.Forms.Test/Views/SectionResultViews/TechnicalInnovationResultViewTest.cs
8:32 am

Robert Tangerman <robert.tangerman@deltares.nl>

Implemented CalculateGeotechnicFailureMechanismSectionCategories method in calculator. WTI-1616

Options
    • -1
    • +13
    /Ringtoets/AssemblyTool/src/Ringtoets.AssemblyTool.KernelWrapper/Calculators/Categories/AssemblyCategoriesCalculator.cs
    • -0
    • +86
    /Ringtoets/AssemblyTool/test/Ringtoets.AssemblyTool.KernelWrapper.Test/Calculators/Categories/AssemblyCategoriesCalculatorTest.cs
8:28 am

Robert Tangerman <robert.tangerman@deltares.nl>

CalculateGeoTechnicFailureMechanismSectionCategories --> CalculateGeotechnicFailureMechanismSectionCategories. WTI-1616

Options
    • -1
    • +1
    /Ringtoets/AssemblyTool/src/Ringtoets.AssemblyTool.KernelWrapper/Calculators/Categories/AssemblyCategoriesCalculator.cs
    • -1
    • +1
    /Ringtoets/AssemblyTool/src/Ringtoets.AssemblyTool.KernelWrapper/Calculators/Categories/IAssemblyCategoriesCalculator.cs
    • -6
    • +6
    /Ringtoets/AssemblyTool/test/Ringtoets.AssemblyTool.KernelWrapper.TestUtil.Test/Calculators/Categories/AssemblyCategoriesCalculatorStubTest.cs
    • -1
    • +1
    /Ringtoets/AssemblyTool/test/Ringtoets.AssemblyTool.KernelWrapper.TestUtil/Calculators/Categories/AssemblyCategoriesCalculatorStub.cs
8:28 am

Dennis Tang <dennis.tang@deltares.nl>

Set Copy local to FALSE for added AssemblyTool.KernelWrapper reference in .Data projects

WTI-1620

Options
    • -0
    • +1
    /Ringtoets/Integration/src/Ringtoets.Integration.Data/Ringtoets.Integration.Data.csproj
8:27 am

Robert Tangerman <robert.tangerman@deltares.nl>

Made calculator stub output private setable. WTI-1616

Options
    • -54
    • +3
    /Ringtoets/AssemblyTool/test/Ringtoets.AssemblyTool.KernelWrapper.TestUtil.Test/Calculators/Categories/AssemblyCategoriesCalculatorStubTest.cs
    • -4
    • +4
    /Ringtoets/AssemblyTool/test/Ringtoets.AssemblyTool.KernelWrapper.TestUtil/Calculators/Categories/AssemblyCategoriesCalculatorStub.cs
8:26 am

Robert Tangerman <robert.tangerman@deltares.nl>

Added CalculateGeoTechnicFailureMechanismSectionCategories method to calculator interface and stub. WTI-1616

Options
    • -0
    • +8
    /Ringtoets/AssemblyTool/src/Ringtoets.AssemblyTool.KernelWrapper/Calculators/Categories/AssemblyCategoriesCalculator.cs
    • -0
    • +14
    /Ringtoets/AssemblyTool/src/Ringtoets.AssemblyTool.KernelWrapper/Calculators/Categories/IAssemblyCategoriesCalculator.cs
    • -0
    • +88
    /Ringtoets/AssemblyTool/test/Ringtoets.AssemblyTool.KernelWrapper.TestUtil.Test/Calculators/Categories/AssemblyCategoriesCalculatorStubTest.cs
    • -0
    • +22
    /Ringtoets/AssemblyTool/test/Ringtoets.AssemblyTool.KernelWrapper.TestUtil/Calculators/Categories/AssemblyCategoriesCalculatorStub.cs
7:50 am

Robert Tangerman <robert.tangerman@deltares.nl>

LowerBoundaryNorm --> LowerLimitNorm. WTI-1616

Options
    • -3
    • +3
    /Ringtoets/AssemblyTool/test/Ringtoets.AssemblyTool.KernelWrapper.TestUtil.Test/Kernels/Categories/AssemblyCategoriesKernelStubTest.cs
    • -1
    • +1
    /Ringtoets/AssemblyTool/test/Ringtoets.AssemblyTool.KernelWrapper.TestUtil/Kernels/Categories/AssemblyCategoriesKernelStub.cs
Tuesday 13 Feb 2018
4:56 pm

Elmar Kleijn

Review related changes => Made resource names consistent

WTI-1531

Options
    • -2
    • +2
    /Ringtoets/Common/src/Ringtoets.Common.Forms/Factories/RingtoetsMapDataFeaturesFactory.cs
    • -8
    • +8
    /Ringtoets/Common/src/Ringtoets.Common.Forms/Properties/Resources.Designer.cs
    • -4
    • +4
    /Ringtoets/Common/src/Ringtoets.Common.Forms/Properties/Resources.resx
    • -1
    • +1
    /Ringtoets/Common/src/Ringtoets.Common.Forms/PropertyClasses/FailureMechanismSectionProbabilityAssessmentProperties.cs
    • -1
    • +1
    /Ringtoets/Common/src/Ringtoets.Common.Forms/PropertyClasses/FailureMechanismSectionProperties.cs
    • -1
    • +1
    /Ringtoets/Common/src/Ringtoets.Common.Forms/Views/FailureMechanismSectionsTable.cs
    • -1
    • +1
    /Ringtoets/Integration/src/Ringtoets.Integration.Forms/PropertyClasses/ReferenceLineProperties.cs
    • -1
    • +1
    /Ringtoets/Integration/src/Ringtoets.Integration.Forms/PropertyClasses/StandAlone/MacroStabilityOutwardsFailureMechanismProperties.cs
    • -1
    • +1
    /Ringtoets/MacroStabilityInwards/src/Ringtoets.MacroStabilityInwards.Forms/PropertyClasses/MacroStabilityInwardsFailureMechanismProperties.cs
    • -1
    • +1
    /Ringtoets/Piping/src/Ringtoets.Piping.Forms/PropertyClasses/PipingFailureMechanismProperties.cs
    • -1
    • +1
    /Ringtoets/WaveImpactAsphaltCover/src/Ringtoets.WaveImpactAsphaltCover.Forms/PropertyClasses/WaveImpactAsphaltCoverFailureMechanismProperties.cs
4:49 pm

Elmar Kleijn

Review related changes => Completed some rename actions

WTI-1531

Options
    • -2
    • +2
    /Application/Ringtoets/src/Application.Ringtoets.Storage/Read/AssessmentSectionEntityReadExtensions.cs
    • -1
    • +1
    /Application/Ringtoets/src/Application.Ringtoets.Storage/Read/FailureMechanismEntityReadExtensions.cs
    • -1
    • +1
    /Application/Ringtoets/src/Application.Ringtoets.Storage/Read/PipingStructure/PipingStructureSectionResultEntityReadExtensions.cs
    • -1
    • +1
    /Application/Ringtoets/test/Application.Ringtoets.Storage.Test/Application.Ringtoets.Storage.Test.csproj
    • -0
    • +114
    /Application/Ringtoets/test/Application.Ringtoets.Storage.Test/Read/PipingStructure/PipingStructureSectionResultEntityReadExtensionsTest.cs
    • -114
    • +0
    /Application/Ringtoets/test/Application.Ringtoets.Storage.Test/Read/PipingStructures/PipingStructureSectionResultEntityReadExtensionsTest.cs
    • -9
    • +9
    /Ringtoets/Integration/src/Ringtoets.Integration.Plugin/RingtoetsPlugin.cs
    • -4
    • +4
    /Ringtoets/Integration/test/Ringtoets.Integration.Data.Test/AssessmentSectionTest.cs
    • -3
    • +3
    /Ringtoets/Integration/test/Ringtoets.Integration.Plugin.Test/TreeNodeInfos/AssessmentSectionTreeNodeInfoTest.cs
4:31 pm

Dennis Tang <dennis.tang@deltares.nl>

Incorporated comments review 2472: - Renamed lower boundary norm -> lower limit norm

WTI-1618

Options
    • -5
    • +8
    /Ringtoets/AssemblyTool/src/Ringtoets.AssemblyTool.KernelWrapper/Calculators/Categories/AssemblyCategoriesCalculator.cs
    • -4
    • +4
    /Ringtoets/AssemblyTool/src/Ringtoets.AssemblyTool.KernelWrapper/Calculators/Categories/IAssemblyCategoriesCalculator.cs
    • -14
    • +14
    /Ringtoets/AssemblyTool/test/Ringtoets.AssemblyTool.KernelWrapper.Test/Calculators/Categories/AssemblyCategoriesCalculatorTest.cs
    • -6
    • +6
    /Ringtoets/AssemblyTool/test/Ringtoets.AssemblyTool.KernelWrapper.TestUtil.Test/Calculators/Categories/AssemblyCategoriesCalculatorStubTest.cs
    • -7
    • +7
    /Ringtoets/AssemblyTool/test/Ringtoets.AssemblyTool.KernelWrapper.TestUtil.Test/Kernels/Categories/AssemblyCategoriesKernelStubTest.cs
    • -6
    • +6
    /Ringtoets/AssemblyTool/test/Ringtoets.AssemblyTool.KernelWrapper.TestUtil/Calculators/Categories/AssemblyCategoriesCalculatorStub.cs
    • -4
    • +4
    /Ringtoets/AssemblyTool/test/Ringtoets.AssemblyTool.KernelWrapper.TestUtil/Kernels/Categories/AssemblyCategoriesKernelStub.cs
    • -3
    • +3
    /Ringtoets/Common/src/Ringtoets.Common.Service/AssemblyTool/AssemblyToolCategoriesCalculationService.cs
    • -5
    • +5
    /Ringtoets/Common/test/Ringtoets.Common.Service.Test/AssemblyTool/AssemblyToolCategoriesCalculationServiceTest.cs
4:30 pm

Carlos Lubbers

Add simple assessment column to the piping structure result view WTI-1617

Options
    • -0
    • +16
    /Ringtoets/Integration/src/Ringtoets.Integration.Forms/Views/SectionResultRows/PipingStructureSectionResultRow.cs
    • -6
    • +13
    /Ringtoets/Integration/src/Ringtoets.Integration.Forms/Views/SectionResultViews/PipingStructureResultView.cs
    • -0
    • +29
    /Ringtoets/Integration/test/Ringtoets.Integration.Forms.Test/Views/SectionResultRows/PipingStructureSectionResultRowTest.cs
    • -21
    • +42
    /Ringtoets/Integration/test/Ringtoets.Integration.Forms.Test/Views/SectionResultViews/PipingStructureResultViewTest.cs
4:15 pm

Dennis Tang <dennis.tang@deltares.nl>

Incorporated comments review 2472: - Got rid of the AssemblyCategoryConversionException as there's nothing to be converted

WTI-1618

Options
    • -68
    • +0
    /Ringtoets/Common/src/Ringtoets.Common.Data/Exceptions/AssemblyCategoryConversionException.cs
    • -1
    • +0
    /Ringtoets/Common/src/Ringtoets.Common.Data/Ringtoets.Common.Data.csproj
    • -1
    • +1
    /Ringtoets/Common/src/Ringtoets.Common.Service/AssemblyTool/AssemblyToolCategoriesCalculationService.cs
    • -31
    • +0
    /Ringtoets/Common/test/Ringtoets.Common.Data.Test/Exceptions/AssemblyCategoryConversionExceptionTest.cs
    • -1
    • +0
    /Ringtoets/Common/test/Ringtoets.Common.Data.Test/Ringtoets.Common.Data.Test.csproj
4:09 pm

Carlos Lubbers

Add simple assessment column to the grass cover erosion outwards cover result view WTI-1617

Options
    • -2
    • +2
    /Ringtoets/Common/src/Ringtoets.Common.Data/FailureMechanism/SimpleAssessmentResultType.cs
    • -2
    • +2
    /Ringtoets/Common/src/Ringtoets.Common.Data/FailureMechanism/SimpleAssessmentResultValidityOnlyType.cs
    • -0
    • +16
    /Ringtoets/Integration/src/Ringtoets.Integration.Forms/Views/SectionResultRows/GrassCoverSlipOffOutwardsSectionResultRow.cs
    • -6
    • +13
    /Ringtoets/Integration/src/Ringtoets.Integration.Forms/Views/SectionResultViews/GrassCoverSlipOffOutwardsResultView.cs
    • -0
    • +29
    /Ringtoets/Integration/test/Ringtoets.Integration.Forms.Test/Views/SectionResultRows/GrassCoverSlipOffOutwardsSectionResultRowTest.cs
    • -21
    • +43
    /Ringtoets/Integration/test/Ringtoets.Integration.Forms.Test/Views/SectionResultViews/GrassCoverSlipOffOutwardsResultViewTest.cs
3:57 pm

Dennis Tang <dennis.tang@deltares.nl>

Incorporated comments review 2472: - Added ArgumentException for the AssessmentSectionAssemblyCategoryCreator: -- To be thrown when the output collection contains null items. - Improved tests: -- Make use of random.GetFromRange() instead of random.Next() -- Made output get only for the FailureMechanismSectionAssemblyCalculatorStub -- Added asserts for initial values of the calculator / kernel stubs

WTI-1618

Options
    • -0
    • +6
    /Ringtoets/AssemblyTool/src/Ringtoets.AssemblyTool.KernelWrapper/Creators/AssemblyCategoryCreator.cs
    • -8
    • +8
    /Ringtoets/AssemblyTool/test/Ringtoets.AssemblyTool.KernelWrapper.Test/Calculators/Categories/AssemblyCategoriesCalculatorTest.cs
    • -0
    • +21
    /Ringtoets/AssemblyTool/test/Ringtoets.AssemblyTool.KernelWrapper.Test/Creators/AssemblyCategoryCreatorTest.cs
    • -32
    • +4
    /Ringtoets/AssemblyTool/test/Ringtoets.AssemblyTool.KernelWrapper.TestUtil.Test/Calculators/Assembly/FailureMechanismSectionAssemblyCalculatorStubTest.cs
    • -2
    • +5
    /Ringtoets/AssemblyTool/test/Ringtoets.AssemblyTool.KernelWrapper.TestUtil.Test/Kernels/Categories/AssemblyCategoriesKernelStubTest.cs
    • -3
    • +2
    /Ringtoets/AssemblyTool/test/Ringtoets.AssemblyTool.KernelWrapper.TestUtil/Calculators/Assembly/FailureMechanismSectionAssemblyCalculatorStub.cs
3:54 pm

Carlos Lubbers

Add simple assessment column to the grass cover slip off inwards result view WTI-1617

Options
    • -7
    • +7
    /Ringtoets/GrassCoverErosionOutwards/test/Ringtoets.GrassCoverErosionOutwards.Forms.Test/Views/GrassCoverErosionOutwardsFailureMechanismResultViewTest.cs
    • -0
    • +16
    /Ringtoets/Integration/src/Ringtoets.Integration.Forms/Views/SectionResultRows/GrassCoverSlipOffInwardsSectionResultRow.cs
    • -6
    • +13
    /Ringtoets/Integration/src/Ringtoets.Integration.Forms/Views/SectionResultViews/GrassCoverSlipOffInwardsResultView.cs
    • -0
    • +29
    /Ringtoets/Integration/test/Ringtoets.Integration.Forms.Test/Views/SectionResultRows/GrassCoverSlipOffInwardsSectionResultRowTest.cs
    • -21
    • +43
    /Ringtoets/Integration/test/Ringtoets.Integration.Forms.Test/Views/SectionResultViews/GrassCoverSlipOffInwardsResultViewTest.cs
    • -7
    • +7
    /Ringtoets/Integration/test/Ringtoets.Integration.Forms.Test/Views/SectionResultViews/WaterPressureAsphaltCoverResultViewTest.cs