Riskeer / Ringtoets / Integration

src

Clone Tools

Stats

Commits this week: 0
Total Committers: 12
Last Commit: 26 Nov
Commits this week: 0

Lines of code count not available

Commit Activity

Commits By Day In Week
52 week commits volume
Commits By Day In Week
Commits by day
Commits By Day In Week
Commits by hour
Commits By Hour In Day
Commit calendar
 

Most active committers (90 days)

loading
loading
  • last updated a few seconds ago
All Commits Reviews
Constraints
Constraints: committers
 
Constraints: files
Constraints: dates
Friday 18 Jan 2019
8:50 am

Robert Tangerman <robert.tangerman@deltares.nl>

Improvements after review. WTI-1927

Options
    • -2
    • +2
    ./Ringtoets.Integration.IO/Importers/HydraulicLocationConfigurationDatabaseImporter.cs
  2. … 1 more file in changeset.
Thursday 17 Jan 2019
4:51 pm

Dennis Tang <dennis.tang@deltares.nl>

Incorporated comments tester: WTI-1925

- Fixed log message when table ScenarioInformation is not present in the HLCD

Options
    • -1
    • +1
    ./Ringtoets.Integration.Plugin/Properties/Resources.Designer.cs
    • -1
    • +1
    ./Ringtoets.Integration.Plugin/Properties/Resources.resx
  3. … 3 more files in changeset.
Wednesday 16 Jan 2019
4:38 pm

Dennis Tang <dennis.tang@deltares.nl>

Incorporated comments review 3449: WTI-1927

- Added HydraulicBoundaryDatabase as constructor argument for the HydraulicLocationConfigurationImportHandler

-- Maintained the location configuration settings as an argument as it must remain clear which object is updated by using the interface.

Options
    • -1
    • +2
    ./Ringtoets.Integration.Forms/PropertyClasses/HydraulicBoundaryDatabaseProperties.cs
    • -4
    • +4
    ./Ringtoets.Integration.Forms/PropertyClasses/IHydraulicLocationConfigurationDatabaseImportHandler.cs
    • -5
    • +14
    ./Ringtoets.Integration.Plugin/Handlers/HydraulicLocationConfigurationDatabaseImportHandler.cs
    • -1
    • +1
    ./Ringtoets.Integration.Plugin/RingtoetsPlugin.cs
  5. … 2 more files in changeset.
4:17 pm

Dennis Tang <dennis.tang@deltares.nl>

Incorporated comments review 3449: WTI-1927

- Improved HydraulicBoundaryDatabaseProperties:

-- Updated and improved tests

-- Changed display logic: display values based on whether the HRD is linked (AND null in case of optional properties)

Options
    • -10
    • +16
    ./Ringtoets.Integration.Forms/PropertyClasses/HydraulicBoundaryDatabaseProperties.cs
  2. … 1 more file in changeset.
4:00 pm

Dennis Tang <dennis.tang@deltares.nl>

Incorporated comments review 3449: WTI-1927

- Cleaned up files

-- Improved tests

Options
    • -1
    • +0
    ./Ringtoets.Integration.Forms/Ringtoets.Integration.Forms.csproj
    • -3
    • +5
    ./Ringtoets.Integration.Plugin/RingtoetsPlugin.cs
  3. … 1 more file in changeset.
Tuesday 15 Jan 2019
4:03 pm

Dennis Tang <dennis.tang@deltares.nl>

Updated editor: WTI-1927

- Changed base type editor from FileNameEditor to UIEditor to enable selection of a HLCD file.

Options
    • -1
    • +1
    ./Ringtoets.Integration.Forms/PropertyClasses/HydraulicBoundaryDatabaseProperties.cs
  2. … 1 more file in changeset.
2:12 pm

Robert Tangerman <robert.tangerman@deltares.nl>

Clear all output. WTI-1927

Options
    • -0
    • +1
    ./Ringtoets.Integration.Plugin/Handlers/HydraulicLocationConfigurationDatabaseUpdateHandler.cs
  2. … 1 more file in changeset.
1:59 pm

Dennis Tang <dennis.tang@deltares.nl>

Incorporated comments review 3445: WTI-1925

- Cleaned up code

- Moved logging from the importer to the update helper

-- Cleaned up resources

-- Cleaned up tests

Options
    • -6
    • +2
    ./Ringtoets.Integration.IO/Importers/HydraulicBoundaryDatabaseImporter.cs
    • -9
    • +0
    ./Ringtoets.Integration.IO/Properties/Resources.Designer.cs
    • -3
    • +0
    ./Ringtoets.Integration.IO/Properties/Resources.resx
    • -0
    • +6
    ./Ringtoets.Integration.Plugin/Helpers/HydraulicLocationConfigurationSettingsUpdateHelper.cs
    • -0
    • +10
    ./Ringtoets.Integration.Plugin/Properties/Resources.Designer.cs
    • -0
    • +3
    ./Ringtoets.Integration.Plugin/Properties/Resources.resx
  7. … 5 more files in changeset.
10:54 am

Dennis Tang <dennis.tang@deltares.nl>

Extracted HLCD file name editor: WTI-1927

- Editor extracted to allow overrides for a custom file filter.

- Fixed failing test of the property info which is introdcued due to a dependency on the GUI.MainWindow

Options
    • -0
    • +39
    ./Ringtoets.Integration.Forms/Editors/HlcdFileNameEditor.cs
    • -0
    • +9
    ./Ringtoets.Integration.Forms/Properties/Resources.Designer.cs
    • -0
    • +3
    ./Ringtoets.Integration.Forms/Properties/Resources.resx
    • -1
    • +2
    ./Ringtoets.Integration.Forms/PropertyClasses/HydraulicBoundaryDatabaseProperties.cs
    • -0
    • +2
    ./Ringtoets.Integration.Forms/Ringtoets.Integration.Forms.csproj
  6. … 4 more files in changeset.
10:02 am

Dennis Tang <dennis.tang@deltares.nl>

Introduced string description for the import HLCD activity. WTI-1927

Options
    • -1
    • +2
    ./Ringtoets.Integration.Plugin/Handlers/HydraulicLocationConfigurationDatabaseImportHandler.cs
    • -0
    • +10
    ./Ringtoets.Integration.Plugin/Properties/Resources.Designer.cs
    • -0
    • +3
    ./Ringtoets.Integration.Plugin/Properties/Resources.resx
Monday 14 Jan 2019
4:04 pm

Dennis Tang <dennis.tang@deltares.nl>

Added ReadOnly property for the HLCD filepath. WTI-1927

- File path should not be editable in case there's no hydraulic boundary database linked.

Options
    • -1
    • +25
    ./Ringtoets.Integration.Forms/PropertyClasses/HydraulicBoundaryDatabaseProperties.cs
  2. … 1 more file in changeset.
3:20 pm

Dennis Tang <dennis.tang@deltares.nl>

Renamed interface method definition. WTI-1927

Options
    • -1
    • +1
    ./Ringtoets.Integration.Forms/PropertyClasses/HydraulicBoundaryDatabaseProperties.cs
    • -1
    • +1
    ./Ringtoets.Integration.Forms/PropertyClasses/IHydraulicLocationConfigurationDatabaseImportHandler.cs
    • -1
    • +1
    ./Ringtoets.Integration.Plugin/Handlers/HydraulicLocationConfigurationDatabaseImportHandler.cs
  4. … 2 more files in changeset.
3:19 pm

Dennis Tang <dennis.tang@deltares.nl>

Added implementation of the import handler. WTI-1927

Options
    • -0
    • +2
    ./Ringtoets.Integration.Forms/PropertyClasses/IHydraulicLocationConfigurationDatabaseImportHandler.cs
    • -1
    • +48
    ./Ringtoets.Integration.Plugin/Handlers/HydraulicLocationConfigurationDatabaseImportHandler.cs
    • -5
    • +16
    ./Ringtoets.Integration.Plugin/RingtoetsPlugin.cs
  4. … 5 more files in changeset.
3:02 pm

Robert Tangerman <robert.tangerman@deltares.nl>

Added clearing output. WTI-1927

Options
    • -0
    • +3
    ./Ringtoets.Integration.Plugin/Handlers/HydraulicLocationConfigurationDatabaseUpdateHandler.cs
  2. … 1 more file in changeset.
2:21 pm

Robert Tangerman <robert.tangerman@deltares.nl>

Added constructor parameter. WTI-1927

Options
    • -0
    • +19
    ./Ringtoets.Integration.Plugin/Handlers/HydraulicLocationConfigurationDatabaseUpdateHandler.cs
  2. … 1 more file in changeset.
2:15 pm

Robert Tangerman <robert.tangerman@deltares.nl>

Return changed objects. WTI-1927

Options
    • -1
    • +6
    ./Ringtoets.Integration.Plugin/Handlers/HydraulicLocationConfigurationDatabaseUpdateHandler.cs
  2. … 1 more file in changeset.
2:07 pm

Robert Tangerman <robert.tangerman@deltares.nl>

Set settings in update handler. WTI-1927

Options
    • -2
    • +4
    ./Ringtoets.Integration.IO/Handlers/IHydraulicLocationConfigurationDatabaseUpdateHandler.cs
    • -6
    • +6
    ./Ringtoets.Integration.Plugin/Handlers/HydraulicLocationConfigurationDatabaseUpdateHandler.cs
  3. … 1 more file in changeset.
1:47 pm

Robert Tangerman <robert.tangerman@deltares.nl>

Cleanup. WTI-1927

Options
    • -22
    • +24
    ./Ringtoets.Integration.Plugin/Helpers/HydraulicLocationConfigurationSettingsUpdateHelper.cs
1:46 pm

Robert Tangerman <robert.tangerman@deltares.nl>

Use helper in handler. WTI-1927

Options
    • -41
    • +4
    ./Ringtoets.Integration.Plugin/Handlers/HydraulicBoundaryDatabaseUpdateHandler.cs
1:45 pm

Robert Tangerman <robert.tangerman@deltares.nl>

Moved helper to Helpers folder and moved constants to separate file. WTI-1927

Options
    • -88
    • +0
    ./Ringtoets.Integration.Plugin/Handlers/HydraulicLocationConfigurationSettingsUpdateHelper.cs
    • -0
    • +36
    ./Ringtoets.Integration.Plugin/Helpers/HydraulicLocationConfigurationSettingsConstants.cs
    • -0
    • +83
    ./Ringtoets.Integration.Plugin/Helpers/HydraulicLocationConfigurationSettingsUpdateHelper.cs
    • -1
    • +3
    ./Ringtoets.Integration.Plugin/Properties/AssemblyInfo.cs
    • -1
    • +2
    ./Ringtoets.Integration.Plugin/Ringtoets.Integration.Plugin.csproj
  6. … 4 more files in changeset.
1:36 pm

Robert Tangerman <robert.tangerman@deltares.nl>

Introduced helper for setting the settings. WTI-1927

Options
    • -0
    • +88
    ./Ringtoets.Integration.Plugin/Handlers/HydraulicLocationConfigurationSettingsUpdateHelper.cs
    • -0
    • +1
    ./Ringtoets.Integration.Plugin/Ringtoets.Integration.Plugin.csproj
  3. … 2 more files in changeset.
12:55 pm

Robert Tangerman <robert.tangerman@deltares.nl>

Added null checks. WTI-1927

Options
    • -0
    • +15
    ./Ringtoets.Integration.Plugin/Handlers/HydraulicLocationConfigurationDatabaseUpdateHandler.cs
  2. … 1 more file in changeset.
12:50 pm

Robert Tangerman <robert.tangerman@deltares.nl>

Added confirmation dialog. WTI-1927

Options
    • -2
    • +9
    ./Ringtoets.Integration.Plugin/Handlers/HydraulicLocationConfigurationDatabaseUpdateHandler.cs
    • -0
    • +12
    ./Ringtoets.Integration.Plugin/Properties/Resources.Designer.cs
    • -0
    • +5
    ./Ringtoets.Integration.Plugin/Properties/Resources.resx
  4. … 1 more file in changeset.
11:57 am

Robert Tangerman <robert.tangerman@deltares.nl>

Changed handler API. WTI-1927

Options
    • -3
    • +3
    ./Ringtoets.Integration.IO/Handlers/IHydraulicLocationConfigurationDatabaseUpdateHandler.cs
    • -1
    • +1
    ./Ringtoets.Integration.IO/Importers/HydraulicLocationConfigurationDatabaseImporter.cs
    • -1
    • +1
    ./Ringtoets.Integration.Plugin/Handlers/HydraulicLocationConfigurationDatabaseUpdateHandler.cs
  4. … 1 more file in changeset.
11:56 am

Robert Tangerman <robert.tangerman@deltares.nl>

Introduced update handler. WTI-1927

Options
    • -0
    • +47
    ./Ringtoets.Integration.Plugin/Handlers/HydraulicLocationConfigurationDatabaseUpdateHandler.cs
    • -0
    • +1
    ./Ringtoets.Integration.Plugin/Ringtoets.Integration.Plugin.csproj
  3. … 2 more files in changeset.
11:43 am

Robert Tangerman <robert.tangerman@deltares.nl>

Added location id validation. WTI-1927

Options
    • -0
    • +10
    ./Ringtoets.Integration.IO/Importers/HydraulicLocationConfigurationDatabaseImporter.cs
    • -0
    • +9
    ./Ringtoets.Integration.IO/Properties/Resources.Designer.cs
    • -0
    • +3
    ./Ringtoets.Integration.IO/Properties/Resources.resx
  4. … 3 more files in changeset.
10:48 am

Dennis Tang <dennis.tang@deltares.nl>

Introduced import handler to handle with HLCD imports from the hydraulic boundary database property panel: WTI-1927

- Added empty handler class to be substituted in the RingtoetsPlugin to prevent ArgumentNullExceptions on runtime.

Options
    • -5
    • +18
    ./Ringtoets.Integration.Forms/PropertyClasses/HydraulicBoundaryDatabaseProperties.cs
    • -0
    • +40
    ./Ringtoets.Integration.Forms/PropertyClasses/IHydraulicLocationConfigurationDatabaseImportHandler.cs
    • -0
    • +1
    ./Ringtoets.Integration.Forms/Ringtoets.Integration.Forms.csproj
    • -0
    • +38
    ./Ringtoets.Integration.Plugin/Handlers/HydraulicLocationConfigurationDatabaseImportHandler.cs
    • -0
    • +1
    ./Ringtoets.Integration.Plugin/Ringtoets.Integration.Plugin.csproj
    • -1
    • +1
    ./Ringtoets.Integration.Plugin/RingtoetsPlugin.cs
  7. … 3 more files in changeset.
9:59 am

Robert Tangerman <robert.tangerman@deltares.nl>

First ask confirmation. WTI-1927

Options
    • -8
    • +8
    ./Ringtoets.Integration.IO/Importers/HydraulicLocationConfigurationDatabaseImporter.cs
  2. … 1 more file in changeset.
Sunday 13 Jan 2019
10:40 am

Robert Tangerman <robert.tangerman@deltares.nl>

Added DoPostImportUpdates. WTI-1927

Options
    • -0
    • +10
    ./Ringtoets.Integration.IO/Importers/HydraulicLocationConfigurationDatabaseImporter.cs
  2. … 1 more file in changeset.
Friday 11 Jan 2019
3:37 pm

Dennis Tang <dennis.tang@deltares.nl>

Incorporated comments PO: WTI-1925

- Changed default values for the HLCD information when there's no ScenarioInformation present in order to make it more insightful that default values are used.

Options
    • -1
    • +2
    ./Ringtoets.Integration.Plugin/Handlers/HydraulicBoundaryDatabaseUpdateHandler.cs
  2. … 1 more file in changeset.