Riskeer

Clone Tools

Stats

Commits this week: 0
Total Committers: 28
Last Commit: 12 Sep 24
Commits this week: 0

Lines of code count not available

Commit Activity

Commits By Day In Week
52 week commits volume
Commits By Day In Week
Commits by day
Commits By Day In Week
Commits by hour
Commits By Hour In Day
Commit calendar
 

Most active committers (90 days)

loading
loading
  • last updated a few seconds ago
All Commits Reviews
Constraints
Constraints: committers
 
Constraints: files
Constraints: dates
Thursday 23 Aug 2018
2:45 pm

Carlos Lubbers <carlos.lubbers@deltares.nl>

Fix typo WTI-1790

Options
    • -1
    • +1
    /Ringtoets/Integration/src/Ringtoets.Integration.Forms/Views/AssemblyResultTotalView.cs
    • -1
    • +1
    /Ringtoets/Integration/src/Ringtoets.Integration.Forms/Views/FailureMechanismAssemblyCategoryGroupResultRow.cs
    • -2
    • +2
    /Ringtoets/Integration/src/Ringtoets.Integration.Forms/Views/FailureMechanismAssemblyResultRow.cs
    • -1
    • +1
    /Ringtoets/Integration/src/Ringtoets.Integration.Forms/Views/FailureMechanismAssemblyResultRowBase.cs
    • -2
    • +2
    /Ringtoets/Integration/test/Ringtoets.Integration.Forms.Test/Views/AssemblyResultTotalViewTest.cs
    • -3
    • +3
    /Ringtoets/Integration/test/Ringtoets.Integration.Forms.Test/Views/FailureMechanismAssemblyCategoryGroupResultRowTest.cs
    • -2
    • +2
    /Ringtoets/Integration/test/Ringtoets.Integration.Forms.Test/Views/FailureMechanismAssemblyResultRowBaseTest.cs
    • -3
    • +3
    /Ringtoets/Integration/test/Ringtoets.Integration.Forms.Test/Views/FailureMechanismAssemblyResultRowTest.cs
    • -1
    • +1
    /Ringtoets/Migration/src/Ringtoets.Migration.Core/EmbeddedResources/DatabaseStructure18.1.sql
    • -1
    • +1
    /build/DatabaseStructure.sql
    • binary
    /design/DatabaseDesign.eap
2:30 pm

Dennis Tang <dennis.tang@deltares.nl>

Incorporated 3190:

- Removed obsolete test fixture tests

- Updated XMLDoc

Paired with ~carloslubbers

WTI-1789

Options
    • -1
    • +1
    /Core/Common/src/Core.Common.Util/Reflection/TypeUtils.cs
    • -2
    • +0
    /Core/Common/test/Core.Common.TestUtil.Test/Core.Common.TestUtil.Test.csproj
    • -74
    • +0
    /Core/Common/test/Core.Common.TestUtil.Test/EnumValuesTestFixtureTest.cs
    • -86
    • +0
    /Core/Common/test/Core.Common.TestUtil.Test/EnumWithDisplayNameTestFixtureTest.cs
2:28 pm

Carlos Lubbers <carlos.lubbers@deltares.nl>

Cleanup WTI-1789

Options
    • -2
    • +2
    /Ringtoets/AssemblyTool/test/Ringtoets.AssemblyTool.IO.TestUtil/SerializableAttributeTestHelper.cs
2:26 pm

Carlos Lubbers <carlos.lubbers@deltares.nl>

Add null or empty check to id's WTI-1789

Options
    • -3
    • +4
    /Ringtoets/AssemblyTool/src/Ringtoets.AssemblyTool.IO/Model/SerializableAssembly.cs
    • -4
    • +4
    /Ringtoets/AssemblyTool/src/Ringtoets.AssemblyTool.IO/Model/SerializableAssessmentProcess.cs
    • -4
    • +9
    /Ringtoets/AssemblyTool/src/Ringtoets.AssemblyTool.IO/Model/SerializableAssessmentSection.cs
    • -3
    • +4
    /Ringtoets/AssemblyTool/src/Ringtoets.AssemblyTool.IO/Model/SerializableCombinedFailureMechanismSectionAssembly.cs
    • -3
    • +5
    /Ringtoets/AssemblyTool/src/Ringtoets.AssemblyTool.IO/Model/SerializableFailureMechanism.cs
    • -4
    • +9
    /Ringtoets/AssemblyTool/src/Ringtoets.AssemblyTool.IO/Model/SerializableFailureMechanismSection.cs
    • -3
    • +4
    /Ringtoets/AssemblyTool/src/Ringtoets.AssemblyTool.IO/Model/SerializableFailureMechanismSectionAssembly.cs
    • -5
    • +7
    /Ringtoets/AssemblyTool/src/Ringtoets.AssemblyTool.IO/Model/SerializableFailureMechanismSectionCollection.cs
    • -3
    • +4
    /Ringtoets/AssemblyTool/src/Ringtoets.AssemblyTool.IO/Model/SerializableTotalAssemblyResult.cs
    • -14
    • +17
    /Ringtoets/AssemblyTool/test/Ringtoets.AssemblyTool.IO.Test/Model/SerializableAssemblyTest.cs
    • -4
    • +7
    /Ringtoets/AssemblyTool/test/Ringtoets.AssemblyTool.IO.Test/Model/SerializableAssessmentProcessTest.cs
    • -5
    • +8
    /Ringtoets/AssemblyTool/test/Ringtoets.AssemblyTool.IO.Test/Model/SerializableAssessmentSectionTest.cs
    • -4
    • +7
    /Ringtoets/AssemblyTool/test/Ringtoets.AssemblyTool.IO.Test/Model/SerializableCombinedFailureMechanismSectionAssemblyTest.cs
    • -4
    • +6
    /Ringtoets/AssemblyTool/test/Ringtoets.AssemblyTool.IO.Test/Model/SerializableFailureMechanismSectionAssemblyTest.cs
    • -8
    • +12
    /Ringtoets/AssemblyTool/test/Ringtoets.AssemblyTool.IO.Test/Model/SerializableFailureMechanismSectionCollectionTest.cs
  16. … 5 more files in changeset.
2:05 pm

Robert Tangerman <robert.tangerman@deltares.nl>

Added method to get the geometry of a section based on reference line and begin and end points. WTI-1821

Options
    • -0
    • +11
    /Ringtoets/Integration/src/Ringtoets.Integration.IO/Helpers/ExportableFailureMechanismSectionHelper.cs
    • -0
    • +11
    /Ringtoets/Integration/test/Ringtoets.Integration.IO.Test/Helpers/ExportableFailureMechanismSectionHelperTest.cs
1:50 pm

Dennis Tang <dennis.tang@deltares.nl>

Incorporated comments review 3186:

- Introduced helper method to create a lookup between section results and exportable failure mechanism sections

-- Removed obsolete factory

WTI-1790

Options
    • -65
    • +0
    /Ringtoets/Integration/src/Ringtoets.Integration.IO/Factories/ExportableFailureMechanismSectionFactory.cs
    • -1
    • +0
    /Ringtoets/Integration/src/Ringtoets.Integration.IO/Ringtoets.Integration.IO.csproj
    • -105
    • +0
    /Ringtoets/Integration/test/Ringtoets.Integration.IO.Test/Factories/ExportableFailureMechanismSectionFactoryTest.cs
    • -1
    • +0
    /Ringtoets/Integration/test/Ringtoets.Integration.IO.Test/Ringtoets.Integration.IO.Test.csproj
1:48 pm

Dennis Tang <dennis.tang@deltares.nl>

Incorporated comments review 3186:

- Introduced helper method to create a lookup between section results and exportable failure mechanism sections

-- Applied helper method in the existing factories

WTI-1790

Options
    • -14
    • +4
    /Ringtoets/Integration/src/Ringtoets.Integration.IO/Factories/ExportableClosingStructuresFailureMechanismFactory.cs
    • -14
    • +4
    /Ringtoets/Integration/src/Ringtoets.Integration.IO/Factories/ExportableDuneErosionFailureMechanismFactory.cs
    • -14
    • +4
    /Ringtoets/Integration/src/Ringtoets.Integration.IO/Factories/ExportableGrassCoverErosionInwardsFailureMechanismFactory.cs
    • -14
    • +4
    /Ringtoets/Integration/src/Ringtoets.Integration.IO/Factories/ExportableGrassCoverErosionOutwardsFailureMechanismFactory.cs
    • -14
    • +4
    /Ringtoets/Integration/src/Ringtoets.Integration.IO/Factories/ExportableGrassCoverSlipOffInwardsFailureMechanismFactory.cs
    • -14
    • +4
    /Ringtoets/Integration/src/Ringtoets.Integration.IO/Factories/ExportableGrassCoverSlipOffOutwardsFailureMechanismFactory.cs
    • -14
    • +4
    /Ringtoets/Integration/src/Ringtoets.Integration.IO/Factories/ExportableHeightStructuresFailureMechanismFactory.cs
    • -13
    • +4
    /Ringtoets/Integration/src/Ringtoets.Integration.IO/Factories/ExportableMacroStabilityInwardsFailureMechanismFactory.cs
    • -14
    • +4
    /Ringtoets/Integration/src/Ringtoets.Integration.IO/Factories/ExportableMacroStabilityOutwardsFailureMechanismFactory.cs
    • -14
    • +4
    /Ringtoets/Integration/src/Ringtoets.Integration.IO/Factories/ExportableMicrostabilityFailureMechanismFactory.cs
    • -13
    • +4
    /Ringtoets/Integration/src/Ringtoets.Integration.IO/Factories/ExportablePipingFailureMechanismFactory.cs
    • -14
    • +4
    /Ringtoets/Integration/src/Ringtoets.Integration.IO/Factories/ExportablePipingStructureFailureMechanismFactory.cs
    • -14
    • +4
    /Ringtoets/Integration/src/Ringtoets.Integration.IO/Factories/ExportableStabilityPointStructuresFailureMechanismFactory.cs
    • -14
    • +4
    /Ringtoets/Integration/src/Ringtoets.Integration.IO/Factories/ExportableStabilityStoneCoverFailureMechanismFactory.cs
    • -14
    • +4
    /Ringtoets/Integration/src/Ringtoets.Integration.IO/Factories/ExportableStrengthStabilityLengthwiseConstructionFailureMechanismFactory.cs
  16. … 3 more files in changeset.
1:33 pm

Dennis Tang <dennis.tang@deltares.nl>

Incorporated comments review 3186:

- Introduced helper method to create a lookup between section results and exportable failure mechanism sections

-- Refactored method, instead of looping multiple times over the collection, loop once.

WTI-1790

Options
    • -11
    • +16
    /Ringtoets/Integration/src/Ringtoets.Integration.IO/Helpers/ExportableFailureMechanismSectionHelper.cs
1:28 pm

Dennis Tang <dennis.tang@deltares.nl>

Incorporated comments review 3186:

- Introduced helper method to create a lookup between section results and exportable failure mechanism sections

WTI-1790

Options
    • -0
    • +64
    /Ringtoets/Integration/src/Ringtoets.Integration.IO/Helpers/ExportableFailureMechanismSectionHelper.cs
    • -0
    • +1
    /Ringtoets/Integration/src/Ringtoets.Integration.IO/Ringtoets.Integration.IO.csproj
    • -0
    • +96
    /Ringtoets/Integration/test/Ringtoets.Integration.IO.Test/Helpers/ExportableFailureMechanismSectionHelperTest.cs
    • -0
    • +1
    /Ringtoets/Integration/test/Ringtoets.Integration.IO.Test/Ringtoets.Integration.IO.Test.csproj
1:12 pm

Carlos Lubbers <carlos.lubbers@deltares.nl>

Add enum value and fix tests WTI-1789

Options
    • -0
    • +4
    /Core/Components/test/Core.Components.Chart.Test/Core.Components.Chart.Test.csproj
    • -0
    • +5
    /Ringtoets/AssemblyTool/src/Ringtoets.AssemblyTool.IO/Model/Enums/AssemblyXmlEnumIdentifiers.cs
    • -1
    • +7
    /Ringtoets/AssemblyTool/src/Ringtoets.AssemblyTool.IO/Model/Enums/SerializableAssessmentSectionCategoryGroup.cs
    • -0
    • +4
    /Ringtoets/AssemblyTool/test/Ringtoets.AssemblyTool.Data.Test/Ringtoets.AssemblyTool.Data.Test.csproj
    • -0
    • +4
    /Ringtoets/AssemblyTool/test/Ringtoets.AssemblyTool.Forms.Test/Ringtoets.AssemblyTool.Forms.Test.csproj
    • -0
    • +1
    /Ringtoets/AssemblyTool/test/Ringtoets.AssemblyTool.IO.Test/Model/Enums/AssemblyXmlEnumIdentifiersTest.cs
    • -0
    • +6
    /Ringtoets/AssemblyTool/test/Ringtoets.AssemblyTool.IO.Test/Model/Enums/SerializableAssessmentSectionCategoryGroupTest.cs
    • -0
    • +4
    /Ringtoets/ClosingStructures/test/Ringtoets.ClosingStructures.Data.Test/Ringtoets.ClosingStructures.Data.Test.csproj
    • -0
    • +4
    /Ringtoets/Common/test/Ringtoets.Common.Data.Test/Ringtoets.Common.Data.Test.csproj
    • -0
    • +4
    /Ringtoets/Common/test/Ringtoets.Common.Primitives.Test/Ringtoets.Common.Primitives.Test.csproj
    • -0
    • +4
    /Ringtoets/GrassCoverErosionInwards/test/Ringtoets.GrassCoverErosionInwards.Data.Test/Ringtoets.GrassCoverErosionInwards.Data.Test.csproj
    • -0
    • +4
    /Ringtoets/Revetment/test/Ringtoets.Revetment.Data.Test/Ringtoets.Revetment.Data.Test.csproj
11:46 am

Carlos Lubbers <carlos.lubbers@deltares.nl>

Review related changes and cleanup WTI-1789

Options
    • -7
    • +7
    /Ringtoets/AssemblyTool/src/Ringtoets.AssemblyTool.IO/Model/SerializableAssessmentSection.cs
    • -1
    • +1
    /Ringtoets/AssemblyTool/src/Ringtoets.AssemblyTool.IO/Model/SerializableTotalAssemblyResult.cs
    • -0
    • +2
    /Ringtoets/AssemblyTool/src/Ringtoets.AssemblyTool.IO/Ringtoets.AssemblyTool.IO.csproj
    • -0
    • +2
    /Ringtoets/AssemblyTool/test/Ringtoets.AssemblyTool.IO.Test/Model/DataTypes/SerializableAssessmentSectionAssemblyResultTest.cs
    • -0
    • +2
    /Ringtoets/AssemblyTool/test/Ringtoets.AssemblyTool.IO.Test/Model/DataTypes/SerializableFailureMechanismAssemblyResultTest.cs
    • -0
    • +1
    /Ringtoets/AssemblyTool/test/Ringtoets.AssemblyTool.IO.Test/Model/DataTypes/SerializableFailureMechanismSectionAssemblyResultTest.cs
    • -4
    • +2
    /Ringtoets/AssemblyTool/test/Ringtoets.AssemblyTool.IO.Test/Model/DataTypes/SerializableLineTest.cs
    • -4
    • +2
    /Ringtoets/AssemblyTool/test/Ringtoets.AssemblyTool.IO.Test/Model/Gml/SerializableLineStringTest.cs
    • -3
    • +3
    /Ringtoets/AssemblyTool/test/Ringtoets.AssemblyTool.IO.Test/Model/Helpers/GeometrySerializationFormatterTest.cs
    • -3
    • +3
    /Ringtoets/AssemblyTool/test/Ringtoets.AssemblyTool.IO.Test/Model/SerializableAssemblyTest.cs
    • -6
    • +7
    /Ringtoets/AssemblyTool/test/Ringtoets.AssemblyTool.IO.Test/Model/SerializableAssessmentSectionTest.cs
    • -4
    • +5
    /Ringtoets/AssemblyTool/test/Ringtoets.AssemblyTool.IO.Test/SerializableAssemblyWriterTest.cs
    • -10
    • +20
    /Ringtoets/AssemblyTool/test/Ringtoets.AssemblyTool.IO.TestUtil/SerializableAttributeTestHelper.cs
11:45 am

Dennis Tang <dennis.tang@deltares.nl>

Incorporated comments review 3186:

- Renamed calculatorfactory variable to calculatorFactory

-- Only for affected namespaces

WTI-1790

Options
    • -3
    • +3
    /Ringtoets/Integration/test/Ringtoets.Integration.IO.Test/Factories/ExportableAssessmentSectionFactoryTest.cs
    • -3
    • +3
    /Ringtoets/Integration/test/Ringtoets.Integration.IO.Test/Factories/ExportableClosingStructuresFailureMechanismFactoryTest.cs
    • -3
    • +3
    /Ringtoets/Integration/test/Ringtoets.Integration.IO.Test/Factories/ExportableDuneErosionFailureMechanismFactoryTest.cs
    • -3
    • +3
    /Ringtoets/Integration/test/Ringtoets.Integration.IO.Test/Factories/ExportableGrassCoverErosionInwardsFailureMechanismFactoryTest.cs
    • -3
    • +3
    /Ringtoets/Integration/test/Ringtoets.Integration.IO.Test/Factories/ExportableGrassCoverErosionOutwardsFailureMechanismFactoryTest.cs
    • -3
    • +3
    /Ringtoets/Integration/test/Ringtoets.Integration.IO.Test/Factories/ExportableGrassCoverSlipOffInwardsFailureMechanismFactoryTest.cs
    • -3
    • +3
    /Ringtoets/Integration/test/Ringtoets.Integration.IO.Test/Factories/ExportableGrassCoverSlipOffOutwardsFailureMechanismFactoryTest.cs
    • -3
    • +3
    /Ringtoets/Integration/test/Ringtoets.Integration.IO.Test/Factories/ExportableHeightStructuresFailureMechanismFactoryTest.cs
    • -3
    • +3
    /Ringtoets/Integration/test/Ringtoets.Integration.IO.Test/Factories/ExportableMacroStabilityInwardsFailureMechanismFactoryTest.cs
    • -3
    • +3
    /Ringtoets/Integration/test/Ringtoets.Integration.IO.Test/Factories/ExportableMacroStabilityOutwardsFailureMechanismFactoryTest.cs
    • -3
    • +3
    /Ringtoets/Integration/test/Ringtoets.Integration.IO.Test/Factories/ExportableMicrostabilityFailureMechanismFactoryTest.cs
    • -3
    • +3
    /Ringtoets/Integration/test/Ringtoets.Integration.IO.Test/Factories/ExportablePipingFailureMechanismFactoryTest.cs
    • -3
    • +3
    /Ringtoets/Integration/test/Ringtoets.Integration.IO.Test/Factories/ExportablePipingStructureFailureMechanismFactoryTest.cs
    • -3
    • +3
    /Ringtoets/Integration/test/Ringtoets.Integration.IO.Test/Factories/ExportableStabilityPointStructuresFailureMechanismFactoryTest.cs
    • -3
    • +3
    /Ringtoets/Integration/test/Ringtoets.Integration.IO.Test/Factories/ExportableStabilityStoneCoverFailureMechanismFactoryTest.cs
  16. … 4 more files in changeset.
11:40 am

Dennis Tang <dennis.tang@deltares.nl>

Incorporated comments review 3186:

- Updated XMLDocs

- Added missing license headers

- Fixed typo of function names.

WTI-1790

Options
    • -1
    • +1
    /Ringtoets/Integration/src/Ringtoets.Integration.IO/Factories/ExportableFailureMechanismSectionFactory.cs
    • -1
    • +1
    /Ringtoets/Integration/test/Ringtoets.Integration.IO.Test/Assembly/ExportableAggregatedFailureMechanismSectionAssemblyResultBaseTest.cs
    • -5
    • +5
    /Ringtoets/Integration/test/Ringtoets.Integration.IO.Test/Assembly/ExportableAggregatedFailureMechanismSectionAssemblyResultTest.cs
    • -5
    • +5
    /Ringtoets/Integration/test/Ringtoets.Integration.IO.Test/Assembly/ExportableAggregatedFailureMechanismSectionAssemblyResultWithProbabilityTest.cs
    • -4
    • +4
    /Ringtoets/Integration/test/Ringtoets.Integration.IO.Test/Assembly/ExportableAggregatedFailureMechanismSectionAssemblyResultWithoutDetailedAssemblyTest.cs
    • -4
    • +4
    /Ringtoets/Integration/test/Ringtoets.Integration.IO.Test/Factories/ExportableAssessmentSectionFactoryTest.cs
    • -2
    • +23
    /Ringtoets/Integration/test/Ringtoets.Integration.IO.TestUtil.Test/ExportableFailureMechanismSectionTestFactoryTest.cs
    • -1
    • +22
    /Ringtoets/Integration/test/Ringtoets.Integration.IO.TestUtil.Test/ExportableSectionAssemblyResultTestFactoryTest.cs
    • -1
    • +0
    /Ringtoets/Integration/test/Ringtoets.Integration.IO.TestUtil.Test/packages.config
    • -2
    • +23
    /Ringtoets/Integration/test/Ringtoets.Integration.IO.TestUtil/ExportableFailureMechanismSectionTestFactory.cs
    • -2
    • +23
    /Ringtoets/Integration/test/Ringtoets.Integration.IO.TestUtil/ExportableFailureMechanismSectionTestHelper.cs
    • -1
    • +22
    /Ringtoets/Integration/test/Ringtoets.Integration.IO.TestUtil/ExportableSectionAssemblyResultTestFactory.cs
    • -1
    • +22
    /Ringtoets/Integration/test/Ringtoets.Integration.IO.TestUtil/ExportableSectionAssemblyResultTestHelper.cs
    • -0
    • +22
    /Ringtoets/Integration/test/Ringtoets.Integration.IO.TestUtil/packages.config
11:32 am

Dennis Tang <dennis.tang@deltares.nl>

Incorporated comments review 3186:

- Fixed XMLDocs

WTI-1790

Options
    • -1
    • +1
    /Ringtoets/Integration/src/Ringtoets.Integration.IO/Assembly/ExportableFailureMechanismAssemblyResult.cs
    • -1
    • +1
    /Ringtoets/Integration/src/Ringtoets.Integration.IO/Assembly/ExportableFailureMechanismGroup.cs
    • -1
    • +1
    /Ringtoets/Integration/src/Ringtoets.Integration.IO/Assembly/ExportableFailureMechanismType.cs
    • -1
    • +1
    /Ringtoets/Integration/src/Ringtoets.Integration.IO/Assembly/ExportableSectionAssemblyResult.cs
    • -13
    • +13
    /Ringtoets/Integration/src/Ringtoets.Integration.IO/Factories/ExportableAssessmentSectionFactory.cs
    • -3
    • +3
    /Ringtoets/Integration/src/Ringtoets.Integration.IO/Factories/ExportableClosingStructuresFailureMechanismFactory.cs
    • -3
    • +3
    /Ringtoets/Integration/src/Ringtoets.Integration.IO/Factories/ExportableCombinedSectionAssemblyCollectionFactory.cs
    • -4
    • +4
    /Ringtoets/Integration/src/Ringtoets.Integration.IO/Factories/ExportableDuneErosionFailureMechanismFactory.cs
    • -4
    • +4
    /Ringtoets/Integration/src/Ringtoets.Integration.IO/Factories/ExportableFailureMechanismFactory.cs
    • -3
    • +3
    /Ringtoets/Integration/src/Ringtoets.Integration.IO/Factories/ExportableGrassCoverErosionInwardsFailureMechanismFactory.cs
    • -3
    • +3
    /Ringtoets/Integration/src/Ringtoets.Integration.IO/Factories/ExportableGrassCoverErosionOutwardsFailureMechanismFactory.cs
    • -3
    • +3
    /Ringtoets/Integration/src/Ringtoets.Integration.IO/Factories/ExportableGrassCoverSlipOffInwardsFailureMechanismFactory.cs
    • -3
    • +3
    /Ringtoets/Integration/src/Ringtoets.Integration.IO/Factories/ExportableGrassCoverSlipOffOutwardsFailureMechanismFactory.cs
    • -3
    • +3
    /Ringtoets/Integration/src/Ringtoets.Integration.IO/Factories/ExportableHeightStructuresFailureMechanismFactory.cs
    • -3
    • +3
    /Ringtoets/Integration/src/Ringtoets.Integration.IO/Factories/ExportableMacroStabilityInwardsFailureMechanismFactory.cs
  16. … 12 more files in changeset.
11:17 am

Robert Tangerman <robert.tangerman@deltares.nl>

Fixed redrawing when surface line updated. WTI-1583

Options
    • -6
    • +23
    /Ringtoets/MacroStabilityInwards/src/Ringtoets.MacroStabilityInwards.Forms/Views/MacroStabilityInwardsInputView.cs
    • -6
    • +63
    /Ringtoets/MacroStabilityInwards/test/Ringtoets.MacroStabilityInwards.Forms.Test/Views/MacroStabilityInwardsInputViewTest.cs
11:11 am

Dennis Tang <dennis.tang@deltares.nl>

Incorporated comments review 3186:

-Ran Deltares Cleanup for all new namespaces.

WTI-1790

Options
    • -1
    • +1
    /Ringtoets/Integration/src/Ringtoets.Integration.IO/Assembly/ExportableCombinedSectionAssemblyCollection.cs
    • -1
    • +1
    /Ringtoets/Integration/src/Ringtoets.Integration.IO/Assembly/ExportableFailureMechanismAssemblyResult.cs
    • -1
    • +1
    /Ringtoets/Integration/src/Ringtoets.Integration.IO/Factories/ExportableCombinedSectionAssemblyCollectionFactory.cs
    • -1
    • +0
    /Ringtoets/Integration/src/Ringtoets.Integration.IO/Factories/ExportableDuneErosionFailureMechanismFactory.cs
    • -1
    • +1
    /Ringtoets/Integration/src/Ringtoets.Integration.IO/Factories/ExportableGrassCoverSlipOffOutwardsFailureMechanismFactory.cs
    • -2
    • +1
    /Ringtoets/Integration/src/Ringtoets.Integration.IO/Factories/ExportableMicrostabilityFailureMechanismFactory.cs
    • -1
    • +1
    /Ringtoets/Integration/src/Ringtoets.Integration.IO/Factories/ExportableStabilityStoneCoverFailureMechanismFactory.cs
    • -1
    • +1
    /Ringtoets/Integration/test/Ringtoets.Integration.IO.Test/Assembly/ExportableAssemblyMethodTest.cs
    • -1
    • +0
    /Ringtoets/Integration/test/Ringtoets.Integration.IO.Test/Assembly/ExportableCombinedSectionAssemblyCollectionTest.cs
    • -1
    • +1
    /Ringtoets/Integration/test/Ringtoets.Integration.IO.Test/Factories/ExportableGrassCoverSlipOffOutwardsFailureMechanismFactoryTest.cs
    • -1
    • +1
    /Ringtoets/Integration/test/Ringtoets.Integration.IO.Test/Factories/ExportableMicrostabilityFailureMechanismFactoryTest.cs
    • -2
    • +2
    /Ringtoets/Integration/test/Ringtoets.Integration.IO.Test/Factories/ExportablePipingFailureMechanismFactoryTest.cs
    • -1
    • +1
    /Ringtoets/Integration/test/Ringtoets.Integration.IO.Test/Factories/ExportableStrengthStabilityLengthwiseConstructionFailureMechanismFactoryTest.cs
11:07 am

Dennis Tang <dennis.tang@deltares.nl>

Incorporated comments review 3186:

- Fixed XMLDocs

WTI-1790

Options
    • -2
    • +2
    /Ringtoets/Integration/src/Ringtoets.Integration.Data/Assembly/CombinedFailureMechanismSectionAssemblyResult.cs
    • -1
    • +1
    /Ringtoets/Integration/src/Ringtoets.Integration.IO/Assembly/ExportableAggregatedFailureMechanismSectionAssemblyResult.cs
    • -1
    • +1
    /Ringtoets/Integration/src/Ringtoets.Integration.IO/Assembly/ExportableAggregatedFailureMechanismSectionAssemblyResultBase.cs
    • -1
    • +1
    /Ringtoets/Integration/src/Ringtoets.Integration.IO/Assembly/ExportableAggregatedFailureMechanismSectionAssemblyResultWithoutDetailedAssembly.cs
    • -1
    • +1
    /Ringtoets/Integration/src/Ringtoets.Integration.IO/Assembly/ExportableAssessmentSection.cs
    • -1
    • +1
    /Ringtoets/Integration/src/Ringtoets.Integration.IO/Assembly/ExportableAssessmentSectionAssemblyResult.cs
11:02 am

Dennis Tang <dennis.tang@deltares.nl>

Incorporated comments review 3186:

- Added license headers to newly created files

WTI-1790

Options
    • -1
    • +22
    /Ringtoets/Integration/src/Ringtoets.Integration.IO/Assembly/ExportableAggregatedFailureMechanismSectionAssemblyResult.cs
    • -1
    • +22
    /Ringtoets/Integration/src/Ringtoets.Integration.IO/Assembly/ExportableAggregatedFailureMechanismSectionAssemblyResultBase.cs
    • -1
    • +22
    /Ringtoets/Integration/src/Ringtoets.Integration.IO/Assembly/ExportableAggregatedFailureMechanismSectionAssemblyResultWithProbability.cs
    • -1
    • +22
    /Ringtoets/Integration/src/Ringtoets.Integration.IO/Assembly/ExportableAggregatedFailureMechanismSectionAssemblyResultWithoutDetailedAssembly.cs
    • -1
    • +22
    /Ringtoets/Integration/src/Ringtoets.Integration.IO/Assembly/ExportableAssemblyMethod.cs
    • -1
    • +22
    /Ringtoets/Integration/src/Ringtoets.Integration.IO/Assembly/ExportableAssessmentSection.cs
    • -1
    • +22
    /Ringtoets/Integration/src/Ringtoets.Integration.IO/Assembly/ExportableAssessmentSectionAssemblyResult.cs
    • -1
    • +22
    /Ringtoets/Integration/src/Ringtoets.Integration.IO/Assembly/ExportableCombinedFailureMechanismSection.cs
    • -1
    • +22
    /Ringtoets/Integration/src/Ringtoets.Integration.IO/Assembly/ExportableCombinedSectionAssembly.cs
    • -1
    • +22
    /Ringtoets/Integration/src/Ringtoets.Integration.IO/Assembly/ExportableCombinedSectionAssemblyCollection.cs
    • -1
    • +22
    /Ringtoets/Integration/src/Ringtoets.Integration.IO/Assembly/ExportableFailureMechanism.cs
    • -1
    • +22
    /Ringtoets/Integration/src/Ringtoets.Integration.IO/Assembly/ExportableFailureMechanismAssemblyResult.cs
    • -1
    • +22
    /Ringtoets/Integration/src/Ringtoets.Integration.IO/Assembly/ExportableFailureMechanismAssemblyResultWithProbability.cs
    • -1
    • +22
    /Ringtoets/Integration/src/Ringtoets.Integration.IO/Assembly/ExportableFailureMechanismCombinedSectionAssemblyResult.cs
    • -1
    • +22
    /Ringtoets/Integration/src/Ringtoets.Integration.IO/Assembly/ExportableFailureMechanismGroup.cs
  16. … 69 more files in changeset.
10:59 am

Carlos Lubbers <carlos.lubbers@deltares.nl>

Improve assembly ctor WTI-1789

Options
    • -18
    • +15
    /Ringtoets/AssemblyTool/src/Ringtoets.AssemblyTool.IO/Model/SerializableAssembly.cs
    • -42
    • +33
    /Ringtoets/AssemblyTool/test/Ringtoets.AssemblyTool.IO.Test/Model/SerializableAssemblyTest.cs
    • -15
    • +6
    /Ringtoets/AssemblyTool/test/Ringtoets.AssemblyTool.IO.Test/SerializableAssemblyWriterTest.cs
10:54 am

Carlos Lubbers <carlos.lubbers@deltares.nl>

Review related changes WTI-1789

Options
    • -9
    • +9
    /Ringtoets/AssemblyTool/src/Ringtoets.AssemblyTool.IO/Model/AssemblyXmlIdentifiers.cs
    • -1
    • +1
    /Ringtoets/AssemblyTool/src/Ringtoets.AssemblyTool.IO/Model/DataTypes/SerializableFailureMechanismAssemblyResult.cs
    • -6
    • +6
    /Ringtoets/AssemblyTool/src/Ringtoets.AssemblyTool.IO/Model/DataTypes/SerializableFailureMechanismSectionAssemblyResult.cs
    • -1
    • +3
    /Ringtoets/AssemblyTool/src/Ringtoets.AssemblyTool.IO/Model/DataTypes/SerializableLine.cs
    • -73
    • +0
    /Ringtoets/AssemblyTool/src/Ringtoets.AssemblyTool.IO/Model/DataTypes/SerializableLineString.cs
    • -15
    • +15
    /Ringtoets/AssemblyTool/src/Ringtoets.AssemblyTool.IO/Model/Enums/AssemblyXmlEnumIdentifiers.cs
    • -55
    • +0
    /Ringtoets/AssemblyTool/src/Ringtoets.AssemblyTool.IO/Model/Enums/SerializableAssemblyGroup.cs
    • -61
    • +0
    /Ringtoets/AssemblyTool/src/Ringtoets.AssemblyTool.IO/Model/Enums/SerializableAssessmentLevel.cs
    • -0
    • +61
    /Ringtoets/AssemblyTool/src/Ringtoets.AssemblyTool.IO/Model/Enums/SerializableAssessmentType.cs
    • -0
    • +55
    /Ringtoets/AssemblyTool/src/Ringtoets.AssemblyTool.IO/Model/Enums/SerializableFailureMechanismGroup.cs
    • -1
    • +1
    /Ringtoets/AssemblyTool/src/Ringtoets.AssemblyTool.IO/Model/Gml/SerializableBoundary.cs
    • -0
    • +74
    /Ringtoets/AssemblyTool/src/Ringtoets.AssemblyTool.IO/Model/Gml/SerializableLineString.cs
    • -1
    • +7
    /Ringtoets/AssemblyTool/src/Ringtoets.AssemblyTool.IO/Model/Helpers/GeometrySerializationFormatter.cs
    • -0
    • +1
    /Ringtoets/AssemblyTool/src/Ringtoets.AssemblyTool.IO/Model/SerializableAssessmentSection.cs
    • -6
    • +6
    /Ringtoets/AssemblyTool/src/Ringtoets.AssemblyTool.IO/Model/SerializableFailureMechanism.cs
  16. … 19 more files in changeset.
10:31 am

Carlos Lubbers <carlos.lubbers@deltares.nl>

Improve typeutil test WTI-1789

Options
    • -5
    • +13
    /Core/Common/test/Core.Common.Util.Test/Reflection/TypeUtilsTest.cs
10:25 am

Carlos Lubbers <carlos.lubbers@deltares.nl>

Improve utils WTI-1789

Options
    • -1
    • +2
    /Core/Common/src/Core.Common.Util/Reflection/TypeUtils.cs
    • -1
    • +1
    /Core/Common/test/Core.Common.TestUtil.Test/EnumWithDisplayNameTestFixtureTest.cs
    • -1
    • +2
    /Core/Common/test/Core.Common.TestUtil/Core.Common.TestUtil.csproj
    • -62
    • +0
    /Core/Common/test/Core.Common.TestUtil/EnumWithDisplayNameTestFixture.cs
    • -0
    • +65
    /Core/Common/test/Core.Common.TestUtil/EnumWithNameTestFixture.cs
    • -0
    • +35
    /Core/Common/test/Core.Common.TestUtil/EnumWithResourcesDisplayNameTestFixture.cs
    • -31
    • +3
    /Core/Common/test/Core.Common.TestUtil/EnumWithXmlEnumNameTestFixture.cs
    • -1
    • +1
    /Core/Components/test/Core.Components.Chart.Test/Data/ChartPointSymbolTest.cs
    • -1
    • +1
    /Core/Components/test/Core.Components.Chart.Test/Styles/ChartLineDashStyleTest.cs
    • -1
    • +1
    /Core/Components/test/Core.Components.Gis.Test/Data/WellKnownTileSourceTest.cs
    • -1
    • +1
    /Core/Components/test/Core.Components.Gis.Test/Style/LineDashStyleTest.cs
    • -1
    • +1
    /Core/Components/test/Core.Components.Gis.Test/Style/PointSymbolTest.cs
    • -1
    • +1
    /Ringtoets/AssemblyTool/test/Ringtoets.AssemblyTool.Data.Test/AssessmentSectionAssemblyCategoryGroupTest.cs
    • -1
    • +1
    /Ringtoets/AssemblyTool/test/Ringtoets.AssemblyTool.Data.Test/FailureMechanismAssemblyCategoryGroupTest.cs
    • -1
    • +1
    /Ringtoets/AssemblyTool/test/Ringtoets.AssemblyTool.Forms.Test/DisplayFailureMechanismSectionAssemblyCategoryGroupTest.cs
  16. … 27 more files in changeset.
8:15 am

Robert Tangerman <robert.tangerman@deltares.nl>

Added category boundary to writer. WTI-1713

Options
    • -5
    • +7
    /Ringtoets/GrassCoverErosionOutwards/test/Ringtoets.GrassCoverErosionOutwards.IO.Test/Exporters/GrassCoverErosionOutwardsWaveConditionsExporterTest.cs
    • -1
    • +1
    /Ringtoets/Revetment/src/Ringtoets.Revetment.IO/Properties/Resources.Designer.cs
    • -1
    • +1
    /Ringtoets/Revetment/src/Ringtoets.Revetment.IO/Properties/Resources.resx
    • -0
    • +1
    /Ringtoets/Revetment/src/Ringtoets.Revetment.IO/WaveConditions/WaveConditionsWriter.cs
    • -5
    • +5
    /Ringtoets/Revetment/test/Ringtoets.Revetment.IO.Test/WaveConditions/WaveConditionsExporterBaseTest.cs
    • -5
    • +5
    /Ringtoets/Revetment/test/Ringtoets.Revetment.IO.Test/WaveConditions/WaveConditionsWriterTest.cs
    • -6
    • +8
    /Ringtoets/StabilityStoneCover/test/Ringtoets.StabilityStoneCover.IO.Test/Exporters/StabilityStoneCoverWaveConditionsExporterTest.cs
    • -5
    • +7
    /Ringtoets/WaveImpactAsphaltCover/test/Ringtoets.WaveImpactAsphaltCover.IO.Test/Exporters/WaveImpactAsphaltCoverWaveConditionsExporterTest.cs
7:38 am

Robert Tangerman <robert.tangerman@deltares.nl>

Cleanup. WTI-1713

Options
    • -0
    • +3
    /Ringtoets/Revetment/src/Ringtoets.Revetment.IO/WaveConditions/ExportableWaveConditions.cs
Wednesday 22 Aug 2018
4:06 pm

Robert Tangerman <robert.tangerman@deltares.nl>

Added category boundary name to ExportableWaveConditions. WTI-1713

Options
    • -3
    • +20
    /Ringtoets/Revetment/src/Ringtoets.Revetment.IO/WaveConditions/ExportableWaveConditions.cs
    • -14
    • +31
    /Ringtoets/Revetment/src/Ringtoets.Revetment.IO/WaveConditions/ExportableWaveConditionsFactory.cs
    • -3
    • +11
    /Ringtoets/Revetment/test/Ringtoets.Revetment.IO.Test/WaveConditions/ExportableWaveConditionsFactoryTest.cs
    • -6
    • +34
    /Ringtoets/Revetment/test/Ringtoets.Revetment.IO.Test/WaveConditions/ExportableWaveConditionsTest.cs
    • -2
    • +2
    /Ringtoets/Revetment/test/Ringtoets.Revetment.IO.Test/WaveConditions/WaveConditionsExporterBaseTest.cs
    • -2
    • +2
    /Ringtoets/Revetment/test/Ringtoets.Revetment.IO.Test/WaveConditions/WaveConditionsWriterTest.cs
3:26 pm

Robert Tangerman <robert.tangerman@deltares.nl>

Refactored factory. WTI-1713

Options
    • -1
    • +1
    /Ringtoets/GrassCoverErosionOutwards/src/Ringtoets.GrassCoverErosionOutwards.IO/Exporters/GrassCoverErosionOutwardsWaveConditionsExporter.cs
    • -26
    • +14
    /Ringtoets/Revetment/src/Ringtoets.Revetment.IO/WaveConditions/ExportableWaveConditionsFactory.cs
    • -50
    • +14
    /Ringtoets/Revetment/test/Ringtoets.Revetment.IO.Test/WaveConditions/ExportableWaveConditionsFactoryTest.cs
    • -1
    • +1
    /Ringtoets/WaveImpactAsphaltCover/src/Ringtoets.WaveImpactAsphaltCover.IO/Exporters/WaveImpactAsphaltCoverWaveConditionsExporter.cs
3:20 pm

Robert Tangerman <robert.tangerman@deltares.nl>

Refactored old method. WTI-1713

Options
    • -52
    • +12
    /Ringtoets/Revetment/src/Ringtoets.Revetment.IO/WaveConditions/ExportableWaveConditionsFactory.cs
    • -100
    • +4
    /Ringtoets/Revetment/test/Ringtoets.Revetment.IO.Test/WaveConditions/ExportableWaveConditionsFactoryTest.cs
3:17 pm

Robert Tangerman <robert.tangerman@deltares.nl>

Added factory method for assessment section wave conditions input. WTI-1713

Options
    • -0
    • +42
    /Ringtoets/Revetment/src/Ringtoets.Revetment.IO/WaveConditions/ExportableWaveConditionsFactory.cs
    • -2
    • +98
    /Ringtoets/Revetment/test/Ringtoets.Revetment.IO.Test/WaveConditions/ExportableWaveConditionsFactoryTest.cs
3:12 pm

Robert Tangerman <robert.tangerman@deltares.nl>

Added factory method for failure mechanism wave conditions input. WTI-1713

Options
    • -0
    • +42
    /Ringtoets/Revetment/src/Ringtoets.Revetment.IO/WaveConditions/ExportableWaveConditionsFactory.cs
    • -0
    • +96
    /Ringtoets/Revetment/test/Ringtoets.Revetment.IO.Test/WaveConditions/ExportableWaveConditionsFactoryTest.cs
3:08 pm

Robert Tangerman <robert.tangerman@deltares.nl>

Cleanup. WTI-1713

Options
    • -5
    • +15
    /Ringtoets/Revetment/src/Ringtoets.Revetment.IO/WaveConditions/ExportableWaveConditionsFactory.cs
    • -5
    • +5
    /Ringtoets/Revetment/test/Ringtoets.Revetment.IO.Test/WaveConditions/ExportableWaveConditionsFactoryTest.cs