Riskeer

Clone Tools

Stats

Commits this week: 0
Total Committers: 28
Last Commit: 26 Nov
Commits this week: 0

Lines of code count not available

Commit Activity

Commits By Day In Week
52 week commits volume
Commits By Day In Week
Commits by day
Commits By Day In Week
Commits by hour
Commits By Hour In Day
Commit calendar
 

Most active committers (90 days)

loading
loading
  • last updated a few seconds ago
All Commits Reviews
Constraints
Constraints: committers
 
Constraints: files
Constraints: dates
Tuesday 18 Oct 2016
9:30 am

Marten Janssen <marten.janssen@deltares.nl>

- Review related changes - Added test for HeightStructureInputContext Related to Issue [WTI-587]

git-svn-id: https://repos.deltares.nl/repos/WettelijkToetsInstrumentarium/trunk@5971 5a3db67b-de53-47b5-99c8-a1c30a6650e2

Former-commit-id: 461cae6fe93306a94241fdafa55ede6fd9f0e20f

Former-commit-id: faf4e4a42c80f881893ec9738bacf5754aebda24

Options
    • -3
    • +0
    /Ringtoets/GrassCoverErosionInwards/src/Ringtoets.GrassCoverErosionInwards.Forms/Ringtoets.GrassCoverErosionInwards.Forms.csproj
    • -3
    • +4
    /Ringtoets/GrassCoverErosionInwards/src/Ringtoets.GrassCoverErosionInwards.Forms/Views/GrassCoverErosionInwardsScenariosView.cs
    • -120
    • +0
    /Ringtoets/GrassCoverErosionInwards/src/Ringtoets.GrassCoverErosionInwards.Forms/Views/GrassCoverErosionInwardsScenariosView.resx
    • -2
    • +1
    /Ringtoets/HeightStructures/src/Ringtoets.HeightStructures.Forms/PresentationObjects/HeightStructuresInputContext.cs
    • -1
    • +0
    /Ringtoets/HeightStructures/src/Ringtoets.HeightStructures.Forms/PropertyClasses/HeightStructuresInputContextProperties.cs
    • -3
    • +0
    /Ringtoets/HeightStructures/src/Ringtoets.HeightStructures.Forms/Ringtoets.HeightStructures.Forms.csproj
    • -4
    • +5
    /Ringtoets/HeightStructures/src/Ringtoets.HeightStructures.Forms/Views/HeightStructuresScenariosView.cs
    • -120
    • +0
    /Ringtoets/HeightStructures/src/Ringtoets.HeightStructures.Forms/Views/HeightStructuresScenariosView.resx
    • -2
    • +0
    /Ringtoets/HeightStructures/src/Ringtoets.HeightStructures.Plugin/HeightStructuresPlugin.cs
    • -0
    • +1
    /Ringtoets/HeightStructures/src/Ringtoets.HeightStructures.Plugin/Ringtoets.HeightStructures.Plugin.csproj
    • -6
    • +23
    /Ringtoets/HeightStructures/test/Ringtoets.HeightStructures.Forms.Test/PresentationObjects/HeightStructuresInputContextTest.cs
    • -27
    • +68
    /Ringtoets/HeightStructures/test/Ringtoets.HeightStructures.Forms.Test/Views/HeightStructuresScenariosViewTest.cs
9:05 am

Marten Janssen <marten.janssen@deltares.nl>

- Review related changes - Added tests for happy path of GrassCoverErosionInwardsHelper Related to Issue [WTI-587]

git-svn-id: https://repos.deltares.nl/repos/WettelijkToetsInstrumentarium/trunk@5970 5a3db67b-de53-47b5-99c8-a1c30a6650e2

Former-commit-id: 0d68d29af9cdb0bf2acf6af0414b8972d369fa1e

Former-commit-id: 1e667e751a939670df9d3a2cfc764d06f1161c5b

Options
    • -21
    • +29
    /Ringtoets/Common/test/Ringtoets.Common.Forms.Test/ScenarioSelectionControlTest.cs
    • -9
    • +8
    /Ringtoets/Common/test/Ringtoets.Common.Utils.Test/AssignUnassignCalculationsTest.cs
    • -2
    • +2
    /Ringtoets/GrassCoverErosionInwards/src/Ringtoets.GrassCoverErosionInwards.Forms/Views/GrassCoverErosionInwardsScenariosView.cs
    • -11
    • +10
    /Ringtoets/GrassCoverErosionInwards/src/Ringtoets.GrassCoverErosionInwards.Utils/GrassCoverErosionInwardsHelper.cs
    • -1
    • +0
    /Ringtoets/GrassCoverErosionInwards/test/Ringtoets.GrassCoverErosionInwards.Forms.Test/TreeNodeInfos/GrassCoverErosionInwardsCalculationContextTreeNodeInfoTest.cs
    • -56
    • +134
    /Ringtoets/GrassCoverErosionInwards/test/Ringtoets.GrassCoverErosionInwards.Utils.Test/GrassCoverErosionInwardsHelperTest.cs
    • -40
    • +47
    /Ringtoets/GrassCoverErosionOutwards/test/Ringtoets.GrassCoverErosionOutwards.Forms.Test/TreeNodeInfos/GrassCoverErosionOutwardsWaveConditionsCalculationGroupContextTreeNodeInfoTest.cs
Monday 17 Oct 2016
4:35 pm

Marten Janssen <marten.janssen@deltares.nl>

- Updated XMLdocs - Added test for non-obvious ArgumentNullException case - Added SectionResultWithCalculationAssignmentTest

Related to Issue [WTI-587]

git-svn-id: https://repos.deltares.nl/repos/WettelijkToetsInstrumentarium/trunk@5969 5a3db67b-de53-47b5-99c8-a1c30a6650e2

Former-commit-id: d6f6ea1b009348697b3e21cd00c875baf9e4e651

Former-commit-id: 6a10412daf7d04f0eb90e26db0271e585fb9a257

Options
    • -0
    • +1
    /Core/Common/src/Core.Common.Base/Geometry/Segment2D.cs
    • -0
    • +1
    /Ringtoets/Common/src/Ringtoets.Common.Utils/SectionSegments.cs
    • -0
    • +1
    /Ringtoets/Common/test/Ringtoets.Common.Utils.Test/Ringtoets.Common.Utils.Test.csproj
    • -0
    • +95
    /Ringtoets/Common/test/Ringtoets.Common.Utils.Test/SectionResultWithCalculationAssignmentTest.cs
    • -13
    • +34
    /Ringtoets/Common/test/Ringtoets.Common.Utils.Test/SectionSegmentsTest.cs
4:34 pm

bos_en <bos_en@example.com>

Corrected style of error message. "valt buiten het bereik (0, 1]" => "moet in het bereik (0, 1] liggen" Related to Issue [WTI-577]

git-svn-id: https://repos.deltares.nl/repos/WettelijkToetsInstrumentarium/trunk@5968 5a3db67b-de53-47b5-99c8-a1c30a6650e2

Former-commit-id: 55e15ba2b120e507927f08ced2e300392c835950

Former-commit-id: 24839005d3b78aa2b18a3bae17aaeb3514a5cac0

Options
    • -1
    • +1
    /Ringtoets/Common/src/Ringtoets.Common.IO/Properties/Resources.Designer.cs
    • -1
    • +1
    /Ringtoets/Common/src/Ringtoets.Common.IO/Properties/Resources.resx
    • -5
    • +5
    /Ringtoets/Common/test/Ringtoets.Common.IO.Test/Structures/StructuresParameterRowsValidatorTest.cs
4:27 pm

bos_en <bos_en@example.com>

Correction to: Corrected style of error message. "moet een getal zijn dat niet negatief is" => "moet een positief getal zijn"

Related to Issue [WTI-577]

git-svn-id: https://repos.deltares.nl/repos/WettelijkToetsInstrumentarium/trunk@5967 5a3db67b-de53-47b5-99c8-a1c30a6650e2

Former-commit-id: 685d364a4bd5eab47ec6541a46566734c88ff05a

Former-commit-id: 97b877b892a383347fa80f73fd5bc89403599586

Options
    • -1
    • +1
    /Ringtoets/StabilityPointStructures/test/Ringtoets.StabilityPointStructures.IO.Test/StabilityPointStructuresImporterTest.cs
3:50 pm

Dennis Tang <dennis.tang@deltares.nl>

Incorporated review comments: - Implemented missing "Cancel" tests - Made test names consistent - Fixed minor typos and ran DeltaresClean Related to Issue [WTI-867]

git-svn-id: https://repos.deltares.nl/repos/WettelijkToetsInstrumentarium/trunk@5966 5a3db67b-de53-47b5-99c8-a1c30a6650e2

Former-commit-id: 28c3c1733f76da4e8cc48fdecaf1031d9093d9de

Former-commit-id: 0485a9aae90be1c368e18d1154b0151afd7a917c

Options
    • -1
    • +1
    /Ringtoets/Common/test/Ringtoets.Common.Service.Test/DesignWaterLevelCalculationServiceTest.cs
    • -1
    • +1
    /Ringtoets/Common/test/Ringtoets.Common.Service.Test/WaveHeightCalculationServiceTest.cs
    • -0
    • +29
    /Ringtoets/GrassCoverErosionOutwards/test/Ringtoets.GrassCoverErosionOutwards.Service.Test/GrassCoverErosionOutwardsWaveConditionsCalculationServiceTest.cs
    • -3
    • +3
    /Ringtoets/Revetment/src/Ringtoets.Revetment.Service/WaveConditionsCalculationServiceBase.cs
    • -0
    • +38
    /Ringtoets/Revetment/test/Ringtoets.Revetment.Service.Test/WaveConditionsCalculationServiceBaseTest.cs
    • -34
    • +43
    /Ringtoets/StabilityStoneCover/test/Ringtoets.StabilityStoneCover.Service.Test/StabilityStoneCoverWaveConditionsCalculationServiceTest.cs
    • -0
    • +30
    /Ringtoets/WaveImpactAsphaltCover/test/Ringtoets.WaveImpactAsphaltCover.Service.Test/WaveImpactAsphaltCoverWaveConditionsCalculationServiceTest.cs
3:19 pm

Marten Janssen <marten.janssen@deltares.nl>

- Updated XMLdocs - Added tests for CalculationWithLocation Related to Issue [WTI-587]

git-svn-id: https://repos.deltares.nl/repos/WettelijkToetsInstrumentarium/trunk@5965 5a3db67b-de53-47b5-99c8-a1c30a6650e2

Former-commit-id: 8f0ee388c9de6a947b43bd5a910d99ad521b8a02

Former-commit-id: 2c7e4234cd969d84d96b9eaf46eed8a31b76173f

Options
    • -1
    • +1
    /Ringtoets/Common/src/Ringtoets.Common.Forms/IScenarioRow.cs
    • -0
    • +1
    /Ringtoets/Common/src/Ringtoets.Common.Forms/ScenarioSelectionControl.cs
    • -7
    • +8
    /Ringtoets/Common/src/Ringtoets.Common.Utils/AssignUnassignCalculations.cs
    • -0
    • +83
    /Ringtoets/Common/test/Ringtoets.Common.Utils.Test/CalculationWithLocationTest.cs
    • -0
    • +1
    /Ringtoets/Common/test/Ringtoets.Common.Utils.Test/Ringtoets.Common.Utils.Test.csproj
2:23 pm

Marten Janssen <marten.janssen@deltares.nl>

- Editorial review comments

Related to Issue [WTI-587]

git-svn-id: https://repos.deltares.nl/repos/WettelijkToetsInstrumentarium/trunk@5964 5a3db67b-de53-47b5-99c8-a1c30a6650e2

Former-commit-id: eb15595cbfdcc920a7d55f1f0460bab3c34f736e

Former-commit-id: a486b2810eac4dfaad17821202fede7ef072542b

Options
    • -1
    • +2
    /Core/Common/test/Core.Common.Gui.Test/ContextMenu/TreeViewContextMenuItemFactoryTest.cs
    • -7
    • +7
    /Core/Common/test/Core.Common.Gui.TestUtil/ContextMenu/CustomItemsOnlyContextMenuBuilder.cs
    • -15
    • +14
    /Ringtoets/ClosingStructures/test/Ringtoets.ClosingStructures.Forms.Test/TreeNodeInfos/ClosingStructuresCalculationGroupContextTreeNodeInfoTest.cs
    • -1
    • +1
    /Ringtoets/Common/src/Ringtoets.Common.Data/FailureMechanism/IFailureMechanism.cs
    • -1
    • +1
    /Ringtoets/Common/src/Ringtoets.Common.Forms/IScenarioRow.cs
2:15 pm

bos_en <bos_en@example.com>

Corrected style of error message. "moet een getal zijn dat niet negatief is" => "moet een positief getal zijn" Related to Issue [WTI-577]

git-svn-id: https://repos.deltares.nl/repos/WettelijkToetsInstrumentarium/trunk@5962 5a3db67b-de53-47b5-99c8-a1c30a6650e2

Former-commit-id: 5dcd717a4b762a649311891d7ac2051830561383

Former-commit-id: b9ab3b83cb2aacf35c6d756303fd6e42a7646e2f

Options
    • -3
    • +3
    /Ringtoets/Common/src/Ringtoets.Common.IO/Properties/Resources.Designer.cs
    • -2
    • +2
    /Ringtoets/Common/src/Ringtoets.Common.IO/Properties/Resources.resx
    • -1
    • +1
    /Ringtoets/Common/src/Ringtoets.Common.IO/Structures/StructuresParameterRowsValidator.cs
    • -22
    • +22
    /Ringtoets/Common/test/Ringtoets.Common.IO.Test/Structures/StructuresParameterRowsValidatorTest.cs
2:00 pm

Marten Janssen <marten.janssen@deltares.nl>

- Added unit test for DataGridView ComboBox cell click - Added tooltip for context menu of "Berekeningen" folder when the folder has no children - Updated resource tooltip texts for context menu of "Berekeningen" folder Related to Issue [WTI-587]

git-svn-id: https://repos.deltares.nl/repos/WettelijkToetsInstrumentarium/trunk@5961 5a3db67b-de53-47b5-99c8-a1c30a6650e2

Former-commit-id: 381cb7b7bcfccc492d06890e4dd269e46bf9e232

Former-commit-id: 3b4e1ea1e4e196400bbfba07f106816f0b986f17

Options
    • -1
    • +3
    /Core/Common/src/Core.Common.Gui/ContextMenu/TreeViewContextMenuItemFactory.cs
    • -3
    • +12
    /Core/Common/src/Core.Common.Gui/Properties/Resources.Designer.cs
    • -2
    • +5
    /Core/Common/src/Core.Common.Gui/Properties/Resources.resx
    • -0
    • +39
    /Core/Common/test/Core.Common.Controls.Test/DataGrid/DataGridViewControlTest.cs
    • -1
    • +0
    /Core/Common/test/Core.Common.Controls.TreeView.Test/TreeViewControlTest.cs
    • -10
    • +11
    /Core/Common/test/Core.Common.Gui.Test/ContextMenu/ContextMenuBuilderTest.cs
    • -7
    • +5
    /Core/Common/test/Core.Common.Gui.Test/ContextMenu/TreeViewContextMenuItemFactoryTest.cs
    • -3
    • +0
    /Ringtoets/GrassCoverErosionInwards/src/Ringtoets.GrassCoverErosionInwards.Plugin/GrassCoverErosionInwardsPlugin.cs
    • -12
    • +4
    /Ringtoets/GrassCoverErosionOutwards/test/Ringtoets.GrassCoverErosionOutwards.Forms.Test/TreeNodeInfos/GrassCoverErosionOutwardsWaveConditionsCalculationGroupContextTreeNodeInfoTest.cs
    • -13
    • +4
    /Ringtoets/StabilityStoneCover/test/Ringtoets.StabilityStoneCover.Forms.Test/TreeNodeInfos/StabilityStoneCoverWaveConditionsCalculationGroupContextTreeNodeInfoTest.cs
    • -9
    • +4
    /Ringtoets/WaveImpactAsphaltCover/test/Ringtoets.WaveImpactAsphaltCover.Forms.Test/TreeNodeInfos/WaveImpactAsphaltCoverWaveConditionsCalculationGroupContextTreeNodeInfoTest.cs
1:32 pm

bos_en <bos_en@example.com>

Structure importers made case insensitive w.r.t. parameterId. Related to Issue [WTI-577]

git-svn-id: https://repos.deltares.nl/repos/WettelijkToetsInstrumentarium/trunk@5960 5a3db67b-de53-47b5-99c8-a1c30a6650e2

Former-commit-id: 0c8d39e99127f0d785f824c3fb228da8f45cd6f8

Former-commit-id: 6a98c7ae20d2c05cd9ae4807355ad6a7808b7b85

Options
    • -1
    • +1
    /Ringtoets/ClosingStructures/src/Ringtoets.ClosingStructures.IO/ClosingStructuresImporter.cs
    • -0
    • +27
    /Ringtoets/ClosingStructures/test/Ringtoets.ClosingStructures.IO.Test/ClosingStructuresImporterTest.cs
    • -0
    • +197
    /Ringtoets/Common/test/Ringtoets.Common.IO.Test/test-data/Structures/CorrectShpRandomCaseHeaderCsv/Kunstwerken.csv
    • binary
    /Ringtoets/Common/test/Ringtoets.Common.IO.Test/test-data/Structures/CorrectShpRandomCaseHeaderCsv/Kunstwerken.dbf
    • -0
    • +1
    /Ringtoets/Common/test/Ringtoets.Common.IO.Test/test-data/Structures/CorrectShpRandomCaseHeaderCsv/Kunstwerken.prj
    • -0
    • +1
    /Ringtoets/Common/test/Ringtoets.Common.IO.Test/test-data/Structures/CorrectShpRandomCaseHeaderCsv/Kunstwerken.qpj
    • binary
    /Ringtoets/Common/test/Ringtoets.Common.IO.Test/test-data/Structures/CorrectShpRandomCaseHeaderCsv/Kunstwerken.shp
    • binary
    /Ringtoets/Common/test/Ringtoets.Common.IO.Test/test-data/Structures/CorrectShpRandomCaseHeaderCsv/Kunstwerken.shx
    • -1
    • +1
    /Ringtoets/HeightStructures/src/Ringtoets.HeightStructures.IO/HeightStructuresImporter.cs
    • -0
    • +27
    /Ringtoets/HeightStructures/test/Ringtoets.HeightStructures.IO.Test/HeightStructuresImporterTest.cs
    • -1
    • +1
    /Ringtoets/StabilityPointStructures/src/Ringtoets.StabilityPointStructures.IO/StabilityPointStructuresImporter.cs
    • -0
    • +27
    /Ringtoets/StabilityPointStructures/test/Ringtoets.StabilityPointStructures.IO.Test/StabilityPointStructuresImporterTest.cs
12:28 pm

Elmar Kleijn

Adapted another test file Related to Issue [WTI-577]

git-svn-id: https://repos.deltares.nl/repos/WettelijkToetsInstrumentarium/trunk@5958 5a3db67b-de53-47b5-99c8-a1c30a6650e2

Former-commit-id: 5972de380212341295a68f1c8d656d2e0844c36f

Former-commit-id: b4deef2b7c32eb146a494d18d5fe0c2b83946a6d

Options
    • -1
    • +1
    /Ringtoets/HeightStructures/test/Ringtoets.HeightStructures.IO.Test/test-data/Characteristics/ValidCharacteristics.csv
12:22 pm

Elmar Kleijn

Turned "Standarddeviatie.variance" into "Standaardafwijking.variatie" Related to Issue [WTI-577]

git-svn-id: https://repos.deltares.nl/repos/WettelijkToetsInstrumentarium/trunk@5957 5a3db67b-de53-47b5-99c8-a1c30a6650e2

Former-commit-id: 33389b5844cf62e17e8a92ad3577adf859845c00

Former-commit-id: 6e8eaa5a13c1b37757f91f7a2ed895cacfd9da1c

Options
    • -1
    • +1
    /Ringtoets/ClosingStructures/test/Ringtoets.ClosingStructures.IO.Test/test-data/StructuresVarianceValueConversion/Kunstwerken.csv
    • -1
    • +1
    /Ringtoets/Common/src/Ringtoets.Common.IO/Structures/StructureFilesKeywords.cs
    • -7
    • +7
    /Ringtoets/Common/test/Ringtoets.Common.IO.Test/Structures/StructuresCharacteristicsCsvReaderTest.cs
    • -9
    • +9
    /Ringtoets/Common/test/Ringtoets.Common.IO.Test/Structures/StructuresParameterRowsValidatorTest.cs
    • -1
    • +1
    /Ringtoets/Common/test/Ringtoets.Common.IO.Test/test-data/Structures/CorrectFiles/Kunstwerken.csv
    • -1
    • +1
    /Ringtoets/Common/test/Ringtoets.Common.IO.Test/test-data/Structures/CorrectShpIncompleteCsv/Kunstwerken.csv
    • -1
    • +1
    /Ringtoets/Common/test/Ringtoets.Common.IO.Test/test-data/Structures/DuplicateLocation/Kunstwerken.csv
    • -1
    • +1
    /Ringtoets/Common/test/Ringtoets.Common.IO.Test/test-data/Structures/StructuresCharacteristicsCsvFiles/InvalidFile_1Location_SecondLineLackingSeparator.csv
    • -1
    • +1
    /Ringtoets/Common/test/Ringtoets.Common.IO.Test/test-data/Structures/StructuresCharacteristicsCsvFiles/InvalidFile_1Location_SecondLineLocationIdEmpty1.csv
    • -1
    • +1
    /Ringtoets/Common/test/Ringtoets.Common.IO.Test/test-data/Structures/StructuresCharacteristicsCsvFiles/InvalidFile_1Location_SecondLineLocationIdEmpty2.csv
    • -1
    • +1
    /Ringtoets/Common/test/Ringtoets.Common.IO.Test/test-data/Structures/StructuresCharacteristicsCsvFiles/InvalidFile_1Location_SecondLineMissingValues.csv
    • -1
    • +1
    /Ringtoets/Common/test/Ringtoets.Common.IO.Test/test-data/Structures/StructuresCharacteristicsCsvFiles/InvalidFile_1Location_SecondLineNumericValueNotNumber.csv
    • -1
    • +1
    /Ringtoets/Common/test/Ringtoets.Common.IO.Test/test-data/Structures/StructuresCharacteristicsCsvFiles/InvalidFile_1Location_SecondLineNumericValueTooLarge.csv
    • -1
    • +1
    /Ringtoets/Common/test/Ringtoets.Common.IO.Test/test-data/Structures/StructuresCharacteristicsCsvFiles/InvalidFile_1Location_SecondLineNumericValueTooSmall.csv
    • -1
    • +1
    /Ringtoets/Common/test/Ringtoets.Common.IO.Test/test-data/Structures/StructuresCharacteristicsCsvFiles/InvalidFile_1Location_SecondLineParameterIdEmpty1.csv
  16. … 31 more files in changeset.
11:21 am

Elmar Kleijn

Improved context menu tooltip for HeightStructuresCalculationGroupContext Related to Issue [WTI-581]

git-svn-id: https://repos.deltares.nl/repos/WettelijkToetsInstrumentarium/trunk@5955 5a3db67b-de53-47b5-99c8-a1c30a6650e2

Former-commit-id: e5425bd4df83258f636c9db4b9e9af2673ecc45f

Former-commit-id: 54200f98c0581c072f1eeb7bc79d0a82e269e080

Options
    • -1
    • +1
    /Ringtoets/HeightStructures/src/Ringtoets.HeightStructures.Plugin/HeightStructuresPlugin.cs
    • -3
    • +3
    /Ringtoets/HeightStructures/src/Ringtoets.HeightStructures.Plugin/Properties/Resources.Designer.cs
    • -2
    • +2
    /Ringtoets/HeightStructures/src/Ringtoets.HeightStructures.Plugin/Properties/Resources.resx
    • -0
    • +1
    /Ringtoets/HeightStructures/src/Ringtoets.HeightStructures.Plugin/Ringtoets.HeightStructures.Plugin.csproj
    • -1
    • +1
    /Ringtoets/HeightStructures/test/Ringtoets.HeightStructures.Forms.Test/TreeNodeInfos/HeightStructuresCalculationGroupContextTreeNodeInfoTest.cs
10:54 am

Elmar Kleijn

Improved some structure reader messages Related to Issue [WTI-577]

git-svn-id: https://repos.deltares.nl/repos/WettelijkToetsInstrumentarium/trunk@5954 5a3db67b-de53-47b5-99c8-a1c30a6650e2

Former-commit-id: 965c9882883da6d026cdc64fb031d05b304f4e35

Former-commit-id: 4f4c6fb1c879666cba695777554a401b3a736c32

Options
    • -6
    • +6
    /Ringtoets/Common/src/Ringtoets.Common.IO/Properties/Resources.Designer.cs
    • -4
    • +4
    /Ringtoets/Common/src/Ringtoets.Common.IO/Properties/Resources.resx
    • -9
    • +22
    /Ringtoets/Common/src/Ringtoets.Common.IO/Structures/StructuresCharacteristicsCsvReader.cs
    • -35
    • +35
    /Ringtoets/Common/test/Ringtoets.Common.IO.Test/Structures/StructuresCharacteristicsCsvReaderTest.cs
9:20 am

Dennis Tang <dennis.tang@deltares.nl>

Incorporated review comments: - Implemented missing "Cancel" tests - Implemented missing test for GrassCoverErosionInwards when a calculation fails for an overtopping calculation (with CalculateDikeHeight = FALSE) Related to Issue [WTI-867]

git-svn-id: https://repos.deltares.nl/repos/WettelijkToetsInstrumentarium/trunk@5953 5a3db67b-de53-47b5-99c8-a1c30a6650e2

Former-commit-id: b883cc17715d7050848047bcf01bbfb0f3d3a9cb

Former-commit-id: e9a44bbaf5da1cba5eb4ca345afa933415023a37

Options
    • -6
    • +54
    /Ringtoets/Common/test/Ringtoets.Common.Service.Test/DesignWaterLevelCalculationServiceTest.cs
    • -13
    • +62
    /Ringtoets/Common/test/Ringtoets.Common.Service.Test/WaveHeightCalculationServiceTest.cs
    • -0
    • +154
    /Ringtoets/GrassCoverErosionInwards/test/Ringtoets.GrassCoverErosionInwards.Service.Test/GrassCoverErosionInwardsCalculationServiceTest.cs
    • -1
    • +48
    /Ringtoets/HeightStructures/test/Ringtoets.HeightStructures.Service.Test/HeightStructuresCalculationServiceTest.cs
9:08 am

Elmar Kleijn

Improved some structure reader messages Related to Issue [WTI-577]

git-svn-id: https://repos.deltares.nl/repos/WettelijkToetsInstrumentarium/trunk@5952 5a3db67b-de53-47b5-99c8-a1c30a6650e2

Former-commit-id: 99537525d22f01ef62c333efe79930d41f834a76

Former-commit-id: 40df54fe3d02155076cf9403fd402a6c849ee07f

Options
    • -1
    • +1
    /Ringtoets/Common/src/Ringtoets.Common.IO/Properties/Resources.Designer.cs
    • -1
    • +1
    /Ringtoets/Common/src/Ringtoets.Common.IO/Properties/Resources.resx
    • -1
    • +1
    /Ringtoets/Common/test/Ringtoets.Common.IO.Test/Structures/StructuresCharacteristicsCsvReaderTest.cs
    • -3
    • +3
    /Ringtoets/Piping/src/Ringtoets.Piping.IO/Properties/Resources.Designer.cs
    • -2
    • +2
    /Ringtoets/Piping/src/Ringtoets.Piping.IO/Properties/Resources.resx
9:00 am

Elmar Kleijn

Improved some final structure related summaries

git-svn-id: https://repos.deltares.nl/repos/WettelijkToetsInstrumentarium/trunk@5950 5a3db67b-de53-47b5-99c8-a1c30a6650e2

Former-commit-id: 3fb1638922241f473de200fe892128e1301c5c1a

Former-commit-id: a7920e8cd444e627912002e5fcfe4f0ca34d2367

Options
    • -1
    • +1
    /Ringtoets/ClosingStructures/src/Ringtoets.ClosingStructures.Data/ClosingStructuresInput.cs
    • -2
    • +2
    /Ringtoets/StabilityPointStructures/src/Ringtoets.StabilityPointStructures.Data/StabilityPointStructuresInput.cs
8:55 am

Elmar Kleijn

Improved some structure reader messages Related to Issue [WTI-577]

git-svn-id: https://repos.deltares.nl/repos/WettelijkToetsInstrumentarium/trunk@5949 5a3db67b-de53-47b5-99c8-a1c30a6650e2

Former-commit-id: 1c62796654c50bb32e4207685f76b5a19fae91e4

Former-commit-id: 05801f3f3f686343c200463d1e3082e2c21941a8

Options
    • -2
    • +5
    /Ringtoets/Common/src/Ringtoets.Common.IO/Properties/Resources.Designer.cs
    • -2
    • +5
    /Ringtoets/Common/src/Ringtoets.Common.IO/Properties/Resources.resx
    • -1
    • +1
    /Ringtoets/Common/src/Ringtoets.Common.IO/Structures/StructuresCharacteristicsCsvReader.cs
    • -8
    • +30
    /Ringtoets/Common/test/Ringtoets.Common.IO.Test/Structures/StructuresCharacteristicsCsvReaderTest.cs
8:30 am

Elmar Kleijn

Ensured reader is correctly disposed in StructuresImporter Related to Issue [WTI-577]

git-svn-id: https://repos.deltares.nl/repos/WettelijkToetsInstrumentarium/trunk@5948 5a3db67b-de53-47b5-99c8-a1c30a6650e2

Former-commit-id: 57704ca6f4ea9d2dd4cd23e6a56b9a31162342b7

Former-commit-id: f7fa79e26191bd4cb855a9977dde5bf086ba7e27

Options
    • -1
    • +1
    /Ringtoets/Common/src/Ringtoets.Common.IO/FileImporters/ProfilesImporter.cs
    • -33
    • +34
    /Ringtoets/Common/src/Ringtoets.Common.IO/FileImporters/StructuresImporter.cs
8:03 am

Elmar Kleijn

Changed "1" to "één" Related to Issue [WTI-577]

git-svn-id: https://repos.deltares.nl/repos/WettelijkToetsInstrumentarium/trunk@5946 5a3db67b-de53-47b5-99c8-a1c30a6650e2

Former-commit-id: a3cae61bf48d3fabc629f3506a158e4614818e7c

Former-commit-id: 16c84742f1230a383219da4c555157b8fe649df2

Options
    • -0
    • +1
    /Core/Common/src/Core.Common.Gui/Core.Common.Gui.csproj
    • -2
    • +2
    /Core/Components/src/Core.Components.Gis.IO/Properties/Resources.Designer.cs
    • -2
    • +2
    /Core/Components/src/Core.Components.Gis.IO/Properties/Resources.resx
    • -1
    • +1
    /Ringtoets/ClosingStructures/test/Ringtoets.ClosingStructures.IO.Test/ClosingStructuresImporterTest.cs
    • -1
    • +1
    /Ringtoets/Common/src/Ringtoets.Common.Data/Properties/Resources.Designer.cs
    • -1
    • +1
    /Ringtoets/Common/src/Ringtoets.Common.Data/Properties/Resources.resx
    • -3
    • +3
    /Ringtoets/Common/src/Ringtoets.Common.IO/Properties/Resources.Designer.cs
    • -3
    • +3
    /Ringtoets/Common/src/Ringtoets.Common.IO/Properties/Resources.resx
    • -1
    • +1
    /Ringtoets/Common/test/Ringtoets.Common.Data.Test/FailureMechanism/FailureMechanismSectionTest.cs
    • -1
    • +1
    /Ringtoets/Common/test/Ringtoets.Common.IO.Test/ReferenceLines/ReferenceLineReaderTest.cs
    • -2
    • +2
    /Ringtoets/Common/test/Ringtoets.Common.IO.Test/Structures/StructuresCharacteristicsCsvReaderTest.cs
    • -3
    • +3
    /Ringtoets/HeightStructures/test/Ringtoets.HeightStructures.IO.Test/HeightStructuresImporterTest.cs
    • -2
    • +2
    /Ringtoets/Piping/src/Ringtoets.Piping.Plugin/Properties/Resources.Designer.cs
    • -2
    • +2
    /Ringtoets/Piping/src/Ringtoets.Piping.Plugin/Properties/Resources.resx
    • -2
    • +2
    /Ringtoets/Piping/test/Ringtoets.Piping.Plugin.Test/FileImporter/PipingSurfaceLinesCsvImporterTest.cs
    • -5
    • +7
    /Ringtoets/StabilityPointStructures/test/Ringtoets.StabilityPointStructures.IO.Test/StabilityPointStructuresImporterTest.cs
7:47 am

Elmar Kleijn

Changed "meermaals" to "meerdere keren"

Related to Issue [WTI-577]

git-svn-id: https://repos.deltares.nl/repos/WettelijkToetsInstrumentarium/trunk@5945 5a3db67b-de53-47b5-99c8-a1c30a6650e2

Former-commit-id: 30bfc87c0059c199f880fe8d0dae9848d9df044b

Former-commit-id: 593dda87216be2bf84d9b52a261963b3fa21814f

Options
    • -1
    • +1
    /Ringtoets/ClosingStructures/test/Ringtoets.ClosingStructures.IO.Test/ClosingStructuresImporterTest.cs
    • -1
    • +1
    /Ringtoets/Common/src/Ringtoets.Common.IO/Properties/Resources.Designer.cs
    • -1
    • +1
    /Ringtoets/Common/src/Ringtoets.Common.IO/Properties/Resources.resx
    • -3
    • +3
    /Ringtoets/Common/test/Ringtoets.Common.IO.Test/Structures/StructuresParameterRowsValidatorTest.cs
    • -1
    • +1
    /Ringtoets/HeightStructures/test/Ringtoets.HeightStructures.IO.Test/HeightStructuresImporterTest.cs
    • -1
    • +1
    /Ringtoets/StabilityPointStructures/test/Ringtoets.StabilityPointStructures.IO.Test/StabilityPointStructuresImporterTest.cs
7:44 am

Elmar Kleijn

Changed "standaard deviation" to "standaardafwijking" Changed "binnen het bereik" to "in het bereik" Related to Issue [WTI-577]

git-svn-id: https://repos.deltares.nl/repos/WettelijkToetsInstrumentarium/trunk@5944 5a3db67b-de53-47b5-99c8-a1c30a6650e2

Former-commit-id: 59cb9983de9d2aa838675df3a7891714bc1a9f7a

Former-commit-id: daffa4ce36964f4f6f6920d7cb0a3994292d0e2b

Options
    • -6
    • +6
    /Ringtoets/ClosingStructures/test/Ringtoets.ClosingStructures.IO.Test/ClosingStructuresImporterTest.cs
    • -3
    • +3
    /Ringtoets/Common/src/Ringtoets.Common.IO/Properties/Resources.Designer.cs
    • -5
    • +5
    /Ringtoets/Common/src/Ringtoets.Common.IO/Properties/Resources.resx
    • -2
    • +2
    /Ringtoets/Common/test/Ringtoets.Common.IO.Test/DikeProfiles/DikeProfileDataReaderTest.cs
    • -1
    • +1
    /Ringtoets/Common/test/Ringtoets.Common.IO.Test/FileImporters/StructuresImporterTest.cs
    • -28
    • +28
    /Ringtoets/Common/test/Ringtoets.Common.IO.Test/Structures/StructuresParameterRowsValidatorTest.cs
    • -3
    • +3
    /Ringtoets/HeightStructures/test/Ringtoets.HeightStructures.IO.Test/HeightStructuresImporterTest.cs
    • -1
    • +1
    /Ringtoets/Piping/src/Ringtoets.Piping.Service/Properties/Resources.Designer.cs
    • -1
    • +1
    /Ringtoets/Piping/src/Ringtoets.Piping.Service/Properties/Resources.resx
    • -1
    • +1
    /Ringtoets/Piping/test/Ringtoets.Piping.Service.Test/PipingCalculationServiceTest.cs
    • -9
    • +9
    /Ringtoets/StabilityPointStructures/test/Ringtoets.StabilityPointStructures.IO.Test/StabilityPointStructuresImporterTest.cs
Friday 14 Oct 2016
12:45 pm

Elmar Kleijn

Review related changes

Paired with tang_ds

Related to Issue [WTI-550]

git-svn-id: https://repos.deltares.nl/repos/WettelijkToetsInstrumentarium/trunk@5939 5a3db67b-de53-47b5-99c8-a1c30a6650e2

Former-commit-id: 1ed2e97f9fa0ca1300b9c2467bc057f4018b038a

Former-commit-id: b39bc25eebd394ec48165658c9fdb37ca2d1a141

Options
    • -9
    • +9
    /Core/Common/src/Core.Common.Gui/Plugin/PluginBase.cs
    • -1
    • +1
    /Core/Plugins/src/Core.Plugins.CommonTools/CommonToolsPlugin.cs
    • -0
    • +3
    /Core/Plugins/src/Core.Plugins.ProjectExplorer/ProjectExplorerPlugin.cs
    • -1
    • +1
    /Demo/Ringtoets/src/Demo.Ringtoets/GUIs/DemoProjectPlugin.cs
    • -9
    • +9
    /Ringtoets/ClosingStructures/src/Ringtoets.ClosingStructures.Plugin/ClosingStructuresPlugin.cs
    • -6
    • +6
    /Ringtoets/GrassCoverErosionInwards/src/Ringtoets.GrassCoverErosionInwards.Plugin/GrassCoverErosionInwardsPlugin.cs
    • -14
    • +14
    /Ringtoets/GrassCoverErosionOutwards/src/Ringtoets.GrassCoverErosionOutwards.Plugin/GrassCoverErosionOutwardsPlugin.cs
    • -6
    • +4
    /Ringtoets/HeightStructures/src/Ringtoets.HeightStructures.Plugin/HeightStructuresPlugin.cs
    • -45
    • +45
    /Ringtoets/Integration/src/Ringtoets.Integration.Plugin/RingtoetsPlugin.cs
    • -11
    • +11
    /Ringtoets/Piping/src/Ringtoets.Piping.Plugin/PipingPlugin.cs
    • -5
    • +7
    /Ringtoets/StabilityPointStructures/src/Ringtoets.StabilityPointStructures.Plugin/StabilityPointStructuresPlugin.cs
    • -13
    • +13
    /Ringtoets/StabilityStoneCover/src/Ringtoets.StabilityStoneCover.Plugin/StabilityStoneCoverPlugin.cs
    • -12
    • +12
    /Ringtoets/WaveImpactAsphaltCover/src/Ringtoets.WaveImpactAsphaltCover.Plugin/WaveImpactAsphaltCoverPlugin.cs
11:54 am

Dennis Tang <dennis.tang@deltares.nl>

Incorporated comments review 1110: - Removed obsolete function - Fixed typo

Paired with kleijn.

Related to Issue [WTI-579]

git-svn-id: https://repos.deltares.nl/repos/WettelijkToetsInstrumentarium/trunk@5937 5a3db67b-de53-47b5-99c8-a1c30a6650e2

Former-commit-id: 643fe506670aa344f861e2d7a9a4ef53df2bb16e

Former-commit-id: 431340f6d26b97c39182c6185f186e1302aed40e

Options
    • -10
    • +1
    /Ringtoets/Common/src/Ringtoets.Common.IO/FileImporters/StructuresImporter.cs
    • -1
    • +1
    /Ringtoets/Common/src/Ringtoets.Common.IO/Structures/StructuresParameterRowsValidator.cs
9:58 am

Elmar Kleijn

* Final changes on units and related descriptions (part 2) * Unified some test names

git-svn-id: https://repos.deltares.nl/repos/WettelijkToetsInstrumentarium/trunk@5936 5a3db67b-de53-47b5-99c8-a1c30a6650e2

Former-commit-id: 8c8e72a5a1de568b6ea56ae4b7a4201bad9ce639

Former-commit-id: 3387dbb86d5e1d63ccd4e73d2da78b1c7c03bf2a

Options
    • -1
    • +1
    /Ringtoets/ClosingStructures/src/Ringtoets.ClosingStructures.Data/ClosingStructuresInput.cs
    • -1
    • +1
    /Ringtoets/ClosingStructures/test/Ringtoets.ClosingStructures.Plugin.Test/ClosingStructuresPluginTest.cs
    • -1
    • +1
    /Ringtoets/Common/src/Ringtoets.Common.Data/Structures/StructuresInputBase.cs
    • -1
    • +1
    /Ringtoets/Common/src/Ringtoets.Common.IO/Structures/StructureFilesKeywords.cs
    • -1
    • +1
    /Ringtoets/GrassCoverErosionInwards/test/Ringtoets.GrassCoverErosionInwards.Plugin.Test/GrassCoverErosionInwardsPluginTest.cs
    • -1
    • +1
    /Ringtoets/HeightStructures/test/Ringtoets.HeightStructures.Plugin.Test/HeightStructuresPluginTest.cs
    • -1
    • +1
    /Ringtoets/Integration/test/Ringtoets.Integration.Plugin.Test/RingtoetsPluginTest.cs
    • -1
    • +1
    /Ringtoets/Piping/test/Ringtoets.Piping.Plugin.Test/PipingPluginTest.cs
    • -0
    • +1
    /Ringtoets/StabilityPointStructures/src/Ringtoets.StabilityPointStructures.Forms/Ringtoets.StabilityPointStructures.Forms.csproj
9:35 am

Elmar Kleijn

Final changes on units and related descriptions

Paired with rodriqu_dd

git-svn-id: https://repos.deltares.nl/repos/WettelijkToetsInstrumentarium/trunk@5935 5a3db67b-de53-47b5-99c8-a1c30a6650e2

Former-commit-id: 473cb06eac13e68e402c7f6345288814c0aa94f2

Former-commit-id: dfe128274a215c9fe3c0d99d2c497ffc946558e0

Options
    • -1
    • +13
    /Ringtoets/ClosingStructures/src/Ringtoets.ClosingStructures.Data/ClosingStructure.cs
    • -1
    • +1
    /Ringtoets/ClosingStructures/test/Ringtoets.ClosingStructures.Forms.Test/PropertyClasses/ClosingStructurePropertiesTest.cs
    • -1
    • +1
    /Ringtoets/Common/src/Ringtoets.Common.Forms/Properties/Resources.Designer.cs
    • -1
    • +1
    /Ringtoets/Common/src/Ringtoets.Common.Forms/Properties/Resources.resx
    • -1
    • +1
    /Ringtoets/HeightStructures/test/Ringtoets.HeightStructures.Forms.Test/PropertyClasses/HeightStructurePropertiesTest.cs
    • -1
    • +1
    /Ringtoets/HeightStructures/test/Ringtoets.HeightStructures.Forms.Test/PropertyClasses/HeightStructuresInputContextPropertiesTest.cs
    • -2
    • +2
    /Ringtoets/StabilityPointStructures/src/Ringtoets.StabilityPointStructures.Data/StabilityPointStructure.cs
    • -1
    • +1
    /Ringtoets/StabilityPointStructures/src/Ringtoets.StabilityPointStructures.Data/StabilityPointStructuresInput.cs
    • -1
    • +1
    /Ringtoets/StabilityPointStructures/test/Ringtoets.StabilityPointStructures.Forms.Test/PropertyClasses/StabilityPointStructurePropertiesTest.cs
8:56 am

Elmar Kleijn

Review related changes

Paired with tang_ds

Related to Issue [WTI-553]

git-svn-id: https://repos.deltares.nl/repos/WettelijkToetsInstrumentarium/trunk@5933 5a3db67b-de53-47b5-99c8-a1c30a6650e2

Former-commit-id: 2eb1988823b12b9f911c5e8f36c6e53db5d25b16

Former-commit-id: 3e799f58ab558a20dc07e1af5d88e3be2d55298c

Options
    • -3
    • +3
    /Ringtoets/ClosingStructures/test/Ringtoets.ClosingStructures.Data.Test/ClosingStructuresInputTest.cs
    • -2
    • +2
    /Ringtoets/Common/src/Ringtoets.Common.Data/Properties/Resources.Designer.cs
    • -2
    • +2
    /Ringtoets/Common/src/Ringtoets.Common.Data/Properties/Resources.resx
    • -3
    • +3
    /Ringtoets/Common/src/Ringtoets.Common.Data/Structures/StructuresInputBase.cs
    • -3
    • +3
    /Ringtoets/Common/src/Ringtoets.Common.IO/Properties/Resources.Designer.cs
    • -2
    • +2
    /Ringtoets/Common/test/Ringtoets.Common.Data.Test/Structures/StructuresInputBaseTest.cs
    • -1
    • +1
    /Ringtoets/Piping/src/Ringtoets.Piping.Primitives/Properties/Resources.Designer.cs
    • -1
    • +1
    /Ringtoets/Revetment/test/Ringtoets.Revetment.Data.Test/WaveConditionsInputTest.cs
    • -1
    • +1
    /Ringtoets/StabilityPointStructures/test/Ringtoets.StabilityPointStructures.Data.Test/StabilityPointStructuresInputTest.cs
Thursday 13 Oct 2016
5:05 pm

bos_en <bos_en@example.com>

Updated units and descriptions as discussed. Related to Issue [WTI-579]

git-svn-id: https://repos.deltares.nl/repos/WettelijkToetsInstrumentarium/trunk@5932 5a3db67b-de53-47b5-99c8-a1c30a6650e2

Former-commit-id: 5d1c48ba67c849068dac8be33331232a45151db1

Former-commit-id: 07e72eb7cced9d21a068dae028f1ebd6ae11b5ba

Options
    • -2
    • +2
    /Ringtoets/ClosingStructures/src/Ringtoets.ClosingStructures.Data/ClosingStructure.cs
    • -1
    • +1
    /Ringtoets/ClosingStructures/test/Ringtoets.ClosingStructures.Forms.Test/PropertyClasses/ClosingStructurePropertiesTest.cs
    • -2
    • +2
    /Ringtoets/Common/src/Ringtoets.Common.Data/Structures/StructuresInputBase.cs
    • -1
    • +1
    /Ringtoets/Common/src/Ringtoets.Common.Forms/Properties/Resources.Designer.cs
    • -1
    • +1
    /Ringtoets/Common/src/Ringtoets.Common.Forms/Properties/Resources.resx
    • -7
    • +7
    /Ringtoets/Common/src/Ringtoets.Common.IO/Structures/StructureFilesKeywords.cs
    • -4
    • +4
    /Ringtoets/HeightStructures/src/Ringtoets.HeightStructures.Data/HeightStructure.cs
    • -1
    • +1
    /Ringtoets/HeightStructures/test/Ringtoets.HeightStructures.Forms.Test/PropertyClasses/HeightStructurePropertiesTest.cs
    • -1
    • +1
    /Ringtoets/HeightStructures/test/Ringtoets.HeightStructures.Forms.Test/PropertyClasses/HeightStructuresInputContextPropertiesTest.cs
    • -6
    • +6
    /Ringtoets/StabilityPointStructures/src/Ringtoets.StabilityPointStructures.Data/StabilityPointStructure.cs
    • -1
    • +1
    /Ringtoets/StabilityPointStructures/src/Ringtoets.StabilityPointStructures.Forms/Properties/Resources.Designer.cs
    • -1
    • +1
    /Ringtoets/StabilityPointStructures/src/Ringtoets.StabilityPointStructures.Forms/Properties/Resources.resx
    • -2
    • +2
    /Ringtoets/StabilityPointStructures/test/Ringtoets.StabilityPointStructures.Forms.Test/PropertyClasses/StabilityPointStructurePropertiesTest.cs
11:35 am

Robert Tangerman <robert.tangerman@deltares.nl>

Implemented StructuresInputBase in StabilityPointStructuresInput Related to Issue [WTI-556]

git-svn-id: https://repos.deltares.nl/repos/WettelijkToetsInstrumentarium/trunk@5931 5a3db67b-de53-47b5-99c8-a1c30a6650e2

Former-commit-id: fe60e20a522554e5ce3861af66a7a3739c8293de

Former-commit-id: 2b5b21faa38d9b4a14cfa0fe27bda9f3c730f1ac

Options
    • -2
    • +0
    /Ringtoets/ClosingStructures/src/Ringtoets.ClosingStructures.Data/ClosingStructuresInput.cs
    • -318
    • +36
    /Ringtoets/StabilityPointStructures/src/Ringtoets.StabilityPointStructures.Data/StabilityPointStructuresInput.cs
    • -0
    • +4
    /Ringtoets/StabilityPointStructures/test/Ringtoets.StabilityPointStructures.Data.Test/Ringtoets.StabilityPointStructures.Data.Test.csproj
    • -446
    • +91
    /Ringtoets/StabilityPointStructures/test/Ringtoets.StabilityPointStructures.Data.Test/StabilityPointStructuresInputTest.cs