Riskeer

Clone Tools

Stats

Commits this week: 0
Total Committers: 28
Last Commit: 26 Nov
Commits this week: 0

Lines of code count not available

Commit Activity

Commits By Day In Week
52 week commits volume
Commits By Day In Week
Commits by day
Commits By Day In Week
Commits by hour
Commits By Hour In Day
Commit calendar
 

Most active committers (90 days)

loading
loading
  • last updated a few seconds ago
All Commits Reviews
Constraints
Constraints: committers
 
Constraints: files
Constraints: dates
Friday 06 Jul 2018
3:13 pm

Dennis Tang <dennis.tang@deltares.nl>

Cleaned up AssessmentSectionProvider:

- Cleaned up Service, call should always return a collection of AssessmentSections or something went wrong during the read.

- Cleaned up tests for clarity

- Added XMLDoc to the interface.

WTI-1761

Options
    • -1
    • +6
    /Ringtoets/Integration/src/Ringtoets.Integration.Service/Merge/AssessmentSectionProviderService.cs
    • -0
    • +3
    /Ringtoets/Integration/src/Ringtoets.Integration.Service/Merge/IAssessmentSectionProvider.cs
    • -13
    • +35
    /Ringtoets/Integration/test/Ringtoets.Integration.Service.Test/Merge/AssessmentSectionProviderServiceTest.cs
3:02 pm

Dennis Tang <dennis.tang@deltares.nl>

Added tests to assert the run and cancelled logic of this activity. WTI-1761

Options
    • -4
    • +13
    /Ringtoets/Integration/src/Ringtoets.Integration.Service/Merge/AssessmentSectionProviderActivity.cs
    • -2
    • +78
    /Ringtoets/Integration/test/Ringtoets.Integration.Service.Test/Merge/AssessmentSectionProviderActivityTest.cs
2:34 pm

Dennis Tang <dennis.tang@deltares.nl>

Renamed property of owner. WTI-1761

Options
    • -1
    • +1
    /Ringtoets/Integration/src/Ringtoets.Integration.Data/Merge/AssessmentSectionsOwner.cs
    • -1
    • +1
    /Ringtoets/Integration/test/Ringtoets.Integration.Data.Test/Merge/AssessmentSectionsOwnerTest.cs
2:02 pm

Dennis Tang <dennis.tang@deltares.nl>

Introduced owner as constructor argument of the activity to hold the assessment sections after reading. WTI-1761

Options
    • -1
    • +4
    /Ringtoets/Integration/src/Ringtoets.Integration.Service/Merge/AssessmentSectionProviderActivity.cs
    • -1
    • +4
    /Ringtoets/Integration/test/Ringtoets.Integration.Service.Test/Merge/AssessmentSectionProviderActivityTest.cs
2:02 pm

Carlos Lubbers

Use new factory method in RingtoetsPlugin WTI-1733

Options
    • -22
    • +6
    /Ringtoets/Integration/src/Ringtoets.Integration.Plugin/RingtoetsPlugin.cs
    • -105
    • +0
    /Ringtoets/Integration/test/Ringtoets.Integration.Plugin.Test/TreeNodeInfos/DesignWaterLevelCalculationsGroupContextTreeNodeInfoTest.cs
    • -105
    • +0
    /Ringtoets/Integration/test/Ringtoets.Integration.Plugin.Test/TreeNodeInfos/WaveHeightCalculationsGroupContextTreeNodeInfoTest.cs
2:01 pm

Dennis Tang <dennis.tang@deltares.nl>

Introduced an AssessmentSectionsOwner to hold the collection of AssessmentSections when running an activity to retrieve them. WTI-1761

Options
    • -0
    • +15
    /Ringtoets/Integration/src/Ringtoets.Integration.Data/Merge/AssessmentSectionsOwner.cs
    • -0
    • +1
    /Ringtoets/Integration/src/Ringtoets.Integration.Data/Ringtoets.Integration.Data.csproj
    • -0
    • +19
    /Ringtoets/Integration/test/Ringtoets.Integration.Data.Test/Merge/AssessmentSectionsOwnerTest.cs
    • -0
    • +1
    /Ringtoets/Integration/test/Ringtoets.Integration.Data.Test/Ringtoets.Integration.Data.Test.csproj
2:00 pm

Carlos Lubbers

Introduce factory for creating hbl calculations for all category boundaries WTI-1733

Options
    • -0
    • +122
    /Ringtoets/Integration/src/Ringtoets.Integration.Service/AssessmentSectionHydraulicBoundaryLocationCalculationActivityFactory.cs
    • -0
    • +1
    /Ringtoets/Integration/src/Ringtoets.Integration.Service/Ringtoets.Integration.Service.csproj
    • -0
    • +227
    /Ringtoets/Integration/test/Ringtoets.Integration.Service.Test/AssessmentSectionHydraulicBoundaryLocationCalculationActivityFactoryTest.cs
    • -0
    • +13
    /Ringtoets/Integration/test/Ringtoets.Integration.Service.Test/Ringtoets.Integration.Service.Test.csproj
1:48 pm

Dennis Tang <dennis.tang@deltares.nl>

Added initial setup for the provider activity. WTI-1761

Options
    • -0
    • +29
    /Ringtoets/Integration/src/Ringtoets.Integration.Service/Merge/AssessmentSectionProviderActivity.cs
    • -0
    • +1
    /Ringtoets/Integration/src/Ringtoets.Integration.Service/Ringtoets.Integration.Service.csproj
    • -0
    • +26
    /Ringtoets/Integration/test/Ringtoets.Integration.Service.Test/Merge/AssessmentSectionProviderActivityTest.cs
    • -0
    • +1
    /Ringtoets/Integration/test/Ringtoets.Integration.Service.Test/Ringtoets.Integration.Service.Test.csproj
1:36 pm

Robert Tangerman <robert.tangerman@deltares.nl>

Implemented returning assessment sections in provider stub. WTI-1750

Options
    • -0
    • +6
    /Ringtoets/Integration/src/Ringtoets.Integration.Forms/Dialogs/AssessmentSectionProviderStub.Designer.cs
    • -6
    • +21
    /Ringtoets/Integration/src/Ringtoets.Integration.Forms/Dialogs/AssessmentSectionProviderStub.cs
    • -9
    • +81
    /Ringtoets/Integration/test/Ringtoets.Integration.Forms.Test/Dialogs/AssessmentSectionProviderStubTest.cs
1:31 pm

Dennis Tang <dennis.tang@deltares.nl>

Wrapped StorageException when it occurs in the provider service. WTI-1761

Options
    • -3
    • +7
    /Ringtoets/Integration/src/Ringtoets.Integration.Service/Merge/AssessmentSectionProviderService.cs
    • -4
    • +21
    /Ringtoets/Integration/test/Ringtoets.Integration.Service.Test/Merge/AssessmentSectionProviderServiceTest.cs
1:20 pm

Robert Tangerman <robert.tangerman@deltares.nl>

Added extra tests. WTI-1750

Options
    • -2
    • +5
    /Ringtoets/Integration/src/Ringtoets.Integration.Forms/Dialogs/AssessmentSectionProviderStub.cs
    • -1
    • +40
    /Ringtoets/Integration/test/Ringtoets.Integration.Forms.Test/Dialogs/AssessmentSectionProviderStubTest.cs
1:06 pm

Dennis Tang <dennis.tang@deltares.nl>

Added custom exception to wrap around the StorageException when it occurs in the provider service. WTI-1761

Options
    • -0
    • +47
    /Ringtoets/Integration/src/Ringtoets.Integration.Service/Exceptions/AssessmentSectionProviderException.cs
    • -0
    • +1
    /Ringtoets/Integration/src/Ringtoets.Integration.Service/Ringtoets.Integration.Service.csproj
    • -0
    • +11
    /Ringtoets/Integration/test/Ringtoets.Integration.Service.Test/Exceptions/AssessmentSectionProviderExceptionTest.cs
    • -0
    • +1
    /Ringtoets/Integration/test/Ringtoets.Integration.Service.Test/Ringtoets.Integration.Service.Test.csproj
1:03 pm

Carlos Lubbers

Support new factory methods in gui services for hbl calculations WTI-1733

Options
    • -13
    • +19
    /Ringtoets/Common/src/Ringtoets.Common.Forms/GuiServices/HydraulicBoundaryLocationCalculationGuiService.cs
    • -14
    • +9
    /Ringtoets/Common/src/Ringtoets.Common.Forms/GuiServices/IHydraulicBoundaryLocationCalculationGuiService.cs
    • -2
    • +1
    /Ringtoets/Common/src/Ringtoets.Common.Forms/Views/DesignWaterLevelCalculationsView.cs
    • -2
    • +1
    /Ringtoets/Common/src/Ringtoets.Common.Forms/Views/WaveHeightCalculationsView.cs
    • -28
    • +126
    /Ringtoets/Common/test/Ringtoets.Common.Forms.Test/GuiServices/HydraulicBoundaryLocationCalculationGuiServiceTest.cs
    • -152
    • +10
    /Ringtoets/Common/test/Ringtoets.Common.Forms.Test/Views/DesignWaterLevelCalculationsViewTest.cs
    • -155
    • +13
    /Ringtoets/Common/test/Ringtoets.Common.Forms.Test/Views/WaveHeightCalculationsViewTest.cs
    • -4
    • +2
    /Ringtoets/GrassCoverErosionOutwards/src/Ringtoets.GrassCoverErosionOutwards.Plugin/GrassCoverErosionOutwardsPlugin.cs
    • -4
    • +2
    /Ringtoets/Integration/src/Ringtoets.Integration.Plugin/RingtoetsPlugin.cs
    • -3
    • +3
    /Ringtoets/Integration/test/Ringtoets.Integration.Plugin.Test/ViewInfos/DesignWaterLevelCalculationsViewInfoTest.cs
    • -3
    • +3
    /Ringtoets/Integration/test/Ringtoets.Integration.Plugin.Test/ViewInfos/WaveHeightCalculationsViewInfoTest.cs
12:55 pm

Dennis Tang <dennis.tang@deltares.nl>

Initial setup of a RingtoetsProjectServiceProvider. WTI-1761

Options
    • -0
    • +47
    /Ringtoets/Integration/src/Ringtoets.Integration.Service/Merge/AssessmentSectionProviderService.cs
    • -0
    • +6
    /Ringtoets/Integration/src/Ringtoets.Integration.Service/Ringtoets.Integration.Service.csproj
    • -0
    • +4
    /Ringtoets/Integration/src/Ringtoets.Integration.Service/packages.config
    • -0
    • +107
    /Ringtoets/Integration/test/Ringtoets.Integration.Service.Test/Merge/AssessmentSectionProviderServiceTest.cs
    • -0
    • +1
    /Ringtoets/Integration/test/Ringtoets.Integration.Service.Test/Ringtoets.Integration.Service.Test.csproj
12:51 pm

Dennis Tang <dennis.tang@deltares.nl>

Fixed compilation errors. WTI-1761

Options
    • -2
    • +2
    /Ringtoets/Integration/test/Ringtoets.Integration.Plugin.Test/AssessmentSectionMergerTest.cs
    • -0
    • +4
    /Ringtoets/Integration/test/Ringtoets.Integration.Plugin.Test/Ringtoets.Integration.Plugin.Test.csproj
12:04 pm

Robert Tangerman <robert.tangerman@deltares.nl>

Added buttons to dialog. WTI-1750

Options
    • -3
    • +75
    /Ringtoets/Integration/src/Ringtoets.Integration.Forms/Dialogs/AssessmentSectionProviderStub.Designer.cs
    • -2
    • +2
    /Ringtoets/Integration/src/Ringtoets.Integration.Forms/Dialogs/AssessmentSectionProviderStub.cs
    • -0
    • +120
    /Ringtoets/Integration/src/Ringtoets.Integration.Forms/Dialogs/AssessmentSectionProviderStub.resx
    • -0
    • +3
    /Ringtoets/Integration/src/Ringtoets.Integration.Forms/Ringtoets.Integration.Forms.csproj
    • -1
    • +0
    /Ringtoets/Integration/src/Ringtoets.Integration.Plugin/RingtoetsPlugin.cs
    • -2
    • +18
    /Ringtoets/Integration/test/Ringtoets.Integration.Forms.Test/Dialogs/AssessmentSectionProviderStubTest.cs
11:57 am

Dennis Tang <dennis.tang@deltares.nl>

Cleaned up Forms projects and fixed compilation errors. WTI-1761

Options
    • -0
    • +4
    /Ringtoets/Integration/src/Ringtoets.Integration.Forms/Ringtoets.Integration.Forms.csproj
    • -1
    • +1
    /Ringtoets/Integration/test/Ringtoets.Integration.Forms.Test/Dialogs/AssessmentSectionProviderStubTest.cs
    • -0
    • +4
    /Ringtoets/Integration/test/Ringtoets.Integration.Forms.Test/Ringtoets.Integration.Forms.Test.csproj
11:38 am

Dennis Tang <dennis.tang@deltares.nl>

Moved interface for the AssessmentSectionProvider to service. WTI-1761

Options
    • -1
    • +1
    /Ringtoets/Integration/src/Ringtoets.Integration.Forms/Dialogs/AssessmentSectionProviderStub.cs
    • -39
    • +0
    /Ringtoets/Integration/src/Ringtoets.Integration.Forms/Merge/IAssessmentSectionProvider.cs
    • -1
    • +0
    /Ringtoets/Integration/src/Ringtoets.Integration.Forms/Ringtoets.Integration.Forms.csproj
    • -0
    • +1
    /Ringtoets/Integration/src/Ringtoets.Integration.Plugin/AssessmentSectionMerger.cs
    • -0
    • +39
    /Ringtoets/Integration/src/Ringtoets.Integration.Service/Merge/IAssessmentSectionProvider.cs
    • -0
    • +1
    /Ringtoets/Integration/src/Ringtoets.Integration.Service/Ringtoets.Integration.Service.csproj
11:10 am

Carlos Lubbers

Refactor hydraulic boundary calculation activity to take an IAssessmentSection instead of two paths WTI-1733

Options
    • -16
    • +18
    /Ringtoets/Common/src/Ringtoets.Common.Service/HydraulicBoundaryLocationCalculationActivityFactory.cs
    • -12
    • +71
    /Ringtoets/Common/test/Ringtoets.Common.Service.Test/HydraulicBoundaryLocationCalculationActivityFactoryTest.cs
    • -4
    • +2
    /Ringtoets/GrassCoverErosionOutwards/src/Ringtoets.GrassCoverErosionOutwards.Plugin/GrassCoverErosionOutwardsPlugin.cs
    • -4
    • +2
    /Ringtoets/Integration/src/Ringtoets.Integration.Plugin/RingtoetsPlugin.cs
10:29 am

Robert Tangerman <robert.tangerman@deltares.nl>

Moved assessment section provider interface from IO to forms. WTI-1750

Options
    • -1
    • +1
    /Ringtoets/Integration/src/Ringtoets.Integration.Forms/Dialogs/AssessmentSectionProviderStub.cs
    • -0
    • +39
    /Ringtoets/Integration/src/Ringtoets.Integration.Forms/Merge/IAssessmentSectionProvider.cs
    • -0
    • +1
    /Ringtoets/Integration/src/Ringtoets.Integration.Forms/Ringtoets.Integration.Forms.csproj
    • -39
    • +0
    /Ringtoets/Integration/src/Ringtoets.Integration.IO/IAssessmentSectionProvider.cs
    • -6
    • +0
    /Ringtoets/Integration/src/Ringtoets.Integration.IO/Ringtoets.Integration.IO.csproj
    • -2
    • +1
    /Ringtoets/Integration/src/Ringtoets.Integration.Plugin/AssessmentSectionMerger.cs
    • -2
    • +1
    /Ringtoets/Integration/test/Ringtoets.Integration.Forms.Test/Dialogs/AssessmentSectionProviderStubTest.cs
    • -1
    • +1
    /Ringtoets/Integration/test/Ringtoets.Integration.Plugin.Test/AssessmentSectionMergerTest.cs
8:51 am

Carlos Lubbers

Move hydraulic boundary calculation activities to Common.Service WTI-1733

Options
    • -105
    • +0
    /Ringtoets/Common/src/Ringtoets.Common.Forms/Helpers/HydraulicBoundaryLocationCalculationActivityFactory.cs
    • -1
    • +0
    /Ringtoets/Common/src/Ringtoets.Common.Forms/Ringtoets.Common.Forms.csproj
    • -1
    • +1
    /Ringtoets/Common/src/Ringtoets.Common.Service/DesignWaterLevelCalculationActivity.cs
    • -0
    • +104
    /Ringtoets/Common/src/Ringtoets.Common.Service/HydraulicBoundaryLocationCalculationActivityFactory.cs
    • -1
    • +3
    /Ringtoets/Common/src/Ringtoets.Common.Service/Properties/AssemblyInfo.cs
    • -0
    • +1
    /Ringtoets/Common/src/Ringtoets.Common.Service/Ringtoets.Common.Service.csproj
    • -1
    • +1
    /Ringtoets/Common/src/Ringtoets.Common.Service/WaveHeightCalculationActivity.cs
    • -202
    • +0
    /Ringtoets/Common/test/Ringtoets.Common.Forms.Test/Helpers/HydraulicBoundaryLocationCalculationActivityFactoryTest.cs
    • -1
    • +0
    /Ringtoets/Common/test/Ringtoets.Common.Forms.Test/Ringtoets.Common.Forms.Test.csproj
    • -0
    • +200
    /Ringtoets/Common/test/Ringtoets.Common.Service.Test/HydraulicBoundaryLocationCalculationActivityFactoryTest.cs
    • -0
    • +1
    /Ringtoets/Common/test/Ringtoets.Common.Service.Test/Ringtoets.Common.Service.Test.csproj
    • -1
    • +0
    /Ringtoets/Integration/src/Ringtoets.Integration.Plugin/RingtoetsPlugin.cs
7:57 am

Robert Tangerman <robert.tangerman@deltares.nl>

Cleanup. WTI-1750

Options
    • -9
    • +0
    /Ringtoets/Integration/src/Ringtoets.Integration.Forms/Dialogs/AssessmentSectionProviderStub.cs
    • -11
    • +0
    /Ringtoets/Integration/test/Ringtoets.Integration.Forms.Test/Dialogs/AssessmentSectionProviderStubTest.cs
Thursday 05 Jul 2018
8:43 am

Robert Tangerman <robert.tangerman@deltares.nl>

Added assessment section provider to the merger. WTI-1750

Options
    • -1
    • +10
    /Ringtoets/Integration/src/Ringtoets.Integration.Plugin/AssessmentSectionMerger.cs
    • -1
    • +1
    /Ringtoets/Integration/src/Ringtoets.Integration.Plugin/RingtoetsPlugin.cs
    • -3
    • +15
    /Ringtoets/Integration/test/Ringtoets.Integration.Plugin.Test/AssessmentSectionMergerTest.cs
8:43 am

Robert Tangerman <robert.tangerman@deltares.nl>

Return empty string instead of null. WTI-1750

Options
    • -1
    • +1
    /Ringtoets/Integration/src/Ringtoets.Integration.Forms/Merge/InquiryMergeHelper.cs
    • -2
    • +2
    /Ringtoets/Integration/test/Ringtoets.Integration.Forms.Test/InquiryMergeHelperTest.cs
8:40 am

Robert Tangerman <robert.tangerman@deltares.nl>

Implemented AssessmentSectionProviderStub. WTI-1750

Options
    • -0
    • +60
    /Ringtoets/Integration/src/Ringtoets.Integration.Forms/Dialogs/AssessmentSectionProviderStub.Designer.cs
    • -0
    • +69
    /Ringtoets/Integration/src/Ringtoets.Integration.Forms/Dialogs/AssessmentSectionProviderStub.cs
    • -0
    • +13
    /Ringtoets/Integration/src/Ringtoets.Integration.Forms/Ringtoets.Integration.Forms.csproj
    • -1
    • +10
    /Ringtoets/Integration/src/Ringtoets.Integration.IO/IAssessmentSectionProvider.cs
    • -0
    • +80
    /Ringtoets/Integration/test/Ringtoets.Integration.Forms.Test/Dialogs/AssessmentSectionProviderStubTest.cs
    • -0
    • +5
    /Ringtoets/Integration/test/Ringtoets.Integration.Forms.Test/Ringtoets.Integration.Forms.Test.csproj
Wednesday 04 Jul 2018
5:00 pm

Carlos Lubbers

Make hydraulic boundary location calculation activity factory return CalculatableActivity objects WTI-1733

Options
    • -9
    • +10
    /Ringtoets/Common/src/Ringtoets.Common.Forms/Helpers/HydraulicBoundaryLocationCalculationActivityFactory.cs
    • -4
    • +8
    /Ringtoets/Common/test/Ringtoets.Common.Forms.Test/Helpers/HydraulicBoundaryLocationCalculationActivityFactoryTest.cs
    • -2
    • +2
    /Ringtoets/GrassCoverErosionOutwards/src/Ringtoets.GrassCoverErosionOutwards.Plugin/GrassCoverErosionOutwardsPlugin.cs
    • -2
    • +2
    /Ringtoets/Integration/src/Ringtoets.Integration.Plugin/RingtoetsPlugin.cs
3:54 pm

Robert Tangerman <robert.tangerman@deltares.nl>

Moved merge classes in forms to merge folder. WTI-1750

Options
    • -28
    • +0
    /Ringtoets/Integration/src/Ringtoets.Integration.Forms/IMergeDataProvider.cs
    • -61
    • +0
    /Ringtoets/Integration/src/Ringtoets.Integration.Forms/InquiryMergeHelper.cs
    • -0
    • +28
    /Ringtoets/Integration/src/Ringtoets.Integration.Forms/Merge/IMergeDataProvider.cs
    • -0
    • +61
    /Ringtoets/Integration/src/Ringtoets.Integration.Forms/Merge/InquiryMergeHelper.cs
    • -2
    • +2
    /Ringtoets/Integration/src/Ringtoets.Integration.Forms/Ringtoets.Integration.Forms.csproj
    • -0
    • +1
    /Ringtoets/Integration/src/Ringtoets.Integration.Plugin/RingtoetsPlugin.cs
    • -0
    • +1
    /Ringtoets/Integration/test/Ringtoets.Integration.Forms.Test/InquiryMergeHelperTest.cs
3:50 pm

Robert Tangerman <robert.tangerman@deltares.nl>

Added getting filePath in merger. WTI-1750

Options
    • -1
    • +20
    /Ringtoets/Integration/src/Ringtoets.Integration.Plugin/AssessmentSectionMerger.cs
    • -0
    • +5
    /Ringtoets/Integration/src/Ringtoets.Integration.Plugin/Ringtoets.Integration.Plugin.csproj
    • -0
    • +39
    /Ringtoets/Integration/test/Ringtoets.Integration.Plugin.Test/AssessmentSectionMergerTest.cs
    • -18
    • +18
    /Ringtoets/Storage/src/Ringtoets.Storage.Core/Properties/Resources.Designer.cs
    • -1
    • +1
    /Ringtoets/Storage/src/Ringtoets.Storage.Core/Ringtoets.Storage.Core.csproj
3:47 pm

Carlos Lubbers

Add check to category boundary name in views WTI-1733

Options
    • -0
    • +5
    /Ringtoets/Common/src/Ringtoets.Common.Forms/Views/DesignWaterLevelCalculationsView.cs
    • -0
    • +5
    /Ringtoets/Common/src/Ringtoets.Common.Forms/Views/WaveHeightCalculationsView.cs
    • -2
    • +2
    /Ringtoets/Common/src/Ringtoets.Common.Service/DesignWaterLevelCalculationActivity.cs
    • -1
    • +2
    /Ringtoets/Common/src/Ringtoets.Common.Service/WaveHeightCalculationActivity.cs
    • -0
    • +20
    /Ringtoets/Common/test/Ringtoets.Common.Forms.Test/Views/DesignWaterLevelCalculationsViewTest.cs
    • -0
    • +20
    /Ringtoets/Common/test/Ringtoets.Common.Forms.Test/Views/WaveHeightCalculationsViewTest.cs
3:47 pm

Elmar Kleijn

Adapted DuneLocationCalculationGuiService. WTI-1732

Options
    • -2
    • +1
    /Ringtoets/DuneErosion/src/Ringtoets.DuneErosion.Plugin/DuneErosionPlugin.cs
    • -54
    • +11
    /Ringtoets/DuneErosion/test/Ringtoets.DuneErosion.Forms.Test/GuiServices/DuneLocationCalculationGuiServiceTest.cs