Riskeer

Clone Tools

Stats

Commits this week: 0
Total Committers: 28
Last Commit: 12 Sep 24
Commits this week: 0

Lines of code count not available

Commit Activity

Commits By Day In Week
52 week commits volume
Commits By Day In Week
Commits by day
Commits By Day In Week
Commits by hour
Commits By Hour In Day
Commit calendar
 

Most active committers (90 days)

loading
loading
  • last updated a few seconds ago
All Commits Reviews
Constraints
Constraints: committers
 
Constraints: files
Constraints: dates
Friday 07 Sep 2018
1:16 pm

Dennis Tang <dennis.tang@deltares.nl>

Incorporated comments review 3219:

- Uniformed XMLDoc across all aggregated objects.

WTI-1803

Options
    • -3
    • +2
    /Ringtoets/Integration/src/Ringtoets.Integration.IO/AggregatedSerializable/AggregatedSerializableCombinedFailureMechanismSectionAssemblies.cs
    • -3
    • +2
    /Ringtoets/Integration/src/Ringtoets.Integration.IO/AggregatedSerializable/AggregatedSerializableCombinedFailureMechanismSectionAssembly.cs
    • -2
    • +2
    /Ringtoets/Integration/src/Ringtoets.Integration.IO/AggregatedSerializable/AggregatedSerializableFailureMechanism.cs
    • -3
    • +2
    /Ringtoets/Integration/src/Ringtoets.Integration.IO/AggregatedSerializable/AggregatedSerializableFailureMechanismSectionAssembly.cs
1:09 pm

Dennis Tang <dennis.tang@deltares.nl>

Incorporated comments review 3217:

- Fixed test name

WTI-1803

Options
    • -1
    • +1
    /Ringtoets/Integration/test/Ringtoets.Integration.IO.Test/Assembly/ExportableAssessmentSectionTest.cs
1:05 pm

Dennis Tang <dennis.tang@deltares.nl>

Incorporated review comments 3216:

- Uniformed XMLDoc for Creator functions

- Fixed typos

WTI-1803

Options
    • -1
    • +1
    /Ringtoets/Integration/src/Ringtoets.Integration.IO/Creators/AggregatedSerializableCombinedFailureMechanismSectionAssemblyCreator.cs
    • -7
    • +7
    /Ringtoets/Integration/src/Ringtoets.Integration.IO/Creators/AggregatedSerializableFailureMechanismCreator.cs
    • -6
    • +6
    /Ringtoets/Integration/src/Ringtoets.Integration.IO/Creators/AggregatedSerializableFailureMechanismSectionAssemblyCreator.cs
    • -1
    • +1
    /Ringtoets/Integration/src/Ringtoets.Integration.IO/Creators/SerializableAssessmentSectionAssemblyResultCreator.cs
    • -1
    • +1
    /Ringtoets/Integration/src/Ringtoets.Integration.IO/Creators/SerializableAssessmentSectionCategoryGroupCreator.cs
    • -1
    • +1
    /Ringtoets/Integration/src/Ringtoets.Integration.IO/Creators/SerializableAssessmentSectionCreator.cs
    • -1
    • +2
    /Ringtoets/Integration/src/Ringtoets.Integration.IO/Creators/SerializableCombinedFailureMechanismSectionAssemblyResultCreator.cs
    • -1
    • +1
    /Ringtoets/Integration/src/Ringtoets.Integration.IO/Creators/SerializableFailureMechanismCategoryGroupCreator.cs
    • -2
    • +2
    /Ringtoets/Integration/src/Ringtoets.Integration.IO/Creators/SerializableFailureMechanismCreator.cs
    • -1
    • +1
    /Ringtoets/Integration/src/Ringtoets.Integration.IO/Creators/SerializableFailureMechanismGroupCreator.cs
    • -4
    • +4
    /Ringtoets/Integration/src/Ringtoets.Integration.IO/Creators/SerializableFailureMechanismResultCreator.cs
    • -4
    • +6
    /Ringtoets/Integration/src/Ringtoets.Integration.IO/Creators/SerializableFailureMechanismSectionAssemblyResultCreator.cs
    • -1
    • +1
    /Ringtoets/Integration/src/Ringtoets.Integration.IO/Creators/SerializableFailureMechanismSectionCategoryGroupCreator.cs
    • -3
    • +3
    /Ringtoets/Integration/src/Ringtoets.Integration.IO/Creators/SerializableFailureMechanismSectionCreator.cs
    • -1
    • +1
    /Ringtoets/Integration/src/Ringtoets.Integration.IO/Creators/SerializableFailureMechanismTypeCreator.cs
11:32 am

Dennis Tang <dennis.tang@deltares.nl>

Incorporated comments review 3216:

- Uniformed XMLDocs of creator classes

WTI-1803

Options
    • -1
    • +1
    /Ringtoets/Integration/src/Ringtoets.Integration.IO/Creators/AggregatedSerializableFailureMechanismSectionAssemblyCreator.cs
    • -1
    • +1
    /Ringtoets/Integration/src/Ringtoets.Integration.IO/Creators/SerializableAssemblyCreator.cs
    • -1
    • +1
    /Ringtoets/Integration/src/Ringtoets.Integration.IO/Creators/SerializableFailureMechanismSectionCreator.cs
10:51 am

Elmar Kleijn

Moved ModelFactorSuperCriticalFlow from StructuresInputBase to ClosingStructuresInput and HeightStructuresInput. WTI-1800

Options
    • -1
    • +1
    /Ringtoets/ClosingStructures/test/Ringtoets.ClosingStructures.IO.Test/Configurations/ClosingStructuresCalculationStochastAssignerTest.cs
    • -3
    • +3
    /Ringtoets/ClosingStructures/test/Ringtoets.ClosingStructures.IO.Test/test-data/ClosingStructuresCalculationConfigurationExporter/completeConfiguration.xml
    • -3
    • +3
    /Ringtoets/ClosingStructures/test/Ringtoets.ClosingStructures.IO.Test/test-data/ClosingStructuresCalculationConfigurationExporter/configurationWithForeshoreProfile.xml
    • -3
    • +3
    /Ringtoets/ClosingStructures/test/Ringtoets.ClosingStructures.IO.Test/test-data/ClosingStructuresCalculationConfigurationExporter/configurationWithStructure.xml
    • -3
    • +3
    /Ringtoets/ClosingStructures/test/Ringtoets.ClosingStructures.IO.Test/test-data/ClosingStructuresCalculationConfigurationExporter/configurationWithUseBreakWater.xml
    • -6
    • +6
    /Ringtoets/ClosingStructures/test/Ringtoets.ClosingStructures.IO.Test/test-data/ClosingStructuresCalculationConfigurationExporter/folderWithSubfolderAndCalculation.xml
    • -3
    • +3
    /Ringtoets/ClosingStructures/test/Ringtoets.ClosingStructures.IO.Test/test-data/ClosingStructuresCalculationConfigurationExporter/sparseConfiguration.xml
    • -4
    • +4
    /Ringtoets/ClosingStructures/test/Ringtoets.ClosingStructures.IO.Test/test-data/ClosingStructuresCalculationConfigurationWriter/completeConfiguration.xml
    • -4
    • +4
    /Ringtoets/ClosingStructures/test/Ringtoets.ClosingStructures.IO.Test/test-data/ClosingStructuresCalculationConfigurationWriter/folderWithSubfolderAndCalculation.xml
10:43 am

Dennis Tang <dennis.tang@deltares.nl>

Incorporated comments review 3216:

- Removed parameter name check for the InvalidEnumArgumentException tests, as the parameter name is already present in the exception message.

WTI-1803

Options
    • -2
    • +1
    /Ringtoets/Integration/test/Ringtoets.Integration.IO.Test/Creators/SerializableAssemblyMethodCreatorTest.cs
    • -2
    • +1
    /Ringtoets/Integration/test/Ringtoets.Integration.IO.Test/Creators/SerializableAssessmentSectionCategoryGroupCreatorTest.cs
    • -2
    • +1
    /Ringtoets/Integration/test/Ringtoets.Integration.IO.Test/Creators/SerializableFailureMechanismCategoryGroupCreatorTest.cs
    • -2
    • +1
    /Ringtoets/Integration/test/Ringtoets.Integration.IO.Test/Creators/SerializableFailureMechanismGroupCreatorTest.cs
    • -2
    • +1
    /Ringtoets/Integration/test/Ringtoets.Integration.IO.Test/Creators/SerializableFailureMechanismSectionCategoryGroupCreatorTest.cs
    • -2
    • +1
    /Ringtoets/Integration/test/Ringtoets.Integration.IO.Test/Creators/SerializableFailureMechanismTypeCreatorTest.cs
10:34 am

Dennis Tang <dennis.tang@deltares.nl>

Incorporated comments review 3215:

- Removed ArgumentNullException tests that are part of an internal call.

WTI-1803

Options
    • -12
    • +0
    /Ringtoets/Integration/test/Ringtoets.Integration.IO.Test/Creators/SerializableAssessmentProcessCreatorTest.cs
    • -60
    • +0
    /Ringtoets/Integration/test/Ringtoets.Integration.IO.Test/Creators/SerializableTotalAssemblyResultCreatorTest.cs
10:24 am

Dennis Tang <dennis.tang@deltares.nl>

Incorporated comments review 3214:

- Synchronised XMLDocs through the test factories

- Fixed test names

- Cleaned up tests

WTI-1803

Options
    • -82
    • +24
    /Ringtoets/Integration/test/Ringtoets.Integration.IO.Test/Assembly/ExportableAssessmentSectionTest.cs
    • -10
    • +8
    /Ringtoets/Integration/test/Ringtoets.Integration.IO.Test/Assembly/ExportableFailureMechanismTest.cs
    • -1
    • +1
    /Ringtoets/Integration/test/Ringtoets.Integration.IO.TestUtil.Test/ExportableFailureMechanismAssemblyResultTestFactoryTest.cs
    • -1
    • +1
    /Ringtoets/Integration/test/Ringtoets.Integration.IO.TestUtil/ExportableAssessmentSectionAssemblyResultTestFactory.cs
    • -4
    • +4
    /Ringtoets/Integration/test/Ringtoets.Integration.IO.TestUtil/ExportableFailureMechanismAssemblyResultTestFactory.cs
    • -2
    • +2
    /Ringtoets/Integration/test/Ringtoets.Integration.IO.TestUtil/ExportableFailureMechanismSectionTestFactory.cs
    • -2
    • +2
    /Ringtoets/Integration/test/Ringtoets.Integration.IO.TestUtil/ExportableSectionAssemblyResultTestFactory.cs
10:19 am

Elmar Kleijn

Moved ModelFactorSuperCriticalFlow from StructuresInputBase to ClosingStructuresInput and HeightStructuresInput. WTI-1800

Options
    • -4
    • +0
    /Ringtoets/Storage/test/Ringtoets.Storage.Core.Test/Read/StructureCalculationEntityReadExtensionsTest.cs
    • -8
    • +0
    /Ringtoets/Storage/test/Ringtoets.Storage.Core.TestUtil/RingtoetsProjectTestHelper.cs
10:17 am

Elmar Kleijn

Moved ModelFactorSuperCriticalFlow from StructuresInputBase to ClosingStructuresInput and HeightStructuresInput. WTI-1800

Options
    • -1
    • +2
    /Ringtoets/Storage/test/Ringtoets.Storage.Core.Test/IntegrationTests/StorageSqLiteIntegrationTest.cs
    • -52
    • +48
    /Ringtoets/Storage/test/Ringtoets.Storage.Core.Test/Read/StabilityPointStructures/StabilityPointStructuresCalculationEntityReadExtensionsTest.cs
10:12 am

Elmar Kleijn

Moved ModelFactorSuperCriticalFlow from StructuresInputBase to ClosingStructuresInput and HeightStructuresInput. WTI-1800

Options
    • -9
    • +0
    /Ringtoets/Storage/test/Ringtoets.Storage.Core.Test/Create/StructuresCalculationCreateExtensionsTest.cs
10:11 am

Elmar Kleijn

Moved ModelFactorSuperCriticalFlow from StructuresInputBase to ClosingStructuresInput and HeightStructuresInput. WTI-1800

Options
    • -4
    • +6
    /Ringtoets/Storage/src/Ringtoets.Storage.Core/Create/StructuresCalculationCreateExtensions.cs
    • -0
    • +1
    /Ringtoets/Storage/src/Ringtoets.Storage.Core/Read/ClosingStructures/ClosingStructuresCalculationEntityReadExtensions.cs
    • -1
    • +2
    /Ringtoets/Storage/src/Ringtoets.Storage.Core/Read/HeightStructures/HeightStructuresCalculationEntityReadExtensions.cs
    • -1
    • +0
    /Ringtoets/Storage/src/Ringtoets.Storage.Core/Read/StructureCalculationEntityReadExtensions.cs
10:07 am

Elmar Kleijn

Moved ModelFactorSuperCriticalFlow from StructuresInputBase to ClosingStructuresInput and HeightStructuresInput. WTI-1800

Options
    • -8
    • +0
    /Ringtoets/HydraRing/src/Ringtoets.HydraRing.Calculation/Data/Input/Structures/StructuresStabilityPointLowSillQuadraticCalculationInput.cs
    • -4
    • +3
    /Ringtoets/HydraRing/test/Ringtoets.HydraRing.Calculation.Test/Data/Input/Structures/StructuresStabilityPointLowSillLinearCalculationInputTest.cs
    • -14
    • +10
    /Ringtoets/HydraRing/test/Ringtoets.HydraRing.Calculation.Test/Data/Input/Structures/StructuresStabilityPointLowSillQuadraticCalculationInputTest.cs
    • -1
    • +1
    /Ringtoets/HydraRing/test/Ringtoets.HydraRing.Calculation.Test/Integration/HydraRingConfigurationServiceIntegrationTest.cs
    • -2
    • +0
    /Ringtoets/StabilityPointStructures/src/Ringtoets.StabilityPointStructures.Service/StabilityPointStructuresCalculationService.cs
    • -4
    • +0
    /Ringtoets/StabilityPointStructures/test/Ringtoets.StabilityPointStructures.Service.Test/StabilityPointStructuresCalculationServiceTest.cs
9:57 am

Dennis Tang <dennis.tang@deltares.nl>

Added log messages:

- Updated query to keep track of the total count of elements that remain instead of only macrostability inwards.

WTI-1765

Options
    • -15
    • +10
    /Ringtoets/Migration/src/Ringtoets.Migration.Core/EmbeddedResources/Migration_17.3_18.1.sql
9:57 am

Dennis Tang <dennis.tang@deltares.nl>

Added log messages:

- Updated query to keep track of the total count of elements that remain instead of only macrostability inwards.

WTI-1765

Options
    • -15
    • +10
    /Ringtoets/Migration/src/Ringtoets.Migration.Core/EmbeddedResources/Migration_17.3_18.1.sql
9:55 am

Elmar Kleijn

Moved ModelFactorSuperCriticalFlow from StructuresInputBase to ClosingStructuresInput and HeightStructuresInput. WTI-1800

Options
    • -68
    • +63
    /Ringtoets/StabilityPointStructures/test/Ringtoets.StabilityPointStructures.Service.Test/StabilityPointStructuresCalculationServiceTest.cs
9:52 am

Elmar Kleijn

Moved ModelFactorSuperCriticalFlow from StructuresInputBase to ClosingStructuresInput and HeightStructuresInput. WTI-1800

Options
    • -8
    • +0
    /Ringtoets/HydraRing/src/Ringtoets.HydraRing.Calculation/Data/Input/Structures/StructuresStabilityPointLowSillLinearCalculationInput.cs
    • -10
    • +7
    /Ringtoets/HydraRing/test/Ringtoets.HydraRing.Calculation.Test/Data/Input/Structures/StructuresStabilityPointLowSillLinearCalculationInputTest.cs
    • -1
    • +1
    /Ringtoets/HydraRing/test/Ringtoets.HydraRing.Calculation.Test/Integration/HydraRingConfigurationServiceIntegrationTest.cs
    • -2
    • +0
    /Ringtoets/StabilityPointStructures/src/Ringtoets.StabilityPointStructures.Service/StabilityPointStructuresCalculationService.cs
    • -4
    • +0
    /Ringtoets/StabilityPointStructures/test/Ringtoets.StabilityPointStructures.IO.Test/Configurations/StabilityPointStructuresCalculationStochastAssignerTest.cs
    • -4
    • +0
    /Ringtoets/StabilityPointStructures/test/Ringtoets.StabilityPointStructures.Service.Test/StabilityPointStructuresCalculationServiceTest.cs
9:47 am

Elmar Kleijn

Moved ModelFactorSuperCriticalFlow from StructuresInputBase to ClosingStructuresInput and HeightStructuresInput. WTI-1800

Options
    • -9
    • +0
    /Ringtoets/StabilityPointStructures/test/Ringtoets.StabilityPointStructures.IO.Test/Configurations/StabilityPointStructuresCalculationConfigurationImporterTest.cs
    • -13
    • +0
    /Ringtoets/StabilityPointStructures/test/Ringtoets.StabilityPointStructures.IO.Test/Configurations/StabilityPointStructuresCalculationConfigurationReaderTest.cs
9:45 am

Elmar Kleijn

Moved ModelFactorSuperCriticalFlow from StructuresInputBase to ClosingStructuresInput and HeightStructuresInput. WTI-1800

Options
    • -6
    • +6
    /Ringtoets/StabilityPointStructures/src/Ringtoets.StabilityPointStructures.Service/StabilityPointStructuresCalculationService.cs
    • -13
    • +8
    /Ringtoets/StabilityPointStructures/test/Ringtoets.StabilityPointStructures.Service.Test/StabilityPointStructuresCalculationServiceTest.cs
9:43 am

Elmar Kleijn

Moved ModelFactorSuperCriticalFlow from StructuresInputBase to ClosingStructuresInput and HeightStructuresInput. WTI-1800

Options
    • -1
    • +0
    /Ringtoets/StabilityPointStructures/src/Ringtoets.StabilityPointStructures.IO/Configurations/StabilityPointStructuresCalculationConfigurationReader.cs
    • -6
    • +2
    /Ringtoets/StabilityPointStructures/src/Ringtoets.StabilityPointStructures.IO/Configurations/StabilityPointStructuresCalculationStochastAssigner.cs
9:09 am

Elmar Kleijn

Moved ModelFactorSuperCriticalFlow from StructuresInputBase to ClosingStructuresInput and HeightStructuresInput. WTI-1800

Options
    • -0
    • +49
    /Ringtoets/ClosingStructures/test/Ringtoets.ClosingStructures.IO.Test/Configurations/ClosingStructuresCalculationStochastAssignerTest.cs
    • -14
    • +0
    /Ringtoets/Common/test/Ringtoets.Common.IO.Test/Configurations/StructuresCalculationStochastAssignerTest.cs
    • -0
    • +47
    /Ringtoets/HeightStructures/test/Ringtoets.HeightStructures.IO.Test/Configurations/HeightStructuresCalculationStochastAssignerTest.cs
Thursday 06 Sep 2018
4:52 pm

Elmar Kleijn

Moved ModelFactorSuperCriticalFlow from StructuresInputBase to ClosingStructuresInput and HeightStructuresInput. WTI-1800

Options
    • -0
    • +10
    /Ringtoets/ClosingStructures/src/Ringtoets.ClosingStructures.IO/Configurations/ClosingStructuresCalculationStochastAssigner.cs
    • -0
    • +2
    /Ringtoets/Common/src/Ringtoets.Common.IO/Configurations/Helpers/ConfigurationValidationExtensions.cs
    • -8
    • +0
    /Ringtoets/Common/src/Ringtoets.Common.IO/Configurations/StructuresCalculationStochastAssigner.cs
    • -0
    • +16
    /Ringtoets/HeightStructures/src/Ringtoets.HeightStructures.IO/Configurations/HeightStructuresCalculationStochastAssigner.cs
4:51 pm

Dennis Tang <dennis.tang@deltares.nl>

Added log messages:

- Add log messages when output is cleared

- Fixed failing test by updating the soil layers

WTI-1756

Options
    • -0
    • +75
    /Ringtoets/Migration/src/Ringtoets.Migration.Core/EmbeddedResources/Migration_17.3_18.1.sql
    • binary
    /Ringtoets/Migration/test/Ringtoets.Migration.Core.Test/test-data/MigrationTestProject173.rtd
    • -2
    • +5
    /Ringtoets/Migration/test/Ringtoets.Migration.Integration.Test/MigrationTo181IntegrationTest.cs
4:51 pm

Dennis Tang <dennis.tang@deltares.nl>

Added log messages:

- Add log messages when output is cleared

- Fixed failing test by updating the soil layers

WTI-1756

Options
    • -0
    • +75
    /Ringtoets/Migration/src/Ringtoets.Migration.Core/EmbeddedResources/Migration_17.3_18.1.sql
    • binary
    /Ringtoets/Migration/test/Ringtoets.Migration.Core.Test/test-data/MigrationTestProject173.rtd
    • -2
    • +5
    /Ringtoets/Migration/test/Ringtoets.Migration.Integration.Test/MigrationTo181IntegrationTest.cs
4:39 pm

Elmar Kleijn

Moved ModelFactorSuperCriticalFlow from StructuresInputBase to ClosingStructuresInput and HeightStructuresInput. WTI-1800

Options
    • -35
    • +0
    /Ringtoets/Common/src/Ringtoets.Common.IO/Configurations/Helpers/ConfigurationValidationExtensions.cs
    • -186
    • +0
    /Ringtoets/Common/test/Ringtoets.Common.IO.Test/Configurations/Helpers/ConfigurationValidationExtensionsTest.cs
4:14 pm

Dennis Tang <dennis.tang@deltares.nl>

Updated migration logic for macro stability inwards:

- Only migrate when a manual assessment level was entered

- Added documentation to the migration script.

WTI-1765

Options
    • -1
    • +30
    /Ringtoets/Migration/src/Ringtoets.Migration.Core/EmbeddedResources/Migration_17.3_18.1.sql
    • -1
    • +67
    /Ringtoets/Migration/test/Ringtoets.Migration.Integration.Test/MigrationTo181IntegrationTest.cs
4:14 pm

Dennis Tang <dennis.tang@deltares.nl>

Updated migration logic for macro stability inwards:

- Only migrate when a manual assessment level was entered

- Added documentation to the migration script.

WTI-1765

Options
    • -1
    • +30
    /Ringtoets/Migration/src/Ringtoets.Migration.Core/EmbeddedResources/Migration_17.3_18.1.sql
    • -1
    • +67
    /Ringtoets/Migration/test/Ringtoets.Migration.Integration.Test/MigrationTo181IntegrationTest.cs
3:49 pm

Dennis Tang <dennis.tang@deltares.nl>

Updated migration logic for piping:

- Only migrate when a manual assessment level was entered

WTI-1765

Options
    • -1
    • +8
    /Ringtoets/Migration/src/Ringtoets.Migration.Core/EmbeddedResources/Migration_17.3_18.1.sql
    • -1
    • +18
    /Ringtoets/Migration/test/Ringtoets.Migration.Integration.Test/MigrationTo181IntegrationTest.cs
3:49 pm

Dennis Tang <dennis.tang@deltares.nl>

Updated migration logic for piping:

- Only migrate when a manual assessment level was entered

WTI-1765

Options
    • -1
    • +8
    /Ringtoets/Migration/src/Ringtoets.Migration.Core/EmbeddedResources/Migration_17.3_18.1.sql
    • -1
    • +18
    /Ringtoets/Migration/test/Ringtoets.Migration.Integration.Test/MigrationTo181IntegrationTest.cs
3:23 pm

Dennis Tang <dennis.tang@deltares.nl>

Removed migration of outputs:

- Removed migration logic for hydraring output that should always be removed (except Piping and macroStabilityInwards)

- Added additional testcases for the reference project for grass cover erosion outwards calculations.

WTI-1765

Options
    • -67
    • +0
    /Ringtoets/Migration/src/Ringtoets.Migration.Core/EmbeddedResources/Migration_17.3_18.1.sql
    • binary
    /Ringtoets/Migration/test/Ringtoets.Migration.Core.Test/test-data/MigrationTestProject173.rtd
    • -84
    • +39
    /Ringtoets/Migration/test/Ringtoets.Migration.Integration.Test/MigrationTo181IntegrationTest.cs