Riskeer

Clone Tools

Stats

Commits this week: 0
Total Committers: 28
Last Commit: 26 Nov
Commits this week: 0

Lines of code count not available

Commit Activity

Commits By Day In Week
52 week commits volume
Commits By Day In Week
Commits by day
Commits By Day In Week
Commits by hour
Commits By Hour In Day
Commit calendar
 

Most active committers (90 days)

loading
loading
  • last updated a few seconds ago
All Commits Reviews
Constraints
Constraints: committers
 
Constraints: files
Constraints: dates
Friday 24 Aug 2018
12:59 pm

Carlos Lubbers

Reduce code smells from sonarqube in ClosingStructures namespace WTI-1787

Options
    • -4
    • +4
    /Ringtoets/ClosingStructures/src/Ringtoets.ClosingStructures.Forms/Views/ClosingStructuresFailureMechanismSectionResultRow.cs
    • -17
    • +17
    /Ringtoets/ClosingStructures/src/Ringtoets.ClosingStructures.IO/Configurations/ClosingStructuresCalculationConfigurationImporter.cs
    • -4
    • +4
    /Ringtoets/ClosingStructures/src/Ringtoets.ClosingStructures.IO/Configurations/ClosingStructuresCalculationStochastAssigner.cs
    • -9
    • +9
    /Ringtoets/ClosingStructures/test/Ringtoets.ClosingStructures.Forms.Test/Views/ClosingStructuresFailureMechanismSectionResultRowTest.cs
12:59 pm

Carlos Lubbers

Reduce code smells from sonarqube in AssemblyTool namespace WTI-1787

Options
    • -2
    • +2
    /Ringtoets/AssemblyTool/test/Ringtoets.AssemblyTool.KernelWrapper.TestUtil/Kernels/Assembly/AssessmentSectionAssemblyKernelStub.cs
12:58 pm

Carlos Lubbers

Reduce code smells from sonarqube in Core namespace WTI-1787

Options
    • -5
    • +3
    /Core/Common/src/Core.Common.Base/Geometry/Point3DCollectionExtensions.cs
    • -6
    • +3
    /Core/Components/src/Core.Components.DotSpatial.Forms/MapControl.cs
    • -9
    • +7
    /Core/Components/src/Core.Components.DotSpatial/Layer/BruTile/BruTileLayer.cs
    • -1
    • +1
    /Core/Components/src/Core.Components.DotSpatial/MapFunctions/MapFunctionSelectionZoom.cs
    • -5
    • +5
    /Core/Components/src/Core.Components.DotSpatial/Projections/TileReprojector.cs
11:36 am

Elmar Kleijn

Improved log message in case of unexpected error in macro stability inwards calculations. WTI-1758

Options
    • -0
    • +9
    /Ringtoets/Common/src/Ringtoets.Common.Service/Properties/Resources.Designer.cs
    • -0
    • +3
    /Ringtoets/Common/src/Ringtoets.Common.Service/Properties/Resources.resx
    • -1
    • +2
    /Ringtoets/MacroStabilityInwards/src/Ringtoets.MacroStabilityInwards.Service/MacroStabilityInwardsCalculationService.cs
    • -10
    • +0
    /Ringtoets/MacroStabilityInwards/src/Ringtoets.MacroStabilityInwards.Service/Properties/Resources.Designer.cs
    • -3
    • +0
    /Ringtoets/MacroStabilityInwards/src/Ringtoets.MacroStabilityInwards.Service/Properties/Resources.resx
    • -1
    • +1
    /Ringtoets/MacroStabilityInwards/test/Ringtoets.MacroStabilityInwards.Service.Test/MacroStabilityInwardsCalculationServiceTest.cs
11:33 am

Dennis Tang <dennis.tang@deltares.nl>

Introduced creator to create the root node SerializableAssembly:

- Initial commit, creator is filled with empty data

WTI-1803

Options
    • -0
    • +81
    /Ringtoets/Integration/src/Ringtoets.Integration.IO/Creators/SerializableAssemblyCreator.cs
    • -0
    • +6
    /Ringtoets/Integration/src/Ringtoets.Integration.IO/Ringtoets.Integration.IO.csproj
    • -0
    • +120
    /Ringtoets/Integration/test/Ringtoets.Integration.IO.Test/Creators/SerializableAssemblyCreatorTest.cs
    • -0
    • +5
    /Ringtoets/Integration/test/Ringtoets.Integration.IO.Test/Ringtoets.Integration.IO.Test.csproj
11:02 am

Robert Tangerman <robert.tangerman@deltares.nl>

Improvements after review. WTI-1715

Options
    • -1
    • +1
    /Ringtoets/GrassCoverErosionInwards/src/Ringtoets.GrassCoverErosionInwards.IO/Configurations/GrassCoverErosionInwardsCalculationConfigurationWriter.cs
    • -1
    • +6
    /Ringtoets/GrassCoverErosionInwards/test/Ringtoets.GrassCoverErosionInwards.IO.Test/Configurations/GrassCoverErosionInwardsCalculationConfigurationExporterTest.cs
    • -0
    • +1
    /Ringtoets/GrassCoverErosionInwards/test/Ringtoets.GrassCoverErosionInwards.IO.Test/test-data/GrassCoverErosionInwardsCalculationConfigurationExporter/folderWithSubfolderAndCalculation.xml
    • -1
    • +1
    /Ringtoets/GrassCoverErosionInwards/test/Ringtoets.GrassCoverErosionInwards.IO.Test/test-data/GrassCoverErosionInwardsCalculationConfigurationWriter/completeConfiguration.xml
    • -1
    • +1
    /Ringtoets/GrassCoverErosionInwards/test/Ringtoets.GrassCoverErosionInwards.IO.Test/test-data/GrassCoverErosionInwardsCalculationConfigurationWriter/folderWithSubfolderAndCalculation.xml
11:02 am

Robert Tangerman <robert.tangerman@deltares.nl>

Improvements after review. WTI-1715

Options
    • -1
    • +1
    /Ringtoets/GrassCoverErosionInwards/src/Ringtoets.GrassCoverErosionInwards.IO/Configurations/GrassCoverErosionInwardsCalculationConfigurationWriter.cs
    • -1
    • +6
    /Ringtoets/GrassCoverErosionInwards/test/Ringtoets.GrassCoverErosionInwards.IO.Test/Configurations/GrassCoverErosionInwardsCalculationConfigurationExporterTest.cs
    • -0
    • +1
    /Ringtoets/GrassCoverErosionInwards/test/Ringtoets.GrassCoverErosionInwards.IO.Test/test-data/GrassCoverErosionInwardsCalculationConfigurationExporter/folderWithSubfolderAndCalculation.xml
    • -1
    • +1
    /Ringtoets/GrassCoverErosionInwards/test/Ringtoets.GrassCoverErosionInwards.IO.Test/test-data/GrassCoverErosionInwardsCalculationConfigurationWriter/completeConfiguration.xml
    • -1
    • +1
    /Ringtoets/GrassCoverErosionInwards/test/Ringtoets.GrassCoverErosionInwards.IO.Test/test-data/GrassCoverErosionInwardsCalculationConfigurationWriter/folderWithSubfolderAndCalculation.xml
10:58 am

Dennis Tang <dennis.tang@deltares.nl>

Reverted wrongly committed project Integration.IO.Test:

- Reverted part of commit a5a1867560f3705d7037a951c9c1a7f9e817a0a6

WTI-1803

Options
    • -5
    • +0
    /Ringtoets/Integration/test/Ringtoets.Integration.IO.Test/Ringtoets.Integration.IO.Test.csproj
10:50 am

Dennis Tang <dennis.tang@deltares.nl>

Introduced test factory to create exportable assessment section assembly results. WTI-1803

Options
    • -23
    • +16
    /Ringtoets/Integration/test/Ringtoets.Integration.IO.Test/Assembly/ExportableAssessmentSectionTest.cs
    • -0
    • +44
    /Ringtoets/Integration/test/Ringtoets.Integration.IO.TestUtil.Test/ExportableAssessmentSectionAssemblyResultTestFactoryTest.cs
    • -0
    • +1
    /Ringtoets/Integration/test/Ringtoets.Integration.IO.TestUtil.Test/Ringtoets.Integration.IO.TestUtil.Test.csproj
    • -0
    • +43
    /Ringtoets/Integration/test/Ringtoets.Integration.IO.TestUtil/ExportableAssessmentSectionAssemblyResultTestFactory.cs
    • -0
    • +1
    /Ringtoets/Integration/test/Ringtoets.Integration.IO.TestUtil/Ringtoets.Integration.IO.TestUtil.csproj
10:44 am

Dennis Tang <dennis.tang@deltares.nl>

Introduced test factory to create exportable failure mechanism assembly results:

- Renamed factory methods.

WTI-1803

Options
    • -16
    • +16
    /Ringtoets/Integration/test/Ringtoets.Integration.IO.Test/Assembly/ExportableAssessmentSectionTest.cs
    • -3
    • +3
    /Ringtoets/Integration/test/Ringtoets.Integration.IO.Test/Assembly/ExportableFailureMechanismTest.cs
    • -5
    • +5
    /Ringtoets/Integration/test/Ringtoets.Integration.IO.TestUtil.Test/ExportableFailureMechanismAssemblyResultTestFactoryTest.cs
    • -2
    • +2
    /Ringtoets/Integration/test/Ringtoets.Integration.IO.TestUtil/ExportableFailureMechanismAssemblyResultTestFactory.cs
10:37 am

Carlos Lubbers

Cleanup xmldocs WTI-1713 Paired with roberttangerman

Options
    • -3
    • +6
    /Ringtoets/Revetment/src/Ringtoets.Revetment.IO/WaveConditions/ExportableWaveConditions.cs
    • -52
    • +44
    /Ringtoets/Revetment/src/Ringtoets.Revetment.IO/WaveConditions/ExportableWaveConditionsFactory.cs
10:35 am

Dennis Tang <dennis.tang@deltares.nl>

Merge branch 'master' into AssemblyExport

Options
10:34 am

Dennis Tang <dennis.tang@deltares.nl>

Introduced test factory to create exportable failure mechanism assembly results:

- Removed local definitions from the intermediate data model.

WTI-1803

Options
    • -36
    • +23
    /Ringtoets/Integration/test/Ringtoets.Integration.IO.Test/Assembly/ExportableAssessmentSectionTest.cs
    • -11
    • +7
    /Ringtoets/Integration/test/Ringtoets.Integration.IO.Test/Assembly/ExportableFailureMechanismTest.cs
    • -0
    • +5
    /Ringtoets/Integration/test/Ringtoets.Integration.IO.Test/Ringtoets.Integration.IO.Test.csproj
    • -0
    • +56
    /Ringtoets/Integration/test/Ringtoets.Integration.IO.TestUtil.Test/ExportableFailureMechanismAssemblyResultTestFactoryTest.cs
    • -0
    • +1
    /Ringtoets/Integration/test/Ringtoets.Integration.IO.TestUtil.Test/Ringtoets.Integration.IO.TestUtil.Test.csproj
    • -0
    • +54
    /Ringtoets/Integration/test/Ringtoets.Integration.IO.TestUtil/ExportableFailureMechanismAssemblyResultTestFactory.cs
    • -0
    • +1
    /Ringtoets/Integration/test/Ringtoets.Integration.IO.TestUtil/Ringtoets.Integration.IO.TestUtil.csproj
10:30 am

Robert Tangerman <robert.tangerman@deltares.nl>

Improvements after review. WTI-1715

Options
    • -1
    • +1
    /Ringtoets/ClosingStructures/test/Ringtoets.ClosingStructures.IO.Test/Configurations/ClosingStructuresCalculationConfigurationReaderTest.cs
    • -4
    • +4
    /Ringtoets/Common/src/Ringtoets.Common.IO/Configurations/ConfigurationSchemaIdentifiers.cs
    • -2
    • +2
    /Ringtoets/Common/src/Ringtoets.Common.IO/Configurations/Helpers/XElementExtensions.cs
    • -4
    • +3
    /Ringtoets/Common/src/Ringtoets.Common.IO/Resources/HbLocatieSchema.xsd
    • -5
    • +24
    /Ringtoets/Common/test/Ringtoets.Common.IO.Test/Configurations/Helpers/XElementExtensionsTest.cs
10:30 am

Robert Tangerman <robert.tangerman@deltares.nl>

Improvements after review. WTI-1715

Options
    • -1
    • +1
    /Ringtoets/ClosingStructures/test/Ringtoets.ClosingStructures.IO.Test/Configurations/ClosingStructuresCalculationConfigurationReaderTest.cs
    • -4
    • +4
    /Ringtoets/Common/src/Ringtoets.Common.IO/Configurations/ConfigurationSchemaIdentifiers.cs
    • -2
    • +2
    /Ringtoets/Common/src/Ringtoets.Common.IO/Configurations/Helpers/XElementExtensions.cs
    • -4
    • +3
    /Ringtoets/Common/src/Ringtoets.Common.IO/Resources/HbLocatieSchema.xsd
    • -5
    • +24
    /Ringtoets/Common/test/Ringtoets.Common.IO.Test/Configurations/Helpers/XElementExtensionsTest.cs
9:48 am

Dennis Tang <dennis.tang@deltares.nl>

Introduced class to generate unique identifiers for the serializable objects. WTI-1803

Options
    • -0
    • +48
    /Ringtoets/Integration/src/Ringtoets.Integration.IO/Helpers/UniqueIdentifierGenerator.cs
    • -0
    • +1
    /Ringtoets/Integration/src/Ringtoets.Integration.IO/Ringtoets.Integration.IO.csproj
    • -0
    • +69
    /Ringtoets/Integration/test/Ringtoets.Integration.IO.Test/Helpers/UniqueIdentifierGeneratorTest.cs
    • -0
    • +1
    /Ringtoets/Integration/test/Ringtoets.Integration.IO.Test/Ringtoets.Integration.IO.Test.csproj
Thursday 23 Aug 2018
3:14 pm

Dennis Tang <dennis.tang@deltares.nl>

Incorporated comments review 3192:

- Updated XMLDoc

- Improved the testhelper

Paired ~carloslubbers

WTI-1789

Options
    • -1
    • +1
    /Ringtoets/AssemblyTool/src/Ringtoets.AssemblyTool.IO/Model/DataTypes/SerializableFailureMechanismSectionAssemblyResult.cs
    • -3
    • +3
    /Ringtoets/AssemblyTool/test/Ringtoets.AssemblyTool.IO.TestUtil/SerializableAttributeTestHelper.cs
2:45 pm

Carlos Lubbers

Fix typo WTI-1790

Options
    • -2
    • +2
    /Ringtoets/Integration/src/Ringtoets.Integration.IO/Helpers/ExportableFailureMechanismSectionHelper.cs
    • -0
    • +53
    /Ringtoets/Integration/test/Ringtoets.Integration.IO.Test/Assembly/ExportableFailureMechanismAssemblyResultWithProbabilityTest.cs
    • -53
    • +0
    /Ringtoets/Integration/test/Ringtoets.Integration.IO.Test/Assembly/ExportableFailureMechanismAssemblyResultWithProbablityTest.cs
    • -8
    • +8
    /Ringtoets/Integration/test/Ringtoets.Integration.IO.Test/Factories/ExportableAssessmentSectionFactoryTest.cs
    • -1
    • +1
    /Ringtoets/Integration/test/Ringtoets.Integration.IO.Test/Ringtoets.Integration.IO.Test.csproj
2:45 pm

Carlos Lubbers

Fix typo WTI-1790

Options
    • -1
    • +1
    /Ringtoets/Integration/src/Ringtoets.Integration.Forms/Views/AssemblyResultTotalView.cs
    • -1
    • +1
    /Ringtoets/Integration/src/Ringtoets.Integration.Forms/Views/FailureMechanismAssemblyCategoryGroupResultRow.cs
    • -2
    • +2
    /Ringtoets/Integration/src/Ringtoets.Integration.Forms/Views/FailureMechanismAssemblyResultRow.cs
    • -1
    • +1
    /Ringtoets/Integration/src/Ringtoets.Integration.Forms/Views/FailureMechanismAssemblyResultRowBase.cs
    • -2
    • +2
    /Ringtoets/Integration/test/Ringtoets.Integration.Forms.Test/Views/AssemblyResultTotalViewTest.cs
    • -3
    • +3
    /Ringtoets/Integration/test/Ringtoets.Integration.Forms.Test/Views/FailureMechanismAssemblyCategoryGroupResultRowTest.cs
    • -2
    • +2
    /Ringtoets/Integration/test/Ringtoets.Integration.Forms.Test/Views/FailureMechanismAssemblyResultRowBaseTest.cs
    • -3
    • +3
    /Ringtoets/Integration/test/Ringtoets.Integration.Forms.Test/Views/FailureMechanismAssemblyResultRowTest.cs
    • -1
    • +1
    /Ringtoets/Migration/src/Ringtoets.Migration.Core/EmbeddedResources/DatabaseStructure18.1.sql
    • -1
    • +1
    /build/DatabaseStructure.sql
    • binary
    /design/DatabaseDesign.eap
2:45 pm

Carlos Lubbers

Fix typo WTI-1790

Options
    • -1
    • +1
    /Ringtoets/Integration/src/Ringtoets.Integration.Forms/Views/AssemblyResultTotalView.cs
    • -1
    • +1
    /Ringtoets/Integration/src/Ringtoets.Integration.Forms/Views/FailureMechanismAssemblyCategoryGroupResultRow.cs
    • -2
    • +2
    /Ringtoets/Integration/src/Ringtoets.Integration.Forms/Views/FailureMechanismAssemblyResultRow.cs
    • -1
    • +1
    /Ringtoets/Integration/src/Ringtoets.Integration.Forms/Views/FailureMechanismAssemblyResultRowBase.cs
    • -2
    • +2
    /Ringtoets/Integration/test/Ringtoets.Integration.Forms.Test/Views/AssemblyResultTotalViewTest.cs
    • -3
    • +3
    /Ringtoets/Integration/test/Ringtoets.Integration.Forms.Test/Views/FailureMechanismAssemblyCategoryGroupResultRowTest.cs
    • -2
    • +2
    /Ringtoets/Integration/test/Ringtoets.Integration.Forms.Test/Views/FailureMechanismAssemblyResultRowBaseTest.cs
    • -3
    • +3
    /Ringtoets/Integration/test/Ringtoets.Integration.Forms.Test/Views/FailureMechanismAssemblyResultRowTest.cs
    • -1
    • +1
    /Ringtoets/Migration/src/Ringtoets.Migration.Core/EmbeddedResources/DatabaseStructure18.1.sql
    • -1
    • +1
    /build/DatabaseStructure.sql
    • binary
    /design/DatabaseDesign.eap
2:30 pm

Dennis Tang <dennis.tang@deltares.nl>

Incorporated 3190:

- Removed obsolete test fixture tests

- Updated XMLDoc

Paired with ~carloslubbers

WTI-1789

Options
    • -1
    • +1
    /Core/Common/src/Core.Common.Util/Reflection/TypeUtils.cs
    • -2
    • +0
    /Core/Common/test/Core.Common.TestUtil.Test/Core.Common.TestUtil.Test.csproj
    • -74
    • +0
    /Core/Common/test/Core.Common.TestUtil.Test/EnumValuesTestFixtureTest.cs
    • -86
    • +0
    /Core/Common/test/Core.Common.TestUtil.Test/EnumWithDisplayNameTestFixtureTest.cs
2:28 pm

Carlos Lubbers

Cleanup WTI-1789

Options
    • -2
    • +2
    /Ringtoets/AssemblyTool/test/Ringtoets.AssemblyTool.IO.TestUtil/SerializableAttributeTestHelper.cs
2:26 pm

Carlos Lubbers

Add null or empty check to id's WTI-1789

Options
    • -3
    • +4
    /Ringtoets/AssemblyTool/src/Ringtoets.AssemblyTool.IO/Model/SerializableAssembly.cs
    • -4
    • +4
    /Ringtoets/AssemblyTool/src/Ringtoets.AssemblyTool.IO/Model/SerializableAssessmentProcess.cs
    • -4
    • +9
    /Ringtoets/AssemblyTool/src/Ringtoets.AssemblyTool.IO/Model/SerializableAssessmentSection.cs
    • -3
    • +4
    /Ringtoets/AssemblyTool/src/Ringtoets.AssemblyTool.IO/Model/SerializableCombinedFailureMechanismSectionAssembly.cs
    • -3
    • +5
    /Ringtoets/AssemblyTool/src/Ringtoets.AssemblyTool.IO/Model/SerializableFailureMechanism.cs
    • -4
    • +9
    /Ringtoets/AssemblyTool/src/Ringtoets.AssemblyTool.IO/Model/SerializableFailureMechanismSection.cs
    • -3
    • +4
    /Ringtoets/AssemblyTool/src/Ringtoets.AssemblyTool.IO/Model/SerializableFailureMechanismSectionAssembly.cs
    • -5
    • +7
    /Ringtoets/AssemblyTool/src/Ringtoets.AssemblyTool.IO/Model/SerializableFailureMechanismSectionCollection.cs
    • -3
    • +4
    /Ringtoets/AssemblyTool/src/Ringtoets.AssemblyTool.IO/Model/SerializableTotalAssemblyResult.cs
    • -14
    • +17
    /Ringtoets/AssemblyTool/test/Ringtoets.AssemblyTool.IO.Test/Model/SerializableAssemblyTest.cs
    • -4
    • +7
    /Ringtoets/AssemblyTool/test/Ringtoets.AssemblyTool.IO.Test/Model/SerializableAssessmentProcessTest.cs
    • -5
    • +8
    /Ringtoets/AssemblyTool/test/Ringtoets.AssemblyTool.IO.Test/Model/SerializableAssessmentSectionTest.cs
    • -4
    • +7
    /Ringtoets/AssemblyTool/test/Ringtoets.AssemblyTool.IO.Test/Model/SerializableCombinedFailureMechanismSectionAssemblyTest.cs
    • -4
    • +6
    /Ringtoets/AssemblyTool/test/Ringtoets.AssemblyTool.IO.Test/Model/SerializableFailureMechanismSectionAssemblyTest.cs
    • -8
    • +12
    /Ringtoets/AssemblyTool/test/Ringtoets.AssemblyTool.IO.Test/Model/SerializableFailureMechanismSectionCollectionTest.cs
  16. … 5 more files in changeset.
2:05 pm

Robert Tangerman <robert.tangerman@deltares.nl>

Added method to get the geometry of a section based on reference line and begin and end points. WTI-1821

Options
    • -0
    • +11
    /Ringtoets/Integration/src/Ringtoets.Integration.IO/Helpers/ExportableFailureMechanismSectionHelper.cs
    • -0
    • +11
    /Ringtoets/Integration/test/Ringtoets.Integration.IO.Test/Helpers/ExportableFailureMechanismSectionHelperTest.cs
1:50 pm

Dennis Tang <dennis.tang@deltares.nl>

Incorporated comments review 3186:

- Introduced helper method to create a lookup between section results and exportable failure mechanism sections

-- Removed obsolete factory

WTI-1790

Options
    • -65
    • +0
    /Ringtoets/Integration/src/Ringtoets.Integration.IO/Factories/ExportableFailureMechanismSectionFactory.cs
    • -1
    • +0
    /Ringtoets/Integration/src/Ringtoets.Integration.IO/Ringtoets.Integration.IO.csproj
    • -105
    • +0
    /Ringtoets/Integration/test/Ringtoets.Integration.IO.Test/Factories/ExportableFailureMechanismSectionFactoryTest.cs
    • -1
    • +0
    /Ringtoets/Integration/test/Ringtoets.Integration.IO.Test/Ringtoets.Integration.IO.Test.csproj
1:48 pm

Dennis Tang <dennis.tang@deltares.nl>

Incorporated comments review 3186:

- Introduced helper method to create a lookup between section results and exportable failure mechanism sections

-- Applied helper method in the existing factories

WTI-1790

Options
    • -14
    • +4
    /Ringtoets/Integration/src/Ringtoets.Integration.IO/Factories/ExportableClosingStructuresFailureMechanismFactory.cs
    • -14
    • +4
    /Ringtoets/Integration/src/Ringtoets.Integration.IO/Factories/ExportableDuneErosionFailureMechanismFactory.cs
    • -14
    • +4
    /Ringtoets/Integration/src/Ringtoets.Integration.IO/Factories/ExportableGrassCoverErosionInwardsFailureMechanismFactory.cs
    • -14
    • +4
    /Ringtoets/Integration/src/Ringtoets.Integration.IO/Factories/ExportableGrassCoverErosionOutwardsFailureMechanismFactory.cs
    • -14
    • +4
    /Ringtoets/Integration/src/Ringtoets.Integration.IO/Factories/ExportableGrassCoverSlipOffInwardsFailureMechanismFactory.cs
    • -14
    • +4
    /Ringtoets/Integration/src/Ringtoets.Integration.IO/Factories/ExportableGrassCoverSlipOffOutwardsFailureMechanismFactory.cs
    • -14
    • +4
    /Ringtoets/Integration/src/Ringtoets.Integration.IO/Factories/ExportableHeightStructuresFailureMechanismFactory.cs
    • -13
    • +4
    /Ringtoets/Integration/src/Ringtoets.Integration.IO/Factories/ExportableMacroStabilityInwardsFailureMechanismFactory.cs
    • -14
    • +4
    /Ringtoets/Integration/src/Ringtoets.Integration.IO/Factories/ExportableMacroStabilityOutwardsFailureMechanismFactory.cs
    • -14
    • +4
    /Ringtoets/Integration/src/Ringtoets.Integration.IO/Factories/ExportableMicrostabilityFailureMechanismFactory.cs
    • -13
    • +4
    /Ringtoets/Integration/src/Ringtoets.Integration.IO/Factories/ExportablePipingFailureMechanismFactory.cs
    • -14
    • +4
    /Ringtoets/Integration/src/Ringtoets.Integration.IO/Factories/ExportablePipingStructureFailureMechanismFactory.cs
    • -14
    • +4
    /Ringtoets/Integration/src/Ringtoets.Integration.IO/Factories/ExportableStabilityPointStructuresFailureMechanismFactory.cs
    • -14
    • +4
    /Ringtoets/Integration/src/Ringtoets.Integration.IO/Factories/ExportableStabilityStoneCoverFailureMechanismFactory.cs
    • -14
    • +4
    /Ringtoets/Integration/src/Ringtoets.Integration.IO/Factories/ExportableStrengthStabilityLengthwiseConstructionFailureMechanismFactory.cs
  16. … 3 more files in changeset.
1:33 pm

Dennis Tang <dennis.tang@deltares.nl>

Incorporated comments review 3186:

- Introduced helper method to create a lookup between section results and exportable failure mechanism sections

-- Refactored method, instead of looping multiple times over the collection, loop once.

WTI-1790

Options
    • -11
    • +16
    /Ringtoets/Integration/src/Ringtoets.Integration.IO/Helpers/ExportableFailureMechanismSectionHelper.cs
1:28 pm

Dennis Tang <dennis.tang@deltares.nl>

Incorporated comments review 3186:

- Introduced helper method to create a lookup between section results and exportable failure mechanism sections

WTI-1790

Options
    • -0
    • +64
    /Ringtoets/Integration/src/Ringtoets.Integration.IO/Helpers/ExportableFailureMechanismSectionHelper.cs
    • -0
    • +1
    /Ringtoets/Integration/src/Ringtoets.Integration.IO/Ringtoets.Integration.IO.csproj
    • -0
    • +96
    /Ringtoets/Integration/test/Ringtoets.Integration.IO.Test/Helpers/ExportableFailureMechanismSectionHelperTest.cs
    • -0
    • +1
    /Ringtoets/Integration/test/Ringtoets.Integration.IO.Test/Ringtoets.Integration.IO.Test.csproj
1:12 pm

Carlos Lubbers

Add enum value and fix tests WTI-1789

Options
    • -0
    • +4
    /Core/Components/test/Core.Components.Chart.Test/Core.Components.Chart.Test.csproj
    • -0
    • +5
    /Ringtoets/AssemblyTool/src/Ringtoets.AssemblyTool.IO/Model/Enums/AssemblyXmlEnumIdentifiers.cs
    • -1
    • +7
    /Ringtoets/AssemblyTool/src/Ringtoets.AssemblyTool.IO/Model/Enums/SerializableAssessmentSectionCategoryGroup.cs
    • -0
    • +4
    /Ringtoets/AssemblyTool/test/Ringtoets.AssemblyTool.Data.Test/Ringtoets.AssemblyTool.Data.Test.csproj
    • -0
    • +4
    /Ringtoets/AssemblyTool/test/Ringtoets.AssemblyTool.Forms.Test/Ringtoets.AssemblyTool.Forms.Test.csproj
    • -0
    • +1
    /Ringtoets/AssemblyTool/test/Ringtoets.AssemblyTool.IO.Test/Model/Enums/AssemblyXmlEnumIdentifiersTest.cs
    • -0
    • +6
    /Ringtoets/AssemblyTool/test/Ringtoets.AssemblyTool.IO.Test/Model/Enums/SerializableAssessmentSectionCategoryGroupTest.cs
    • -0
    • +4
    /Ringtoets/ClosingStructures/test/Ringtoets.ClosingStructures.Data.Test/Ringtoets.ClosingStructures.Data.Test.csproj
    • -0
    • +4
    /Ringtoets/Common/test/Ringtoets.Common.Data.Test/Ringtoets.Common.Data.Test.csproj
    • -0
    • +4
    /Ringtoets/Common/test/Ringtoets.Common.Primitives.Test/Ringtoets.Common.Primitives.Test.csproj
    • -0
    • +4
    /Ringtoets/GrassCoverErosionInwards/test/Ringtoets.GrassCoverErosionInwards.Data.Test/Ringtoets.GrassCoverErosionInwards.Data.Test.csproj
    • -0
    • +4
    /Ringtoets/Revetment/test/Ringtoets.Revetment.Data.Test/Ringtoets.Revetment.Data.Test.csproj
11:46 am

Carlos Lubbers

Review related changes and cleanup WTI-1789

Options
    • -7
    • +7
    /Ringtoets/AssemblyTool/src/Ringtoets.AssemblyTool.IO/Model/SerializableAssessmentSection.cs
    • -1
    • +1
    /Ringtoets/AssemblyTool/src/Ringtoets.AssemblyTool.IO/Model/SerializableTotalAssemblyResult.cs
    • -0
    • +2
    /Ringtoets/AssemblyTool/src/Ringtoets.AssemblyTool.IO/Ringtoets.AssemblyTool.IO.csproj
    • -0
    • +2
    /Ringtoets/AssemblyTool/test/Ringtoets.AssemblyTool.IO.Test/Model/DataTypes/SerializableAssessmentSectionAssemblyResultTest.cs
    • -0
    • +2
    /Ringtoets/AssemblyTool/test/Ringtoets.AssemblyTool.IO.Test/Model/DataTypes/SerializableFailureMechanismAssemblyResultTest.cs
    • -0
    • +1
    /Ringtoets/AssemblyTool/test/Ringtoets.AssemblyTool.IO.Test/Model/DataTypes/SerializableFailureMechanismSectionAssemblyResultTest.cs
    • -4
    • +2
    /Ringtoets/AssemblyTool/test/Ringtoets.AssemblyTool.IO.Test/Model/DataTypes/SerializableLineTest.cs
    • -4
    • +2
    /Ringtoets/AssemblyTool/test/Ringtoets.AssemblyTool.IO.Test/Model/Gml/SerializableLineStringTest.cs
    • -3
    • +3
    /Ringtoets/AssemblyTool/test/Ringtoets.AssemblyTool.IO.Test/Model/Helpers/GeometrySerializationFormatterTest.cs
    • -3
    • +3
    /Ringtoets/AssemblyTool/test/Ringtoets.AssemblyTool.IO.Test/Model/SerializableAssemblyTest.cs
    • -6
    • +7
    /Ringtoets/AssemblyTool/test/Ringtoets.AssemblyTool.IO.Test/Model/SerializableAssessmentSectionTest.cs
    • -4
    • +5
    /Ringtoets/AssemblyTool/test/Ringtoets.AssemblyTool.IO.Test/SerializableAssemblyWriterTest.cs
    • -10
    • +20
    /Ringtoets/AssemblyTool/test/Ringtoets.AssemblyTool.IO.TestUtil/SerializableAttributeTestHelper.cs