Riskeer

Clone Tools

Stats

Commits this week: 0
Total Committers: 28
Last Commit: 12 Sep 24
Commits this week: 0

Lines of code count not available

Commit Activity

Commits By Day In Week
52 week commits volume
Commits By Day In Week
Commits by day
Commits By Day In Week
Commits by hour
Commits By Hour In Day
Commit calendar
 

Most active committers (90 days)

loading
loading
  • last updated a few seconds ago
All Commits Reviews
Constraints
Constraints: committers
 
Constraints: files
Constraints: dates
Wednesday 21 Feb 2018
3:01 pm

Elmar Kleijn

Improved GetHashCode implementations of all CalculationGroupContext implementations. WTI-1563

Options
    • -1
    • +1
    /Ringtoets/ClosingStructures/src/Ringtoets.ClosingStructures.Forms/PresentationObjects/ClosingStructuresCalculationGroupContext.cs
    • -1
    • +1
    /Ringtoets/GrassCoverErosionInwards/src/Ringtoets.GrassCoverErosionInwards.Forms/PresentationObjects/GrassCoverErosionInwardsCalculationGroupContext.cs
    • -1
    • +1
    /Ringtoets/GrassCoverErosionOutwards/src/Ringtoets.GrassCoverErosionOutwards.Forms/PresentationObjects/GrassCoverErosionOutwardsWaveConditionsCalculationGroupContext.cs
    • -1
    • +1
    /Ringtoets/HeightStructures/src/Ringtoets.HeightStructures.Forms/PresentationObjects/HeightStructuresCalculationGroupContext.cs
    • -0
    • +3
    /Ringtoets/Integration/test/Ringtoets.Integration.Plugin.Test/TreeNodeInfos/HydraulicBoundaryDatabaseContextTreeNodeInfoTest.cs
    • -1
    • +1
    /Ringtoets/StabilityPointStructures/src/Ringtoets.StabilityPointStructures.Forms/PresentationObjects/StabilityPointStructuresCalculationGroupContext.cs
    • -1
    • +1
    /Ringtoets/StabilityStoneCover/src/Ringtoets.StabilityStoneCover.Forms/PresentationObjects/StabilityStoneCoverWaveConditionsCalculationGroupContext.cs
    • -1
    • +1
    /Ringtoets/WaveImpactAsphaltCover/src/Ringtoets.WaveImpactAsphaltCover.Forms/PresentationObjects/WaveImpactAsphaltCoverCalculationGroupContext.cs
2:59 pm

Dennis Tang <dennis.tang@deltares.nl>

Incorporated comments review 2503: - Cleaned up unused references in HeightStructures - Cleaned up files

WTI-1621

Options
    • -5
    • +0
    /Ringtoets/HeightStructures/src/Ringtoets.HeightStructures.IO/Ringtoets.HeightStructures.IO.csproj
    • -5
    • +0
    /Ringtoets/HeightStructures/src/Ringtoets.HeightStructures.Plugin/Ringtoets.HeightStructures.Plugin.csproj
    • -3
    • +2
    /Ringtoets/HeightStructures/test/Ringtoets.HeightStructures.IO.Test/Configurations/HeightStructuresCalculationConfigurationImporterTest.cs
    • -5
    • +1
    /Ringtoets/HeightStructures/test/Ringtoets.HeightStructures.Plugin.Test/Ringtoets.HeightStructures.Plugin.Test.csproj
    • -135
    • +0
    /Ringtoets/HeightStructures/test/Ringtoets.HeightStructures.Plugin.Test/TreeNodeInfos/HeightStructuresProbabilityFailureMechanismResultContextTreeNodeInfoTest.cs
    • -0
    • +135
    /Ringtoets/HeightStructures/test/Ringtoets.HeightStructures.Plugin.Test/TreeNodeInfos/HeightStructuresProbabilityFailureMechanismSectionResultContextTreeNodeInfoTest.cs
2:55 pm

Dennis Tang <dennis.tang@deltares.nl>

Incorporated comments review 2503: - Cleaned up unused references in Ringtoets.Common - Cleaned up files - Added test in FailureMechanismResultView to assert the behaviour of the recursive observer.

WTI-1621

Options
    • -2
    • +2
    /Ringtoets/Common/src/Ringtoets.Common.Forms/Helpers/FailureMechanismSectionResultRowHelper.cs
    • -15
    • +0
    /Ringtoets/Common/src/Ringtoets.Common.Service/Ringtoets.Common.Service.csproj
    • -0
    • +25
    /Ringtoets/Common/test/Ringtoets.Common.Forms.Test/Views/FailureMechanismResultViewTest.cs
    • -12
    • +0
    /Ringtoets/Common/test/Ringtoets.Common.Service.Test/Ringtoets.Common.Service.Test.csproj
    • -1
    • +1
    /Ringtoets/Common/test/Ringtoets.Common.Util.Test/StructuresHelperTest.cs
2:47 pm

Dennis Tang <dennis.tang@deltares.nl>

Incorporated comments review 2503: - Cleaned up unused references in ClosingStructures - Rewrote treenodeinfo test to be in line with other comparable tests.

WTI-1621

Options
    • -2
    • +7
    /Ringtoets/ClosingStructures/src/Ringtoets.ClosingStructures.Forms/PropertyClasses/ClosingStructuresInputContextProperties.cs
    • -1
    • +0
    /Ringtoets/ClosingStructures/src/Ringtoets.ClosingStructures.IO/Configurations/ClosingStructuresCalculationConfigurationImporter.cs
    • -5
    • +0
    /Ringtoets/ClosingStructures/src/Ringtoets.ClosingStructures.IO/Ringtoets.ClosingStructures.IO.csproj
    • -3
    • +0
    /Ringtoets/ClosingStructures/src/Ringtoets.ClosingStructures.Plugin/FileImporters/ClosingStructureReplaceDataStrategy.cs
    • -2
    • +0
    /Ringtoets/ClosingStructures/src/Ringtoets.ClosingStructures.Plugin/FileImporters/ClosingStructureUpdateDataStrategy.cs
    • -5
    • +0
    /Ringtoets/ClosingStructures/src/Ringtoets.ClosingStructures.Plugin/Ringtoets.ClosingStructures.Plugin.csproj
    • -1
    • +0
    /Ringtoets/ClosingStructures/test/Ringtoets.ClosingStructures.Plugin.Test/FileImporters/ClosingStructureReplaceDataStrategyTest.cs
    • -4
    • +0
    /Ringtoets/ClosingStructures/test/Ringtoets.ClosingStructures.Plugin.Test/Ringtoets.ClosingStructures.Plugin.Test.csproj
    • -58
    • +46
    /Ringtoets/ClosingStructures/test/Ringtoets.ClosingStructures.Plugin.Test/TreeNodeInfos/ClosingStructuresProbabilityFailureMechanismSectionResultContextTreeNodeInfoTest.cs
2:38 pm

Dennis Tang <dennis.tang@deltares.nl>

Incorporated comments review 2503: - Cleaned up unused references in storage

WTI-1621

Options
    • -1
    • +0
    /Application/Ringtoets/src/Application.Ringtoets.Storage/Create/ClosingStructures/ClosingStructuresFailureMechanismCreateExtensions.cs
    • -1
    • +0
    /Application/Ringtoets/src/Application.Ringtoets.Storage/Read/FailureMechanismEntityReadExtensions.cs
    • -1
    • +0
    /Application/Ringtoets/test/Application.Ringtoets.Storage.Test/IntegrationTests/StorageSqLiteIntegrationTest.cs
2:18 pm

Elmar Kleijn

Added missing tests. WTI-1563

Options
    • -3
    • +6
    /Ringtoets/Integration/src/Ringtoets.Integration.Plugin/RingtoetsPlugin.cs
    • -5
    • +5
    /Ringtoets/Integration/test/Ringtoets.Integration.Plugin.Test/PropertyInfos/DesignWaterLevelLocationsContextPropertyInfoTest.cs
    • -5
    • +5
    /Ringtoets/Integration/test/Ringtoets.Integration.Plugin.Test/PropertyInfos/WaveHeightLocationsContextPropertyInfoTest.cs
    • -0
    • +4
    /Ringtoets/Integration/test/Ringtoets.Integration.Plugin.Test/Ringtoets.Integration.Plugin.Test.csproj
    • -3
    • +41
    /Ringtoets/Integration/test/Ringtoets.Integration.Plugin.Test/ViewInfos/DesignWaterLevelLocationsViewInfoTest.cs
    • -3
    • +41
    /Ringtoets/Integration/test/Ringtoets.Integration.Plugin.Test/ViewInfos/WaveHeightLocationsViewInfoTest.cs
2:08 pm

Carlos Lubbers <carlos.lubbers@deltares.nl>

Review related changes. Use data model instead of cell value when checking for read-onlyness WTI-1617

Options
    • -2
    • +2
    /Ringtoets/ClosingStructures/src/Ringtoets.ClosingStructures.Forms/Views/ClosingStructuresFailureMechanismResultView.cs
    • -1
    • +1
    /Ringtoets/Common/src/Ringtoets.Common.Forms/Helpers/FailureMechanismResultViewHelper.cs
    • -1
    • +1
    /Ringtoets/Common/src/Ringtoets.Common.Forms/Views/FailureMechanismResultView.cs
    • -2
    • +3
    /Ringtoets/Common/test/Ringtoets.Common.Data.TestUtil.Test/FailureMechanismSectionTestFactoryTest.cs
    • -1
    • +1
    /Ringtoets/Common/test/Ringtoets.Common.Data.TestUtil/FailureMechanismSectionTestFactory.cs
    • -2
    • +2
    /Ringtoets/DuneErosion/src/Ringtoets.DuneErosion.Forms/Views/DuneErosionFailureMechanismResultView.cs
    • -2
    • +2
    /Ringtoets/GrassCoverErosionInwards/src/Ringtoets.GrassCoverErosionInwards.Forms/Views/GrassCoverErosionInwardsFailureMechanismResultView.cs
    • -2
    • +2
    /Ringtoets/GrassCoverErosionOutwards/src/Ringtoets.GrassCoverErosionOutwards.Forms/Views/GrassCoverErosionOutwardsFailureMechanismResultView.cs
    • -2
    • +2
    /Ringtoets/HeightStructures/src/Ringtoets.HeightStructures.Forms/Views/HeightStructuresFailureMechanismResultView.cs
    • -2
    • +2
    /Ringtoets/Integration/src/Ringtoets.Integration.Forms/Views/SectionResultViews/GrassCoverSlipOffInwardsResultView.cs
    • -2
    • +2
    /Ringtoets/Integration/src/Ringtoets.Integration.Forms/Views/SectionResultViews/GrassCoverSlipOffOutwardsResultView.cs
    • -2
    • +2
    /Ringtoets/Integration/src/Ringtoets.Integration.Forms/Views/SectionResultViews/MacroStabilityOutwardsResultView.cs
    • -2
    • +2
    /Ringtoets/Integration/src/Ringtoets.Integration.Forms/Views/SectionResultViews/MicrostabilityResultView.cs
    • -2
    • +2
    /Ringtoets/Integration/src/Ringtoets.Integration.Forms/Views/SectionResultViews/PipingStructureResultView.cs
    • -2
    • +2
    /Ringtoets/Integration/src/Ringtoets.Integration.Forms/Views/SectionResultViews/StrengthStabilityLengthwiseConstructionResultView.cs
  16. … 7 more files in changeset.
1:44 pm

Elmar Kleijn

Added missing tests. WTI-1563

Options
    • -0
    • +87
    /Ringtoets/Integration/test/Ringtoets.Integration.Plugin.Test/PropertyInfos/DesignWaterLevelLocationContextPropertyInfoTest.cs
    • -6
    • +33
    /Ringtoets/Integration/test/Ringtoets.Integration.Plugin.Test/PropertyInfos/DesignWaterLevelLocationsContextPropertyInfoTest.cs
    • -0
    • +87
    /Ringtoets/Integration/test/Ringtoets.Integration.Plugin.Test/PropertyInfos/WaveHeightLocationContextPropertyInfoTest.cs
    • -6
    • +33
    /Ringtoets/Integration/test/Ringtoets.Integration.Plugin.Test/PropertyInfos/WaveHeightLocationsContextPropertyInfoTest.cs
    • -0
    • +2
    /Ringtoets/Integration/test/Ringtoets.Integration.Plugin.Test/Ringtoets.Integration.Plugin.Test.csproj
12:58 pm

Carlos Lubbers <carlos.lubbers@deltares.nl>

Rename resources containing "(afgerond)" to include _Rounded_ WTI-1531

Options
    • -6
    • +6
    /Ringtoets/Common/src/Ringtoets.Common.Forms/Properties/Resources.Designer.cs
    • -3
    • +3
    /Ringtoets/Common/src/Ringtoets.Common.Forms/Properties/Resources.resx
    • -1
    • +1
    /Ringtoets/Common/src/Ringtoets.Common.Forms/PropertyClasses/FailureMechanismSectionProbabilityAssessmentProperties.cs
    • -1
    • +1
    /Ringtoets/Common/src/Ringtoets.Common.Forms/PropertyClasses/FailureMechanismSectionProperties.cs
    • -1
    • +1
    /Ringtoets/Integration/src/Ringtoets.Integration.Forms/PropertyClasses/ReferenceLineProperties.cs
    • -1
    • +1
    /Ringtoets/Integration/src/Ringtoets.Integration.Forms/PropertyClasses/StandAlone/MacroStabilityOutwardsFailureMechanismProperties.cs
    • -1
    • +1
    /Ringtoets/MacroStabilityInwards/src/Ringtoets.MacroStabilityInwards.Forms/PropertyClasses/MacroStabilityInwardsFailureMechanismProperties.cs
    • -1
    • +1
    /Ringtoets/Piping/src/Ringtoets.Piping.Forms/PropertyClasses/PipingFailureMechanismProperties.cs
    • -1
    • +1
    /Ringtoets/WaveImpactAsphaltCover/src/Ringtoets.WaveImpactAsphaltCover.Forms/PropertyClasses/WaveImpactAsphaltCoverFailureMechanismProperties.cs
11:34 am

Elmar Kleijn

Applied some final cleanups when it comes to DocumentViewController. WTI-1563

Options
    • -3
    • +9
    /Core/Common/src/Core.Common.Gui/Forms/ViewHost/DocumentViewController.cs
11:20 am

Elmar Kleijn

Applied some final cleanups when it comes to DocumentViewControllerTest. WTI-1563

Options
    • -2
    • +2
    /Core/Common/test/Core.Common.Gui.Test/Forms/ViewHost/DocumentViewControllerTest.cs
11:11 am

Elmar Kleijn

Adapted GuiCore. WTI-1563

Options
    • -1
    • +1
    /Core/Common/src/Core.Common.Gui/Forms/ViewHost/DocumentViewController.cs
    • -1
    • +2
    /Core/Common/src/Core.Common.Gui/Forms/ViewHost/IDocumentViewController.cs
    • -1
    • +5
    /Core/Common/src/Core.Common.Gui/GuiCore.cs
    • -0
    • +32
    /Core/Common/test/Core.Common.Gui.Test/GuiCoreTest.cs
11:03 am

Elmar Kleijn

Adapted DocumentViewControllerTest. WTI-1563

Options
    • -217
    • +283
    /Core/Common/test/Core.Common.Gui.Test/Forms/ViewHost/DocumentViewControllerTest.cs
9:35 am

Elmar Kleijn

Further simplified DocumentViewController. WTI-1563

Options
    • -66
    • +74
    /Core/Common/src/Core.Common.Gui/Forms/ViewHost/DocumentViewController.cs
    • -9
    • +0
    /Core/Common/src/Core.Common.Gui/Forms/ViewHost/IDocumentViewController.cs
    • -1
    • +1
    /Core/Common/test/Core.Common.Gui.Test/GuiCoreTest.cs
9:00 am

Elmar Kleijn

Simplified DocumentViewController. WTI-1563

Options
    • -26
    • +4
    /Core/Common/src/Core.Common.Gui/Forms/ViewHost/DocumentViewController.cs
Tuesday 20 Feb 2018
3:52 pm

Dennis Tang <dennis.tang@deltares.nl>

Final cleanup: - Removed every notion of AssessmentLayerOne from Structures, except for .Data - Removed obsolete tests in: -- Common.Forms: AssessmentLayerOne is implemented specifically --- Common.Data: autoproperty tests should not be implemented

WTI-1621

Options
    • -4
    • +4
    /Ringtoets/ClosingStructures/test/Ringtoets.ClosingStructures.Forms.Test/Views/ClosingStructuresFailureMechanismResultViewTest.cs
    • -17
    • +0
    /Ringtoets/Common/test/Ringtoets.Common.Data.Test/FailureMechanism/FailureMechanismSectionResultTest.cs
    • -55
    • +70
    /Ringtoets/Common/test/Ringtoets.Common.Forms.Test/Helpers/FailureMechanismSectionResultRowHelperTest.cs
    • -28
    • +6
    /Ringtoets/Common/test/Ringtoets.Common.Forms.Test/Views/FailureMechanismResultViewTest.cs
    • -5
    • +5
    /Ringtoets/HeightStructures/test/Ringtoets.HeightStructures.Forms.Test/Views/HeightStructuresFailureMechanismResultViewTest.cs
    • -10
    • +10
    /Ringtoets/StabilityPointStructures/test/Ringtoets.StabilityPointStructures.Forms.Test/Views/StabilityPointStructuresFailureMechanismResultViewTest.cs
3:07 pm

Carlos Lubbers <carlos.lubbers@deltares.nl>

Review related changes, rename resources and cleanup WTI-1617

Options
    • -3
    • +3
    /Ringtoets/ClosingStructures/src/Ringtoets.ClosingStructures.Forms/Views/ClosingStructuresFailureMechanismResultView.cs
    • -2
    • +2
    /Ringtoets/Common/src/Ringtoets.Common.Forms/Helpers/FailureMechanismResultViewHelper.cs
    • -8
    • +8
    /Ringtoets/Common/src/Ringtoets.Common.Forms/Properties/Resources.Designer.cs
    • -4
    • +4
    /Ringtoets/Common/src/Ringtoets.Common.Forms/Properties/Resources.resx
    • -1
    • +1
    /Ringtoets/Common/src/Ringtoets.Common.Forms/ScenarioSelectionControl.cs
    • -1
    • +1
    /Ringtoets/Common/src/Ringtoets.Common.Forms/Views/FailureMechanismResultView.cs
    • -3
    • +3
    /Ringtoets/DuneErosion/src/Ringtoets.DuneErosion.Forms/Views/DuneErosionFailureMechanismResultView.cs
    • -3
    • +3
    /Ringtoets/GrassCoverErosionInwards/src/Ringtoets.GrassCoverErosionInwards.Forms/Views/GrassCoverErosionInwardsFailureMechanismResultView.cs
    • -3
    • +3
    /Ringtoets/GrassCoverErosionOutwards/src/Ringtoets.GrassCoverErosionOutwards.Forms/Views/GrassCoverErosionOutwardsFailureMechanismResultView.cs
    • -3
    • +3
    /Ringtoets/HeightStructures/src/Ringtoets.HeightStructures.Forms/Views/HeightStructuresFailureMechanismResultView.cs
    • -3
    • +3
    /Ringtoets/Integration/src/Ringtoets.Integration.Forms/Views/SectionResultViews/GrassCoverSlipOffInwardsResultView.cs
    • -3
    • +3
    /Ringtoets/Integration/src/Ringtoets.Integration.Forms/Views/SectionResultViews/GrassCoverSlipOffOutwardsResultView.cs
    • -3
    • +3
    /Ringtoets/Integration/src/Ringtoets.Integration.Forms/Views/SectionResultViews/MacroStabilityOutwardsResultView.cs
    • -3
    • +3
    /Ringtoets/Integration/src/Ringtoets.Integration.Forms/Views/SectionResultViews/MicrostabilityResultView.cs
    • -3
    • +3
    /Ringtoets/Integration/src/Ringtoets.Integration.Forms/Views/SectionResultViews/PipingStructureResultView.cs
  16. … 8 more files in changeset.
2:53 pm

Carlos Lubbers <carlos.lubbers@deltares.nl>

Review related changes, renamed HasPassedSimpleAssessment and used test failuremechanism instead of simple failure mechanism WTI-1617

Options
    • -1
    • +1
    /Ringtoets/ClosingStructures/src/Ringtoets.ClosingStructures.Forms/Views/ClosingStructuresFailureMechanismResultView.cs
    • -4
    • +4
    /Ringtoets/Common/src/Ringtoets.Common.Forms/Helpers/FailureMechanismResultViewHelper.cs
    • -12
    • +12
    /Ringtoets/Common/test/Ringtoets.Common.Forms.Test/Helpers/FailureMechanismResultViewHelperTest.cs
    • -29
    • +16
    /Ringtoets/Common/test/Ringtoets.Common.IO.Test/FileImporters/FailureMechanismSectionsImporterTest.cs
    • -1
    • +1
    /Ringtoets/DuneErosion/src/Ringtoets.DuneErosion.Forms/Views/DuneErosionFailureMechanismResultView.cs
    • -1
    • +1
    /Ringtoets/GrassCoverErosionInwards/src/Ringtoets.GrassCoverErosionInwards.Forms/Views/GrassCoverErosionInwardsFailureMechanismResultView.cs
    • -1
    • +1
    /Ringtoets/GrassCoverErosionOutwards/src/Ringtoets.GrassCoverErosionOutwards.Forms/Views/GrassCoverErosionOutwardsFailureMechanismResultView.cs
    • -9
    • +2
    /Ringtoets/HeightStructures/src/Ringtoets.HeightStructures.Forms/Views/HeightStructuresFailureMechanismResultView.cs
    • -1
    • +1
    /Ringtoets/Integration/src/Ringtoets.Integration.Forms/Views/SectionResultViews/GrassCoverSlipOffInwardsResultView.cs
    • -1
    • +1
    /Ringtoets/Integration/src/Ringtoets.Integration.Forms/Views/SectionResultViews/GrassCoverSlipOffOutwardsResultView.cs
    • -1
    • +1
    /Ringtoets/Integration/src/Ringtoets.Integration.Forms/Views/SectionResultViews/MacroStabilityOutwardsResultView.cs
    • -1
    • +1
    /Ringtoets/Integration/src/Ringtoets.Integration.Forms/Views/SectionResultViews/MicrostabilityResultView.cs
    • -1
    • +1
    /Ringtoets/Integration/src/Ringtoets.Integration.Forms/Views/SectionResultViews/PipingStructureResultView.cs
    • -1
    • +1
    /Ringtoets/Integration/src/Ringtoets.Integration.Forms/Views/SectionResultViews/StrengthStabilityLengthwiseConstructionResultView.cs
    • -1
    • +1
    /Ringtoets/Integration/src/Ringtoets.Integration.Forms/Views/SectionResultViews/TechnicalInnovationResultView.cs
  16. … 6 more files in changeset.
2:45 pm

Carlos Lubbers <carlos.lubbers@deltares.nl>

Review related changes, update xmldoc and fix tests WTI-1617

Options
    • -1
    • +1
    /Ringtoets/ClosingStructures/src/Ringtoets.ClosingStructures.Data/ClosingStructuresFailureMechanismSectionResult.cs
    • -6
    • +3
    /Ringtoets/ClosingStructures/test/Ringtoets.ClosingStructures.Forms.Test/Views/ClosingStructuresFailureMechanismResultViewTest.cs
    • -1
    • +1
    /Ringtoets/DuneErosion/src/Ringtoets.DuneErosion.Data/DuneErosionFailureMechanismSectionResult.cs
    • -1
    • +1
    /Ringtoets/GrassCoverErosionInwards/src/Ringtoets.GrassCoverErosionInwards.Data/GrassCoverErosionInwardsFailureMechanismSectionResult.cs
    • -1
    • +1
    /Ringtoets/GrassCoverErosionOutwards/src/Ringtoets.GrassCoverErosionOutwards.Data/GrassCoverErosionOutwardsFailureMechanismSectionResult.cs
    • -1
    • +1
    /Ringtoets/HeightStructures/src/Ringtoets.HeightStructures.Data/HeightStructuresFailureMechanismSectionResult.cs
    • -31
    • +10
    /Ringtoets/HeightStructures/test/Ringtoets.HeightStructures.Forms.Test/Views/HeightStructuresFailureMechanismResultViewTest.cs
    • -1
    • +1
    /Ringtoets/Integration/src/Ringtoets.Integration.Data/StandAlone/SectionResults/GrassCoverSlipOffInwardsFailureMechanismSectionResult.cs
    • -1
    • +1
    /Ringtoets/Integration/src/Ringtoets.Integration.Data/StandAlone/SectionResults/GrassCoverSlipOffOutwardsFailureMechanismSectionResult.cs
    • -1
    • +1
    /Ringtoets/Integration/src/Ringtoets.Integration.Data/StandAlone/SectionResults/MacroStabilityOutwardsFailureMechanismSectionResult.cs
    • -1
    • +1
    /Ringtoets/Integration/src/Ringtoets.Integration.Data/StandAlone/SectionResults/MicrostabilityFailureMechanismSectionResult.cs
    • -1
    • +1
    /Ringtoets/Integration/src/Ringtoets.Integration.Data/StandAlone/SectionResults/PipingStructureFailureMechanismSectionResult.cs
    • -1
    • +1
    /Ringtoets/Integration/src/Ringtoets.Integration.Data/StandAlone/SectionResults/StrengthStabilityLengthwiseConstructionFailureMechanismSectionResult.cs
    • -1
    • +1
    /Ringtoets/Integration/src/Ringtoets.Integration.Data/StandAlone/SectionResults/TechnicalInnovationFailureMechanismSectionResult.cs
    • -1
    • +1
    /Ringtoets/Integration/src/Ringtoets.Integration.Data/StandAlone/SectionResults/WaterPressureAsphaltCoverFailureMechanismSectionResult.cs
  16. … 5 more files in changeset.
2:29 pm

Carlos Lubbers <carlos.lubbers@deltares.nl>

Update methods to create test views for gekb and structures WTI-1617

Options
    • -23
    • +12
    /Ringtoets/ClosingStructures/test/Ringtoets.ClosingStructures.Forms.Test/Views/ClosingStructuresFailureMechanismResultViewTest.cs
    • -28
    • +17
    /Ringtoets/GrassCoverErosionInwards/test/Ringtoets.GrassCoverErosionInwards.Forms.Test/Views/GrassCoverErosionInwardsFailureMechanismResultViewTest.cs
    • -22
    • +17
    /Ringtoets/HeightStructures/test/Ringtoets.HeightStructures.Forms.Test/Views/HeightStructuresFailureMechanismResultViewTest.cs
    • -22
    • +16
    /Ringtoets/StabilityPointStructures/test/Ringtoets.StabilityPointStructures.Forms.Test/Views/StabilityPointStructuresFailureMechanismResultViewTest.cs
2:13 pm

Dennis Tang <dennis.tang@deltares.nl>

Fixed compilation errors: - Mergetool did not work for every file - Fixed failing tests

WTI-1621

Options
    • -18
    • +17
    /Ringtoets/ClosingStructures/test/Ringtoets.ClosingStructures.Forms.Test/Views/ClosingStructuresFailureMechanismResultViewTest.cs
    • -6
    • +1
    /Ringtoets/ClosingStructures/test/Ringtoets.ClosingStructures.Forms.Test/Views/ClosingStructuresFailureMechanismSectionResultRowTest.cs
    • -22
    • +23
    /Ringtoets/Common/test/Ringtoets.Common.Forms.Test/Helpers/FailureMechanismSectionResultRowHelperTest.cs
    • -26
    • +26
    /Ringtoets/HeightStructures/test/Ringtoets.HeightStructures.Forms.Test/Views/HeightStructuresFailureMechanismResultViewTest.cs
    • -6
    • +1
    /Ringtoets/HeightStructures/test/Ringtoets.HeightStructures.Forms.Test/Views/HeightStructuresFailureMechanismSectionResultRowTest.cs
    • -1
    • +1
    /Ringtoets/StabilityPointStructures/test/Ringtoets.StabilityPointStructures.Forms.Test/Views/StabilityPointStructuresFailureMechanismSectionResultRowTest.cs
2:02 pm

Carlos Lubbers <carlos.lubbers@deltares.nl>

Move inheritdoc tag and use helper method for dune erosion result view WTI-1617

Options
    • -1
    • +1
    /Ringtoets/ClosingStructures/src/Ringtoets.ClosingStructures.Forms/Views/ClosingStructuresFailureMechanismResultView.cs
    • -8
    • +5
    /Ringtoets/DuneErosion/src/Ringtoets.DuneErosion.Forms/Views/DuneErosionFailureMechanismResultView.cs
    • -1
    • +1
    /Ringtoets/GrassCoverErosionInwards/src/Ringtoets.GrassCoverErosionInwards.Forms/Views/GrassCoverErosionInwardsFailureMechanismResultView.cs
    • -1
    • +1
    /Ringtoets/GrassCoverErosionOutwards/src/Ringtoets.GrassCoverErosionOutwards.Forms/Views/GrassCoverErosionOutwardsFailureMechanismResultView.cs
    • -1
    • +1
    /Ringtoets/HeightStructures/src/Ringtoets.HeightStructures.Forms/Views/HeightStructuresFailureMechanismResultView.cs
    • -1
    • +1
    /Ringtoets/Integration/src/Ringtoets.Integration.Forms/Views/SectionResultViews/GrassCoverSlipOffInwardsResultView.cs
    • -1
    • +1
    /Ringtoets/Integration/src/Ringtoets.Integration.Forms/Views/SectionResultViews/GrassCoverSlipOffOutwardsResultView.cs
    • -1
    • +1
    /Ringtoets/Integration/src/Ringtoets.Integration.Forms/Views/SectionResultViews/MacroStabilityOutwardsResultView.cs
    • -1
    • +1
    /Ringtoets/Integration/src/Ringtoets.Integration.Forms/Views/SectionResultViews/MicrostabilityResultView.cs
    • -1
    • +1
    /Ringtoets/Integration/src/Ringtoets.Integration.Forms/Views/SectionResultViews/PipingStructureResultView.cs
    • -1
    • +1
    /Ringtoets/Integration/src/Ringtoets.Integration.Forms/Views/SectionResultViews/StrengthStabilityLengthwiseConstructionResultView.cs
    • -1
    • +1
    /Ringtoets/Integration/src/Ringtoets.Integration.Forms/Views/SectionResultViews/TechnicalInnovationResultView.cs
    • -1
    • +1
    /Ringtoets/Integration/src/Ringtoets.Integration.Forms/Views/SectionResultViews/WaterPressureAsphaltCoverResultView.cs
    • -1
    • +1
    /Ringtoets/MacroStabilityInwards/src/Ringtoets.MacroStabilityInwards.Forms/Views/MacroStabilityInwardsFailureMechanismResultView.cs
    • -1
    • +1
    /Ringtoets/Piping/src/Ringtoets.Piping.Forms/Views/PipingFailureMechanismResultView.cs
  16. … 3 more files in changeset.
1:15 pm

Carlos Lubbers <carlos.lubbers@deltares.nl>

Review related improvements. Introduce new and use test factory, update test names WTI-1617

Options
    • -42
    • +21
    /Ringtoets/ClosingStructures/test/Ringtoets.ClosingStructures.Forms.Test/Views/ClosingStructuresFailureMechanismResultViewTest.cs
    • -0
    • +47
    /Ringtoets/Common/test/Ringtoets.Common.Data.TestUtil.Test/FailureMechanismSectionResultTestFactoryTest.cs
    • -2
    • +19
    /Ringtoets/Common/test/Ringtoets.Common.Data.TestUtil.Test/FailureMechanismSectionTestFactoryTest.cs
    • -0
    • +1
    /Ringtoets/Common/test/Ringtoets.Common.Data.TestUtil.Test/Ringtoets.Common.Data.TestUtil.Test.csproj
    • -0
    • +41
    /Ringtoets/Common/test/Ringtoets.Common.Data.TestUtil/FailureMechanismSectionResultTestFactory.cs
    • -4
    • +10
    /Ringtoets/Common/test/Ringtoets.Common.Data.TestUtil/FailureMechanismSectionTestFactory.cs
    • -0
    • +1
    /Ringtoets/Common/test/Ringtoets.Common.Data.TestUtil/Ringtoets.Common.Data.TestUtil.csproj
    • -14
    • +5
    /Ringtoets/Common/test/Ringtoets.Common.Forms.Test/Views/FailureMechanismResultViewTest.cs
    • -7
    • +3
    /Ringtoets/Common/test/Ringtoets.Common.Forms.Test/Views/FailureMechanismSectionResultRowTest.cs
    • -13
    • +7
    /Ringtoets/Common/test/Ringtoets.Common.Util.Test/SectionResultWithCalculationAssignmentTest.cs
    • -17
    • +7
    /Ringtoets/DuneErosion/test/Ringtoets.DuneErosion.Forms.Test/Views/DuneErosionFailureMechanismResultViewTest.cs
    • -18
    • +12
    /Ringtoets/GrassCoverErosionInwards/test/Ringtoets.GrassCoverErosionInwards.Forms.Test/Views/GrassCoverErosionInwardsFailureMechanismResultViewTest.cs
    • -26
    • +11
    /Ringtoets/GrassCoverErosionOutwards/test/Ringtoets.GrassCoverErosionOutwards.Forms.Test/Views/GrassCoverErosionOutwardsFailureMechanismResultViewTest.cs
    • -15
    • +6
    /Ringtoets/HeightStructures/test/Ringtoets.HeightStructures.Forms.Test/Views/HeightStructuresFailureMechanismResultViewTest.cs
    • -26
    • +11
    /Ringtoets/Integration/test/Ringtoets.Integration.Forms.Test/Views/SectionResultViews/GrassCoverSlipOffInwardsResultViewTest.cs
  16. … 11 more files in changeset.
10:04 am

Dennis Tang <dennis.tang@deltares.nl>

Implemented SimpleAssessmentResult type for Closing and Height structures: - Adjusted row object - Adjusted view logic to respond on changes of type SimpleAssessmentResultValidityOnly

WTI-1621

Options
    • -15
    • +10
    /Ringtoets/ClosingStructures/src/Ringtoets.ClosingStructures.Forms/Views/ClosingStructuresFailureMechanismResultView.cs
    • -5
    • +5
    /Ringtoets/ClosingStructures/src/Ringtoets.ClosingStructures.Forms/Views/ClosingStructuresFailureMechanismSectionResultRow.cs
    • -0
    • +4
    /Ringtoets/ClosingStructures/test/Ringtoets.ClosingStructures.Forms.Test/Ringtoets.ClosingStructures.Forms.Test.csproj
    • -57
    • +146
    /Ringtoets/ClosingStructures/test/Ringtoets.ClosingStructures.Forms.Test/Views/ClosingStructuresFailureMechanismResultViewTest.cs
    • -6
    • +10
    /Ringtoets/ClosingStructures/test/Ringtoets.ClosingStructures.Forms.Test/Views/ClosingStructuresFailureMechanismSectionResultRowTest.cs
    • -6
    • +6
    /Ringtoets/Common/src/Ringtoets.Common.Forms/Helpers/FailureMechanismSectionResultRowHelper.cs
    • -36
    • +90
    /Ringtoets/Common/test/Ringtoets.Common.Forms.Test/Helpers/FailureMechanismSectionResultRowHelperTest.cs
    • -7
    • +9
    /Ringtoets/HeightStructures/src/Ringtoets.HeightStructures.Forms/Views/HeightStructuresFailureMechanismResultView.cs
    • -5
    • +5
    /Ringtoets/HeightStructures/src/Ringtoets.HeightStructures.Forms/Views/HeightStructuresFailureMechanismSectionResultRow.cs
    • -0
    • +4
    /Ringtoets/HeightStructures/test/Ringtoets.HeightStructures.Forms.Test/Ringtoets.HeightStructures.Forms.Test.csproj
    • -39
    • +251
    /Ringtoets/HeightStructures/test/Ringtoets.HeightStructures.Forms.Test/Views/HeightStructuresFailureMechanismResultViewTest.cs
    • -6
    • +10
    /Ringtoets/HeightStructures/test/Ringtoets.HeightStructures.Forms.Test/Views/HeightStructuresFailureMechanismSectionResultRowTest.cs
8:50 am

Carlos Lubbers <carlos.lubbers@deltares.nl>

Review related improvements, stub interface, change test names and remove duplicate test file WTI-1617

Options
    • -28
    • +8
    /Ringtoets/Common/test/Ringtoets.Common.Forms.Test/PresentationObjects/FailureMechanismSectionResultContextTest.cs
    • -6
    • +12
    /Ringtoets/Common/test/Ringtoets.Common.Forms.Test/PresentationObjects/ProbabilityFailureMechanismSectionResultContextTest.cs
    • -1
    • +1
    /Ringtoets/DuneErosion/test/Ringtoets.DuneErosion.Plugin.Test/ViewInfos/DuneErosionFailureMechanismResultViewInfoTest.cs
    • -1
    • +1
    /Ringtoets/GrassCoverErosionInwards/test/Ringtoets.GrassCoverErosionInwards.Plugin.Test/ViewInfos/GrassCoverErosionInwardsFailureMechanismResultViewInfoTest.cs
    • -38
    • +3
    /Ringtoets/GrassCoverErosionOutwards/test/Ringtoets.GrassCoverErosionOutwards.Plugin.Test/ViewInfos/GrassCoverErosionOutwardsFailureMechanismResultViewInfoTest.cs
    • -1
    • +1
    /Ringtoets/HeightStructures/test/Ringtoets.HeightStructures.Plugin.Test/ViewInfos/HeightStructuresFailureMechanismResultViewInfoTest.cs
    • -1
    • +1
    /Ringtoets/Integration/test/Ringtoets.Integration.Plugin.Test/ViewInfos/GrassCoverSlipOffInwardsResultViewInfoTest.cs
    • -1
    • +1
    /Ringtoets/Integration/test/Ringtoets.Integration.Plugin.Test/ViewInfos/GrassCoverSlipOffOutwardsResultViewInfoTest.cs
    • -1
    • +1
    /Ringtoets/Integration/test/Ringtoets.Integration.Plugin.Test/ViewInfos/MacroStabilityOutwardsResultViewInfoTest.cs
    • -1
    • +1
    /Ringtoets/Integration/test/Ringtoets.Integration.Plugin.Test/ViewInfos/MicrostabilityResultViewInfoTest.cs
    • -1
    • +1
    /Ringtoets/Integration/test/Ringtoets.Integration.Plugin.Test/ViewInfos/PipingStructureResultViewInfoTest.cs
    • -1
    • +1
    /Ringtoets/Integration/test/Ringtoets.Integration.Plugin.Test/ViewInfos/StrengthStabilityLengthwiseConstructionResultViewInfoTest.cs
    • -1
    • +1
    /Ringtoets/Integration/test/Ringtoets.Integration.Plugin.Test/ViewInfos/TechnicalInnovationResultViewInfoTest.cs
    • -1
    • +1
    /Ringtoets/Integration/test/Ringtoets.Integration.Plugin.Test/ViewInfos/WaterPressureAsphaltCoverResultViewInfoTest.cs
    • -71
    • +0
    /Ringtoets/MacroStabilityInwards/test/Ringtoets.MacroStabilityInwards.Forms.Test/PresentationObjects/ProbabilityFailureMechanismSectionResultContextTest.cs
  16. … 3 more files in changeset.
Monday 19 Feb 2018
4:26 pm

Dennis Tang <dennis.tang@deltares.nl>

Implemented SimpleAssessmentResultValidityOnly type for stability point structures: - Cleaned up affectec files in .Forms

WTI-1621

Options
    • -2
    • +2
    /Ringtoets/StabilityPointStructures/src/Ringtoets.StabilityPointStructures.Forms/Views/StabilityPointStructuresFailureMechanismResultView.cs
    • -3
    • +3
    /Ringtoets/StabilityPointStructures/test/Ringtoets.StabilityPointStructures.Forms.Test/Views/StabilityPointStructuresFailureMechanismResultViewTest.cs
4:01 pm

Carlos Lubbers <carlos.lubbers@deltares.nl>

Implement review comments from review 2480 WTI-1617

Options
    • -33
    • +29
    /Ringtoets/GrassCoverErosionOutwards/test/Ringtoets.GrassCoverErosionOutwards.Forms.Test/Views/GrassCoverErosionOutwardsFailureMechanismResultViewTest.cs
    • -1
    • +0
    /Ringtoets/HeightStructures/test/Ringtoets.HeightStructures.Plugin.Test/ViewInfos/HeightStructuresFailureMechanismResultViewInfoTest.cs
    • -1
    • +1
    /Ringtoets/Integration/test/Ringtoets.Integration.Plugin.Test/Ringtoets.Integration.Plugin.Test.csproj
    • -0
    • +217
    /Ringtoets/Integration/test/Ringtoets.Integration.Plugin.Test/ViewInfos/FailureMechanismViewInfoTest.cs
    • -217
    • +0
    /Ringtoets/Integration/test/Ringtoets.Integration.Plugin.Test/ViewInfos/TestFailureMechanismViewInfoTest.cs
3:55 pm

Carlos Lubbers <carlos.lubbers@deltares.nl>

Implement review comments. Update xmldoc and use test factory in failure mechanism tests WTI-1617

Options
    • -4
    • +5
    /Ringtoets/ClosingStructures/test/Ringtoets.ClosingStructures.Data.Test/ClosingStructuresFailureMechanismTest.cs
    • -1
    • +1
    /Ringtoets/Common/src/Ringtoets.Common.Data/FailureMechanism/IHasSectionResults.cs
    • -12
    • +7
    /Ringtoets/Common/test/Ringtoets.Common.Data.TestUtil.Test/TestFailureMechanismTest.cs
    • -9
    • +7
    /Ringtoets/DuneErosion/test/Ringtoets.DuneErosion.Data.Test/DuneErosionFailureMechanismTest.cs
    • -10
    • +9
    /Ringtoets/GrassCoverErosionInwards/test/Ringtoets.GrassCoverErosionInwards.Data.Test/GrassCoverErosionInwardsFailureMechanismTest.cs
    • -9
    • +8
    /Ringtoets/GrassCoverErosionOutwards/test/Ringtoets.GrassCoverErosionOutwards.Data.Test/GrassCoverErosionOutwardsFailureMechanismTest.cs
    • -4
    • +5
    /Ringtoets/HeightStructures/test/Ringtoets.HeightStructures.Data.Test/HeightStructuresFailureMechanismTest.cs
    • -9
    • +8
    /Ringtoets/Integration/test/Ringtoets.Integration.Data.Test/StandAlone/GrassCoverSlipOffInwardsFailureMechanismTest.cs
    • -9
    • +8
    /Ringtoets/Integration/test/Ringtoets.Integration.Data.Test/StandAlone/GrassCoverSlipOffOutwardsFailureMechanismTest.cs
    • -9
    • +8
    /Ringtoets/Integration/test/Ringtoets.Integration.Data.Test/StandAlone/MacroStabilityOutwardsFailureMechanismTest.cs
    • -9
    • +8
    /Ringtoets/Integration/test/Ringtoets.Integration.Data.Test/StandAlone/MicrostabilityFailureMechanismTest.cs
    • -9
    • +7
    /Ringtoets/Integration/test/Ringtoets.Integration.Data.Test/StandAlone/PipingStructureFailureMechanismTest.cs
    • -9
    • +8
    /Ringtoets/Integration/test/Ringtoets.Integration.Data.Test/StandAlone/StrengthStabilityLengthwiseConstructionFailureMechanismTest.cs
    • -9
    • +8
    /Ringtoets/Integration/test/Ringtoets.Integration.Data.Test/StandAlone/TechnicalInnovationFailureMechanismTest.cs
    • -9
    • +8
    /Ringtoets/Integration/test/Ringtoets.Integration.Data.Test/StandAlone/WaterPressureAsphaltCoverFailureMechanismTest.cs
  16. … 5 more files in changeset.
3:04 pm

Carlos Lubbers <carlos.lubbers@deltares.nl>

Review related changes. Improve assembly factory formatting. WTI-1620

Options
    • -2
    • +2
    /Ringtoets/AssemblyTool/test/Ringtoets.AssemblyTool.KernelWrapper.Test/Calculators/AssemblyToolCalculatorFactoryTest.cs
    • -2
    • +2
    /Ringtoets/ClosingStructures/src/Ringtoets.ClosingStructures.Data/ClosingStructuresFailureMechanismSectionResultAssemblyFactory.cs
    • -2
    • +2
    /Ringtoets/GrassCoverErosionInwards/src/Ringtoets.GrassCoverErosionInwards.Data/GrassCoverErosionInwardsFailureMechanismSectionResultAssemblyFactory.cs
    • -2
    • +2
    /Ringtoets/HeightStructures/src/Ringtoets.HeightStructures.Data/HeightStructuresFailureMechanismSectionResultAssemblyFactory.cs
    • -2
    • +2
    /Ringtoets/MacroStabilityInwards/src/Ringtoets.MacroStabilityInwards.Data/MacroStabilityInwardsFailureMechanismSectionResultAssemblyFactory.cs
    • -2
    • +2
    /Ringtoets/Piping/src/Ringtoets.Piping.Data/PipingFailureMechanismSectionResultAssemblyFactory.cs
    • -2
    • +2
    /Ringtoets/StabilityPointStructures/src/Ringtoets.StabilityPointStructures.Data/StabilityPointStructuresFailureMechanismSectionResultAssemblyFactory.cs
2:50 pm

Carlos Lubbers <carlos.lubbers@deltares.nl>

Review related changes. Improve formatting of factories WTI-1620

Options
    • -8
    • +12
    /Ringtoets/ClosingStructures/src/Ringtoets.ClosingStructures.Data/ClosingStructuresFailureMechanismSectionResultAssemblyFactory.cs
    • -8
    • +11
    /Ringtoets/GrassCoverErosionInwards/src/Ringtoets.GrassCoverErosionInwards.Data/GrassCoverErosionInwardsFailureMechanismSectionResultAssemblyFactory.cs
    • -8
    • +12
    /Ringtoets/HeightStructures/src/Ringtoets.HeightStructures.Data/HeightStructuresFailureMechanismSectionResultAssemblyFactory.cs
    • -0
    • +1
    /Ringtoets/Integration/src/Ringtoets.Integration.Data/StandAlone/AssemblyFactories/StrengthStabilityLengthwiseConstructionFailureMechanismSectionResultAssemblyFactory.cs
    • -0
    • +1
    /Ringtoets/Integration/src/Ringtoets.Integration.Data/StandAlone/AssemblyFactories/TechnicalInnovationFailureMechanismSectionResultAssemblyFactory.cs
    • -0
    • +1
    /Ringtoets/Integration/src/Ringtoets.Integration.Data/StandAlone/AssemblyFactories/WaterPressureAsphaltCoverFailureMechanismSectionResultAssemblyFactory.cs
    • -9
    • +13
    /Ringtoets/MacroStabilityInwards/src/Ringtoets.MacroStabilityInwards.Data/MacroStabilityInwardsFailureMechanismSectionResultAssemblyFactory.cs
    • -9
    • +12
    /Ringtoets/Piping/src/Ringtoets.Piping.Data/PipingFailureMechanismSectionResultAssemblyFactory.cs
    • -8
    • +12
    /Ringtoets/StabilityPointStructures/src/Ringtoets.StabilityPointStructures.Data/StabilityPointStructuresFailureMechanismSectionResultAssemblyFactory.cs
    • -0
    • +1
    /Ringtoets/WaveImpactAsphaltCover/src/Ringtoets.WaveImpactAsphaltCover.Data/WaveImpactAsphaltCoverFailureMechanismSectionResultAssemblyFactory.cs