Riskeer

Clone Tools

Stats

Commits this week: 0
Total Committers: 28
Last Commit: 26 Nov
Commits this week: 0

Lines of code count not available

Commit Activity

Commits By Day In Week
52 week commits volume
Commits By Day In Week
Commits by day
Commits By Day In Week
Commits by hour
Commits By Hour In Day
Commit calendar
 

Most active committers (90 days)

loading
loading
  • last updated a few seconds ago
All Commits Reviews
Constraints
Constraints: committers
 
Constraints: files
Constraints: dates
Monday 23 Oct 2017
1:25 pm

Marten Janssen <marten.janssen@deltares.nl>

Removed empty constructor of MacroStabilityInwardsInput Simplified tests in MacroStabilityInwardsInputContextTreeNodeInfoTest Related to Issue [WTI-1400]

git-svn-id: https://repos.deltares.nl/repos/WettelijkToetsInstrumentarium/trunk@12282 5a3db67b-de53-47b5-99c8-a1c30a6650e2

Former-commit-id: 474dc6152f5570da7aa19451083ae227043d26ac

Former-commit-id: 0fd5d93f1cc10c0dc6fae50194d7c42492f35d24

Options
    • -1
    • +1
    /Ringtoets/MacroStabilityInwards/src/Ringtoets.MacroStabilityInwards.Data/MacroStabilityInwardsCalculation.cs
    • -2
    • +0
    /Ringtoets/MacroStabilityInwards/src/Ringtoets.MacroStabilityInwards.Data/MacroStabilityInwardsInput.cs
    • -3
    • +3
    /Ringtoets/MacroStabilityInwards/test/Ringtoets.MacroStabilityInwards.CalculatedInput.Test/Converters/DrainageConstructionConverterTest.cs
    • -4
    • +4
    /Ringtoets/MacroStabilityInwards/test/Ringtoets.MacroStabilityInwards.Data.TestUtil/MacroStabilityInwardsInputFactory.cs
    • -1
    • +1
    /Ringtoets/MacroStabilityInwards/test/Ringtoets.MacroStabilityInwards.Forms.Test/PresentationObjects/MacroStabilityInwardsInputContextTest.cs
    • -8
    • +10
    /Ringtoets/MacroStabilityInwards/test/Ringtoets.MacroStabilityInwards.Forms.Test/PropertyClasses/MacroStabilityInwardsDrainagePropertiesTest.cs
    • -8
    • +10
    /Ringtoets/MacroStabilityInwards/test/Ringtoets.MacroStabilityInwards.Forms.Test/PropertyClasses/MacroStabilityInwardsGridSettingsPropertiesTest.cs
    • -1
    • +1
    /Ringtoets/MacroStabilityInwards/test/Ringtoets.MacroStabilityInwards.Forms.Test/PropertyClasses/MacroStabilityInwardsInputContextPropertiesTest.cs
    • -7
    • +9
    /Ringtoets/MacroStabilityInwards/test/Ringtoets.MacroStabilityInwards.Forms.Test/PropertyClasses/MacroStabilityInwardsSlipPlaneSettingsPropertiesTest.cs
    • -6
    • +8
    /Ringtoets/MacroStabilityInwards/test/Ringtoets.MacroStabilityInwards.Forms.Test/PropertyClasses/MacroStabilityInwardsWaterStressesPropertiesTest.cs
    • -4
    • +4
    /Ringtoets/MacroStabilityInwards/test/Ringtoets.MacroStabilityInwards.Forms.Test/PropertyClasses/MacroStabilityInwardsWaternetPropertiesTest.cs
    • -2
    • +2
    /Ringtoets/MacroStabilityInwards/test/Ringtoets.MacroStabilityInwards.Forms.Test/UITypeEditors/MacroStabilityInwardsInputContextStochasticSoilModelSelectionEditorTest.cs
    • -2
    • +2
    /Ringtoets/MacroStabilityInwards/test/Ringtoets.MacroStabilityInwards.Forms.Test/UITypeEditors/MacroStabilityInwardsInputContextStochasticSoilProfileSelectionEditorTest.cs
    • -2
    • +2
    /Ringtoets/MacroStabilityInwards/test/Ringtoets.MacroStabilityInwards.Forms.Test/UITypeEditors/MacroStabilityInwardsInputContextSurfaceLineSelectionEditorTest.cs
    • -22
    • +2
    /Ringtoets/MacroStabilityInwards/test/Ringtoets.MacroStabilityInwards.Plugin.Test/TreeNodeInfos/MacroStabilityInwardsInputContextTreeNodeInfoTest.cs
  16. … 3 more files in changeset.
1:18 pm

Robert Tangerman <robert.tangerman@deltares.nl>

Added phreatic lines to view. Related to Issue [WTI-1395]

git-svn-id: https://repos.deltares.nl/repos/WettelijkToetsInstrumentarium/trunk@12281 5a3db67b-de53-47b5-99c8-a1c30a6650e2

Former-commit-id: 61630d71d40a2e5b963ffd2ce80bf0cc5ed63cf7

Former-commit-id: b982a22414d14f91bf4614a45d91ed8c95363585

Options
    • -0
    • +22
    /Ringtoets/MacroStabilityInwards/src/Ringtoets.MacroStabilityInwards.Forms/Factories/MacroStabilityInwardsChartDataFactory.cs
    • -0
    • +11
    /Ringtoets/MacroStabilityInwards/src/Ringtoets.MacroStabilityInwards.Forms/Factories/MacroStabilityInwardsChartDataPointsFactory.cs
    • -1
    • +8
    /Ringtoets/MacroStabilityInwards/src/Ringtoets.MacroStabilityInwards.Forms/Views/MacroStabilityInwardsInputView.cs
    • -0
    • +33
    /Ringtoets/MacroStabilityInwards/test/Ringtoets.MacroStabilityInwards.Forms.Test/Factories/MacroStabilityInwardsChartDataFactoryTest.cs
    • -0
    • +29
    /Ringtoets/MacroStabilityInwards/test/Ringtoets.MacroStabilityInwards.Forms.Test/Factories/MacroStabilityInwardsChartDataPointsFactoryTest.cs
12:58 pm

Marten Janssen <marten.janssen@deltares.nl>

Added validation to TangentLineZTop and TangentLineZBottom. Updated tests to comply with the new validation Related to Issue [WTI-1400]

git-svn-id: https://repos.deltares.nl/repos/WettelijkToetsInstrumentarium/trunk@12280 5a3db67b-de53-47b5-99c8-a1c30a6650e2

Former-commit-id: e9d171ab74574dacd69604e74379b53c2e3afcc5

Former-commit-id: d7bbc42bf0cccd10b7336b67f4364e924649c221

Options
    • -2
    • +2
    /Application/Ringtoets/test/Application.Ringtoets.Storage.Test/Create/MacroStabilityInwards/MacroStabilityInwardsCalculationScenarioCreateExtensionsTest.cs
    • -2
    • +2
    /Application/Ringtoets/test/Application.Ringtoets.Storage.Test/Read/MacroStabilityInwards/MacroStabilityInwardsCalculationEntityReadExtensionsTest.cs
    • -4
    • +4
    /Application/Ringtoets/test/Application.Ringtoets.Storage.TestUtil/RingtoetsProjectTestHelper.cs
    • -0
    • +14
    /Ringtoets/MacroStabilityInwards/src/Ringtoets.MacroStabilityInwards.Data/MacroStabilityInwardsInput.cs
    • -0
    • +10
    /Ringtoets/MacroStabilityInwards/src/Ringtoets.MacroStabilityInwards.Data/Properties/Resources.Designer.cs
    • -0
    • +3
    /Ringtoets/MacroStabilityInwards/src/Ringtoets.MacroStabilityInwards.Data/Properties/Resources.resx
    • -7
    • +7
    /Ringtoets/MacroStabilityInwards/test/Ringtoets.MacroStabilityInwards.Data.Test/MacroStabilityInwardsGridTest.cs
    • -4
    • +47
    /Ringtoets/MacroStabilityInwards/test/Ringtoets.MacroStabilityInwards.Data.Test/MacroStabilityInwardsInputTest.cs
    • -1
    • +1
    /Ringtoets/MacroStabilityInwards/test/Ringtoets.MacroStabilityInwards.Data.TestUtil.Test/MacroStabilityInwardsCalculationScenarioFactoryTest.cs
    • -1
    • +1
    /Ringtoets/MacroStabilityInwards/test/Ringtoets.MacroStabilityInwards.Data.TestUtil/MacroStabilityInwardsCalculationScenarioFactory.cs
    • -2
    • +2
    /Ringtoets/MacroStabilityInwards/test/Ringtoets.MacroStabilityInwards.Forms.Test/PropertyClasses/MacroStabilityInwardsGridSettingsPropertiesTest.cs
    • -2
    • +3
    /Ringtoets/MacroStabilityInwards/test/Ringtoets.MacroStabilityInwards.KernelWrapper.Test/Creators/Input/SlipPlaneUpliftVanCreatorTest.cs
    • -2
    • +2
    /Ringtoets/MacroStabilityInwards/test/Ringtoets.MacroStabilityInwards.Service.Test/Converters/UpliftVanSlipPlaneConverterTest.cs
    • -2
    • +2
    /Ringtoets/MacroStabilityInwards/test/Ringtoets.MacroStabilityInwards.Service.Test/MacroStabilityInwardsCalculationServiceTest.cs
11:12 am

Marten Janssen <marten.janssen@deltares.nl>

- Updated MacroStabilityInwardsInput to have construction properties - Added restriction on ConstructionProperties.TangentLines (ZTop > ZBottom) - Updated MacroStabilityInwardsInputTest to use ConstructionProperties Related to Issue [WTI-1400]

git-svn-id: https://repos.deltares.nl/repos/WettelijkToetsInstrumentarium/trunk@12279 5a3db67b-de53-47b5-99c8-a1c30a6650e2

Former-commit-id: 46cf4a53e0fd9333176f43ceff9737d3e1f64071

Former-commit-id: 7f0c125156287b9204ae360157dd3f455ecca582

Options
    • -2
    • +2
    /Ringtoets/MacroStabilityInwards/src/Ringtoets.MacroStabilityInwards.Data/MacroStabilityInwardsGrid.cs
    • -5
    • +115
    /Ringtoets/MacroStabilityInwards/src/Ringtoets.MacroStabilityInwards.Data/MacroStabilityInwardsInput.cs
    • -0
    • +10
    /Ringtoets/MacroStabilityInwards/src/Ringtoets.MacroStabilityInwards.Data/Properties/Resources.Designer.cs
    • -0
    • +3
    /Ringtoets/MacroStabilityInwards/src/Ringtoets.MacroStabilityInwards.Data/Properties/Resources.resx
    • -4
    • +4
    /Ringtoets/MacroStabilityInwards/test/Ringtoets.MacroStabilityInwards.Data.Test/MacroStabilityInwardsGridTest.cs
    • -16
    • +170
    /Ringtoets/MacroStabilityInwards/test/Ringtoets.MacroStabilityInwards.Data.Test/MacroStabilityInwardsInputTest.cs
10:04 am

Robert Tangerman <robert.tangerman@deltares.nl>

Added waternet line zones to the input view. Related to Issue [WTI-1395]

git-svn-id: https://repos.deltares.nl/repos/WettelijkToetsInstrumentarium/trunk@12278 5a3db67b-de53-47b5-99c8-a1c30a6650e2

Former-commit-id: 82a5febf3948c40a3219a17a58f078ce855aa89c

Former-commit-id: 06cbc3db09238ac0963eb7756b45433bdf8bef8b

Options
    • -0
    • +42
    /Ringtoets/MacroStabilityInwards/src/Ringtoets.MacroStabilityInwards.Forms/Factories/MacroStabilityInwardsChartDataFactory.cs
    • -0
    • +21
    /Ringtoets/MacroStabilityInwards/src/Ringtoets.MacroStabilityInwards.Forms/Factories/MacroStabilityInwardsChartDataPointsFactory.cs
    • -0
    • +18
    /Ringtoets/MacroStabilityInwards/src/Ringtoets.MacroStabilityInwards.Forms/Properties/Resources.Designer.cs
    • -0
    • +6
    /Ringtoets/MacroStabilityInwards/src/Ringtoets.MacroStabilityInwards.Forms/Properties/Resources.resx
    • -2
    • +18
    /Ringtoets/MacroStabilityInwards/src/Ringtoets.MacroStabilityInwards.Forms/Views/MacroStabilityInwardsInputView.cs
    • -0
    • +48
    /Ringtoets/MacroStabilityInwards/test/Ringtoets.MacroStabilityInwards.Forms.Test/Factories/MacroStabilityInwardsChartDataFactoryTest.cs
    • -1
    • +38
    /Ringtoets/MacroStabilityInwards/test/Ringtoets.MacroStabilityInwards.Forms.Test/Factories/MacroStabilityInwardsChartDataPointsFactoryTest.cs
    • -2
    • +10
    /Ringtoets/MacroStabilityInwards/test/Ringtoets.MacroStabilityInwards.Forms.Test/Views/MacroStabilityInwardsInputViewTest.cs
8:44 am

Marten Janssen <marten.janssen@deltares.nl>

- Added validation for MacroStabilityInwardsGrid X and Z - Updated tests to comply with the new restrictions on the MacroStabilityInwardsGrid - Added overload for Random.NextRoundedDouble with range Related to Issue [WTI-1400]

git-svn-id: https://repos.deltares.nl/repos/WettelijkToetsInstrumentarium/trunk@12277 5a3db67b-de53-47b5-99c8-a1c30a6650e2

Former-commit-id: c3004e5a0c7735345a8b66e548cde9e67490c77a

Former-commit-id: e58a79f58922074521c2b76c8ef8529c024d6aba

Options
    • -7
    • +8
    /Application/Ringtoets/test/Application.Ringtoets.Storage.Test/Create/MacroStabilityInwards/MacroStabilityInwardsCalculationScenarioCreateExtensionsTest.cs
    • -8
    • +8
    /Application/Ringtoets/test/Application.Ringtoets.Storage.Test/Read/MacroStabilityInwards/MacroStabilityInwardsCalculationEntityReadExtensionsTest.cs
    • -8
    • +8
    /Application/Ringtoets/test/Application.Ringtoets.Storage.Test/Read/MacroStabilityInwards/MacroStabilityInwardsCalculationOutputEntityReadExtensionsTest.cs
    • -8
    • +8
    /Application/Ringtoets/test/Application.Ringtoets.Storage.TestUtil/RingtoetsProjectTestHelper.cs
    • -0
    • +20
    /Core/Common/test/Core.Common.TestUtil/RandomExtensions.cs
    • -0
    • +50
    /Ringtoets/MacroStabilityInwards/src/Ringtoets.MacroStabilityInwards.Data/MacroStabilityInwardsGrid.cs
    • -0
    • +36
    /Ringtoets/MacroStabilityInwards/src/Ringtoets.MacroStabilityInwards.Data/Properties/Resources.Designer.cs
    • -0
    • +12
    /Ringtoets/MacroStabilityInwards/src/Ringtoets.MacroStabilityInwards.Data/Properties/Resources.resx
    • -3
    • +128
    /Ringtoets/MacroStabilityInwards/test/Ringtoets.MacroStabilityInwards.Data.Test/MacroStabilityInwardsGridTest.cs
    • -8
    • +8
    /Ringtoets/MacroStabilityInwards/test/Ringtoets.MacroStabilityInwards.Data.Test/MacroStabilityInwardsInputTest.cs
    • -4
    • +4
    /Ringtoets/MacroStabilityInwards/test/Ringtoets.MacroStabilityInwards.Data.TestUtil.Test/MacroStabilityInwardsCalculationScenarioFactoryTest.cs
    • -4
    • +4
    /Ringtoets/MacroStabilityInwards/test/Ringtoets.MacroStabilityInwards.Data.TestUtil/MacroStabilityInwardsCalculationScenarioFactory.cs
    • -104
    • +0
    /Ringtoets/MacroStabilityInwards/test/Ringtoets.MacroStabilityInwards.Forms.Test/Factories/MacroStabilityInwardsChartDataPointsFactoryTest.cs
    • -2
    • +2
    /Ringtoets/MacroStabilityInwards/test/Ringtoets.MacroStabilityInwards.KernelWrapper.TestUtil.Test/Calculators/UpliftVan/UpliftVanGridTestFactoryTest.cs
    • -1
    • +1
    /Ringtoets/MacroStabilityInwards/test/Ringtoets.MacroStabilityInwards.KernelWrapper.TestUtil/Calculators/UpliftVan/UpliftVanGridTestFactory.cs
    • -16
    • +16
    /Ringtoets/MacroStabilityInwards/test/Ringtoets.MacroStabilityInwards.Service.Test/Converters/UpliftVanSlipPlaneConverterTest.cs
    • -8
    • +8
    /Ringtoets/MacroStabilityInwards/test/Ringtoets.MacroStabilityInwards.Service.Test/MacroStabilityInwardsCalculationServiceTest.cs
Friday 20 Oct 2017
5:41 pm

Robert Tangerman <robert.tangerman@deltares.nl>

Improvements after review. Related to Issue [WTI-1345]

git-svn-id: https://repos.deltares.nl/repos/WettelijkToetsInstrumentarium/trunk@12276 5a3db67b-de53-47b5-99c8-a1c30a6650e2

Former-commit-id: b3768f456a6fa3ab0676ae66ffe7fdcd5aa26c0d

Former-commit-id: a6b9fefd2569f12e897c6053baae97c6fd7bd0ca

Options
    • -1
    • +1
    /Core/Common/src/Core.Common.Utils/Reflection/TypeUtils.cs
    • -2
    • +2
    /Core/Common/test/Core.Common.Utils.Test/Reflection/TypeUtilsTest.cs
    • -4
    • +4
    /Ringtoets/MacroStabilityInwards/src/Ringtoets.MacroStabilityInwards.KernelWrapper/Calculators/Waternet/WaternetCalculator.cs
    • -3
    • +2
    /Ringtoets/MacroStabilityInwards/src/Ringtoets.MacroStabilityInwards.KernelWrapper/Creators/Input/SoilCreator.cs
    • -3
    • +2
    /Ringtoets/MacroStabilityInwards/src/Ringtoets.MacroStabilityInwards.KernelWrapper/Creators/Input/SoilModelCreator.cs
    • -3
    • +2
    /Ringtoets/MacroStabilityInwards/src/Ringtoets.MacroStabilityInwards.KernelWrapper/Creators/Input/SoilProfileCreator.cs
    • -3
    • +2
    /Ringtoets/MacroStabilityInwards/src/Ringtoets.MacroStabilityInwards.KernelWrapper/Creators/Input/SurfaceLineCreator.cs
4:33 pm

Carlos Lubbers

Implement review comments, make StabilityModel private and access it in tests with a new TypeUtils method. Add more asserts in several tests. Related to Issue [WTI-1345]

git-svn-id: https://repos.deltares.nl/repos/WettelijkToetsInstrumentarium/trunk@12275 5a3db67b-de53-47b5-99c8-a1c30a6650e2

Former-commit-id: 086ddc5c047480b110d9b407894e0b46ba20caa9

Former-commit-id: d59ecea68d791818bddc3ef0388b87da350c76c5

Options
    • -0
    • +27
    /Core/Common/src/Core.Common.Utils/Reflection/TypeUtils.cs
    • -0
    • +107
    /Core/Common/test/Core.Common.Utils.Test/Reflection/TypeUtilsTest.cs
    • -10
    • +12
    /Ringtoets/MacroStabilityInwards/src/Ringtoets.MacroStabilityInwards.KernelWrapper/Kernels/Waternet/WaternetKernelWrapper.cs
    • -1
    • +1
    /Ringtoets/MacroStabilityInwards/test/Ringtoets.MacroStabilityInwards.KernelWrapper.Test/Kernels/Waternet/WaternetDailyKernelWrapperTest.cs
    • -1
    • +1
    /Ringtoets/MacroStabilityInwards/test/Ringtoets.MacroStabilityInwards.KernelWrapper.Test/Kernels/Waternet/WaternetExtremeKernelWrapperTest.cs
    • -15
    • +2
    /Ringtoets/MacroStabilityInwards/test/Ringtoets.MacroStabilityInwards.KernelWrapper.Test/Kernels/Waternet/WaternetKernelWrapperTest.cs
    • -4
    • +4
    /Ringtoets/MacroStabilityInwards/test/Ringtoets.MacroStabilityInwards.KernelWrapper.TestUtil.Test/Calculators/TestMacroStabilityInwardsCalculatorFactoryTest.cs
    • -2
    • +11
    /Ringtoets/MacroStabilityInwards/test/Ringtoets.MacroStabilityInwards.KernelWrapper.TestUtil.Test/Calculators/Waternet/Input/WaternetCalculatorInputTestFactoryTest.cs
    • -1
    • +0
    /Ringtoets/MacroStabilityInwards/test/Ringtoets.MacroStabilityInwards.KernelWrapper.TestUtil.Test/Calculators/Waternet/Output/WaternetCalculatorResultTestFactoryTest.cs
    • -6
    • +28
    /Ringtoets/MacroStabilityInwards/test/Ringtoets.MacroStabilityInwards.KernelWrapper.TestUtil/Kernels/UpliftVan/Input/KernelInputAssert.cs
    • -1
    • +1
    /Ringtoets/MacroStabilityInwards/test/Ringtoets.MacroStabilityInwards.Service.Test/MacroStabilityInwardsCalculationServiceTest.cs
4:30 pm

Robert Tangerman <robert.tangerman@deltares.nl>

Created TestUtil project and assert for output view. Related to Issue [WTI-1412]

git-svn-id: https://repos.deltares.nl/repos/WettelijkToetsInstrumentarium/trunk@12274 5a3db67b-de53-47b5-99c8-a1c30a6650e2

Former-commit-id: 488326cd79154dfd5241902bef84492c94f92e19

Former-commit-id: 80d05a61a5dc0c9d6b27f5bed74967d89f9112ca

Options
    • -0
    • +14
    /Ringtoets.sln
    • -0
    • +4
    /Ringtoets/MacroStabilityInwards/test/Ringtoets.MacroStabilityInwards.Forms.Test/Ringtoets.MacroStabilityInwards.Forms.Test.csproj
    • -140
    • +21
    /Ringtoets/MacroStabilityInwards/test/Ringtoets.MacroStabilityInwards.Forms.Test/Views/MacroStabilityInwardsOutputChartControlTest.cs
    • -56
    • +131
    /Ringtoets/MacroStabilityInwards/test/Ringtoets.MacroStabilityInwards.Forms.Test/Views/MacroStabilityInwardsOutputViewTest.cs
    • -0
    • +185
    /Ringtoets/MacroStabilityInwards/test/Ringtoets.MacroStabilityInwards.Forms.TestUtil/MacroStabilityInwardsOutputViewChartDataAssert.cs
    • -0
    • +27
    /Ringtoets/MacroStabilityInwards/test/Ringtoets.MacroStabilityInwards.Forms.TestUtil/Properties/AssemblyInfo.cs
    • -0
    • +95
    /Ringtoets/MacroStabilityInwards/test/Ringtoets.MacroStabilityInwards.Forms.TestUtil/Ringtoets.MacroStabilityInwards.Forms.TestUtil.csproj
    • -0
    • +26
    /Ringtoets/MacroStabilityInwards/test/Ringtoets.MacroStabilityInwards.Forms.TestUtil/packages.config
3:35 pm

Robert Tangerman <robert.tangerman@deltares.nl>

Add empty chart data when output is not set instead of removing everything. Related to Issue [WTI-1412]

git-svn-id: https://repos.deltares.nl/repos/WettelijkToetsInstrumentarium/trunk@12273 5a3db67b-de53-47b5-99c8-a1c30a6650e2

Former-commit-id: 646df876d642973065745dde7cc099311bafebc8

Former-commit-id: a417c1763126af1c04b35388ee5690211863b396

Options
    • -3
    • +7
    /Ringtoets/MacroStabilityInwards/src/Ringtoets.MacroStabilityInwards.Forms/Views/MacroStabilityInwardsInputView.cs
    • -26
    • +48
    /Ringtoets/MacroStabilityInwards/src/Ringtoets.MacroStabilityInwards.Forms/Views/MacroStabilityInwardsOutputChartControl.cs
    • -10
    • +10
    /Ringtoets/MacroStabilityInwards/src/Ringtoets.MacroStabilityInwards.Forms/Views/MacroStabilityInwardsOutputView.cs
    • -1
    • +1
    /Ringtoets/MacroStabilityInwards/test/Ringtoets.MacroStabilityInwards.Data.TestUtil.Test/MacroStabilityInwardsCalculationScenarioFactoryTest.cs
    • -1
    • +1
    /Ringtoets/MacroStabilityInwards/test/Ringtoets.MacroStabilityInwards.Data.TestUtil/MacroStabilityInwardsCalculationScenarioFactory.cs
    • -6
    • +227
    /Ringtoets/MacroStabilityInwards/test/Ringtoets.MacroStabilityInwards.Forms.Test/Views/MacroStabilityInwardsOutputChartControlTest.cs
    • -80
    • +57
    /Ringtoets/MacroStabilityInwards/test/Ringtoets.MacroStabilityInwards.Forms.Test/Views/MacroStabilityInwardsOutputViewTest.cs
3:21 pm

Carlos Lubbers

Implement review comments, update test names, fix failing test Related to Issue [WTI-1345]

git-svn-id: https://repos.deltares.nl/repos/WettelijkToetsInstrumentarium/trunk@12272 5a3db67b-de53-47b5-99c8-a1c30a6650e2

Former-commit-id: 678d06a91da941c3aeb3eac8c6bf6bc10ffa6674

Former-commit-id: ec995504dee603f21361c2916417d394091b4629

Options
    • -2
    • +10
    /Ringtoets/MacroStabilityInwards/src/Ringtoets.MacroStabilityInwards.KernelWrapper/Kernels/Waternet/WaternetKernelWrapper.cs
    • -10
    • +0
    /Ringtoets/MacroStabilityInwards/test/Ringtoets.MacroStabilityInwards.Data.Test/DerivedMacroStabilityInwardsInputTest.cs
    • -5
    • +5
    /Ringtoets/MacroStabilityInwards/test/Ringtoets.MacroStabilityInwards.KernelWrapper.Test/Calculators/MacroStabilityInwardsCalculatorFactoryTest.cs
    • -14
    • +14
    /Ringtoets/MacroStabilityInwards/test/Ringtoets.MacroStabilityInwards.KernelWrapper.Test/Calculators/Waternet/Input/WaternetCalculatorInputTest.cs
    • -6
    • +6
    /Ringtoets/MacroStabilityInwards/test/Ringtoets.MacroStabilityInwards.KernelWrapper.Test/Creators/Input/StabilityLocationCreatorHelperTest.cs
    • -1
    • +1
    /Ringtoets/MacroStabilityInwards/test/Ringtoets.MacroStabilityInwards.KernelWrapper.Test/Creators/Input/UpliftVanStabilityLocationCreatorTest.cs
    • -4
    • +4
    /Ringtoets/MacroStabilityInwards/test/Ringtoets.MacroStabilityInwards.KernelWrapper.Test/Creators/Input/WaternetStabilityLocationCreatorTest.cs
2:52 pm

Carlos Lubbers

Implement review comments from review 2202: Rename tests, update xmldoc, improve derived classes from WaternetKernelWrapper, cleanup Related to Issue [WTI-1345]

git-svn-id: https://repos.deltares.nl/repos/WettelijkToetsInstrumentarium/trunk@12271 5a3db67b-de53-47b5-99c8-a1c30a6650e2

Former-commit-id: 4f07713a9d875f54b625adb9893eeaf239c6e62f

Former-commit-id: 90e6dbd48460d7f1857155f05964b5b1bc085c2a

Options
    • -1
    • +1
    /Ringtoets/MacroStabilityInwards/src/Ringtoets.MacroStabilityInwards.CalculatedInput/Converters/MacroStabilityInwardsWaternetConverter.cs
    • -1
    • +0
    /Ringtoets/MacroStabilityInwards/src/Ringtoets.MacroStabilityInwards.CalculatedInput/Ringtoets.MacroStabilityInwards.CalculatedInput.csproj
    • -19
    • +33
    /Ringtoets/MacroStabilityInwards/src/Ringtoets.MacroStabilityInwards.CalculatedInput/WaternetCalculationService.cs
    • -2
    • +0
    /Ringtoets/MacroStabilityInwards/src/Ringtoets.MacroStabilityInwards.Forms/PropertyClasses/MacroStabilityInwardsWaternetProperties.cs
    • -1
    • +8
    /Ringtoets/MacroStabilityInwards/src/Ringtoets.MacroStabilityInwards.KernelWrapper/Calculators/IMacroStabilityInwardsCalculatorFactory.cs
    • -1
    • +1
    /Ringtoets/MacroStabilityInwards/src/Ringtoets.MacroStabilityInwards.KernelWrapper/Calculators/Waternet/Input/WaternetCalculatorInput.cs
    • -1
    • +2
    /Ringtoets/MacroStabilityInwards/src/Ringtoets.MacroStabilityInwards.KernelWrapper/Calculators/Waternet/Output/WaternetCalculatorResult.cs
    • -13
    • +16
    /Ringtoets/MacroStabilityInwards/src/Ringtoets.MacroStabilityInwards.KernelWrapper/Calculators/Waternet/WaternetCalculator.cs
    • -2
    • +2
    /Ringtoets/MacroStabilityInwards/src/Ringtoets.MacroStabilityInwards.KernelWrapper/Calculators/Waternet/WaternetDailyCalculator.cs
    • -2
    • +2
    /Ringtoets/MacroStabilityInwards/src/Ringtoets.MacroStabilityInwards.KernelWrapper/Calculators/Waternet/WaternetExtremeCalculator.cs
    • -9
    • +7
    /Ringtoets/MacroStabilityInwards/src/Ringtoets.MacroStabilityInwards.KernelWrapper/Creators/Input/SoilCreator.cs
    • -1
    • +11
    /Ringtoets/MacroStabilityInwards/src/Ringtoets.MacroStabilityInwards.KernelWrapper/Kernels/Waternet/WaternetDailyKernelWrapper.cs
    • -3
    • +12
    /Ringtoets/MacroStabilityInwards/src/Ringtoets.MacroStabilityInwards.KernelWrapper/Kernels/Waternet/WaternetExtremeKernelWrapper.cs
    • -25
    • +12
    /Ringtoets/MacroStabilityInwards/src/Ringtoets.MacroStabilityInwards.KernelWrapper/Kernels/Waternet/WaternetKernelWrapper.cs
    • -17
    • +22
    /Ringtoets/MacroStabilityInwards/test/Ringtoets.MacroStabilityInwards.CalculatedInput.Test/Converters/DrainageConstructionConverterTest.cs
  16. … 12 more files in changeset.
1:38 pm

Marten Janssen <marten.janssen@deltares.nl>

Added validation in MacroStabilityInwardsGrid: - NumberOfHorizontalPoints [1, 100], default set to 5 - NumberOfVerticalPoints [1, 100], default set to 5 Related to Issue [WTI-1400]

git-svn-id: https://repos.deltares.nl/repos/WettelijkToetsInstrumentarium/trunk@12270 5a3db67b-de53-47b5-99c8-a1c30a6650e2

Former-commit-id: 2aba5bbcced6dfcafc4908a727ff829c6e38d6ee

Former-commit-id: 919adf3dbad612b4ecfb29b689ae84d7f86866f6

Options
    • -4
    • +4
    /Application/Ringtoets/test/Application.Ringtoets.Storage.Test/Create/MacroStabilityInwards/MacroStabilityInwardsCalculationScenarioCreateExtensionsTest.cs
    • -4
    • +20
    /Application/Ringtoets/test/Application.Ringtoets.Storage.Test/Read/CalculationGroupEntityReadExtentionsTest.cs
    • -1
    • +5
    /Application/Ringtoets/test/Application.Ringtoets.Storage.Test/Read/FailureMechanismEntityReadExtensionsTest.cs
    • -41
    • +37
    /Application/Ringtoets/test/Application.Ringtoets.Storage.Test/Read/MacroStabilityInwards/MacroStabilityInwardsCalculationEntityReadExtensionsTest.cs
    • -19
    • +23
    /Application/Ringtoets/test/Application.Ringtoets.Storage.Test/Read/MacroStabilityInwards/MacroStabilityInwardsCalculationOutputEntityReadExtensionsTest.cs
    • -2
    • +46
    /Ringtoets/MacroStabilityInwards/src/Ringtoets.MacroStabilityInwards.Data/MacroStabilityInwardsGrid.cs
    • -0
    • +18
    /Ringtoets/MacroStabilityInwards/src/Ringtoets.MacroStabilityInwards.Data/Properties/Resources.Designer.cs
    • -0
    • +6
    /Ringtoets/MacroStabilityInwards/src/Ringtoets.MacroStabilityInwards.Data/Properties/Resources.resx
    • -9
    • +2
    /Ringtoets/MacroStabilityInwards/src/Ringtoets.MacroStabilityInwards.Forms/Factories/MacroStabilityInwardsChartDataPointsFactory.cs
    • -2
    • +37
    /Ringtoets/MacroStabilityInwards/test/Ringtoets.MacroStabilityInwards.Data.Test/MacroStabilityInwardsGridTest.cs
    • -4
    • +4
    /Ringtoets/MacroStabilityInwards/test/Ringtoets.MacroStabilityInwards.Data.Test/MacroStabilityInwardsInputTest.cs
    • -28
    • +2
    /Ringtoets/MacroStabilityInwards/test/Ringtoets.MacroStabilityInwards.Forms.Test/Factories/MacroStabilityInwardsChartDataPointsFactoryTest.cs
    • -2
    • +2
    /Ringtoets/MacroStabilityInwards/test/Ringtoets.MacroStabilityInwards.Forms.Test/PropertyClasses/MacroStabilityInwardsGridPropertiesTest.cs
    • -8
    • +8
    /Ringtoets/MacroStabilityInwards/test/Ringtoets.MacroStabilityInwards.Service.Test/Converters/UpliftVanSlipPlaneConverterTest.cs
    • -4
    • +4
    /Ringtoets/MacroStabilityInwards/test/Ringtoets.MacroStabilityInwards.Service.Test/MacroStabilityInwardsCalculationServiceTest.cs
1:32 pm

Dennis Tang <dennis.tang@deltares.nl>

- Implemented Duplicate context menu item for MacroStabilityInwards calculation group treenode info items -- Added equals method to the context to ensure hierarchy being maintained in the project explorer

Related to Issue [WTI-1366]

git-svn-id: https://repos.deltares.nl/repos/WettelijkToetsInstrumentarium/trunk@12269 5a3db67b-de53-47b5-99c8-a1c30a6650e2

Former-commit-id: 456b2eb8f1b0786b7bfa295f4b0196f685c81109

Former-commit-id: 20df36d3273601c8051a8e6cceb74f58cc9344c2

Options
    • -0
    • +18
    /Ringtoets/MacroStabilityInwards/src/Ringtoets.MacroStabilityInwards.Forms/PresentationObjects/MacroStabilityInwardsCalculationGroupContext.cs
    • -3
    • +8
    /Ringtoets/MacroStabilityInwards/src/Ringtoets.MacroStabilityInwards.Plugin/MacroStabilityInwardsPlugin.cs
    • -1
    • +280
    /Ringtoets/MacroStabilityInwards/test/Ringtoets.MacroStabilityInwards.Forms.Test/PresentationObjects/MacroStabilityInwardsCalculationGroupContextTest.cs
    • -15
    • +21
    /Ringtoets/MacroStabilityInwards/test/Ringtoets.MacroStabilityInwards.Plugin.Test/TreeNodeInfos/MacroStabilityInwardsCalculationGroupContextTreeNodeInfoTest.cs
1:09 pm

Robert Tangerman <robert.tangerman@deltares.nl>

Resolve MacroStabilityInwardsSoilProfileUnderSurfaceLine dynamically. Related to Issue [WTI-1399]

git-svn-id: https://repos.deltares.nl/repos/WettelijkToetsInstrumentarium/trunk@12268 5a3db67b-de53-47b5-99c8-a1c30a6650e2

Former-commit-id: 03e885f963173c181f776e578757b499439c5305

Former-commit-id: 05550778449a1a91ddcc3d6a14bf52ab1292253c

Options
    • -48
    • +25
    /Ringtoets/MacroStabilityInwards/src/Ringtoets.MacroStabilityInwards.Data/MacroStabilityInwardsInput.cs
    • -2
    • +2
    /Ringtoets/MacroStabilityInwards/test/Ringtoets.MacroStabilityInwards.CalculatedInput.TestUtil/CalculatorInputAssert.cs
11:57 am

Dennis Tang <dennis.tang@deltares.nl>

- Implemented Duplicate context menu item for MacroStabilityInwards calculation treenode info items -- Added equals method to the context to ensure hierarchy being maintained in the project explorer - Synchronised test names of MacroStabilityInwards calculations with other duplications -- Expanded test to ensure that base.Clone() is called from the derived class Related to Issue [WTI-1366]

git-svn-id: https://repos.deltares.nl/repos/WettelijkToetsInstrumentarium/trunk@12267 5a3db67b-de53-47b5-99c8-a1c30a6650e2

Former-commit-id: 077d5c792532550e79a6b88eb58817db52fd2932

Former-commit-id: 0728c6fc34d66fc157e047cbe746a31c917d1348

Options
    • -0
    • +18
    /Ringtoets/MacroStabilityInwards/src/Ringtoets.MacroStabilityInwards.Forms/PresentationObjects/MacroStabilityInwardsCalculationScenarioContext.cs
    • -1
    • +28
    /Ringtoets/MacroStabilityInwards/test/Ringtoets.MacroStabilityInwards.Data.Test/MacroStabilityInwardsCalculationScenarioTest.cs
    • -2
    • +2
    /Ringtoets/MacroStabilityInwards/test/Ringtoets.MacroStabilityInwards.Data.Test/MacroStabilityInwardsCalculationTest.cs
    • -0
    • +275
    /Ringtoets/MacroStabilityInwards/test/Ringtoets.MacroStabilityInwards.Forms.Test/PresentationObjects/MacroStabilityInwardsCalculationScenarioContextTest.cs
11:40 am

Robert Tangerman <robert.tangerman@deltares.nl>

Created factory methods for getting the geometry data of soil profiles. Related to Issue [WTI-1399]

git-svn-id: https://repos.deltares.nl/repos/WettelijkToetsInstrumentarium/trunk@12266 5a3db67b-de53-47b5-99c8-a1c30a6650e2

Former-commit-id: 87d95af1efe4d078124a62edc2266057dfec7625

Former-commit-id: d6fe65c8c603da56601be0595665b694bd84d3fe

Options
    • -25
    • +8
    /Ringtoets/MacroStabilityInwards/src/Ringtoets.MacroStabilityInwards.Forms/Factories/MacroStabilityInwardsChartDataFactory.cs
    • -131
    • +45
    /Ringtoets/MacroStabilityInwards/src/Ringtoets.MacroStabilityInwards.Forms/Factories/MacroStabilityInwardsChartDataPointsFactory.cs
    • -17
    • +17
    /Ringtoets/MacroStabilityInwards/src/Ringtoets.MacroStabilityInwards.Forms/Views/MacroStabilityInwardsInputView.cs
    • -39
    • +1
    /Ringtoets/MacroStabilityInwards/test/Ringtoets.MacroStabilityInwards.Forms.Test/Factories/MacroStabilityInwardsChartDataFactoryTest.cs
    • -286
    • +89
    /Ringtoets/MacroStabilityInwards/test/Ringtoets.MacroStabilityInwards.Forms.Test/Factories/MacroStabilityInwardsChartDataPointsFactoryTest.cs
10:48 am

Marten Janssen <marten.janssen@deltares.nl>

Refactored MacroStabilityInwardsGrid to be able to set the x left/right and z top/bottom via the constructor Related to Issue [WTI-1400]

git-svn-id: https://repos.deltares.nl/repos/WettelijkToetsInstrumentarium/trunk@12265 5a3db67b-de53-47b5-99c8-a1c30a6650e2

Former-commit-id: 0f86def14d70aa807cabae1394b52f0c1f8334c5

Former-commit-id: 9ff2c4efb5bcb5ba77076d98eb057631ad27c736

Options
    • -11
    • +9
    /Application/Ringtoets/src/Application.Ringtoets.Storage/Read/MacroStabilityInwards/MacroStabilityInwardsCalculationOutputEntityReadExtensions.cs
    • -8
    • +7
    /Application/Ringtoets/test/Application.Ringtoets.Storage.Test/Create/MacroStabilityInwards/MacroStabilityInwardsOutputCreateExtensionsTest.cs
    • -5
    • +9
    /Ringtoets/MacroStabilityInwards/src/Ringtoets.MacroStabilityInwards.Data/MacroStabilityInwardsGrid.cs
    • -2
    • +2
    /Ringtoets/MacroStabilityInwards/src/Ringtoets.MacroStabilityInwards.Data/MacroStabilityInwardsInput.cs
    • -6
    • +4
    /Ringtoets/MacroStabilityInwards/src/Ringtoets.MacroStabilityInwards.Service/Converters/MacroStabilityInwardsSlipPlaneUpliftVanConverter.cs
    • -13
    • +18
    /Ringtoets/MacroStabilityInwards/test/Ringtoets.MacroStabilityInwards.Data.Test/MacroStabilityInwardsGridTest.cs
    • -4
    • +5
    /Ringtoets/MacroStabilityInwards/test/Ringtoets.MacroStabilityInwards.Data.TestUtil.Test/MacroStabilityInwardsGridTestFactoryTest.cs
    • -8
    • +2
    /Ringtoets/MacroStabilityInwards/test/Ringtoets.MacroStabilityInwards.Data.TestUtil/MacroStabilityInwardsGridTestFactory.cs
    • -126
    • +58
    /Ringtoets/MacroStabilityInwards/test/Ringtoets.MacroStabilityInwards.Forms.Test/Factories/MacroStabilityInwardsChartDataPointsFactoryTest.cs
    • -10
    • +16
    /Ringtoets/MacroStabilityInwards/test/Ringtoets.MacroStabilityInwards.Forms.Test/PropertyClasses/MacroStabilityInwardsGridPropertiesTest.cs
10:45 am

Carlos Lubbers

Change Assert.AreEqual to CollectionAssert.AreEqual Paired with [~janssen] Related to Issue [WTI-1443]

git-svn-id: https://repos.deltares.nl/repos/WettelijkToetsInstrumentarium/trunk@12264 5a3db67b-de53-47b5-99c8-a1c30a6650e2

Former-commit-id: f1272f0829059f4afc8cd5c2280603f15d4c1f91

Former-commit-id: f60e5a8c8188c6a1adb636cb49ae151fdfe73ab9

Options
    • -1
    • +1
    /Ringtoets/MacroStabilityInwards/test/Ringtoets.MacroStabilityInwards.IO.Test/SurfaceLines/MacrostabilityInwardsSurfaceLineTransformerTest.cs
    • -1
    • +1
    /Ringtoets/Piping/test/Ringtoets.Piping.IO.Test/SurfaceLines/PipingSurfaceLineTransformerTest.cs
10:27 am

Dennis Tang <dennis.tang@deltares.nl>

- Implemented Duplicate context menu item for MacroStabilityInwards calculation treenode info items Related to Issue [WTI-1366]

git-svn-id: https://repos.deltares.nl/repos/WettelijkToetsInstrumentarium/trunk@12263 5a3db67b-de53-47b5-99c8-a1c30a6650e2

Former-commit-id: 005fc3c13870c1286f69f5da2f41115e8c7b38bb

Former-commit-id: 92ccea4dad0a3c4cd4bafc1079d6e25a7b8cced1

Options
    • -0
    • +2
    /Ringtoets/MacroStabilityInwards/src/Ringtoets.MacroStabilityInwards.Plugin/MacroStabilityInwardsPlugin.cs
    • -3
    • +12
    /Ringtoets/MacroStabilityInwards/test/Ringtoets.MacroStabilityInwards.Plugin.Test/TreeNodeInfos/MacroStabilityInwardsCalculationScenarioContextTreeNodeInfoTest.cs
9:53 am

Dennis Tang <dennis.tang@deltares.nl>

- Implemented .Clone() for the MacroStabilityInwardsLocationCalculation and its derived classes -- Added helpers in the clone assert - Cleaned up some test code Related to Issue [WTI-1366]

git-svn-id: https://repos.deltares.nl/repos/WettelijkToetsInstrumentarium/trunk@12262 5a3db67b-de53-47b5-99c8-a1c30a6650e2

Former-commit-id: fb463e361e96a23c9e3dac546151b4edbd400ad2

Former-commit-id: a2687cfd64d637cbf838327341d80c6f51bc7221

Options
    • -6
    • +19
    /Ringtoets/MacroStabilityInwards/src/Ringtoets.MacroStabilityInwards.Data/MacroStabilityInwardsCalculation.cs
    • -0
    • +26
    /Ringtoets/MacroStabilityInwards/test/Ringtoets.MacroStabilityInwards.Data.Test/MacroStabilityInwardsCalculationScenarioTest.cs
    • -0
    • +53
    /Ringtoets/MacroStabilityInwards/test/Ringtoets.MacroStabilityInwards.Data.Test/MacroStabilityInwardsCalculationTest.cs
    • -1
    • +1
    /Ringtoets/MacroStabilityInwards/test/Ringtoets.MacroStabilityInwards.Data.TestUtil.Test/MacroStabilityInwardsSemiProbabilisticTestFactoryTest.cs
    • -0
    • +16
    /Ringtoets/MacroStabilityInwards/test/Ringtoets.MacroStabilityInwards.Data.TestUtil/MacroStabilityInwardsCloneAssert.cs
9:48 am

Robert Tangerman <robert.tangerman@deltares.nl>

Clear chart when output is cleared. Related to Issue [WTI-1412]

git-svn-id: https://repos.deltares.nl/repos/WettelijkToetsInstrumentarium/trunk@12261 5a3db67b-de53-47b5-99c8-a1c30a6650e2

Former-commit-id: e197db774b22a0fa9b4b824c9870675074f41aed

Former-commit-id: e2d9ad0390e4117189a08f4f4e1678d4941b867e

Options
    • -2
    • +1
    /Core/Components/src/Core.Components.OxyPlot.Forms/ChartControl.cs
    • -2
    • +6
    /Ringtoets/MacroStabilityInwards/src/Ringtoets.MacroStabilityInwards.Forms/Views/MacroStabilityInwardsOutputChartControl.cs
    • -1
    • +0
    /Ringtoets/MacroStabilityInwards/src/Ringtoets.MacroStabilityInwards.Forms/Views/MacroStabilityInwardsOutputView.cs
Thursday 19 Oct 2017
4:49 pm

Dennis Tang <dennis.tang@deltares.nl>

Converted the TestMacroStabilityInwardsOutput test object to a test factory: - Created objects are to be used for asserting composite objects that can clone. These asserts should be preferably done with the original object rather than a derived (test) object

Related to Issue [WTI-1366]

git-svn-id: https://repos.deltares.nl/repos/WettelijkToetsInstrumentarium/trunk@12260 5a3db67b-de53-47b5-99c8-a1c30a6650e2

Former-commit-id: 9692ca616baffd96345a37e0f605fc8573337e86

Former-commit-id: 9abe379937333a2a121c54329d4dc57ee5d128a3

Options
    • -1
    • +1
    /Application/Ringtoets/test/Application.Ringtoets.Storage.Test/Create/MacroStabilityInwards/MacroStabilityInwardsCalculationScenarioCreateExtensionsTest.cs
    • -1
    • +1
    /Application/Ringtoets/test/Application.Ringtoets.Storage.TestUtil/RingtoetsProjectTestHelper.cs
    • -4
    • +4
    /Ringtoets/MacroStabilityInwards/test/Ringtoets.MacroStabilityInwards.Data.Test/MacroStabilityInwardsCalculationScenarioTest.cs
    • -2
    • +2
    /Ringtoets/MacroStabilityInwards/test/Ringtoets.MacroStabilityInwards.Data.Test/MacroStabilityInwardsCalculationTest.cs
    • -0
    • +78
    /Ringtoets/MacroStabilityInwards/test/Ringtoets.MacroStabilityInwards.Data.TestUtil.Test/MacroStabilityInwardsOutputTestFactoryTest.cs
    • -1
    • +1
    /Ringtoets/MacroStabilityInwards/test/Ringtoets.MacroStabilityInwards.Data.TestUtil.Test/Ringtoets.MacroStabilityInwards.Data.TestUtil.Test.csproj
    • -73
    • +0
    /Ringtoets/MacroStabilityInwards/test/Ringtoets.MacroStabilityInwards.Data.TestUtil.Test/TestMacroStabilityInwardsOutputTest.cs
    • -1
    • +1
    /Ringtoets/MacroStabilityInwards/test/Ringtoets.MacroStabilityInwards.Data.TestUtil/MacroStabilityInwardsCalculationScenarioFactory.cs
    • -0
    • +59
    /Ringtoets/MacroStabilityInwards/test/Ringtoets.MacroStabilityInwards.Data.TestUtil/MacroStabilityInwardsOutputTestFactory.cs
    • -4
    • +4
    /Ringtoets/MacroStabilityInwards/test/Ringtoets.MacroStabilityInwards.Data.TestUtil/MacroStabilityInwardsTestDataGenerator.cs
    • -1
    • +1
    /Ringtoets/MacroStabilityInwards/test/Ringtoets.MacroStabilityInwards.Data.TestUtil/Ringtoets.MacroStabilityInwards.Data.TestUtil.csproj
    • -54
    • +0
    /Ringtoets/MacroStabilityInwards/test/Ringtoets.MacroStabilityInwards.Data.TestUtil/TestMacroStabilityInwardsOutput.cs
    • -2
    • +2
    /Ringtoets/MacroStabilityInwards/test/Ringtoets.MacroStabilityInwards.Forms.Test/Views/MacroStabilityInwardsCalculationRowTest.cs
    • -2
    • +2
    /Ringtoets/MacroStabilityInwards/test/Ringtoets.MacroStabilityInwards.Forms.Test/Views/MacroStabilityInwardsCalculationsViewTest.cs
    • -4
    • +4
    /Ringtoets/MacroStabilityInwards/test/Ringtoets.MacroStabilityInwards.Forms.Test/Views/MacroStabilityInwardsOutputViewTest.cs
  16. … 17 more files in changeset.
4:38 pm

Elmar Kleijn

Review related changes

Paired with tang_ds

Related to Issue [WTI-1340]

git-svn-id: https://repos.deltares.nl/repos/WettelijkToetsInstrumentarium/trunk@12259 5a3db67b-de53-47b5-99c8-a1c30a6650e2

Former-commit-id: d86e200c9cf7a7619b5d2ebd4d842deddc1c3e38

Former-commit-id: 0b53279071881b6a26322b110f9c9b408ce12f38

Options
    • -19
    • +8
    /Ringtoets/Common/src/Ringtoets.Common.IO/Properties/Resources.Designer.cs
    • -4
    • +0
    /Ringtoets/Common/src/Ringtoets.Common.IO/Properties/Resources.resx
    • -4
    • +4
    /Ringtoets/Common/src/Ringtoets.Common.IO/SoilProfile/SoilLayer2D.cs
    • -41
    • +0
    /Ringtoets/MacroStabilityInwards/src/Ringtoets.MacroStabilityInwards.IO/Properties/Resources.Designer.cs
    • -13
    • +0
    /Ringtoets/MacroStabilityInwards/src/Ringtoets.MacroStabilityInwards.IO/Properties/Resources.resx
4:12 pm

Marten Janssen <marten.janssen@deltares.nl>

- Removed TrafficLoadInside and TrafficLoadOutside from our data model. - - Only the CharacteristicPointsCsvReader in Ringtoets.Common.IO.SurfaceLines has knowledge of the existence of these traffic load properties Related to Issue [WTI-1443]

git-svn-id: https://repos.deltares.nl/repos/WettelijkToetsInstrumentarium/trunk@12258 5a3db67b-de53-47b5-99c8-a1c30a6650e2

Former-commit-id: 81160300b03498fde6c5dd16d23a54992961ea78

Former-commit-id: 18cd599b8704c1b45334953e1fbe944524939564

Options
    • -2
    • +2
    /Application/Ringtoets/src/Application.Ringtoets.Migration.Core/EmbeddedResources/DatabaseStructure17.2.sql
    • -2
    • +0
    /Application/Ringtoets/src/Application.Ringtoets.Storage/Create/MacroStabilityInwards/MacroStabilityInwardsSurfaceLineCreateExtensions.cs
    • -19
    • +9
    /Application/Ringtoets/src/Application.Ringtoets.Storage/DbContext/MacroStabilityInwardsCharacteristicPointType.cs
    • -81
    • +81
    /Application/Ringtoets/src/Application.Ringtoets.Storage/DbContext/RingtoetsEntities.edmx.diagram
    • -6
    • +0
    /Application/Ringtoets/src/Application.Ringtoets.Storage/Read/SurfaceLineEntityReadExtensions.cs
    • -7
    • +5
    /Application/Ringtoets/test/Application.Ringtoets.Storage.Test/Create/MacroStabilityInwards/MacroStabilityInwardsFailureMechanismCreateExtensionsTest.cs
    • -31
    • +13
    /Application/Ringtoets/test/Application.Ringtoets.Storage.Test/Create/MacroStabilityInwards/MacroStabilityInwardsSurfaceLineCreateExtensionsTest.cs
    • -2
    • +0
    /Application/Ringtoets/test/Application.Ringtoets.Storage.Test/IntegrationTests/StorageSqLiteIntegrationTest.cs
    • -37
    • +21
    /Application/Ringtoets/test/Application.Ringtoets.Storage.Test/Read/SurfaceLineEntityReadExtensionsTest.cs
    • -7
    • +3
    /Application/Ringtoets/test/Application.Ringtoets.Storage.TestUtil.Test/RingtoetsProjectTestHelperTest.cs
    • -7
    • +3
    /Application/Ringtoets/test/Application.Ringtoets.Storage.TestUtil/RingtoetsProjectTestHelper.cs
    • -18
    • +0
    /Ringtoets/Common/src/Ringtoets.Common.Data/Properties/Resources.Designer.cs
    • -6
    • +0
    /Ringtoets/Common/src/Ringtoets.Common.Data/Properties/Resources.resx
    • -18
    • +0
    /Ringtoets/Common/src/Ringtoets.Common.Forms/Properties/Resources.Designer.cs
    • -6
    • +0
    /Ringtoets/Common/src/Ringtoets.Common.Forms/Properties/Resources.resx
  16. … 19 more files in changeset.
4:01 pm

Dennis Tang <dennis.tang@deltares.nl>

Converted the TestMacroStabilityInwardsSemiProbabilisticOutput test object to a test factory: - Created objects are to be used for asserting composite objects that can clone. These asserts should be preferably done with the original object rather than a derived (test) object - Added test class Related to Issue [WTI-1366]

git-svn-id: https://repos.deltares.nl/repos/WettelijkToetsInstrumentarium/trunk@12257 5a3db67b-de53-47b5-99c8-a1c30a6650e2

Former-commit-id: 5e2c6799a5a83569ca93d3c253dbe99043f93213

Former-commit-id: 8f8e4f479c2b0fb04a31740690f9cfd710f91b77

Options
    • -1
    • +1
    /Application/Ringtoets/test/Application.Ringtoets.Storage.Test/Create/MacroStabilityInwards/MacroStabilityInwardsCalculationScenarioCreateExtensionsTest.cs
    • -3
    • +3
    /Ringtoets/MacroStabilityInwards/test/Ringtoets.MacroStabilityInwards.Data.Test/MacroStabilityInwardsCalculationScenarioTest.cs
    • -2
    • +2
    /Ringtoets/MacroStabilityInwards/test/Ringtoets.MacroStabilityInwards.Data.Test/MacroStabilityInwardsCalculationTest.cs
    • -0
    • +73
    /Ringtoets/MacroStabilityInwards/test/Ringtoets.MacroStabilityInwards.Data.TestUtil.Test/MacroStabilityInwardsSemiProbabilisticTestFactoryTest.cs
    • -0
    • +1
    /Ringtoets/MacroStabilityInwards/test/Ringtoets.MacroStabilityInwards.Data.TestUtil.Test/Ringtoets.MacroStabilityInwards.Data.TestUtil.Test.csproj
    • -0
    • +40
    /Ringtoets/MacroStabilityInwards/test/Ringtoets.MacroStabilityInwards.Data.TestUtil/MacroStabilityInwardsSemiProbabilisticOutputTestFactory.cs
    • -4
    • +4
    /Ringtoets/MacroStabilityInwards/test/Ringtoets.MacroStabilityInwards.Data.TestUtil/MacroStabilityInwardsTestDataGenerator.cs
    • -1
    • +1
    /Ringtoets/MacroStabilityInwards/test/Ringtoets.MacroStabilityInwards.Data.TestUtil/Ringtoets.MacroStabilityInwards.Data.TestUtil.csproj
    • -36
    • +0
    /Ringtoets/MacroStabilityInwards/test/Ringtoets.MacroStabilityInwards.Data.TestUtil/TestMacroStabilityInwardsSemiProbabilisticOutput.cs
    • -3
    • +3
    /Ringtoets/MacroStabilityInwards/test/Ringtoets.MacroStabilityInwards.Forms.Test/PropertyClasses/MacroStabilityInwardsOutputContextPropertiesTest.cs
    • -1
    • +1
    /Ringtoets/MacroStabilityInwards/test/Ringtoets.MacroStabilityInwards.Integration.Test/MacroStabilityInwardsFailureMechanismResultViewIntegrationTest.cs
    • -5
    • +5
    /Ringtoets/MacroStabilityInwards/test/Ringtoets.MacroStabilityInwards.Plugin.Test/FileImporter/MacroStabilityInwardsSurfaceLineUpdateDataStrategyTest.cs
    • -1
    • +1
    /Ringtoets/MacroStabilityInwards/test/Ringtoets.MacroStabilityInwards.Plugin.Test/PropertyInfos/MacroStabilityInwardsOutputContextPropertyInfoTest.cs
    • -4
    • +4
    /Ringtoets/MacroStabilityInwards/test/Ringtoets.MacroStabilityInwards.Plugin.Test/TreeNodeInfos/MacroStabilityInwardsCalculationGroupContextTreeNodeInfoTest.cs
    • -3
    • +3
    /Ringtoets/MacroStabilityInwards/test/Ringtoets.MacroStabilityInwards.Plugin.Test/TreeNodeInfos/MacroStabilityInwardsCalculationScenarioContextTreeNodeInfoTest.cs
  16. … 3 more files in changeset.
4:01 pm

Carlos Lubbers

Fix failing tests in MacroStabilityInwardsSoilLayerDataTableTest Related to Issue [WTI-1298]

git-svn-id: https://repos.deltares.nl/repos/WettelijkToetsInstrumentarium/trunk@12256 5a3db67b-de53-47b5-99c8-a1c30a6650e2

Former-commit-id: 816d35f7a0a7787ab0b17603a56743bf3c0489bb

Former-commit-id: f7dc6886fa3175f65ae13951269ed743fe4cfcb2

Options
    • -44
    • +39
    /Ringtoets/MacroStabilityInwards/test/Ringtoets.MacroStabilityInwards.Forms.Test/Views/MacroStabilityInwardsSoilLayerDataTableTest.cs
3:44 pm

Elmar Kleijn

Review related changes

Paired with lubbers

Related to Issue [WTI-1296]

git-svn-id: https://repos.deltares.nl/repos/WettelijkToetsInstrumentarium/trunk@12254 5a3db67b-de53-47b5-99c8-a1c30a6650e2

Former-commit-id: 5c4a46e1d66b7800f9ed08553d778b934cb22d64

Former-commit-id: 0a6b147ffd1825a5a12160ddabbd540080cfa91c

Options
    • -3
    • +3
    /Ringtoets/Common/test/Ringtoets.Common.Service.Test/CalculationServiceHelperTest.cs
3:38 pm

Dennis Tang <dennis.tang@deltares.nl>

- Implemented .Clone() for the MacroStabilityInwardsInput -- Expanded input test with a variant where none of the properties are set - Added assert to assert clones of MacroStabilityInwardsCalculation objects

Related to Issue [WTI-1366]

git-svn-id: https://repos.deltares.nl/repos/WettelijkToetsInstrumentarium/trunk@12253 5a3db67b-de53-47b5-99c8-a1c30a6650e2

Former-commit-id: a7e3c74824dd8030f5927b05045e9969b501a8ca

Former-commit-id: cc4c3aff74e1b5dfb2f236f33c6c4dc731a0f63f

Options
    • -1
    • +14
    /Ringtoets/MacroStabilityInwards/test/Ringtoets.MacroStabilityInwards.Data.Test/MacroStabilityInwardsInputTest.cs
    • -0
    • +19
    /Ringtoets/MacroStabilityInwards/test/Ringtoets.MacroStabilityInwards.Data.TestUtil/MacroStabilityInwardsCloneAssert.cs
3:20 pm

Dennis Tang <dennis.tang@deltares.nl>

- Implemented .Clone() for the MacroStabilityInwardsInput and its derived classes -- Added helper in the clone assert - Added missing asserts in the CreateExtensions for MacroStabilityInwardsCalculationScenario Related to Issue [WTI-1366]

git-svn-id: https://repos.deltares.nl/repos/WettelijkToetsInstrumentarium/trunk@12252 5a3db67b-de53-47b5-99c8-a1c30a6650e2

Former-commit-id: e373eaec8dec7739fb5f1ea3a79950d6785fccc1

Former-commit-id: 6472a83d5430723a59a80b0cc7f97579997fcecf

Options
    • -0
    • +2
    /Application/Ringtoets/test/Application.Ringtoets.Storage.Test/Create/MacroStabilityInwards/MacroStabilityInwardsCalculationScenarioCreateExtensionsTest.cs
    • -5
    • +15
    /Ringtoets/MacroStabilityInwards/src/Ringtoets.MacroStabilityInwards.Data/MacroStabilityInwardsInput.cs
    • -1
    • +101
    /Ringtoets/MacroStabilityInwards/test/Ringtoets.MacroStabilityInwards.Data.Test/MacroStabilityInwardsInputTest.cs
    • -2
    • +65
    /Ringtoets/MacroStabilityInwards/test/Ringtoets.MacroStabilityInwards.Data.TestUtil/MacroStabilityInwardsCloneAssert.cs