Riskeer

Clone Tools

Stats

Commits this week: 0
Total Committers: 28
Last Commit: 26 Nov
Commits this week: 0

Lines of code count not available

Commit Activity

Commits By Day In Week
52 week commits volume
Commits By Day In Week
Commits by day
Commits By Day In Week
Commits by hour
Commits By Hour In Day
Commit calendar
 

Most active committers (90 days)

loading
loading
  • last updated a few seconds ago
All Commits Reviews
Constraints
Constraints: committers
 
Constraints: files
Constraints: dates
Monday 27 May 2024
1:59 pm

Elmar Kleijn

Fixing rounding problems in piping. WTI-2875

Options
    • -8
    • +11
    /Riskeer/Piping/test/Riskeer.Piping.Data.Test/DerivedPipingInputTest.cs
1:57 pm

Dennis Tang <dennis.tang@deltares.nl>

WTI-2871: Incorporated review comments:

- Updated Piping view implementation

-- Updated alignments

Options
    • -1
    • +1
    /Riskeer/Piping/src/Riskeer.Piping.Forms/Views/PipingScenariosView.Designer.cs
1:50 pm

Elmar Kleijn

Revert "Fixing rounding problems in piping. WTI-2875"

This reverts commit cde550e73604bdfbe79365267872d58baab8d7dc.

Options
    • -2
    • +2
    /Riskeer/Piping/test/Riskeer.Piping.Data.Test/DerivedPipingInputTest.cs
1:50 pm

Elmar Kleijn

Revert "Fixing rounding problems in piping. WTI-2875"

This reverts commit 46ae7ec812202bd25a814b3ff94823a1c95201e9.

Options
    • -5
    • +2
    /Riskeer/Piping/test/Riskeer.Piping.Data.Test/DerivedPipingInputTest.cs
1:48 pm

Dennis Tang <dennis.tang@deltares.nl>

WTI-2871: Incorporated review comments:

- Updated Piping view implementation

Options
    • -23
    • +23
    /Riskeer/Piping/src/Riskeer.Piping.Forms/Views/PipingScenariosView.Designer.cs
    • -21
    • +16
    /Riskeer/Piping/src/Riskeer.Piping.Forms/Views/PipingScenariosView.cs
1:31 pm

Elmar Kleijn

Fixing rounding problems in piping. WTI-2875

Options
    • -2
    • +5
    /Riskeer/Piping/test/Riskeer.Piping.Data.Test/DerivedPipingInputTest.cs
1:30 pm

Dennis Tang <dennis.tang@deltares.nl>

WTI-2871: Incorporated review comments:

- Updated Piping view implementation

Options
    • -7
    • +9
    /Riskeer/Piping/src/Riskeer.Piping.Forms/Views/PipingScenariosView.cs
    • -5
    • +0
    /Riskeer/Piping/test/Riskeer.Piping.Forms.Test/Views/PipingScenariosViewTest.cs
12:39 pm

Elmar Kleijn

Fixing rounding problems in piping. WTI-2875

Options
    • -2
    • +2
    /Riskeer/Piping/test/Riskeer.Piping.Data.Test/DerivedPipingInputTest.cs
12:31 pm

Elmar Kleijn

Fixing rounding problems in piping. WTI-2875

Options
    • -2
    • +2
    /Riskeer/Piping/src/Riskeer.Piping.Data/DerivedPipingInput.cs
12:16 pm

Dennis Tang <dennis.tang@deltares.nl>

WTI-2871: Incorporated review comments:

- Cleanup failure mechanism data implementations

Options
    • -2
    • +3
    /Riskeer/MacroStabilityInwards/test/Riskeer.MacroStabilityInwards.Data.Test/MacroStabilityInwardsFailureMechanismTest.cs
    • -1
    • +1
    /Riskeer/Piping/src/Riskeer.Piping.Data/PipingScenarioConfigurationPerFailureMechanismSection.cs
    • -2
    • +2
    /Riskeer/Piping/test/Riskeer.Piping.Data.Test/PipingFailureMechanismTest.cs
11:11 am

Dennis Tang <dennis.tang@deltares.nl>

WTI-2871: Incorporated review comments:

- Cleanup

Options
    • -1
    • +1
    /Riskeer/Common/src/Riskeer.Common.Data/FailureMechanism/ScenarioConfigurationPerFailureMechanismSection.cs
    • -24
    • +10
    /Riskeer/Common/test/Riskeer.Common.Data.Test/FailureMechanism/ScenarioConfigurationPerFailureMechanismSectionTest.cs
    • -0
    • +40
    /Riskeer/Common/test/Riskeer.Common.Data.Test/FailureMechanism/TestScenarioConfigurationPerFailureMechanismSection.cs
    • -5
    • +1
    /Riskeer/Common/test/Riskeer.Common.Data.Test/Probability/ScenarioConfigurationPerFailureMechanismSectionExtensionsTest.cs
11:11 am

Dennis Tang <dennis.tang@deltares.nl>

WTI-2871: Incorporated review comments:

- Fixed implementation to cope with whitespace at leading string

Options
    • -3
    • +4
    /Riskeer/Common/src/Riskeer.Common.Forms/Helpers/ProbabilityParsingHelper.cs
    • -9
    • +12
    /Riskeer/Common/test/Riskeer.Common.Forms.Test/Helpers/ProbabilityParsingHelperTest.cs
10:46 am

Dennis Tang <dennis.tang@deltares.nl>

WTI-2871: Incorporated review comments:

- Wired helper to the converter

Options
    • -16
    • +5
    /Core/Common/src/Core.Common.Base/TypeConverters/RoundedDoubleConverter.cs
    • -6
    • +6
    /Core/Common/test/Core.Common.Base.Test/TypeConverters/RoundedDoubleConverterTest.cs
    • -8
    • +8
    /Riskeer/Common/test/Riskeer.Common.Forms.Test/TypeConverters/NoProbabilityValueDoubleConverterTest.cs
10:41 am

Dennis Tang <dennis.tang@deltares.nl>

WTI-2871: Incorporated review comments:

- Adjusted parsing helper to contain same logic as the converter

Options
    • -3
    • +3
    /Core/Common/src/Core.Common.Base/Helpers/DoubleParsingHelper.cs
    • -28
    • +27
    /Core/Common/src/Core.Common.Base/Properties/Resources.Designer.cs
    • -3
    • +3
    /Core/Common/src/Core.Common.Base/Properties/Resources.resx
    • -3
    • +3
    /Core/Common/src/Core.Common.Base/TypeConverters/RoundedDoubleConverter.cs
    • -20
    • +25
    /Core/Common/test/Core.Common.Base.Test/Helpers/DoubleParsingHelperTest.cs
10:23 am

Dennis Tang <dennis.tang@deltares.nl>

WTI-2871: Incorporated review comments:

- Cleanup

Options
    • -1
    • +1
    /Riskeer/Common/src/Riskeer.Common.Forms/Helpers/ProbabilityParsingHelper.cs
    • -18
    • +9
    /Riskeer/Common/src/Riskeer.Common.Forms/Properties/Resources.Designer.cs
    • -4
    • +1
    /Riskeer/Common/src/Riskeer.Common.Forms/Properties/Resources.resx
10:21 am

Dennis Tang <dennis.tang@deltares.nl>

WTI-2871: Incorporated review comments:

- Moved parsing helper

Options
    • -0
    • +69
    /Core/Common/src/Core.Common.Base/Exceptions/DoubleParsingException.cs
    • -0
    • +65
    /Core/Common/src/Core.Common.Base/Helpers/DoubleParsingHelper.cs
    • -0
    • +32
    /Core/Common/test/Core.Common.Base.Test/Exceptions/DoubleParsingExceptionTest.cs
    • -0
    • +119
    /Core/Common/test/Core.Common.Base.Test/Helpers/DoubleParsingHelperTest.cs
    • -69
    • +0
    /Riskeer/Common/src/Riskeer.Common.Forms/Exceptions/DoubleParsingException.cs
    • -62
    • +0
    /Riskeer/Common/src/Riskeer.Common.Forms/Helpers/DoubleParsingHelper.cs
    • -32
    • +0
    /Riskeer/Common/test/Riskeer.Common.Forms.Test/Exceptions/DoubleParsingExceptionTest.cs
    • -119
    • +0
    /Riskeer/Common/test/Riskeer.Common.Forms.Test/Helpers/DoubleParsingHelperTest.cs
    • -3
    • +3
    /Riskeer/MacroStabilityInwards/src/Riskeer.MacroStabilityInwards.Forms/Views/MacroStabilityInwardsScenariosView.cs
    • -2
    • +2
    /Riskeer/Piping/src/Riskeer.Piping.Forms/Views/PipingScenariosView.cs
8:59 am

Dennis Tang <dennis.tang@deltares.nl>

WTI-2871: Incorporated review comments

Options
    • -1
    • +1
    /Riskeer/Common/src/Riskeer.Common.Forms/Helpers/DoubleParsingHelper.cs
    • -1
    • +1
    /Riskeer/Common/src/Riskeer.Common.Forms/Helpers/ProbabilityParsingHelper.cs
    • -2
    • +2
    /Riskeer/Common/src/Riskeer.Common.Forms/Properties/Resources.Designer.cs
    • -1
    • +1
    /Riskeer/Common/src/Riskeer.Common.Forms/Properties/Resources.resx
8:41 am

Dennis Tang <dennis.tang@deltares.nl>

WTI-2871: Incorporated review comments:

- Renamed parsing helper to work on doubles

-- Adjusted logic

Options
    • -6
    • +4
    /Riskeer/Common/src/Riskeer.Common.Forms/Helpers/DoubleParsingHelper.cs
    • -34
    • +20
    /Riskeer/Common/test/Riskeer.Common.Forms.Test/Helpers/DoubleParsingHelperTest.cs
    • -1
    • +1
    /Riskeer/MacroStabilityInwards/src/Riskeer.MacroStabilityInwards.Forms/Views/MacroStabilityInwardsScenariosView.cs
    • -1
    • +1
    /Riskeer/Piping/src/Riskeer.Piping.Forms/Views/PipingScenariosView.cs
8:06 am

Dennis Tang <dennis.tang@deltares.nl>

WTI-2871: Incorporated review comments:

- Renamed parsing helper to work on doubles

Options
    • -0
    • +64
    /Riskeer/Common/src/Riskeer.Common.Forms/Helpers/DoubleParsingHelper.cs
    • -64
    • +0
    /Riskeer/Common/src/Riskeer.Common.Forms/Helpers/RoundedDoubleParsingHelper.cs
    • -0
    • +133
    /Riskeer/Common/test/Riskeer.Common.Forms.Test/Helpers/DoubleParsingHelperTest.cs
    • -133
    • +0
    /Riskeer/Common/test/Riskeer.Common.Forms.Test/Helpers/RoundedDoubleParsingHelperTest.cs
    • -1
    • +1
    /Riskeer/MacroStabilityInwards/src/Riskeer.MacroStabilityInwards.Forms/Views/MacroStabilityInwardsScenariosView.cs
    • -1
    • +1
    /Riskeer/Piping/src/Riskeer.Piping.Forms/Views/PipingScenariosView.cs
7:36 am

Dennis Tang <dennis.tang@deltares.nl>

WTI-2871: Incorporated review comments:

- Changed name of the excception

Options
    • -0
    • +69
    /Riskeer/Common/src/Riskeer.Common.Forms/Exceptions/DoubleParsingException.cs
    • -69
    • +0
    /Riskeer/Common/src/Riskeer.Common.Forms/Exceptions/RoundedDoubleParsingException.cs
    • -3
    • +3
    /Riskeer/Common/src/Riskeer.Common.Forms/Helpers/RoundedDoubleParsingHelper.cs
    • -1
    • +1
    /Riskeer/Common/test/Riskeer.Common.Forms.Test/Exceptions/DoubleParsingExceptionTest.cs
    • -2
    • +2
    /Riskeer/Common/test/Riskeer.Common.Forms.Test/Helpers/RoundedDoubleParsingHelperTest.cs
    • -1
    • +1
    /Riskeer/MacroStabilityInwards/src/Riskeer.MacroStabilityInwards.Forms/Views/MacroStabilityInwardsScenariosView.cs
    • -1
    • +1
    /Riskeer/Piping/src/Riskeer.Piping.Forms/Views/PipingScenariosView.cs
7:36 am

Dennis Tang <dennis.tang@deltares.nl>

WTI-2871: Incorporated review comments

Options
    • -6
    • +4
    /Riskeer/Common/src/Riskeer.Common.Data/FailureMechanism/ScenarioConfigurationPerFailureMechanismSection.cs
    • -3
    • +3
    /Riskeer/Common/src/Riskeer.Common.Data/Probability/ScenarioConfigurationPerFailureMechanismSectionExtensions.cs
    • -16
    • +43
    /Riskeer/Common/test/Riskeer.Common.Data.Test/FailureMechanism/ScenarioConfigurationPerFailureMechanismSectionTest.cs
7:14 am

Dennis Tang <dennis.tang@deltares.nl>

WTI-2871: Moving B parameter

- Make the probability assessment input obsolete as there is only one readonly property present

Options
    • -0
    • +7
    /Riskeer/MacroStabilityInwards/src/Riskeer.MacroStabilityInwards.Data/GeneralMacroStabilityInwardsInput.cs
    • -0
    • +1
    /Riskeer/MacroStabilityInwards/test/Riskeer.MacroStabilityInwards.Data.Test/GeneralMacroStabilityInwardsInputTest.cs
    • -0
    • +11
    /Riskeer/Piping/src/Riskeer.Piping.Data/GeneralPipingInput.cs
    • -0
    • +1
    /Riskeer/Piping/test/Riskeer.Piping.Data.Test/GeneralPipingInputTest.cs
Friday 24 May 2024
3:52 pm

Dennis Tang <dennis.tang@deltares.nl>

WTI-2871: Adapted MacroStabilityInwards view:

- Fixed failing test

Options
    • -1
    • +0
    /Riskeer/MacroStabilityInwards/test/Riskeer.MacroStabilityInwards.Forms.Test/Views/MacroStabilityInwardsScenariosViewTest.cs
3:29 pm

Dennis Tang <dennis.tang@deltares.nl>

WTI-2871: Adapted Piping view:

- Cleaned up test

Options
    • -9
    • +0
    /Riskeer/Piping/src/Riskeer.Piping.Forms/Properties/Resources.Designer.cs
    • -3
    • +0
    /Riskeer/Piping/src/Riskeer.Piping.Forms/Properties/Resources.resx
    • -1
    • +1
    /Riskeer/Piping/src/Riskeer.Piping.Forms/Views/PipingScenariosView.Designer.cs
    • -13
    • +11
    /Riskeer/Piping/test/Riskeer.Piping.Forms.Test/Views/PipingScenariosViewTest.cs
3:24 pm

Dennis Tang <dennis.tang@deltares.nl>

WTI-2871: Adapted MacroStabilityInwards view:

- Added tests

Options
    • -32
    • +882
    /Riskeer/MacroStabilityInwards/test/Riskeer.MacroStabilityInwards.Forms.Test/Views/MacroStabilityInwardsScenariosViewTest.cs
3:03 pm

Dennis Tang <dennis.tang@deltares.nl>

WTI-2871: Adapted Piping view:

- Adjusted test name

Options
    • -1
    • +1
    /Riskeer/Piping/test/Riskeer.Piping.Forms.Test/Views/PipingScenariosViewTest.cs
10:08 am

Dennis Tang <dennis.tang@deltares.nl>

WTI-2871: Adapted Piping view:

- Always disable the NRounded textbox

Options
    • -0
    • +1
    /Riskeer/Piping/src/Riskeer.Piping.Forms/Views/PipingScenariosView.Designer.cs
    • -2
    • +0
    /Riskeer/Piping/src/Riskeer.Piping.Forms/Views/PipingScenariosView.cs
    • -4
    • +1
    /Riskeer/Piping/test/Riskeer.Piping.Forms.Test/Views/PipingScenariosViewTest.cs
Thursday 23 May 2024
4:07 pm

Dennis Tang <dennis.tang@deltares.nl>

WTI-2871: Adapted Piping view:

- Updated assert

Options
    • -2
    • +2
    /Riskeer/Piping/test/Riskeer.Piping.Forms.Test/Views/PipingScenariosViewTest.cs
4:07 pm

Dennis Tang <dennis.tang@deltares.nl>

WTI-2871: Adapted MacroStabilityInwards view:

- Added initial test

- Fixed logic for updating the length effect data

Options
    • -0
    • +1
    /Riskeer/MacroStabilityInwards/src/Riskeer.MacroStabilityInwards.Forms/Views/MacroStabilityInwardsScenariosView.cs
    • -11
    • +273
    /Riskeer/MacroStabilityInwards/test/Riskeer.MacroStabilityInwards.Forms.Test/Views/MacroStabilityInwardsScenariosViewTest.cs
2:55 pm

Dennis Tang <dennis.tang@deltares.nl>

WTI-2871: Adapted MacroStabilityInwards view:

- Added logic for the length effect controls

- Updated layout

Options
    • -2
    • +5
    /Riskeer/MacroStabilityInwards/src/Riskeer.MacroStabilityInwards.Forms/Views/MacroStabilityInwardsScenariosView.Designer.cs
    • -6
    • +113
    /Riskeer/MacroStabilityInwards/src/Riskeer.MacroStabilityInwards.Forms/Views/MacroStabilityInwardsScenariosView.cs