Riskeer

Clone Tools

Stats

Commits this week: 0
Total Committers: 28
Last Commit: 26 Nov
Commits this week: 0

Lines of code count not available

Commit Activity

Commits By Day In Week
52 week commits volume
Commits By Day In Week
Commits by day
Commits By Day In Week
Commits by hour
Commits By Hour In Day
Commit calendar
 

Most active committers (90 days)

loading
loading
  • last updated a few seconds ago
All Commits Reviews
Constraints
Constraints: committers
 
Constraints: files
Constraints: dates
Thursday 02 Aug 2018
12:17 pm

Carlos Lubbers

Implement review comments WTI-1752

Options
    • -4
    • +10
    /Ringtoets/Common/src/Ringtoets.Common.IO/FileImporters/FailureMechanismSectionReplaceStrategy.cs
    • -5
    • +11
    /Ringtoets/Common/src/Ringtoets.Common.IO/FileImporters/FailureMechanismSectionUpdateStrategy.cs
    • -9
    • +10
    /Ringtoets/Common/src/Ringtoets.Common.IO/FileImporters/FailureMechanismSectionsImporter.cs
    • -0
    • +2
    /Ringtoets/Common/src/Ringtoets.Common.IO/FileImporters/IFailureMechanismSectionResultUpdateStrategy.cs
    • -0
    • +8
    /Ringtoets/Common/src/Ringtoets.Common.IO/FileImporters/IFailureMechanismSectionUpdateStrategy.cs
    • -2
    • +84
    /Ringtoets/Common/test/Ringtoets.Common.Forms.Test/UpdateInfos/RingtoetsUpdateInfoFactoryTest.cs
    • -0
    • +66
    /Ringtoets/Common/test/Ringtoets.Common.IO.Test/FileImporters/FailureMechanismSectionReplaceStrategyTest.cs
    • -38
    • +105
    /Ringtoets/Common/test/Ringtoets.Common.IO.Test/FileImporters/FailureMechanismSectionUpdateStrategyTest.cs
    • -102
    • +38
    /Ringtoets/Common/test/Ringtoets.Common.IO.Test/FileImporters/FailureMechanismSectionsImporterTest.cs
    • -2
    • +0
    /Ringtoets/Piping/src/Ringtoets.Piping.Plugin/FileImporter/PipingFailureMechanismSectionResultUpdateStrategy.cs
11:24 am

Dennis Tang <dennis.tang@deltares.nl>

Incorporated comments review 3139:

- Improved tests

Paired with ~carloslubbers

WTI-1751

Options
    • -0
    • +1
    /Ringtoets/Common/test/Ringtoets.Common.Data.Test/FailureMechanism/FailureMechanismBaseTest.cs
    • -6
    • +36
    /Ringtoets/Common/test/Ringtoets.Common.Data.Test/FailureMechanism/FailureMechanismSectionCollectionTest.cs
11:17 am

Robert Tangerman <robert.tangerman@deltares.nl>

Resubscribe failure mechanism observers when assessment section notified. WTI-1793

Options
    • -2
    • +29
    /Ringtoets/Integration/src/Ringtoets.Integration.Forms/Observers/AssessmentSectionResultObserver.cs
    • -0
    • +71
    /Ringtoets/Integration/test/Ringtoets.Integration.Forms.Test/Observers/AssessmentSectionResultObserverTest.cs
10:43 am

Carlos Lubbers

Use HydraulicBoundaryDatabaseConnectionValidator in structures service WTI-1720

Options
    • -1
    • +2
    /Ringtoets/ClosingStructures/test/Ringtoets.ClosingStructures.Integration.Test/ClosingStructuresCalculationActivityIntegrationTest.cs
    • -2
    • +1
    /Ringtoets/Common/src/Ringtoets.Common.Service/Structures/StructuresCalculationServiceBase.cs
    • -5
    • +35
    /Ringtoets/Common/test/Ringtoets.Common.Service.Test/Structures/StructuresCalculationServiceBaseTest.cs
    • -1
    • +2
    /Ringtoets/HeightStructures/test/Ringtoets.HeightStructures.Integration.Test/HeightStructuresCalculationActivityIntegrationTest.cs
    • -1
    • +1
    /Ringtoets/StabilityPointStructures/test/Ringtoets.StabilityPointStructures.Integration.Test/StabilityPointStructuresCalculationActivityIntegrationTest.cs
10:42 am

Carlos Lubbers

Cleanup WTI-1720

Options
    • -1
    • +1
    /Ringtoets/GrassCoverErosionInwards/test/Ringtoets.GrassCoverErosionInwards.Service.Test/GrassCoverErosionInwardsCalculationServiceTest.cs
    • -1
    • +1
    /Ringtoets/GrassCoverErosionOutwards/test/Ringtoets.GrassCoverErosionOutwards.Service.Test/GrassCoverErosionOutwardsWaveConditionsCalculationServiceTest.cs
    • -21
    • +24
    /Ringtoets/Revetment/test/Ringtoets.Revetment.Service.Test/WaveConditionsCalculationServiceBaseTest.cs
    • -1
    • +1
    /Ringtoets/StabilityStoneCover/test/Ringtoets.StabilityStoneCover.Service.Test/StabilityStoneCoverWaveConditionsCalculationServiceTest.cs
    • -1
    • +1
    /Ringtoets/WaveImpactAsphaltCover/test/Ringtoets.WaveImpactAsphaltCover.Service.Test/WaveImpactAsphaltCoverWaveConditionsCalculationServiceTest.cs
10:16 am

Carlos Lubbers

Use HydraulicBoundaryDatabaseConnectionValidator in AGK service WTI-1720

Options
    • -4
    • +2
    /Ringtoets/WaveImpactAsphaltCover/src/Ringtoets.WaveImpactAsphaltCover.Plugin/WaveImpactAsphaltCoverPlugin.cs
    • -3
    • +1
    /Ringtoets/WaveImpactAsphaltCover/src/Ringtoets.WaveImpactAsphaltCover.Service/WaveImpactAsphaltCoverWaveConditionsCalculationActivity.cs
    • -6
    • +3
    /Ringtoets/WaveImpactAsphaltCover/src/Ringtoets.WaveImpactAsphaltCover.Service/WaveImpactAsphaltCoverWaveConditionsCalculationService.cs
    • -1
    • +2
    /Ringtoets/WaveImpactAsphaltCover/test/Ringtoets.WaveImpactAsphaltCover.Integration.Test/WaveImpactAsphaltCoverWaveConditionsCalculationActivityIntegrationTest.cs
    • -21
    • +81
    /Ringtoets/WaveImpactAsphaltCover/test/Ringtoets.WaveImpactAsphaltCover.Service.Test/WaveImpactAsphaltCoverWaveConditionsCalculationServiceTest.cs
10:16 am

Carlos Lubbers

Use HydraulicBoundaryDatabaseConnectionValidator in ZST service WTI-1720

Options
    • -4
    • +2
    /Ringtoets/StabilityStoneCover/src/Ringtoets.StabilityStoneCover.Plugin/StabilityStoneCoverPlugin.cs
    • -3
    • +1
    /Ringtoets/StabilityStoneCover/src/Ringtoets.StabilityStoneCover.Service/StabilityStoneCoverWaveConditionsCalculationActivity.cs
    • -6
    • +3
    /Ringtoets/StabilityStoneCover/src/Ringtoets.StabilityStoneCover.Service/StabilityStoneCoverWaveConditionsCalculationService.cs
    • -1
    • +2
    /Ringtoets/StabilityStoneCover/test/Ringtoets.StabilityStoneCover.Integration.Test/StabilityStoneCoverWaveConditionsCalculationActivityIntegrationTest.cs
    • -21
    • +81
    /Ringtoets/StabilityStoneCover/test/Ringtoets.StabilityStoneCover.Service.Test/StabilityStoneCoverWaveConditionsCalculationServiceTest.cs
10:16 am

Carlos Lubbers

Use HydraulicBoundaryDatabaseConnectionValidator in GEBU service WTI-1720

Options
    • -4
    • +2
    /Ringtoets/GrassCoverErosionOutwards/src/Ringtoets.GrassCoverErosionOutwards.Plugin/GrassCoverErosionOutwardsPlugin.cs
    • -3
    • +1
    /Ringtoets/GrassCoverErosionOutwards/src/Ringtoets.GrassCoverErosionOutwards.Service/GrassCoverErosionOutwardsWaveConditionsCalculationActivity.cs
    • -6
    • +3
    /Ringtoets/GrassCoverErosionOutwards/src/Ringtoets.GrassCoverErosionOutwards.Service/GrassCoverErosionOutwardsWaveConditionsCalculationService.cs
    • -1
    • +2
    /Ringtoets/GrassCoverErosionOutwards/test/Ringtoets.GrassCoverErosionOutwards.Integration.Test/GrassCoverErosionOutwardsWaveConditionsCalculationActivityIntegrationTest.cs
    • -21
    • +81
    /Ringtoets/GrassCoverErosionOutwards/test/Ringtoets.GrassCoverErosionOutwards.Service.Test/GrassCoverErosionOutwardsWaveConditionsCalculationServiceTest.cs
    • -14
    • +14
    /Ringtoets/Revetment/src/Ringtoets.Revetment.Service/WaveConditionsCalculationServiceBase.cs
    • -34
    • +60
    /Ringtoets/Revetment/test/Ringtoets.Revetment.Service.Test/WaveConditionsCalculationServiceBaseTest.cs
9:42 am

Robert Tangerman <robert.tangerman@deltares.nl>

Merge branch '1792'

Options
    • -3
    • +2
    /Ringtoets/Integration/src/Ringtoets.Integration.Plugin/RingtoetsPlugin.cs
9:40 am

Robert Tangerman <robert.tangerman@deltares.nl>

Cleanup. WTI-1792

Options
    • -6
    • +6
    /Ringtoets/Integration/src/Ringtoets.Integration.Forms/Views/FailureMechanismContributionItemRow.cs
    • -1
    • +1
    /Ringtoets/Integration/src/Ringtoets.Integration.Forms/Views/FailureMechanismContributionView.cs
    • -1
    • +1
    /Ringtoets/Integration/test/Ringtoets.Integration.Forms.Test/Views/FailureMechanismContributionItemRowTest.cs
9:36 am

Robert Tangerman <robert.tangerman@deltares.nl>

Cleanup. WTI-1792

Options
    • -3
    • +1
    /Ringtoets/Integration/src/Ringtoets.Integration.Data/AssessmentSection.cs
    • -1
    • +1
    /Ringtoets/Integration/src/Ringtoets.Integration.Forms/PropertyClasses/StandAlone/StandAloneFailureMechanismProperties.cs
    • -4
    • +1
    /Ringtoets/Integration/src/Ringtoets.Integration.Forms/Views/FailureMechanismContributionView.cs
    • -3
    • +3
    /Ringtoets/Integration/test/Ringtoets.Integration.Forms.Test/Views/FailureMechanismContributionViewTest.cs
9:27 am

Elmar Kleijn

Review related changes. WTI-892

Options
    • -2
    • +1
    /Ringtoets/Common/test/Ringtoets.Common.IO.Test/DikeProfiles/DikeProfileDataTest.cs
9:12 am

Carlos Lubbers

Use HydraulicBoundaryDatabaseConnectionValidator in GEKB service WTI-1720

Options
    • -4
    • +3
    /Ringtoets/GrassCoverErosionInwards/src/Ringtoets.GrassCoverErosionInwards.Service/GrassCoverErosionInwardsCalculationService.cs
    • -1
    • +1
    /Ringtoets/GrassCoverErosionInwards/test/Ringtoets.GrassCoverErosionInwards.Integration.Test/GrassCoverErosionInwardsCalculationActivityIntegrationTest.cs
    • -2
    • +42
    /Ringtoets/GrassCoverErosionInwards/test/Ringtoets.GrassCoverErosionInwards.Service.Test/GrassCoverErosionInwardsCalculationServiceTest.cs
9:09 am

Robert Tangerman <robert.tangerman@deltares.nl>

Removed unused resources. WTI-1792

Options
    • -20
    • +0
    /Ringtoets/Common/src/Ringtoets.Common.Data/Properties/Resources.Designer.cs
    • -6
    • +0
    /Ringtoets/Common/src/Ringtoets.Common.Data/Properties/Resources.resx
8:54 am

Robert Tangerman <robert.tangerman@deltares.nl>

Removed contribution item. WTI-1792

Options
    • -143
    • +0
    /Ringtoets/Common/src/Ringtoets.Common.Data/Contribution/FailureMechanismContributionItem.cs
    • -1
    • +0
    /Ringtoets/Common/src/Ringtoets.Common.Data/Ringtoets.Common.Data.csproj
    • -205
    • +0
    /Ringtoets/Common/test/Ringtoets.Common.Data.Test/Contribution/FailureMechanismContributionItemTest.cs
    • -1
    • +0
    /Ringtoets/Common/test/Ringtoets.Common.Data.Test/Ringtoets.Common.Data.Test.csproj
    • -3
    • +2
    /Ringtoets/Integration/test/Ringtoets.Integration.Forms.Test/Views/FailureMechanismContributionViewTest.cs
8:51 am

Robert Tangerman <robert.tangerman@deltares.nl>

Cleaned FailureMechanismContribution. WTI-1792

Options
    • -25
    • +2
    /Ringtoets/Common/src/Ringtoets.Common.Data/Contribution/FailureMechanismContribution.cs
    • -241
    • +22
    /Ringtoets/Common/test/Ringtoets.Common.Data.Test/Contribution/FailureMechanismContributionTest.cs
8:45 am

Robert Tangerman <robert.tangerman@deltares.nl>

Removed redundant test factory method. WTI-1792

Options
    • -38
    • +1
    /Ringtoets/Common/test/Ringtoets.Common.Data.TestUtil.Test/FailureMechanismContributionTestFactoryTest.cs
    • -12
    • +0
    /Ringtoets/Common/test/Ringtoets.Common.Data.TestUtil/FailureMechanismContributionTestFactory.cs
    • -16
    • +4
    /Ringtoets/DuneErosion/test/Ringtoets.DuneErosion.Plugin.Test/TreeNodeInfos/DuneLocationCalculationsContextTreeNodeInfoTest.cs
8:43 am

Robert Tangerman <robert.tangerman@deltares.nl>

Removed unused construction parameters. WTI-1792

Options
    • -18
    • +2
    /Ringtoets/Common/src/Ringtoets.Common.Data/Contribution/FailureMechanismContribution.cs
    • -347
    • +22
    /Ringtoets/Common/test/Ringtoets.Common.Data.Test/Contribution/FailureMechanismContributionTest.cs
    • -4
    • +1
    /Ringtoets/Common/test/Ringtoets.Common.Data.TestUtil/AssessmentSectionHelper.cs
    • -3
    • +1
    /Ringtoets/Common/test/Ringtoets.Common.Data.TestUtil/AssessmentSectionStub.cs
    • -6
    • +2
    /Ringtoets/Common/test/Ringtoets.Common.Data.TestUtil/FailureMechanismContributionTestFactory.cs
    • -3
    • +1
    /Ringtoets/Integration/src/Ringtoets.Integration.Data/AssessmentSection.cs
8:36 am

Robert Tangerman <robert.tangerman@deltares.nl>

Update other failure mechanism contribution when changing composition. WTI-1792

Options
    • -3
    • +3
    /Ringtoets/Integration/src/Ringtoets.Integration.Data/AssessmentSection.cs
    • -0
    • +1
    /Ringtoets/Integration/test/Ringtoets.Integration.Data.Test/AssessmentSectionTest.cs
8:32 am

Robert Tangerman <robert.tangerman@deltares.nl>

Removed UpdateContributions method. WTI-1792

Options
    • -53
    • +0
    /Ringtoets/Common/src/Ringtoets.Common.Data/Contribution/FailureMechanismContribution.cs
8:31 am

Robert Tangerman <robert.tangerman@deltares.nl>

Fixed tests. WTI-1792

Options
    • -14
    • +0
    /Ringtoets/Common/test/Ringtoets.Common.Data.TestUtil.Test/AssessmentSectionStubTest.cs
    • -13
    • +0
    /Ringtoets/Common/test/Ringtoets.Common.Data.TestUtil.Test/FailureMechanismContributionTestFactoryTest.cs
8:29 am

Robert Tangerman <robert.tangerman@deltares.nl>

Fixed test. WTI-1792

Options
    • -2
    • +1
    /Ringtoets/Integration/test/Ringtoets.Integration.Forms.Test/Views/FailureMechanismContributionViewTest.cs
8:27 am

Robert Tangerman <robert.tangerman@deltares.nl>

Fixed tests. WTI-1792

Options
    • -107
    • +4
    /Ringtoets/Integration/test/Ringtoets.Integration.Data.Test/AssessmentSectionTest.cs
7:59 am

Robert Tangerman <robert.tangerman@deltares.nl>

Removed Distribution from FailureMechanismContribution. WTI-1792

Options
    • -11
    • +0
    /Ringtoets/Common/src/Ringtoets.Common.Data/Contribution/FailureMechanismContribution.cs
Wednesday 01 Aug 2018
4:10 pm

Carlos Lubbers

Review related improvements WTI-1751

Options
    • -1
    • +0
    /Demo/Ringtoets/test/Demo.Ringtoets.Test/Commands/AddNewDemoAssessmentSectionCommandTest.cs
    • -4
    • +0
    /Demo/Ringtoets/test/Demo.Ringtoets.Test/Demo.Ringtoets.Test.csproj
    • -1
    • +1
    /Ringtoets/ClosingStructures/test/Ringtoets.ClosingStructures.Forms.Test/Views/ClosingStructuresScenariosViewTest.cs
    • -2
    • +2
    /Ringtoets/Common/src/Ringtoets.Common.Data/FailureMechanism/FailureMechanismSectionCollection.cs
    • -9
    • +9
    /Ringtoets/Common/src/Ringtoets.Common.Forms/PropertyClasses/FailureMechanismSectionsProbabilityAssessmentProperties.cs
    • -9
    • +9
    /Ringtoets/Common/src/Ringtoets.Common.Forms/PropertyClasses/FailureMechanismSectionsProperties.cs
    • -2
    • +3
    /Ringtoets/Common/test/Ringtoets.Common.Data.Test/FailureMechanism/FailureMechanismSectionCollectionTest.cs
    • -10
    • +9
    /Ringtoets/Common/test/Ringtoets.Common.Forms.Test/PropertyClasses/FailureMechanismSectionsProbabilityAssessmentPropertiesTest.cs
    • -10
    • +9
    /Ringtoets/Common/test/Ringtoets.Common.Forms.Test/PropertyClasses/FailureMechanismSectionsPropertiesTest.cs
    • -1
    • +1
    /Ringtoets/GrassCoverErosionInwards/test/Ringtoets.GrassCoverErosionInwards.Data.Test/GrassCoverErosionInwardsFailureMechanismTest.cs
    • -1
    • +1
    /Ringtoets/Integration/test/Ringtoets.Integration.TestUtil/DataImportHelper.cs
4:09 pm

Robert Tangerman <robert.tangerman@deltares.nl>

Only create observers for contributing failure mechanisms. WTI-1792

Options
    • -2
    • +13
    /Ringtoets/Common/test/Ringtoets.Common.Data.TestUtil.Test/AssessmentSectionStubTest.cs
    • -1
    • +1
    /Ringtoets/Common/test/Ringtoets.Common.Data.TestUtil/AssessmentSectionStub.cs
    • -1
    • +1
    /Ringtoets/Integration/src/Ringtoets.Integration.Forms/Views/FailureMechanismContributionView.cs
    • -17
    • +6
    /Ringtoets/Integration/test/Ringtoets.Integration.Plugin.Test/ViewInfos/FailureMechanismContributionViewInfoTest.cs
4:03 pm

Robert Tangerman <robert.tangerman@deltares.nl>

Fixed stand alone failure mechanism property control. WTI-1792

Options
    • -1
    • +1
    /Ringtoets/Integration/src/Ringtoets.Integration.Forms/PropertyClasses/StandAlone/StandAloneFailureMechanismProperties.cs
    • -10
    • +11
    /Ringtoets/Integration/test/Ringtoets.Integration.Forms.Test/PropertyClasses/StandAlone/StandAloneFailureMechanismPropertiesTest.cs
4:00 pm

Robert Tangerman <robert.tangerman@deltares.nl>

Resubscribe failure mechanisms when notifying assessment section. WTI-1792

Options
    • -1
    • +6
    /Ringtoets/Integration/src/Ringtoets.Integration.Forms/Views/FailureMechanismContributionView.cs
    • -0
    • +41
    /Ringtoets/Integration/test/Ringtoets.Integration.Forms.Test/Views/FailureMechanismContributionViewTest.cs
3:47 pm

Robert Tangerman <robert.tangerman@deltares.nl>

Cleanup. WTI-1792

Options
    • -39
    • +39
    /Ringtoets/Integration/src/Ringtoets.Integration.Forms/Views/FailureMechanismContributionItemRow.cs
    • -1
    • +0
    /Ringtoets/Integration/src/Ringtoets.Integration.Forms/Views/FailureMechanismContributionView.cs
    • -38
    • +12
    /Ringtoets/Integration/test/Ringtoets.Integration.Forms.Test/Views/FailureMechanismContributionViewTest.cs
3:44 pm

Robert Tangerman <robert.tangerman@deltares.nl>

Added construction properties to row. WTI-1792

Options
    • -20
    • +33
    /Ringtoets/Integration/src/Ringtoets.Integration.Forms/Views/FailureMechanismContributionItemRow.cs
    • -3
    • +14
    /Ringtoets/Integration/src/Ringtoets.Integration.Forms/Views/FailureMechanismContributionView.cs
    • -22
    • +51
    /Ringtoets/Integration/test/Ringtoets.Integration.Forms.Test/Views/FailureMechanismContributionItemRowTest.cs