Riskeer

Clone Tools

Stats

Commits this week: 0
Total Committers: 28
Last Commit: 26 Nov
Commits this week: 0

Lines of code count not available

Commit Activity

Commits By Day In Week
52 week commits volume
Commits By Day In Week
Commits by day
Commits By Day In Week
Commits by hour
Commits By Hour In Day
Commit calendar
 

Most active committers (90 days)

loading
loading
  • last updated a few seconds ago
All Commits Reviews
Constraints
Constraints: committers
 
Constraints: files
Constraints: dates
Tuesday 28 Feb 2017
9:04 am

Robert Tangerman <robert.tangerman@deltares.nl>

Moved exceptions to BruTile project.

git-svn-id: https://repos.deltares.nl/repos/WettelijkToetsInstrumentarium/branches/WTI-1088@8453 5a3db67b-de53-47b5-99c8-a1c30a6650e2

Former-commit-id: a4fffc791ced5ded000116f7e4313d1a1bf5e413

Former-commit-id: a0b3ac2088b1853dbc2ba4ca5a681be0c0320d85

Options
    • -0
    • +8
    /Core/Components/src/Core.Components.BruTile/Core.Components.BruTile.csproj
    • -0
    • +57
    /Core/Components/src/Core.Components.BruTile/Exceptions/CannotCreateTileCacheException.cs
    • -0
    • +59
    /Core/Components/src/Core.Components.BruTile/Exceptions/CannotFindTileSourceException.cs
    • -0
    • +57
    /Core/Components/src/Core.Components.BruTile/Exceptions/CannotReceiveTilesException.cs
    • -0
    • +26
    /Core/Components/src/Core.Components.BruTile/packages.config
    • -1
    • +1
    /Core/Components/src/Core.Components.DotSpatial.Forms/IO/WmtsCapabilityFactory.cs
    • -3
    • +0
    /Core/Components/src/Core.Components.DotSpatial/Core.Components.DotSpatial.csproj
    • -3
    • +3
    /Core/Components/src/Core.Components.DotSpatial/Layer/BruTile/BruTileLayer.cs
    • -57
    • +0
    /Core/Components/src/Core.Components.DotSpatial/Layer/BruTile/Configurations/CannotCreateTileCacheException.cs
    • -59
    • +0
    /Core/Components/src/Core.Components.DotSpatial/Layer/BruTile/Configurations/CannotFindTileSourceException.cs
    • -57
    • +0
    /Core/Components/src/Core.Components.DotSpatial/Layer/BruTile/Configurations/CannotReceiveTilesException.cs
    • -4
    • +4
    /Core/Components/src/Core.Components.DotSpatial/Layer/BruTile/Configurations/IConfiguration.cs
    • -1
    • +1
    /Core/Components/src/Core.Components.DotSpatial/Layer/BruTile/Configurations/ITileSourceFactory.cs
    • -3
    • +3
    /Core/Components/src/Core.Components.DotSpatial/Layer/BruTile/Configurations/PersistentCacheConfiguration.cs
    • -1
    • +1
    /Core/Components/src/Core.Components.DotSpatial/Layer/BruTile/Configurations/TileSourceFactory.cs
  16. … 11 more files in changeset.
8:43 am

Robert Tangerman <robert.tangerman@deltares.nl>

git-svn-id: https://repos.deltares.nl/repos/WettelijkToetsInstrumentarium/branches/WTI-1088@8452 5a3db67b-de53-47b5-99c8-a1c30a6650e2

Former-commit-id: 0c64ce215c0e6d5b181656511fc54cfff8f0df66

Former-commit-id: dacfae9a270403b1aeff7da01f3fbb82dd09a7b3

Options
8:23 am

Marten Janssen <marten.janssen@deltares.nl>

Review related suggestions Related to Issue [WTI-1144]

git-svn-id: https://repos.deltares.nl/repos/WettelijkToetsInstrumentarium/trunk@8451 5a3db67b-de53-47b5-99c8-a1c30a6650e2

Former-commit-id: 1727fc14aecff4df000b090c26b960939e388d0e

Former-commit-id: c2321b11dec0e3dde4240ccf1e35c30d68b7dc28

Options
    • -12
    • +12
    /Core/Common/test/Core.Common.Gui.Test/Forms/PropertyGridView/PropertyGridViewTest.cs
    • -9
    • +4
    /Ringtoets/Integration/src/Ringtoets.Integration.Forms/PropertyClasses/BackgroundMapDataContainerProperties.cs
    • -4
    • +1
    /Ringtoets/Integration/test/Ringtoets.Integration.Forms.Test/PropertyClasses/BackgroundMapDataContainerPropertiesTest.cs
    • -40
    • +20
    /Ringtoets/Integration/test/Ringtoets.Integration.Plugin.Test/PropertyInfos/BackgroundMapDataContainerPropertyInfoTest.cs
    • -4
    • +1
    /Ringtoets/Integration/test/Ringtoets.Integration.Plugin.Test/TreeNodeInfos/BackgroundMapDataContainerTreeNodeInfoTest.cs
Monday 27 Feb 2017
5:11 pm

Dennis Tang <dennis.tang@deltares.nl>

Incorporated comments review 1488: - Improved tests of StrategyBase: -- Replaced the return methods with properties to assert if they're called with the right input arguments -- Renamed several tests - Ran DeltaresClean - Inlined the ValidateItems function in the ObservableUniqueItemCollectionWithSourcePath Related to Issue [WTI-1075]

git-svn-id: https://repos.deltares.nl/repos/WettelijkToetsInstrumentarium/trunk@8450 5a3db67b-de53-47b5-99c8-a1c30a6650e2

Former-commit-id: 4ffcec0c1dcd11672904c2b637269d6a80545364

Former-commit-id: eee856fa71a461b074affbe52ed8d0429d4a7333

Options
    • -24
    • +14
    /Core/Common/src/Core.Common.Base/ObservableUniqueItemCollectionWithSourcePath.cs
    • -11
    • +15
    /Ringtoets/Common/test/Ringtoets.Common.Data.Test/UpdateDataStrategies/ReplaceDataStrategyBaseTest.cs
    • -51
    • +45
    /Ringtoets/Common/test/Ringtoets.Common.Data.Test/UpdateDataStrategies/UpdateDataStrategyBaseTest.cs
    • -2
    • +4
    /Ringtoets/Piping/src/Ringtoets.Piping.Plugin/FileImporter/StochasticSoilModelUpdateDataStrategy.cs
    • -3
    • +2
    /Ringtoets/Piping/test/Ringtoets.Piping.Plugin.Test/FileImporter/RingtoetsPipingSurfaceLineUpdateDataStrategyTest.cs
4:54 pm

Marten Janssen <marten.janssen@deltares.nl>

Review suggestion - Added XMLdoc - Used ReadOnlyCollection

Related to Issue [WTI-1091]

git-svn-id: https://repos.deltares.nl/repos/WettelijkToetsInstrumentarium/trunk@8449 5a3db67b-de53-47b5-99c8-a1c30a6650e2

Former-commit-id: 477fcef439b7e71f0fd00dc69cd78121ca4df2f3

Former-commit-id: ca41d728c163e009123e3743626db73ec419e58a

Options
    • -4
    • +7
    /Core/Components/src/Core.Components.DotSpatial.Forms/IO/WmtsConnectionInfoReader.cs
    • -2
    • +2
    /Core/Components/src/Core.Components.DotSpatial.Forms/Views/WmtsLocationControl.cs
4:42 pm

Marten Janssen <marten.janssen@deltares.nl>

Review suggestion - Added XMLdoc - Renamed IHasMapData.cs

Related to Issue [WTI-1091]

git-svn-id: https://repos.deltares.nl/repos/WettelijkToetsInstrumentarium/trunk@8448 5a3db67b-de53-47b5-99c8-a1c30a6650e2

Former-commit-id: fc4dcc56738fcc32fb980ce400bee7d1d515dc51

Former-commit-id: b86d1ddfc8ec73699cdb28fc90229453fc651884

Options
    • -1
    • +1
    /Core/Components/src/Core.Components.DotSpatial.Forms/Core.Components.DotSpatial.Forms.csproj
    • -0
    • +53
    /Core/Components/src/Core.Components.DotSpatial.Forms/Views/IBackgroundMapDataSelectionControl.cs
    • -53
    • +0
    /Core/Components/src/Core.Components.DotSpatial.Forms/Views/IHasMapData.cs
    • -5
    • +5
    /Core/Components/src/Core.Components.DotSpatial.Forms/Views/WmtsConnectionDialog.cs
    • -1
    • +1
    /Core/Components/src/Core.Components.DotSpatial.Forms/Views/WmtsLocationControl.cs
    • -1
    • +1
    /Core/Components/test/Core.Components.DotSpatial.Forms.Test/Views/WmtsLocationControlTest.cs
    • -6
    • +6
    /Ringtoets/Integration/src/Ringtoets.Integration.Forms/BackgroundMapDataSelectionDialog.cs
    • -1
    • +1
    /Ringtoets/Integration/test/Ringtoets.Integration.Forms.Test/BackgroundMapDataSelectionDialogTest.cs
4:40 pm

Joël van den Berg

Upgraded HydraRing (version 17.1.2) Related to Issue [WTI-1196]

git-svn-id: https://repos.deltares.nl/repos/WettelijkToetsInstrumentarium/trunk@8447 5a3db67b-de53-47b5-99c8-a1c30a6650e2

Former-commit-id: b28f14f2df1019adb033f1c9d43932a86936b4ea

Former-commit-id: 8a2e3d66c46ed576628a39fe44ce3f474bf7b9d2

Options
    • binary
    /Ringtoets/HydraRing/src/Ringtoets.HydraRing.Calculation/HydraRing/DikesOvertopping.dll
    • binary
    /Ringtoets/HydraRing/src/Ringtoets.HydraRing.Calculation/HydraRing/DllLinearizedBetaAlpha.dll
    • binary
    /Ringtoets/HydraRing/src/Ringtoets.HydraRing.Calculation/HydraRing/HydraRing.Database.Test.dll
    • binary
    /Ringtoets/HydraRing/src/Ringtoets.HydraRing.Calculation/HydraRing/HydraRing.Database.TestUtils.dll
    • binary
    /Ringtoets/HydraRing/src/Ringtoets.HydraRing.Calculation/HydraRing/HydraRing.Database.dll
    • binary
    /Ringtoets/HydraRing/src/Ringtoets.HydraRing.Calculation/HydraRing/HydraRing.DuneErosionWrapper.Tests.dll
    • binary
    /Ringtoets/HydraRing/src/Ringtoets.HydraRing.Calculation/HydraRing/HydraRing.DuneErosionWrapper.dll
    • binary
    /Ringtoets/HydraRing/src/Ringtoets.HydraRing.Calculation/HydraRing/HydraRing.IO.Native.dll
    • binary
    /Ringtoets/HydraRing/src/Ringtoets.HydraRing.Calculation/HydraRing/HydraRing.IO.TestUtils.Native.dll
    • binary
    /Ringtoets/HydraRing/src/Ringtoets.HydraRing.Calculation/HydraRing/HydraRing.MacroStability.Wrapper.dll
    • binary
    /Ringtoets/HydraRing/src/Ringtoets.HydraRing.Calculation/HydraRing/HydraRing.Piping2017Wrapper.dll
    • binary
    /Ringtoets/HydraRing/src/Ringtoets.HydraRing.Calculation/HydraRing/HydraRing.PluginShared.dll
    • binary
    /Ringtoets/HydraRing/src/Ringtoets.HydraRing.Calculation/HydraRing/MechanismComputation.exe
    • binary
    /Ringtoets/HydraRing/src/Ringtoets.HydraRing.Calculation/HydraRing/RingComputation.exe
    • binary
    /Ringtoets/HydraRing/src/Ringtoets.HydraRing.Calculation/HydraRing/StructuresStructuralFailure2017wrapper.dll
  16. … 12 more files in changeset.
4:34 pm

Marten Janssen <marten.janssen@deltares.nl>

Review suggestion - Added XMLdoc - Extracted method Related to Issue [WTI-1091]

git-svn-id: https://repos.deltares.nl/repos/WettelijkToetsInstrumentarium/trunk@8446 5a3db67b-de53-47b5-99c8-a1c30a6650e2

Former-commit-id: e7863b7fde6498eaf0771ec456a42c2dddad00c5

Former-commit-id: 6d747773c26c95bd80d63bd43cc9a05a8acefc97

Options
    • -15
    • +28
    /Core/Components/src/Core.Components.DotSpatial.Forms/IO/WmtsConnectionInfoReader.cs
4:05 pm

Robert Tangerman <robert.tangerman@deltares.nl>

Added BruTile projects so we can separate it from DotSpatial logic. Related to Issue [WTI-1088]

git-svn-id: https://repos.deltares.nl/repos/WettelijkToetsInstrumentarium/trunk@8445 5a3db67b-de53-47b5-99c8-a1c30a6650e2

Former-commit-id: 3393f04ece091c3fa47a083beddc0ad6d911c14a

Former-commit-id: 2c56fd5acb012dfd57dc1b3a9371a37fcdb5f9ad

Options
    • -67
    • +73
    /Application/Ringtoets/src/Application.Ringtoets.Setup/Licentie.rtf
    • -0
    • +57
    /Core/Components/src/Core.Components.BruTile.Forms/Core.Components.BruTile.Forms.csproj
    • -0
    • +27
    /Core/Components/src/Core.Components.BruTile.Forms/Properties/AssemblyInfo.cs
    • -0
    • +57
    /Core/Components/src/Core.Components.BruTile.IO/Core.Components.BruTile.IO.csproj
    • -0
    • +27
    /Core/Components/src/Core.Components.BruTile.IO/Properties/AssemblyInfo.cs
    • -0
    • +58
    /Core/Components/src/Core.Components.BruTile/Core.Components.BruTile.csproj
    • -0
    • +27
    /Core/Components/src/Core.Components.BruTile/Properties/AssemblyInfo.cs
    • -0
    • +64
    /Core/Components/test/Core.Components.BruTile.Forms.Test/Core.Components.BruTile.Forms.Test.csproj
    • -0
    • +27
    /Core/Components/test/Core.Components.BruTile.Forms.Test/Properties/AssemblyInfo.cs
    • -0
    • +64
    /Core/Components/test/Core.Components.BruTile.IO.Test/Core.Components.BruTile.IO.Test.csproj
    • -0
    • +27
    /Core/Components/test/Core.Components.BruTile.IO.Test/Properties/AssemblyInfo.cs
    • -0
    • +64
    /Core/Components/test/Core.Components.BruTile.Test/Core.Components.BruTile.Test.csproj
    • -0
    • +27
    /Core/Components/test/Core.Components.BruTile.Test/Properties/AssemblyInfo.cs
    • -1
    • +0
    /Core/Components/test/Core.Components.DotSpatial.Test/Core.Components.DotSpatial.Test.csproj
    • -0
    • +93
    /Ringtoets.sln
3:58 pm

Marten Janssen <marten.janssen@deltares.nl>

Review suggestion - Extracted 'can write in directory' to TestHelper Related to Issue [WTI-1091]

git-svn-id: https://repos.deltares.nl/repos/WettelijkToetsInstrumentarium/trunk@8444 5a3db67b-de53-47b5-99c8-a1c30a6650e2

Former-commit-id: 765597811edfbd109236b4e396a7773d858cdc7f

Former-commit-id: 8df66894178c30a8573677d772beb1e308a58755

Options
    • -21
    • +86
    /Core/Common/test/Core.Common.TestUtil.Test/DirectoryDisposeHelperTest.cs
    • -5
    • +78
    /Core/Common/test/Core.Common.TestUtil.Test/TestHelperTest.cs
    • -8
    • +19
    /Core/Common/test/Core.Common.TestUtil/DirectoryDisposeHelper.cs
    • -0
    • +1
    /Core/Common/test/Core.Common.TestUtil/FileDisposeHelper.cs
    • -7
    • +27
    /Core/Common/test/Core.Common.TestUtil/TestHelper.cs
3:57 pm

Joël van den Berg

Renamed test Reviewed: tang_ds Related to Issue [WTI-1077]

git-svn-id: https://repos.deltares.nl/repos/WettelijkToetsInstrumentarium/trunk@8443 5a3db67b-de53-47b5-99c8-a1c30a6650e2

Former-commit-id: f5f7a30b3b587f5bd74d6d7e72f385aac8004cbd

Former-commit-id: c4caf93e46cf84a50721ee9f10c695fb83d29c16

Options
    • -3
    • +3
    /Ringtoets/Piping/test/Ringtoets.Piping.Plugin.Test/TreeNodeInfos/PipingCalculationScenarioContextTreeNodeInfoTest.cs
3:21 pm

Robert Tangerman <robert.tangerman@deltares.nl>

Improvements after review. Related to Issue [WTI-1128]

git-svn-id: https://repos.deltares.nl/repos/WettelijkToetsInstrumentarium/trunk@8442 5a3db67b-de53-47b5-99c8-a1c30a6650e2

Former-commit-id: 312555e819ad6cfed810361d35e2e97171dff292

Former-commit-id: d24d0f9a754b146e92fbbabee3a2db47c83e865b

Options
    • -0
    • +1
    /Ringtoets/Common/src/Ringtoets.Common.Forms/ChangeHandlers/PropertyChangeHelper.cs
    • -1
    • +0
    /Ringtoets/Common/src/Ringtoets.Common.Forms/PropertyClasses/StructuresInputBaseProperties.cs
    • -24
    • +8
    /Ringtoets/Piping/src/Ringtoets.Piping.Forms/Views/PipingCalculationRow.cs
    • -1
    • +0
    /Ringtoets/Revetment/src/Ringtoets.Revetment.Forms/PropertyClasses/WaveConditionsInputContextProperties.cs
2:49 pm

Marten Janssen <marten.janssen@deltares.nl>

Review suggestion - Refactoring of TestSettingsHelper

Related to Issue [WTI-1091]

git-svn-id: https://repos.deltares.nl/repos/WettelijkToetsInstrumentarium/trunk@8441 5a3db67b-de53-47b5-99c8-a1c30a6650e2

Former-commit-id: 48dca65c5b99bf49cdc8832105a96d71ff3966b0

Former-commit-id: a65b0c889a9d1b12dded48c7cf024d4148fc1e93

Options
    • -26
    • +42
    /Core/Common/test/Core.Common.Gui.TestUtil.Test/Settings/TestSettingsHelperTest.cs
    • -13
    • +7
    /Core/Common/test/Core.Common.Gui.TestUtil/Settings/TestSettingsHelper.cs
    • -5
    • +5
    /Core/Components/test/Core.Components.DotSpatial.Forms.Test/MapControlTest.cs
    • -20
    • +24
    /Core/Components/test/Core.Components.DotSpatial.Forms.Test/Views/WmtsLocationControlTest.cs
2:22 pm

Marten Janssen <marten.janssen@deltares.nl>

Review suggestion - Explicit types - Extended tests - Moved UseCustomSettingsHelper to Core.Common.Gui.TestUtil Related to Issue [WTI-1091]

git-svn-id: https://repos.deltares.nl/repos/WettelijkToetsInstrumentarium/trunk@8440 5a3db67b-de53-47b5-99c8-a1c30a6650e2

Former-commit-id: ff142b1c5f7f09290831c940e8089533a7250a52

Former-commit-id: c7bda8c1d641aadd567c2a4c2c746816149f4c49

Options
    • -1
    • +1
    /Core/Common/src/Core.Common.Controls/DataGrid/DataGridViewControl.cs
    • -4
    • +9
    /Core/Common/test/Core.Common.Controls.Test/DataGrid/DataGridViewControlTest.cs
    • -5
    • +5
    /Core/Common/test/Core.Common.Gui.Test/Settings/SettingsHelperTest.cs
    • -0
    • +5
    /Core/Common/test/Core.Common.Gui.TestUtil.Test/Core.Common.Gui.TestUtil.Test.csproj
    • -0
    • +74
    /Core/Common/test/Core.Common.Gui.TestUtil.Test/Settings/UseCustomSettingsHelperTest.cs
    • -0
    • +1
    /Core/Common/test/Core.Common.Gui.TestUtil.Test/packages.config
    • -0
    • +1
    /Core/Common/test/Core.Common.Gui.TestUtil/Core.Common.Gui.TestUtil.csproj
    • -0
    • +1
    /Core/Common/test/Core.Common.Gui.TestUtil/Settings/TestSettingsHelper.cs
    • -0
    • +63
    /Core/Common/test/Core.Common.Gui.TestUtil/Settings/UseCustomSettingsHelper.cs
    • -1
    • +0
    /Core/Common/test/Core.Common.Gui.TestUtil/packages.config
    • -11
    • +0
    /Core/Components/test/Core.Components.DotSpatial.TestUtil.Test/Core.Components.DotSpatial.TestUtil.Test.csproj
    • -73
    • +0
    /Core/Components/test/Core.Components.DotSpatial.TestUtil.Test/UseCustomSettingsHelperTest.cs
    • -5
    • +0
    /Core/Components/test/Core.Components.DotSpatial.TestUtil/Core.Components.DotSpatial.TestUtil.csproj
    • -68
    • +0
    /Core/Components/test/Core.Components.DotSpatial.TestUtil/UseCustomSettingsHelper.cs
2:11 pm

Dennis Tang <dennis.tang@deltares.nl>

Updated context menu for the RingtoetsPipingSurfaceLines: - Removed DeleteChildren and Delete on individual items of the surface lines - Removed the obsolete CanRemove and OnNodeRemove functions - Cleared unused references Related to Issue [WTI-1117]

git-svn-id: https://repos.deltares.nl/repos/WettelijkToetsInstrumentarium/trunk@8439 5a3db67b-de53-47b5-99c8-a1c30a6650e2

Former-commit-id: d698bcc7ba8818c915fff9bfd66b8208fca1edda

Former-commit-id: 775ee8852b6e947dd1b6d502fccac5abe461d8d8

Options
    • -25
    • +1
    /Ringtoets/Piping/src/Ringtoets.Piping.Plugin/PipingPlugin.cs
    • -2
    • +0
    /Ringtoets/Piping/test/Ringtoets.Piping.Plugin.Test/TreeNodeInfos/RingtoetsPipingSurfaceLineCollectionTreeNodeInfoTest.cs
    • -128
    • +2
    /Ringtoets/Piping/test/Ringtoets.Piping.Plugin.Test/TreeNodeInfos/RingtoetsPipingSurfaceLineTreeNodeInfoTest.cs
    • -4
    • +0
    /Ringtoets/Piping/test/Ringtoets.Piping.Plugin.Test/TreeNodeInfos/StochasticSoilModelTreeNodeInfoTest.cs
1:53 pm

Dennis Tang <dennis.tang@deltares.nl>

Added update entry and exit points when the surface line geometry is updated for all calculations: - Added feature for the CalculationGroup objects and added functional tests - Refactored: -- Added stricter assertions for the individual calculations, adjusted test names to better reflect the changes in the "When" stage -- Inlined the return value of CreateGeneratePipingCalculationsItem function

Related to Issue [WTI-1077]

git-svn-id: https://repos.deltares.nl/repos/WettelijkToetsInstrumentarium/trunk@8438 5a3db67b-de53-47b5-99c8-a1c30a6650e2

Former-commit-id: 328fe4a68ff43e5c844ba4ddcae741b8a0a14a94

Former-commit-id: 45f189b0b14791e44b4d95a7b3d09b3ce296a10d

Options
    • -3
    • +23
    /Ringtoets/Piping/src/Ringtoets.Piping.Plugin/PipingPlugin.cs
    • -0
    • +19
    /Ringtoets/Piping/src/Ringtoets.Piping.Plugin/Properties/Resources.Designer.cs
    • -0
    • +6
    /Ringtoets/Piping/src/Ringtoets.Piping.Plugin/Properties/Resources.resx
    • -23
    • +384
    /Ringtoets/Piping/test/Ringtoets.Piping.Plugin.Test/TreeNodeInfos/PipingCalculationGroupContextTreeNodeInfoTest.cs
    • -8
    • +14
    /Ringtoets/Piping/test/Ringtoets.Piping.Plugin.Test/TreeNodeInfos/PipingCalculationScenarioContextTreeNodeInfoTest.cs
1:41 pm

Marten Janssen <marten.janssen@deltares.nl>

Review suggestion - simplify tests

{qoute}

Looking at most of this unit test, there doesn't seem to be any need for ControlTester to reflect the encapsulated member. Think about the level of abstraction you are working and think of needing thinks like ControlTester as potential smells that the object you are working on is encapsulating too much or you as a dev are too much focussed on doing white-box testing.

{quote}

Related to Issue [WTI-1091]

git-svn-id: https://repos.deltares.nl/repos/WettelijkToetsInstrumentarium/trunk@8437 5a3db67b-de53-47b5-99c8-a1c30a6650e2

Former-commit-id: 159916a320a71d293c597116f3206f303cc16f8f

Former-commit-id: 1b797a01335db5609e7ce3062975cca2e36a99d4

Options
    • -238
    • +140
    /Core/Common/test/Core.Common.Controls.Test/DataGrid/DataGridViewControlTest.cs
1:32 pm

Joël van den Berg

Reduced line length. Related to Issue [WTI-1128]

git-svn-id: https://repos.deltares.nl/repos/WettelijkToetsInstrumentarium/trunk@8436 5a3db67b-de53-47b5-99c8-a1c30a6650e2

Former-commit-id: ab86dd06c30cc7b0b3dd79147b51ed2a9aa3c437

Former-commit-id: 878baba327b26a37cb735876b252ae44de0328ee

Options
    • -46
    • +145
    /Ringtoets/Common/test/Ringtoets.Common.Forms.Test/PropertyClasses/StructuresInputBasePropertiesTest.cs
1:25 pm

Joël van den Berg

Removed unused parameters of DesignVariableProperties (and descendants). Several cleanups/doc improvements. Related to Issue [WTI-1128]

git-svn-id: https://repos.deltares.nl/repos/WettelijkToetsInstrumentarium/trunk@8435 5a3db67b-de53-47b5-99c8-a1c30a6650e2

Former-commit-id: e0921d6542373caf861c2b3e03b40cb1e7382b42

Former-commit-id: 8fd618dee27dcf3e525484fccc98081cc74426ac

Options
    • -3
    • +1
    /Ringtoets/Common/src/Ringtoets.Common.Forms/PropertyClasses/LogNormalDistributionProperties.cs
    • -3
    • +1
    /Ringtoets/Common/src/Ringtoets.Common.Forms/PropertyClasses/NormalDistributionProperties.cs
    • -1
    • +4
    /Ringtoets/Common/src/Ringtoets.Common.Forms/PropertyClasses/StructuresInputBaseProperties.cs
    • -6
    • +7
    /Ringtoets/Common/src/Ringtoets.Common.Forms/PropertyClasses/TruncatedNormalDistributionProperties.cs
    • -2
    • +2
    /Ringtoets/Common/src/Ringtoets.Common.Forms/PropertyClasses/VariationCoefficientDistributionPropertiesBase.cs
    • -3
    • +2
    /Ringtoets/Common/src/Ringtoets.Common.Forms/PropertyClasses/VariationCoefficientLogNormalDistributionProperties.cs
    • -2
    • +1
    /Ringtoets/Common/src/Ringtoets.Common.Forms/PropertyClasses/VariationCoefficientNormalDistributionProperties.cs
    • -15
    • +22
    /Ringtoets/Common/test/Ringtoets.Common.Forms.Test/PropertyClasses/StructuresInputBasePropertiesTest.cs
    • -1
    • +0
    /Ringtoets/Common/test/Ringtoets.Common.Forms.Test/PropertyClasses/TruncatedNormalDistributionPropertiesTest.cs
    • -1
    • +1
    /Ringtoets/Common/test/Ringtoets.Common.Forms.Test/PropertyClasses/UseBreakWaterPropertiesTest.cs
    • -1
    • +1
    /Ringtoets/Common/test/Ringtoets.Common.Forms.Test/PropertyClasses/UseForeshorePropertiesTest.cs
    • -5
    • +6
    /Ringtoets/Common/test/Ringtoets.Common.Forms.TestUtil.Test/CalculationInputSetPropertyValueAfterConfirmationParameterTesterTest.cs
    • -1
    • +0
    /Ringtoets/GrassCoverErosionInwards/src/Ringtoets.GrassCoverErosionInwards.Forms/PropertyClasses/GrassCoverErosionInwardsFailureMechanismContextProperties.cs
    • -7
    • +2
    /Ringtoets/Piping/src/Ringtoets.Piping.Forms/PropertyClasses/DesignVariableProperties.cs
    • -8
    • +1
    /Ringtoets/Piping/src/Ringtoets.Piping.Forms/PropertyClasses/LogNormalDistributionDesignVariableProperties.cs
  16. … 9 more files in changeset.
1:18 pm

Elmar Kleijn

Adapted PipingConfigurationWriter => No RoundedDouble formatting because of Oneindig => Infinity => XmlConvert because of Infinity => INF Related to Issue [WTI-1134]

git-svn-id: https://repos.deltares.nl/repos/WettelijkToetsInstrumentarium/trunk@8434 5a3db67b-de53-47b5-99c8-a1c30a6650e2

Former-commit-id: 107226747b221d3e521545334451383b92bbccab

Former-commit-id: 9656053d0f7e7a39025d80b87b548703293617bd

Options
    • -1
    • +1
    /Ringtoets/Piping/src/Ringtoets.Piping.IO/Exporters/PipingConfigurationWriter.cs
    • -1
    • +0
    /Ringtoets/Piping/src/Ringtoets.Piping.IO/Readers/PipingConfigurationReader.cs
    • -7
    • +7
    /Ringtoets/Piping/test/Ringtoets.Piping.IO.Test/test-data/PipingConfigurationWriter/calculationWithAssessmentLevel.xml
    • -6
    • +6
    /Ringtoets/Piping/test/Ringtoets.Piping.IO.Test/test-data/PipingConfigurationWriter/calculationWithoutHydraulicLocation.xml
    • -6
    • +6
    /Ringtoets/Piping/test/Ringtoets.Piping.IO.Test/test-data/PipingConfigurationWriter/calculationWithoutSoilProfile.xml
    • -6
    • +6
    /Ringtoets/Piping/test/Ringtoets.Piping.IO.Test/test-data/PipingConfigurationWriter/calculationWithoutSoilmodel.xml
    • -4
    • +4
    /Ringtoets/Piping/test/Ringtoets.Piping.IO.Test/test-data/PipingConfigurationWriter/calculationWithoutSurfaceline.xml
    • -12
    • +12
    /Ringtoets/Piping/test/Ringtoets.Piping.IO.Test/test-data/PipingConfigurationWriter/folderWithSubfolderAndCalculation.xml
11:58 am

Robert Tangerman <robert.tangerman@deltares.nl>

Improvements after review. Related to Issue [WTi-1076]

git-svn-id: https://repos.deltares.nl/repos/WettelijkToetsInstrumentarium/trunk@8433 5a3db67b-de53-47b5-99c8-a1c30a6650e2

Former-commit-id: b8e6d363c2b5af967e6dbb52dd93e87ceca695d8

Former-commit-id: a9f8b962388316d93157d917fa0026900309972e

Options
    • -11
    • +13
    /Ringtoets/Piping/src/Ringtoets.Piping.Plugin/PipingPlugin.cs
    • -3
    • +3
    /Ringtoets/Piping/src/Ringtoets.Piping.Plugin/Properties/Resources.Designer.cs
    • -1
    • +1
    /Ringtoets/Piping/src/Ringtoets.Piping.Plugin/Properties/Resources.resx
    • -5
    • +6
    /Ringtoets/Piping/test/Ringtoets.Piping.Plugin.Test/TreeNodeInfos/PipingCalculationScenarioContextTreeNodeInfoTest.cs
11:41 am

Joël van den Berg

Introduced PropertyChangeHelper which can be used to easily perform a change using a delegate and then notify affected objects returned by the ObservablePropertyChangeHandler. Related to Issue [WTI-1128]

git-svn-id: https://repos.deltares.nl/repos/WettelijkToetsInstrumentarium/trunk@8432 5a3db67b-de53-47b5-99c8-a1c30a6650e2

Former-commit-id: fa51077ff3f3b52f034b64860809ab521c4e666b

Former-commit-id: fb0102f750eb85428d793c1f07e015a1232119af

Options
    • -18
    • +16
    /Ringtoets/ClosingStructures/src/Ringtoets.ClosingStructures.Forms/PropertyClasses/ClosingStructuresInputContextProperties.cs
    • -1
    • +1
    /Ringtoets/Common/src/Ringtoets.Common.Forms/ChangeHandlers/ObservablePropertyChangeHandler.cs
    • -0
    • +63
    /Ringtoets/Common/src/Ringtoets.Common.Forms/ChangeHandlers/PropertyChangeHelper.cs
    • -12
    • +12
    /Ringtoets/Common/src/Ringtoets.Common.Forms/Properties/Resources.Designer.cs
    • -1
    • +1
    /Ringtoets/Common/src/Ringtoets.Common.Forms/Properties/Resources.resx
    • -16
    • +3
    /Ringtoets/Common/src/Ringtoets.Common.Forms/PropertyClasses/DistributionPropertiesBase.cs
    • -26
    • +10
    /Ringtoets/Common/src/Ringtoets.Common.Forms/PropertyClasses/StructuresInputBaseProperties.cs
    • -18
    • +3
    /Ringtoets/Common/src/Ringtoets.Common.Forms/PropertyClasses/VariationCoefficientDistributionPropertiesBase.cs
    • -0
    • +1
    /Ringtoets/Common/src/Ringtoets.Common.Forms/Ringtoets.Common.Forms.csproj
    • -0
    • +110
    /Ringtoets/Common/test/Ringtoets.Common.Forms.Test/ChangeHandlers/PropertyChangeHelperTest.cs
    • -339
    • +0
    /Ringtoets/Common/test/Ringtoets.Common.Forms.Test/PropertyClasses/ConfirmingDistributionPropertiesBaseTest.cs
    • -102
    • +0
    /Ringtoets/Common/test/Ringtoets.Common.Forms.Test/PropertyClasses/ConfirmingLogNormalDistributionPropertiesTest.cs
    • -102
    • +0
    /Ringtoets/Common/test/Ringtoets.Common.Forms.Test/PropertyClasses/ConfirmingNormalDistributionPropertiesTest.cs
    • -340
    • +0
    /Ringtoets/Common/test/Ringtoets.Common.Forms.Test/PropertyClasses/ConfirmingVariationCoefficientDistributionPropertiesBaseTest.cs
    • -104
    • +0
    /Ringtoets/Common/test/Ringtoets.Common.Forms.Test/PropertyClasses/ConfirmingVariationCoefficientLogNormalDistributionPropertiesTest.cs
  16. … 12 more files in changeset.
11:38 am

Marten Janssen <marten.janssen@deltares.nl>

review suggestions paird with tang_ds Related to Issue [WTI-1094]

git-svn-id: https://repos.deltares.nl/repos/WettelijkToetsInstrumentarium/trunk@8431 5a3db67b-de53-47b5-99c8-a1c30a6650e2

Former-commit-id: a7d149972b3949757d3b83eff662af98edba5123

Former-commit-id: 63d6d85d5128f78742cc81c32f47904b6574e813

Options
    • -18
    • +0
    /Core/Plugins/test/Core.Plugins.Map.Test/UITypeEditors/SelectableMetaDataAttributeTest.cs
    • -2
    • +2
    /Ringtoets/Common/src/Ringtoets.Common.IO/IConfirmDataChangeHandler.cs
    • -24
    • +2
    /Ringtoets/Common/test/Ringtoets.Common.Forms.Test/PresentationObjects/SelectableHydraulicBoundaryLocationTest.cs
    • -0
    • +167
    /Ringtoets/Piping/src/Ringtoets.Piping.Plugin/FileImporter/RingtoetsPipingSurfaceLineUpdateDataStrategy.cs
    • -167
    • +0
    /Ringtoets/Piping/src/Ringtoets.Piping.Plugin/FileImporter/RingtoetsPipingSurfaceLineUpdateStrategy.cs
    • -1
    • +1
    /Ringtoets/Piping/src/Ringtoets.Piping.Plugin/Ringtoets.Piping.Plugin.csproj
    • -4
    • +2
    /Ringtoets/Piping/src/Ringtoets.Piping.Primitives/RingtoetsPipingSurfaceLine.cs
    • -30
    • +0
    /Ringtoets/Piping/test/Ringtoets.Piping.Data.Test/RingtoetsPipingSurfaceLineTest.cs
    • -0
    • +15
    /Ringtoets/Piping/test/Ringtoets.Piping.Data.Test/StochasticSoilProfileTest.cs
    • -1
    • +1
    /Ringtoets/Piping/test/Ringtoets.Piping.Plugin.Test/ImportInfos/RingtoetsPipingSurfaceLinesContextImportInfoTest.cs
    • -1
    • +1
    /Ringtoets/Piping/test/Ringtoets.Piping.Plugin.Test/UpdateInfos/RingtoetsPipingSurfaceLinesContextUpdateInfoTest.cs
11:24 am

Robert Tangerman <robert.tangerman@deltares.nl>

Improvements after review. Related to Issue [WTI-1133]

git-svn-id: https://repos.deltares.nl/repos/WettelijkToetsInstrumentarium/trunk@8430 5a3db67b-de53-47b5-99c8-a1c30a6650e2

Former-commit-id: 58a77f4e5772a50da48d0575dff08e8779780c01

Former-commit-id: 60fb8aa1c80c5a08394b38bb7ff07d7fe5a37678

Options
    • -4
    • +4
    /Core/Common/src/Core.Common.IO/Readers/ReadResult.cs
    • -1
    • +1
    /Core/Common/test/Core.Common.IO.Test/Readers/ReadResultTest.cs
    • -2
    • +2
    /Core/Components/src/Core.Components.Gis.IO/Importers/FeatureBasedMapDataImporter.cs
    • -2
    • +2
    /Ringtoets/Common/src/Ringtoets.Common.IO/FileImporters/DikeProfilesImporter.cs
    • -2
    • +2
    /Ringtoets/Common/src/Ringtoets.Common.IO/FileImporters/FailureMechanismSectionsImporter.cs
    • -1
    • +1
    /Ringtoets/Common/src/Ringtoets.Common.IO/FileImporters/ForeshoreProfilesImporter.cs
    • -3
    • +3
    /Ringtoets/Common/src/Ringtoets.Common.IO/FileImporters/ProfilesImporter.cs
    • -4
    • +4
    /Ringtoets/Common/src/Ringtoets.Common.IO/FileImporters/StructuresImporter.cs
    • -2
    • +2
    /Ringtoets/Common/src/Ringtoets.Common.IO/ReferenceLines/ReferenceLineImporter.cs
    • -2
    • +2
    /Ringtoets/Piping/src/Ringtoets.Piping.IO/Importers/PipingConfigurationImporter.cs
    • -6
    • +6
    /Ringtoets/Piping/src/Ringtoets.Piping.IO/Importers/StochasticSoilModelImporter.cs
    • -4
    • +4
    /Ringtoets/Piping/src/Ringtoets.Piping.IO/Properties/Resources.Designer.cs
    • -4
    • +4
    /Ringtoets/Piping/src/Ringtoets.Piping.IO/Properties/Resources.resx
    • -4
    • +4
    /Ringtoets/Piping/src/Ringtoets.Piping.Plugin/FileImporter/PipingSurfaceLinesCsvImporter.cs
    • -26
    • +28
    /Ringtoets/Piping/test/Ringtoets.Piping.IO.Test/Importers/PipingConfigurationImporterTest.cs
  16. … 7 more files in changeset.
10:52 am

Joël van den Berg

In some cases, invalidate is called from the .NET libraries when refresh is called upon a data grid view. No clear reason for why/when this happens is apparent, so the test assertion has been relaxed to "at least" firing the event "once". Related to Issue [WTI-1070]

git-svn-id: https://repos.deltares.nl/repos/WettelijkToetsInstrumentarium/trunk@8429 5a3db67b-de53-47b5-99c8-a1c30a6650e2

Former-commit-id: 20460e97b432a2a1420c9c0fe4635e54474a373d

Former-commit-id: ecc43550b954641e65de7540a9baa198a4d4634a

Options
    • -3
    • +3
    /Ringtoets/GrassCoverErosionOutwards/test/Ringtoets.GrassCoverErosionOutwards.Forms.Test/Views/GrassCoverErosionOutwardsDesignWaterLevelLocationsViewTest.cs
9:00 am

Robert Tangerman <robert.tangerman@deltares.nl>

Improvements after review. Related to Issue [WTI-1133]

git-svn-id: https://repos.deltares.nl/repos/WettelijkToetsInstrumentarium/trunk@8428 5a3db67b-de53-47b5-99c8-a1c30a6650e2

Former-commit-id: 331f6ea0cfe5494ebfc1e4fb917ee42212e8a114

Former-commit-id: e779a2129e8567975f4f85e6bb8e1ac14bd3bc43

Options
    • -1
    • +1
    /Core/Common/src/Core.Common.Base/IO/FileImporterBase.cs
    • -6
    • +6
    /Core/Common/test/Core.Common.Base.Test/IO/FileImporterBaseTest.cs
    • -2
    • +2
    /Core/Common/test/Core.Common.Base.Test/ObservableUniqueItemCollectionWithSourcePathTest.cs
    • -1
    • +1
    /Core/Common/test/Core.Common.Gui.Test/Commands/GuiImportHandlerTest.cs
    • -2
    • +2
    /Core/Common/test/Core.Common.Gui.Test/Commands/GuiUpdateHandlerTest.cs
    • -15
    • +15
    /Core/Components/test/Core.Components.Gis.IO.Test/Importers/FeatureBasedMapDataImporterTest.cs
    • -1
    • +1
    /Core/Plugins/test/Core.Plugins.Map.Test/ImportInfos/MapDataCollectionImportInfoTest.cs
    • -1
    • +1
    /Ringtoets/ClosingStructures/test/Ringtoets.ClosingStructures.Plugin.Test/ImportInfos/ClosingStructuresContextImportInfoTest.cs
    • -2
    • +2
    /Ringtoets/Common/test/Ringtoets.Common.Forms.Test/GuiServices/HydraulicBoundaryLocationCalculationGuiServiceTest.cs
    • -1
    • +1
    /Ringtoets/Common/test/Ringtoets.Common.IO.Test/DikeProfiles/DikeProfileDataReaderTest.cs
    • -18
    • +18
    /Ringtoets/Common/test/Ringtoets.Common.IO.Test/ReferenceLines/ReferenceLineImporterTest.cs
    • -1
    • +1
    /Ringtoets/HeightStructures/test/Ringtoets.HeightStructures.Plugin.Test/ImportInfos/HeightStructuresContextImportInfoTest.cs
    • -1
    • +1
    /Ringtoets/Integration/test/Ringtoets.Integration.Plugin.Test/ImportInfos/DikeProfilesContextImportInfoTest.cs
    • -1
    • +1
    /Ringtoets/Integration/test/Ringtoets.Integration.Plugin.Test/ImportInfos/FailureMechanismSectionsContextImportInfoTest.cs
    • -1
    • +1
    /Ringtoets/Integration/test/Ringtoets.Integration.Plugin.Test/ImportInfos/ForeshoreProfilesContextImportInfoTest.cs
  16. … 12 more files in changeset.
8:59 am

Dennis Tang <dennis.tang@deltares.nl>

Added update entry and exit points when the surface line geometry is updated: - Changed resource value to enable hotkey

Related to Issue [WTI-1076]

git-svn-id: https://repos.deltares.nl/repos/WettelijkToetsInstrumentarium/trunk@8427 5a3db67b-de53-47b5-99c8-a1c30a6650e2

Former-commit-id: afb6f9ad542bfda794f8d5d448b3a7e1e83c2c05

Former-commit-id: fb269b4cd6874d6e2804bdb014741757aad9a1b8

Options
    • -1
    • +1
    /Ringtoets/Piping/src/Ringtoets.Piping.Plugin/Properties/Resources.Designer.cs
    • -1
    • +1
    /Ringtoets/Piping/src/Ringtoets.Piping.Plugin/Properties/Resources.resx
    • -2
    • +2
    /Ringtoets/Piping/test/Ringtoets.Piping.Plugin.Test/TreeNodeInfos/PipingCalculationScenarioContextTreeNodeInfoTest.cs
8:24 am

Robert Tangerman <robert.tangerman@deltares.nl>

Improvements after review. Related to Issue [WTI-1133]

git-svn-id: https://repos.deltares.nl/repos/WettelijkToetsInstrumentarium/trunk@8426 5a3db67b-de53-47b5-99c8-a1c30a6650e2

Former-commit-id: 657e55c2815c9510b3f86f29996fb10c041febc8

Former-commit-id: 954b87b25d1cde04dd18df9285795caab2e3cb43

Options
    • -3
    • +4
    /Ringtoets/Piping/src/Ringtoets.Piping.IO/Importers/PipingConfigurationImporter.cs
    • -3
    • +3
    /Ringtoets/Piping/src/Ringtoets.Piping.IO/Properties/Resources.Designer.cs
    • -2
    • +2
    /Ringtoets/Piping/src/Ringtoets.Piping.IO/Properties/Resources.resx
    • -8
    • +13
    /Ringtoets/Piping/src/Ringtoets.Piping.Plugin/PipingPlugin.cs
    • -2
    • +2
    /Ringtoets/Piping/src/Ringtoets.Piping.Plugin/Properties/Resources.Designer.cs
    • -1
    • +1
    /Ringtoets/Piping/src/Ringtoets.Piping.Plugin/Properties/Resources.resx
    • -1
    • +1
    /Ringtoets/Piping/test/Ringtoets.Piping.IO.Test/Importers/PipingConfigurationImporterTest.cs
8:06 am

Joël van den Berg

Added tests for PipingDataSynchronizationService routines Related to Issue [WTI-1070]

git-svn-id: https://repos.deltares.nl/repos/WettelijkToetsInstrumentarium/trunk@8425 5a3db67b-de53-47b5-99c8-a1c30a6650e2

Former-commit-id: 228b29fb5e9425876a51fb76509ffc2dde0a0701

Former-commit-id: 8075562ecc088c3bdd9190967ef41394dd32a081

Options
    • -5
    • +10
    /Ringtoets/Piping/test/Ringtoets.Piping.Integration.TestUtils/PipingTestDataGenerator.cs
    • -0
    • +16
    /Ringtoets/Piping/test/Ringtoets.Piping.Plugin.Test/FileImporter/StochasticSoilModelUpdateDataStrategyTest.cs
    • -0
    • +262
    /Ringtoets/Piping/test/Ringtoets.Piping.Service.Test/PipingDataSynchronizationServiceTest.cs
Friday 24 Feb 2017
4:50 pm

Dennis Tang <dennis.tang@deltares.nl>

Added update entry and exit points when the surface line geometry is updated: - Added tooltip - Added icon Related to Issue [WTI-1076]

git-svn-id: https://repos.deltares.nl/repos/WettelijkToetsInstrumentarium/trunk@8424 5a3db67b-de53-47b5-99c8-a1c30a6650e2

Former-commit-id: ccbf0fc5568f0018e6dde0aa35fdf0e8556bdcdc

Former-commit-id: 17831e96dcad964ae17cb42a4e94a6eb7e8a56b0

Options
    • -0
    • +10
    /Ringtoets/Common/src/Ringtoets.Common.Forms/Properties/Resources.Designer.cs
    • -0
    • +3
    /Ringtoets/Common/src/Ringtoets.Common.Forms/Properties/Resources.resx
    • binary
    /Ringtoets/Common/src/Ringtoets.Common.Forms/Resources/update.png
    • -0
    • +1
    /Ringtoets/Common/src/Ringtoets.Common.Forms/Ringtoets.Common.Forms.csproj
    • -5
    • +9
    /Ringtoets/Piping/src/Ringtoets.Piping.Plugin/PipingPlugin.cs
    • -0
    • +29
    /Ringtoets/Piping/src/Ringtoets.Piping.Plugin/Properties/Resources.Designer.cs
    • -0
    • +9
    /Ringtoets/Piping/src/Ringtoets.Piping.Plugin/Properties/Resources.resx
    • -8
    • +8
    /Ringtoets/Piping/test/Ringtoets.Piping.Plugin.Test/TreeNodeInfos/PipingCalculationScenarioContextTreeNodeInfoTest.cs