Riskeer

Clone Tools

Stats

Commits this week: 0
Total Committers: 28
Last Commit: 26 Nov
Commits this week: 0

Lines of code count not available

Commit Activity

Commits By Day In Week
52 week commits volume
Commits By Day In Week
Commits by day
Commits By Day In Week
Commits by hour
Commits By Hour In Day
Commit calendar
 

Most active committers (90 days)

loading
loading
  • last updated a few seconds ago
All Commits Reviews
Constraints
Constraints: committers
 
Constraints: files
Constraints: dates
Tuesday 22 May 2018
12:03 pm

Dennis Tang <dennis.tang@deltares.nl>

Changed constructor arguments for the DuneLocationCalculationsContext: - Added Func<double> to enable dynamic resolving the norm and a category boundary name to provide the norms and treenode info names for a wrapped dune location calculation collection

WTI-1575

Options
    • -5
    • +33
    /Ringtoets/DuneErosion/src/Ringtoets.DuneErosion.Forms/PresentationObjects/DuneLocationCalculationsContext.cs
    • -3
    • +77
    /Ringtoets/DuneErosion/test/Ringtoets.DuneErosion.Forms.Test/PresentationObjects/DuneLocationCalculationsContextTest.cs
12:01 pm

Dennis Tang <dennis.tang@deltares.nl>

Changed constructor arguments for the DuneLocationCalculationView: - Added Func<double> to enable dynamic resolving the norm in the view when a dune location is being calculated.

WTI-1575

Options
    • -3
    • +12
    /Ringtoets/DuneErosion/src/Ringtoets.DuneErosion.Forms/Views/DuneLocationCalculationsView.cs
    • -23
    • +82
    /Ringtoets/DuneErosion/test/Ringtoets.DuneErosion.Forms.Test/Views/DuneLocationCalculationsViewTest.cs
    • -6
    • +7
    /Ringtoets/DuneErosion/test/Ringtoets.DuneErosion.Integration.Test/DuneLocationsViewIntegrationTest.cs
12:01 pm

Dennis Tang <dennis.tang@deltares.nl>

Introduce generic FailureMechanismNormHelper to retrieve norms based on FailureMechanismCategoryType: - Fixed service tests --> removed explicit calls to the dune erosion failure mechanism extension. Norm can be every value.

WTI-1575

Options
    • -37
    • +17
    /Ringtoets/DuneErosion/test/Ringtoets.DuneErosion.Service.Test/DuneErosionBoundaryCalculationServiceTest.cs
11:58 am

Dennis Tang <dennis.tang@deltares.nl>

Introduce generic FailureMechanismNormHelper to retrieve norms based on FailureMechanismCategoryType: - Replaced dune erosion implementation with the generic implementation.

WTI-1575

Options
    • -8
    • +24
    /Ringtoets/DuneErosion/src/Ringtoets.DuneErosion.Data/DuneErosionFailureMechanismExtensions.cs
    • -0
    • +5
    /Ringtoets/DuneErosion/src/Ringtoets.DuneErosion.Data/Ringtoets.DuneErosion.Data.csproj
    • -11
    • +120
    /Ringtoets/DuneErosion/test/Ringtoets.DuneErosion.Data.Test/DuneErosionFailureMechanismExtensionsTest.cs
11:57 am

Dennis Tang <dennis.tang@deltares.nl>

Introduce generic FailureMechanismNormHelper to retrieve norms based on FailureMechanismCategoryType: - Replaced grass cover erosion outwards implementation with the generic implementation.

WTI-1575

Options
    • -33
    • +5
    /Ringtoets/GrassCoverErosionOutwards/src/Ringtoets.GrassCoverErosionOutwards.Data/GrassCoverErosionOutwardsFailureMechanismExtensions.cs
    • -0
    • +5
    /Ringtoets/GrassCoverErosionOutwards/src/Ringtoets.GrassCoverErosionOutwards.Data/Ringtoets.GrassCoverErosionOutwards.Data.csproj
    • -2
    • +2
    /Ringtoets/GrassCoverErosionOutwards/test/Ringtoets.GrassCoverErosionOutwards.Data.Test/GrassCoverErosionOutwardsFailureMechanismExtensionsTest.cs
11:11 am

Robert Tangerman <robert.tangerman@deltares.nl>

PipingStructures -> PipingStructure. WTI-1683

Options
    • -6
    • +6
    /Ringtoets/Integration/src/Ringtoets.Integration.Data/Assembly/CombinedFailureMechanismSectionAssemblyResult.cs
    • -2
    • +2
    /Ringtoets/Integration/src/Ringtoets.Integration.Forms/Views/AssemblyResultPerSectionView.cs
    • -6
    • +6
    /Ringtoets/Integration/src/Ringtoets.Integration.Forms/Views/CombinedFailureMechanismSectionAssemblyResultRow.cs
    • -4
    • +4
    /Ringtoets/Integration/test/Ringtoets.Integration.Data.Test/Assembly/CombinedFailureMechanismSectionAssemblyResultTest.cs
    • -6
    • +6
    /Ringtoets/Integration/test/Ringtoets.Integration.Forms.Test/Views/CombinedFailureMechanismSectionAssemblyResultRowTest.cs
9:05 am

Carlos Lubbers

Inline variable WTI-1689

Options
    • -2
    • +1
    /Ringtoets/Integration/src/Ringtoets.Integration.Forms/Views/AssemblyResultPerSectionView.cs
Friday 18 May 2018
3:48 pm

Carlos Lubbers

Update xmldoc WTI-1687

Options
    • -1
    • +1
    /Ringtoets/Common/src/Ringtoets.Common.Forms/Observers/CalculatableFailureMechanismResultObserver.cs
    • -1
    • +1
    /Ringtoets/Common/src/Ringtoets.Common.Forms/Observers/FailureMechanismResultObserver.cs
3:11 pm

Carlos Lubbers

Add assessment section result observer to AssemblyResultPerSectionView WTI-1689

Options
    • -2
    • +11
    /Ringtoets/Integration/src/Ringtoets.Integration.Forms/Views/AssemblyResultPerSectionView.Designer.cs
    • -1
    • +27
    /Ringtoets/Integration/src/Ringtoets.Integration.Forms/Views/AssemblyResultPerSectionView.cs
    • -7
    • +122
    /Ringtoets/Integration/test/Ringtoets.Integration.Forms.Test/Views/AssemblyResultPerSectionViewTest.cs
    • -10
    • +13
    /Ringtoets/Integration/test/Ringtoets.Integration.Forms.Test/Views/AssemblyResultTotalViewTest.cs
3:10 pm

Dennis Tang <dennis.tang@deltares.nl>

Introduce generic FailureMechanismNormHelper to retrieve norms based on FailureMechanismCategoryType: - Added validation for n and failure mechanism contribution.

WTI-1575

Options
    • -6
    • +37
    /Ringtoets/Common/src/Ringtoets.Common.Util/FailureMechanismNormHelper.cs
    • -4
    • +44
    /Ringtoets/Common/test/Ringtoets.Common.Util.Test/FailureMechanismNormHelperTest.cs
2:45 pm

Dennis Tang <dennis.tang@deltares.nl>

Introduce generic FailureMechanismNormHelper to retrieve norms based on FailureMechanismCategoryType: - Added initial setup

WTI-1575

Options
    • -0
    • +96
    /Ringtoets/Common/src/Ringtoets.Common.Util/FailureMechanismNormHelper.cs
    • -0
    • +6
    /Ringtoets/Common/src/Ringtoets.Common.Util/Ringtoets.Common.Util.csproj
    • -0
    • +156
    /Ringtoets/Common/test/Ringtoets.Common.Util.Test/FailureMechanismNormHelperTest.cs
    • -0
    • +1
    /Ringtoets/Common/test/Ringtoets.Common.Util.Test/Ringtoets.Common.Util.Test.csproj
    • -0
    • +3
    /Ringtoets/DuneErosion/test/Ringtoets.DuneErosion.Data.Test/Ringtoets.DuneErosion.Data.Test.csproj
    • -0
    • +1
    /Ringtoets/DuneErosion/test/Ringtoets.DuneErosion.Data.Test/packages.config
2:42 pm

Carlos Lubbers

Update icon WTI-1687

Options
    • -1
    • +1
    /Ringtoets/Integration/src/Ringtoets.Integration.Forms/Views/AssemblyResultTotalView.Designer.cs
    • -5
    • +9
    /Ringtoets/Integration/test/Ringtoets.Integration.Forms.Test/Views/AssemblyResultTotalViewTest.cs
2:13 pm

Carlos Lubbers

Add warning provider to assembly result total view WTI-1687

Options
    • -0
    • +10
    /Ringtoets/Integration/src/Ringtoets.Integration.Forms/Properties/Resources.Designer.cs
    • -0
    • +3
    /Ringtoets/Integration/src/Ringtoets.Integration.Forms/Properties/Resources.resx
    • -1
    • +12
    /Ringtoets/Integration/src/Ringtoets.Integration.Forms/Views/AssemblyResultTotalView.Designer.cs
    • -9
    • +15
    /Ringtoets/Integration/src/Ringtoets.Integration.Forms/Views/AssemblyResultTotalView.cs
    • -0
    • +3
    /Ringtoets/Integration/src/Ringtoets.Integration.Forms/Views/AssemblyResultTotalView.resx
    • -23
    • +48
    /Ringtoets/Integration/test/Ringtoets.Integration.Forms.Test/Views/AssemblyResultTotalViewTest.cs
1:57 pm

Dennis Tang <dennis.tang@deltares.nl>

Removed obsolete enum: - AssessmentLayerTwoAResult is replaced by Assembly relevant enums

WTI-1575

Options
    • -52
    • +0
    /Ringtoets/Common/src/Ringtoets.Common.Data/FailureMechanism/AssessmentLayerTwoAResult.cs
    • -1
    • +0
    /Ringtoets/Common/src/Ringtoets.Common.Data/Ringtoets.Common.Data.csproj
    • -70
    • +0
    /Ringtoets/Common/test/Ringtoets.Common.Data.Test/FailureMechanism/AssessmentLayerTwoAResultTest.cs
    • -1
    • +0
    /Ringtoets/Common/test/Ringtoets.Common.Data.Test/Ringtoets.Common.Data.Test.csproj
1:48 pm

Dennis Tang <dennis.tang@deltares.nl>

Cleanup: - Renamed all PropertyInfo, ViewInfo tests

WTI-1575

Options
    • -0
    • +74
    /Ringtoets/DuneErosion/test/Ringtoets.DuneErosion.Plugin.Test/PropertyInfos/DuneLocationCalculationPropertyInfoTest.cs
    • -0
    • +85
    /Ringtoets/DuneErosion/test/Ringtoets.DuneErosion.Plugin.Test/PropertyInfos/DuneLocationCalculationsContextPropertyInfoTest.cs
    • -74
    • +0
    /Ringtoets/DuneErosion/test/Ringtoets.DuneErosion.Plugin.Test/PropertyInfos/DuneLocationPropertyInfoTest.cs
    • -85
    • +0
    /Ringtoets/DuneErosion/test/Ringtoets.DuneErosion.Plugin.Test/PropertyInfos/DuneLocationsContextPropertyInfoTest.cs
    • -3
    • +3
    /Ringtoets/DuneErosion/test/Ringtoets.DuneErosion.Plugin.Test/Ringtoets.DuneErosion.Plugin.Test.csproj
    • -0
    • +416
    /Ringtoets/DuneErosion/test/Ringtoets.DuneErosion.Plugin.Test/ViewInfos/DuneLocationCalculationsViewInfoTest.cs
    • -416
    • +0
    /Ringtoets/DuneErosion/test/Ringtoets.DuneErosion.Plugin.Test/ViewInfos/DuneLocationsViewInfoTest.cs
1:44 pm

Dennis Tang <dennis.tang@deltares.nl>

Cleanup: - Ran DeltaresClean

WTI-1575

Options
    • -1
    • +0
    /Ringtoets/DuneErosion/test/Ringtoets.DuneErosion.Integration.Test/DuneErosionBoundaryCalculationActivityIntegrationTest.cs
1:44 pm

Dennis Tang <dennis.tang@deltares.nl>

Rewire plugin: - Adjusted validation logic: validation should be based on the amount of calculations that are present and not by the amount of locations -- Fixed failing tests for the DuneLocationCalculationsContextTreeNodeInfoTest

WTI-1575

Options
    • -6
    • +10
    /Ringtoets/DuneErosion/src/Ringtoets.DuneErosion.Plugin/DuneErosionPlugin.cs
    • -14
    • +18
    /Ringtoets/DuneErosion/test/Ringtoets.DuneErosion.Plugin.Test/TreeNodeInfos/DuneLocationCalculationsContextTreeNodeInfoTest.cs
1:24 pm

Dennis Tang <dennis.tang@deltares.nl>

Rewire plugin: - Temporary feed the calculations for the factorized lower limit norm as input for the context in order to keep the tests running --> 5 treenodes are not exposed yet -- Fixed failing test for the FailureMechanismContextTreeNodeInfoTest

WTI-1575

Options
    • -1
    • +1
    /Ringtoets/DuneErosion/test/Ringtoets.DuneErosion.Plugin.Test/TreeNodeInfos/DuneErosionFailureMechanismContextTreeNodeInfoTest.cs
11:45 am

Dennis Tang <dennis.tang@deltares.nl>

Rewire plugin: - Fixed failing tests related to the property info --> corrected the datatype from dune location to dune location calculation

WTI-1575

Options
    • -2
    • +2
    /Ringtoets/DuneErosion/src/Ringtoets.DuneErosion.Plugin/DuneErosionPlugin.cs
    • -1
    • +1
    /Ringtoets/DuneErosion/test/Ringtoets.DuneErosion.Plugin.Test/DuneErosionPluginTest.cs
    • -7
    • +7
    /Ringtoets/DuneErosion/test/Ringtoets.DuneErosion.Plugin.Test/PropertyInfos/DuneLocationPropertyInfoTest.cs
11:41 am

Dennis Tang <dennis.tang@deltares.nl>

Rewire plugin: - Fixed compilation errors - Temporary feed the calculations for the factorized lower limit norm as input for the context in order to keep the tests running --> 5 treenodes are not exposed yet - Fixed failing test related to the DuneErosionPlugin

WTI-1575

Options
    • -2
    • +2
    /Ringtoets/DuneErosion/src/Ringtoets.DuneErosion.Plugin/DuneErosionPlugin.cs
    • -1
    • +1
    /Ringtoets/DuneErosion/test/Ringtoets.DuneErosion.Plugin.Test/DuneErosionPluginTest.cs
11:27 am

Dennis Tang <dennis.tang@deltares.nl>

Rewire views: - Fixed compilation errors and failed tests for hte corresponding ViewInfoTests

WTI-1575

Options
    • -36
    • +29
    /Ringtoets/DuneErosion/test/Ringtoets.DuneErosion.Plugin.Test/ViewInfos/DuneLocationsViewInfoTest.cs
11:23 am

Dennis Tang <dennis.tang@deltares.nl>

Rewire views: - Cleanup test: -- Corrected test names -- Surrounded remaining instantiations of the dune erosion location calculations view with using() statements

WTI-1575

Options
    • -1
    • +1
    /Ringtoets/DuneErosion/test/Ringtoets.DuneErosion.Forms.Test/Ringtoets.DuneErosion.Forms.Test.csproj
    • -91
    • +93
    /Ringtoets/DuneErosion/test/Ringtoets.DuneErosion.Forms.Test/Views/DuneLocationCalculationsViewTest.cs
11:19 am

Dennis Tang <dennis.tang@deltares.nl>

Rewire views: - Renamed view object: calculations are now displayed instead of locations --> renamed

WTI-1575

Options
    • -3
    • +3
    /Ringtoets/DuneErosion/src/Ringtoets.DuneErosion.Forms/Ringtoets.DuneErosion.Forms.csproj
    • -0
    • +45
    /Ringtoets/DuneErosion/src/Ringtoets.DuneErosion.Forms/Views/DuneLocationCalculationsView.Designer.cs
    • -0
    • +183
    /Ringtoets/DuneErosion/src/Ringtoets.DuneErosion.Forms/Views/DuneLocationCalculationsView.cs
    • -45
    • +0
    /Ringtoets/DuneErosion/src/Ringtoets.DuneErosion.Forms/Views/DuneLocationsView.Designer.cs
    • -183
    • +0
    /Ringtoets/DuneErosion/src/Ringtoets.DuneErosion.Forms/Views/DuneLocationsView.cs
    • -4
    • +3
    /Ringtoets/DuneErosion/src/Ringtoets.DuneErosion.Plugin/DuneErosionPlugin.cs
    • -0
    • +709
    /Ringtoets/DuneErosion/test/Ringtoets.DuneErosion.Forms.Test/Views/DuneLocationCalculationsViewTest.cs
    • -709
    • +0
    /Ringtoets/DuneErosion/test/Ringtoets.DuneErosion.Forms.Test/Views/DuneLocationsViewTest.cs
    • -5
    • +5
    /Ringtoets/DuneErosion/test/Ringtoets.DuneErosion.Integration.Test/DuneLocationsViewIntegrationTest.cs
    • -1
    • +1
    /Ringtoets/DuneErosion/test/Ringtoets.DuneErosion.Plugin.Test/DuneErosionPluginTest.cs
11:16 am

Dennis Tang <dennis.tang@deltares.nl>

Rewire views: - Renamed row object: they don't wrap around a location, but a calculation --> renamed

WTI-1575

Options
    • -1
    • +1
    /Ringtoets/DuneErosion/src/Ringtoets.DuneErosion.Forms/Ringtoets.DuneErosion.Forms.csproj
    • -0
    • +149
    /Ringtoets/DuneErosion/src/Ringtoets.DuneErosion.Forms/Views/DuneLocationCalculationRow.cs
    • -149
    • +0
    /Ringtoets/DuneErosion/src/Ringtoets.DuneErosion.Forms/Views/DuneLocationRow.cs
    • -11
    • +11
    /Ringtoets/DuneErosion/src/Ringtoets.DuneErosion.Forms/Views/DuneLocationsView.cs
    • -3
    • +3
    /Ringtoets/DuneErosion/src/Ringtoets.DuneErosion.Forms/Views/DuneLocationsViewBase.cs
    • -1
    • +1
    /Ringtoets/DuneErosion/test/Ringtoets.DuneErosion.Forms.Test/Ringtoets.DuneErosion.Forms.Test.csproj
    • -0
    • +100
    /Ringtoets/DuneErosion/test/Ringtoets.DuneErosion.Forms.Test/Views/DuneLocationCalculationRowTest.cs
    • -100
    • +0
    /Ringtoets/DuneErosion/test/Ringtoets.DuneErosion.Forms.Test/Views/DuneLocationRowTest.cs
    • -1
    • +1
    /Ringtoets/DuneErosion/test/Ringtoets.DuneErosion.Forms.Test/Views/DuneLocationsViewBaseTest.cs
    • -1
    • +1
    /Ringtoets/DuneErosion/test/Ringtoets.DuneErosion.Forms.Test/Views/DuneLocationsViewTest.cs
11:13 am

Dennis Tang <dennis.tang@deltares.nl>

Rewire views: - Cleanup test: -- Surrounded every instantiation of the View with an using() statement -- Rewired correct observers for when a calculation is done

WTI-1575

Options
    • -120
    • +130
    /Ringtoets/DuneErosion/test/Ringtoets.DuneErosion.Forms.Test/Views/DuneLocationsViewTest.cs
10:55 am

Dennis Tang <dennis.tang@deltares.nl>

Rewire views: - Adapted View for DuneLocations --> selection is based on calculations. -- Removed GetCalculationFunc constructor argument

WTI-1575

Options
    • -28
    • +17
    /Ringtoets/DuneErosion/src/Ringtoets.DuneErosion.Forms/Views/DuneLocationsView.cs
    • -147
    • +125
    /Ringtoets/DuneErosion/test/Ringtoets.DuneErosion.Forms.Test/Views/DuneLocationsViewTest.cs
    • -22
    • +19
    /Ringtoets/DuneErosion/test/Ringtoets.DuneErosion.Integration.Test/DuneLocationsViewIntegrationTest.cs
9:44 am

Dennis Tang <dennis.tang@deltares.nl>

Rewire views: - Adapted ViewBase for DuneLocations --> selection is based on calculations.

WTI-1575

Options
    • -1
    • +1
    /Ringtoets/DuneErosion/src/Ringtoets.DuneErosion.Forms/Views/DuneLocationsViewBase.cs
    • -6
    • +5
    /Ringtoets/DuneErosion/test/Ringtoets.DuneErosion.Forms.Test/Views/DuneLocationsViewBaseTest.cs
9:36 am

Dennis Tang <dennis.tang@deltares.nl>

Rewire views: - Adapted the row to wrap around a dune location calculation instead of a dune location.

WTI-1575

Options
    • -26
    • +14
    /Ringtoets/DuneErosion/src/Ringtoets.DuneErosion.Forms/Views/DuneLocationRow.cs
    • -17
    • +5
    /Ringtoets/DuneErosion/test/Ringtoets.DuneErosion.Forms.Test/Views/DuneLocationRowTest.cs
9:15 am

Dennis Tang <dennis.tang@deltares.nl>

Rewire calculation services / activities: - Removed the dunelocation parameter when calling the GUIService: the dune location calculations already contain the dune location

WTI-1575

Options
    • -20
    • +11
    /Ringtoets/DuneErosion/src/Ringtoets.DuneErosion.Forms/GuiServices/DuneLocationCalculationGuiService.cs
    • -1
    • +0
    /Ringtoets/DuneErosion/src/Ringtoets.DuneErosion.Plugin/DuneErosionPlugin.cs
    • -37
    • +12
    /Ringtoets/DuneErosion/test/Ringtoets.DuneErosion.Forms.Test/GuiServices/DuneLocationCalculationGuiServiceTest.cs
8:51 am

Dennis Tang <dennis.tang@deltares.nl>

Rewire calculation services / activities: - Cleaned up tests for the services

WTI-1575

Options
    • -51
    • +8
    /Ringtoets/DuneErosion/test/Ringtoets.DuneErosion.Service.Test/DuneErosionBoundaryCalculationServiceTest.cs