Riskeer

Clone Tools

Stats

Commits this week: 0
Total Committers: 28
Last Commit: 26 Nov
Commits this week: 0

Lines of code count not available

Commit Activity

Commits By Day In Week
52 week commits volume
Commits By Day In Week
Commits by day
Commits By Day In Week
Commits by hour
Commits By Hour In Day
Commit calendar
 

Most active committers (90 days)

loading
loading
  • last updated a few seconds ago
All Commits Reviews
Constraints
Constraints: committers
 
Constraints: files
Constraints: dates
Thursday 24 May 2018
12:04 pm

Dennis Tang <dennis.tang@deltares.nl>

Finalise release, made 18.1 compatible with the 'new' 17.3 release: - Adjusted migration script, table HydraRingpreprocessorEntity does not exist in the new 17.3 release -- Adjusted testfile, reopened and saved the test file in the 'new' 17.3 release to get rid of the HydraRingPreprocessorEntityTable

WTI-1710

Options
    • -1
    • +0
    /Application/Ringtoets/src/Application.Ringtoets.Migration.Core/EmbeddedResources/Migration_17.3_18.1.sql
    • binary
    /Application/Ringtoets/test/Application.Ringtoets.Migration.Core.Test/test-data/MigrationTestProject173.rtd
    • -1
    • +0
    /Application/Ringtoets/test/Application.Ringtoets.Storage.Test/IntegrationTests/MigrationTo181IntegrationTest.cs
12:00 pm

Robert Tangerman <robert.tangerman@deltares.nl>

Improvements after review. WTI-1683

Options
    • -0
    • +10
    /Ringtoets/Integration/src/Ringtoets.Integration.Data/Assembly/AssessmentSectionAssemblyFactory.cs
    • -41
    • +32
    /Ringtoets/Integration/src/Ringtoets.Integration.Data/Assembly/CombinedAssemblyFailureMechanismSectionFactory.cs
    • -6
    • +6
    /Ringtoets/Integration/src/Ringtoets.Integration.Data/Assembly/CombinedFailureMechanismSectionAssemblyResult.cs
    • -1
    • +1
    /Ringtoets/Integration/src/Ringtoets.Integration.Data/Assembly/CombinedFailureMechanismSectionAssemblyResultFactory.cs
    • -2
    • +2
    /Ringtoets/Integration/src/Ringtoets.Integration.Forms/Views/CombinedFailureMechanismSectionAssemblyResultRow.cs
    • -1
    • +1
    /Ringtoets/Integration/test/Ringtoets.Integration.Data.Test/Assembly/AssessmentSectionAssemblyFactoryTest.cs
    • -2
    • +2
    /Ringtoets/Integration/test/Ringtoets.Integration.Data.Test/Assembly/CombinedFailureMechanismSectionAssemblyResultFactoryTest.cs
    • -3
    • +3
    /Ringtoets/Integration/test/Ringtoets.Integration.Data.Test/Assembly/CombinedFailureMechanismSectionAssemblyResultTest.cs
    • -3
    • +3
    /Ringtoets/Integration/test/Ringtoets.Integration.Forms.Test/Views/CombinedFailureMechanismSectionAssemblyResultRowTest.cs
11:52 am

Robert Tangerman <robert.tangerman@deltares.nl>

Improvements after review. WTI-1683

Options
    • -2
    • +2
    /Ringtoets/ClosingStructures/src/Ringtoets.ClosingStructures.Data/ClosingStructuresFailureMechanismAssemblyFactory.cs
    • -2
    • +2
    /Ringtoets/DuneErosion/src/Ringtoets.DuneErosion.Data/DuneErosionFailureMechanismAssemblyFactory.cs
    • -2
    • +2
    /Ringtoets/GrassCoverErosionInwards/src/Ringtoets.GrassCoverErosionInwards.Data/GrassCoverErosionInwardsFailureMechanismAssemblyFactory.cs
    • -2
    • +2
    /Ringtoets/GrassCoverErosionOutwards/src/Ringtoets.GrassCoverErosionOutwards.Data/GrassCoverErosionOutwardsFailureMechanismAssemblyFactory.cs
    • -2
    • +2
    /Ringtoets/HeightStructures/src/Ringtoets.HeightStructures.Data/HeightStructuresFailureMechanismAssemblyFactory.cs
    • -2
    • +2
    /Ringtoets/Integration/src/Ringtoets.Integration.Data/StandAlone/AssemblyFactories/GrassCoverSlipOffInwardsFailureMechanismAssemblyFactory.cs
    • -2
    • +2
    /Ringtoets/Integration/src/Ringtoets.Integration.Data/StandAlone/AssemblyFactories/GrassCoverSlipOffOutwardsFailureMechanismAssemblyFactory.cs
    • -1
    • +1
    /Ringtoets/Integration/src/Ringtoets.Integration.Data/StandAlone/AssemblyFactories/MacroStabilityOutwardsFailureMechanismAssemblyFactory.cs
    • -2
    • +2
    /Ringtoets/Integration/src/Ringtoets.Integration.Data/StandAlone/AssemblyFactories/MicrostabilityFailureMechanismAssemblyFactory.cs
    • -2
    • +2
    /Ringtoets/Integration/src/Ringtoets.Integration.Data/StandAlone/AssemblyFactories/PipingStructureFailureMechanismAssemblyFactory.cs
    • -2
    • +2
    /Ringtoets/Integration/src/Ringtoets.Integration.Data/StandAlone/AssemblyFactories/StrengthStabilityLengthwiseConstructionFailureMechanismAssemblyFactory.cs
    • -2
    • +2
    /Ringtoets/Integration/src/Ringtoets.Integration.Data/StandAlone/AssemblyFactories/TechnicalInnovationFailureMechanismAssemblyFactory.cs
    • -2
    • +2
    /Ringtoets/Integration/src/Ringtoets.Integration.Data/StandAlone/AssemblyFactories/WaterPressureAsphaltCoverFailureMechanismAssemblyFactory.cs
    • -2
    • +2
    /Ringtoets/MacroStabilityInwards/src/Ringtoets.MacroStabilityInwards.Data/MacroStabilityInwardsFailureMechanismAssemblyFactory.cs
    • -2
    • +2
    /Ringtoets/Piping/src/Ringtoets.Piping.Data/PipingFailureMechanismAssemblyFactory.cs
  16. … 3 more files in changeset.
11:39 am

Robert Tangerman <robert.tangerman@deltares.nl>

Improvements after review. WTI-1683

Options
    • -1
    • +1
    /Ringtoets/AssemblyTool/src/Ringtoets.AssemblyTool.KernelWrapper/Calculators/Assembly/AssessmentSectionAssemblyCalculator.cs
    • -0
    • +79
    /Ringtoets/AssemblyTool/src/Ringtoets.AssemblyTool.KernelWrapper/Creators/AssemblyCalculatorInputCreator.cs
    • -48
    • +2
    /Ringtoets/AssemblyTool/src/Ringtoets.AssemblyTool.KernelWrapper/Creators/FailureMechanismSectionAssemblyCalculatorInputCreator.cs
    • -35
    • +6
    /Ringtoets/AssemblyTool/src/Ringtoets.AssemblyTool.KernelWrapper/Creators/FailureMechanismSectionListCreator.cs
    • -0
    • +1
    /Ringtoets/AssemblyTool/src/Ringtoets.AssemblyTool.KernelWrapper/Ringtoets.AssemblyTool.KernelWrapper.csproj
    • -1
    • +1
    /Ringtoets/AssemblyTool/test/Ringtoets.AssemblyTool.KernelWrapper.Test/Calculators/Assembly/AssessmentSectionAssemblyCalculatorTest.cs
    • -39
    • +24
    /Ringtoets/AssemblyTool/test/Ringtoets.AssemblyTool.KernelWrapper.Test/Calculators/Assembly/FailureMechanismSectionAssemblyCalculatorTest.cs
    • -0
    • +68
    /Ringtoets/AssemblyTool/test/Ringtoets.AssemblyTool.KernelWrapper.Test/Creators/AssemblyCalculatorInputCreatorTest.cs
    • -2
    • +3
    /Ringtoets/AssemblyTool/test/Ringtoets.AssemblyTool.KernelWrapper.Test/Creators/CombinedFailureMechanismSectionAssemblyCreatorTest.cs
    • -2
    • +2
    /Ringtoets/AssemblyTool/test/Ringtoets.AssemblyTool.KernelWrapper.Test/Creators/FailureMechanismSectionListCreatorTest.cs
    • -0
    • +1
    /Ringtoets/AssemblyTool/test/Ringtoets.AssemblyTool.KernelWrapper.Test/Ringtoets.AssemblyTool.KernelWrapper.Test.csproj
    • -27
    • +35
    /Ringtoets/AssemblyTool/test/Ringtoets.AssemblyTool.KernelWrapper.TestUtil/AssemblyCategoryAssert.cs
    • -38
    • +11
    /Ringtoets/AssemblyTool/test/Ringtoets.AssemblyTool.KernelWrapper.TestUtil/CombinedFailureMechanismSectionAssemblyAssert.cs
    • -8
    • +9
    /Ringtoets/AssemblyTool/test/Ringtoets.AssemblyTool.KernelWrapper.TestUtil/CombinedFailureMechanismSectionsInputAssert.cs
11:12 am

Dennis Tang <dennis.tang@deltares.nl>

Incorporated comments review 2824: - Renamed assert function in the test

WTI-1574

Options
    • -7
    • +7
    /Ringtoets/Integration/test/Ringtoets.Integration.TestUtil.Test/TestDataGeneratorTest.cs
10:49 am

Robert Tangerman <robert.tangerman@deltares.nl>

Fixed meter / kilometer conversion. WTI-1683

Options
    • -5
    • +5
    /Ringtoets/AssemblyTool/src/Ringtoets.AssemblyTool.Data/CombinedAssemblyFailureMechanismSection.cs
    • -2
    • +4
    /Ringtoets/Integration/src/Ringtoets.Integration.Data/Assembly/CombinedFailureMechanismSectionAssemblyResult.cs
    • -2
    • +2
    /Ringtoets/Integration/src/Ringtoets.Integration.Data/Assembly/CombinedFailureMechanismSectionAssemblyResultFactory.cs
    • -2
    • +2
    /Ringtoets/Integration/src/Ringtoets.Integration.Forms/Views/CombinedFailureMechanismSectionAssemblyResultRow.cs
    • -4
    • +4
    /Ringtoets/Integration/test/Ringtoets.Integration.Data.Test/Assembly/CombinedFailureMechanismSectionAssemblyResultFactoryTest.cs
10:36 am

Dennis Tang <dennis.tang@deltares.nl>

Incorporated comments review 2824, get rid of the 'Erosion' intermediate suffix to prevent confusion: - Renamed the service

WTI-1574

Options
    • -263
    • +0
    /Ringtoets/DuneErosion/src/Ringtoets.DuneErosion.Service/DuneErosionBoundaryCalculationService.cs
    • -3
    • +3
    /Ringtoets/DuneErosion/src/Ringtoets.DuneErosion.Service/DuneLocationCalculationActivity.cs
    • -0
    • +263
    /Ringtoets/DuneErosion/src/Ringtoets.DuneErosion.Service/DuneLocationCalculationService.cs
    • -1
    • +1
    /Ringtoets/DuneErosion/src/Ringtoets.DuneErosion.Service/Ringtoets.DuneErosion.Service.csproj
    • -534
    • +0
    /Ringtoets/DuneErosion/test/Ringtoets.DuneErosion.Service.Test/DuneErosionBoundaryCalculationServiceTest.cs
    • -0
    • +534
    /Ringtoets/DuneErosion/test/Ringtoets.DuneErosion.Service.Test/DuneLocationCalculationServiceTest.cs
    • -1
    • +1
    /Ringtoets/DuneErosion/test/Ringtoets.DuneErosion.Service.Test/Ringtoets.DuneErosion.Service.Test.csproj
10:32 am

Dennis Tang <dennis.tang@deltares.nl>

Incorporated comments review 2824, get rid of the 'Erosion' intermediate suffix to prevent confusion: - Renamed the activitiy

WTI-1574

Options
    • -4
    • +4
    /Ringtoets/DuneErosion/src/Ringtoets.DuneErosion.Forms/GuiServices/DuneLocationCalculationGuiService.cs
    • -116
    • +0
    /Ringtoets/DuneErosion/src/Ringtoets.DuneErosion.Service/DuneErosionBoundaryCalculationActivity.cs
    • -0
    • +116
    /Ringtoets/DuneErosion/src/Ringtoets.DuneErosion.Service/DuneLocationCalculationActivity.cs
    • -1
    • +1
    /Ringtoets/DuneErosion/src/Ringtoets.DuneErosion.Service/Ringtoets.DuneErosion.Service.csproj
    • -12
    • +12
    /Ringtoets/DuneErosion/test/Ringtoets.DuneErosion.Integration.Test/DuneErosionBoundaryCalculationActivityIntegrationTest.cs
    • -441
    • +0
    /Ringtoets/DuneErosion/test/Ringtoets.DuneErosion.Service.Test/DuneErosionBoundaryCalculationActivityTest.cs
    • -0
    • +441
    /Ringtoets/DuneErosion/test/Ringtoets.DuneErosion.Service.Test/DuneLocationCalculationActivityTest.cs
    • -1
    • +1
    /Ringtoets/DuneErosion/test/Ringtoets.DuneErosion.Service.Test/Ringtoets.DuneErosion.Service.Test.csproj
10:30 am

Dennis Tang <dennis.tang@deltares.nl>

Incorporated comments review 2824, get rid of the 'Erosion' intermediate suffix to prevent confusion: - Updated XMLDocs

WTI-1574

Options
    • -1
    • +1
    /Ringtoets/DuneErosion/src/Ringtoets.DuneErosion.Data/DuneLocation.cs
    • -1
    • +1
    /Ringtoets/DuneErosion/src/Ringtoets.DuneErosion.Data/DuneLocationCalculation.cs
9:34 am

Dennis Tang <dennis.tang@deltares.nl>

Incorporated comments review 2824, get rid of the 'Erosion' intermediate suffix to prevent confusion: - Cleaned tests - Updated function names in the data synchronization service to make it consistent with grass cover erosion outwards

WTI-1574

Options
    • -1
    • +1
    /Ringtoets/DuneErosion/src/Ringtoets.DuneErosion.Forms/DuneErosionFailureMechanismPropertyChangeHandler.cs
    • -1
    • +1
    /Ringtoets/DuneErosion/src/Ringtoets.DuneErosion.Service/DuneErosionDataSynchronizationService.cs
    • -4
    • +4
    /Ringtoets/DuneErosion/test/Ringtoets.DuneErosion.Service.Test/DuneErosionDataSynchronizationServiceTest.cs
    • -1
    • +1
    /Ringtoets/Integration/src/Ringtoets.Integration.Service/RingtoetsDataSynchronizationService.cs
    • -12
    • +12
    /Ringtoets/Integration/test/Ringtoets.Integration.Plugin.Test/Handlers/AssessmentSectionCompositionChangeHandlerTest.cs
9:24 am

Dennis Tang <dennis.tang@deltares.nl>

Incorporated comments review 2824, get rid of the 'Erosion' intermediate suffix to prevent confusion: - Renamed the DuneErosionLocationsHelper --> DuneLocationCalculationsHelper. -- Updated function names and XMLDoc

WTI-1574

Options
    • -117
    • +0
    /Ringtoets/DuneErosion/test/Ringtoets.DuneErosion.Data.TestUtil.Test/DuneErosionLocationsTestHelperTest.cs
    • -0
    • +117
    /Ringtoets/DuneErosion/test/Ringtoets.DuneErosion.Data.TestUtil.Test/DuneLocationCalculationsTestHelperTest.cs
    • -1
    • +1
    /Ringtoets/DuneErosion/test/Ringtoets.DuneErosion.Data.TestUtil.Test/Ringtoets.DuneErosion.Data.TestUtil.Test.csproj
    • -88
    • +0
    /Ringtoets/DuneErosion/test/Ringtoets.DuneErosion.Data.TestUtil/DuneErosionLocationsTestHelper.cs
    • -0
    • +88
    /Ringtoets/DuneErosion/test/Ringtoets.DuneErosion.Data.TestUtil/DuneLocationCalculationsTestHelper.cs
    • -1
    • +1
    /Ringtoets/DuneErosion/test/Ringtoets.DuneErosion.Data.TestUtil/Ringtoets.DuneErosion.Data.TestUtil.csproj
    • -2
    • +2
    /Ringtoets/DuneErosion/test/Ringtoets.DuneErosion.Service.Test/DuneErosionDataSynchronizationServiceTest.cs
    • -5
    • +5
    /Ringtoets/Integration/test/Ringtoets.Integration.Plugin.Test/Handlers/AssessmentSectionCompositionChangeHandlerTest.cs
    • -3
    • +3
    /Ringtoets/Integration/test/Ringtoets.Integration.Plugin.Test/Handlers/FailureMechanismContributionNormChangeHandlerTest.cs
    • -4
    • +4
    /Ringtoets/Integration/test/Ringtoets.Integration.Service.Test/RingtoetsDataSynchronizationServiceTest.cs
9:21 am

Carlos Lubbers

Implement review comments, add asserts for per section view WTI-1689

Options
    • -0
    • +3
    /Ringtoets/Integration/test/Ringtoets.Integration.Forms.Test/Views/AssemblyResultPerSectionViewTest.cs
9:12 am

Dennis Tang <dennis.tang@deltares.nl>

Incorporated comments review 2824: - Made the generation of dune locations (and calculation output) similar to grass cover erosion outwards implementation for the test data generator -- Updated XMLDoc -- Cleaned up files. Added CollectionAssert.IsNotEmpty checks to certain collections, because .All() returns TRUE in case of an empty collection

WTI-1574

Options
    • -74
    • +26
    /Ringtoets/Integration/test/Ringtoets.Integration.TestUtil.Test/TestDataGeneratorTest.cs
    • -17
    • +7
    /Ringtoets/Integration/test/Ringtoets.Integration.TestUtil/TestDataGenerator.cs
7:33 am

Robert Tangerman <robert.tangerman@deltares.nl>

Made sure icons wouldn't overlap. WTI-1684

Options
    • -0
    • +3
    /Ringtoets/Integration/src/Ringtoets.Integration.Forms/Views/AssemblyResultPerSectionView.cs
    • -5
    • +44
    /Ringtoets/Integration/test/Ringtoets.Integration.Forms.Test/Views/AssemblyResultPerSectionViewTest.cs
Wednesday 23 May 2018
5:10 pm

Carlos Lubbers

Move icon padding to designer WTI-1687

Options
    • -1
    • +3
    /Ringtoets/Integration/src/Ringtoets.Integration.Forms/Views/AssemblyResultPerSectionView.Designer.cs
    • -3
    • +0
    /Ringtoets/Integration/src/Ringtoets.Integration.Forms/Views/AssemblyResultPerSectionView.cs
    • -0
    • +1
    /Ringtoets/Integration/src/Ringtoets.Integration.Forms/Views/AssemblyResultTotalView.Designer.cs
    • -2
    • +0
    /Ringtoets/Integration/src/Ringtoets.Integration.Forms/Views/AssemblyResultTotalView.cs
5:06 pm

Carlos Lubbers

Implement review comments WTI-1687

Options
    • -6
    • +7
    /Ringtoets/Common/src/Ringtoets.Common.Forms/Observers/CalculatableFailureMechanismResultObserver.cs
    • -2
    • +2
    /Ringtoets/Common/test/Ringtoets.Common.Forms.Test/Observers/CalculatableFailureMechanismResultObserverTest.cs
    • -6
    • +6
    /Ringtoets/Common/test/Ringtoets.Common.Forms.Test/Observers/FailureMechanismResultObserverTest.cs
    • -1
    • +0
    /Ringtoets/Integration/src/Ringtoets.Integration.Forms/Observers/AssessmentSectionResultObserver.cs
    • -3
    • +3
    /Ringtoets/Integration/src/Ringtoets.Integration.Forms/Properties/Resources.Designer.cs
    • -1
    • +1
    /Ringtoets/Integration/src/Ringtoets.Integration.Forms/Properties/Resources.resx
    • -2
    • +2
    /Ringtoets/Integration/src/Ringtoets.Integration.Forms/Views/AssemblyResultPerSectionView.cs
    • -1
    • +1
    /Ringtoets/Integration/src/Ringtoets.Integration.Forms/Views/AssemblyResultTotalView.cs
    • -40
    • +45
    /Ringtoets/Integration/test/Ringtoets.Integration.Forms.Test/Observers/AssessmentSectionResultObserverTest.cs
    • -3
    • +6
    /Ringtoets/Integration/test/Ringtoets.Integration.Forms.Test/Views/AssemblyResultPerSectionViewTest.cs
    • -2
    • +4
    /Ringtoets/Integration/test/Ringtoets.Integration.Forms.Test/Views/AssemblyResultTotalViewTest.cs
4:22 pm

Dennis Tang <dennis.tang@deltares.nl>

Incorporated comments review 2824: - Updated XMLDoc for the Integration.Service -- Improved and cleaned up tests

WTI-1574

Options
    • -6
    • +7
    /Ringtoets/Integration/src/Ringtoets.Integration.Service/RingtoetsDataSynchronizationService.cs
    • -2
    • +2
    /Ringtoets/Integration/test/Ringtoets.Integration.Plugin.Test/Handlers/AssessmentSectionCompositionChangeHandlerTest.cs
    • -3
    • +3
    /Ringtoets/Integration/test/Ringtoets.Integration.Plugin.Test/Handlers/FailureMechanismContributionNormChangeHandlerTest.cs
    • -4
    • +27
    /Ringtoets/Integration/test/Ringtoets.Integration.Service.Test/RingtoetsDataSynchronizationServiceTest.cs
3:25 pm

Dennis Tang <dennis.tang@deltares.nl>

Incorporated comments review 2824: - Cleaned up tests related to the .Forms, .Plugin and .Service namespaces of DuneErosion.

WTI-1574

Options
    • -11
    • +10
    /Ringtoets/DuneErosion/test/Ringtoets.DuneErosion.Forms.Test/DuneErosionFailureMechanismPropertyChangeHandlerTest.cs
    • -1
    • +0
    /Ringtoets/DuneErosion/test/Ringtoets.DuneErosion.Forms.Test/Views/DuneLocationCalculationRowTest.cs
    • -0
    • +5
    /Ringtoets/DuneErosion/test/Ringtoets.DuneErosion.Plugin.Test/Handlers/DuneLocationsReplacementHandlerTest.cs
    • -3
    • +3
    /Ringtoets/DuneErosion/test/Ringtoets.DuneErosion.Plugin.Test/ViewInfos/DuneLocationCalculationsViewInfoTest.cs
    • -5
    • +0
    /Ringtoets/DuneErosion/test/Ringtoets.DuneErosion.Service.Test/DuneErosionBoundaryCalculationServiceTest.cs
    • -1
    • +1
    /Ringtoets/DuneErosion/test/Ringtoets.DuneErosion.Service.Test/DuneErosionDataSynchronizationServiceTest.cs
3:16 pm

Dennis Tang <dennis.tang@deltares.nl>

Incorporated comments review 2824: - Updated GrassCoverErosionOutwardsHydraulicBoundaryLocationsTestHelper: -- Updated helper function and added missing test.

WTI-1574

Options
    • -0
    • +12
    /Ringtoets/GrassCoverErosionOutwards/test/Ringtoets.GrassCoverErosionOutwards.Data.TestUtil.Test/GrassCoverErosionOutwardsHydraulicBoundaryLocationsTestHelperTest.cs
    • -6
    • +6
    /Ringtoets/GrassCoverErosionOutwards/test/Ringtoets.GrassCoverErosionOutwards.Data.TestUtil/GrassCoverErosionOutwardsHydraulicBoundaryLocationsTestHelper.cs
3:09 pm

Dennis Tang <dennis.tang@deltares.nl>

Incorporated comments review 2824: - Updated DuneLocationsTestHelper

WTI-1574

Options
    • -2
    • +13
    /Ringtoets/DuneErosion/test/Ringtoets.DuneErosion.Data.TestUtil.Test/DuneErosionLocationsTestHelperTest.cs
    • -10
    • +15
    /Ringtoets/DuneErosion/test/Ringtoets.DuneErosion.Data.TestUtil/DuneErosionLocationsTestHelper.cs
2:59 pm

Robert Tangerman <robert.tangerman@deltares.nl>

Changed type of category group when not in list. WTI-1683

Options
    • -91
    • +57
    /Ringtoets/Integration/src/Ringtoets.Integration.Data/Assembly/CombinedFailureMechanismSectionAssemblyResultFactory.cs
    • -18
    • +18
    /Ringtoets/Integration/test/Ringtoets.Integration.Data.Test/Assembly/CombinedFailureMechanismSectionAssemblyResultFactoryTest.cs
2:45 pm

Dennis Tang <dennis.tang@deltares.nl>

Incorporated comments review 2824: - Updated XMLDoc - Optimised iteration, changed parameter names for clarity

for the namespaces DuneErosion.Forms, .Plugin and .Service

WTI-1574

Options
    • -1
    • +1
    /Ringtoets/DuneErosion/src/Ringtoets.DuneErosion.Forms/DuneErosionFailureMechanismPropertyChangeHandler.cs
    • -10
    • +4
    /Ringtoets/DuneErosion/src/Ringtoets.DuneErosion.Service/DuneErosionDataSynchronizationService.cs
2:42 pm

Dennis Tang <dennis.tang@deltares.nl>

Incorporated comments review 2824, adjusted dune location reader: - Results should be cached by the reader already before setting the results onto the failure mechanism

WTI-1574

Options
    • -1
    • +4
    /Ringtoets/DuneErosion/src/Ringtoets.DuneErosion.IO/DuneLocationsReader.cs
    • -2
    • +4
    /Ringtoets/DuneErosion/src/Ringtoets.DuneErosion.Plugin/Handlers/DuneLocationsReplacementHandler.cs
2:26 pm

Dennis Tang <dennis.tang@deltares.nl>

Incorporated comments review 2824, rename SetDuneLocationCalculations to SetDuneLocations: - Exposed ClearDuneLocationData() in order to clear all dune location (and associated calculations) when necessary.

WTI-1574

Options
    • -11
    • +14
    /Ringtoets/DuneErosion/src/Ringtoets.DuneErosion.Data/DuneErosionFailureMechanism.cs
    • -1
    • +1
    /Ringtoets/DuneErosion/src/Ringtoets.DuneErosion.Service/DuneErosionDataSynchronizationService.cs
    • -0
    • +29
    /Ringtoets/DuneErosion/test/Ringtoets.DuneErosion.Data.Test/DuneErosionFailureMechanismTest.cs
2:22 pm

Dennis Tang <dennis.tang@deltares.nl>

Incorporated comments review 2824, rename SetDuneLocationCalculations to SetDuneLocations: - Made the DuneLocations property an IObservableEnumerable --> modifications should not be possible from outside the SetDuneLocations() method to prevent the calculations from getting out of sync with the locations

WTI-1574

Options
    • -6
    • +5
    /Application/Ringtoets/src/Application.Ringtoets.Storage/Read/FailureMechanismEntityReadExtensions.cs
    • -4
    • +4
    /Application/Ringtoets/test/Application.Ringtoets.Storage.Test/Read/FailureMechanismEntityReadExtensionsTest.cs
    • -7
    • +8
    /Application/Ringtoets/test/Application.Ringtoets.Storage.TestUtil.Test/RingtoetsProjectTestHelperTest.cs
    • -3
    • +6
    /Application/Ringtoets/test/Application.Ringtoets.Storage.TestUtil/RingtoetsProjectTestHelper.cs
    • -11
    • +15
    /Ringtoets/DuneErosion/src/Ringtoets.DuneErosion.Data/DuneErosionFailureMechanism.cs
    • -2
    • +3
    /Ringtoets/DuneErosion/src/Ringtoets.DuneErosion.Forms/Views/DuneErosionFailureMechanismView.cs
    • -3
    • +2
    /Ringtoets/DuneErosion/src/Ringtoets.DuneErosion.Plugin/Handlers/DuneLocationsReplacementHandler.cs
    • -6
    • +7
    /Ringtoets/DuneErosion/src/Ringtoets.DuneErosion.Service/DuneErosionDataSynchronizationService.cs
    • -1
    • +0
    /Ringtoets/DuneErosion/test/Ringtoets.DuneErosion.Data.Test/DuneErosionFailureMechanismTest.cs
    • -1
    • +0
    /Ringtoets/DuneErosion/test/Ringtoets.DuneErosion.Data.TestUtil.Test/DuneErosionLocationsTestHelperTest.cs
    • -5
    • +6
    /Ringtoets/DuneErosion/test/Ringtoets.DuneErosion.Forms.Test/DuneErosionFailureMechanismPropertyChangeHandlerTest.cs
    • -34
    • +34
    /Ringtoets/DuneErosion/test/Ringtoets.DuneErosion.Forms.Test/Views/DuneErosionFailureMechanismViewTest.cs
    • -26
    • +20
    /Ringtoets/DuneErosion/test/Ringtoets.DuneErosion.Plugin.Test/Handlers/DuneLocationsReplacementHandlerTest.cs
    • -1
    • +4
    /Ringtoets/DuneErosion/test/Ringtoets.DuneErosion.Plugin.Test/TreeNodeInfos/DuneLocationCalculationsContextTreeNodeInfoTest.cs
    • -4
    • +6
    /Ringtoets/DuneErosion/test/Ringtoets.DuneErosion.Service.Test/DuneErosionDataSynchronizationServiceTest.cs
  16. … 4 more files in changeset.
2:06 pm

Robert Tangerman <robert.tangerman@deltares.nl>

Added mininum width. WTI-1684

Options
    • -0
    • +1
    /Ringtoets/Integration/src/Ringtoets.Integration.Forms/Views/AssemblyResultPerSectionView.Designer.cs
    • -0
    • +2
    /Ringtoets/Integration/test/Ringtoets.Integration.Forms.Test/Views/AssemblyResultPerSectionViewTest.cs
1:52 pm

Dennis Tang <dennis.tang@deltares.nl>

Incorporated comments review 2824, rename SetDuneLocationCalculations to SetDuneLocations: - Changed functionality: function sets the locations as well to keep the calculations and locations synchronised.

WTI-1574

Options
    • -3
    • +10
    /Ringtoets/DuneErosion/src/Ringtoets.DuneErosion.Data/DuneErosionFailureMechanism.cs
    • -1
    • +1
    /Ringtoets/DuneErosion/src/Ringtoets.DuneErosion.Plugin/Handlers/DuneLocationsReplacementHandler.cs
    • -7
    • +11
    /Ringtoets/DuneErosion/test/Ringtoets.DuneErosion.Data.Test/DuneErosionFailureMechanismTest.cs
    • -1
    • +1
    /Ringtoets/DuneErosion/test/Ringtoets.DuneErosion.Data.TestUtil.Test/DuneErosionLocationsTestHelperTest.cs
    • -1
    • +1
    /Ringtoets/DuneErosion/test/Ringtoets.DuneErosion.Forms.Test/DuneErosionFailureMechanismPropertyChangeHandlerTest.cs
    • -1
    • +1
    /Ringtoets/DuneErosion/test/Ringtoets.DuneErosion.Plugin.Test/Handlers/DuneLocationsReplacementHandlerTest.cs
    • -1
    • +1
    /Ringtoets/DuneErosion/test/Ringtoets.DuneErosion.Service.Test/DuneErosionDataSynchronizationServiceTest.cs
    • -1
    • +1
    /Ringtoets/Integration/test/Ringtoets.Integration.Service.Test/RingtoetsDataSynchronizationServiceTest.cs
    • -1
    • +1
    /Ringtoets/Integration/test/Ringtoets.Integration.TestUtil/TestDataGenerator.cs
1:42 pm

Robert Tangerman <robert.tangerman@deltares.nl>

Connected view to factory. WTI-1684

Options
    • -7
    • +7
    /Ringtoets/Integration/src/Ringtoets.Integration.Data/Assembly/AssessmentSectionAssemblyFactory.cs
    • -51
    • +5
    /Ringtoets/Integration/src/Ringtoets.Integration.Forms/Views/AssemblyResultPerSectionView.cs
    • -0
    • +4
    /Ringtoets/Integration/test/Ringtoets.Integration.Forms.Test/Ringtoets.Integration.Forms.Test.csproj
    • -10
    • +24
    /Ringtoets/Integration/test/Ringtoets.Integration.Forms.Test/Views/AssemblyResultPerSectionViewTest.cs
1:41 pm

Robert Tangerman <robert.tangerman@deltares.nl>

Improved calculator stub. WTI-1684

Options
    • -4
    • +1
    /Ringtoets/AssemblyTool/test/Ringtoets.AssemblyTool.KernelWrapper.TestUtil.Test/Calculators/Assembly/AssessmentSectionAssemblyCalculatorStubTest.cs
    • -4
    • +2
    /Ringtoets/AssemblyTool/test/Ringtoets.AssemblyTool.KernelWrapper.TestUtil/Calculators/Assembly/AssessmentSectionAssemblyCalculatorStub.cs
1:33 pm

Dennis Tang <dennis.tang@deltares.nl>

Incorporated comments review 2824: - Renamed DuneLocationOutput to DuneLocationCalculationOutput -- Adjusted CreateExtension file names -- Updated function and parameter names where necessary.

WTI-1574

Options
    • -1
    • +1
    /Application/Ringtoets/src/Application.Ringtoets.Storage/Application.Ringtoets.Storage.csproj
    • -0
    • +58
    /Application/Ringtoets/src/Application.Ringtoets.Storage/Create/DuneErosion/DuneLocationCalculationOutputCreateExtensions.cs
    • -2
    • +2
    /Application/Ringtoets/src/Application.Ringtoets.Storage/Create/DuneErosion/DuneLocationCreateExtensions.cs
    • -58
    • +0
    /Application/Ringtoets/src/Application.Ringtoets.Storage/Create/DuneErosion/DuneLocationOutputCreateExtensions.cs
    • -6
    • +6
    /Application/Ringtoets/src/Application.Ringtoets.Storage/Read/DuneErosion/DuneLocationOutputEntityReadExtensions.cs
    • -1
    • +1
    /Application/Ringtoets/test/Application.Ringtoets.Storage.Test/Application.Ringtoets.Storage.Test.csproj
    • -0
    • +110
    /Application/Ringtoets/test/Application.Ringtoets.Storage.Test/Create/DuneErosion/DuneLocationCalculationOutputCreateExtensionsTest.cs
    • -14
    • +14
    /Application/Ringtoets/test/Application.Ringtoets.Storage.Test/Create/DuneErosion/DuneLocationCreateExtensionsTest.cs
    • -110
    • +0
    /Application/Ringtoets/test/Application.Ringtoets.Storage.Test/Create/DuneErosion/DuneLocationOutputCreateExtensionsTest.cs
    • -2
    • +2
    /Application/Ringtoets/test/Application.Ringtoets.Storage.Test/IntegrationTests/StorageSqLiteIntegrationTest.cs
    • -2
    • +2
    /Application/Ringtoets/test/Application.Ringtoets.Storage.Test/Read/DuneErosion/DuneLocationEntityReadExtensionsTest.cs
    • -2
    • +2
    /Application/Ringtoets/test/Application.Ringtoets.Storage.Test/Read/DuneErosion/DuneLocationOutputEntityReadExtensionsTest.cs
    • -13
    • +13
    /Application/Ringtoets/test/Application.Ringtoets.Storage.TestUtil/RingtoetsProjectTestHelper.cs
    • -1
    • +1
    /Ringtoets/DuneErosion/src/Ringtoets.DuneErosion.Data/DuneLocationCalculation.cs
    • -0
    • +166
    /Ringtoets/DuneErosion/src/Ringtoets.DuneErosion.Data/DuneLocationCalculationOutput.cs
  16. … 29 more files in changeset.