Riskeer

Clone Tools

Stats

Commits this week: 0
Total Committers: 28
Last Commit: 12 Sep 24
Commits this week: 0

Lines of code count not available

Commit Activity

Commits By Day In Week
52 week commits volume
Commits By Day In Week
Commits by day
Commits By Day In Week
Commits by hour
Commits By Hour In Day
Commit calendar
 

Most active committers (90 days)

loading
loading
  • last updated a few seconds ago
All Commits Reviews
Constraints
Constraints: committers
 
Constraints: files
Constraints: dates
Monday 17 Dec 2018
12:23 pm

Robert Tangerman <robert.tangerman@deltares.nl>

Removed dictionary from data model. WTI-1486

Options
    • -14
    • +0
    /Ringtoets/HydraRing/src/Ringtoets.HydraRing.IO/HydraulicLocationConfigurationDatabase/ReadHydraulicLocationConfigurationDatabase.cs
    • -14
    • +1
    /Ringtoets/HydraRing/test/Ringtoets.HydraRing.IO.Test/HydraulicLocationConfigurationDatabase/ReadHydraulicLocationConfigurationDatabaseTest.cs
    • -1
    • +1
    /Ringtoets/Integration/test/Ringtoets.Integration.IO.Test/Importers/HydraulicBoundaryDatabaseImporterTest.cs
12:20 pm

Robert Tangerman <robert.tangerman@deltares.nl>

Adapted test factory. WTI-1486

Options
    • -5
    • +5
    /Ringtoets/HydraRing/test/Ringtoets.HydraRing.IO.TestUtil.Test/ReadHydraulicLocationConfigurationDatabaseTestFactoryTest.cs
    • -8
    • +3
    /Ringtoets/HydraRing/test/Ringtoets.HydraRing.IO.TestUtil/ReadHydraulicLocationConfigurationDatabaseTestFactory.cs
12:18 pm

Robert Tangerman <robert.tangerman@deltares.nl>

Create mappings instead of dictionary in reader. WTI-1486

Options
    • -1
    • +3
    /Ringtoets/Common/src/Ringtoets.Common.IO/FileImporters/HydraulicBoundaryDatabaseImporter.cs
    • -8
    • +9
    /Ringtoets/HydraRing/src/Ringtoets.HydraRing.IO/HydraulicLocationConfigurationDatabase/HydraulicLocationConfigurationDatabaseReader.cs
    • -15
    • +20
    /Ringtoets/HydraRing/test/Ringtoets.HydraRing.IO.Test/HydraulicLocationConfigurationDatabase/HydraulicLocationConfigurationDatabaseReaderTest.cs
10:50 am

Robert Tangerman <robert.tangerman@deltares.nl>

Added mappings to read database object. WTI-1486

Options
    • -0
    • +23
    /Ringtoets/HydraRing/src/Ringtoets.HydraRing.IO/HydraulicLocationConfigurationDatabase/ReadHydraulicLocationConfigurationDatabase.cs
    • -0
    • +14
    /Ringtoets/HydraRing/test/Ringtoets.HydraRing.IO.Test/HydraulicLocationConfigurationDatabase/ReadHydraulicLocationConfigurationDatabaseTest.cs
10:47 am

Robert Tangerman <robert.tangerman@deltares.nl>

Added mapping object for location ids from hydraulic location configuration database. WTI-1486

Options
    • -0
    • +50
    /Ringtoets/HydraRing/src/Ringtoets.HydraRing.IO/HydraulicLocationConfigurationDatabase/ReadHydraulicLocationMapping.cs
    • -0
    • +1
    /Ringtoets/HydraRing/src/Ringtoets.HydraRing.IO/Ringtoets.HydraRing.IO.csproj
    • -0
    • +47
    /Ringtoets/HydraRing/test/Ringtoets.HydraRing.IO.Test/HydraulicLocationConfigurationDatabase/ReadHydraulicLocationMappingTest.cs
    • -0
    • +1
    /Ringtoets/HydraRing/test/Ringtoets.HydraRing.IO.Test/Ringtoets.HydraRing.IO.Test.csproj
10:08 am

Robert Tangerman <robert.tangerman@deltares.nl>

Cleanup. WTI-1486

Options
    • -11
    • +3
    /Ringtoets/Integration/src/Ringtoets.Integration.IO/Importers/HydraulicBoundaryDatabaseImporter.cs
10:07 am

Robert Tangerman <robert.tangerman@deltares.nl>

Added call DoPostUpdateActions of handler in DoPostImportUpdates. WTI-1486

Options
    • -1
    • +3
    /Ringtoets/Integration/src/Ringtoets.Integration.IO/Importers/HydraulicBoundaryDatabaseImporter.cs
    • -0
    • +1
    /Ringtoets/Integration/test/Ringtoets.Integration.IO.Test/Importers/HydraulicBoundaryDatabaseImporterTest.cs
10:01 am

Robert Tangerman <robert.tangerman@deltares.nl>

Only perform PostUpdateActions when locations are changed. WTI-1486

Options
    • -11
    • +16
    /Ringtoets/Integration/src/Ringtoets.Integration.Plugin/Handlers/HydraulicBoundaryDatabaseUpdateHandler.cs
    • -2
    • +77
    /Ringtoets/Integration/test/Ringtoets.Integration.Plugin.Test/Handlers/HydraulicBoundaryDatabaseUpdateHandlerTest.cs
9:36 am

Robert Tangerman <robert.tangerman@deltares.nl>

Removed viewCommands from constructor. WTI-1486

Options
    • -7
    • +1
    /Ringtoets/Integration/src/Ringtoets.Integration.Plugin/Handlers/HydraulicBoundaryDatabaseUpdateHandler.cs
    • -61
    • +19
    /Ringtoets/Integration/test/Ringtoets.Integration.Plugin.Test/Handlers/HydraulicBoundaryDatabaseUpdateHandlerTest.cs
9:34 am

Robert Tangerman <robert.tangerman@deltares.nl>

Implemented DoPostUpdateActions method. WTI-1486

Options
    • -1
    • +1
    /Ringtoets/Integration/src/Ringtoets.Integration.Plugin/Handlers/HydraulicBoundaryDatabaseUpdateHandler.cs
    • -0
    • +21
    /Ringtoets/Integration/test/Ringtoets.Integration.Plugin.Test/Handlers/HydraulicBoundaryDatabaseUpdateHandlerTest.cs
9:30 am

Robert Tangerman <robert.tangerman@deltares.nl>

Adapted tests to interface. WTI-1486

Options
    • -2
    • +2
    /Ringtoets/Integration/src/Ringtoets.Integration.Plugin/Handlers/HydraulicBoundaryDatabaseUpdateHandler.cs
    • -70
    • +22
    /Ringtoets/Integration/test/Ringtoets.Integration.Plugin.Test/Handlers/HydraulicBoundaryDatabaseUpdateHandlerTest.cs
9:01 am

Robert Tangerman <robert.tangerman@deltares.nl>

Added dune locations replace handler to hydraulic boundary database update handler constructor. WTI-1486

Options
    • -5
    • +11
    /Ringtoets/Integration/src/Ringtoets.Integration.Plugin/Handlers/HydraulicBoundaryDatabaseUpdateHandler.cs
    • -19
    • +61
    /Ringtoets/Integration/test/Ringtoets.Integration.Plugin.Test/Handlers/HydraulicBoundaryDatabaseUpdateHandlerTest.cs
    • -0
    • +4
    /Ringtoets/Integration/test/Ringtoets.Integration.Plugin.Test/Ringtoets.Integration.Plugin.Test.csproj
8:34 am

Robert Tangerman <robert.tangerman@deltares.nl>

Extracted interface of dune locations replacement handler. WTI-1486

Options
    • -1
    • +1
    /Ringtoets/DuneErosion/src/Ringtoets.DuneErosion.Plugin/Handlers/DuneLocationsReplacementHandler.cs
    • -0
    • +48
    /Ringtoets/DuneErosion/src/Ringtoets.DuneErosion.Plugin/Handlers/IDuneLocationsReplacementHandler.cs
    • -0
    • +1
    /Ringtoets/DuneErosion/src/Ringtoets.DuneErosion.Plugin/Ringtoets.DuneErosion.Plugin.csproj
    • -0
    • +16
    /Ringtoets/DuneErosion/test/Ringtoets.DuneErosion.Plugin.Test/Handlers/DuneLocationsReplacementHandlerTest.cs
Saturday 15 Dec 2018
7:53 pm

Robert Tangerman <robert.tangerman@deltares.nl>

Revert "Removed method from interface. WTI-1486"

This reverts commit 6ce2336528e99336ffb86e0a514e5ef1fd295d75.

Options
    • -0
    • +5
    /Ringtoets/Integration/src/Ringtoets.Integration.IO/Handlers/IHydraulicBoundaryDatabaseUpdateHandler.cs
    • -0
    • +5
    /Ringtoets/Integration/src/Ringtoets.Integration.Plugin/Handlers/HydraulicBoundaryDatabaseUpdateHandler.cs
7:47 pm

Robert Tangerman <robert.tangerman@deltares.nl>

Added dunes to changed objects. WTI-1486

Options
    • -1
    • +7
    /Ringtoets/Integration/src/Ringtoets.Integration.Plugin/Handlers/HydraulicBoundaryDatabaseUpdateHandler.cs
    • -1
    • +7
    /Ringtoets/Integration/test/Ringtoets.Integration.Plugin.Test/Handlers/HydraulicBoundaryDatabaseUpdateHandlerTest.cs
7:43 pm

Robert Tangerman <robert.tangerman@deltares.nl>

Implemented updating dune locations. WTI-1486

Options
    • -1
    • +1
    /Ringtoets/DuneErosion/src/Ringtoets.DuneErosion.Plugin/Handlers/DuneLocationsReplacementHandler.cs
    • -2
    • +2
    /Ringtoets/DuneErosion/src/Ringtoets.DuneErosion.Service/DuneErosionDataSynchronizationService.cs
    • -2
    • +5
    /Ringtoets/Integration/src/Ringtoets.Integration.Plugin/Handlers/HydraulicBoundaryDatabaseUpdateHandler.cs
    • -2
    • +68
    /Ringtoets/Integration/test/Ringtoets.Integration.Plugin.Test/Handlers/HydraulicBoundaryDatabaseUpdateHandlerTest.cs
7:39 pm

Robert Tangerman <robert.tangerman@deltares.nl>

Expanded test factory. WTI-1486

Options
    • -1
    • +17
    /Ringtoets/HydraRing/test/Ringtoets.HydraRing.IO.TestUtil.Test/ReadHydraulicBoundaryDatabaseTestFactoryTest.cs
    • -1
    • +13
    /Ringtoets/HydraRing/test/Ringtoets.HydraRing.IO.TestUtil/ReadHydraulicBoundaryDatabaseTestFactory.cs
Friday 14 Dec 2018
12:00 pm

Robert Tangerman <robert.tangerman@deltares.nl>

Improved test. WTI-1486

Options
    • -1
    • +13
    /Ringtoets/Integration/test/Ringtoets.Integration.Plugin.Test/Handlers/HydraulicBoundaryDatabaseUpdateHandlerTest.cs
11:47 am

Dennis Tang <dennis.tang@deltares.nl>

Cleanup Structures: WTI-1923

- Editorial changes

Options
    • -1
    • +0
    /Ringtoets/ClosingStructures/test/Ringtoets.ClosingStructures.Plugin.Test/TreeNodeInfos/ClosingStructuresCalculationContextTreeNodeInfoTest.cs
11:45 am

Robert Tangerman <robert.tangerman@deltares.nl>

Added viewCommands to handler. WTI-1486

Options
    • -1
    • +10
    /Ringtoets/Integration/src/Ringtoets.Integration.Plugin/Handlers/HydraulicBoundaryDatabaseUpdateHandler.cs
    • -20
    • +119
    /Ringtoets/Integration/test/Ringtoets.Integration.Plugin.Test/Handlers/HydraulicBoundaryDatabaseUpdateHandlerTest.cs
11:33 am

Robert Tangerman <robert.tangerman@deltares.nl>

Added clearing calculation output. WTI-1486

Options
    • -0
    • +2
    /Ringtoets/Integration/src/Ringtoets.Integration.Plugin/Handlers/HydraulicBoundaryDatabaseUpdateHandler.cs
    • -7
    • +30
    /Ringtoets/Integration/test/Ringtoets.Integration.Plugin.Test/Handlers/HydraulicBoundaryDatabaseUpdateHandlerTest.cs
11:26 am

Dennis Tang <dennis.tang@deltares.nl>

Cleanup GrassCoverErosionInwards: WTI-1823

- Removed obsolete calculator input check, this is already checked in other tests.

Options
    • -20
    • +7
    /Ringtoets/GrassCoverErosionInwards/test/Ringtoets.GrassCoverErosionInwards.Service.Test/GrassCoverErosionInwardsCalculationServiceTest.cs
10:38 am

Robert Tangerman <robert.tangerman@deltares.nl>

Added returning changed objects. WTI-1486

Options
    • -3
    • +25
    /Ringtoets/Integration/src/Ringtoets.Integration.Plugin/Handlers/HydraulicBoundaryDatabaseUpdateHandler.cs
    • -5
    • +45
    /Ringtoets/Integration/test/Ringtoets.Integration.Plugin.Test/Handlers/HydraulicBoundaryDatabaseUpdateHandlerTest.cs
10:24 am

Robert Tangerman <robert.tangerman@deltares.nl>

Implemented setting new locations. WTI-1486

Options
    • -0
    • +20
    /Ringtoets/Integration/src/Ringtoets.Integration.Plugin/Handlers/HydraulicBoundaryDatabaseUpdateHandler.cs
    • -8
    • +153
    /Ringtoets/Integration/test/Ringtoets.Integration.Plugin.Test/Handlers/HydraulicBoundaryDatabaseUpdateHandlerTest.cs
10:02 am

Dennis Tang <dennis.tang@deltares.nl>

Cleanup WaveConditions: WTI-1923

- Simplified mocks and tests

- Adjusted code layout

Options
    • -2
    • +1
    /Ringtoets/GrassCoverErosionOutwards/src/Ringtoets.GrassCoverErosionOutwards.Service/GrassCoverErosionOutwardsWaveConditionsCalculationActivity.cs
    • -7
    • +2
    /Ringtoets/GrassCoverErosionOutwards/test/Ringtoets.GrassCoverErosionOutwards.Integration.Test/GrassCoverErosionOutwardsWaveConditionsCalculationActivityIntegrationTest.cs
    • -8
    • +0
    /Ringtoets/GrassCoverErosionOutwards/test/Ringtoets.GrassCoverErosionOutwards.Plugin.Test/TreeNodeInfos/GrassCoverErosionOutwardsWaveConditionsCalculationGroupContextTreeNodeInfoTest.cs
    • -1
    • +1
    /Ringtoets/GrassCoverErosionOutwards/test/Ringtoets.GrassCoverErosionOutwards.Service.Test/GrassCoverErosionOutwardsWaveConditionsCalculationServiceTest.cs
    • -9
    • +3
    /Ringtoets/Revetment/test/Ringtoets.Revetment.Service.Test/WaveConditionsCalculationServiceBaseTest.cs
    • -2
    • +1
    /Ringtoets/StabilityStoneCover/src/Ringtoets.StabilityStoneCover.Service/StabilityStoneCoverWaveConditionsCalculationActivity.cs
    • -7
    • +2
    /Ringtoets/StabilityStoneCover/test/Ringtoets.StabilityStoneCover.Integration.Test/StabilityStoneCoverWaveConditionsCalculationActivityIntegrationTest.cs
    • -7
    • +2
    /Ringtoets/StabilityStoneCover/test/Ringtoets.StabilityStoneCover.Service.Test/StabilityStoneCoverWaveConditionsCalculationServiceTest.cs
    • -2
    • +1
    /Ringtoets/WaveImpactAsphaltCover/src/Ringtoets.WaveImpactAsphaltCover.Service/WaveImpactAsphaltCoverWaveConditionsCalculationActivity.cs
    • -7
    • +2
    /Ringtoets/WaveImpactAsphaltCover/test/Ringtoets.WaveImpactAsphaltCover.Service.Test/WaveImpactAsphaltCoverWaveConditionsCalculationServiceTest.cs
Thursday 13 Dec 2018
4:19 pm

Dennis Tang <dennis.tang@deltares.nl>

Cleanup HydraulicBoundary items: WTI-1923

- Updated XMLDoc

Options
    • -1
    • +2
    /Ringtoets/Common/src/Ringtoets.Common.Service/DesignWaterLevelCalculationService.cs
3:59 pm

Dennis Tang <dennis.tang@deltares.nl>

Cleanup Dunes: WTI-1923

- Simplified mock expectancies

- Corrected typos

Options
    • -1
    • +1
    /Ringtoets/DuneErosion/src/Ringtoets.DuneErosion.Service/DuneLocationCalculationActivity.cs
    • -7
    • +2
    /Ringtoets/DuneErosion/test/Ringtoets.DuneErosion.Forms.Test/Views/DuneLocationCalculationsViewTest.cs
    • -10
    • +4
    /Ringtoets/DuneErosion/test/Ringtoets.DuneErosion.Plugin.Test/TreeNodeInfos/DuneLocationCalculationsContextTreeNodeInfoTest.cs
    • -2
    • +2
    /Ringtoets/DuneErosion/test/Ringtoets.DuneErosion.Service.Test/DuneLocationCalculationActivityFactoryTest.cs
    • -1
    • +2
    /Ringtoets/DuneErosion/test/Ringtoets.DuneErosion.Service.Test/DuneLocationCalculationActivityTest.cs
3:36 pm

Dennis Tang <dennis.tang@deltares.nl>

Updated XMLDoc: WTI-1923

- hlcd --> HLCD

- Fixed typo

Options
    • -2
    • +2
    /Ringtoets/Common/src/Ringtoets.Common.Data/Hydraulics/HydraulicBoundaryCalculationSettings.cs
    • -1
    • +1
    /Ringtoets/Common/test/Ringtoets.Common.Service.TestUtil/HydraRingCalculationSettingsTestHelper.cs
    • -1
    • +1
    /Ringtoets/HydraRing/test/Ringtoets.HydraRing.Calculation.Test/Calculator/HydraRingCalculatorBaseTest.cs
3:30 pm

Dennis Tang <dennis.tang@deltares.nl>

Introduced constructor overload for the HydraulicBoundaryCalculationSettings: WTI-1923

- Introduced to prevent sending NULL arguments to certain settings when calling the factory method

Options
    • -5
    • +16
    /Ringtoets/Common/src/Ringtoets.Common.Data/Hydraulics/HydraulicBoundaryCalculationSettings.cs
    • -7
    • +8
    /Ringtoets/Common/src/Ringtoets.Common.Data/Hydraulics/HydraulicBoundaryCalculationSettingsFactory.cs
    • -2
    • +30
    /Ringtoets/Common/test/Ringtoets.Common.Data.Test/Hydraulics/HydraulicBoundaryCalculationSettingsTest.cs
    • -1
    • +1
    /Ringtoets/Common/test/Ringtoets.Common.Service.TestUtil/HydraRingCalculationSettingsTestHelper.cs
2:43 pm

Dennis Tang <dennis.tang@deltares.nl>

Cleanup: WTI-1923

- Removed test factory:

-- The test files usually already contain their local definitions of creating a valid HydraulicBoundaryCalculationSettings object, no need to redefine it again by means of an external factory.

Options
    • -21
    • +0
    /Ringtoets/Common/test/Ringtoets.Common.Data.TestUtil.Test/HydraulicBoundaryCalculationSettingsTestFactoryTest.cs
    • -1
    • +0
    /Ringtoets/Common/test/Ringtoets.Common.Data.TestUtil.Test/Ringtoets.Common.Data.TestUtil.Test.csproj
    • -24
    • +0
    /Ringtoets/Common/test/Ringtoets.Common.Data.TestUtil/HydraulicBoundaryCalculationSettingsTestFactory.cs
    • -1
    • +0
    /Ringtoets/Common/test/Ringtoets.Common.Data.TestUtil/Ringtoets.Common.Data.TestUtil.csproj
    • -1
    • +1
    /Ringtoets/Common/test/Ringtoets.Common.Service.Test/DesignWaterLevelCalculationActivityTest.cs
    • -2
    • +2
    /Ringtoets/Common/test/Ringtoets.Common.Service.Test/DesignWaterLevelCalculationServiceTest.cs
    • -2
    • +2
    /Ringtoets/Common/test/Ringtoets.Common.Service.Test/Structures/StructuresCalculationServiceBaseTest.cs
    • -1
    • +1
    /Ringtoets/Common/test/Ringtoets.Common.Service.Test/WaveHeightCalculationActivityTest.cs
    • -2
    • +2
    /Ringtoets/Common/test/Ringtoets.Common.Service.Test/WaveHeightCalculationServiceTest.cs
    • -1
    • +1
    /Ringtoets/DuneErosion/test/Ringtoets.DuneErosion.Service.Test/DuneLocationCalculationActivityTest.cs
    • -4
    • +4
    /Ringtoets/DuneErosion/test/Ringtoets.DuneErosion.Service.Test/DuneLocationCalculationServiceTest.cs