Riskeer

Clone Tools

Stats

Commits this week: 0
Total Committers: 28
Last Commit: 26 Nov
Commits this week: 0

Lines of code count not available

Commit Activity

Commits By Day In Week
52 week commits volume
Commits By Day In Week
Commits by day
Commits By Day In Week
Commits by hour
Commits By Hour In Day
Commit calendar
 

Most active committers (90 days)

loading
loading
  • last updated a few seconds ago
All Commits Reviews
Constraints
Constraints: committers
 
Constraints: files
Constraints: dates
Friday 16 Feb 2018
4:12 pm

Carlos Lubbers

Implement detailed assessment factory methods for closing structures WTI-1616

Options
    • -74
    • +0
    /Ringtoets/ClosingStructures/src/Ringtoets.ClosingStructures.Data/ClosingStructuresFailureMechanismSection2aAssessmentResultExtensions.cs
    • -0
    • +73
    /Ringtoets/ClosingStructures/src/Ringtoets.ClosingStructures.Data/ClosingStructuresFailureMechanismSectionDetailedAssessmentResultExtensions.cs
    • -0
    • +54
    /Ringtoets/ClosingStructures/src/Ringtoets.ClosingStructures.Data/ClosingStructuresFailureMechanismSectionResultAssemblyFactory.cs
    • -1
    • +1
    /Ringtoets/ClosingStructures/src/Ringtoets.ClosingStructures.Data/Ringtoets.ClosingStructures.Data.csproj
    • -6
    • +6
    /Ringtoets/ClosingStructures/src/Ringtoets.ClosingStructures.Forms/Views/ClosingStructuresFailureMechanismResultView.cs
    • -4
    • +4
    /Ringtoets/ClosingStructures/src/Ringtoets.ClosingStructures.Forms/Views/ClosingStructuresFailureMechanismSectionResultRow.cs
    • -161
    • +0
    /Ringtoets/ClosingStructures/test/Ringtoets.ClosingStructures.Data.Test/ClosingStructuresFailureMechanismSection2aAssessmentResultExtensionsTest.cs
    • -0
    • +161
    /Ringtoets/ClosingStructures/test/Ringtoets.ClosingStructures.Data.Test/ClosingStructuresFailureMechanismSectionDetailedAssessmentResultExtensionsTest.cs
    • -0
    • +181
    /Ringtoets/ClosingStructures/test/Ringtoets.ClosingStructures.Data.Test/ClosingStructuresFailureMechanismSectionResultAssemblyFactoryTest.cs
    • -1
    • +1
    /Ringtoets/ClosingStructures/test/Ringtoets.ClosingStructures.Data.Test/Ringtoets.ClosingStructures.Data.Test.csproj
    • -28
    • +28
    /Ringtoets/ClosingStructures/test/Ringtoets.ClosingStructures.Forms.Test/Views/ClosingStructuresFailureMechanismResultViewTest.cs
    • -11
    • +11
    /Ringtoets/ClosingStructures/test/Ringtoets.ClosingStructures.Forms.Test/Views/ClosingStructuresFailureMechanismSectionResultRowTest.cs
3:48 pm

Carlos Lubbers

Add tests for grass cover erosion inwards assembly factory WTI-1616

Options
    • -2
    • +2
    /Ringtoets/GrassCoverErosionInwards/src/Ringtoets.GrassCoverErosionInwards.Data/GrassCoverErosionInwardsFailureMechanismSectionResultAssemblyFactory.cs
    • -1
    • +182
    /Ringtoets/GrassCoverErosionInwards/test/Ringtoets.GrassCoverErosionInwards.Data.Test/GrassCoverErosionInwardsFailureMechanismSectionResultAssemblyFactoryTest.cs
    • -2
    • +2
    /Ringtoets/MacroStabilityInwards/src/Ringtoets.MacroStabilityInwards.Data/MacroStabilityInwardsFailureMechanismSectionResultAssemblyFactory.cs
    • -2
    • +2
    /Ringtoets/Piping/src/Ringtoets.Piping.Data/PipingFailureMechanismSectionResultAssemblyFactory.cs
3:33 pm

Carlos Lubbers

Rename AssessmentLayerTwoA -> DetailedAssessmentProbability WTI-1616

Options
    • -1
    • +1
    /Ringtoets/ClosingStructures/src/Ringtoets.ClosingStructures.Forms/Views/ClosingStructuresFailureMechanismResultView.cs
    • -17
    • +17
    /Ringtoets/Common/src/Ringtoets.Common.Forms/Helpers/FailureMechanismSectionResultRowHelper.cs
    • -7
    • +7
    /Ringtoets/Common/test/Ringtoets.Common.Forms.Test/Helpers/FailureMechanismSectionResultRowHelperTest.cs
    • -73
    • +0
    /Ringtoets/GrassCoverErosionInwards/src/Ringtoets.GrassCoverErosionInwards.Data/GrassCoverErosionInwardsFailureMechanismSection2aAssessmentResultExtensions.cs
    • -0
    • +73
    /Ringtoets/GrassCoverErosionInwards/src/Ringtoets.GrassCoverErosionInwards.Data/GrassCoverErosionInwardsFailureMechanismSectionDetailedAssessmentProbabilityResultExtensions.cs
    • -0
    • +54
    /Ringtoets/GrassCoverErosionInwards/src/Ringtoets.GrassCoverErosionInwards.Data/GrassCoverErosionInwardsFailureMechanismSectionResultAssemblyFactory.cs
    • -1
    • +1
    /Ringtoets/GrassCoverErosionInwards/src/Ringtoets.GrassCoverErosionInwards.Data/Ringtoets.GrassCoverErosionInwards.Data.csproj
    • -7
    • +7
    /Ringtoets/GrassCoverErosionInwards/src/Ringtoets.GrassCoverErosionInwards.Forms/Views/GrassCoverErosionInwardsFailureMechanismResultView.cs
    • -3
    • +3
    /Ringtoets/GrassCoverErosionInwards/src/Ringtoets.GrassCoverErosionInwards.Forms/Views/GrassCoverErosionInwardsFailureMechanismSectionResultRow.cs
    • -157
    • +0
    /Ringtoets/GrassCoverErosionInwards/test/Ringtoets.GrassCoverErosionInwards.Data.Test/GrassCoverErosionInwardsFailureMechanismSection2aAssessmentResultExtensionsTest.cs
    • -0
    • +157
    /Ringtoets/GrassCoverErosionInwards/test/Ringtoets.GrassCoverErosionInwards.Data.Test/GrassCoverErosionInwardsFailureMechanismSectionDetailedAssessmentProbabilityResultExtensionsTest.cs
    • -1
    • +1
    /Ringtoets/GrassCoverErosionInwards/test/Ringtoets.GrassCoverErosionInwards.Data.Test/Ringtoets.GrassCoverErosionInwards.Data.Test.csproj
    • -22
    • +22
    /Ringtoets/GrassCoverErosionInwards/test/Ringtoets.GrassCoverErosionInwards.Forms.Test/Views/GrassCoverErosionInwardsFailureMechanismResultViewTest.cs
    • -11
    • +11
    /Ringtoets/GrassCoverErosionInwards/test/Ringtoets.GrassCoverErosionInwards.Forms.Test/Views/GrassCoverErosionInwardsFailureMechanismSectionResultRowTest.cs
    • -4
    • +4
    /Ringtoets/HeightStructures/src/Ringtoets.HeightStructures.Forms/Views/HeightStructuresFailureMechanismResultView.cs
  16. … 3 more files in changeset.
2:57 pm

Dennis Tang <dennis.tang@deltares.nl>

Rewired SectionResult to the mirror property SectionResult2 for StabilityPointStructures in Forms: - Adjusted ScenarioRow and the view

WTI-1621

Options
    • -3
    • +3
    /Ringtoets/StabilityPointStructures/src/Ringtoets.StabilityPointStructures.Forms/Views/StabilityPointStructuresScenarioRow.cs
    • -1
    • +1
    /Ringtoets/StabilityPointStructures/src/Ringtoets.StabilityPointStructures.Forms/Views/StabilityPointStructuresScenariosView.cs
    • -3
    • +3
    /Ringtoets/StabilityPointStructures/test/Ringtoets.StabilityPointStructures.Forms.Test/Views/StabilityPointStructuresScenarioRowTest.cs
2:48 pm

Dennis Tang <dennis.tang@deltares.nl>

Rewired SectionResult to the mirror property SectionResult2 for StabilityPointStructures in Data: - Adjusted the 2aAssessementResultExtensions - Adjusted Forms classes that depend on the extension method: -- Fixed compilation errors and tests for the failure mechanism result view

WTI-1621

Options
    • -2
    • +1
    /Ringtoets/StabilityPointStructures/src/Ringtoets.StabilityPointStructures.Data/StabilityPointStructuresFailureMechanismSection2aAssessmentResultExtensions.cs
    • -4
    • +4
    /Ringtoets/StabilityPointStructures/src/Ringtoets.StabilityPointStructures.Forms/Views/StabilityPointStructuresFailureMechanismResultView.cs
    • -4
    • +4
    /Ringtoets/StabilityPointStructures/src/Ringtoets.StabilityPointStructures.Forms/Views/StabilityPointStructuresFailureMechanismSectionResultRow.cs
    • -2
    • +2
    /Ringtoets/StabilityPointStructures/src/Ringtoets.StabilityPointStructures.Plugin/StabilityPointStructuresPlugin.cs
    • -6
    • +5
    /Ringtoets/StabilityPointStructures/test/Ringtoets.StabilityPointStructures.Data.Test/StabilityPointStructuresFailureMechanismSection2aAssessmentResultExtensionsTest.cs
    • -29
    • +29
    /Ringtoets/StabilityPointStructures/test/Ringtoets.StabilityPointStructures.Forms.Test/Views/StabilityPointStructuresFailureMechanismResultViewTest.cs
    • -11
    • +11
    /Ringtoets/StabilityPointStructures/test/Ringtoets.StabilityPointStructures.Forms.Test/Views/StabilityPointStructuresFailureMechanismSectionResultRowTest.cs
    • -2
    • +2
    /Ringtoets/StabilityPointStructures/test/Ringtoets.StabilityPointStructures.Plugin.Test/StabilityPointStructuresPluginTest.cs
    • -17
    • +16
    /Ringtoets/StabilityPointStructures/test/Ringtoets.StabilityPointStructures.Plugin.Test/ViewInfos/StabilityPointStructuresResultViewInfoTest.cs
2:16 pm

Carlos Lubbers

Add detailed assessment assembly factory method to macro stability inwards WTI-1616

Options
    • -0
    • +131
    /Ringtoets/MacroStabilityInwards/src/Ringtoets.MacroStabilityInwards.Data/MacroStabilityInwardsFailureMechanismSectionResultAssemblyFactory.cs
    • -68
    • +0
    /Ringtoets/MacroStabilityInwards/src/Ringtoets.MacroStabilityInwards.Data/MacroStabilityInwardsFailureMechanismSectionResultsAssemblyFactory.cs
    • -1
    • +1
    /Ringtoets/MacroStabilityInwards/src/Ringtoets.MacroStabilityInwards.Data/Ringtoets.MacroStabilityInwards.Data.csproj
    • -2
    • +0
    /Ringtoets/MacroStabilityInwards/src/Ringtoets.MacroStabilityInwards.Forms/Views/MacroStabilityInwardsFailureMechanismSectionResultRow.cs
    • -15
    • +45
    /Ringtoets/MacroStabilityInwards/test/Ringtoets.MacroStabilityInwards.Data.Test/MacroStabilityInwardsFailureMechanismSectionDetailedAssessmentResultExtensionsTest.cs
    • -4
    • +230
    /Ringtoets/MacroStabilityInwards/test/Ringtoets.MacroStabilityInwards.Data.Test/MacroStabilityInwardsFailureMechanismSectionResultAssemblyFactoryTest.cs
    • -0
    • +1
    /Ringtoets/MacroStabilityInwards/test/Ringtoets.MacroStabilityInwards.Data.TestUtil.Test/MacroStabilityInwardsCalculationScenarioTestFactoryTest.cs
    • -0
    • +1
    /Ringtoets/MacroStabilityInwards/test/Ringtoets.MacroStabilityInwards.Data.TestUtil/MacroStabilityInwardsCalculationScenarioTestFactory.cs
    • -1
    • +1
    /Ringtoets/MacroStabilityInwards/test/Ringtoets.MacroStabilityInwards.Forms.Test/Views/MacroStabilityInwardsFailureMechanismSectionResultRowTest.cs
    • -2
    • +6
    /Ringtoets/Piping/test/Ringtoets.Piping.Data.Test/PipingFailureMechanismSectionResultAssemblyFactoryTest.cs
2:15 pm

Dennis Tang <dennis.tang@deltares.nl>

Rewired SectionResult to the mirror property SectionResult2 for StabilityPointStructures in storage: - Adjusted Create and ReadExtensions - Adjusted Integration test (helpers)

WTI-1621

Options
    • -4
    • +3
    /Application/Ringtoets/src/Application.Ringtoets.Storage/Create/StabilityPointStructures/StabilityPointStructuresFailureMechanismCreateExtensions.cs
    • -4
    • +3
    /Application/Ringtoets/src/Application.Ringtoets.Storage/Create/StabilityPointStructures/StabilityPointStructuresFailureMechanismSectionResultCreateExtensions.cs
    • -2
    • +2
    /Application/Ringtoets/src/Application.Ringtoets.Storage/Read/FailureMechanismEntityReadExtensions.cs
    • -6
    • +6
    /Application/Ringtoets/src/Application.Ringtoets.Storage/Read/StabilityPointStructures/StabilityPointStructuresSectionResultEntityReadExtensions.cs
    • -4
    • +4
    /Application/Ringtoets/test/Application.Ringtoets.Storage.Test/Create/StabilityPointStructures/StabilityPointStructuresFailureMechanismSectionResultCreateExtensionsTest.cs
    • -4
    • +4
    /Application/Ringtoets/test/Application.Ringtoets.Storage.Test/IntegrationTests/StorageSqLiteIntegrationTest.cs
    • -4
    • +4
    /Application/Ringtoets/test/Application.Ringtoets.Storage.Test/Read/StabilityPointStructures/StabilityPointStructuresSectionResultEntityReadExtensionsTest.cs
    • -1
    • +1
    /Application/Ringtoets/test/Application.Ringtoets.Storage.TestUtil.Test/RingtoetsProjectTestHelperTest.cs
    • -3
    • +3
    /Application/Ringtoets/test/Application.Ringtoets.Storage.TestUtil/RingtoetsProjectTestHelper.cs
1:57 pm

Dennis Tang <dennis.tang@deltares.nl>

Introduced mirror property for StabilityPointStructures failure mechanism: - Used to remove the generic failure mechanism section result step by step

WTI-1621

Options
    • -0
    • +12
    /Ringtoets/StabilityPointStructures/src/Ringtoets.StabilityPointStructures.Data/StabilityPointStructuresFailureMechanism.cs
    • -6
    • +11
    /Ringtoets/StabilityPointStructures/test/Ringtoets.StabilityPointStructures.Data.Test/StabilityPointStructuresFailureMechanismTest.cs
1:52 pm

Carlos Lubbers

Rename data model properties for macrostability inwards WTI-1616

Options
    • -174
    • +0
    /Ringtoets/MacroStabilityInwards/src/Ringtoets.MacroStabilityInwards.Data/MacroStabilityInwardsFailureMechanismSection2aAssessmentResultExtensions.cs
    • -0
    • +179
    /Ringtoets/MacroStabilityInwards/src/Ringtoets.MacroStabilityInwards.Data/MacroStabilityInwardsFailureMechanismSectionDetailedAssessmentResultExtensions.cs
    • -1
    • +1
    /Ringtoets/MacroStabilityInwards/src/Ringtoets.MacroStabilityInwards.Data/Ringtoets.MacroStabilityInwards.Data.csproj
    • -7
    • +7
    /Ringtoets/MacroStabilityInwards/src/Ringtoets.MacroStabilityInwards.Forms/Views/MacroStabilityInwardsFailureMechanismResultView.cs
    • -16
    • +3
    /Ringtoets/MacroStabilityInwards/src/Ringtoets.MacroStabilityInwards.Forms/Views/MacroStabilityInwardsFailureMechanismSectionResultRow.cs
    • -408
    • +0
    /Ringtoets/MacroStabilityInwards/test/Ringtoets.MacroStabilityInwards.Data.Test/MacroStabilityInwardsFailureMechanismSection2aAssessmentResultExtensionsTest.cs
    • -0
    • +408
    /Ringtoets/MacroStabilityInwards/test/Ringtoets.MacroStabilityInwards.Data.Test/MacroStabilityInwardsFailureMechanismSectionDetailedAssessmentResultExtensionsTest.cs
    • -1
    • +1
    /Ringtoets/MacroStabilityInwards/test/Ringtoets.MacroStabilityInwards.Data.Test/Ringtoets.MacroStabilityInwards.Data.Test.csproj
    • -21
    • +21
    /Ringtoets/MacroStabilityInwards/test/Ringtoets.MacroStabilityInwards.Forms.Test/Views/MacroStabilityInwardsFailureMechanismResultViewTest.cs
    • -18
    • +18
    /Ringtoets/MacroStabilityInwards/test/Ringtoets.MacroStabilityInwards.Forms.Test/Views/MacroStabilityInwardsFailureMechanismSectionResultRowTest.cs
    • -27
    • +27
    /Ringtoets/MacroStabilityInwards/test/Ringtoets.MacroStabilityInwards.Integration.Test/MacroStabilityInwardsFailureMechanismResultViewIntegrationTest.cs
    • -3
    • +3
    /Ringtoets/Piping/src/Ringtoets.Piping.Data/PipingFailureMechanismSectionDetailedAssessmentResultExtensions.cs
1:50 pm

Dennis Tang <dennis.tang@deltares.nl>

- Cleaned up tests that only depend on the coordinates --> use the testfactory to create FailureMechanismSections: -- Performed for HeightStructures.Data

WTI-1621

Options
    • -6
    • +4
    /Ringtoets/HeightStructures/test/Ringtoets.HeightStructures.Data.Test/HeightStructuresFailureMechanismTest.cs
1:46 pm

Dennis Tang <dennis.tang@deltares.nl>

Removed mirror property SectionResults2 for HeightStructures: - Replaced the old generic SectionResults property with the mirror property - Cleaned up test

WTI-1621

Options
    • -1
    • +1
    /Application/Ringtoets/src/Application.Ringtoets.Storage/Create/HeightStructures/HeightStructuresFailureMechanismCreateExtensions.cs
    • -1
    • +1
    /Application/Ringtoets/src/Application.Ringtoets.Storage/Read/FailureMechanismEntityReadExtensions.cs
    • -2
    • +2
    /Application/Ringtoets/test/Application.Ringtoets.Storage.Test/IntegrationTests/StorageSqLiteIntegrationTest.cs
    • -1
    • +1
    /Application/Ringtoets/test/Application.Ringtoets.Storage.TestUtil.Test/RingtoetsProjectTestHelperTest.cs
    • -1
    • +1
    /Application/Ringtoets/test/Application.Ringtoets.Storage.TestUtil/RingtoetsProjectTestHelper.cs
    • -21
    • +9
    /Ringtoets/HeightStructures/src/Ringtoets.HeightStructures.Data/HeightStructuresFailureMechanism.cs
    • -1
    • +1
    /Ringtoets/HeightStructures/src/Ringtoets.HeightStructures.Forms/Views/HeightStructuresScenariosView.cs
    • -1
    • +1
    /Ringtoets/HeightStructures/src/Ringtoets.HeightStructures.Plugin/HeightStructuresPlugin.cs
    • -5
    • +5
    /Ringtoets/HeightStructures/src/Ringtoets.HeightStructures.Util/HeightStructuresHelper.cs
    • -8
    • +2
    /Ringtoets/HeightStructures/test/Ringtoets.HeightStructures.Data.Test/HeightStructuresFailureMechanismTest.cs
    • -1
    • +1
    /Ringtoets/HeightStructures/test/Ringtoets.HeightStructures.Forms.Test/PropertyClasses/HeightStructuresInputContextPropertiesTest.cs
    • -4
    • +4
    /Ringtoets/HeightStructures/test/Ringtoets.HeightStructures.Forms.Test/Views/HeightStructuresFailureMechanismResultViewTest.cs
    • -3
    • +3
    /Ringtoets/HeightStructures/test/Ringtoets.HeightStructures.IO.Test/Configurations/HeightStructuresCalculationConfigurationImporterTest.cs
    • -1
    • +1
    /Ringtoets/HeightStructures/test/Ringtoets.HeightStructures.Plugin.Test/FileImporters/HeightStructureReplaceDataStrategyTest.cs
    • -4
    • +4
    /Ringtoets/HeightStructures/test/Ringtoets.HeightStructures.Plugin.Test/FileImporters/HeightStructureUpdateDataStrategyTest.cs
  16. … 6 more files in changeset.
1:33 pm

Carlos Lubbers

Add detailed assessment method to the piping assembly factory WTI-1616

Options
    • -13
    • +12
    /Ringtoets/AssemblyTool/test/Ringtoets.AssemblyTool.KernelWrapper.TestUtil.Test/Calculators/Assembly/FailureMechanismSectionAssemblyCalculatorStubTest.cs
    • -13
    • +14
    /Ringtoets/AssemblyTool/test/Ringtoets.AssemblyTool.KernelWrapper.TestUtil/Calculators/Assembly/FailureMechanismSectionAssemblyCalculatorStub.cs
    • -4
    • +0
    /Ringtoets/AssemblyTool/test/Ringtoets.AssemblyTool.KernelWrapper.TestUtil/Ringtoets.AssemblyTool.KernelWrapper.TestUtil.csproj
    • -14
    • +5
    /Ringtoets/Piping/src/Ringtoets.Piping.Data/PipingFailureMechanismSectionDetailedAssessmentResultExtensions.cs
    • -0
    • +63
    /Ringtoets/Piping/src/Ringtoets.Piping.Data/PipingFailureMechanismSectionResultAssemblyFactory.cs
    • -0
    • +222
    /Ringtoets/Piping/test/Ringtoets.Piping.Data.Test/PipingFailureMechanismSectionResultAssemblyFactoryTest.cs
    • -1
    • +2
    /Ringtoets/Piping/test/Ringtoets.Piping.Data.TestUtil/PipingCalculationScenarioTestFactory.cs
1:15 pm

Dennis Tang <dennis.tang@deltares.nl>

- Cleaned up tests that only depend on the coordinates --> use the testfactory to create FailureMechanismSections: -- Performed for ClosingStructures.Data - Replaced StructuresFailureMechanismSectionResult<ClosingStructuresInput> from the Integration.Plugin with the specific implementation.

WTI-1621

Options
    • -6
    • +4
    /Ringtoets/ClosingStructures/test/Ringtoets.ClosingStructures.Data.Test/ClosingStructuresFailureMechanismTest.cs
    • -2
    • +2
    /Ringtoets/Integration/src/Ringtoets.Integration.Plugin/RingtoetsPlugin.cs
1:11 pm

Dennis Tang <dennis.tang@deltares.nl>

Replaced StructuresFailureMechanismSectionResult<HeightStructuresInput> from the .Plugin with the specific implementation.

WTI-1621

Options
    • -3
    • +3
    /Ringtoets/HeightStructures/src/Ringtoets.HeightStructures.Plugin/HeightStructuresPlugin.cs
    • -2
    • +1
    /Ringtoets/HeightStructures/test/Ringtoets.HeightStructures.Plugin.Test/HeightStructuresPluginTest.cs
    • -2
    • +2
    /Ringtoets/HeightStructures/test/Ringtoets.HeightStructures.Plugin.Test/TreeNodeInfos/HeightStructuresFailureMechanismContextTreeNodeInfoTest.cs
    • -4
    • +3
    /Ringtoets/HeightStructures/test/Ringtoets.HeightStructures.Plugin.Test/TreeNodeInfos/HeightStructuresProbabilityFailureMechanismResultContextTreeNodeInfoTest.cs
    • -4
    • +4
    /Ringtoets/HeightStructures/test/Ringtoets.HeightStructures.Service.Test/HeightStructuresDataSynchronizationServiceTest.cs
12:48 pm

Dennis Tang <dennis.tang@deltares.nl>

Cleaned up tests that only depend on the coordinates --> use the testfactory to create FailureMechanismSections: - Performed for ClosingStructures.Plugin.Test

WTI-1621

Options
    • -1
    • +1
    /Ringtoets/ClosingStructures/test/Ringtoets.ClosingStructures.Plugin.Test/FileImporters/ClosingStructureReplaceDataStrategyTest.cs
    • -1
    • +1
    /Ringtoets/ClosingStructures/test/Ringtoets.ClosingStructures.Plugin.Test/FileImporters/ClosingStructureUpdateDataStrategyTest.cs
12:48 pm

Dennis Tang <dennis.tang@deltares.nl>

Separated the generic RingtoetsCommonDataSynchronization service implementation into specific (HeightStructure) implementation: - Corrected calls in the corresponding Replace- and UpdateDataStrategies - Adjusted tests

WTI-1621

Options
    • -7
    • +2
    /Ringtoets/HeightStructures/src/Ringtoets.HeightStructures.Plugin/FileImporters/HeightStructureReplaceDataStrategy.cs
    • -10
    • +4
    /Ringtoets/HeightStructures/src/Ringtoets.HeightStructures.Plugin/FileImporters/HeightStructureUpdateDataStrategy.cs
    • -3
    • +2
    /Ringtoets/HeightStructures/test/Ringtoets.HeightStructures.Plugin.Test/FileImporters/HeightStructureReplaceDataStrategyTest.cs
    • -13
    • +8
    /Ringtoets/HeightStructures/test/Ringtoets.HeightStructures.Plugin.Test/FileImporters/HeightStructureUpdateDataStrategyTest.cs
    • -0
    • +4
    /Ringtoets/HeightStructures/test/Ringtoets.HeightStructures.Plugin.Test/Ringtoets.HeightStructures.Plugin.Test.csproj
11:40 am

Dennis Tang <dennis.tang@deltares.nl>

Separated the generic RingtoetsCommonDataSynchronization service implementation into specific (HeightStructure) implementation: - Performed for the RemoveStructure - Performed for the RemoveAllStructures

WTI-1621

Options
    • -0
    • +91
    /Ringtoets/HeightStructures/src/Ringtoets.HeightStructures.Service/HeightStructuresDataSynchronizationService.cs
    • -0
    • +5
    /Ringtoets/HeightStructures/src/Ringtoets.HeightStructures.Service/Ringtoets.HeightStructures.Service.csproj
    • -0
    • +233
    /Ringtoets/HeightStructures/test/Ringtoets.HeightStructures.Service.Test/HeightStructuresDataSynchronizationServiceTest.cs
11:26 am

Dennis Tang <dennis.tang@deltares.nl>

Cleaned up tests that only depend on the coordinates --> use the testfactory to create FailureMechanismSections: - Performed for ClosingStructures

WTI-1621

Options
    • -6
    • +6
    /Ringtoets/ClosingStructures/test/Ringtoets.ClosingStructures.IO.Test/Configurations/ClosingStructuresCalculationConfigurationImporterTest.cs
    • -7
    • +2
    /Ringtoets/ClosingStructures/test/Ringtoets.ClosingStructures.Plugin.Test/TreeNodeInfos/ClosingStructuresCalculationContextTreeNodeInfoTest.cs
    • -6
    • +1
    /Ringtoets/ClosingStructures/test/Ringtoets.ClosingStructures.Plugin.Test/TreeNodeInfos/ClosingStructuresCalculationGroupContextTreeNodeInfoTest.cs
    • -12
    • +10
    /Ringtoets/ClosingStructures/test/Ringtoets.ClosingStructures.Service.Test/ClosingStructureDataSynchronizationServiceTest.cs
11:20 am

Dennis Tang <dennis.tang@deltares.nl>

Separated the generic StructuresHelper implementation into specific (HeighStructure) implementation: - Replaced StructuresHelperCall with the specific HeightStructure helper implementation -- Except for the UpdateDataStrategy -- Cleaned up tests that only depend on the coordinates --> use the testfactory

WTI-1621

Options
    • -5
    • +2
    /Ringtoets/HeightStructures/src/Ringtoets.HeightStructures.Forms/PropertyClasses/HeightStructuresInputContextProperties.cs
    • -0
    • +5
    /Ringtoets/HeightStructures/src/Ringtoets.HeightStructures.Forms/Ringtoets.HeightStructures.Forms.csproj
    • -5
    • +7
    /Ringtoets/HeightStructures/src/Ringtoets.HeightStructures.IO/Configurations/HeightStructuresCalculationConfigurationImporter.cs
    • -0
    • +5
    /Ringtoets/HeightStructures/src/Ringtoets.HeightStructures.IO/Ringtoets.HeightStructures.IO.csproj
    • -10
    • +4
    /Ringtoets/HeightStructures/src/Ringtoets.HeightStructures.Plugin/HeightStructuresPlugin.cs
    • -0
    • +5
    /Ringtoets/HeightStructures/src/Ringtoets.HeightStructures.Plugin/Ringtoets.HeightStructures.Plugin.csproj
    • -0
    • +87
    /Ringtoets/HeightStructures/src/Ringtoets.HeightStructures.Util/HeightStructuresHelper.cs
    • -0
    • +23
    /Ringtoets/HeightStructures/src/Ringtoets.HeightStructures.Util/Ringtoets.HeightStructures.Util.csproj
    • -6
    • +9
    /Ringtoets/HeightStructures/test/Ringtoets.HeightStructures.Forms.Test/PropertyClasses/HeightStructuresInputContextPropertiesTest.cs
    • -8
    • +10
    /Ringtoets/HeightStructures/test/Ringtoets.HeightStructures.IO.Test/Configurations/HeightStructuresCalculationConfigurationImporterTest.cs
    • -23
    • +18
    /Ringtoets/HeightStructures/test/Ringtoets.HeightStructures.Plugin.Test/TreeNodeInfos/HeightStructuresCalculationContextTreeNodeInfoTest.cs
    • -27
    • +24
    /Ringtoets/HeightStructures/test/Ringtoets.HeightStructures.Plugin.Test/TreeNodeInfos/HeightStructuresCalculationGroupContextTreeNodeInfoTest.cs
    • -0
    • +114
    /Ringtoets/HeightStructures/test/Ringtoets.HeightStructures.Util.Test/HeightStructuresHelperTest.cs
    • -0
    • +31
    /Ringtoets/HeightStructures/test/Ringtoets.HeightStructures.Util.Test/Ringtoets.HeightStructures.Util.Test.csproj
    • -0
    • +26
    /Ringtoets/HeightStructures/test/Ringtoets.HeightStructures.Util.Test/packages.config
11:13 am

Carlos Lubbers

DetailedAssessment -> DetailedAssessmentProbability WTI-1616

Options
    • -2
    • +2
    /Ringtoets/Piping/src/Ringtoets.Piping.Forms/Views/PipingFailureMechanismResultView.cs
    • -1
    • +1
    /Ringtoets/Piping/src/Ringtoets.Piping.Forms/Views/PipingFailureMechanismSectionResultRow.cs
    • -16
    • +16
    /Ringtoets/Piping/test/Ringtoets.Piping.Data.Test/PipingFailureMechanismSectionDetailedAssessmentResultExtensionsTest.cs
    • -5
    • +5
    /Ringtoets/Piping/test/Ringtoets.Piping.Forms.Test/Views/PipingFailureMechanismSectionResultRowTest.cs
11:10 am

Carlos Lubbers

Move logic from the failure mechanism result row into the extension method WTI-1616

Options
    • -7
    • +20
    /Ringtoets/Piping/src/Ringtoets.Piping.Data/PipingFailureMechanismSectionDetailedAssessmentResultExtensions.cs
    • -16
    • +1
    /Ringtoets/Piping/src/Ringtoets.Piping.Forms/Views/PipingFailureMechanismSectionResultRow.cs
    • -15
    • +42
    /Ringtoets/Piping/test/Ringtoets.Piping.Data.Test/PipingFailureMechanismSectionDetailedAssessmentResultExtensionsTest.cs
    • -87
    • +0
    /Ringtoets/Piping/test/Ringtoets.Piping.Forms.Test/Views/PipingFailureMechanismSectionResultRowTest.cs
10:48 am

Dennis Tang <dennis.tang@deltares.nl>

Expanded FailureMechanismSectionTestFactory with factory method that constructs a section based on the coordinates alone: - Certain tests are location dependent - Cleaned up the ClosingStructuresHelperTest

WTI-1621

Options
    • -27
    • +24
    /Ringtoets/ClosingStructures/test/Ringtoets.ClosingStructures.Util.Test/ClosingStructuresHelperTest.cs
    • -0
    • +4
    /Ringtoets/ClosingStructures/test/Ringtoets.ClosingStructures.Util.Test/Ringtoets.ClosingStructures.Util.Test.csproj
    • -1
    • +34
    /Ringtoets/Common/test/Ringtoets.Common.Data.TestUtil.Test/FailureMechanismSectionTestFactoryTest.cs
    • -1
    • +25
    /Ringtoets/Common/test/Ringtoets.Common.Data.TestUtil/FailureMechanismSectionTestFactory.cs
10:31 am

Carlos Lubbers

Rename AssessmentLayerTwoA -> DetailedAssessment for piping WTI-1616

Options
    • -171
    • +0
    /Ringtoets/Piping/src/Ringtoets.Piping.Data/PipingFailureMechanismSection2aAssessmentResultExtensions.cs
    • -0
    • +171
    /Ringtoets/Piping/src/Ringtoets.Piping.Data/PipingFailureMechanismSectionDetailedAssessmentResultExtensions.cs
    • -1
    • +1
    /Ringtoets/Piping/src/Ringtoets.Piping.Data/Ringtoets.Piping.Data.csproj
    • -7
    • +7
    /Ringtoets/Piping/src/Ringtoets.Piping.Forms/Views/PipingFailureMechanismResultView.cs
    • -3
    • +3
    /Ringtoets/Piping/src/Ringtoets.Piping.Forms/Views/PipingFailureMechanismSectionResultRow.cs
    • -381
    • +0
    /Ringtoets/Piping/test/Ringtoets.Piping.Data.Test/PipingFailureMechanismSection2aAssessmentResultExtensionsTest.cs
    • -0
    • +386
    /Ringtoets/Piping/test/Ringtoets.Piping.Data.Test/PipingFailureMechanismSectionDetailedAssessmentResultExtensionsTest.cs
    • -1
    • +1
    /Ringtoets/Piping/test/Ringtoets.Piping.Data.Test/Ringtoets.Piping.Data.Test.csproj
    • -21
    • +21
    /Ringtoets/Piping/test/Ringtoets.Piping.Forms.Test/Views/PipingFailureMechanismResultViewTest.cs
    • -16
    • +16
    /Ringtoets/Piping/test/Ringtoets.Piping.Forms.Test/Views/PipingFailureMechanismSectionResultRowTest.cs
    • -27
    • +27
    /Ringtoets/Piping/test/Ringtoets.Piping.Integration.Test/PipingFailureMechanismResultViewIntegrationTest.cs
10:27 am

Dennis Tang <dennis.tang@deltares.nl>

Introduced Util projects for Height- and StabilityPoint-structures: - Required to separate the generic StructuresHelper implementation into specific structure implementations

WTI-1621

Options
    • -72
    • +80
    /Application/Ringtoets/src/Application.Ringtoets.Setup/Licentie.rtf
    • -0
    • +62
    /Ringtoets.sln
    • -0
    • +25
    /Ringtoets/HeightStructures/src/Ringtoets.HeightStructures.Util/Properties/AssemblyInfo.cs
    • -0
    • +21
    /Ringtoets/HeightStructures/src/Ringtoets.HeightStructures.Util/Ringtoets.HeightStructures.Util.csproj
    • -0
    • +25
    /Ringtoets/HeightStructures/test/Ringtoets.HeightStructures.Util.Test/Properties/AssemblyInfo.cs
    • -0
    • +21
    /Ringtoets/HeightStructures/test/Ringtoets.HeightStructures.Util.Test/Ringtoets.HeightStructures.Util.Test.csproj
    • -0
    • +25
    /Ringtoets/StabilityPointStructures/src/Ringtoets.StabilityPointStructures.Util/Properties/AssemblyInfo.cs
    • -0
    • +21
    /Ringtoets/StabilityPointStructures/src/Ringtoets.StabilityPointStructures.Util/Ringtoets.StabilityPointStructures.Util.csproj
    • -0
    • +25
    /Ringtoets/StabilityPointStructures/test/Ringtoets.StabilityPointStructures.Util.Test/Properties/AssemblyInfo.cs
    • -0
    • +21
    /Ringtoets/StabilityPointStructures/test/Ringtoets.StabilityPointStructures.Util.Test/Ringtoets.StabilityPointStructures.Util.Test.csproj
10:16 am

Carlos Lubbers

Rename GetSectionSpecificN to GetN WTI-1616

Options
    • -5
    • +5
    /Ringtoets/Common/src/Ringtoets.Common.Data/Probability/ProbabilityAssessmentInputExtensions.cs
    • -1
    • +1
    /Ringtoets/Common/src/Ringtoets.Common.Forms/PropertyClasses/FailureMechanismSectionProbabilityAssessmentProperties.cs
    • -4
    • +4
    /Ringtoets/Common/test/Ringtoets.Common.Data.Test/Probability/ProbabilityAssessmentInputExtensionsTest.cs
    • -1
    • +1
    /Ringtoets/Integration/src/Ringtoets.Integration.Forms/PropertyClasses/StandAlone/MacroStabilityOutwardsFailureMechanismProperties.cs
    • -1
    • +1
    /Ringtoets/Integration/test/Ringtoets.Integration.Forms.Test/PropertyClasses/StandAlone/MacroStabilityOutwardsFailureMechanismPropertiesTest.cs
    • -1
    • +1
    /Ringtoets/MacroStabilityInwards/src/Ringtoets.MacroStabilityInwards.Forms/PropertyClasses/MacroStabilityInwardsFailureMechanismProperties.cs
    • -1
    • +1
    /Ringtoets/MacroStabilityInwards/test/Ringtoets.MacroStabilityInwards.Forms.Test/PropertyClasses/MacroStabilityInwardsFailureMechanismPropertiesTest.cs
    • -1
    • +1
    /Ringtoets/Piping/src/Ringtoets.Piping.Forms/PropertyClasses/PipingFailureMechanismProperties.cs
    • -1
    • +1
    /Ringtoets/Piping/test/Ringtoets.Piping.Forms.Test/PropertyClasses/PipingFailureMechanismPropertiesTest.cs
9:13 am

Elmar Kleijn

Review related changes

WTI-1531

Options
    • -6
    • +7
    /Application/Ringtoets/test/Application.Ringtoets.Storage.Test/Read/AssessmentSectionEntityReadExtensionsTest.cs
8:38 am

Elmar Kleijn

Review related changes

WTI-1531

Options
    • -14
    • +0
    /Ringtoets/GrassCoverErosionInwards/test/Ringtoets.GrassCoverErosionInwards.Forms.Test/PresentationObjects/GrassCoverErosionInwardsFailureMechanismContextTest.cs
    • -29
    • +0
    /Ringtoets/GrassCoverErosionOutwards/test/Ringtoets.GrassCoverErosionOutwards.Forms.Test/PresentationObjects/GrassCoverErosionOutwardsFailureMechanismContextTest.cs
    • -15
    • +0
    /Ringtoets/HeightStructures/test/Ringtoets.HeightStructures.Forms.Test/PresentationObjects/HeightStructuresFailureMechanismContextTest.cs
    • -0
    • +3
    /Ringtoets/Integration/test/Ringtoets.Integration.Data.Test/AssessmentSectionTest.cs
    • -14
    • +0
    /Ringtoets/Integration/test/Ringtoets.Integration.Forms.Test/PresentationObjects/StandAlone/MacroStabilityOutwardsFailureMechanismContextTest.cs
    • -14
    • +0
    /Ringtoets/Integration/test/Ringtoets.Integration.Forms.Test/PresentationObjects/StandAlone/PipingStructureFailureMechanismContextTest.cs
    • -1
    • +1
    /Ringtoets/Integration/test/Ringtoets.Integration.Forms.Test/PropertyClasses/StandAlone/PipingStructureFailureMechanismPropertiesTest.cs
    • -1
    • +0
    /Ringtoets/Integration/test/Ringtoets.Integration.Plugin.Test/TreeNodeInfos/MacroStabilityOutwardsFailureMechanismContextTreeNodeInfoTest.cs
    • -1
    • +0
    /Ringtoets/Integration/test/Ringtoets.Integration.Plugin.Test/TreeNodeInfos/PipingStructureFailureMechanismContextTreeNodeInfoTest.cs
    • -14
    • +0
    /Ringtoets/MacroStabilityInwards/test/Ringtoets.MacroStabilityInwards.Forms.Test/PresentationObjects/MacroStabilityInwardsFailureMechanismContextTest.cs
    • -1
    • +1
    /Ringtoets/Piping/src/Ringtoets.Piping.Forms/PropertyClasses/PipingFailureMechanismProperties.cs
    • -14
    • +0
    /Ringtoets/Piping/test/Ringtoets.Piping.Forms.Test/PresentationObjects/PipingFailureMechanismContextTest.cs
    • -1
    • +1
    /Ringtoets/StabilityStoneCover/src/Ringtoets.StabilityStoneCover.Forms/PropertyClasses/StabilityStoneCoverFailureMechanismProperties.cs
    • -32
    • +0
    /Ringtoets/StabilityStoneCover/test/Ringtoets.StabilityStoneCover.Forms.Test/PresentationObjects/StabilityStoneCoverFailureMechanismContextTest.cs
    • -1
    • +1
    /Ringtoets/StabilityStoneCover/test/Ringtoets.StabilityStoneCover.Forms.Test/PropertyClasses/StabilityStoneCoverFailureMechanismPropertiesTest.cs
  16. … 3 more files in changeset.
Thursday 15 Feb 2018
4:20 pm

Carlos Lubbers

Implement detailed assessment methods in the calculator stub WTI-1616

Options
    • -0
    • +176
    /Ringtoets/AssemblyTool/test/Ringtoets.AssemblyTool.KernelWrapper.TestUtil.Test/Calculators/Assembly/FailureMechanismSectionAssemblyCalculatorStubTest.cs
    • -8
    • +43
    /Ringtoets/AssemblyTool/test/Ringtoets.AssemblyTool.KernelWrapper.TestUtil/Calculators/Assembly/FailureMechanismSectionAssemblyCalculatorStub.cs
3:53 pm

Dennis Tang <dennis.tang@deltares.nl>

Rewired SectionResult to the mirror property SectionResult2 for HeightStructures in Forms: - Adjusted ScenarioRow and the view

WTI-1621

Options
    • -3
    • +3
    /Ringtoets/HeightStructures/src/Ringtoets.HeightStructures.Forms/Views/HeightStructuresScenarioRow.cs
    • -1
    • +1
    /Ringtoets/HeightStructures/src/Ringtoets.HeightStructures.Forms/Views/HeightStructuresScenariosView.cs
    • -3
    • +3
    /Ringtoets/HeightStructures/test/Ringtoets.HeightStructures.Forms.Test/Views/HeightStructuresScenarioRowTest.cs
3:42 pm

Dennis Tang <dennis.tang@deltares.nl>

Final cleanup of StructuresFailureMechanismSectionResult<T> implementations for ClosingStructures: - Adjusted TreeNodeInfo and Plugin

WTI-1621

Options
    • -2
    • +1
    /Ringtoets/ClosingStructures/src/Ringtoets.ClosingStructures.Plugin/ClosingStructuresPlugin.cs
    • -2
    • +1
    /Ringtoets/ClosingStructures/test/Ringtoets.ClosingStructures.Plugin.Test/ClosingStructuresPluginTest.cs
    • -5
    • +4
    /Ringtoets/ClosingStructures/test/Ringtoets.ClosingStructures.Plugin.Test/TreeNodeInfos/ClosingStructuresProbabilityFailureMechanismSectionResultContextTreeNodeInfoTest.cs