Riskeer

Clone Tools

Stats

Commits this week: 0
Total Committers: 28
Last Commit: 26 Nov
Commits this week: 0

Lines of code count not available

Commit Activity

Commits By Day In Week
52 week commits volume
Commits By Day In Week
Commits by day
Commits By Day In Week
Commits by hour
Commits By Hour In Day
Commit calendar
 

Most active committers (90 days)

loading
loading
  • last updated a few seconds ago
All Commits Reviews
Constraints
Constraints: committers
 
Constraints: files
Constraints: dates
Friday 16 Nov 2018
1:54 pm

Robert Tangerman <robert.tangerman@deltares.nl>

Fixed tests. WTI-977

Options
    • -53
    • +0
    /Ringtoets/Integration/test/Ringtoets.Integration.TestUtil.Test/DataImportHelperTest.cs
    • -1
    • +2
    /Ringtoets/Storage/src/Ringtoets.Storage.Core/Create/AssessmentSectionCreateExtensions.cs
    • -1
    • +1
    /Ringtoets/Storage/test/Ringtoets.Storage.Core.Test/Read/AssessmentSectionEntityReadExtensionsTest.cs
1:51 pm

Dennis Tang <dennis.tang@deltares.nl>

Implemented comments review 3379. WTI-1554

- Sanitized csproj files

- Cleaned up code

Options
    • -2
    • +2
    /Ringtoets/Common/test/Ringtoets.Common.Forms.TestUtil/MapThemeTestHelper.cs
    • -0
    • +1
    /Ringtoets/Integration/src/Ringtoets.Integration.Forms/Ringtoets.Integration.Forms.csproj
    • -1
    • +0
    /Ringtoets/Integration/src/Ringtoets.Integration.Util/Ringtoets.Integration.Util.csproj
    • -1
    • +0
    /Ringtoets/Integration/test/Ringtoets.Integration.Util.Test/Ringtoets.Integration.Util.Test.csproj
1:31 pm

Robert Tangerman <robert.tangerman@deltares.nl>

Fixed tests. WTI-977

Options
    • -5
    • +0
    /Ringtoets/Integration/src/Ringtoets.Integration.IO/Factories/ExportableAssessmentSectionFactory.cs
    • -14
    • +0
    /Ringtoets/Integration/test/Ringtoets.Integration.IO.Test/Factories/ExportableAssessmentSectionFactoryTest.cs
    • -4
    • +5
    /Ringtoets/Integration/test/Ringtoets.Integration.Plugin.Test/Handlers/ReferenceLineReplacementHandlerTest.cs
    • -32
    • +1
    /Ringtoets/Integration/test/Ringtoets.Integration.Service.Test/RingtoetsDataSynchronizationServiceTest.cs
1:12 pm

Dennis Tang <dennis.tang@deltares.nl>

Added missing tests WTI-1887

- Added for the derived classes: default category should be added when a theme is defined for an attribute that's not present in the features.

- Added for the filter expression, test in the base class to guarantee it always gives the expected expression.

- Fixed parameter names

Options
    • -1
    • +29
    /Core/Components/test/Core.Components.DotSpatial.Test/Converter/FeatureBasedMapDataConverterTest.cs
    • -0
    • +50
    /Core/Components/test/Core.Components.DotSpatial.Test/Converter/MapLineDataConverterTest.cs
    • -3
    • +57
    /Core/Components/test/Core.Components.DotSpatial.Test/Converter/MapPointDataConverterTest.cs
    • -7
    • +57
    /Core/Components/test/Core.Components.DotSpatial.Test/Converter/MapPolygonDataConverterTest.cs
12:00 pm

Robert Tangerman <robert.tangerman@deltares.nl>

Fixed tests. WTI-977

Options
    • -1
    • +2
    /Ringtoets/Common/test/Ringtoets.Common.Data.TestUtil.Test/AssessmentSectionStubTest.cs
    • -7
    • +1
    /Ringtoets/Integration/test/Ringtoets.Integration.Forms.Test/Commands/AssessmentSectionFromFileCommandHandlerTest.cs
11:51 am

Dennis Tang <dennis.tang@deltares.nl>

Fixed converters. WTI-1887

- Added category creation logic in the converters and pushed tests downwards for the derived datatypes from the converter base class.

Options
    • -2
    • +7
    /Core/Components/src/Core.Components.DotSpatial/Converter/FeatureBasedMapDataConverter.cs
    • -10
    • +35
    /Core/Components/src/Core.Components.DotSpatial/Converter/MapLineDataConverter.cs
    • -15
    • +34
    /Core/Components/src/Core.Components.DotSpatial/Converter/MapPointDataConverter.cs
    • -10
    • +36
    /Core/Components/src/Core.Components.DotSpatial/Converter/MapPolygonDataConverter.cs
    • -11
    • +5
    /Core/Components/test/Core.Components.DotSpatial.Test/Converter/FeatureBasedMapDataConverterTest.cs
    • -20
    • +89
    /Core/Components/test/Core.Components.DotSpatial.Test/Converter/MapLineDataConverterTest.cs
    • -21
    • +98
    /Core/Components/test/Core.Components.DotSpatial.Test/Converter/MapPointDataConverterTest.cs
    • -15
    • +88
    /Core/Components/test/Core.Components.DotSpatial.Test/Converter/MapPolygonDataConverterTest.cs
11:43 am

Robert Tangerman <robert.tangerman@deltares.nl>

Fixed compilation errors. WTI-977

Options
    • -3
    • +7
    /Ringtoets/Integration/src/Ringtoets.Integration.Plugin/Handlers/ReferenceLineReplacementHandler.cs
    • -11
    • +4
    /Ringtoets/Integration/src/Ringtoets.Integration.Service/RingtoetsDataSynchronizationService.cs
    • -4
    • +4
    /Ringtoets/Integration/test/Ringtoets.Integration.Service.Test/RingtoetsDataSynchronizationServiceTest.cs
11:19 am

Robert Tangerman <robert.tangerman@deltares.nl>

Fixed compilation errors. WTI-977

Options
    • -1
    • +1
    /Ringtoets/StabilityStoneCover/test/Ringtoets.StabilityStoneCover.Plugin.Test/UpdateInfos/StabilityStoneCoverFailureMechanismSectionsContextUpdateInfoTest.cs
    • -2
    • +1
    /Ringtoets/WaveImpactAsphaltCover/test/Ringtoets.WaveImpactAsphaltCover.Forms.Test/PropertyClasses/WaveImpactAsphaltCoverFailureMechanismPropertiesTest.cs
    • -1
    • +1
    /Ringtoets/WaveImpactAsphaltCover/test/Ringtoets.WaveImpactAsphaltCover.Plugin.Test/UpdateInfos/WaveImpactAsphaltCoverFailureMechanismSectionsContextUpdateInfoTest.cs
11:18 am

Robert Tangerman <robert.tangerman@deltares.nl>

Fixed compilation errors. WTI-977

Options
    • -4
    • +3
    /Ringtoets/StabilityPointStructures/test/Ringtoets.StabilityPointStructures.Plugin.Test/ImportInfos/StabilityPointStructuresContextImportInfoTest.cs
    • -2
    • +1
    /Ringtoets/StabilityPointStructures/test/Ringtoets.StabilityPointStructures.Plugin.Test/UpdateInfos/StabilityPointStructuresContextUpdateInfoTest.cs
    • -1
    • +1
    /Ringtoets/StabilityPointStructures/test/Ringtoets.StabilityPointStructures.Plugin.Test/UpdateInfos/StabilityPointStructuresFailureMechanismSectionsContextUpdateInfoTest.cs
11:13 am

Robert Tangerman <robert.tangerman@deltares.nl>

Fixed compilation errors. WTI-977

Options
    • -2
    • +1
    /Ringtoets/Piping/test/Ringtoets.Piping.Forms.Test/PropertyClasses/PipingFailureMechanismPropertiesTest.cs
    • -2
    • +1
    /Ringtoets/Piping/test/Ringtoets.Piping.Plugin.Test/ImportInfos/PipingStochasticSoilModelCollectionContextImportInfoTest.cs
    • -4
    • +2
    /Ringtoets/Piping/test/Ringtoets.Piping.Plugin.Test/ImportInfos/PipingSurfaceLinesContextImportInfoTest.cs
    • -1
    • +1
    /Ringtoets/Piping/test/Ringtoets.Piping.Plugin.Test/UpdateInfos/PipingFailureMechanismSectionsContextUpdateInfoTest.cs
    • -2
    • +1
    /Ringtoets/Piping/test/Ringtoets.Piping.Plugin.Test/UpdateInfos/PipingSurfaceLinesContextUpdateInfoTest.cs
11:11 am

Robert Tangerman <robert.tangerman@deltares.nl>

Fixed compilation errors. WTI-977

Options
    • -2
    • +1
    /Ringtoets/MacroStabilityInwards/test/Ringtoets.MacroStabilityInwards.Forms.Test/PropertyClasses/MacroStabilityInwardsFailureMechanismPropertiesTest.cs
    • -2
    • +1
    /Ringtoets/MacroStabilityInwards/test/Ringtoets.MacroStabilityInwards.Plugin.Test/ImportInfos/MacroStabilityInwardsStochasticSoilModelCollectionContextImportInfoTest.cs
    • -4
    • +2
    /Ringtoets/MacroStabilityInwards/test/Ringtoets.MacroStabilityInwards.Plugin.Test/ImportInfos/MacroStabilityInwardsSurfaceLinesContextImportInfoTest.cs
    • -1
    • +1
    /Ringtoets/MacroStabilityInwards/test/Ringtoets.MacroStabilityInwards.Plugin.Test/UpdateInfos/MacroStabilityInwardsFailureMechanismSectionsContextUpdateInfoTest.cs
    • -2
    • +1
    /Ringtoets/MacroStabilityInwards/test/Ringtoets.MacroStabilityInwards.Plugin.Test/UpdateInfos/MacroStabilityInwardsSurfaceLinesContextUpdateInfoTest.cs
10:47 am

Robert Tangerman <robert.tangerman@deltares.nl>

Fixed compilation errors. WTI-977

Options
    • -6
    • +3
    /Ringtoets/Integration/test/Ringtoets.Integration.Forms.Test/PropertyClasses/ReferenceLinePropertiesTest.cs
    • -2
    • +1
    /Ringtoets/Integration/test/Ringtoets.Integration.Forms.Test/PropertyClasses/StandAlone/MacroStabilityOutwardsFailureMechanismPropertiesTest.cs
    • -2
    • +1
    /Ringtoets/Integration/test/Ringtoets.Integration.IO.Test/Factories/ExportableDuneErosionFailureMechanismFactoryTest.cs
    • -6
    • +2
    /Ringtoets/Integration/test/Ringtoets.Integration.IO.Test/Factories/ExportableFailureMechanismFactoryTest.cs
    • -2
    • +1
    /Ringtoets/Integration/test/Ringtoets.Integration.IO.Test/Factories/ExportableGrassCoverErosionOutwardsFailureMechanismFactoryTest.cs
    • -2
    • +1
    /Ringtoets/Integration/test/Ringtoets.Integration.IO.Test/Factories/ExportableGrassCoverSlipOffInwardsFailureMechanismFactoryTest.cs
    • -2
    • +1
    /Ringtoets/Integration/test/Ringtoets.Integration.IO.Test/Factories/ExportableGrassCoverSlipOffOutwardsFailureMechanismFactoryTest.cs
    • -2
    • +1
    /Ringtoets/Integration/test/Ringtoets.Integration.IO.Test/Factories/ExportableMicrostabilityFailureMechanismFactoryTest.cs
    • -2
    • +1
    /Ringtoets/Integration/test/Ringtoets.Integration.IO.Test/Factories/ExportablePipingStructureFailureMechanismFactoryTest.cs
    • -2
    • +1
    /Ringtoets/Integration/test/Ringtoets.Integration.IO.Test/Factories/ExportableStabilityStoneCoverFailureMechanismFactoryTest.cs
    • -2
    • +1
    /Ringtoets/Integration/test/Ringtoets.Integration.IO.Test/Factories/ExportableStrengthStabilityLengthwiseConstructionFailureMechanismFactoryTest.cs
    • -2
    • +1
    /Ringtoets/Integration/test/Ringtoets.Integration.IO.Test/Factories/ExportableTechnicalInnovationFailureMechanismFactoryTest.cs
    • -2
    • +1
    /Ringtoets/Integration/test/Ringtoets.Integration.IO.Test/Factories/ExportableWaterPressureAsphaltCoverFailureMechanismFactoryTest.cs
    • -2
    • +1
    /Ringtoets/Integration/test/Ringtoets.Integration.IO.Test/Factories/ExportableWaveImpactAsphaltCoverFailureMechanismFactoryTest.cs
    • -4
    • +2
    /Ringtoets/Integration/test/Ringtoets.Integration.Plugin.Test/ImportInfos/FailureMechanismSectionsContextImportInfoTest.cs
  16. … 11 more files in changeset.
10:36 am

Robert Tangerman <robert.tangerman@deltares.nl>

Fixed compilation errors. WTI-977

Options
    • -4
    • +3
    /Ringtoets/HeightStructures/test/Ringtoets.HeightStructures.Plugin.Test/ImportInfos/HeightStructuresContextImportInfoTest.cs
    • -2
    • +1
    /Ringtoets/HeightStructures/test/Ringtoets.HeightStructures.Plugin.Test/UpdateInfos/HeightStructuresContextUpdateInfoTest.cs
    • -1
    • +1
    /Ringtoets/HeightStructures/test/Ringtoets.HeightStructures.Plugin.Test/UpdateInfos/HeightStructuresFailureMechanismSectionsContextUpdateInfoTest.cs
10:34 am

Robert Tangerman <robert.tangerman@deltares.nl>

Fixed compilation errors. WTI-977

Options
    • -4
    • +2
    /Ringtoets/GrassCoverErosionInwards/test/Ringtoets.GrassCoverErosionInwards.Plugin.Test/ImportInfos/DikeProfilesContextImportInfoTest.cs
    • -4
    • +2
    /Ringtoets/GrassCoverErosionInwards/test/Ringtoets.GrassCoverErosionInwards.Plugin.Test/UpdateInfos/DikeProfilesContextUpdateInfoTest.cs
    • -1
    • +1
    /Ringtoets/GrassCoverErosionInwards/test/Ringtoets.GrassCoverErosionInwards.Plugin.Test/UpdateInfos/GrassCoverErosionInwardsFailureMechanismSectionsContextUpdateInfoTest.cs
    • -1
    • +1
    /Ringtoets/GrassCoverErosionOutwards/test/Ringtoets.GrassCoverErosionOutwards.Plugin.Test/UpdateInfos/GrassCoverErosionOutwardsFailureMechanismSectionsContextUpdateInfoTest.cs
10:32 am

Robert Tangerman <robert.tangerman@deltares.nl>

Fixed compilation errors. WTI-977

Options
    • -1
    • +1
    /Ringtoets/DuneErosion/test/Ringtoets.DuneErosion.Plugin.Test/UpdateInfos/DuneErosionFailureMechanismSectionsContextUpdateInfoTest.cs
10:28 am

Robert Tangerman <robert.tangerman@deltares.nl>

Fixed compilation errors. WTI-977

Options
    • -3
    • +2
    /Ringtoets/ClosingStructures/test/Ringtoets.ClosingStructures.Plugin.Test/ImportInfos/ClosingStructuresContextImportInfoTest.cs
    • -3
    • +2
    /Ringtoets/ClosingStructures/test/Ringtoets.ClosingStructures.Plugin.Test/UpdateInfos/ClosingStructuresContextUpdateInfoTest.cs
    • -1
    • +1
    /Ringtoets/ClosingStructures/test/Ringtoets.ClosingStructures.Plugin.Test/UpdateInfos/ClosingStructuresFailureMechanismSectionsContextUpdateInfoTest.cs
10:20 am

Robert Tangerman <robert.tangerman@deltares.nl>

Fixed compilation errors. WTI-977

Options
    • -6
    • +3
    /Ringtoets/Common/test/Ringtoets.Common.Data.TestUtil/AssessmentSectionTestHelper.cs
    • -5
    • +2
    /Ringtoets/Common/test/Ringtoets.Common.Forms.Test/PresentationObjects/ReferenceLineContextTest.cs
    • -6
    • +6
    /Ringtoets/Common/test/Ringtoets.Common.Forms.Test/UpdateInfos/RingtoetsUpdateInfoFactoryTest.cs
    • -11
    • +10
    /Ringtoets/Common/test/Ringtoets.Common.IO.Test/FileImporters/ForeshoreProfilesImporterTest.cs
    • -7
    • +7
    /Ringtoets/Common/test/Ringtoets.Common.IO.Test/ReferenceLines/ReferenceLineImporterTest.cs
10:08 am

Robert Tangerman <robert.tangerman@deltares.nl>

Fixed compilation errors. WTI-977

Options
    • -5
    • +1
    /Ringtoets/Storage/src/Ringtoets.Storage.Core/Read/AssessmentSectionEntityReadExtensions.cs
10:05 am

Robert Tangerman <robert.tangerman@deltares.nl>

Removed ReferenceLine setter from IAssessmentSection. WTI-977

Options
    • -2
    • +2
    /Ringtoets/Common/src/Ringtoets.Common.Data/AssessmentSection/IAssessmentSection.cs
10:03 am

Robert Tangerman <robert.tangerman@deltares.nl>

Fixed tests. WTI-977

Options
    • -0
    • +2
    /Ringtoets/Integration/test/Ringtoets.Integration.Forms.Test/PropertyClasses/StandAlone/MacroStabilityOutwardsFailureMechanismPropertiesTest.cs
    • -0
    • +2
    /Ringtoets/MacroStabilityInwards/test/Ringtoets.MacroStabilityInwards.Forms.Test/PropertyClasses/MacroStabilityInwardsFailureMechanismPropertiesTest.cs
    • -0
    • +2
    /Ringtoets/Piping/test/Ringtoets.Piping.Forms.Test/PropertyClasses/PipingFailureMechanismPropertiesTest.cs
    • -0
    • +2
    /Ringtoets/WaveImpactAsphaltCover/test/Ringtoets.WaveImpactAsphaltCover.Forms.Test/PropertyClasses/WaveImpactAsphaltCoverFailureMechanismPropertiesTest.cs
9:55 am

Robert Tangerman <robert.tangerman@deltares.nl>

Fixed tests. WTI-977

Options
    • -6
    • +6
    /Ringtoets/Piping/test/Ringtoets.Piping.Forms.Test/PropertyClasses/PipingOutputPropertiesTest.cs
9:48 am

Robert Tangerman <robert.tangerman@deltares.nl>

Fixed tests. WTI-977

Options
    • -4
    • +12
    /Ringtoets/MacroStabilityInwards/test/Ringtoets.MacroStabilityInwards.Data.Test/DerivedMacroStabilityInwardsOutputFactoryTest.cs
    • -2
    • +2
    /Ringtoets/Piping/test/Ringtoets.Piping.Data.Test/DerivedPipingOutputFactoryTest.cs
8:15 am

Robert Tangerman <robert.tangerman@deltares.nl>

Initialize reference line in assessment section constructor. WTI-977

Options
    • -0
    • +1
    /Ringtoets/Integration/src/Ringtoets.Integration.Data/AssessmentSection.cs
    • -1
    • +4
    /Ringtoets/Integration/test/Ringtoets.Integration.Data.Test/AssessmentSectionTest.cs
8:10 am

Robert Tangerman <robert.tangerman@deltares.nl>

Fixed tests. WTI-977

Options
    • -2
    • +2
    /Ringtoets/Common/src/Ringtoets.Common.Forms/Factories/RingtoetsMapDataFeaturesFactory.cs
    • -0
    • +10
    /Ringtoets/Common/test/Ringtoets.Common.Forms.Test/Factories/RingtoetsMapDataFeaturesFactoryTest.cs
Thursday 15 Nov 2018
4:04 pm

Dennis Tang <dennis.tang@deltares.nl>

Adjusted base converter WTI-1887

- Turned the base converter into a template pattern class, as the derived classes should provide the implementations to convert categories

Options
    • -44
    • +17
    /Core/Components/src/Core.Components.DotSpatial/Converter/FeatureBasedMapDataConverter.cs
    • -109
    • +67
    /Core/Components/test/Core.Components.DotSpatial.Test/Converter/FeatureBasedMapDataConverterTest.cs
2:39 pm

Robert Tangerman <robert.tangerman@deltares.nl>

Fixed tests. WTI-977

Options
    • -1
    • +1
    /Ringtoets/Common/test/Ringtoets.Common.Data.TestUtil.Test/AssessmentSectionStubTest.cs
    • -0
    • +1
    /Ringtoets/Common/test/Ringtoets.Common.Data.TestUtil/AssessmentSectionStub.cs
2:35 pm

Robert Tangerman <robert.tangerman@deltares.nl>

Fixed tests. WTI-977

Options
    • -0
    • +3
    /Ringtoets/Common/test/Ringtoets.Common.Data.TestUtil.Test/AssessmentSectionTestHelperTest.cs
    • -1
    • +5
    /Ringtoets/Common/test/Ringtoets.Common.Data.TestUtil/AssessmentSectionTestHelper.cs
2:24 pm

Dennis Tang <dennis.tang@deltares.nl>

Pushed (Map)Theme property from the base down to derived classes. WTI-1887

- Pushed down as the derived classes each has their own specific styling options and thus their own categorical theming.

Options
    • -6
    • +0
    /Core/Components/src/Core.Components.Gis/Data/FeatureBasedMapData.cs
    • -0
    • +6
    /Core/Components/src/Core.Components.Gis/Data/MapLineData.cs
    • -0
    • +6
    /Core/Components/src/Core.Components.Gis/Data/MapPointData.cs
    • -0
    • +6
    /Core/Components/src/Core.Components.Gis/Data/MapPolygonData.cs
    • -1
    • +0
    /Core/Components/test/Core.Components.Gis.Test/Data/FeatureBasedMapDataTest.cs
    • -3
    • +9
    /Core/Components/test/Core.Components.Gis.Test/Data/MapLineDataTest.cs
    • -4
    • +10
    /Core/Components/test/Core.Components.Gis.Test/Data/MapPointDataTest.cs
    • -4
    • +9
    /Core/Components/test/Core.Components.Gis.Test/Data/MapPolygonDataTest.cs
    • -2
    • +0
    /Core/Components/test/Core.Components.Gis.Test/TestFeatureBasedMapDataTest.cs
1:56 pm

Dennis Tang <dennis.tang@deltares.nl>

Made MapTheme typed. WTI-1887

- Made it typed as a preparation for pushing the MapTheme property down to its derived classes for the FeatureBasedMapData

Options
    • -5
    • +6
    /Core/Components/src/Core.Components.Gis/Theme/MapTheme.cs
    • -11
    • +18
    /Core/Components/test/Core.Components.Gis.Test/Theme/MapThemeTest.cs
1:42 pm

Dennis Tang <dennis.tang@deltares.nl>

Updated CategoryTheme. WTI-1887

- Made class abstract, as it serves as a base for the specific Map type data

- Removed Color property as it is already contained within the derived classes and their specific styling

Options
    • -10
    • +2
    /Core/Components/src/Core.Components.Gis/Theme/CategoryTheme.cs
    • -1
    • +1
    /Core/Components/src/Core.Components.Gis/Theme/LineCategoryTheme.cs
    • -1
    • +1
    /Core/Components/src/Core.Components.Gis/Theme/PointCategoryTheme.cs
    • -1
    • +1
    /Core/Components/src/Core.Components.Gis/Theme/PolygonCategoryTheme.cs
    • -14
    • +9
    /Core/Components/test/Core.Components.Gis.Test/Theme/CategoryThemeTest.cs