Riskeer

Clone Tools

Stats

Commits this week: 0
Total Committers: 28
Last Commit: 26 Nov
Commits this week: 0

Lines of code count not available

Commit Activity

Commits By Day In Week
52 week commits volume
Commits By Day In Week
Commits by day
Commits By Day In Week
Commits by hour
Commits By Hour In Day
Commit calendar
 

Most active committers (90 days)

loading
loading
  • last updated a few seconds ago
All Commits Reviews
Constraints
Constraints: committers
 
Constraints: files
Constraints: dates
Wednesday 28 Mar 2018
4:15 pm

Dennis Tang <dennis.tang@deltares.nl>

Incorporated comments review 2630: - Cleaned up tests -- removed hard coded constants as much as possible - Improved implementation of row object: -- Used attribute type converter instead of making a display wrapper every time - Renamed helper for clarification

WTI-1538

Options
    • -0
    • +110
    /Ringtoets/Common/src/Ringtoets.Common.Forms/Helpers/AssemblyCategoryGroupColorHelper.cs
    • -110
    • +0
    /Ringtoets/Common/src/Ringtoets.Common.Forms/Helpers/AssemblyCategoryGroupHelper.cs
    • -1
    • +1
    /Ringtoets/Common/src/Ringtoets.Common.Forms/Helpers/FailureMechanismSectionResultRowHelper.cs
    • -36
    • +0
    /Ringtoets/Common/src/Ringtoets.Common.Forms/Properties/Resources.Designer.cs
    • -12
    • +0
    /Ringtoets/Common/src/Ringtoets.Common.Forms/Properties/Resources.resx
    • -1
    • +1
    /Ringtoets/Common/src/Ringtoets.Common.Forms/Ringtoets.Common.Forms.csproj
    • -0
    • +83
    /Ringtoets/Common/test/Ringtoets.Common.Forms.Test/Helpers/AssemblyCategoryGroupColorHelperTest.cs
    • -83
    • +0
    /Ringtoets/Common/test/Ringtoets.Common.Forms.Test/Helpers/AssemblyCategoryGroupHelperTest.cs
    • -1
    • +1
    /Ringtoets/Common/test/Ringtoets.Common.Forms.Test/Ringtoets.Common.Forms.Test.csproj
    • -10
    • +10
    /Ringtoets/Common/test/Ringtoets.Common.Forms.TestUtil.Test/AssemblyCategoryGroupTestHelperTest.cs
    • -0
    • +36
    /Ringtoets/Integration/src/Ringtoets.Integration.Forms/Properties/Resources.Designer.cs
    • -0
    • +12
    /Ringtoets/Integration/src/Ringtoets.Integration.Forms/Properties/Resources.resx
    • -1
    • +1
    /Ringtoets/Integration/src/Ringtoets.Integration.Forms/Views/AssessmentSectionAssemblyCategoriesTable.cs
    • -5
    • +1
    /Ringtoets/Integration/src/Ringtoets.Integration.Forms/Views/AssessmentSectionAssemblyCategoriesView.cs
    • -4
    • +5
    /Ringtoets/Integration/src/Ringtoets.Integration.Forms/Views/AssessmentSectionAssemblyCategoryRow.cs
  16. … 4 more files in changeset.
3:58 pm

Elmar Kleijn

Removed redundant Data set calls. WTI-1612

Options
    • -1
    • +0
    /Ringtoets/MacroStabilityInwards/src/Ringtoets.MacroStabilityInwards.Forms/Views/MacroStabilityInwardsOutputView.Designer.cs
    • -2
    • +0
    /Ringtoets/MacroStabilityInwards/src/Ringtoets.MacroStabilityInwards.Forms/Views/MacroStabilityInwardsOutputView.cs
3:57 pm

Elmar Kleijn

Implemented CreateInstance method for MacroStabilityInwardsOutputView. WTI-1612

Options
    • -1
    • +3
    /Ringtoets/MacroStabilityInwards/src/Ringtoets.MacroStabilityInwards.Plugin/MacroStabilityInwardsPlugin.cs
    • -3
    • +14
    /Ringtoets/MacroStabilityInwards/test/Ringtoets.MacroStabilityInwards.Plugin.Test/ViewInfos/MacroStabilityInwardsOutputViewInfoTest.cs
3:43 pm

Robert Tangerman <robert.tangerman@deltares.nl>

Added test helper for adding locations and calculations to grass cover erosion outwards. WTI-1612

Options
    • -28
    • +7
    /Ringtoets/GrassCoverErosionOutwards/test/Ringtoets.GrassCoverErosionOutwards.Util.Test/GrassCoverErosionOutwardsAggregatedHydraulicBoundaryLocationFactoryTest.cs
    • -0
    • +8
    /Ringtoets/GrassCoverErosionOutwards/test/Ringtoets.GrassCoverErosionOutwards.Util.Test/Ringtoets.GrassCoverErosionOutwards.Util.Test.csproj
    • -0
    • +88
    /Ringtoets/GrassCoverErosionOutwards/test/Ringtoets.GrassCoverErosionOutwards.Util.TestUtil.Test/GrassCoverErosionOutwardsHydraulicBoundaryLocationsHelperTest.cs
    • -0
    • +31
    /Ringtoets/GrassCoverErosionOutwards/test/Ringtoets.GrassCoverErosionOutwards.Util.TestUtil.Test/Ringtoets.GrassCoverErosionOutwards.Util.TestUtil.Test.csproj
    • -0
    • +26
    /Ringtoets/GrassCoverErosionOutwards/test/Ringtoets.GrassCoverErosionOutwards.Util.TestUtil.Test/packages.config
    • -0
    • +80
    /Ringtoets/GrassCoverErosionOutwards/test/Ringtoets.GrassCoverErosionOutwards.Util.TestUtil/GrassCoverErosionOutwardsHydraulicBoundaryLocationsHelper.cs
    • -0
    • +19
    /Ringtoets/GrassCoverErosionOutwards/test/Ringtoets.GrassCoverErosionOutwards.Util.TestUtil/Ringtoets.GrassCoverErosionOutwards.Util.TestUtil.csproj
2:52 pm

Robert Tangerman <roberttangerman@gmail.com>

Added testUtil project for grass cover erosion outwards util. WTI-1612

Options
    • -0
    • +30
    /Ringtoets.sln
    • -0
    • +25
    /Ringtoets/GrassCoverErosionOutwards/test/Ringtoets.GrassCoverErosionOutwards.Util.TestUtil.Test/Properties/AssemblyInfo.cs
    • -0
    • +21
    /Ringtoets/GrassCoverErosionOutwards/test/Ringtoets.GrassCoverErosionOutwards.Util.TestUtil.Test/Ringtoets.GrassCoverErosionOutwards.Util.TestUtil.Test.csproj
    • -0
    • +25
    /Ringtoets/GrassCoverErosionOutwards/test/Ringtoets.GrassCoverErosionOutwards.Util.TestUtil/Properties/AssemblyInfo.cs
    • -0
    • +21
    /Ringtoets/GrassCoverErosionOutwards/test/Ringtoets.GrassCoverErosionOutwards.Util.TestUtil/Ringtoets.GrassCoverErosionOutwards.Util.TestUtil.csproj
2:24 pm

Elmar Kleijn

Fixed failing tests. WTI-1612

Options
    • -2
    • +2
    /Ringtoets/MacroStabilityInwards/test/Ringtoets.MacroStabilityInwards.Forms.Test/Views/MacroStabilityInwardsOutputChartControlTest.cs
    • -3
    • +3
    /Ringtoets/MacroStabilityInwards/test/Ringtoets.MacroStabilityInwards.Forms.Test/Views/MacroStabilityInwardsOutputViewTest.cs
2:17 pm

Elmar Kleijn

Fixed final compilation errors. WTI-1612

Options
    • -1
    • +2
    /Ringtoets/MacroStabilityInwards/test/Ringtoets.MacroStabilityInwards.Plugin.Test/ViewInfos/MacroStabilityInwardsOutputViewInfoTest.cs
1:58 pm

Elmar Kleijn

Improved MacroStabilityInwardsOutputViewTest and MacroStabilityInwardsOutputChartControlTest. WTI-1612

Options
    • -6
    • +2
    /Ringtoets/MacroStabilityInwards/test/Ringtoets.MacroStabilityInwards.Forms.Test/Views/MacroStabilityInwardsOutputChartControlTest.cs
    • -1
    • +0
    /Ringtoets/MacroStabilityInwards/test/Ringtoets.MacroStabilityInwards.Forms.Test/Views/MacroStabilityInwardsOutputViewTest.cs
1:53 pm

Elmar Kleijn

Adapted MacroStabilityInwardsOutputViewTest. WTI-1612

Options
    • -113
    • +73
    /Ringtoets/MacroStabilityInwards/test/Ringtoets.MacroStabilityInwards.Forms.Test/Views/MacroStabilityInwardsOutputViewTest.cs
1:50 pm

Robert Tangerman <robert.tangerman@deltares.nl>

Added factory for creating aggregated locations. WTI-1612

Options
    • -2
    • +2
    /Ringtoets/Common/test/Ringtoets.Common.Util.Test/AggregatedHydraulicBoundaryLocationFactoryTest.cs
    • -0
    • +110
    /Ringtoets/GrassCoverErosionOutwards/src/Ringtoets.GrassCoverErosionOutwards.Util/GrassCoverErosionOutwardsAggregatedHydraulicBoundaryLocationFactory.cs
    • -0
    • +11
    /Ringtoets/GrassCoverErosionOutwards/src/Ringtoets.GrassCoverErosionOutwards.Util/Ringtoets.GrassCoverErosionOutwards.Util.csproj
    • -0
    • +189
    /Ringtoets/GrassCoverErosionOutwards/test/Ringtoets.GrassCoverErosionOutwards.Util.Test/GrassCoverErosionOutwardsAggregatedHydraulicBoundaryLocationFactoryTest.cs
    • -0
    • +16
    /Ringtoets/GrassCoverErosionOutwards/test/Ringtoets.GrassCoverErosionOutwards.Util.Test/Ringtoets.GrassCoverErosionOutwards.Util.Test.csproj
    • -2
    • +3
    /Ringtoets/GrassCoverErosionOutwards/test/Ringtoets.GrassCoverErosionOutwards.Util.Test/packages.config
1:47 pm

Elmar Kleijn

Adapted MacroStabilityInwardsOutputViewTest. WTI-1612

Options
    • -36
    • +35
    /Ringtoets/MacroStabilityInwards/test/Ringtoets.MacroStabilityInwards.Forms.Test/Views/MacroStabilityInwardsOutputViewTest.cs
12:01 pm

Dennis Tang <dennis.tang@deltares.nl>

Cleanup: - Removed constraint on the combination of FKs of calculation collections (constraint was not present in the previous implementation)

WTI-1656

Options
    • -2
    • +1
    /Application/Ringtoets/src/Application.Ringtoets.Migration.Core/EmbeddedResources/DatabaseStructure18.1.sql
    • -84
    • +84
    /Application/Ringtoets/src/Application.Ringtoets.Storage/DbContext/RingtoetsEntities.edmx.diagram
    • binary
    /Application/Ringtoets/src/Application.Ringtoets.Storage/Ringtoets.rtd
    • binary
    /Application/Ringtoets/test/Application.Ringtoets.Migration.Core.Test/test-data/FullTestProject181.rtd
    • -2
    • +1
    /build/DatabaseStructure.sql
    • binary
    /design/DatabaseDesign.eap
11:30 am

Robert Tangerman <robert.tangerman@deltares.nl>

Added aggregated hydraulic boundary location object for grass cover erosion outwards. WTI-1612

Options
    • -0
    • +171
    /Ringtoets/GrassCoverErosionOutwards/src/Ringtoets.GrassCoverErosionOutwards.Util/GrassCoverErosionOutwardsAggregatedHydraulicBoundaryLocation.cs
    • -0
    • +8
    /Ringtoets/GrassCoverErosionOutwards/src/Ringtoets.GrassCoverErosionOutwards.Util/Ringtoets.GrassCoverErosionOutwards.Util.csproj
    • -0
    • +108
    /Ringtoets/GrassCoverErosionOutwards/test/Ringtoets.GrassCoverErosionOutwards.Util.Test/GrassCoverErosionOutwardsAggregatedHydraulicBoundaryLocationTest.cs
    • -0
    • +15
    /Ringtoets/GrassCoverErosionOutwards/test/Ringtoets.GrassCoverErosionOutwards.Util.Test/Ringtoets.GrassCoverErosionOutwards.Util.Test.csproj
11:24 am

Dennis Tang <dennis.tang@deltares.nl>

Cleanup: - Added missing asserts upon migration - Renamed the query generator functions to better distinct between HBL calculations that are migrated and HBL calculations that are newly created

WTI-1656

Options
    • -30
    • +54
    /Application/Ringtoets/test/Application.Ringtoets.Storage.Test/IntegrationTests/MigrationTo181IntegrationTest.cs
10:52 am

Dennis Tang <dennis.tang@deltares.nl>

Cleanup: - Fixed typo from migration script

WTI-1656

Options
    • -1
    • +1
    /Application/Ringtoets/src/Application.Ringtoets.Migration.Core/EmbeddedResources/Migration_17.3_18.1.sql
10:41 am

Dennis Tang <dennis.tang@deltares.nl>

Cleanup: - Updated the latest file version for the migration scripts to fix failing test

WTI-1656

Options
    • binary
    /Application/Ringtoets/test/Application.Ringtoets.Migration.Core.Test/test-data/FullTestProject181.rtd
10:37 am

Dennis Tang <dennis.tang@deltares.nl>

Cleanup: - Updated the database structure to fix failing test

WTI-1656

Options
    • -9
    • +9
    /Application/Ringtoets/src/Application.Ringtoets.Migration.Core/EmbeddedResources/DatabaseStructure18.1.sql
10:21 am

Dennis Tang <dennis.tang@deltares.nl>

Merge branch 'master' into 1607

Options
10:19 am

Dennis Tang <dennis.tang@deltares.nl>

Adjusted migration script and asserts: - Migrated the hydraulic location output based on the normative norm and mapped them onto the new HydraulicLocationOutputEntity and the corresponding HydraulicLocationCalculationEntities

WTI-1656

Options
    • -0
    • +88
    /Application/Ringtoets/src/Application.Ringtoets.Migration.Core/EmbeddedResources/Migration_17.3_18.1.sql
    • -35
    • +157
    /Application/Ringtoets/test/Application.Ringtoets.Storage.Test/IntegrationTests/MigrationTo181IntegrationTest.cs
10:09 am

Robert Tangerman <robert.tangerman@deltares.nl>

Added util project for grass cover erosion outwards. WTI-1612

Options
    • -94
    • +97
    /Application/Ringtoets/src/Application.Ringtoets.Setup/Licentie.rtf
    • -0
    • +32
    /Ringtoets.sln
    • -0
    • +25
    /Ringtoets/GrassCoverErosionOutwards/src/Ringtoets.GrassCoverErosionOutwards.Util/Properties/AssemblyInfo.cs
    • -0
    • +21
    /Ringtoets/GrassCoverErosionOutwards/src/Ringtoets.GrassCoverErosionOutwards.Util/Ringtoets.GrassCoverErosionOutwards.Util.csproj
    • -0
    • +25
    /Ringtoets/GrassCoverErosionOutwards/test/Ringtoets.GrassCoverErosionOutwards.Util.Test/Properties/AssemblyInfo.cs
    • -0
    • +25
    /Ringtoets/GrassCoverErosionOutwards/test/Ringtoets.GrassCoverErosionOutwards.Util.Test/Ringtoets.GrassCoverErosionOutwards.Util.Test.csproj
    • -0
    • +26
    /Ringtoets/GrassCoverErosionOutwards/test/Ringtoets.GrassCoverErosionOutwards.Util.Test/packages.config
Tuesday 27 Mar 2018
3:31 pm

Dennis Tang <dennis.tang@deltares.nl>

Adjusted migration script and asserts: - Migrated the hydraulic location input based on the normative norm and mapped them onto the new HydraulicLocationCalculationEntity - Refactored test

Note: output is not migrated yet

WTI-1656

Options
    • -0
    • +54
    /Application/Ringtoets/src/Application.Ringtoets.Migration.Core/EmbeddedResources/Migration_17.3_18.1.sql
    • -13
    • +140
    /Application/Ringtoets/test/Application.Ringtoets.Storage.Test/IntegrationTests/MigrationTo181IntegrationTest.cs
3:26 pm

Robert Tangerman <robert.tangerman@deltares.nl>

Cleanup. WTI-1612

Options
    • -0
    • +6
    /Ringtoets/ClosingStructures/test/Ringtoets.ClosingStructures.Forms.Test/Views/ClosingStructuresFailureMechanismViewTest.cs
3:26 pm

Robert Tangerman <robert.tangerman@deltares.nl>

Cleanup. WTI-1612

Options
    • -0
    • +6
    /Ringtoets/GrassCoverErosionInwards/test/Ringtoets.GrassCoverErosionInwards.Forms.Test/Views/GrassCoverErosionInwardsFailureMechanismViewTest.cs
3:25 pm

Robert Tangerman <robert.tangerman@deltares.nl>

Cleanup. WTI-1612

Options
    • -0
    • +6
    /Ringtoets/MacroStabilityInwards/test/Ringtoets.MacroStabilityInwards.Forms.Test/Views/MacroStabilityInwardsFailureMechanismViewTest.cs
3:24 pm

Robert Tangerman <robert.tangerman@deltares.nl>

Cleanup. WTI-1612

Options
    • -0
    • +6
    /Ringtoets/Piping/test/Ringtoets.Piping.Forms.Test/Views/PipingFailureMechanismViewTest.cs
3:23 pm

Robert Tangerman <robert.tangerman@deltares.nl>

Cleanup. WTI-1612

Options
    • -17
    • +29
    /Ringtoets/Common/src/Ringtoets.Common.Forms/Views/FailureMechanismView.cs
    • -0
    • +63
    /Ringtoets/Common/test/Ringtoets.Common.Forms.Test/Views/FailureMechanismViewTest.cs
3:19 pm

Robert Tangerman <robert.tangerman@deltares.nl>

Cleanup. WTI-1612

Options
    • -9
    • +17
    /Ringtoets/Integration/src/Ringtoets.Integration.Forms/Views/AssessmentSectionView.cs
    • -6
    • +49
    /Ringtoets/Integration/test/Ringtoets.Integration.Forms.Test/Views/AssessmentSectionViewTest.cs
3:14 pm

Robert Tangerman <robert.tangerman@deltares.nl>

Cleanup. WTI-1612

Options
    • -1
    • +1
    /Ringtoets/WaveImpactAsphaltCover/test/Ringtoets.WaveImpactAsphaltCover.Forms.Test/Views/WaveImpactAsphaltCoverFailureMechanismViewTest.cs
3:10 pm

Robert Tangerman <robert.tangerman@deltares.nl>

removed old observer. WTI-1612

Options
    • -7
    • +0
    /Ringtoets/WaveImpactAsphaltCover/src/Ringtoets.WaveImpactAsphaltCover.Forms/Views/WaveImpactAsphaltCoverFailureMechanismView.cs
    • -40
    • +0
    /Ringtoets/WaveImpactAsphaltCover/test/Ringtoets.WaveImpactAsphaltCover.Forms.Test/Views/WaveImpactAsphaltCoverFailureMechanismViewTest.cs
3:08 pm

Robert Tangerman <robert.tangerman@deltares.nl>

Added observers for hydraulic boundary location calculations. WTI-1612

Options
    • -0
    • +34
    /Ringtoets/WaveImpactAsphaltCover/src/Ringtoets.WaveImpactAsphaltCover.Forms/Views/WaveImpactAsphaltCoverFailureMechanismView.cs
    • -0
    • +35
    /Ringtoets/WaveImpactAsphaltCover/test/Ringtoets.WaveImpactAsphaltCover.Forms.Test/Views/WaveImpactAsphaltCoverFailureMechanismViewTest.cs