Riskeer

Clone Tools

Stats

Commits this week: 0
Total Committers: 28
Last Commit: 26 Nov
Commits this week: 0

Lines of code count not available

Commit Activity

Commits By Day In Week
52 week commits volume
Commits By Day In Week
Commits by day
Commits By Day In Week
Commits by hour
Commits By Hour In Day
Commit calendar
 

Most active committers (90 days)

loading
loading
  • last updated a few seconds ago
All Commits Reviews
Constraints
Constraints: committers
 
Constraints: files
Constraints: dates
Thursday 19 Apr 2018
3:06 pm

Dennis Tang <dennis.tang@deltares.nl>

Incorporated comments review 2714, 2715, 2717: - Added missing assert - Cleaned up testfiles

WTI-1570

Options
    • -1
    • +0
    /Ringtoets/GrassCoverErosionOutwards/test/Ringtoets.GrassCoverErosionOutwards.Forms.Test/GrassCoverErosionOutwardsFailureMechanismPropertyChangeHandlerTest.cs
    • -1
    • +1
    /Ringtoets/Integration/test/Ringtoets.Integration.Plugin.Test/Handlers/AssessmentSectionCompositionChangeHandlerTest.cs
    • -0
    • +7
    /Ringtoets/Integration/test/Ringtoets.Integration.TestUtil.Test/TestDataGeneratorTest.cs
3:01 pm

Dennis Tang <dennis.tang@deltares.nl>

Incorporated comments review 2713: - Cleaned up test

WTI-1570

Options
    • -2
    • +2
    /Ringtoets/Integration/test/Ringtoets.Integration.Forms.Test/PropertyClasses/NormPropertiesIntegrationTest.cs
2:58 pm

Dennis Tang <dennis.tang@deltares.nl>

Incorporated comments review 2711: - Updated XMLDocs - Cleaned up function call: hydraulic boundary location (HBL) database is not necessary to clear HBL calculation output anymore as the calculations are defined in a different object - Updated testfile

WTI-1570

Options
    • -2
    • +2
    /Ringtoets/GrassCoverErosionOutwards/src/Ringtoets.GrassCoverErosionOutwards.Service/GrassCoverErosionOutwardsDataSynchronizationService.cs
    • -2
    • +1
    /Ringtoets/Integration/src/Ringtoets.Integration.Plugin/Handlers/FailureMechanismContributionNormChangeHandler.cs
    • -13
    • +6
    /Ringtoets/Integration/src/Ringtoets.Integration.Service/RingtoetsDataSynchronizationService.cs
    • -146
    • +134
    /Ringtoets/Integration/test/Ringtoets.Integration.Service.Test/RingtoetsDataSynchronizationServiceTest.cs
    • -1
    • +1
    /Ringtoets/Integration/test/Ringtoets.Integration.TestUtil/TestDataGenerator.cs
2:38 pm

Carlos Lubbers

Update assembly categories calculator/kernelstub/factory WTI-1670

Options
    • -11
    • +10
    /Ringtoets/AssemblyTool/src/Ringtoets.AssemblyTool.KernelWrapper/Calculators/Assembly/IFailureMechanismSectionAssemblyCalculator.cs
    • -12
    • +8
    /Ringtoets/AssemblyTool/src/Ringtoets.AssemblyTool.KernelWrapper/Calculators/Categories/AssemblyCategoriesCalculator.cs
    • -10
    • +6
    /Ringtoets/AssemblyTool/src/Ringtoets.AssemblyTool.KernelWrapper/Calculators/Categories/IAssemblyCategoriesCalculator.cs
    • -25
    • +25
    /Ringtoets/AssemblyTool/test/Ringtoets.AssemblyTool.KernelWrapper.Test/Calculators/Categories/AssemblyCategoriesCalculatorTest.cs
    • -2
    • +2
    /Ringtoets/AssemblyTool/test/Ringtoets.AssemblyTool.KernelWrapper.Test/Creators/AssemblyCategoryCreatorTest.cs
    • -22
    • +28
    /Ringtoets/AssemblyTool/test/Ringtoets.AssemblyTool.KernelWrapper.TestUtil.Test/Calculators/Categories/AssemblyCategoriesCalculatorStubTest.cs
    • -19
    • +8
    /Ringtoets/AssemblyTool/test/Ringtoets.AssemblyTool.KernelWrapper.TestUtil/Calculators/Categories/AssemblyCategoriesCalculatorStub.cs
    • -8
    • +8
    /Ringtoets/Common/src/Ringtoets.Common.Data/AssemblyTool/AssemblyToolCategoriesFactory.cs
    • -8
    • +10
    /Ringtoets/Common/test/Ringtoets.Common.Data.Test/AssemblyTool/AssemblyToolCategoriesFactoryTest.cs
1:42 pm

Carlos Lubbers

Update xmldoc and tests WTI-1670

Options
    • -34
    • +38
    /Ringtoets/AssemblyTool/src/Ringtoets.AssemblyTool.KernelWrapper/Creators/AssemblyCategoryCreator.cs
    • -15
    • +15
    /Ringtoets/AssemblyTool/test/Ringtoets.AssemblyTool.KernelWrapper.Test/Creators/AssemblyCategoryCreatorTest.cs
1:34 pm

Carlos Lubbers

Adjust random number generator ranges WTI-1670

Options
    • -14
    • +14
    /Ringtoets/AssemblyTool/test/Ringtoets.AssemblyTool.KernelWrapper.Test/Calculators/Categories/AssemblyCategoriesCalculatorTest.cs
1:29 pm

Carlos Lubbers

Cleanup WTI-1670

Options
    • -2
    • +0
    /Ringtoets/GrassCoverErosionInwards/src/Ringtoets.GrassCoverErosionInwards.Data/GrassCoverErosionInwardsFailureMechanismSectionResultAssemblyFactory.cs
    • -2
    • +0
    /Ringtoets/HeightStructures/src/Ringtoets.HeightStructures.Data/HeightStructuresFailureMechanismSectionResultAssemblyFactory.cs
    • -2
    • +0
    /Ringtoets/Integration/src/Ringtoets.Integration.Data/StandAlone/AssemblyFactories/MacroStabilityOutwardsFailureMechanismSectionResultAssemblyFactory.cs
    • -2
    • +1
    /Ringtoets/MacroStabilityInwards/src/Ringtoets.MacroStabilityInwards.Data/MacroStabilityInwardsFailureMechanismSectionResultAssemblyFactory.cs
    • -2
    • +0
    /Ringtoets/StabilityPointStructures/src/Ringtoets.StabilityPointStructures.Data/StabilityPointStructuresFailureMechanismSectionResultAssemblyFactory.cs
1:22 pm

Carlos Lubbers

Add delta to assert WTI-1670

Options
    • -1
    • +1
    /Ringtoets/AssemblyTool/test/Ringtoets.AssemblyTool.Data.Test/AssemblyCategoriesInputTest.cs
1:20 pm

Carlos Lubbers

Cleanup factory WTI-1670

Options
    • -9
    • +0
    /Ringtoets/ClosingStructures/src/Ringtoets.ClosingStructures.Data/ClosingStructuresFailureMechanismSectionResultAssemblyFactory.cs
1:17 pm

Carlos Lubbers

Update xmldoc WTI-1670

Options
    • -2
    • +1
    /Ringtoets/AssemblyTool/src/Ringtoets.AssemblyTool.Data/AssemblyCategoriesInput.cs
1:07 pm

Carlos Lubbers

Switch assertion parameters around WTI-1670

Options
    • -5
    • +5
    /Ringtoets/AssemblyTool/test/Ringtoets.AssemblyTool.KernelWrapper.Test/Creators/FailureMechanismSectionAssemblyCalculatorInputCreatorTest.cs
12:56 pm

Carlos Lubbers

Set input for test randomly WTI-1670

Options
    • -2
    • +2
    /Ringtoets/AssemblyTool/test/Ringtoets.AssemblyTool.KernelWrapper.Test/Calculators/Assembly/FailureMechanismSectionAssemblyCalculatorTest.cs
12:47 pm

Carlos Lubbers

Rename convert methods WTI-1670

Options
    • -1
    • +1
    /Ringtoets/AssemblyTool/src/Ringtoets.AssemblyTool.KernelWrapper/Calculators/Assembly/FailureMechanismSectionAssemblyCalculator.cs
    • -9
    • +10
    /Ringtoets/AssemblyTool/src/Ringtoets.AssemblyTool.KernelWrapper/Creators/FailureMechanismSectionAssemblyCalculatorInputCreator.cs
    • -1
    • +1
    /Ringtoets/AssemblyTool/test/Ringtoets.AssemblyTool.KernelWrapper.Test/Calculators/Assembly/FailureMechanismSectionAssemblyCalculatorTest.cs
    • -4
    • +4
    /Ringtoets/AssemblyTool/test/Ringtoets.AssemblyTool.KernelWrapper.Test/Creators/FailureMechanismSectionAssemblyCalculatorInputCreatorTest.cs
11:40 am

Carlos Lubbers

Ensure correct order of assert parameters WTI-1670

Options
    • -8
    • +8
    /Ringtoets/AssemblyTool/test/Ringtoets.AssemblyTool.KernelWrapper.Test/Calculators/Assembly/FailureMechanismSectionAssemblyCalculatorTest.cs
11:29 am

Carlos Lubbers

Cleanup unused references WTI-1569

Paired with siuhintang

Options
    • -17
    • +0
    /Ringtoets/Integration/test/Ringtoets.Integration.Forms.Test/Ringtoets.Integration.Forms.Test.csproj
10:45 am

Carlos Lubbers

Add xmldoc WTI-1670

Options
    • -0
    • +15
    /Ringtoets/AssemblyTool/src/Ringtoets.AssemblyTool.Data/AssemblyCategoriesInput.cs
    • -2
    • +2
    /Ringtoets/AssemblyTool/src/Ringtoets.AssemblyTool.KernelWrapper/Creators/FailureMechanismSectionAssemblyCalculatorInputCreator.cs
10:39 am

Carlos Lubbers

Implement review comments, improve method and xmldoc changes WTI-1670

Options
    • -47
    • +23
    /Ringtoets/AssemblyTool/src/Ringtoets.AssemblyTool.KernelWrapper/Creators/FailureMechanismSectionAssemblyCalculatorInputCreator.cs
10:32 am

Carlos Lubbers

Change the way input is sent to the kernel for the combined assembly WTI-1670

Options
    • -16
    • +6
    /Ringtoets/AssemblyTool/src/Ringtoets.AssemblyTool.KernelWrapper/Calculators/Assembly/FailureMechanismSectionAssemblyCalculator.cs
    • -6
    • +4
    /Ringtoets/AssemblyTool/test/Ringtoets.AssemblyTool.KernelWrapper.Test/Calculators/Assembly/FailureMechanismSectionAssemblyCalculatorTest.cs
    • -2
    • +0
    /Ringtoets/AssemblyTool/test/Ringtoets.AssemblyTool.KernelWrapper.TestUtil.Test/Kernels/Categories/AssemblyCategoriesKernelStubTest.cs
10:14 am

Carlos Lubbers

Implement review comments from review 2705 WTI-1670

Options
    • -86
    • +105
    /Ringtoets/AssemblyTool/test/Ringtoets.AssemblyTool.KernelWrapper.TestUtil.Test/Kernels/Assembly/FailureMechanismSectionAssemblyKernelStubTest.cs
10:06 am

Carlos Lubbers

Change the way input is sent to the kernel for the combined assembly WTI-1670

Options
    • -8
    • +26
    /Ringtoets/AssemblyTool/src/Ringtoets.AssemblyTool.KernelWrapper/Calculators/Assembly/FailureMechanismSectionAssemblyCalculator.cs
    • -11
    • +16
    /Ringtoets/AssemblyTool/test/Ringtoets.AssemblyTool.KernelWrapper.Test/Calculators/Assembly/FailureMechanismSectionAssemblyCalculatorTest.cs
Wednesday 18 Apr 2018
3:23 pm

Carlos Lubbers

Also stop assembling the combined assembly when the result is FV/Iv WTI-1670

Options
    • -3
    • +3
    /Ringtoets/AssemblyTool/src/Ringtoets.AssemblyTool.KernelWrapper/Calculators/Assembly/FailureMechanismSectionAssemblyCalculator.cs
    • -9
    • +15
    /Ringtoets/AssemblyTool/test/Ringtoets.AssemblyTool.KernelWrapper.Test/Calculators/Assembly/FailureMechanismSectionAssemblyCalculatorTest.cs
3:05 pm

Carlos Lubbers

Remove unused reference WTI-1670

Options
    • -4
    • +0
    /Ringtoets/AssemblyTool/test/Ringtoets.AssemblyTool.KernelWrapper.TestUtil.Test/Ringtoets.AssemblyTool.KernelWrapper.TestUtil.Test.csproj
3:03 pm

Carlos Lubbers

Rename resource WTI-1670

Options
    • -2
    • +2
    /Ringtoets/AssemblyTool/src/Ringtoets.AssemblyTool.Data/AssessmentSectionAssemblyCategoryGroup.cs
    • -14
    • +5
    /Ringtoets/AssemblyTool/src/Ringtoets.AssemblyTool.Data/Properties/Resources.Designer.cs
    • -6
    • +3
    /Ringtoets/AssemblyTool/src/Ringtoets.AssemblyTool.Data/Properties/Resources.resx
2:59 pm

Carlos Lubbers

Fix failing test WTI-1670

Options
    • -3
    • +3
    /Ringtoets/AssemblyTool/test/Ringtoets.AssemblyTool.KernelWrapper.Test/Creators/FailureMechanismSectionAssemblyCalculatorInputCreatorTest.cs
2:57 pm

Carlos Lubbers

Rename and set some methods to internal WTI-1670

Options
    • -6
    • +6
    /Ringtoets/AssemblyTool/src/Ringtoets.AssemblyTool.KernelWrapper/Calculators/Assembly/FailureMechanismSectionAssemblyCalculator.cs
    • -12
    • +12
    /Ringtoets/AssemblyTool/src/Ringtoets.AssemblyTool.KernelWrapper/Creators/FailureMechanismSectionAssemblyCalculatorInputCreator.cs
    • -4
    • +4
    /Ringtoets/AssemblyTool/src/Ringtoets.AssemblyTool.KernelWrapper/Creators/FailureMechanismSectionAssemblyCreator.cs
    • -6
    • +7
    /Ringtoets/AssemblyTool/test/Ringtoets.AssemblyTool.KernelWrapper.Test/Creators/FailureMechanismSectionAssemblyCreatorTest.cs
2:52 pm

Carlos Lubbers

Cleanup WTI-1670

Options
    • -8
    • +13
    /Ringtoets/AssemblyTool/src/Ringtoets.AssemblyTool.KernelWrapper/Calculators/Assembly/FailureMechanismSectionAssemblyCalculator.cs
    • -6
    • +9
    /Ringtoets/AssemblyTool/src/Ringtoets.AssemblyTool.KernelWrapper/Creators/FailureMechanismSectionAssemblyCalculatorInputCreator.cs
    • -131
    • +22
    /Ringtoets/AssemblyTool/test/Ringtoets.AssemblyTool.KernelWrapper.Test/Calculators/Assembly/FailureMechanismSectionAssemblyCalculatorTest.cs
    • -129
    • +50
    /Ringtoets/AssemblyTool/test/Ringtoets.AssemblyTool.KernelWrapper.Test/Creators/FailureMechanismSectionAssemblyCalculatorInputCreatorTest.cs
2:13 pm

Carlos Lubbers

Improve output of the combined assembly calculator methods. When the simple assessment is NVT, the final result should *always* be NVT WTI-1670

Options
    • -1
    • +13
    /Ringtoets/AssemblyTool/src/Ringtoets.AssemblyTool.KernelWrapper/Calculators/Assembly/FailureMechanismSectionAssemblyCalculator.cs
    • -0
    • +54
    /Ringtoets/AssemblyTool/test/Ringtoets.AssemblyTool.KernelWrapper.Test/Calculators/Assembly/FailureMechanismSectionAssemblyCalculatorTest.cs
1:42 pm

Carlos Lubbers

Cleanup WTI-1670

Options
    • -2
    • +2
    /Ringtoets/AssemblyTool/test/Ringtoets.AssemblyTool.KernelWrapper.Test/Creators/AssemblyCategoryCreatorTest.cs
1:42 pm

Carlos Lubbers

Reduce amount of exceptions thrown by kernel. When a probability option is selected but a NaN value is found, send None/Gr to the kernel. WTI-1670

Options
    • -5
    • +15
    /Ringtoets/AssemblyTool/src/Ringtoets.AssemblyTool.KernelWrapper/Calculators/Assembly/FailureMechanismSectionAssemblyCalculator.cs
    • -24
    • +173
    /Ringtoets/AssemblyTool/test/Ringtoets.AssemblyTool.KernelWrapper.Test/Calculators/Assembly/FailureMechanismSectionAssemblyCalculatorTest.cs
1:35 pm

Dennis Tang <dennis.tang@deltares.nl>

Incorporated comments review 2690: - Cleaned up tests: Separated CreateFailureMechanism function into a function that configures a failuremechanism with HydraulicBoundaryLocationOutput

WTI-1569

Options
    • -21
    • +109
    /Ringtoets/GrassCoverErosionOutwards/test/Ringtoets.GrassCoverErosionOutwards.Integration.Test/GrassCoverErosionOutwardsWaveConditionsCalculationActivityIntegrationTest.cs
    • -21
    • +53
    /Ringtoets/GrassCoverErosionOutwards/test/Ringtoets.GrassCoverErosionOutwards.Plugin.Test/TreeNodeInfos/GrassCoverErosionOutwardsWaveConditionsCalculationContextTreeNodeInfoTest.cs
    • -18
    • +50
    /Ringtoets/GrassCoverErosionOutwards/test/Ringtoets.GrassCoverErosionOutwards.Plugin.Test/TreeNodeInfos/GrassCoverErosionOutwardsWaveConditionsCalculationGroupContextTreeNodeInfoTest.cs
    • -23
    • +99
    /Ringtoets/GrassCoverErosionOutwards/test/Ringtoets.GrassCoverErosionOutwards.Service.Test/GrassCoverErosionOutwardsWaveConditionsCalculationServiceTest.cs