Wflow

Clone Tools
  • last updated a few seconds ago
Constraints
Constraints: committers
 
Constraints: files
Constraints: dates
some more black formatting

use fixed alpha and reformat code (black) a dynamic alpha value for the kinematic wave can result in significant water balance errors, a fixed value resolves this.

    • -5
    • +5
    /wflow/pcrglobwb/parameterSoilAndTopo.py
  1. … 29 more files in changeset.
fix notebook wflow-sbm-test

    • -3705
    • +454
    /notebooks/wflow-test-sbm.ipynb
Merge pull request #50 from openstreams/glacier_params

Fix conversion of time-dependent glacier parameters and HBV time dependent parameters

Fix HBV time dependent model parameters

Fix conversion of time-dependent glacier parameters These parameters (G_SIfrac and Cfmax) are now converted (using the actual model timestep).

fixed test netcdf testbmirunnetcdf and testapirun_netcfd did fail (OSError: [Errno -51] NetCDF: Unknown file format: staticoutmaps.nc)

wflow_sbm initial multiply parameters self.wf_multparameters() function now called just after reading wflow model parameters. Dependent model parameters can not be changed during initialization.

fix wflow_prepare.ipynb

    • binary
    /notebooks/wflow_gauges.map
    • -134
    • +263
    /notebooks/wflow_prepare.ipynb
Merge pull request #47 from openstreams/delwaq

Update wflow_delwaq script

Update wflow_delwaq script

update readme and docs refer to new developments in Wflow.jl

update readme and docs refer to new developments in Wflow.jl

update readme and docs refer to new developments in Wflow.jl

update readme and docs refer to new developments in Wflow.jl

fix issue #45

fix issue #45

Merge pull request #44 from openstreams/fix_massbal_kinwave

fix issue #43

fix issue #43 for the mass balance calculation the water level at sub timestep (iteration kinematic wave) should be used

Bugfix #39

PyInstaller needs the bin

area calculation wflow_hbv replaced self.reallength with self.xl and self.yl for cell area calculations, for lat lon this is more precise.

area calculation wflow_hbv replaced self.reallength with self.xl and self.yl for cell area calculations, for lat lon this is more precise.

Merge pull request #40 from openstreams/fix_glaciermelt

fix glacier melt issue

fix glacier melt issue glacier melt can contain missing values, because input parameters can have missing values. this works through in the infiltration (rainfall + melt). to avoid missing values pcr.cover(self.GlacierMelt,0.0) is now used.

caught exception in estimate_iterations_kin_wave when all map values are zero.

caught exception in estimate_iterations_kin_wave when all map values are zero.

changed self.reallength to self.xl and self.yl done in most part of the code for more accurate - area calculation of grid cells - conversion between mm and m3/s

estimate kinematic wave iterations revert back to previous estimate_iterations_kin_wave (zero discharge values for celerity calculation are not included)

Kinematic wave (sub timestep)

- Running the kinematic wave (overland flow and river flow) at sub-timestep (iterations) resulted in a too smoothed/delayed discharge pattern.

- Now states at sub-timestep are used for wflow_hbv and wflow_sbm. This improves the discharge pattern.

- Note 1: this change affects the simulated discharge (timing and peaks) quite a bit (compared to previous code versions).

- Note 2: state files have also changed, recommmend to start with cold state start (reinit=1)

    • binary
    /examples/wflow_rhine_sbm/instate/LandRunoffsub.map
    • binary
    /examples/wflow_rhine_sbm/instate/RiverRunoff.map
    • binary
    /examples/wflow_rhine_sbm/instate/RiverRunoffsub.map
    • binary
    /examples/wflow_rhine_sbm/instate/SubsurfaceFlow.map
    • binary
    /examples/wflow_rhine_sbm/instate/WaterLevel.map
    • binary
    /examples/wflow_rhine_sbm/instate/WaterLevelL.map
    • binary
    /examples/wflow_rhine_sbm/instate/WaterLevelLsub.map
    • binary
    /examples/wflow_rhine_sbm/instate/WaterLevelR.map
    • binary
    /examples/wflow_rhine_sbm/instate/WaterLevelRsub.map