Fisheye on Riskeer/

Riskeer (feature/2953_param_c_in_asphalt_adjustable): changes after 2nd review

Edwin Spee — Mon, 20 Apr 2026 14:37:35 +0200

Edwin Spee committed 2ee8ee4 on branch feature/2953_param_c_in_asphalt_adjustable in Riskeer

changes after 2nd review

· /Riskeer/WaveImpactAsphaltCover/.../WaveImpactAsphaltCoverFailureMechanismContextTest.cs	(-79, +0)	\| History	\| Source	\| Diff
· /Riskeer/WaveImpactAsphaltCover/.../WaveImpactAsphaltCoverFailureMechanismPropertiesTest.cs	(-9, +82)	\| History	\| Source	\| Diff

Riskeer (feature/2953_param_c_in_asphalt_adjustable): add extra tests in PresentationObjects

Edwin Spee — Fri, 17 Apr 2026 13:49:26 +0200

Edwin Spee committed 9f9d6e5 on branch feature/2953_param_c_in_asphalt_adjustable in Riskeer

add extra tests in PresentationObjects

· /Riskeer/WaveImpactAsphaltCover/.../WaveImpactAsphaltCoverFailureMechanismContextTest.cs

(-1, +80)

| History

| Source

| Diff

Riskeer (feature/2953_param_c_in_asphalt_adjustable): update expected string

Edwin Spee — Fri, 17 Apr 2026 11:58:44 +0200

Edwin Spee committed 85d38da on branch feature/2953_param_c_in_asphalt_adjustable in Riskeer

update expected string

· /Riskeer/WaveImpactAsphaltCover/.../GeneralWaveImpactAsphaltCoverWaveConditionsInputTest.cs

(-1, +1)

| History

| Source

| Diff

Riskeer (feature/2953_param_c_in_asphalt_adjustable): reformatting

Edwin Spee — Fri, 17 Apr 2026 11:55:04 +0200

Edwin Spee committed c19af08 on branch feature/2953_param_c_in_asphalt_adjustable in Riskeer

reformatting

· /Riskeer/WaveImpactAsphaltCover/.../GeneralWaveImpactAsphaltCoverWaveConditionsInput.cs	(-5, +6)	\| History	\| Source	\| Diff
· /Riskeer/WaveImpactAsphaltCover/.../WaveImpactAsphaltCoverFailureMechanismProperties.cs	(-1, +0)	\| History	\| Source	\| Diff
· /Riskeer/WaveImpactAsphaltCover/.../GeneralWaveImpactAsphaltCoverWaveConditionsInputTest.cs	(-2, +1)	\| History	\| Source	\| Diff

Riskeer (feature/2953_param_c_in_asphalt_adjustable): more review comments

Edwin Spee — Fri, 17 Apr 2026 11:51:21 +0200

Edwin Spee committed 9986e3e on branch feature/2953_param_c_in_asphalt_adjustable in Riskeer

more review comments

· /Riskeer/Piping/src/Riskeer.Piping.Data/Properties/Resources.Designer.cs	(-1, +22)	\| History	\| Source	\| Diff
· /Riskeer/WaveImpactAsphaltCover/.../GeneralWaveImpactAsphaltCoverWaveConditionsInput.cs	(-11, +12)	\| History	\| Source	\| Diff
· /Riskeer/WaveImpactAsphaltCover/src/.../Properties/Resources.Designer.cs	(-12, +33)	\| History	\| Source	\| Diff
· /Riskeer/WaveImpactAsphaltCover/.../GeneralWaveImpactAsphaltCoverWaveConditionsInputTest.cs	(-4, +4)	\| History	\| Source	\| Diff

Riskeer (feature/2953_param_c_in_asphalt_adjustable): Apply suggestions from code review...

Fri, 17 Apr 2026 11:27:05 +0200

Edwin Spee <34799234+epsig@users.noreply.github.com> committed c0bc188 on branch feature/2953_param_c_in_asphalt_adjustable in Riskeer

Apply suggestions from code review

Co-authored-by: Elmar Kleijn <34710209+kleijn@users.noreply.github.com>

· /Riskeer/Piping/src/Riskeer.Piping.Data/Properties/Resources.resx	(-1, +1)	\| History	\| Source	\| Diff
· /Riskeer/Piping/test/Riskeer.Piping.Data.Test/GeneralPipingInputTest.cs	(-1, +1)	\| History	\| Source	\| Diff
· /Riskeer/Piping/test/.../PropertyClasses/CalculationsState/PipingFailureMechanismPropertiesTest.cs	(-1, +1)	\| History	\| Source	\| Diff
· /Riskeer/WaveImpactAsphaltCover/.../GeneralWaveImpactAsphaltCoverWaveConditionsInput.cs	(-2, +2)	\| History	\| Source	\| Diff
· /Riskeer/WaveImpactAsphaltCover/src/Riskeer.WaveImpactAsphaltCover.Data/Properties/Resources.resx	(-1, +1)	\| History	\| Source	\| Diff
· /Riskeer/WaveImpactAsphaltCover/.../GeneralWaveImpactAsphaltCoverWaveConditionsInputTest.cs	(-12, +20)	\| History	\| Source	\| Diff

Riskeer (feature/2953_param_c_in_asphalt_adjustable): add test for invalid values of param C

Edwin Spee — Tue, 14 Apr 2026 15:20:51 +0200

Edwin Spee committed e16cb69 on branch feature/2953_param_c_in_asphalt_adjustable in Riskeer

add test for invalid values of param C

· /Riskeer/WaveImpactAsphaltCover/src/.../Properties/Resources.Designer.cs	(-1, +1)	\| History	\| Source	\| Diff
· /Riskeer/WaveImpactAsphaltCover/src/Riskeer.WaveImpactAsphaltCover.Data/Properties/Resources.resx	(-1, +1)	\| History	\| Source	\| Diff
· /Riskeer/WaveImpactAsphaltCover/.../GeneralWaveImpactAsphaltCoverWaveConditionsInputTest.cs	(-0, +20)	\| History	\| Source	\| Diff

Riskeer (feature/2953_param_c_in_asphalt_adjustable): move validation for param C to data...

Edwin Spee — Tue, 14 Apr 2026 14:48:31 +0200

Edwin Spee committed ea96684 on branch feature/2953_param_c_in_asphalt_adjustable in Riskeer

move validation for param C to data

improve error message for param volume of water in piping

· /Riskeer/Piping/src/Riskeer.Piping.Data/Properties/Resources.Designer.cs	(-26, +4)	\| History	\| Source	\| Diff
· /Riskeer/Piping/src/Riskeer.Piping.Data/Properties/Resources.resx	(-28, +28)	\| History	\| Source	\| Diff
· /Riskeer/Piping/test/Riskeer.Piping.Data.Test/GeneralPipingInputTest.cs	(-2, +2)	\| History	\| Source	\| Diff
· /Riskeer/Piping/test/.../PropertyClasses/CalculationsState/PipingFailureMechanismPropertiesTest.cs	(-4, +4)	\| History	\| Source	\| Diff
· /Riskeer/WaveImpactAsphaltCover/.../GeneralWaveImpactAsphaltCoverWaveConditionsInput.cs	(-4, +31)	\| History	\| Source	\| Diff
· /Riskeer/WaveImpactAsphaltCover/src/.../Properties/Resources.Designer.cs	(-23, +10)	\| History	\| Source	\| Diff
· /Riskeer/WaveImpactAsphaltCover/src/Riskeer.WaveImpactAsphaltCover.Data/Properties/Resources.resx	(-27, +30)	\| History	\| Source	\| Diff
· /Riskeer/WaveImpactAsphaltCover/.../WaveImpactAsphaltCoverFailureMechanismProperties.cs	(-15, +1)	\| History	\| Source	\| Diff

Riskeer (feature/2953_param_c_in_asphalt_adjustable): add propertyChangeHandler to WaveImpactAsphaltCoverFailureMechanismProperties

Edwin Spee — Fri, 10 Apr 2026 17:08:44 +0200

Edwin Spee committed 4b4b8a9 on branch feature/2953_param_c_in_asphalt_adjustable in Riskeer

add propertyChangeHandler to WaveImpactAsphaltCoverFailureMechanismProperties

· /Riskeer/WaveImpactAsphaltCover/.../WaveImpactAsphaltCoverFailureMechanismProperties.cs	(-4, +32)	\| History	\| Source	\| Diff
· /Riskeer/WaveImpactAsphaltCover/.../Riskeer.WaveImpactAsphaltCover.Plugin/WaveImpactAsphaltCoverPlugin.cs	(-2, +2)	\| History	\| Source	\| Diff
· /Riskeer/WaveImpactAsphaltCover/.../WaveImpactAsphaltCoverFailureMechanismPropertiesTest.cs	(-3, +4)	\| History	\| Source	\| Diff

Riskeer (feature/2953_param_c_in_asphalt_adjustable): add unit tests

Edwin Spee — Fri, 10 Apr 2026 14:07:31 +0200

Edwin Spee committed 6ba841e on branch feature/2953_param_c_in_asphalt_adjustable in Riskeer

add unit tests

· /Riskeer/WaveImpactAsphaltCover/.../GeneralWaveImpactAsphaltCoverWaveConditionsInputTest.cs	(-0, +56)	\| History	\| Source
· /Riskeer/WaveImpactAsphaltCover/.../WaveImpactAsphaltCoverFailureMechanismPropertiesTest.cs	(-1, +18)	\| History	\| Source	\| Diff

Riskeer (feature/2953_param_c_in_asphalt_adjustable): fix failing test

Edwin Spee — Fri, 10 Apr 2026 13:19:05 +0200

Edwin Spee committed d3914e9 on branch feature/2953_param_c_in_asphalt_adjustable in Riskeer

fix failing test

· /Riskeer/WaveImpactAsphaltCover/.../WaveImpactAsphaltCoverFailureMechanismPropertiesTest.cs

(-1, +1)

| History

| Source

| Diff

Riskeer (feature/2953_param_c_in_asphalt_adjustable): simply constructor

Edwin Spee — Fri, 10 Apr 2026 13:14:33 +0200

Edwin Spee committed 7ff7777 on branch feature/2953_param_c_in_asphalt_adjustable in Riskeer

simply constructor

· /Riskeer/WaveImpactAsphaltCover/.../GeneralWaveImpactAsphaltCoverWaveConditionsInput.cs	(-11, +8)	\| History	\| Source	\| Diff
· /Riskeer/WaveImpactAsphaltCover/.../WaveImpactAsphaltCoverFailureMechanism.cs	(-1, +1)	\| History	\| Source	\| Diff

Riskeer (feature/2953_param_c_in_asphalt_adjustable): only update C if in valid range

Edwin Spee — Fri, 10 Apr 2026 11:55:09 +0200

Edwin Spee committed db6e1ed on branch feature/2953_param_c_in_asphalt_adjustable in Riskeer

only update C if in valid range

· /Riskeer/WaveImpactAsphaltCover/.../WaveImpactAsphaltCoverFailureMechanismProperties.cs

(-1, +15)

| History

| Source

| Diff

Riskeer (feature/2953_param_c_in_asphalt_adjustable): setter in param C only for asphalt

Edwin Spee — Fri, 10 Apr 2026 09:23:24 +0200

Edwin Spee committed 0f2a9f1 on branch feature/2953_param_c_in_asphalt_adjustable in Riskeer

setter in param C only for asphalt

· /Riskeer/Revetment/src/Riskeer.Revetment.Data/GeneralWaveConditionsInput.cs	(-1, +1)	\| History	\| Source	\| Diff
· /Riskeer/WaveImpactAsphaltCover/.../GeneralWaveImpactAsphaltCoverWaveConditionsInput.cs	(-0, +59)	\| History	\| Source
· /Riskeer/WaveImpactAsphaltCover/.../WaveImpactAsphaltCoverFailureMechanism.cs	(-4, +3)	\| History	\| Source	\| Diff
· /Riskeer/WaveImpactAsphaltCover/.../WaveImpactAsphaltCoverWaveConditionsCalculationService.cs	(-6, +6)	\| History	\| Source	\| Diff
· /Riskeer/WaveImpactAsphaltCover/.../WaveImpactAsphaltCoverFailureMechanismPropertiesTest.cs	(-2, +2)	\| History	\| Source	\| Diff
· /Riskeer/.../WaveImpactAsphaltCoverWaveConditionsCalculationActivityIntegrationTest.cs	(-2, +2)	\| History	\| Source	\| Diff
· /Riskeer/WaveImpactAsphaltCover/.../WaveImpactAsphaltCoverWaveConditionsCalculationServiceTest.cs	(-2, +2)	\| History	\| Source	\| Diff

Riskeer (feature/2953_param_c_in_asphalt_adjustable): add setters for param C

Edwin Spee — Fri, 10 Apr 2026 08:53:32 +0200

Edwin Spee committed c56dddb on branch feature/2953_param_c_in_asphalt_adjustable in Riskeer

add setters for param C

· /Riskeer/Revetment/src/Riskeer.Revetment.Data/GeneralWaveConditionsInput.cs	(-2, +2)	\| History	\| Source	\| Diff
· /Riskeer/WaveImpactAsphaltCover/.../WaveImpactAsphaltCoverFailureMechanismProperties.cs	(-1, +5)	\| History	\| Source	\| Diff

Riskeer (feature/2953_param_c_in_asphalt_adjustable): Added new version of RSPstelsel. WTI-2955

Elmar Kleijn — Wed, 08 Apr 2026 09:21:58 +0200

Elmar Kleijn committed 03f4b08 on branch master, feature/15-add-parameter-c-to-storage and 4 more in Riskeer

Added new version of RSPstelsel. WTI-2955

· /Riskeer/DuneErosion/src/Riskeer.DuneErosion.IO/EmbeddedResources/RSPstelsel.dbf	(binary)	\| History	\| Source	\| Diff
· /Riskeer/DuneErosion/src/Riskeer.DuneErosion.IO/EmbeddedResources/RSPstelsel.prj	(-1, +1)	\| History	\| Source	\| Diff
· /Riskeer/DuneErosion/src/Riskeer.DuneErosion.IO/EmbeddedResources/RSPstelsel.shp	(binary)	\| History	\| Source	\| Diff

Riskeer (task/net10-upgrade): Match with dune locations based on name. WTI-2955

Elmar Kleijn — Thu, 26 Mar 2026 14:14:44 +0100

Elmar Kleijn committed ee1d321 on branch master, feature/15-add-parameter-c-to-storage and 5 more in Riskeer

Match with dune locations based on name. WTI-2955

· /Riskeer/DuneErosion/src/Riskeer.DuneErosion.Service/DuneErosionDataSynchronizationService.cs

(-1, +1)

| History

| Source

| Diff

Riskeer (task/net10-upgrade): Ensured offset is correctly rounded. WTI-2955

Elmar Kleijn — Thu, 26 Mar 2026 14:07:46 +0100

Elmar Kleijn committed 5583bf4 on branch master, feature/15-add-parameter-c-to-storage and 5 more in Riskeer

Ensured offset is correctly rounded. WTI-2955

· /Riskeer/DuneErosion/src/Riskeer.DuneErosion.Service/DuneErosionDataSynchronizationService.cs	(-1, +1)	\| History	\| Source	\| Diff
· /Riskeer/DuneErosion/.../Riskeer.DuneErosion.Service.Test/DuneErosionDataSynchronizationServiceTest.cs	(-1, +1)	\| History	\| Source	\| Diff

Riskeer (task/net10-upgrade): Turning offset in ReadDuneLocation into integer. WTI-2955

Elmar Kleijn — Thu, 26 Mar 2026 13:46:32 +0100

Elmar Kleijn committed 0a684fc on branch master, feature/15-add-parameter-c-to-storage and 5 more in Riskeer

Turning offset in ReadDuneLocation into integer. WTI-2955

· /Riskeer/DuneErosion/test/Riskeer.DuneErosion.IO.Test/DuneLocationsReaderTest.cs

(-9, +15)

| History

| Source

| Diff

Riskeer (task/net10-upgrade): Turning offset in ReadDuneLocation into integer. WTI-2955

Elmar Kleijn — Thu, 26 Mar 2026 13:08:00 +0100

Elmar Kleijn committed d6acc93 on branch master, feature/15-add-parameter-c-to-storage and 5 more in Riskeer

Turning offset in ReadDuneLocation into integer. WTI-2955

· /Riskeer/DuneErosion/.../Riskeer.DuneErosion.Service.Test/DuneErosionDataSynchronizationServiceTest.cs

(-1, +1)

| History

| Source

| Diff

Riskeer (task/net10-upgrade): Turning offset in ReadDuneLocation into integer. WTI-2955

Elmar Kleijn — Thu, 26 Mar 2026 13:07:22 +0100

Elmar Kleijn committed 743c2df on branch master, feature/15-add-parameter-c-to-storage and 5 more in Riskeer

Turning offset in ReadDuneLocation into integer. WTI-2955

· /Riskeer/DuneErosion/src/Riskeer.DuneErosion.IO/DuneLocationsReader.cs

(-2, +2)

| History

| Source

| Diff

Riskeer (task/net10-upgrade): Turning offset in ReadDuneLocation into integer. WTI-2955

Elmar Kleijn — Thu, 26 Mar 2026 13:06:11 +0100

Elmar Kleijn committed 5a31399 on branch master, feature/15-add-parameter-c-to-storage and 5 more in Riskeer

Turning offset in ReadDuneLocation into integer. WTI-2955

· /Riskeer/DuneErosion/src/Riskeer.DuneErosion.IO/ReadDuneLocation.cs	(-8, +3)	\| History	\| Source	\| Diff
· /Riskeer/DuneErosion/test/Riskeer.DuneErosion.IO.Test/ReadDuneLocationTest.cs	(-0, +11)	\| History	\| Source	\| Diff

Riskeer (task/net10-upgrade): Turning offset in ReadDuneLocation into integer. WTI-2955

Elmar Kleijn — Thu, 26 Mar 2026 13:03:36 +0100

Elmar Kleijn committed e066264 on branch master, feature/15-add-parameter-c-to-storage and 5 more in Riskeer

Turning offset in ReadDuneLocation into integer. WTI-2955

· /Riskeer/DuneErosion/src/Riskeer.DuneErosion.IO/ReadDuneLocation.cs	(-4, +3)	\| History	\| Source	\| Diff
· /Riskeer/DuneErosion/test/Riskeer.DuneErosion.IO.Test/ReadDuneLocationTest.cs	(-15, +3)	\| History	\| Source	\| Diff

Riskeer (task/net10-upgrade): Adding units to summaries. WTI-2955

Elmar Kleijn — Thu, 26 Mar 2026 12:58:02 +0100

Elmar Kleijn committed 4fdb715 on branch master, feature/15-add-parameter-c-to-storage and 5 more in Riskeer

Adding units to summaries. WTI-2955

· /Riskeer/DuneErosion/src/Riskeer.DuneErosion.Data/DuneLocation.cs	(-0, +2)	\| History	\| Source	\| Diff
· /Riskeer/DuneErosion/src/Riskeer.DuneErosion.IO/ReadDuneLocation.cs	(-0, +1)	\| History	\| Source	\| Diff

Riskeer (task/net10-upgrade): Match with dune locations based on name. WTI-2955

Elmar Kleijn — Thu, 26 Mar 2026 12:13:37 +0100

Elmar Kleijn committed 02829c4 on branch master, feature/15-add-parameter-c-to-storage and 5 more in Riskeer

Match with dune locations based on name. WTI-2955

· /Riskeer/DuneErosion/src/Riskeer.DuneErosion.Service/DuneErosionDataSynchronizationService.cs	(-24, +25)	\| History	\| Source	\| Diff
· /Riskeer/DuneErosion/.../Riskeer.DuneErosion.Service.Test/DuneErosionDataSynchronizationServiceTest.cs	(-2, +2)	\| History	\| Source	\| Diff

Riskeer (task/net10-upgrade): Match with dune locations based on name. WTI-2955

Elmar Kleijn — Thu, 26 Mar 2026 12:06:45 +0100

Elmar Kleijn committed 2f9d839 on branch master, feature/15-add-parameter-c-to-storage and 5 more in Riskeer

Match with dune locations based on name. WTI-2955

· /Riskeer/DuneErosion/src/Riskeer.DuneErosion.Service/DuneErosionDataSynchronizationService.cs

(-15, +14)

| History

| Source

| Diff

Riskeer (task/net10-upgrade): Match with dune locations based on name. WTI-2955

Elmar Kleijn — Thu, 26 Mar 2026 11:52:51 +0100

Elmar Kleijn committed f043860 on branch master, feature/15-add-parameter-c-to-storage and 5 more in Riskeer

Match with dune locations based on name. WTI-2955

· /Riskeer/DuneErosion/.../Riskeer.DuneErosion.Service.Test/DuneErosionDataSynchronizationServiceTest.cs

(-3, +3)

| History

| Source

| Diff

Riskeer (task/net10-upgrade): Match with dune locations based on name. WTI-2955

Elmar Kleijn — Thu, 26 Mar 2026 11:40:55 +0100

Elmar Kleijn committed 1cfa001 on branch master, feature/15-add-parameter-c-to-storage and 5 more in Riskeer

Match with dune locations based on name. WTI-2955

· /Riskeer/DuneErosion/.../Riskeer.DuneErosion.Service.Test/DuneErosionDataSynchronizationServiceTest.cs

(-24, +13)

| History

| Source

| Diff

Riskeer (task/net10-upgrade): Match with dune locations based on name. WTI-2955

Elmar Kleijn — Thu, 26 Mar 2026 11:19:15 +0100

Elmar Kleijn committed a7d48f9 on branch master, feature/15-add-parameter-c-to-storage and 5 more in Riskeer

Match with dune locations based on name. WTI-2955

· /Riskeer/DuneErosion/.../Riskeer.DuneErosion.Service.Test/DuneErosionDataSynchronizationServiceTest.cs

(-36, +0)

| History

| Source

| Diff

Riskeer (task/net10-upgrade): Match with dune locations based on name. WTI-2955

Elmar Kleijn — Thu, 26 Mar 2026 11:17:29 +0100

Elmar Kleijn committed dc15a08 on branch master, feature/15-add-parameter-c-to-storage and 5 more in Riskeer

Match with dune locations based on name. WTI-2955

· /Riskeer/DuneErosion/.../Riskeer.DuneErosion.Service.Test/DuneErosionDataSynchronizationServiceTest.cs

(-4, +7)

| History

| Source

| Diff