Fisheye on Riskeer/Ringtoets/MacroStabilityInwards/test/Ringtoets.MacroStabilityInwards.Data.TestUtil.Test/TestMacroStabilityInwardsOutputTest.cs

Riskeer (feature/23-connect-to-master-of-hydra-ring): Converted the TestMacroStabilityInwardsOutput test object to a test factory: - Created objects are to be used for assert...

Thu, 19 Oct 2017 16:49:20 +0200

Dennis Tang committed b2f4b30 on branch master, Release17_2 and 27 more in Riskeer

Converted the TestMacroStabilityInwardsOutput test object to a test factory: - Created objects are to be used for asserting composite objects that can clone. These asserts should be preferably done with the original object rather than a derived (test) object

Related to Issue [WTI-1366]

git-svn-id: https://repos.deltares.nl/repos/WettelijkToetsInstrumentarium/trunk@12260 5a3db67b-de53-47b5-99c8-a1c30a6650e2

Former-commit-id: 9692ca616baffd96345a37e0f605fc8573337e86

Former-commit-id: 9abe379937333a2a121c54329d4dc57ee5d128a3

· /Application/Ringtoets/.../MacroStabilityInwardsCalculationScenarioCreateExtensionsTest.cs

(-1, +1)

| History

| Source

| Diff

· /Application/Ringtoets/test/Application.Ringtoets.Storage.TestUtil/RingtoetsProjectTestHelper.cs

(-1, +1)

| History

| Source

| Diff

· /Ringtoets/MacroStabilityInwards/.../MacroStabilityInwardsCalculationScenarioTest.cs

(-4, +4)

| History

| Source

| Diff

· /Ringtoets/MacroStabilityInwards/.../MacroStabilityInwardsCalculationTest.cs

(-2, +2)

| History

| Source

| Diff

· /Ringtoets/MacroStabilityInwards/.../MacroStabilityInwardsOutputTestFactoryTest.cs

(-0, +78)

| History

| Source

· /Ringtoets/MacroStabilityInwards/.../Ringtoets.MacroStabilityInwards.Data.TestUtil.Test.csproj

(-1, +1)

| History

| Source

| Diff

· /Ringtoets/MacroStabilityInwards/.../TestMacroStabilityInwardsOutputTest.cs

(-73, +0)

| History

| Source

| Diff

· /Ringtoets/MacroStabilityInwards/.../MacroStabilityInwardsCalculationScenarioFactory.cs

(-1, +1)

| History

| Source

| Diff

· /Ringtoets/MacroStabilityInwards/.../MacroStabilityInwardsOutputTestFactory.cs

(-0, +59)

| History

| Source

· /Ringtoets/MacroStabilityInwards/.../MacroStabilityInwardsTestDataGenerator.cs

(-4, +4)

| History

| Source

| Diff

· /Ringtoets/MacroStabilityInwards/.../Ringtoets.MacroStabilityInwards.Data.TestUtil.csproj

(-1, +1)

| History

| Source

| Diff

· /Ringtoets/MacroStabilityInwards/.../TestMacroStabilityInwardsOutput.cs

(-54, +0)

| History

| Source

| Diff

· /Ringtoets/MacroStabilityInwards/test/.../Views/MacroStabilityInwardsCalculationRowTest.cs

(-2, +2)

| History

| Source

| Diff

· /Ringtoets/MacroStabilityInwards/test/.../Views/MacroStabilityInwardsCalculationsViewTest.cs

(-2, +2)

| History

| Source

| Diff

· /Ringtoets/MacroStabilityInwards/test/.../Views/MacroStabilityInwardsOutputViewTest.cs

(-4, +4)

| History

| Source

| Diff

… 17 more files in changeset.

Riskeer (feature/23-connect-to-master-of-hydra-ring): Incorporated comments review 2187 - Removed obsolete casts, or property initializers - Removed commented code - Replaced...

Tue, 10 Oct 2017 13:59:26 +0200

Dennis Tang committed 1d029d0 on branch master, Release17_2 and 27 more in Riskeer

Incorporated comments review 2187 - Removed obsolete casts, or property initializers - Removed commented code - Replaced calls with test output when possible

Paired with ~tangerma

Related to Issue [WTI-1407]

git-svn-id: https://repos.deltares.nl/repos/WettelijkToetsInstrumentarium/trunk@12084 5a3db67b-de53-47b5-99c8-a1c30a6650e2

Former-commit-id: 28ce6e16475d0c243dce430c5fc820edcd4c3660

Former-commit-id: 41eef66c47c7f0ea0c637b6d4d67dee801c5fe81

· /Ringtoets/MacroStabilityInwards/.../TestMacroStabilityInwardsOutputTest.cs	(-1, +2)	\| History	\| Source	\| Diff
· /Ringtoets/MacroStabilityInwards/.../MacroStabilityInwardsCalculationScenarioFactory.cs	(-2, +2)	\| History	\| Source	\| Diff
· /Ringtoets/MacroStabilityInwards/.../TestMacroStabilityInwardsOutput.cs	(-4, +1)	\| History	\| Source	\| Diff
· /Ringtoets/MacroStabilityInwards/.../PropertyClasses/MacroStabilityInwardsOutputContextPropertiesTest.cs	(-16, +4)	\| History	\| Source	\| Diff
· /Ringtoets/MacroStabilityInwards/test/.../Views/MacroStabilityInwardsScenariosViewTest.cs	(-1, +1)	\| History	\| Source	\| Diff
· /Ringtoets/MacroStabilityInwards/test/.../Calculators/UpliftVan/UpliftVanCalculatorTest.cs	(-1, +0)	\| History	\| Source	\| Diff

Riskeer (feature/23-connect-to-master-of-hydra-ring): Applied review comments. Related to Issue [WTI-1407]...

Mon, 09 Oct 2017 15:10:16 +0200

Robert Tangerman committed 0f736d8 on branch master, Release17_2 and 27 more in Riskeer

Applied review comments. Related to Issue [WTI-1407]

git-svn-id: https://repos.deltares.nl/repos/WettelijkToetsInstrumentarium/trunk@12063 5a3db67b-de53-47b5-99c8-a1c30a6650e2

Former-commit-id: e7a0ef4c0508b7a0340c39c16a738cf630f003e1

Former-commit-id: 3c8d58abb4de0b7ccb3d339f850e7531fd50a1d9

· /Ringtoets/Common/test/Ringtoets.Common.Service.Test/CalculationServiceHelperTest.cs

(-2, +3)

| History

| Source

| Diff

· /Ringtoets/MacroStabilityInwards/.../MacroStabilityInwardsLocationInputDaily.cs

(-0, +5)

| History

| Source

| Diff

· /Ringtoets/MacroStabilityInwards/.../Ringtoets.MacroStabilityInwards.Data/MacroStabilityInwardsSlice.cs

(-3, +3)

| History

| Source

| Diff

· /Ringtoets/MacroStabilityInwards/.../MacroStabilityInwardsSlidingCircle.cs

(-1, +2)

| History

| Source

| Diff

· /Ringtoets/MacroStabilityInwards/.../MacroStabilityInwardsSlidingCurve.cs

(-2, +2)

| History

| Source

| Diff

· /Ringtoets/MacroStabilityInwards/.../MacroStabilityInwardsSlipPlaneUpliftVan.cs

(-1, +1)

| History

| Source

| Diff

· /Ringtoets/MacroStabilityInwards/src/.../Calculators/UpliftVan/IUpliftVanCalculator.cs

(-1, +1)

| History

| Source

| Diff

· /Ringtoets/MacroStabilityInwards/src/.../UpliftVan/Output/UpliftVanSlidingCircleResult.cs

(-0, +1)

| History

| Source

| Diff

· /Ringtoets/MacroStabilityInwards/src/.../UpliftVan/Output/UpliftVanSlidingCurveResult.cs

(-2, +2)

| History

| Source

| Diff

· /Ringtoets/MacroStabilityInwards/src/.../Calculators/UpliftVan/UpliftVanCalculator.cs

(-1, +1)

| History

| Source

| Diff

· /Ringtoets/MacroStabilityInwards/src/.../Calculators/UpliftVan/UpliftVanCalculatorException.cs

(-1, +1)

| History

| Source

| Diff

· /Ringtoets/MacroStabilityInwards/src/.../Kernels/UpliftVan/IUpliftVanKernel.cs

(-1, +1)

| History

| Source

| Diff

· /Ringtoets/MacroStabilityInwards/src/.../Kernels/UpliftVan/UpliftVanKernelWrapper.cs

(-0, +6)

| History

| Source

| Diff

· /Ringtoets/MacroStabilityInwards/src/.../Kernels/UpliftVan/UpliftVanKernelWrapperException.cs

(-1, +1)

| History

| Source

| Diff

· /Ringtoets/MacroStabilityInwards/src/.../Converters/MacroStabilityInwardsSlipPlaneUpliftVanConverter.cs

(-1, +1)

| History

| Source

| Diff

… 15 more files in changeset.