Index: DamClients/DamUI/trunk/src/DamClientsLibrary/Deltares.Dam.Data.Tests/Registry/RegistryReaderTests.cs =================================================================== diff -u -r6921 -r6937 --- DamClients/DamUI/trunk/src/DamClientsLibrary/Deltares.Dam.Data.Tests/Registry/RegistryReaderTests.cs (.../RegistryReaderTests.cs) (revision 6921) +++ DamClients/DamUI/trunk/src/DamClientsLibrary/Deltares.Dam.Data.Tests/Registry/RegistryReaderTests.cs (.../RegistryReaderTests.cs) (revision 6937) @@ -71,16 +71,5 @@ Assert.That(actualValue, Is.EqualTo(string.Empty)); } - [Test] - public void GetRegistryValue_ReturnsStringRepresentation_WhenValueIsNotString() - { - using (RegistryKey key = Microsoft.Win32.Registry.CurrentUser.OpenSubKey(keyPath, true)) - { - key!.SetValue("VersionValue", "7.8.0.0", RegistryValueKind.String); - } - - string actualValue = RegistryReader.GetRegistryValueFromCurrentUser(keyPath, "VersionValue"); - Assert.That(actualValue, Is.EqualTo("7.8.0.0")); - } } } \ No newline at end of file Index: DamClients/DamUI/trunk/src/DamClientsLibrary/Deltares.Dam.Data.Tests/Version/VersionComparerTests.cs =================================================================== diff -u -r6903 -r6937 --- DamClients/DamUI/trunk/src/DamClientsLibrary/Deltares.Dam.Data.Tests/Version/VersionComparerTests.cs (.../VersionComparerTests.cs) (revision 6903) +++ DamClients/DamUI/trunk/src/DamClientsLibrary/Deltares.Dam.Data.Tests/Version/VersionComparerTests.cs (.../VersionComparerTests.cs) (revision 6937) @@ -47,12 +47,18 @@ } [Test] - public void IsVersionGreaterOrEqual_ReturnsTrue_WhenCurrentHasFewerSegmentsButIsEqual() + public void IsVersionGreaterOrEqual_ReturnsFalse_WhenCurrentHasFewerSegmentsButIsEqual() { Assert.That(VersionComparer.IsVersionGreaterOrEqual("7.8.1", "7.8.1.0"), Is.False); } [Test] + public void IsVersionGreaterOrEqual_ReturnsTrue_WhenCurrentHasFewerSegmentsButLarger() + { + Assert.That(VersionComparer.IsVersionGreaterOrEqual("7.8.1", "7.8.0.1"), Is.True); + } + + [Test] public void IsVersionGreaterOrEqual_ThrowsFormatException_WhenVersionIsInvalid() { Assert.Throws(() => VersionComparer.IsVersionGreaterOrEqual("invalid", "7.8.0.0")); Index: DamClients/DamUI/trunk/src/DamClientsLibrary/Deltares.Dam.Data/Version/VersionComparer.cs =================================================================== diff -u -r6903 -r6937 --- DamClients/DamUI/trunk/src/DamClientsLibrary/Deltares.Dam.Data/Version/VersionComparer.cs (.../VersionComparer.cs) (revision 6903) +++ DamClients/DamUI/trunk/src/DamClientsLibrary/Deltares.Dam.Data/Version/VersionComparer.cs (.../VersionComparer.cs) (revision 6937) @@ -34,6 +34,6 @@ var current = new System.Version(currentVersion); var required = new System.Version(requiredVersion); - return current >= required; + return current.CompareTo(required) >= 0; } } \ No newline at end of file