Index: Application/Ringtoets/test/Application.Ringtoets.Migration.Test/RingtoetsUpgradeScriptTest.cs =================================================================== diff -u -r1fe151fcfd0dce8fa2c1d93243cae90eee991e70 -r9487e717f5c13a44bdf7bc60cfa7fccb9a3fd84a --- Application/Ringtoets/test/Application.Ringtoets.Migration.Test/RingtoetsUpgradeScriptTest.cs (.../RingtoetsUpgradeScriptTest.cs) (revision 1fe151fcfd0dce8fa2c1d93243cae90eee991e70) +++ Application/Ringtoets/test/Application.Ringtoets.Migration.Test/RingtoetsUpgradeScriptTest.cs (.../RingtoetsUpgradeScriptTest.cs) (revision 9487e717f5c13a44bdf7bc60cfa7fccb9a3fd84a) @@ -36,8 +36,7 @@ [Test] [TestCase("")] [TestCase(null)] - [TestCase("4")] - public void Constructor_InvalidFromVersion_ThrowsArgumentException(string fromVersion) + public void Constructor_FromVersionOrEmpty_ThrowsArgumentException(string fromVersion) { // Setup const string query = "Valid query"; @@ -54,8 +53,7 @@ [Test] [TestCase("")] [TestCase(null)] - [TestCase("4")] - public void Constructor_InvalidToVersion_ThrowsArgumentException(string toVersion) + public void Constructor_ToVersionOrEmpty_ThrowsArgumentException(string toVersion) { // Setup string fromVersion = RingtoetsVersionHelper.GetCurrentDatabaseVersion(); @@ -70,6 +68,38 @@ } [Test] + [TestCase("4")] + public void Constructor_InvalidFromVersion_ThrowsArgumentException(string fromVersion) + { + // Setup + const string query = "Valid query"; + string toVersion = RingtoetsVersionHelper.GetCurrentDatabaseVersion(); + + // Call + TestDelegate call = () => new RingtoetsUpgradeScript(fromVersion, toVersion, query); + + // Assert + string expectedMessage = $@"'{fromVersion}' is geen geldige Ringtoets versie."; + TestHelper.AssertThrowsArgumentExceptionAndTestMessage(call, expectedMessage); + } + + [Test] + [TestCase("4")] + public void Constructor_InvalidToVersion_ThrowsArgumentException(string toVersion) + { + // Setup + string fromVersion = RingtoetsVersionHelper.GetCurrentDatabaseVersion(); + const string query = "Valid query"; + + // Call + TestDelegate call = () => new RingtoetsUpgradeScript(fromVersion, toVersion, query); + + // Assert + string expectedMessage = $@"'{toVersion}' is geen geldige Ringtoets versie."; + TestHelper.AssertThrowsArgumentExceptionAndTestMessage(call, expectedMessage); + } + + [Test] [TestCase("")] [TestCase(" ")] [TestCase(null)] @@ -144,7 +174,7 @@ // Assert Assert.IsTrue(File.Exists(filePath)); - using (new FileDisposeHelper(filePath)) { } + using (new FileDisposeHelper(filePath)) {} } } } \ No newline at end of file