Index: Ringtoets/ClosingStructures/test/Ringtoets.ClosingStructures.Plugin.Test/TreeNodeInfos/ClosingStructuresCalculationGroupContextTreeNodeInfoTest.cs =================================================================== diff -u -rf8c28b3b04cdabb62ea37772efcb1f4ebbbf2b9e -r52bce8b206b1c171b7590763a725271e9bd974a7 --- Ringtoets/ClosingStructures/test/Ringtoets.ClosingStructures.Plugin.Test/TreeNodeInfos/ClosingStructuresCalculationGroupContextTreeNodeInfoTest.cs (.../ClosingStructuresCalculationGroupContextTreeNodeInfoTest.cs) (revision f8c28b3b04cdabb62ea37772efcb1f4ebbbf2b9e) +++ Ringtoets/ClosingStructures/test/Ringtoets.ClosingStructures.Plugin.Test/TreeNodeInfos/ClosingStructuresCalculationGroupContextTreeNodeInfoTest.cs (.../ClosingStructuresCalculationGroupContextTreeNodeInfoTest.cs) (revision 52bce8b206b1c171b7590763a725271e9bd974a7) @@ -84,24 +84,6 @@ private MockRepository mocks; private ClosingStructuresPlugin plugin; - public override void Setup() - { - mocks = new MockRepository(); - gui = mocks.Stub(); - plugin = new ClosingStructuresPlugin - { - Gui = gui - }; - - info = plugin.GetTreeNodeInfos().First(tni => tni.TagType == typeof(ClosingStructuresCalculationGroupContext)); - } - - public override void TearDown() - { - plugin.Dispose(); - mocks.VerifyAll(); - } - [Test] public void Initialized_Always_ExpectedPropertiesSet() { @@ -238,6 +220,7 @@ // Call info.ContextMenuStrip(groupContext, null, treeViewControl); } + // Assert // Assert expectancies called in TearDown() } @@ -320,13 +303,13 @@ { new TestClosingStructure() }, "some path"); - var assessmentSection = mocks.Stub(); - assessmentSection.HydraulicBoundaryDatabase = new HydraulicBoundaryDatabase(); + IAssessmentSection assessmentSection = AssessmentSectionHelper.CreateAssessmentSectionStub(mocks); var groupContext = new ClosingStructuresCalculationGroupContext(group, null, failureMechanism, assessmentSection); var menuBuilder = new CustomItemsOnlyContextMenuBuilder(); + using (var treeViewControl = new TreeViewControl()) { gui.Stub(g => g.Get(groupContext, treeViewControl)).Return(menuBuilder); @@ -400,6 +383,7 @@ // Call info.ContextMenuStrip(groupContext, parentGroupContext, treeViewControl); } + // Assert // Assert expectancies called in TearDown() } @@ -475,7 +459,7 @@ } [Test] - public void ContextMenuStrip_NoHydraulicBoundaryDatabase_ContextMenuItemCalculateAllAndValidateAllDisabledAndTooltipSet() + public void ContextMenuStrip_HydraulicBoundaryDatabaseNotLinked_ContextMenuItemCalculateAllAndValidateAllDisabledAndTooltipSet() { // Setup var group = new CalculationGroup @@ -489,7 +473,7 @@ var failureMechanism = new TestClosingStructuresFailureMechanism(); failureMechanism.CalculationsGroup.Children.Add(new StructuresCalculation()); - var assessmentSection = mocks.Stub(); + IAssessmentSection assessmentSection = AssessmentSectionHelper.CreateAssessmentSectionStub(mocks); var nodeData = new ClosingStructuresCalculationGroupContext(group, null, @@ -525,7 +509,7 @@ } [Test] - public void ContextMenuStrip_HydraulicBoundaryDatabaseNotValid_ContextMenuItemCalculateAllAndValidateAllDisabledAndTooltipSet() + public void ContextMenuStrip_HydraulicBoundaryDatabaseLinkedToInvalidFile_ContextMenuItemCalculateAllAndValidateAllDisabledAndTooltipSet() { // Setup var group = new CalculationGroup @@ -539,8 +523,7 @@ var failureMechanism = new TestClosingStructuresFailureMechanism(); failureMechanism.CalculationsGroup.Children.Add(new StructuresCalculation()); - var assessmentSection = mocks.Stub(); - assessmentSection.HydraulicBoundaryDatabase = new HydraulicBoundaryDatabase(); + IAssessmentSection assessmentSection = AssessmentSectionHelper.CreateAssessmentSectionStub(null, mocks, "invalidFilePath"); var nodeData = new ClosingStructuresCalculationGroupContext(group, null, @@ -595,11 +578,11 @@ failureMechanism.CalculationsGroup.Children.Add(new StructuresCalculation()); var assessmentSection = mocks.Stub(); - assessmentSection.HydraulicBoundaryDatabase = new HydraulicBoundaryDatabase + assessmentSection.Stub(a => a.HydraulicBoundaryDatabase).Return(new HydraulicBoundaryDatabase { FilePath = validFilePath, Version = "1.0" - }; + }); var nodeData = new ClosingStructuresCalculationGroupContext(group, null, @@ -652,11 +635,11 @@ failureMechanism.CalculationsGroup.Children.Add(new StructuresCalculation()); var assessmentSection = mocks.Stub(); - assessmentSection.HydraulicBoundaryDatabase = new HydraulicBoundaryDatabase + assessmentSection.Stub(a => a.HydraulicBoundaryDatabase).Return(new HydraulicBoundaryDatabase { FilePath = validFilePath, Version = "1.0" - }; + }); var nodeData = new ClosingStructuresCalculationGroupContext(group, null, @@ -693,7 +676,7 @@ public void ContextMenuStrip_CalculationGroupWithCalculationWithForeshoreProfileAndInputOutOfSync_ContextMenuItemUpdateForeshoreProfilesEnabledAndToolTipSet() { // Setup - var assessmentSection = mocks.Stub(); + IAssessmentSection assessmentSection = AssessmentSectionHelper.CreateAssessmentSectionStub(mocks); var failureMechanism = new TestClosingStructuresFailureMechanism(); var calculation = new StructuresCalculation { @@ -746,7 +729,7 @@ var calculationInputObserver = mocks.StrictMock(); calculationInputObserver.Expect(o => o.UpdateObserver()); - var assessmentSection = mocks.Stub(); + IAssessmentSection assessmentSection = AssessmentSectionHelper.CreateAssessmentSectionStub(mocks); var failureMechanism = new TestClosingStructuresFailureMechanism(); var calculation = new StructuresCalculation @@ -820,15 +803,13 @@ string validFilePath = Path.Combine(testDataPath, "complete.sqlite"); - var hydraulicBoundaryDatabase = new HydraulicBoundaryDatabase - { - FilePath = validFilePath - }; - var assessmentSection = mocks.Stub(); - assessmentSection.HydraulicBoundaryDatabase = hydraulicBoundaryDatabase; assessmentSection.Stub(a => a.Id).Return(string.Empty); assessmentSection.Stub(a => a.FailureMechanismContribution).Return(FailureMechanismContributionTestFactory.CreateFailureMechanismContribution()); + assessmentSection.Stub(a => a.HydraulicBoundaryDatabase).Return(new HydraulicBoundaryDatabase + { + FilePath = validFilePath + }); var groupContext = new ClosingStructuresCalculationGroupContext(failureMechanism.CalculationsGroup, null, @@ -910,14 +891,12 @@ string validFilePath = Path.Combine(testDataPath, "complete.sqlite"); - var hydraulicBoundaryDatabase = new HydraulicBoundaryDatabase + var assessmentSection = mocks.Stub(); + assessmentSection.Stub(a => a.HydraulicBoundaryDatabase).Return(new HydraulicBoundaryDatabase { FilePath = validFilePath - }; + }); - var assessmentSection = mocks.Stub(); - assessmentSection.HydraulicBoundaryDatabase = hydraulicBoundaryDatabase; - var groupContext = new ClosingStructuresCalculationGroupContext(failureMechanism.CalculationsGroup, null, failureMechanism, @@ -1628,7 +1607,7 @@ var calculation = new StructuresCalculation(); group.Children.Add(calculation); - ClosingStructuresFailureMechanismSectionResult result = failureMechanism.SectionResults.First(); + StructuresFailureMechanismSectionResult result = failureMechanism.SectionResults.First(); result.Calculation = calculation; // Call @@ -1675,6 +1654,24 @@ CollectionAssert.DoesNotContain(parentGroup.Children, group); } + public override void Setup() + { + mocks = new MockRepository(); + gui = mocks.Stub(); + plugin = new ClosingStructuresPlugin + { + Gui = gui + }; + + info = plugin.GetTreeNodeInfos().First(tni => tni.TagType == typeof(ClosingStructuresCalculationGroupContext)); + } + + public override void TearDown() + { + plugin.Dispose(); + mocks.VerifyAll(); + } + private static void ChangeStructure(ClosingStructure structure) { structure.CopyProperties(new ClosingStructure(