Index: Ringtoets/Common/test/Ringtoets.Common.Data.Test/Hydraulics/WaveHeightCalculationTest.cs =================================================================== diff -u -r50af72c141113a242971eeeee1e6622c40d901f6 -rb461ea57ca863fd47810d2a27f40b54c9eab2187 --- Ringtoets/Common/test/Ringtoets.Common.Data.Test/Hydraulics/WaveHeightCalculationTest.cs (.../WaveHeightCalculationTest.cs) (revision 50af72c141113a242971eeeee1e6622c40d901f6) +++ Ringtoets/Common/test/Ringtoets.Common.Data.Test/Hydraulics/WaveHeightCalculationTest.cs (.../WaveHeightCalculationTest.cs) (revision b461ea57ca863fd47810d2a27f40b54c9eab2187) @@ -30,30 +30,24 @@ [TestFixture] public class WaveHeightCalculationTest { - private static IEnumerable HydraulicBoundaryLocationsToCalculate + private static IEnumerable HydraulicBoundaryLocationCalculationsToPerform { get { - yield return new TestCaseData(new TestHydraulicBoundaryLocation("WithOutputWithoutIllustrationPoints") + yield return new TestCaseData(new HydraulicBoundaryLocationCalculation { - WaveHeightCalculation = + InputParameters = { - InputParameters = - { - ShouldIllustrationPointsBeCalculated = true - }, - Output = new TestHydraulicBoundaryLocationOutput(1.0, CalculationConvergence.CalculatedConverged) - } + ShouldIllustrationPointsBeCalculated = true + }, + Output = new TestHydraulicBoundaryLocationOutput(1.0, CalculationConvergence.CalculatedConverged) }, true); - yield return new TestCaseData(new TestHydraulicBoundaryLocation("WithoutOutput"), true); + yield return new TestCaseData(new HydraulicBoundaryLocationCalculation(), true); - yield return new TestCaseData(new TestHydraulicBoundaryLocation("WithValidOutput") + yield return new TestCaseData(new HydraulicBoundaryLocationCalculation { - WaveHeightCalculation = - { - Output = new TestHydraulicBoundaryLocationOutput(1.0, CalculationConvergence.CalculatedConverged) - } + Output = new TestHydraulicBoundaryLocationOutput(1.0, CalculationConvergence.CalculatedConverged) }, false); } } @@ -81,43 +75,36 @@ } [Test] - public void Constructor_ValidHydraulicBoundaryLocation_SetsProperties( - [Values(true, false)] bool calculateIllustrationPoints) + public void Constructor_ValidInputParameters_SetsProperties([Values(true, false)] bool calculateIllustrationPoints) { // Setup - var hydraulicBoundaryLocation = new HydraulicBoundaryLocation(1, "name", 1, 1) + var hydraulicBoundaryLocation = new TestHydraulicBoundaryLocation(); + var hydraulicBoundaryLocationCalculation = new HydraulicBoundaryLocationCalculation { - WaveHeightCalculation = + InputParameters = { - InputParameters = - { - ShouldIllustrationPointsBeCalculated = calculateIllustrationPoints - } + ShouldIllustrationPointsBeCalculated = calculateIllustrationPoints } }; - HydraulicBoundaryLocationCalculation hydraulicBoundaryLocationCalculation = hydraulicBoundaryLocation.WaveHeightCalculation; - // Call var calculation = new WaveHeightCalculation(hydraulicBoundaryLocation, hydraulicBoundaryLocationCalculation); // Assert Assert.IsInstanceOf(calculation); Assert.AreEqual(hydraulicBoundaryLocation.Id, calculation.Id); Assert.AreSame(hydraulicBoundaryLocation.Name, calculation.Name); - Assert.AreEqual(hydraulicBoundaryLocationCalculation.InputParameters.ShouldIllustrationPointsBeCalculated, calculation.CalculateIllustrationPoints); - Assert.AreSame(hydraulicBoundaryLocation, calculation.ObservableObject); } [Test] - [TestCaseSource(nameof(HydraulicBoundaryLocationsToCalculate))] - public void IsCalculated_HydraulicBoundaryLocationsToCalculate_ReturnIsCalculated( - HydraulicBoundaryLocation hydraulicBoundaryLocation, bool shouldBeCalculated) + [TestCaseSource(nameof(HydraulicBoundaryLocationCalculationsToPerform))] + public void IsCalculated_NotFullyCalculated_ReturnIsCalculated(HydraulicBoundaryLocationCalculation hydraulicBoundaryLocationCalculation, + bool shouldBeCalculated) { // Setup - var calculation = new WaveHeightCalculation(hydraulicBoundaryLocation, hydraulicBoundaryLocation.WaveHeightCalculation); + var calculation = new DesignWaterLevelCalculation(new TestHydraulicBoundaryLocation(), hydraulicBoundaryLocationCalculation); // Call bool isCalculated = calculation.IsCalculated(); @@ -131,14 +118,15 @@ { // Setup var hydraulicBoundaryLocation = new TestHydraulicBoundaryLocation(); - var calculation = new WaveHeightCalculation(hydraulicBoundaryLocation, hydraulicBoundaryLocation.WaveHeightCalculation); + var hydraulicBoundaryLocationCalculation = new HydraulicBoundaryLocationCalculation(); + var calculation = new WaveHeightCalculation(hydraulicBoundaryLocation, hydraulicBoundaryLocationCalculation); var output = new TestHydraulicBoundaryLocationOutput(1); // Call calculation.Output = output; // Assert - Assert.AreSame(hydraulicBoundaryLocation.WaveHeightCalculation.Output, output); + Assert.AreSame(hydraulicBoundaryLocationCalculation.Output, output); } } } \ No newline at end of file