Index: Ringtoets/Common/test/Ringtoets.Common.Service.Test/DesignWaterLevelCalculationServiceTest.cs =================================================================== diff -u -r105bf942dafea23515d9d10b37dc23ba370ad0a4 -r1513447d61c0a667d233af5da6ba0480ffe5c3c3 --- Ringtoets/Common/test/Ringtoets.Common.Service.Test/DesignWaterLevelCalculationServiceTest.cs (.../DesignWaterLevelCalculationServiceTest.cs) (revision 105bf942dafea23515d9d10b37dc23ba370ad0a4) +++ Ringtoets/Common/test/Ringtoets.Common.Service.Test/DesignWaterLevelCalculationServiceTest.cs (.../DesignWaterLevelCalculationServiceTest.cs) (revision 1513447d61c0a667d233af5da6ba0480ffe5c3c3) @@ -135,7 +135,7 @@ } [Test] - public void Calculate_HydraulicBoundaryLocationNull_ThrowArgumentNullException() + public void Calculate_HydraulicBoundaryLocationCalculationNull_ThrowArgumentNullException() { // Setup var mockRepository = new MockRepository(); @@ -144,51 +144,24 @@ // Call TestDelegate test = () => new DesignWaterLevelCalculationService().Calculate(null, - new HydraulicBoundaryLocationCalculation(new TestHydraulicBoundaryLocation()), string.Empty, string.Empty, 1, calculationMessageProvider); // Assert var exception = Assert.Throws(test); - Assert.AreEqual("hydraulicBoundaryLocation", exception.ParamName); - mockRepository.VerifyAll(); - } - - [Test] - public void Calculate_HydraulicBoundaryLocationCalculationNull_ThrowArgumentNullException() - { - // Setup - var mockRepository = new MockRepository(); - var calculationMessageProvider = mockRepository.Stub(); - mockRepository.ReplayAll(); - - // Call - TestDelegate test = () => new DesignWaterLevelCalculationService().Calculate(new TestHydraulicBoundaryLocation(), - null, - string.Empty, - string.Empty, - 1, - calculationMessageProvider); - - // Assert - var exception = Assert.Throws(test); Assert.AreEqual("hydraulicBoundaryLocationCalculation", exception.ParamName); mockRepository.VerifyAll(); } [Test] public void Calculate_MessageProviderNull_ThrowArgumentNullException() { - // Setup - var hydraulicBoundaryLocation = new TestHydraulicBoundaryLocation(); - // Call TestDelegate test = () => { - new DesignWaterLevelCalculationService().Calculate(hydraulicBoundaryLocation, - new HydraulicBoundaryLocationCalculation(hydraulicBoundaryLocation), + new DesignWaterLevelCalculationService().Calculate(new HydraulicBoundaryLocationCalculation(new TestHydraulicBoundaryLocation()), string.Empty, string.Empty, 1, @@ -219,8 +192,7 @@ var calculationMessageProvider = mockRepository.StrictMock(); mockRepository.ReplayAll(); - var hydraulicBoundaryLocation = new HydraulicBoundaryLocation(100, "punt_flw_ 1", 0.0, 0.0); - var hydraulicBoundaryLocationCalculation = new HydraulicBoundaryLocationCalculation(hydraulicBoundaryLocation) + var hydraulicBoundaryLocationCalculation = new HydraulicBoundaryLocationCalculation(new TestHydraulicBoundaryLocation()) { InputParameters = { @@ -231,8 +203,7 @@ using (new HydraRingCalculatorFactoryConfig(calculatorFactory)) { // Call - Action call = () => new DesignWaterLevelCalculationService().Calculate(hydraulicBoundaryLocation, - hydraulicBoundaryLocationCalculation, + Action call = () => new DesignWaterLevelCalculationService().Calculate(hydraulicBoundaryLocationCalculation, validFilePath, validPreprocessorDirectory, 1.0 / 30, @@ -282,14 +253,12 @@ var calculationMessageProvider = mockRepository.StrictMock(); mockRepository.ReplayAll(); - var hydraulicBoundaryLocation = new HydraulicBoundaryLocation(100, "punt_flw_ 1", 0.0, 0.0); - var hydraulicBoundaryLocationCalculation = new HydraulicBoundaryLocationCalculation(hydraulicBoundaryLocation); + var hydraulicBoundaryLocationCalculation = new HydraulicBoundaryLocationCalculation(new TestHydraulicBoundaryLocation()); using (new HydraRingCalculatorFactoryConfig(calculatorFactory)) { // Call - new DesignWaterLevelCalculationService().Calculate(hydraulicBoundaryLocation, - hydraulicBoundaryLocationCalculation, + new DesignWaterLevelCalculationService().Calculate(hydraulicBoundaryLocationCalculation, validFilePath, preprocessorDirectory, 1.0 / 30, @@ -325,8 +294,7 @@ calculationMessageProvider.Expect(c => c.GetCalculatedNotConvergedMessage("punt_flw_ 1")).Return(failedConvergenceMessage); mockRepository.ReplayAll(); - var hydraulicBoundaryLocation = new HydraulicBoundaryLocation(100, "punt_flw_ 1", 0.0, 0.0); - var hydraulicBoundaryLocationCalculation = new HydraulicBoundaryLocationCalculation(hydraulicBoundaryLocation) + var hydraulicBoundaryLocationCalculation = new HydraulicBoundaryLocationCalculation(new TestHydraulicBoundaryLocation()) { InputParameters = { @@ -337,8 +305,7 @@ using (new HydraRingCalculatorFactoryConfig(calculatorFactory)) { // Call - Action call = () => new DesignWaterLevelCalculationService().Calculate(hydraulicBoundaryLocation, - hydraulicBoundaryLocationCalculation, + Action call = () => new DesignWaterLevelCalculationService().Calculate(hydraulicBoundaryLocationCalculation, validFilePath, validPreprocessorDirectory, norm, @@ -383,8 +350,7 @@ var calculationMessageProvider = mockRepository.StrictMock(); mockRepository.ReplayAll(); - var hydraulicBoundaryLocation = new HydraulicBoundaryLocation(100, "punt_flw_ 1", 0.0, 0.0); - var hydraulicBoundaryLocationCalculation = new HydraulicBoundaryLocationCalculation(hydraulicBoundaryLocation) + var hydraulicBoundaryLocationCalculation = new HydraulicBoundaryLocationCalculation(new TestHydraulicBoundaryLocation()) { InputParameters = { @@ -395,8 +361,7 @@ using (new HydraRingCalculatorFactoryConfig(calculatorFactory)) { // Call - Action call = () => new DesignWaterLevelCalculationService().Calculate(hydraulicBoundaryLocation, - hydraulicBoundaryLocationCalculation, + Action call = () => new DesignWaterLevelCalculationService().Calculate(hydraulicBoundaryLocationCalculation, validFilePath, validPreprocessorDirectory, 1.0 / 30, @@ -442,8 +407,7 @@ var calculationMessageProvider = mockRepository.StrictMock(); mockRepository.ReplayAll(); - var hydraulicBoundaryLocation = new HydraulicBoundaryLocation(100, "punt_flw_ 1", 0.0, 0.0); - var hydraulicBoundaryLocationCalculation = new HydraulicBoundaryLocationCalculation(hydraulicBoundaryLocation) + var hydraulicBoundaryLocationCalculation = new HydraulicBoundaryLocationCalculation(new TestHydraulicBoundaryLocation()) { InputParameters = { @@ -454,8 +418,7 @@ using (new HydraRingCalculatorFactoryConfig(calculatorFactory)) { // Call - Action call = () => new DesignWaterLevelCalculationService().Calculate(hydraulicBoundaryLocation, - hydraulicBoundaryLocationCalculation, + Action call = () => new DesignWaterLevelCalculationService().Calculate(hydraulicBoundaryLocationCalculation, validFilePath, validPreprocessorDirectory, 1.0 / 30, @@ -504,14 +467,12 @@ calculationMessageProvider.Stub(mp => mp.GetCalculatedNotConvergedMessage("punt_flw_ 1")).Return(string.Empty); mockRepository.ReplayAll(); - var hydraulicBoundaryLocation = new HydraulicBoundaryLocation(100, "punt_flw_ 1", 0.0, 0.0); - var hydraulicBoundaryLocationCalculation = new HydraulicBoundaryLocationCalculation(hydraulicBoundaryLocation); + var hydraulicBoundaryLocationCalculation = new HydraulicBoundaryLocationCalculation(new TestHydraulicBoundaryLocation()); using (new HydraRingCalculatorFactoryConfig(calculatorFactory)) { // Call - TestDelegate call = () => new DesignWaterLevelCalculationService().Calculate(hydraulicBoundaryLocation, - hydraulicBoundaryLocationCalculation, + TestDelegate call = () => new DesignWaterLevelCalculationService().Calculate(hydraulicBoundaryLocationCalculation, validFilePath, validPreprocessorDirectory, 1.0 / 30, @@ -543,8 +504,7 @@ var calculationMessageProvider = mockRepository.Stub(); mockRepository.ReplayAll(); - var hydraulicBoundaryLocation = new HydraulicBoundaryLocation(100, "punt_flw_ 1", 0.0, 0.0); - var hydraulicBoundaryLocationCalculation = new HydraulicBoundaryLocationCalculation(hydraulicBoundaryLocation) + var hydraulicBoundaryLocationCalculation = new HydraulicBoundaryLocationCalculation(new TestHydraulicBoundaryLocation()) { InputParameters = { @@ -555,8 +515,7 @@ using (new HydraRingCalculatorFactoryConfig(calculatorFactory)) { // Call - Action call = () => new DesignWaterLevelCalculationService().Calculate(hydraulicBoundaryLocation, - hydraulicBoundaryLocationCalculation, + Action call = () => new DesignWaterLevelCalculationService().Calculate(hydraulicBoundaryLocationCalculation, validFilePath, validPreprocessorDirectory, 1.0 / 30, @@ -596,14 +555,12 @@ var calculationMessageProvider = mockRepository.Stub(); mockRepository.ReplayAll(); - var hydraulicBoundaryLocation = new HydraulicBoundaryLocation(100, "punt_flw_ 1", 0.0, 0.0); - var hydraulicBoundaryLocationCalculation = new HydraulicBoundaryLocationCalculation(hydraulicBoundaryLocation); + var hydraulicBoundaryLocationCalculation = new HydraulicBoundaryLocationCalculation(new TestHydraulicBoundaryLocation()); using (new HydraRingCalculatorFactoryConfig(calculatorFactory)) { // Call - Action call = () => new DesignWaterLevelCalculationService().Calculate(hydraulicBoundaryLocation, - hydraulicBoundaryLocationCalculation, + Action call = () => new DesignWaterLevelCalculationService().Calculate(hydraulicBoundaryLocationCalculation, validFilePath, validPreprocessorDirectory, 1.0 / 30, @@ -637,8 +594,7 @@ var calculationMessageProvider = mockRepository.Stub(); mockRepository.ReplayAll(); - var hydraulicBoundaryLocation = new HydraulicBoundaryLocation(100, "punt_flw_ 1", 0.0, 0.0); - var hydraulicBoundaryLocationCalculation = new HydraulicBoundaryLocationCalculation(hydraulicBoundaryLocation); + var hydraulicBoundaryLocationCalculation = new HydraulicBoundaryLocationCalculation(new TestHydraulicBoundaryLocation()); const double norm = 1.0 / 30; @@ -648,8 +604,7 @@ calculator.CalculationFinishedHandler += (s, e) => service.Cancel(); // Call - service.Calculate(hydraulicBoundaryLocation, - hydraulicBoundaryLocationCalculation, + service.Calculate(hydraulicBoundaryLocationCalculation, validFilePath, validPreprocessorDirectory, norm, @@ -700,8 +655,7 @@ mockRepository.ReplayAll(); - var hydraulicBoundaryLocation = new HydraulicBoundaryLocation(100, locationName, 0.0, 0.0); - var hydraulicBoundaryLocationCalculation = new HydraulicBoundaryLocationCalculation(hydraulicBoundaryLocation); + var hydraulicBoundaryLocationCalculation = new HydraulicBoundaryLocationCalculation(new TestHydraulicBoundaryLocation(locationName)); using (new HydraRingCalculatorFactoryConfig(calculatorFactory)) { @@ -712,8 +666,7 @@ { try { - new DesignWaterLevelCalculationService().Calculate(hydraulicBoundaryLocation, - hydraulicBoundaryLocationCalculation, + new DesignWaterLevelCalculationService().Calculate(hydraulicBoundaryLocationCalculation, validFilePath, validPreprocessorDirectory, norm,