Index: Ringtoets/Common/test/Ringtoets.Common.Service.Test/Structures/StructuresCalculationServiceBaseTest.cs =================================================================== diff -u -rfe55aedc4ccec24ea5827ecf23a965d2a2cb1ed8 -r9cd1f99915772a8d9990c31e281b70dd663b4e2d --- Ringtoets/Common/test/Ringtoets.Common.Service.Test/Structures/StructuresCalculationServiceBaseTest.cs (.../StructuresCalculationServiceBaseTest.cs) (revision fe55aedc4ccec24ea5827ecf23a965d2a2cb1ed8) +++ Ringtoets/Common/test/Ringtoets.Common.Service.Test/Structures/StructuresCalculationServiceBaseTest.cs (.../StructuresCalculationServiceBaseTest.cs) (revision 9cd1f99915772a8d9990c31e281b70dd663b4e2d) @@ -28,7 +28,6 @@ using Rhino.Mocks; using Ringtoets.Common.Data.AssessmentSection; using Ringtoets.Common.Data.Exceptions; -using Ringtoets.Common.Data.Hydraulics; using Ringtoets.Common.Data.TestUtil; using Ringtoets.Common.Service.MessageProviders; using Ringtoets.Common.Service.Structures; @@ -97,11 +96,11 @@ { // Setup var mocks = new MockRepository(); - IAssessmentSection assessmentSection = AssessmentSectionHelper.CreateAssessmentSectionStub(new TestFailureMechanism(), mocks); + IAssessmentSection assessmentSection = AssessmentSectionHelper.CreateAssessmentSectionStub(new TestFailureMechanism(), + mocks, + Path.Combine(testDataPath, "notexisting.sqlite")); mocks.ReplayAll(); - assessmentSection.HydraulicBoundaryDatabase.FilePath = Path.Combine(testDataPath, "notexisting.sqlite"); - var calculation = new TestStructuresCalculation(); var isValid = true; @@ -128,17 +127,16 @@ { // Setup var mocks = new MockRepository(); - IAssessmentSection assessmentSection = AssessmentSectionHelper.CreateAssessmentSectionStubWithoutBoundaryDatabase(new TestFailureMechanism(), mocks); - mocks.ReplayAll(); - assessmentSection.HydraulicBoundaryDatabase = new HydraulicBoundaryDatabase - { - FilePath = validFilePath, - CanUsePreprocessor = true, - UsePreprocessor = true, - PreprocessorDirectory = "NonExistingPreprocessorDirectory" - }; + IAssessmentSection assessmentSection = AssessmentSectionHelper.CreateAssessmentSectionStub( + new TestFailureMechanism(), mocks, validFilePath); + assessmentSection.HydraulicBoundaryDatabase.CanUsePreprocessor = true; + assessmentSection.HydraulicBoundaryDatabase.UsePreprocessor = true; + assessmentSection.HydraulicBoundaryDatabase.PreprocessorDirectory = "NonExistingPreprocessorDirectory"; + + mocks.ReplayAll(); + var calculation = new TestStructuresCalculation(); var isValid = true; @@ -165,13 +163,11 @@ { // Setup var mocks = new MockRepository(); - IAssessmentSection assessmentSection = AssessmentSectionHelper.CreateAssessmentSectionStub( - new TestFailureMechanism(), - mocks); + IAssessmentSection assessmentSection = AssessmentSectionHelper.CreateAssessmentSectionStub(new TestFailureMechanism(), + mocks, + Path.Combine(testDataPath, "HRD nosettings.sqlite")); mocks.ReplayAll(); - assessmentSection.HydraulicBoundaryDatabase.FilePath = Path.Combine(testDataPath, "HRD nosettings.sqlite"); - var calculation = new TestStructuresCalculation(); var isValid = false; @@ -198,12 +194,11 @@ { // Setup var mocks = new MockRepository(); - IAssessmentSection assessmentSection = AssessmentSectionHelper.CreateAssessmentSectionStub( - new TestFailureMechanism(), mocks); + IAssessmentSection assessmentSection = AssessmentSectionHelper.CreateAssessmentSectionStub(new TestFailureMechanism(), + mocks, + validFilePath); mocks.ReplayAll(); - assessmentSection.HydraulicBoundaryDatabase.FilePath = validFilePath; - var calculation = new TestStructuresCalculation { InputParameters = @@ -239,8 +234,7 @@ var mocks = new MockRepository(); IAssessmentSection assessmentSection = AssessmentSectionHelper.CreateAssessmentSectionStub( - failureMechanism, mocks); - assessmentSection.HydraulicBoundaryDatabase.FilePath = validFilePath; + failureMechanism, mocks, validFilePath); mocks.ReplayAll(); var calculation = new TestStructuresCalculation @@ -278,8 +272,7 @@ var mocks = new MockRepository(); IAssessmentSection assessmentSection = AssessmentSectionHelper.CreateAssessmentSectionStub( - failureMechanism, mocks); - assessmentSection.HydraulicBoundaryDatabase.FilePath = validFilePath; + failureMechanism, mocks, validFilePath); mocks.ReplayAll(); var calculation = new TestStructuresCalculation @@ -319,8 +312,7 @@ var mocks = new MockRepository(); IAssessmentSection assessmentSection = AssessmentSectionHelper.CreateAssessmentSectionStub( - failureMechanism, mocks); - assessmentSection.HydraulicBoundaryDatabase.FilePath = validFilePath; + failureMechanism, mocks, validFilePath); mocks.ReplayAll(); var calculation = new TestStructuresCalculation @@ -355,18 +347,15 @@ public void Validate_ValidInputWithUseProcessorFalse_ReturnsTrue() { // Setup - var failureMechanism = new TestFailureMechanism(); - var mocks = new MockRepository(); - IAssessmentSection assessmentSection = AssessmentSectionHelper.CreateAssessmentSectionStubWithoutBoundaryDatabase( - failureMechanism, mocks); - assessmentSection.HydraulicBoundaryDatabase = new HydraulicBoundaryDatabase - { - FilePath = validFilePath, - CanUsePreprocessor = true, - UsePreprocessor = false, - PreprocessorDirectory = "NonExistingPreprocessorDirectory" - }; + + IAssessmentSection assessmentSection = AssessmentSectionHelper.CreateAssessmentSectionStub( + new TestFailureMechanism(), mocks, validFilePath); + + assessmentSection.HydraulicBoundaryDatabase.CanUsePreprocessor = true; + assessmentSection.HydraulicBoundaryDatabase.UsePreprocessor = false; + assessmentSection.HydraulicBoundaryDatabase.PreprocessorDirectory = "NonExistingPreprocessorDirectory"; + mocks.ReplayAll(); var calculation = new TestStructuresCalculation @@ -401,18 +390,15 @@ public void Validate_ValidInputWithUseProcessorTrue_ReturnsTrue() { // Setup - var failureMechanism = new TestFailureMechanism(); - var mocks = new MockRepository(); - IAssessmentSection assessmentSection = AssessmentSectionHelper.CreateAssessmentSectionStubWithoutBoundaryDatabase( - failureMechanism, mocks); - assessmentSection.HydraulicBoundaryDatabase = new HydraulicBoundaryDatabase - { - FilePath = validFilePath, - CanUsePreprocessor = true, - UsePreprocessor = true, - PreprocessorDirectory = TestHelper.GetScratchPadPath() - }; + + IAssessmentSection assessmentSection = AssessmentSectionHelper.CreateAssessmentSectionStub( + new TestFailureMechanism(), mocks, validFilePath); + + assessmentSection.HydraulicBoundaryDatabase.CanUsePreprocessor = true; + assessmentSection.HydraulicBoundaryDatabase.UsePreprocessor = true; + assessmentSection.HydraulicBoundaryDatabase.PreprocessorDirectory = TestHelper.GetScratchPadPath(); + mocks.ReplayAll(); var calculation = new TestStructuresCalculation @@ -453,7 +439,7 @@ // Call TestDelegate test = () => new TestStructuresCalculationService(messageProvider) - .Calculate(null, new GeneralTestInput(), 0, 1, 1, string.Empty, string.Empty); + .Calculate(null, new GeneralTestInput(), string.Empty, string.Empty); // Assert var exception = Assert.Throws(test); @@ -473,7 +459,7 @@ // Call TestDelegate test = () => new TestStructuresCalculationService(messageProvider) - .Calculate(calculation, null, 0, 1, 1, string.Empty, string.Empty); + .Calculate(calculation, null, string.Empty, string.Empty); // Assert var exception = Assert.Throws(test); @@ -517,7 +503,7 @@ var service = new TestStructuresCalculationService(messageProvider); // Call - Action call = () => service.Calculate(calculation, new GeneralTestInput(), 1, 1, 1, validFilePath, validPreprocessorDirectory); + Action call = () => service.Calculate(calculation, new GeneralTestInput(), validFilePath, validPreprocessorDirectory); // Assert TestHelper.AssertLogMessages(call, messages => @@ -577,7 +563,7 @@ var service = new TestStructuresCalculationService(messageProvider); // Call - Action call = () => service.Calculate(calculation, new GeneralTestInput(), 1, 1, 1, validFilePath, validPreprocessorDirectory); + Action call = () => service.Calculate(calculation, new GeneralTestInput(), validFilePath, validPreprocessorDirectory); // Assert TestHelper.AssertLogMessages(call, messages => @@ -630,7 +616,7 @@ var service = new TestStructuresCalculationService(messageProvider); // Call - Action call = () => service.Calculate(calculation, new GeneralTestInput(), 1, 1, 1, validFilePath, validPreprocessorDirectory); + Action call = () => service.Calculate(calculation, new GeneralTestInput(), validFilePath, validPreprocessorDirectory); // Assert TestHelper.AssertLogMessages(call, messages => @@ -682,7 +668,7 @@ var service = new TestStructuresCalculationService(messageProvider); // Call - Action call = () => service.Calculate(calculation, new GeneralTestInput(), 1, 1, 1, validFilePath, validPreprocessorDirectory); + Action call = () => service.Calculate(calculation, new GeneralTestInput(), validFilePath, validPreprocessorDirectory); // Assert TestHelper.AssertLogMessagesWithLevelAndLoggedExceptions(call, messages => @@ -739,7 +725,7 @@ var service = new TestStructuresCalculationService(messageProvider); // Call - Action call = () => service.Calculate(calculation, new GeneralTestInput(), 1, 1, 1, validFilePath, validPreprocessorDirectory); + Action call = () => service.Calculate(calculation, new GeneralTestInput(), validFilePath, validPreprocessorDirectory); // Assert TestHelper.AssertLogMessagesWithLevelAndLoggedExceptions(call, messages => @@ -789,7 +775,7 @@ calculator.CalculationFinishedHandler += (s, e) => service.Cancel(); // Call - service.Calculate(calculation, new GeneralTestInput(), 0, 0.5, 1, validFilePath, validPreprocessorDirectory); + service.Calculate(calculation, new GeneralTestInput(), validFilePath, validPreprocessorDirectory); // Assert Assert.IsNull(calculation.Output); @@ -856,7 +842,7 @@ { try { - structuresCalculationService.Calculate(calculation, new GeneralTestInput(), 0, 0.5, 1, validFilePath, validPreprocessorDirectory); + structuresCalculationService.Calculate(calculation, new GeneralTestInput(), validFilePath, validPreprocessorDirectory); } catch (HydraRingCalculationException) {