Index: Ringtoets/Common/test/Ringtoets.Common.Service.Test/WaveHeightCalculationActivityTest.cs =================================================================== diff -u -r9779d1ab6b555c557e8fd18f4430ad207bd003da -r8737389949c6578649c7788bd3a0550699276eac --- Ringtoets/Common/test/Ringtoets.Common.Service.Test/WaveHeightCalculationActivityTest.cs (.../WaveHeightCalculationActivityTest.cs) (revision 9779d1ab6b555c557e8fd18f4430ad207bd003da) +++ Ringtoets/Common/test/Ringtoets.Common.Service.Test/WaveHeightCalculationActivityTest.cs (.../WaveHeightCalculationActivityTest.cs) (revision 8737389949c6578649c7788bd3a0550699276eac) @@ -117,11 +117,10 @@ // Setup string inValidFilePath = Path.Combine(testDataPath, "notexisting.sqlite"); const string locationName = "testLocation"; - const string activityDescription = "activityDescription"; - const string calculationName = "locationName"; + const string calculationName = "calculationName"; var calculationMessageProvider = mockRepository.StrictMock(); - calculationMessageProvider.Stub(calc => calc.GetActivityDescription(locationName)).Return(activityDescription); + calculationMessageProvider.Stub(calc => calc.GetActivityDescription(locationName)).Return(string.Empty); calculationMessageProvider.Stub(calc => calc.GetCalculationName(locationName)).Return(calculationName).Repeat.AtLeastOnce(); mockRepository.ReplayAll(); @@ -150,8 +149,7 @@ // Setup string validFilePath = Path.Combine(testDataPath, validFile); const string locationName = "locationName"; - const string activityDescription = "activityDescription"; - const string calculationName = "locationName"; + const string calculationName = "calculationName"; const double norm = 1.0 / 30; var hydraulicBoundaryLocation = new HydraulicBoundaryLocation(0, locationName, 0, 0); @@ -163,7 +161,7 @@ var calculatorFactory = mockRepository.StrictMock(); calculatorFactory.Expect(cf => cf.CreateWaveHeightCalculator(testDataPath)).Return(calculator); var calculationMessageProvider = mockRepository.Stub(); - calculationMessageProvider.Stub(calc => calc.GetActivityDescription(locationName)).Return(activityDescription); + calculationMessageProvider.Stub(calc => calc.GetActivityDescription(locationName)).Return(string.Empty); calculationMessageProvider.Stub(calc => calc.GetCalculationName(locationName)).Return(calculationName); mockRepository.ReplayAll(); @@ -202,12 +200,11 @@ // Setup string validFilePath = Path.Combine(testDataPath, validFile); const string locationName = "locationName"; - const string activityDescription = "activityDescription"; const double norm = 1.0 / 30; var calculationMessageProvider = mockRepository.Stub(); - calculationMessageProvider.Stub(calc => calc.GetActivityDescription(locationName)).Return(activityDescription); - calculationMessageProvider.Stub(calc => calc.GetCalculationName(locationName)).Return(activityDescription); + calculationMessageProvider.Stub(calc => calc.GetActivityDescription(locationName)).Return(string.Empty); + calculationMessageProvider.Stub(calc => calc.GetCalculationName(locationName)).Return(string.Empty); mockRepository.ReplayAll(); var hydraulicBoundaryLocation = new HydraulicBoundaryLocation(1, locationName, 0, 0) @@ -331,8 +328,7 @@ { // Setup const string locationName = "locationName"; - const string activityDescription = "activityDescription"; - const string calculationNotConvergedMessage = "GetCalculatedNotConvergedMessage"; + const string calculationNotConvergedMessage = "calculationNotConvergedMessage"; var calculator = new TestWaveHeightCalculator { @@ -342,8 +338,8 @@ var calculatorFactory = mockRepository.StrictMock(); calculatorFactory.Expect(cf => cf.CreateWaveHeightCalculator(testDataPath)).Return(calculator); var calculationMessageProvider = mockRepository.Stub(); - calculationMessageProvider.Stub(calc => calc.GetActivityDescription(locationName)).Return(activityDescription); - calculationMessageProvider.Stub(calc => calc.GetCalculationName(locationName)).Return("GetCalculationName").Repeat.AtLeastOnce(); + calculationMessageProvider.Stub(calc => calc.GetActivityDescription(locationName)).Return(string.Empty); + calculationMessageProvider.Stub(calc => calc.GetCalculationName(locationName)).Return(string.Empty).Repeat.AtLeastOnce(); calculationMessageProvider.Stub(calc => calc.GetCalculatedNotConvergedMessage(locationName)).Return(calculationNotConvergedMessage); mockRepository.ReplayAll(); @@ -386,7 +382,6 @@ { // Setup const string locationName = "locationName 1"; - const string calculationFailedMessage = "Something went wrong"; var hydraulicBoundaryLocation = new HydraulicBoundaryLocation(0, locationName, 0, 0) { WaveHeightOutput = new HydraulicBoundaryLocationOutput(double.NaN, double.NaN, @@ -403,11 +398,11 @@ var calculatorFactory = mockRepository.StrictMock(); calculatorFactory.Expect(cf => cf.CreateWaveHeightCalculator(testDataPath)).Return(calculator); var calculationMessageProvider = mockRepository.StrictMock(); - calculationMessageProvider.Stub(calc => calc.GetActivityDescription(locationName)).Return(locationName); - calculationMessageProvider.Stub(calc => calc.GetCalculationName(locationName)).Return(locationName); - calculationMessageProvider.Stub(calc => calc.GetCalculationFailedMessage(null, null)).IgnoreArguments().Return(calculationFailedMessage); - calculationMessageProvider.Stub(calc => calc.GetCalculationFailedUnexplainedMessage(locationName)).Return(calculationFailedMessage); - calculationMessageProvider.Stub(calc => calc.GetCalculatedNotConvergedMessage(locationName)).Return(locationName); + calculationMessageProvider.Stub(calc => calc.GetActivityDescription(locationName)).Return(string.Empty); + calculationMessageProvider.Stub(calc => calc.GetCalculationName(locationName)).Return(string.Empty); + calculationMessageProvider.Stub(calc => calc.GetCalculationFailedMessage(null, null)).IgnoreArguments().Return(string.Empty); + calculationMessageProvider.Stub(calc => calc.GetCalculationFailedUnexplainedMessage(locationName)).Return(string.Empty); + calculationMessageProvider.Stub(calc => calc.GetCalculatedNotConvergedMessage(locationName)).Return(string.Empty); mockRepository.ReplayAll(); string validFilePath = Path.Combine(testDataPath, validFile);