Index: Ringtoets/GrassCoverErosionInwards/test/Ringtoets.GrassCoverErosionInwards.Integration.Test/GrassCoverErosionInwardsCalculationActivityIntegrationTest.cs =================================================================== diff -u -r3ed8e00da47ef2780e79688a9902e12b674e4cc0 -r736f04ea6f24399148ab8efd7f3b03ae8f8f56b5 --- Ringtoets/GrassCoverErosionInwards/test/Ringtoets.GrassCoverErosionInwards.Integration.Test/GrassCoverErosionInwardsCalculationActivityIntegrationTest.cs (.../GrassCoverErosionInwardsCalculationActivityIntegrationTest.cs) (revision 3ed8e00da47ef2780e79688a9902e12b674e4cc0) +++ Ringtoets/GrassCoverErosionInwards/test/Ringtoets.GrassCoverErosionInwards.Integration.Test/GrassCoverErosionInwardsCalculationActivityIntegrationTest.cs (.../GrassCoverErosionInwardsCalculationActivityIntegrationTest.cs) (revision 736f04ea6f24399148ab8efd7f3b03ae8f8f56b5) @@ -230,10 +230,10 @@ } }; - var testOvertoppingCalculator = new TestOvertoppingCalculator(); + var calculator = new TestOvertoppingCalculator(); var mockRepository = new MockRepository(); - var calculatorFactory = mockRepository.Stub(); - calculatorFactory.Expect(cf => cf.CreateOvertoppingCalculator(testDataPath)).Return(testOvertoppingCalculator); + var calculatorFactory = mockRepository.StrictMock(); + calculatorFactory.Expect(cf => cf.CreateOvertoppingCalculator(testDataPath)).Return(calculator); mockRepository.ReplayAll(); var activity = new GrassCoverErosionInwardsCalculationActivity(calculation, validFile, assessmentSection.GrassCoverErosionInwards, assessmentSection); @@ -244,7 +244,7 @@ activity.Run(); // Assert - OvertoppingCalculationInput[] overtoppingCalculationInputs = testOvertoppingCalculator.ReceivedInputs.ToArray(); + OvertoppingCalculationInput[] overtoppingCalculationInputs = calculator.ReceivedInputs.ToArray(); Assert.AreEqual(1, overtoppingCalculationInputs.Length); OvertoppingCalculationInput actualInput = overtoppingCalculationInputs[0]; @@ -301,14 +301,14 @@ } }; - var testOvertoppingCalculator = new TestOvertoppingCalculator + var calculator = new TestOvertoppingCalculator { LastErrorFileContent = "An error occurred", EndInFailure = true }; var mockRepository = new MockRepository(); - var calculatorFactory = mockRepository.Stub(); - calculatorFactory.Expect(cf => cf.CreateOvertoppingCalculator(testDataPath)).Return(testOvertoppingCalculator); + var calculatorFactory = mockRepository.StrictMock(); + calculatorFactory.Expect(cf => cf.CreateOvertoppingCalculator(testDataPath)).Return(calculator); mockRepository.ReplayAll(); using (new HydraRingCalculatorFactoryConfig(calculatorFactory)) @@ -352,13 +352,13 @@ DikeProfile = CreateDikeProfile() } }; - var testOvertoppingCalculator = new TestOvertoppingCalculator + var calculator = new TestOvertoppingCalculator { EndInFailure = true }; var mockRepository = new MockRepository(); - var calculatorFactory = mockRepository.Stub(); - calculatorFactory.Expect(cf => cf.CreateOvertoppingCalculator(testDataPath)).Return(testOvertoppingCalculator); + var calculatorFactory = mockRepository.StrictMock(); + calculatorFactory.Expect(cf => cf.CreateOvertoppingCalculator(testDataPath)).Return(calculator); mockRepository.ReplayAll(); using (new HydraRingCalculatorFactoryConfig(calculatorFactory)) @@ -402,14 +402,14 @@ DikeProfile = CreateDikeProfile() } }; - var testOvertoppingCalculator = new TestOvertoppingCalculator + var calculator = new TestOvertoppingCalculator { LastErrorFileContent = "An error occurred", EndInFailure = false }; var mockRepository = new MockRepository(); - var calculatorFactory = mockRepository.Stub(); - calculatorFactory.Expect(cf => cf.CreateOvertoppingCalculator(testDataPath)).Return(testOvertoppingCalculator); + var calculatorFactory = mockRepository.StrictMock(); + calculatorFactory.Expect(cf => cf.CreateOvertoppingCalculator(testDataPath)).Return(calculator); mockRepository.ReplayAll(); using (new HydraRingCalculatorFactoryConfig(calculatorFactory)) @@ -455,7 +455,7 @@ }; var mockRepository = new MockRepository(); - var calculatorFactory = mockRepository.Stub(); + var calculatorFactory = mockRepository.StrictMock(); calculatorFactory.Expect(cf => cf.CreateOvertoppingCalculator(testDataPath)).Return(new TestOvertoppingCalculator()); mockRepository.ReplayAll(); @@ -491,12 +491,12 @@ var observerMock = mockRepository.StrictMock(); observerMock.Expect(o => o.UpdateObserver()); - var testOvertoppingCalculator = new TestOvertoppingCalculator + var calculator = new TestOvertoppingCalculator { EndInFailure = true }; var calculatorFactory = mockRepository.StrictMock(); - calculatorFactory.Expect(cf => cf.CreateOvertoppingCalculator(testDataPath)).Return(testOvertoppingCalculator); + calculatorFactory.Expect(cf => cf.CreateOvertoppingCalculator(testDataPath)).Return(calculator); mockRepository.ReplayAll(); var assessmentSection = new AssessmentSection(AssessmentSectionComposition.Dike); @@ -537,7 +537,7 @@ var observerMock = mockRepository.StrictMock(); observerMock.Expect(o => o.UpdateObserver()); - var calculatorFactory = mockRepository.Stub(); + var calculatorFactory = mockRepository.StrictMock(); calculatorFactory.Expect(cf => cf.CreateOvertoppingCalculator(testDataPath)).Return(new TestOvertoppingCalculator()); mockRepository.ReplayAll(); @@ -584,12 +584,12 @@ public void Run_ValidDikeHeightCalculation_InputPropertiesCorrectlySendToService(DikeHeightCalculationType dikeHeightCalculationType) { // Setup - var testDikeHeightCalculator = new TestHydraulicLoadsCalculator(); + var dikeHeightCalculator = new TestHydraulicLoadsCalculator(); var mockRepository = new MockRepository(); - var calculatorFactory = mockRepository.Stub(); + var calculatorFactory = mockRepository.StrictMock(); calculatorFactory.Expect(cf => cf.CreateOvertoppingCalculator(testDataPath)).Return(new TestOvertoppingCalculator()); - calculatorFactory.Expect(cf => cf.CreateDikeHeightCalculator(testDataPath)).Return(testDikeHeightCalculator); + calculatorFactory.Expect(cf => cf.CreateDikeHeightCalculator(testDataPath)).Return(dikeHeightCalculator); mockRepository.ReplayAll(); var assessmentSection = new AssessmentSection(AssessmentSectionComposition.Dike); @@ -614,7 +614,7 @@ activity.Run(); // Assert - HydraulicLoadsCalculationInput[] hydraulicLoadsCalculationInputs = testDikeHeightCalculator.ReceivedInputs.ToArray(); + HydraulicLoadsCalculationInput[] hydraulicLoadsCalculationInputs = dikeHeightCalculator.ReceivedInputs.ToArray(); Assert.AreEqual(1, hydraulicLoadsCalculationInputs.Length); HydraulicLoadsCalculationInput actualInput = hydraulicLoadsCalculationInputs[0]; @@ -668,16 +668,16 @@ public void Run_InvalidDikeHeightCalculationWithExceptionAndLastErrorPresent_LogError(DikeHeightCalculationType dikeHeightCalculationType) { // Setup - var testDikeHeightCalculator = new TestHydraulicLoadsCalculator + var dikeHeightCalculator = new TestHydraulicLoadsCalculator { LastErrorFileContent = "An error occurred", EndInFailure = true }; var mockRepository = new MockRepository(); - var calculatorFactory = mockRepository.Stub(); + var calculatorFactory = mockRepository.StrictMock(); calculatorFactory.Expect(cf => cf.CreateOvertoppingCalculator(testDataPath)).Return(new TestOvertoppingCalculator()); - calculatorFactory.Expect(cf => cf.CreateDikeHeightCalculator(testDataPath)).Return(testDikeHeightCalculator); + calculatorFactory.Expect(cf => cf.CreateDikeHeightCalculator(testDataPath)).Return(dikeHeightCalculator); mockRepository.ReplayAll(); var assessmentSection = new AssessmentSection(AssessmentSectionComposition.Dike); @@ -726,15 +726,15 @@ public void Run_InvalidDikeHeightCalculationWithExceptionAndNoLastErrorPresent_LogError(DikeHeightCalculationType dikeHeightCalculationType) { // Setup - var testDikeHeightCalculator = new TestHydraulicLoadsCalculator + var dikeHeightCalculator = new TestHydraulicLoadsCalculator { EndInFailure = true }; var mockRepository = new MockRepository(); - var calculatorFactory = mockRepository.Stub(); + var calculatorFactory = mockRepository.StrictMock(); calculatorFactory.Expect(cf => cf.CreateOvertoppingCalculator(testDataPath)).Return(new TestOvertoppingCalculator()); - calculatorFactory.Expect(cf => cf.CreateDikeHeightCalculator(testDataPath)).Return(testDikeHeightCalculator); + calculatorFactory.Expect(cf => cf.CreateDikeHeightCalculator(testDataPath)).Return(dikeHeightCalculator); mockRepository.ReplayAll(); var assessmentSection = new AssessmentSection(AssessmentSectionComposition.Dike); @@ -783,16 +783,16 @@ public void Run_InvalidDikeHeightCalculationWithoutExceptionAndWithLastErrorPresent_LogError(DikeHeightCalculationType dikeHeightCalculationType) { // Setup - var testDikeHeightCalculator = new TestHydraulicLoadsCalculator + var dikeHeightCalculator = new TestHydraulicLoadsCalculator { EndInFailure = false, LastErrorFileContent = "An error occurred" }; var mockRepository = new MockRepository(); - var calculatorFactory = mockRepository.Stub(); + var calculatorFactory = mockRepository.StrictMock(); calculatorFactory.Expect(cf => cf.CreateOvertoppingCalculator(testDataPath)).Return(new TestOvertoppingCalculator()); - calculatorFactory.Expect(cf => cf.CreateDikeHeightCalculator(testDataPath)).Return(testDikeHeightCalculator); + calculatorFactory.Expect(cf => cf.CreateDikeHeightCalculator(testDataPath)).Return(dikeHeightCalculator); mockRepository.ReplayAll(); var assessmentSection = new AssessmentSection(AssessmentSectionComposition.Dike); @@ -841,16 +841,16 @@ public void Run_ValidDikeHeightCalculation_PerformValidationAndCalculationAndLogStartAndEndError(DikeHeightCalculationType dikeHeightCalculationType) { // Setup - var testDikeHeightCalculator = new TestHydraulicLoadsCalculator + var dikeHeightCalculator = new TestHydraulicLoadsCalculator { Value = 2, ReliabilityIndex = -1 }; var mockRepository = new MockRepository(); - var calculatorFactory = mockRepository.Stub(); + var calculatorFactory = mockRepository.StrictMock(); calculatorFactory.Expect(cf => cf.CreateOvertoppingCalculator(testDataPath)).Return(new TestOvertoppingCalculator()); - calculatorFactory.Expect(cf => cf.CreateDikeHeightCalculator(testDataPath)).Return(testDikeHeightCalculator); + calculatorFactory.Expect(cf => cf.CreateDikeHeightCalculator(testDataPath)).Return(dikeHeightCalculator); mockRepository.ReplayAll(); var assessmentSection = new AssessmentSection(AssessmentSectionComposition.Dike) @@ -909,14 +909,14 @@ var observerMock = mockRepository.StrictMock(); observerMock.Expect(o => o.UpdateObserver()); - var testDikeHeightCalculator = new TestHydraulicLoadsCalculator + var dikeHeightCalculator = new TestHydraulicLoadsCalculator { Value = double.NaN, EndInFailure = true }; - var calculatorFactory = mockRepository.Stub(); + var calculatorFactory = mockRepository.StrictMock(); calculatorFactory.Expect(cf => cf.CreateOvertoppingCalculator(testDataPath)).Return(new TestOvertoppingCalculator()); - calculatorFactory.Expect(cf => cf.CreateDikeHeightCalculator(testDataPath)).Return(testDikeHeightCalculator); + calculatorFactory.Expect(cf => cf.CreateDikeHeightCalculator(testDataPath)).Return(dikeHeightCalculator); mockRepository.ReplayAll(); var assessmentSection = new AssessmentSection(AssessmentSectionComposition.Dike); @@ -961,7 +961,7 @@ var observerMock = mockRepository.StrictMock(); observerMock.Expect(o => o.UpdateObserver()); - var calculatorFactory = mockRepository.Stub(); + var calculatorFactory = mockRepository.StrictMock(); calculatorFactory.Expect(cf => cf.CreateOvertoppingCalculator(testDataPath)).Return(new TestOvertoppingCalculator()); calculatorFactory.Expect(cf => cf.CreateDikeHeightCalculator(testDataPath)).Return(new TestHydraulicLoadsCalculator()); mockRepository.ReplayAll(); @@ -1015,7 +1015,7 @@ var overtoppingRateCalculator = new TestHydraulicLoadsCalculator(); var mockRepository = new MockRepository(); - var calculatorFactory = mockRepository.Stub(); + var calculatorFactory = mockRepository.StrictMock(); calculatorFactory.Expect(cf => cf.CreateOvertoppingCalculator(testDataPath)).Return(new TestOvertoppingCalculator()); calculatorFactory.Expect(cf => cf.CreateOvertoppingRateCalculator(testDataPath)).Return(overtoppingRateCalculator); mockRepository.ReplayAll(); @@ -1102,7 +1102,7 @@ }; var mockRepository = new MockRepository(); - var calculatorFactory = mockRepository.Stub(); + var calculatorFactory = mockRepository.StrictMock(); calculatorFactory.Expect(cf => cf.CreateOvertoppingCalculator(testDataPath)).Return(new TestOvertoppingCalculator()); calculatorFactory.Expect(cf => cf.CreateOvertoppingRateCalculator(testDataPath)).Return(overtoppingRateCalculator); mockRepository.ReplayAll(); @@ -1159,7 +1159,7 @@ }; var mockRepository = new MockRepository(); - var calculatorFactory = mockRepository.Stub(); + var calculatorFactory = mockRepository.StrictMock(); calculatorFactory.Expect(cf => cf.CreateOvertoppingCalculator(testDataPath)).Return(new TestOvertoppingCalculator()); calculatorFactory.Expect(cf => cf.CreateOvertoppingRateCalculator(testDataPath)).Return(overtoppingRateCalculator); mockRepository.ReplayAll(); @@ -1217,7 +1217,7 @@ }; var mockRepository = new MockRepository(); - var calculatorFactory = mockRepository.Stub(); + var calculatorFactory = mockRepository.StrictMock(); calculatorFactory.Expect(cf => cf.CreateOvertoppingCalculator(testDataPath)).Return(new TestOvertoppingCalculator()); calculatorFactory.Expect(cf => cf.CreateOvertoppingRateCalculator(testDataPath)).Return(overtoppingRateCalculator); mockRepository.ReplayAll(); @@ -1275,7 +1275,7 @@ }; var mockRepository = new MockRepository(); - var calculatorFactory = mockRepository.Stub(); + var calculatorFactory = mockRepository.StrictMock(); calculatorFactory.Expect(cf => cf.CreateOvertoppingCalculator(testDataPath)).Return(new TestOvertoppingCalculator()); calculatorFactory.Expect(cf => cf.CreateOvertoppingRateCalculator(testDataPath)).Return(overtoppingRateCalculator); mockRepository.ReplayAll(); @@ -1341,7 +1341,7 @@ Value = double.NaN, EndInFailure = true }; - var calculatorFactory = mockRepository.Stub(); + var calculatorFactory = mockRepository.StrictMock(); calculatorFactory.Expect(cf => cf.CreateOvertoppingCalculator(testDataPath)).Return(new TestOvertoppingCalculator()); calculatorFactory.Expect(cf => cf.CreateOvertoppingRateCalculator(testDataPath)).Return(overtoppingRateCalculator); mockRepository.ReplayAll(); @@ -1388,7 +1388,7 @@ var observerMock = mockRepository.StrictMock(); observerMock.Expect(o => o.UpdateObserver()); - var calculatorFactory = mockRepository.Stub(); + var calculatorFactory = mockRepository.StrictMock(); calculatorFactory.Expect(cf => cf.CreateOvertoppingCalculator(testDataPath)).Return(new TestOvertoppingCalculator()); calculatorFactory.Expect(cf => cf.CreateOvertoppingRateCalculator(testDataPath)).Return(new TestHydraulicLoadsCalculator()); mockRepository.ReplayAll();