Index: Ringtoets/Integration/test/Ringtoets.Integration.Forms.Test/Views/DesignWaterLevelLocationsViewTest.cs =================================================================== diff -u -r0ce4c68a5285d7596b108dc1b42693970961bd50 -r2d014f7589947c4c9e34140b42687e496ee04c5f --- Ringtoets/Integration/test/Ringtoets.Integration.Forms.Test/Views/DesignWaterLevelLocationsViewTest.cs (.../DesignWaterLevelLocationsViewTest.cs) (revision 0ce4c68a5285d7596b108dc1b42693970961bd50) +++ Ringtoets/Integration/test/Ringtoets.Integration.Forms.Test/Views/DesignWaterLevelLocationsViewTest.cs (.../DesignWaterLevelLocationsViewTest.cs) (revision 2d014f7589947c4c9e34140b42687e496ee04c5f) @@ -19,7 +19,6 @@ // Stichting Deltares and remain full property of Stichting Deltares at all times. // All rights reserved. -using System; using System.Collections.Generic; using System.Globalization; using System.Linq; @@ -35,14 +34,13 @@ using Ringtoets.Common.Data.TestUtil; using Ringtoets.Common.Data.TestUtil.IllustrationPoints; using Ringtoets.Common.Forms.GuiServices; +using Ringtoets.Common.Forms.TestUtil; using Ringtoets.Common.Forms.Views; using Ringtoets.Common.Service.MessageProviders; -using Ringtoets.Integration.Data; using Ringtoets.Integration.Forms.PresentationObjects; using Ringtoets.Integration.Forms.Views; using Ringtoets.Integration.Service.MessageProviders; using Button = System.Windows.Forms.Button; -using Control = System.Windows.Forms.Control; namespace Ringtoets.Integration.Forms.Test.Views { @@ -70,10 +68,10 @@ } [Test] - public void DefaultConstructor_DefaultValues() + public void Constructor_ExpectedValues() { // Call - using (var view = new DesignWaterLevelLocationsView(new AssessmentSection(AssessmentSectionComposition.Dike))) + using (var view = new DesignWaterLevelLocationsView(new ObservableTestAssessmentSectionStub())) { // Assert Assert.IsInstanceOf(view); @@ -87,7 +85,7 @@ // Given DesignWaterLevelLocationsView view = ShowFullyConfiguredDesignWaterLevelLocationsView(); - DataGridView dataGridView = GetDataGridView(); + DataGridView dataGridView = ControlTestHelper.GetDataGridView(testForm, "DataGridView"); DataGridViewRow currentRow = dataGridView.Rows[1]; HydraulicBoundaryLocation location = ((HydraulicBoundaryLocationRow)currentRow.DataBoundItem).CalculatableObject; @@ -105,7 +103,7 @@ public void Selection_WithoutLocations_ReturnsNull() { // Call - using (var view = new DesignWaterLevelLocationsView(new AssessmentSection(AssessmentSectionComposition.Dike))) + using (var view = new DesignWaterLevelLocationsView(new ObservableTestAssessmentSectionStub())) { // Assert Assert.IsNull(view.Selection); @@ -117,8 +115,8 @@ { // Setup ShowFullyConfiguredDesignWaterLevelLocationsView(); - IllustrationPointsControl illustrationPointsControl = GetIllustrationPointsControl(); - DataGridViewControl dataGridView = GetDataGridViewControl(); + IllustrationPointsControl illustrationPointsControl = ControlTestHelper.GetControls(testForm, "IllustrationPointsControl").First(); + DataGridViewControl dataGridView = ControlTestHelper.GetDataGridViewControl(testForm, "DataGridViewControl"); // Call dataGridView.SetCurrentCell(dataGridView.GetCell(0, 1)); @@ -132,8 +130,8 @@ { // Setup ShowFullyConfiguredDesignWaterLevelLocationsView(); - IllustrationPointsControl illustrationPointsControl = GetIllustrationPointsControl(); - DataGridViewControl dataGridView = GetDataGridViewControl(); + IllustrationPointsControl illustrationPointsControl = ControlTestHelper.GetControls(testForm, "IllustrationPointsControl").First(); + DataGridViewControl dataGridView = ControlTestHelper.GetDataGridViewControl(testForm, "DataGridViewControl"); // Call dataGridView.SetCurrentCell(dataGridView.GetCell(1, 0)); @@ -147,9 +145,9 @@ { // Setup ShowFullyConfiguredDesignWaterLevelLocationsView(); - IllustrationPointsControl illustrationPointsControl = GetIllustrationPointsControl(); + IllustrationPointsControl illustrationPointsControl = ControlTestHelper.GetControls(testForm, "IllustrationPointsControl").First(); - DataGridViewControl dataGridView = GetDataGridViewControl(); + DataGridViewControl dataGridView = ControlTestHelper.GetDataGridViewControl(testForm, "DataGridViewControl"); // Call dataGridView.SetCurrentCell(dataGridView.GetCell(4, 0)); @@ -162,10 +160,10 @@ public void Constructor_DataGridViewCorrectlyInitialized() { // Setup & Call - ShowDesignWaterLevelLocationsView(new AssessmentSection(AssessmentSectionComposition.Dike)); + ShowDesignWaterLevelLocationsView(new ObservableTestAssessmentSectionStub()); // Assert - DataGridView dataGridView = GetDataGridView(); + DataGridView dataGridView = ControlTestHelper.GetDataGridView(testForm, "DataGridView"); Assert.AreEqual(6, dataGridView.ColumnCount); var locationCalculateColumn = (DataGridViewCheckBoxColumn) dataGridView.Columns[locationCalculateColumnIndex]; @@ -197,7 +195,7 @@ ShowFullyConfiguredDesignWaterLevelLocationsView(); // Assert - DataGridViewControl dataGridView = GetDataGridViewControl(); + DataGridViewControl dataGridView = ControlTestHelper.GetDataGridViewControl(testForm, "DataGridViewControl"); DataGridViewRowCollection rows = dataGridView.Rows; Assert.AreEqual(5, rows.Count); @@ -268,7 +266,7 @@ newHydraulicBoundaryDatabase.Locations.Add(hydraulicBoundaryLocation); // Precondition - DataGridViewControl dataGridView = GetDataGridViewControl(); + DataGridViewControl dataGridView = ControlTestHelper.GetDataGridViewControl(testForm, "DataGridViewControl"); DataGridViewRowCollection rows = dataGridView.Rows; Assert.AreEqual(5, rows.Count); @@ -297,7 +295,7 @@ IAssessmentSection assessmentSection = view.AssessmentSection; // Precondition - DataGridView dataGridView = GetDataGridView(); + DataGridView dataGridView = ControlTestHelper.GetDataGridView(testForm, "DataGridView"); DataGridViewRowCollection rows = dataGridView.Rows; Assert.AreEqual(5, rows.Count); Assert.AreEqual("-", rows[0].Cells[locationDesignWaterlevelColumnIndex].FormattedValue); @@ -332,7 +330,7 @@ // Setup DesignWaterLevelLocationsView view = ShowFullyConfiguredDesignWaterLevelLocationsView(); IAssessmentSection assessmentSection = view.AssessmentSection; - DataGridViewControl dataGridView = GetDataGridViewControl(); + DataGridViewControl dataGridView = ControlTestHelper.GetDataGridViewControl(testForm, "DataGridViewControl"); DataGridViewRowCollection rows = dataGridView.Rows; rows[0].Cells[locationCalculateColumnIndex].Value = true; @@ -379,7 +377,7 @@ // Setup ShowFullyConfiguredDesignWaterLevelLocationsView(); - DataGridViewControl dataGridView = GetDataGridViewControl(); + DataGridViewControl dataGridView = ControlTestHelper.GetDataGridViewControl(testForm, "DataGridViewControl"); DataGridViewRowCollection rows = dataGridView.Rows; rows[0].Cells[locationCalculateColumnIndex].Value = true; @@ -397,8 +395,8 @@ { // Setup DesignWaterLevelLocationsView view = ShowFullyConfiguredDesignWaterLevelLocationsView(); - IllustrationPointsControl illustrationPointsControl = GetIllustrationPointsControl(); - DataGridViewControl dataGridView = GetDataGridViewControl(); + IllustrationPointsControl illustrationPointsControl = ControlTestHelper.GetControls(testForm, "IllustrationPointsControl").First(); + DataGridViewControl dataGridView = ControlTestHelper.GetDataGridViewControl(testForm, "DataGridViewControl"); dataGridView.SetCurrentCell(dataGridView.GetCell(3, 0)); @@ -417,32 +415,6 @@ Assert.AreSame(result, illustrationPointsControl.Data); } - private DataGridViewControl GetDataGridViewControl() - { - return GetControls("DataGridViewControl").Single(); - } - - private DataGridView GetDataGridView() - { - return GetControls("DataGridView").First(); - } - - private IllustrationPointsControl GetIllustrationPointsControl() - { - return GetControls("IllustrationPointsControl").Single(); - } - - /// - /// Gets the controls by name. - /// - /// The name of the controls to find. - /// The found control. - /// Thrown when is null or empty. - private IEnumerable GetControls(string controlName) where TView : Control - { - return testForm.Controls.Find(controlName, true).OfType(); - } - private DesignWaterLevelLocationsView ShowDesignWaterLevelLocationsView(IAssessmentSection assessmentSection) { var view = new DesignWaterLevelLocationsView(assessmentSection);