Index: Ringtoets/Piping/test/Ringtoets.Piping.Data.Test/PipingSoilProfileTest.cs =================================================================== diff -u -r1b6b6e221ac583d9d24ec033972acf73ffe30c56 -r24145cb7feea063e2986e8f4b2270bb2a478b3fd --- Ringtoets/Piping/test/Ringtoets.Piping.Data.Test/PipingSoilProfileTest.cs (.../PipingSoilProfileTest.cs) (revision 1b6b6e221ac583d9d24ec033972acf73ffe30c56) +++ Ringtoets/Piping/test/Ringtoets.Piping.Data.Test/PipingSoilProfileTest.cs (.../PipingSoilProfileTest.cs) (revision 24145cb7feea063e2986e8f4b2270bb2a478b3fd) @@ -171,7 +171,19 @@ } [Test] - [TestCase(null)] + public void ToString_WithNullName_ReturnsStringEmpty() + { + // Setup + var profile = new PipingSoilProfile(null, 0.0, new[] + { + new PipingSoilLayer(0.0) + }, SoilProfileType.SoilProfile1D, 0); + + // Call & Assert + Assert.IsEmpty(profile.ToString()); + } + + [Test] [TestCase("")] [TestCase("some name")] public void ToString_WithName_ReturnsName(string name) @@ -187,14 +199,30 @@ } [Test] + public void Equals_Null_ReturnsFalse() + { + // Setup + var profile = new PipingSoilProfile("name", 0, new[] { + CreateRandomLayer(new Random(21))}, SoilProfileType.SoilProfile1D, -1); + + // Call + var areEqual = profile.Equals(null); + + // Assert + Assert.IsFalse(areEqual); + } + + [Test] [TestCaseSource(nameof(ProfileCombinations))] public void Equals_DifferentScenarios_ReturnsExpectedResult(PipingSoilProfile profile, PipingSoilProfile otherProfile, bool expectedEqual) { // Call - var areEqual = profile.Equals(otherProfile); + var areEqualOne = profile.Equals(otherProfile); + var areEqualTwo = otherProfile.Equals(profile); // Assert - Assert.AreEqual(expectedEqual, areEqual); + Assert.AreEqual(expectedEqual, areEqualOne); + Assert.AreEqual(expectedEqual, areEqualTwo); } private static TestCaseData[] ProfileCombinations() @@ -222,19 +250,14 @@ CreateRandomLayer(random) }, random.NextEnumValue(), random.Next()); - - return new[] { - new TestCaseData(profileA, profileA, true) { TestName = "Equals_ProfileAProfileA_True"}, new TestCaseData(profileA, profileB, true) { TestName = "Equals_ProfileAProfileB_True"}, new TestCaseData(profileB, profileC, false) { TestName = "Equals_ProfileBProfileC_False"}, - new TestCaseData(profileC, profileC, true) { TestName = "Equals_ProfileCProfileC_True"}, new TestCaseData(profileD, profileE, false) { TestName = "Equals_ProfileDProfileE_False"}, new TestCaseData(profileD, profileF, false) { TestName = "Equals_ProfileDProfileF_False"}, new TestCaseData(profileD, profileG, false) { TestName = "Equals_ProfileDProfileG_False"}, new TestCaseData(profileH, profileI, false) { TestName = "Equals_ProfileHProfileI_False"}, - new TestCaseData(profileI, profileH, false) { TestName = "Equals_ProfileHProfileI_False"}, }; } @@ -251,7 +274,7 @@ { layers.Add(CreateRandomLayer(random)); } - return new PipingSoilProfile(GetRandomName(random), -random.NextDouble(), layers, random.NextEnumValue(), random.Next()); + return new PipingSoilProfile(GetRandomName(random), -1.0 - random.NextDouble(), layers, random.NextEnumValue(), random.Next()); } private static PipingSoilLayer CreateRandomLayer(Random random)