Index: Ringtoets/Piping/test/Ringtoets.Piping.Service.Test/PipingCalculationActivityTest.cs =================================================================== diff -u -r1b61e079b5ce825f3966ecac688d65e9ff567237 -rbd3005f6e588e9dabb067acd8b61a3682c43970c --- Ringtoets/Piping/test/Ringtoets.Piping.Service.Test/PipingCalculationActivityTest.cs (.../PipingCalculationActivityTest.cs) (revision 1b61e079b5ce825f3966ecac688d65e9ff567237) +++ Ringtoets/Piping/test/Ringtoets.Piping.Service.Test/PipingCalculationActivityTest.cs (.../PipingCalculationActivityTest.cs) (revision bd3005f6e588e9dabb067acd8b61a3682c43970c) @@ -29,6 +29,7 @@ using NUnit.Framework; using Rhino.Mocks; using Ringtoets.Common.Data.TestUtil; +using Ringtoets.Common.Service; using Ringtoets.Common.Service.TestUtil; using Ringtoets.Piping.Data; using Ringtoets.Piping.Data.TestUtil; @@ -49,32 +50,17 @@ RoundedDouble.NaN); // Assert - Assert.IsInstanceOf(activity); + Assert.IsInstanceOf(activity); Assert.AreEqual($"Uitvoeren van berekening '{calculation.Name}'", activity.Description); Assert.IsNull(activity.ProgressText); Assert.AreEqual(ActivityState.None, activity.State); } [Test] - public void Constructor_CalculationNull_ThrowsArgumentNullException() + public void Run_InvalidPipingCalculation_LogValidationStartAndEndWithErrors() { - // Call - TestDelegate call = () => new PipingCalculationActivity(null, - RoundedDouble.NaN); - - // Assert - var exception = Assert.Throws(call); - Assert.AreEqual("calculation", exception.ParamName); - } - - [Test] - public void Run_InvalidPipingCalculationWithOutput_LogValidationStartAndEndWithErrors() - { // Setup - PipingOutput originalOutput = PipingOutputTestFactory.Create(); - PipingCalculationScenario invalidPipingCalculation = PipingCalculationScenarioTestFactory.CreatePipingCalculationScenarioWithInvalidInput(); - invalidPipingCalculation.Output = originalOutput; var activity = new PipingCalculationActivity(invalidPipingCalculation, AssessmentSectionHelper.GetTestAssessmentLevel()); @@ -99,19 +85,16 @@ CalculationServiceTestHelper.AssertValidationEndMessage(msgs[7]); }); Assert.AreEqual(ActivityState.Failed, activity.State); - Assert.AreSame(originalOutput, invalidPipingCalculation.Output); } [Test] public void Run_ValidPipingCalculation_PerformPipingValidationAndCalculationAndLogStartAndEnd() { // Setup PipingCalculationScenario validPipingCalculation = PipingCalculationScenarioTestFactory.CreatePipingCalculationScenarioWithValidInput(new TestHydraulicBoundaryLocation()); - validPipingCalculation.Output = null; var activity = new PipingCalculationActivity(validPipingCalculation, AssessmentSectionHelper.GetTestAssessmentLevel()); - activity.Run(); // Call Action call = () => activity.Run();