Index: Ringtoets/WaveImpactAsphaltCover/test/Ringtoets.WaveImpactAsphaltCover.Integration.Test/WaveImpactAsphaltCoverWaveConditionsCalculationActivityIntegrationTest.cs =================================================================== diff -u -r9a62e7ebcbf96a0455143740fc883704b2cc6eea -rf8f4f06311e58fd749631bdb933d8f8468ce56f8 --- Ringtoets/WaveImpactAsphaltCover/test/Ringtoets.WaveImpactAsphaltCover.Integration.Test/WaveImpactAsphaltCoverWaveConditionsCalculationActivityIntegrationTest.cs (.../WaveImpactAsphaltCoverWaveConditionsCalculationActivityIntegrationTest.cs) (revision 9a62e7ebcbf96a0455143740fc883704b2cc6eea) +++ Ringtoets/WaveImpactAsphaltCover/test/Ringtoets.WaveImpactAsphaltCover.Integration.Test/WaveImpactAsphaltCoverWaveConditionsCalculationActivityIntegrationTest.cs (.../WaveImpactAsphaltCoverWaveConditionsCalculationActivityIntegrationTest.cs) (revision f8f4f06311e58fd749631bdb933d8f8468ce56f8) @@ -586,25 +586,15 @@ } [Test] - [TestCaseSource(typeof(HydraRingCalculatorTestCaseProvider), nameof(HydraRingCalculatorTestCaseProvider.GetCalculatorFailingConditions), new object[] + public void Finish_ValidCalculation_NotifiesObserversOfCalculation() { - nameof(Finish_InvalidCalculation_DoesNotSetOutputAndNotifyObservers) - })] - public void Finish_InvalidCalculation_DoesNotSetOutputAndNotifyObservers(bool endInFailure, - string lastErrorFileContent) - { // Setup var mockRepository = new MockRepository(); var observer = mockRepository.StrictMock(); observer.Expect(o => o.UpdateObserver()); - var calculator = new TestWaveConditionsCosineCalculator - { - EndInFailure = endInFailure, - LastErrorFileContent = lastErrorFileContent - }; var calculatorFactory = mockRepository.StrictMock(); - calculatorFactory.Expect(cf => cf.CreateWaveConditionsCosineCalculator(testDataPath, string.Empty)).Return(calculator).Repeat.Times(3); + calculatorFactory.Expect(cf => cf.CreateWaveConditionsCosineCalculator(testDataPath, string.Empty)).Return(new TestWaveConditionsCosineCalculator()).Repeat.Times(3); mockRepository.ReplayAll(); IAssessmentSection assessmentSection = CreateAssessmentSectionWithHydraulicBoundaryOutput(); @@ -627,56 +617,9 @@ activity.Finish(); // Assert - Assert.IsNull(calculation.Output); mockRepository.VerifyAll(); } - [Test] - public void Finish_ValidCalculation_SetsOutputAndNotifyObserversOfCalculation() - { - // Setup - var mockRepository = new MockRepository(); - var observer = mockRepository.StrictMock(); - observer.Expect(o => o.UpdateObserver()); - - var calculatorFactory = mockRepository.StrictMock(); - var waveConditionsCosineCalculator = new TestWaveConditionsCosineCalculator - { - WaveHeight = new Random(39).NextDouble() - }; - calculatorFactory.Expect(cf => cf.CreateWaveConditionsCosineCalculator(testDataPath, string.Empty)).Return(waveConditionsCosineCalculator).Repeat.Times(3); - mockRepository.ReplayAll(); - - IAssessmentSection assessmentSection = CreateAssessmentSectionWithHydraulicBoundaryOutput(); - - WaveImpactAsphaltCoverWaveConditionsCalculation calculation = CreateValidCalculation(assessmentSection.HydraulicBoundaryDatabase.Locations.First()); - - calculation.Attach(observer); - - CalculatableActivity activity = WaveImpactAsphaltCoverWaveConditionsCalculationActivityFactory.CreateCalculationActivity( - calculation, - new WaveImpactAsphaltCoverFailureMechanism(), - assessmentSection); - - using (new HydraRingCalculatorFactoryConfig(calculatorFactory)) - { - activity.Run(); - } - - // Call - activity.Finish(); - - // Assert - Assert.IsNotNull(calculation.Output); - Assert.AreEqual(3, calculation.Output.Items.Count()); - foreach (WaveConditionsOutput waveConditionsOutput in calculation.Output.Items) - { - Assert.AreEqual(waveConditionsCosineCalculator.WaveHeight, waveConditionsOutput.WaveHeight, waveConditionsOutput.WaveHeight.GetAccuracy()); - } - - mockRepository.VerifyAll(); - } - private static WaveImpactAsphaltCoverWaveConditionsCalculation CreateValidCalculation(HydraulicBoundaryLocation hydraulicBoundaryLocation) { return new WaveImpactAsphaltCoverWaveConditionsCalculation