Index: Ringtoets/WaveImpactAsphaltCover/test/Ringtoets.WaveImpactAsphaltCover.Plugin.Test/TreeNodeInfos/WaveImpactAsphaltCoverWaveConditionsCalculationGroupContextTreeNodeInfoTest.cs =================================================================== diff -u -r80c49f33c35b73d7778f8beded83ad330208e690 -r708e9cf90cb58b98f95bdab8cdf5a3a17a1b27a6 --- Ringtoets/WaveImpactAsphaltCover/test/Ringtoets.WaveImpactAsphaltCover.Plugin.Test/TreeNodeInfos/WaveImpactAsphaltCoverWaveConditionsCalculationGroupContextTreeNodeInfoTest.cs (.../WaveImpactAsphaltCoverWaveConditionsCalculationGroupContextTreeNodeInfoTest.cs) (revision 80c49f33c35b73d7778f8beded83ad330208e690) +++ Ringtoets/WaveImpactAsphaltCover/test/Ringtoets.WaveImpactAsphaltCover.Plugin.Test/TreeNodeInfos/WaveImpactAsphaltCoverWaveConditionsCalculationGroupContextTreeNodeInfoTest.cs (.../WaveImpactAsphaltCoverWaveConditionsCalculationGroupContextTreeNodeInfoTest.cs) (revision 708e9cf90cb58b98f95bdab8cdf5a3a17a1b27a6) @@ -84,6 +84,8 @@ private WaveImpactAsphaltCoverPlugin plugin; private TreeNodeInfo info; + private readonly string validFilePath = TestHelper.GetTestDataPath(TestDataPath.Ringtoets.Integration.Service, Path.Combine("HydraRingCalculation", "HRD ijsselmeer.sqlite")); + [Test] public void Initialized_Always_ExpectedPropertiesSet() { @@ -833,18 +835,18 @@ public void ContextMenuStrip_TwoCalculationsClickOnValidateAllInGroup_ValidationMessagesLogged() { // Setup - string hrdPath = TestHelper.GetTestDataPath(TestDataPath.Ringtoets.Integration.Service, "HydraRingCalculation"); - var failureMechanism = new WaveImpactAsphaltCoverFailureMechanism(); IAssessmentSection assessmentSection = AssessmentSectionHelper.CreateAssessmentSectionStub( - failureMechanism, mocks, Path.Combine(hrdPath, "HRD ijsselmeer.sqlite")); + failureMechanism, mocks, validFilePath); + HydraulicBoundaryLocation hydraulicBoundaryLocation = assessmentSection.HydraulicBoundaryDatabase.Locations.First(); + var calculationA = new WaveImpactAsphaltCoverWaveConditionsCalculation { Name = "A", InputParameters = { - HydraulicBoundaryLocation = CreateHydraulicBoundaryLocationWithNormativeOutput(), + HydraulicBoundaryLocation = hydraulicBoundaryLocation, LowerBoundaryRevetment = (RoundedDouble) 1.0, UpperBoundaryRevetment = (RoundedDouble) 10.0, StepSize = WaveConditionsInputStepSize.One, @@ -859,7 +861,7 @@ Name = "B", InputParameters = { - HydraulicBoundaryLocation = CreateHydraulicBoundaryLocationWithNormativeOutput(), + HydraulicBoundaryLocation = hydraulicBoundaryLocation, LowerBoundaryRevetment = (RoundedDouble) 1.0, UpperBoundaryRevetment = (RoundedDouble) 10.0, StepSize = WaveConditionsInputStepSize.One, @@ -914,14 +916,20 @@ public void ValidateAllViaContextMenuStrip_HydraulicBoundaryDatabaseWithCanUsePreprocessorFalse_NoValidationErrorsLogged() { // Setup - string hrdPath = TestHelper.GetTestDataPath(TestDataPath.Ringtoets.Integration.Service, "HydraRingCalculation"); + var failureMechanism = new WaveImpactAsphaltCoverFailureMechanism + { + Contribution = 5 + }; + IAssessmentSection assessmentSection = AssessmentSectionHelper.CreateAssessmentSectionStub( + failureMechanism, mocks, validFilePath); + var calculation = new WaveImpactAsphaltCoverWaveConditionsCalculation { Name = "A", InputParameters = { - HydraulicBoundaryLocation = CreateHydraulicBoundaryLocationWithNormativeOutput(), + HydraulicBoundaryLocation = assessmentSection.HydraulicBoundaryDatabase.Locations.First(), LowerBoundaryRevetment = (RoundedDouble) 1.0, UpperBoundaryRevetment = (RoundedDouble) 10.0, StepSize = WaveConditionsInputStepSize.One, @@ -934,15 +942,8 @@ var group = new CalculationGroup(); group.Children.Add(calculation); - var failureMechanism = new WaveImpactAsphaltCoverFailureMechanism - { - Contribution = 5 - }; failureMechanism.WaveConditionsCalculationGroup.Children.Add(group); - IAssessmentSection assessmentSection = AssessmentSectionHelper.CreateAssessmentSectionStub( - failureMechanism, mocks, Path.Combine(hrdPath, "HRD ijsselmeer.sqlite")); - var nodeData = new WaveImpactAsphaltCoverWaveConditionsCalculationGroupContext(group, failureMechanism.WaveConditionsCalculationGroup, failureMechanism, @@ -981,14 +982,20 @@ public void ValidateAllViaContextMenuStrip_HydraulicBoundaryDatabaseWithUsePreprocessorFalse_NoValidationErrorsLogged() { // Setup - string hrdPath = TestHelper.GetTestDataPath(TestDataPath.Ringtoets.Integration.Service, "HydraRingCalculation"); + var failureMechanism = new WaveImpactAsphaltCoverFailureMechanism + { + Contribution = 5 + }; + IAssessmentSection assessmentSection = AssessmentSectionHelper.CreateAssessmentSectionStub( + failureMechanism, mocks, validFilePath); + var calculation = new WaveImpactAsphaltCoverWaveConditionsCalculation { Name = "A", InputParameters = { - HydraulicBoundaryLocation = CreateHydraulicBoundaryLocationWithNormativeOutput(), + HydraulicBoundaryLocation = assessmentSection.HydraulicBoundaryDatabase.Locations.First(), LowerBoundaryRevetment = (RoundedDouble) 1.0, UpperBoundaryRevetment = (RoundedDouble) 10.0, StepSize = WaveConditionsInputStepSize.One, @@ -1001,15 +1008,8 @@ var group = new CalculationGroup(); group.Children.Add(calculation); - var failureMechanism = new WaveImpactAsphaltCoverFailureMechanism - { - Contribution = 5 - }; failureMechanism.WaveConditionsCalculationGroup.Children.Add(group); - IAssessmentSection assessmentSection = AssessmentSectionHelper.CreateAssessmentSectionStub( - failureMechanism, mocks, Path.Combine(hrdPath, "HRD ijsselmeer.sqlite")); - assessmentSection.HydraulicBoundaryDatabase.CanUsePreprocessor = true; assessmentSection.HydraulicBoundaryDatabase.UsePreprocessor = false; assessmentSection.HydraulicBoundaryDatabase.PreprocessorDirectory = "InvalidPreprocessorDirectory"; @@ -1052,14 +1052,20 @@ public void ValidateAllViaContextMenuStrip_HydraulicBoundaryDatabaseWithUsePreprocessorTrue_NoValidationErrorsLogged() { // Setup - string hrdPath = TestHelper.GetTestDataPath(TestDataPath.Ringtoets.Integration.Service, "HydraRingCalculation"); + var failureMechanism = new WaveImpactAsphaltCoverFailureMechanism + { + Contribution = 5 + }; + IAssessmentSection assessmentSection = AssessmentSectionHelper.CreateAssessmentSectionStub( + failureMechanism, mocks, validFilePath); + var calculation = new WaveImpactAsphaltCoverWaveConditionsCalculation { Name = "A", InputParameters = { - HydraulicBoundaryLocation = CreateHydraulicBoundaryLocationWithNormativeOutput(), + HydraulicBoundaryLocation = assessmentSection.HydraulicBoundaryDatabase.Locations.First(), LowerBoundaryRevetment = (RoundedDouble) 1.0, UpperBoundaryRevetment = (RoundedDouble) 10.0, StepSize = WaveConditionsInputStepSize.One, @@ -1072,15 +1078,8 @@ var group = new CalculationGroup(); group.Children.Add(calculation); - var failureMechanism = new WaveImpactAsphaltCoverFailureMechanism - { - Contribution = 5 - }; failureMechanism.WaveConditionsCalculationGroup.Children.Add(group); - IAssessmentSection assessmentSection = AssessmentSectionHelper.CreateAssessmentSectionStub( - failureMechanism, mocks, Path.Combine(hrdPath, "HRD ijsselmeer.sqlite")); - assessmentSection.HydraulicBoundaryDatabase.CanUsePreprocessor = true; assessmentSection.HydraulicBoundaryDatabase.UsePreprocessor = true; assessmentSection.HydraulicBoundaryDatabase.PreprocessorDirectory = TestHelper.GetScratchPadPath(); @@ -1123,14 +1122,20 @@ public void ValidateAllViaContextMenuStrip_HydraulicBoundaryDatabaseWithUsePreprocessorTrue_ValidationErrorsLogged() { // Setup - string hrdPath = TestHelper.GetTestDataPath(TestDataPath.Ringtoets.Integration.Service, "HydraRingCalculation"); + var failureMechanism = new WaveImpactAsphaltCoverFailureMechanism + { + Contribution = 5 + }; + IAssessmentSection assessmentSection = AssessmentSectionHelper.CreateAssessmentSectionStub( + failureMechanism, mocks, validFilePath); + var calculation = new WaveImpactAsphaltCoverWaveConditionsCalculation { Name = "A", InputParameters = { - HydraulicBoundaryLocation = CreateHydraulicBoundaryLocationWithNormativeOutput(), + HydraulicBoundaryLocation = assessmentSection.HydraulicBoundaryDatabase.Locations.First(), LowerBoundaryRevetment = (RoundedDouble) 1.0, UpperBoundaryRevetment = (RoundedDouble) 10.0, StepSize = WaveConditionsInputStepSize.One, @@ -1143,15 +1148,8 @@ var group = new CalculationGroup(); group.Children.Add(calculation); - var failureMechanism = new WaveImpactAsphaltCoverFailureMechanism - { - Contribution = 5 - }; failureMechanism.WaveConditionsCalculationGroup.Children.Add(group); - IAssessmentSection assessmentSection = AssessmentSectionHelper.CreateAssessmentSectionStub( - failureMechanism, mocks, Path.Combine(hrdPath, "HRD ijsselmeer.sqlite")); - assessmentSection.HydraulicBoundaryDatabase.CanUsePreprocessor = true; assessmentSection.HydraulicBoundaryDatabase.UsePreprocessor = true; assessmentSection.HydraulicBoundaryDatabase.PreprocessorDirectory = "InvalidPreprocessorDirectory"; @@ -1195,21 +1193,21 @@ public void ContextMenuStrip_TwoCalculationsClickOnCalculateAllInGroup_MessagesLogged() { // Setup - string hrdPath = TestHelper.GetTestDataPath(TestDataPath.Ringtoets.Integration.Service, "HydraRingCalculation"); - var failureMechanism = new WaveImpactAsphaltCoverFailureMechanism(); IAssessmentSection assessmentSection = AssessmentSectionHelper.CreateAssessmentSectionStub( - failureMechanism, mocks, Path.Combine(hrdPath, "HRD ijsselmeer.sqlite")); + failureMechanism, mocks, validFilePath); var observerA = mocks.StrictMock(); observerA.Expect(o => o.UpdateObserver()); var observerB = mocks.StrictMock(); observerB.Expect(o => o.UpdateObserver()); + HydraulicBoundaryLocation hydraulicBoundaryLocation = assessmentSection.HydraulicBoundaryDatabase.Locations.First(); + var group = new CalculationGroup(); - WaveImpactAsphaltCoverWaveConditionsCalculation calculationA = GetValidCalculation(); + WaveImpactAsphaltCoverWaveConditionsCalculation calculationA = GetValidCalculation(hydraulicBoundaryLocation); calculationA.Name = "A"; - WaveImpactAsphaltCoverWaveConditionsCalculation calculationB = GetValidCalculation(); + WaveImpactAsphaltCoverWaveConditionsCalculation calculationB = GetValidCalculation(hydraulicBoundaryLocation); calculationB.Name = "B"; calculationA.Attach(observerA); calculationB.Attach(observerB); @@ -1242,7 +1240,7 @@ .Cast() .Sum(c => c.InputParameters.GetWaterLevels(assessmentSection.GetNormativeAssessmentLevel(c.InputParameters.HydraulicBoundaryLocation)).Count()); var calculatorFactory = mocks.Stub(); - calculatorFactory.Expect(cf => cf.CreateWaveConditionsCosineCalculator(hrdPath, string.Empty)) + calculatorFactory.Expect(cf => cf.CreateWaveConditionsCosineCalculator(Path.GetDirectoryName(validFilePath), string.Empty)) .Return(new TestWaveConditionsCosineCalculator()) .Repeat .Times(nrOfCalculators); @@ -1278,11 +1276,9 @@ public void ContextMenuStrip_NoCalculations_ClearAllOutputItemDisabled() { // Setup - string hrdPath = TestHelper.GetTestDataPath(TestDataPath.Ringtoets.Integration.Service, "HydraRingCalculation"); - var failureMechanism = new WaveImpactAsphaltCoverFailureMechanism(); IAssessmentSection assessmentSection = AssessmentSectionHelper.CreateAssessmentSectionStub( - failureMechanism, mocks, Path.Combine(hrdPath, "HRD ijsselmeer.sqlite")); + failureMechanism, mocks, validFilePath); var group = new CalculationGroup(); @@ -1322,15 +1318,15 @@ public void ContextMenuStrip_TwoCalculationsWithoutOutput_ClearAllOutputItemDisabled() { // Setup - string hrdPath = TestHelper.GetTestDataPath(TestDataPath.Ringtoets.Integration.Service, "HydraRingCalculation"); - var failureMechanism = new WaveImpactAsphaltCoverFailureMechanism(); IAssessmentSection assessmentSection = AssessmentSectionHelper.CreateAssessmentSectionStub( - failureMechanism, mocks, Path.Combine(hrdPath, "HRD ijsselmeer.sqlite")); + failureMechanism, mocks, validFilePath); + HydraulicBoundaryLocation hydraulicBoundaryLocation = assessmentSection.HydraulicBoundaryDatabase.Locations.First(); + var group = new CalculationGroup(); - WaveImpactAsphaltCoverWaveConditionsCalculation calculationA = GetValidCalculation(); - WaveImpactAsphaltCoverWaveConditionsCalculation calculationB = GetValidCalculation(); + WaveImpactAsphaltCoverWaveConditionsCalculation calculationA = GetValidCalculation(hydraulicBoundaryLocation); + WaveImpactAsphaltCoverWaveConditionsCalculation calculationB = GetValidCalculation(hydraulicBoundaryLocation); group.Children.Add(calculationA); group.Children.Add(calculationB); @@ -1372,11 +1368,9 @@ public void ContextMenuStrip_TwoCalculationsWithOutputClickOnClearAllOutput_OutputRemovedForCalculationsAfterConfirmation(bool confirm) { // Setup - string hrdPath = TestHelper.GetTestDataPath(TestDataPath.Ringtoets.Integration.Service, "HydraRingCalculation"); - var failureMechanism = new WaveImpactAsphaltCoverFailureMechanism(); IAssessmentSection assessmentSection = AssessmentSectionHelper.CreateAssessmentSectionStub( - failureMechanism, mocks, Path.Combine(hrdPath, "HRD ijsselmeer.sqlite")); + failureMechanism, mocks, validFilePath); var observerA = mocks.StrictMock(); var observerB = mocks.StrictMock(); @@ -1386,10 +1380,12 @@ observerB.Expect(o => o.UpdateObserver()); } + HydraulicBoundaryLocation hydraulicBoundaryLocation = assessmentSection.HydraulicBoundaryDatabase.Locations.First(); + var group = new CalculationGroup(); - WaveImpactAsphaltCoverWaveConditionsCalculation calculationA = GetValidCalculation(); + WaveImpactAsphaltCoverWaveConditionsCalculation calculationA = GetValidCalculation(hydraulicBoundaryLocation); calculationA.Output = new WaveImpactAsphaltCoverWaveConditionsOutput(Enumerable.Empty()); - WaveImpactAsphaltCoverWaveConditionsCalculation calculationB = GetValidCalculation(); + WaveImpactAsphaltCoverWaveConditionsCalculation calculationB = GetValidCalculation(hydraulicBoundaryLocation); calculationB.Output = new WaveImpactAsphaltCoverWaveConditionsOutput(Enumerable.Empty()); group.Children.Add(calculationA); group.Children.Add(calculationB); @@ -1884,24 +1880,13 @@ base.TearDown(); } - private static TestHydraulicBoundaryLocation CreateHydraulicBoundaryLocationWithNormativeOutput() + private static WaveImpactAsphaltCoverWaveConditionsCalculation GetValidCalculation(HydraulicBoundaryLocation hydraulicBoundaryLocation) { - return new TestHydraulicBoundaryLocation - { - DesignWaterLevelCalculation3 = - { - Output = new TestHydraulicBoundaryLocationOutput(12) - } - }; - } - - private static WaveImpactAsphaltCoverWaveConditionsCalculation GetValidCalculation() - { return new WaveImpactAsphaltCoverWaveConditionsCalculation { InputParameters = { - HydraulicBoundaryLocation = CreateHydraulicBoundaryLocationWithNormativeOutput(), + HydraulicBoundaryLocation = hydraulicBoundaryLocation, ForeshoreProfile = new TestForeshoreProfile(true), UseForeshore = true, UseBreakWater = true,