Index: Core/Common/src/Core.Common.Base/Geometry/Point3DCollectionExtensions.cs =================================================================== diff -u -r569a286badd9b3494f5465cc2767a8cf6a77f618 -r00da0d2f72214f140bceff0eaae5f14172c587de --- Core/Common/src/Core.Common.Base/Geometry/Point3DCollectionExtensions.cs (.../Point3DCollectionExtensions.cs) (revision 569a286badd9b3494f5465cc2767a8cf6a77f618) +++ Core/Common/src/Core.Common.Base/Geometry/Point3DCollectionExtensions.cs (.../Point3DCollectionExtensions.cs) (revision 00da0d2f72214f140bceff0eaae5f14172c587de) @@ -38,20 +38,19 @@ /// Collection of 2D points in the LZ-plane. /// Thrown when /// is null. - public static IEnumerable ProjectToLz(this IEnumerable points) + public static IEnumerable ProjectToLZ(this IEnumerable points) { if (points == null) { throw new ArgumentNullException(nameof(points)); } - Point3D[] point3Ds = points.ToArray(); - int count = point3Ds.Length; + int count = points.Count(); if (count == 0) { return Enumerable.Empty(); } - Point3D first = point3Ds.First(); + Point3D first = points.First(); if (count == 1) { return new[] @@ -60,10 +59,10 @@ }; } - Point3D last = point3Ds.Last(); + Point3D last = points.Last(); var firstPoint = new Point2D(first.X, first.Y); var lastPoint = new Point2D(last.X, last.Y); - return point3Ds.Select(p => p.ProjectIntoLocalCoordinates(firstPoint, lastPoint)); + return points.Select(p => p.ProjectIntoLocalCoordinates(firstPoint, lastPoint)); } /// @@ -109,7 +108,7 @@ /// is null. public static bool IsReclining(this IEnumerable points) { - return points.ProjectToLz().IsReclining(); + return points.ProjectToLZ().IsReclining(); } } } \ No newline at end of file Index: Core/Common/test/Core.Common.Base.Test/Geometry/Point3DCollectionExtensionsTest.cs =================================================================== diff -u -r569a286badd9b3494f5465cc2767a8cf6a77f618 -r00da0d2f72214f140bceff0eaae5f14172c587de --- Core/Common/test/Core.Common.Base.Test/Geometry/Point3DCollectionExtensionsTest.cs (.../Point3DCollectionExtensionsTest.cs) (revision 569a286badd9b3494f5465cc2767a8cf6a77f618) +++ Core/Common/test/Core.Common.Base.Test/Geometry/Point3DCollectionExtensionsTest.cs (.../Point3DCollectionExtensionsTest.cs) (revision 00da0d2f72214f140bceff0eaae5f14172c587de) @@ -172,31 +172,31 @@ } [Test] - public void ProjectToLz_PointsNull_ThrowsArgumentNullException() + public void ProjectToLZ_PointsNull_ThrowsArgumentNullException() { // Call - TestDelegate test = () => ((IEnumerable) null).ProjectToLz(); + TestDelegate test = () => ((IEnumerable) null).ProjectToLZ(); // Assert var exception = Assert.Throws(test); Assert.AreEqual("points", exception.ParamName); } [Test] - public void ProjectToLz_EmptyCollection_ReturnEmptyCollection() + public void ProjectToLZ_EmptyCollection_ReturnEmptyCollection() { // Setup var points = new Point3D[0]; // Call - IEnumerable lzCoordinates = points.ProjectToLz(); + IEnumerable lzCoordinates = points.ProjectToLZ(); // Assert CollectionAssert.IsEmpty(lzCoordinates); } [Test] - public void ProjectToLz_GeometryWithOnePoint_ReturnSinglePointAtZeroXAndOriginalZ() + public void ProjectToLZ_GeometryWithOnePoint_ReturnSinglePointAtZeroXAndOriginalZ() { // Setup const double originalZ = 3.3; @@ -206,7 +206,7 @@ }; // Call - IEnumerable lzCoordinates = points.ProjectToLz(); + IEnumerable lzCoordinates = points.ProjectToLZ(); // Assert CollectionAssert.AreEqual(new[] @@ -216,7 +216,7 @@ } [Test] - public void ProjectToLz_GeometryWithMultiplePoints_ProjectPointsOntoLzPlaneKeepingOriginalZ() + public void ProjectToLZ_GeometryWithMultiplePoints_ProjectPointsOntoLZPlaneKeepingOriginalZ() { // Setup var points = new[] @@ -227,7 +227,7 @@ }; // Call - IEnumerable actual = points.ProjectToLz(); + IEnumerable actual = points.ProjectToLZ(); // Assert double length = Math.Sqrt(2 * 2 + 3 * 3); Index: Core/Common/test/Core.Common.Base.Test/Geometry/Point3DExtensionsTest.cs =================================================================== diff -u -r67284323e2785c651633d9c52049ba12a9c70e6a -r00da0d2f72214f140bceff0eaae5f14172c587de --- Core/Common/test/Core.Common.Base.Test/Geometry/Point3DExtensionsTest.cs (.../Point3DExtensionsTest.cs) (revision 67284323e2785c651633d9c52049ba12a9c70e6a) +++ Core/Common/test/Core.Common.Base.Test/Geometry/Point3DExtensionsTest.cs (.../Point3DExtensionsTest.cs) (revision 00da0d2f72214f140bceff0eaae5f14172c587de) @@ -120,7 +120,7 @@ } [Test] - public void ProjectIntoLocalCoordinates_GeometryWithMultiplePoints_ProjectPointsOntoLzPlaneKeepingOriginalZ() + public void ProjectIntoLocalCoordinates_GeometryWithMultiplePoints_ProjectPointsOntoLZPlaneKeepingOriginalZ() { // Setup var startPoint = new Point2D(1.0, 1.0); Index: Ringtoets/Common/src/Ringtoets.Common.Data/MechanismSurfaceLineBase.cs =================================================================== diff -u -r569a286badd9b3494f5465cc2767a8cf6a77f618 -r00da0d2f72214f140bceff0eaae5f14172c587de --- Ringtoets/Common/src/Ringtoets.Common.Data/MechanismSurfaceLineBase.cs (.../MechanismSurfaceLineBase.cs) (revision 569a286badd9b3494f5465cc2767a8cf6a77f618) +++ Ringtoets/Common/src/Ringtoets.Common.Data/MechanismSurfaceLineBase.cs (.../MechanismSurfaceLineBase.cs) (revision 00da0d2f72214f140bceff0eaae5f14172c587de) @@ -109,7 +109,7 @@ EndingWorldPoint = Points[Points.Length - 1]; } - LocalGeometry = new RoundedPoint2DCollection(numberOfDecimalPlaces, Points.ProjectToLz().ToArray()); + LocalGeometry = new RoundedPoint2DCollection(numberOfDecimalPlaces, Points.ProjectToLZ().ToArray()); } /// Index: Ringtoets/Common/src/Ringtoets.Common.IO/FileImporters/ProfilesImporter.cs =================================================================== diff -u -r4eaa942f6a986a04aacee22d1b8e142b0d07f389 -r00da0d2f72214f140bceff0eaae5f14172c587de --- Ringtoets/Common/src/Ringtoets.Common.IO/FileImporters/ProfilesImporter.cs (.../ProfilesImporter.cs) (revision 4eaa942f6a986a04aacee22d1b8e142b0d07f389) +++ Ringtoets/Common/src/Ringtoets.Common.IO/FileImporters/ProfilesImporter.cs (.../ProfilesImporter.cs) (revision 00da0d2f72214f140bceff0eaae5f14172c587de) @@ -271,7 +271,6 @@ var dikeProfileData = new Collection(); var dikeProfileDataReader = new DikeProfileDataReader(acceptedIds); - var errorOccured = false; for (var i = 0; i < totalNumberOfSteps; i++) { Index: Ringtoets/Common/src/Ringtoets.Common.IO/SurfaceLines/SurfaceLine.cs =================================================================== diff -u -r569a286badd9b3494f5465cc2767a8cf6a77f618 -r00da0d2f72214f140bceff0eaae5f14172c587de --- Ringtoets/Common/src/Ringtoets.Common.IO/SurfaceLines/SurfaceLine.cs (.../SurfaceLine.cs) (revision 569a286badd9b3494f5465cc2767a8cf6a77f618) +++ Ringtoets/Common/src/Ringtoets.Common.IO/SurfaceLines/SurfaceLine.cs (.../SurfaceLine.cs) (revision 00da0d2f72214f140bceff0eaae5f14172c587de) @@ -79,7 +79,7 @@ { throw new ArgumentException(Resources.SurfaceLine_SetGeometry_SurfaceLine_has_zero_length); } - if (new RoundedPoint2DCollection(2, points.ProjectToLz()).IsReclining()) + if (new RoundedPoint2DCollection(2, points.ProjectToLZ()).IsReclining()) { throw new ArgumentException(Resources.SurfaceLine_SetGeometry_SurfaceLine_has_reclining_geometry); } Index: Ringtoets/Common/test/Ringtoets.Common.Data.TestUtil/TestCalculationWithForeshoreProfile.cs =================================================================== diff -u -r6ef5e439a6d9f40ebd9926251945e0935fbbc314 -r00da0d2f72214f140bceff0eaae5f14172c587de --- Ringtoets/Common/test/Ringtoets.Common.Data.TestUtil/TestCalculationWithForeshoreProfile.cs (.../TestCalculationWithForeshoreProfile.cs) (revision 6ef5e439a6d9f40ebd9926251945e0935fbbc314) +++ Ringtoets/Common/test/Ringtoets.Common.Data.TestUtil/TestCalculationWithForeshoreProfile.cs (.../TestCalculationWithForeshoreProfile.cs) (revision 00da0d2f72214f140bceff0eaae5f14172c587de) @@ -103,7 +103,7 @@ HasOutput = false; } - public object Clone() + public override object Clone() { throw new NotImplementedException(); } Fisheye: Tag 00da0d2f72214f140bceff0eaae5f14172c587de refers to a dead (removed) revision in file `Ringtoets/MacroStabilityInwards/src/Ringtoets.MacroStabilityInwards.Data/MacroStabilityInwardsFailureMechanismSection2AAssessmentResultExtensions.cs'. Fisheye: No comparison available. Pass `N' to diff? Fisheye: Tag c4392a12110e2bb3549c5fee1ec319c229b67198 refers to a dead (removed) revision in file `Ringtoets/MacroStabilityInwards/src/Ringtoets.MacroStabilityInwards.Data/MacroStabilityInwardsFailureMechanismSection2aAssessmentResultExtensions.cs'. Fisheye: No comparison available. Pass `N' to diff? Index: Ringtoets/MacroStabilityInwards/src/Ringtoets.MacroStabilityInwards.Data/Ringtoets.MacroStabilityInwards.Data.csproj =================================================================== diff -u -rc4392a12110e2bb3549c5fee1ec319c229b67198 -r00da0d2f72214f140bceff0eaae5f14172c587de --- Ringtoets/MacroStabilityInwards/src/Ringtoets.MacroStabilityInwards.Data/Ringtoets.MacroStabilityInwards.Data.csproj (.../Ringtoets.MacroStabilityInwards.Data.csproj) (revision c4392a12110e2bb3549c5fee1ec319c229b67198) +++ Ringtoets/MacroStabilityInwards/src/Ringtoets.MacroStabilityInwards.Data/Ringtoets.MacroStabilityInwards.Data.csproj (.../Ringtoets.MacroStabilityInwards.Data.csproj) (revision 00da0d2f72214f140bceff0eaae5f14172c587de) @@ -45,7 +45,7 @@ - + Fisheye: Tag 00da0d2f72214f140bceff0eaae5f14172c587de refers to a dead (removed) revision in file `Ringtoets/MacroStabilityInwards/test/Ringtoets.MacroStabilityInwards.Data.Test/MacroStabilityInwardsFailureMechanismSection2AAssessmentResultExtensionsTest.cs'. Fisheye: No comparison available. Pass `N' to diff? Fisheye: Tag c4392a12110e2bb3549c5fee1ec319c229b67198 refers to a dead (removed) revision in file `Ringtoets/MacroStabilityInwards/test/Ringtoets.MacroStabilityInwards.Data.Test/MacroStabilityInwardsFailureMechanismSection2aAssessmentResultExtensionsTest.cs'. Fisheye: No comparison available. Pass `N' to diff? Index: Ringtoets/MacroStabilityInwards/test/Ringtoets.MacroStabilityInwards.Data.Test/Ringtoets.MacroStabilityInwards.Data.Test.csproj =================================================================== diff -u -rc4392a12110e2bb3549c5fee1ec319c229b67198 -r00da0d2f72214f140bceff0eaae5f14172c587de --- Ringtoets/MacroStabilityInwards/test/Ringtoets.MacroStabilityInwards.Data.Test/Ringtoets.MacroStabilityInwards.Data.Test.csproj (.../Ringtoets.MacroStabilityInwards.Data.Test.csproj) (revision c4392a12110e2bb3549c5fee1ec319c229b67198) +++ Ringtoets/MacroStabilityInwards/test/Ringtoets.MacroStabilityInwards.Data.Test/Ringtoets.MacroStabilityInwards.Data.Test.csproj (.../Ringtoets.MacroStabilityInwards.Data.Test.csproj) (revision 00da0d2f72214f140bceff0eaae5f14172c587de) @@ -69,7 +69,7 @@ - + Fisheye: Tag 00da0d2f72214f140bceff0eaae5f14172c587de refers to a dead (removed) revision in file `Ringtoets/Piping/src/Ringtoets.Piping.Data/PipingFailureMechanismSection2AAssessmentResultExtensions.cs'. Fisheye: No comparison available. Pass `N' to diff? Fisheye: Tag db77ae03f93f27b25268dd9f62f0091a47fe22d8 refers to a dead (removed) revision in file `Ringtoets/Piping/src/Ringtoets.Piping.Data/PipingFailureMechanismSection2aAssessmentResultExtensions.cs'. Fisheye: No comparison available. Pass `N' to diff? Index: Ringtoets/Piping/src/Ringtoets.Piping.Data/Ringtoets.Piping.Data.csproj =================================================================== diff -u -rdb77ae03f93f27b25268dd9f62f0091a47fe22d8 -r00da0d2f72214f140bceff0eaae5f14172c587de --- Ringtoets/Piping/src/Ringtoets.Piping.Data/Ringtoets.Piping.Data.csproj (.../Ringtoets.Piping.Data.csproj) (revision db77ae03f93f27b25268dd9f62f0091a47fe22d8) +++ Ringtoets/Piping/src/Ringtoets.Piping.Data/Ringtoets.Piping.Data.csproj (.../Ringtoets.Piping.Data.csproj) (revision 00da0d2f72214f140bceff0eaae5f14172c587de) @@ -44,7 +44,7 @@ - + Fisheye: Tag 00da0d2f72214f140bceff0eaae5f14172c587de refers to a dead (removed) revision in file `Ringtoets/Piping/test/Ringtoets.Piping.Data.Test/PipingFailureMechanismSection2AAssessmentResultExtensionsTest.cs'. Fisheye: No comparison available. Pass `N' to diff? Fisheye: Tag db77ae03f93f27b25268dd9f62f0091a47fe22d8 refers to a dead (removed) revision in file `Ringtoets/Piping/test/Ringtoets.Piping.Data.Test/PipingFailureMechanismSection2aAssessmentResultExtensionsTest.cs'. Fisheye: No comparison available. Pass `N' to diff? Index: Ringtoets/Piping/test/Ringtoets.Piping.Data.Test/Ringtoets.Piping.Data.Test.csproj =================================================================== diff -u -rdb77ae03f93f27b25268dd9f62f0091a47fe22d8 -r00da0d2f72214f140bceff0eaae5f14172c587de --- Ringtoets/Piping/test/Ringtoets.Piping.Data.Test/Ringtoets.Piping.Data.Test.csproj (.../Ringtoets.Piping.Data.Test.csproj) (revision db77ae03f93f27b25268dd9f62f0091a47fe22d8) +++ Ringtoets/Piping/test/Ringtoets.Piping.Data.Test/Ringtoets.Piping.Data.Test.csproj (.../Ringtoets.Piping.Data.Test.csproj) (revision 00da0d2f72214f140bceff0eaae5f14172c587de) @@ -59,7 +59,7 @@ - +