Index: Ringtoets/Common/src/Ringtoets.Common.Forms/PropertyClasses/FailureMechanismAssemblyCategoriesProperties.cs
===================================================================
diff -u -rd520a1dd8a435c8de3ae5aab1c02b4be9627b67d -r09972250b5028e3fc06f492be60be48234b6e0e8
--- Ringtoets/Common/src/Ringtoets.Common.Forms/PropertyClasses/FailureMechanismAssemblyCategoriesProperties.cs (.../FailureMechanismAssemblyCategoriesProperties.cs) (revision d520a1dd8a435c8de3ae5aab1c02b4be9627b67d)
+++ Ringtoets/Common/src/Ringtoets.Common.Forms/PropertyClasses/FailureMechanismAssemblyCategoriesProperties.cs (.../FailureMechanismAssemblyCategoriesProperties.cs) (revision 09972250b5028e3fc06f492be60be48234b6e0e8)
@@ -28,51 +28,41 @@
using Core.Common.Gui.PropertyBag;
using Core.Common.Util.Attributes;
using Ringtoets.AssemblyTool.Data;
-using Ringtoets.Common.Data.FailureMechanism;
using Ringtoets.Common.Forms.Properties;
namespace Ringtoets.Common.Forms.PropertyClasses
{
///
- /// Base ViewModel of the assembly categories in a for properties panel.
+ /// ViewModel of a collection of for properties panel.
///
- public class FailureMechanismAssemblyCategoriesProperties : ObjectProperties
+ public class FailureMechanismAssemblyCategoriesProperties : ObjectProperties>
{
private const int failureMechanismAssemblyCategoryPropertyIndex = 1;
private const int failureMechanismSectionAssemblyCategoryPropertyIndex = 2;
- private readonly Func> getFailureMechanismAssemblyCategoryFunc;
- private readonly Func> getFailureMechanismSectionAssemblyCategoryFunc;
+ private readonly IEnumerable failureMechanismSectionAssemblyCategories;
///
/// Creates a new instance of .
///
- /// The failure mechanism to show the properties for.
- /// The function to get a collection of .
- /// The function to get a collection of .
+ /// The collection of .
+ /// The collection of .
/// Thrown when any parameter is null.
- public FailureMechanismAssemblyCategoriesProperties(IFailureMechanism failureMechanism,
- Func> getFailureMechanismAssemblyCategoryFunc,
- Func> getFailureMechanismSectionAssemblyCategoryFunc)
+ public FailureMechanismAssemblyCategoriesProperties(IEnumerable failureMechanismAssemblyCategories,
+ IEnumerable failureMechanismSectionAssemblyCategories)
{
- if (failureMechanism == null)
+ if (failureMechanismAssemblyCategories == null)
{
- throw new ArgumentNullException(nameof(failureMechanism));
+ throw new ArgumentNullException(nameof(failureMechanismAssemblyCategories));
}
- if (getFailureMechanismAssemblyCategoryFunc == null)
+ if (failureMechanismSectionAssemblyCategories == null)
{
- throw new ArgumentNullException(nameof(getFailureMechanismAssemblyCategoryFunc));
+ throw new ArgumentNullException(nameof(failureMechanismSectionAssemblyCategories));
}
- if (getFailureMechanismSectionAssemblyCategoryFunc == null)
- {
- throw new ArgumentNullException(nameof(getFailureMechanismSectionAssemblyCategoryFunc));
- }
+ this.failureMechanismSectionAssemblyCategories = failureMechanismSectionAssemblyCategories;
- this.getFailureMechanismAssemblyCategoryFunc = getFailureMechanismAssemblyCategoryFunc;
- this.getFailureMechanismSectionAssemblyCategoryFunc = getFailureMechanismSectionAssemblyCategoryFunc;
-
- Data = failureMechanism;
+ Data = failureMechanismAssemblyCategories;
}
[PropertyOrder(failureMechanismAssemblyCategoryPropertyIndex)]
@@ -84,7 +74,7 @@
{
get
{
- return getFailureMechanismAssemblyCategoryFunc().Select(category => new FailureMechanismAssemblyCategoryProperties(category)).ToArray();
+ return data.Select(category => new FailureMechanismAssemblyCategoryProperties(category)).ToArray();
}
}
@@ -97,7 +87,7 @@
{
get
{
- return getFailureMechanismSectionAssemblyCategoryFunc().Select(category => new FailureMechanismSectionAssemblyCategoryProperties(category)).ToArray();
+ return failureMechanismSectionAssemblyCategories.Select(category => new FailureMechanismSectionAssemblyCategoryProperties(category)).ToArray();
}
}
}
Index: Ringtoets/Common/test/Ringtoets.Common.Forms.Test/PropertyClasses/FailureMechanismAssemblyCategoriesPropertiesTest.cs
===================================================================
diff -u -r8211929afdf8bbc97b32554493572972fc552c23 -r09972250b5028e3fc06f492be60be48234b6e0e8
--- Ringtoets/Common/test/Ringtoets.Common.Forms.Test/PropertyClasses/FailureMechanismAssemblyCategoriesPropertiesTest.cs (.../FailureMechanismAssemblyCategoriesPropertiesTest.cs) (revision 8211929afdf8bbc97b32554493572972fc552c23)
+++ Ringtoets/Common/test/Ringtoets.Common.Forms.Test/PropertyClasses/FailureMechanismAssemblyCategoriesPropertiesTest.cs (.../FailureMechanismAssemblyCategoriesPropertiesTest.cs) (revision 09972250b5028e3fc06f492be60be48234b6e0e8)
@@ -27,9 +27,7 @@
using Core.Common.Gui.PropertyBag;
using Core.Common.TestUtil;
using NUnit.Framework;
-using Rhino.Mocks;
using Ringtoets.AssemblyTool.Data;
-using Ringtoets.Common.Data.FailureMechanism;
using Ringtoets.Common.Forms.PropertyClasses;
namespace Ringtoets.Common.Forms.Test.PropertyClasses
@@ -38,75 +36,43 @@
public class FailureMechanismAssemblyCategoriesPropertiesTest
{
[Test]
- public void Constructor_FailureMechanismNull_ThrowsArgumentNullException()
+ public void Constructor_GetFailureMechanismAssemblyCategoryFuncNull_ThrowsArgumentNullException()
{
// Call
TestDelegate call = () => new FailureMechanismAssemblyCategoriesProperties(null,
- GetFailureMechanismAssemblyCategory,
- GetFailureMechanismSectionAssemblyCategory);
+ GetFailureMechanismSectionAssemblyCategories());
// Assert
var exception = Assert.Throws(call);
- Assert.AreEqual("failureMechanism", exception.ParamName);
+ Assert.AreEqual("failureMechanismAssemblyCategories", exception.ParamName);
}
[Test]
- public void Constructor_GetFailureMechanismAssemblyCategoryFuncNull_ThrowsArgumentNullException()
- {
- // Setup
- var mocks = new MockRepository();
- var failureMechanism = mocks.Stub();
- mocks.ReplayAll();
-
- // Call
- TestDelegate call = () => new FailureMechanismAssemblyCategoriesProperties(failureMechanism,
- null,
- GetFailureMechanismSectionAssemblyCategory);
-
- // Assert
- var exception = Assert.Throws(call);
- Assert.AreEqual("getFailureMechanismAssemblyCategoryFunc", exception.ParamName);
- mocks.VerifyAll();
- }
-
- [Test]
public void Constructor_GetFailureMechanismSectionAssemblyCategoryFuncNull_ThrowsArgumentNullException()
{
- // Setup
- var mocks = new MockRepository();
- var failureMechanism = mocks.Stub();
- mocks.ReplayAll();
-
// Call
- TestDelegate call = () => new FailureMechanismAssemblyCategoriesProperties(failureMechanism,
- GetFailureMechanismAssemblyCategory,
+ TestDelegate call = () => new FailureMechanismAssemblyCategoriesProperties(GetFailureMechanismAssemblyCategories(),
null);
// Assert
var exception = Assert.Throws(call);
- Assert.AreEqual("getFailureMechanismSectionAssemblyCategoryFunc", exception.ParamName);
- mocks.VerifyAll();
+ Assert.AreEqual("failureMechanismSectionAssemblyCategories", exception.ParamName);
}
[Test]
public void Constructor_ValidParameters_ExpectedValues()
{
// Setup
- var mocks = new MockRepository();
- var failureMechanism = mocks.Stub();
- mocks.ReplayAll();
+ IEnumerable expectedFailureMechanismCategories = GetFailureMechanismAssemblyCategories();
+ IEnumerable expectedFailureMechanismSectionCategories = GetFailureMechanismSectionAssemblyCategories();
- IEnumerable expectedFailureMechanismCategories = GetFailureMechanismAssemblyCategory();
- IEnumerable expectedFailureMechanismSectionCategories = GetFailureMechanismSectionAssemblyCategory();
-
// Call
- var properties = new FailureMechanismAssemblyCategoriesProperties(failureMechanism,
- () => expectedFailureMechanismCategories,
- () => expectedFailureMechanismSectionCategories);
+ var properties = new FailureMechanismAssemblyCategoriesProperties(expectedFailureMechanismCategories,
+ expectedFailureMechanismSectionCategories);
// Assert
- Assert.IsInstanceOf>(properties);
- Assert.AreSame(failureMechanism, properties.Data);
+ Assert.IsInstanceOf>>(properties);
+ Assert.AreSame(expectedFailureMechanismCategories, properties.Data);
TestHelper.AssertTypeConverter(
nameof(FailureMechanismAssemblyCategoriesProperties.FailureMechanismAssemblyCategories));
@@ -132,22 +98,14 @@
Assert.AreEqual(category.UpperBoundary, property.UpperBoundary);
Assert.AreEqual(category.LowerBoundary, property.LowerBoundary);
}
-
- mocks.VerifyAll();
}
[Test]
public void Constructor_Always_PropertiesHaveExpectedAttributesValues()
{
- // Setup
- var mocks = new MockRepository();
- var failureMechanism = mocks.Stub();
- mocks.ReplayAll();
-
// Call
- var properties = new FailureMechanismAssemblyCategoriesProperties(failureMechanism,
- GetFailureMechanismAssemblyCategory,
- GetFailureMechanismSectionAssemblyCategory);
+ var properties = new FailureMechanismAssemblyCategoriesProperties(GetFailureMechanismAssemblyCategories(),
+ GetFailureMechanismSectionAssemblyCategories());
// Assert
PropertyDescriptorCollection dynamicProperties = PropertiesTestHelper.GetAllVisiblePropertyDescriptors(properties);
Assert.AreEqual(2, dynamicProperties.Count);
@@ -167,22 +125,30 @@
"Categoriegrenzen per vak",
"De categoriegrenzen per vak voor dit toetsspoor.",
true);
-
- mocks.VerifyAll();
}
- private static IEnumerable GetFailureMechanismSectionAssemblyCategory()
+ private static IEnumerable GetFailureMechanismSectionAssemblyCategories()
{
var random = new Random(21);
- yield return new FailureMechanismSectionAssemblyCategory(random.NextDouble(), random.NextDouble(), random.NextEnumValue());
+ return new[]
+ {
+ new FailureMechanismSectionAssemblyCategory(random.NextDouble(),
+ random.NextDouble(),
+ random.NextEnumValue())
+ };
}
- private static IEnumerable GetFailureMechanismAssemblyCategory()
+ private static IEnumerable GetFailureMechanismAssemblyCategories()
{
var random = new Random(21);
- yield return new FailureMechanismAssemblyCategory(random.NextDouble(), random.NextDouble(), random.NextEnumValue());
+ return new[]
+ {
+ new FailureMechanismAssemblyCategory(random.NextDouble(),
+ random.NextDouble(),
+ random.NextEnumValue())
+ };
}
}
}
\ No newline at end of file