Fisheye: Tag 09cbe8d8fd52fcc80a38bcf60ca32890ef9fbbf5 refers to a dead (removed) revision in file `Ringtoets/Integration/src/Ringtoets.Integration.Service/Exceptions/AssessmentSectionProviderException.cs'. Fisheye: No comparison available. Pass `N' to diff? Index: Ringtoets/Integration/src/Ringtoets.Integration.Service/Exceptions/LoadAssessmentSectionException.cs =================================================================== diff -u --- Ringtoets/Integration/src/Ringtoets.Integration.Service/Exceptions/LoadAssessmentSectionException.cs (revision 0) +++ Ringtoets/Integration/src/Ringtoets.Integration.Service/Exceptions/LoadAssessmentSectionException.cs (revision 09cbe8d8fd52fcc80a38bcf60ca32890ef9fbbf5) @@ -0,0 +1,68 @@ +// Copyright (C) Stichting Deltares 2017. All rights reserved. +// +// This file is part of Ringtoets. +// +// Ringtoets is free software: you can redistribute it and/or modify +// it under the terms of the GNU General Public License as published by +// the Free Software Foundation, either version 3 of the License, or +// (at your option) any later version. +// +// This program is distributed in the hope that it will be useful, +// but WITHOUT ANY WARRANTY; without even the implied warranty of +// MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the +// GNU General Public License for more details. +// +// You should have received a copy of the GNU General Public License +// along with this program. If not, see . +// +// All names, logos, and references to "Deltares" are registered trademarks of +// Stichting Deltares and remain full property of Stichting Deltares at all times. +// All rights reserved. + +using System; +using System.Runtime.Serialization; + +namespace Ringtoets.Integration.Service.Exceptions +{ + /// + /// Exception thrown when something went wrong when loading assessment sections. + /// + [Serializable] + public class LoadAssessmentSectionException : Exception + { + /// + /// Initializes a new instance of the class. + /// + public LoadAssessmentSectionException() {} + + /// + /// Initializes a new instance of the class + /// with a specified error message. + /// + /// The message that describes the error. + public LoadAssessmentSectionException(string message) + : base(message) {} + + /// + /// Initializes a new instance of the class with a specified error message + /// and a reference to the inner exception that is the cause of this exception. + /// + /// The error message that explains the reason for the exception. + /// The exception that is the cause of the current exception, + /// or null if no inner exception is specified. + public LoadAssessmentSectionException(string message, Exception innerException) : base(message, innerException) {} + + /// + /// Initializes a new instance of with + /// serialized data. + /// The that holds the serialized + /// object data about the exception being thrown. + /// The that contains contextual + /// information about the source or destination. + /// The parameter is + /// null. + /// The class name is null or + /// is zero (0). + protected LoadAssessmentSectionException(SerializationInfo info, StreamingContext context) : base(info, context) {} + } +} \ No newline at end of file Index: Ringtoets/Integration/src/Ringtoets.Integration.Service/Merge/ILoadAssessmentSectionService.cs =================================================================== diff -u -r8f55cc2e48410adbc9c96fa1d2a134200dcb52c3 -r09cbe8d8fd52fcc80a38bcf60ca32890ef9fbbf5 --- Ringtoets/Integration/src/Ringtoets.Integration.Service/Merge/ILoadAssessmentSectionService.cs (.../ILoadAssessmentSectionService.cs) (revision 8f55cc2e48410adbc9c96fa1d2a134200dcb52c3) +++ Ringtoets/Integration/src/Ringtoets.Integration.Service/Merge/ILoadAssessmentSectionService.cs (.../ILoadAssessmentSectionService.cs) (revision 09cbe8d8fd52fcc80a38bcf60ca32890ef9fbbf5) @@ -35,8 +35,8 @@ /// /// The file path to read the assessment sections from. /// A collection of . - /// Thrown if something went wrong - /// when providing the assessment sections. + /// Thrown if something went wrong + /// when loading the assessment sections. IEnumerable LoadAssessmentSections(string filePath); } } \ No newline at end of file Index: Ringtoets/Integration/src/Ringtoets.Integration.Service/Merge/LoadAssessmentSectionService.cs =================================================================== diff -u -r8f55cc2e48410adbc9c96fa1d2a134200dcb52c3 -r09cbe8d8fd52fcc80a38bcf60ca32890ef9fbbf5 --- Ringtoets/Integration/src/Ringtoets.Integration.Service/Merge/LoadAssessmentSectionService.cs (.../LoadAssessmentSectionService.cs) (revision 8f55cc2e48410adbc9c96fa1d2a134200dcb52c3) +++ Ringtoets/Integration/src/Ringtoets.Integration.Service/Merge/LoadAssessmentSectionService.cs (.../LoadAssessmentSectionService.cs) (revision 09cbe8d8fd52fcc80a38bcf60ca32890ef9fbbf5) @@ -63,12 +63,12 @@ string exceptionMessage = e.Message; log.Error(exceptionMessage, e.InnerException); - throw new AssessmentSectionProviderException(exceptionMessage, e); + throw new LoadAssessmentSectionException(exceptionMessage, e); } if (openedProject == null) { - throw new AssessmentSectionProviderException(); + throw new LoadAssessmentSectionException(); } return openedProject.AssessmentSections; Index: Ringtoets/Integration/src/Ringtoets.Integration.Service/Ringtoets.Integration.Service.csproj =================================================================== diff -u -r9b13d72b947e626befe542c6c09d34860a6b485c -r09cbe8d8fd52fcc80a38bcf60ca32890ef9fbbf5 --- Ringtoets/Integration/src/Ringtoets.Integration.Service/Ringtoets.Integration.Service.csproj (.../Ringtoets.Integration.Service.csproj) (revision 9b13d72b947e626befe542c6c09d34860a6b485c) +++ Ringtoets/Integration/src/Ringtoets.Integration.Service/Ringtoets.Integration.Service.csproj (.../Ringtoets.Integration.Service.csproj) (revision 09cbe8d8fd52fcc80a38bcf60ca32890ef9fbbf5) @@ -18,7 +18,7 @@ - + Fisheye: Tag 09cbe8d8fd52fcc80a38bcf60ca32890ef9fbbf5 refers to a dead (removed) revision in file `Ringtoets/Integration/test/Ringtoets.Integration.Service.Test/Exceptions/AssessmentSectionProviderExceptionTest.cs'. Fisheye: No comparison available. Pass `N' to diff? Index: Ringtoets/Integration/test/Ringtoets.Integration.Service.Test/Exceptions/LoadAssessmentSectionExceptionTest.cs =================================================================== diff -u --- Ringtoets/Integration/test/Ringtoets.Integration.Service.Test/Exceptions/LoadAssessmentSectionExceptionTest.cs (revision 0) +++ Ringtoets/Integration/test/Ringtoets.Integration.Service.Test/Exceptions/LoadAssessmentSectionExceptionTest.cs (revision 09cbe8d8fd52fcc80a38bcf60ca32890ef9fbbf5) @@ -0,0 +1,32 @@ +// Copyright (C) Stichting Deltares 2017. All rights reserved. +// +// This file is part of Ringtoets. +// +// Ringtoets is free software: you can redistribute it and/or modify +// it under the terms of the GNU General Public License as published by +// the Free Software Foundation, either version 3 of the License, or +// (at your option) any later version. +// +// This program is distributed in the hope that it will be useful, +// but WITHOUT ANY WARRANTY; without even the implied warranty of +// MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the +// GNU General Public License for more details. +// +// You should have received a copy of the GNU General Public License +// along with this program. If not, see . +// +// All names, logos, and references to "Deltares" are registered trademarks of +// Stichting Deltares and remain full property of Stichting Deltares at all times. +// All rights reserved. + +using System; +using Core.Common.TestUtil; +using NUnit.Framework; +using Ringtoets.Integration.Service.Exceptions; + +namespace Ringtoets.Integration.Service.Test.Exceptions +{ + [TestFixture] + public class LoadAssessmentSectionExceptionTest : + CustomExceptionDesignGuidelinesTestFixture {} +} \ No newline at end of file Index: Ringtoets/Integration/test/Ringtoets.Integration.Service.Test/Merge/LoadAssessmentSectionServiceTest.cs =================================================================== diff -u -r8f55cc2e48410adbc9c96fa1d2a134200dcb52c3 -r09cbe8d8fd52fcc80a38bcf60ca32890ef9fbbf5 --- Ringtoets/Integration/test/Ringtoets.Integration.Service.Test/Merge/LoadAssessmentSectionServiceTest.cs (.../LoadAssessmentSectionServiceTest.cs) (revision 8f55cc2e48410adbc9c96fa1d2a134200dcb52c3) +++ Ringtoets/Integration/test/Ringtoets.Integration.Service.Test/Merge/LoadAssessmentSectionServiceTest.cs (.../LoadAssessmentSectionServiceTest.cs) (revision 09cbe8d8fd52fcc80a38bcf60ca32890ef9fbbf5) @@ -105,7 +105,7 @@ } [Test] - public void LoadAssessmentSections_LoadedProjectNull_ThrowsAssessmentSectionProviderException() + public void LoadAssessmentSections_LoadedProjectNull_ThrowsLoadAssessmentSectionException() { // Setup var mocks = new MockRepository(); @@ -121,12 +121,12 @@ TestDelegate call = () => provider.LoadAssessmentSections(string.Empty); // Assert - Assert.Throws(call); + Assert.Throws(call); mocks.VerifyAll(); } [Test] - public void LoadAssessmentSections_LoadingProjectThrowsException_ThrowsAssessmentSectionProviderExceptionAndLogsError() + public void LoadAssessmentSections_LoadingProjectThrowsException_ThrowsLoadAssessmentSectionExceptionAndLogsError() { // Setup const string exceptionMessage = "StorageException"; @@ -141,7 +141,7 @@ var provider = new LoadAssessmentSectionService(storeProject); - AssessmentSectionProviderException exception = null; + LoadAssessmentSectionException exception = null; // Call Action call = () => @@ -150,7 +150,7 @@ { provider.LoadAssessmentSections(string.Empty); } - catch (AssessmentSectionProviderException e) + catch (LoadAssessmentSectionException e) { exception = e; } Index: Ringtoets/Integration/test/Ringtoets.Integration.Service.Test/Merge/LoadAssessmentSectionsActivityTest.cs =================================================================== diff -u -r8f55cc2e48410adbc9c96fa1d2a134200dcb52c3 -r09cbe8d8fd52fcc80a38bcf60ca32890ef9fbbf5 --- Ringtoets/Integration/test/Ringtoets.Integration.Service.Test/Merge/LoadAssessmentSectionsActivityTest.cs (.../LoadAssessmentSectionsActivityTest.cs) (revision 8f55cc2e48410adbc9c96fa1d2a134200dcb52c3) +++ Ringtoets/Integration/test/Ringtoets.Integration.Service.Test/Merge/LoadAssessmentSectionsActivityTest.cs (.../LoadAssessmentSectionsActivityTest.cs) (revision 09cbe8d8fd52fcc80a38bcf60ca32890ef9fbbf5) @@ -124,7 +124,7 @@ } [Test] - public void Run_ProviderReturnsAssessmentSections_SetsActivityStateToExecutedAndSetsAssessmentSections() + public void Run_ServiceReturnsAssessmentSections_SetsActivityStateToExecutedAndSetsAssessmentSections() { // Setup IEnumerable assessmentSections = Enumerable.Empty(); @@ -149,14 +149,14 @@ } [Test] - public void Run_ProviderThrowsException_SetsActivityStateToFailedAndDoesNotSetAssessmentSections() + public void Run_ServiceThrowsException_SetsActivityStateToFailedAndDoesNotSetAssessmentSections() { // Setup var mocks = new MockRepository(); var provider = mocks.StrictMock(); provider.Expect(p => p.LoadAssessmentSections(null)) .IgnoreArguments() - .Throw(new AssessmentSectionProviderException()); + .Throw(new LoadAssessmentSectionException()); mocks.ReplayAll(); var owner = new AssessmentSectionsOwner(); Index: Ringtoets/Integration/test/Ringtoets.Integration.Service.Test/Ringtoets.Integration.Service.Test.csproj =================================================================== diff -u -rbdd157e9b19f636d46ce3f3b971ef83a0200e483 -r09cbe8d8fd52fcc80a38bcf60ca32890ef9fbbf5 --- Ringtoets/Integration/test/Ringtoets.Integration.Service.Test/Ringtoets.Integration.Service.Test.csproj (.../Ringtoets.Integration.Service.Test.csproj) (revision bdd157e9b19f636d46ce3f3b971ef83a0200e483) +++ Ringtoets/Integration/test/Ringtoets.Integration.Service.Test/Ringtoets.Integration.Service.Test.csproj (.../Ringtoets.Integration.Service.Test.csproj) (revision 09cbe8d8fd52fcc80a38bcf60ca32890ef9fbbf5) @@ -20,7 +20,7 @@ - +