Index: Ringtoets/Common/test/Ringtoets.Common.IO.Test/ReferenceLines/ReferenceLineImporterTest.cs =================================================================== diff -u -r2d7781915c424dbd7887718775d4eb6e42a96503 -r0e576d355cea018f0256f7d236c9e0ef444383b7 --- Ringtoets/Common/test/Ringtoets.Common.IO.Test/ReferenceLines/ReferenceLineImporterTest.cs (.../ReferenceLineImporterTest.cs) (revision 2d7781915c424dbd7887718775d4eb6e42a96503) +++ Ringtoets/Common/test/Ringtoets.Common.IO.Test/ReferenceLines/ReferenceLineImporterTest.cs (.../ReferenceLineImporterTest.cs) (revision 0e576d355cea018f0256f7d236c9e0ef444383b7) @@ -29,6 +29,7 @@ using NUnit.Framework; using Rhino.Mocks; using Ringtoets.Common.Data.AssessmentSection; +using Ringtoets.Common.Data.TestUtil; using Ringtoets.Common.Forms.PresentationObjects; using Ringtoets.Common.IO.ReferenceLines; @@ -71,11 +72,12 @@ } [Test] - public void Import_ContextWithoutReferenceLine_ImportReferenceLineToAssessmentSection() + public void Import_ContextWithReferenceLineWithoutGeometry_ImportReferenceLineToAssessmentSection() { // Setup var mocks = new MockRepository(); var assessmentSection = mocks.Stub(); + assessmentSection.Stub(a => a.ReferenceLine).Return(new ReferenceLine()); var handler = mocks.StrictMock(); handler.Expect(h => h.Replace(Arg.Is.Same(assessmentSection), Arg.Is.NotNull)) @@ -104,11 +106,12 @@ } [Test] - public void Import_ContextWithoutReferenceLine_GeneratedExpectedProgressMessages() + public void Import_ContextWithReferenceLineWithoutGeometry_GeneratedExpectedProgressMessages() { // Setup var mocks = new MockRepository(); var assessmentSection = mocks.Stub(); + assessmentSection.Stub(a => a.ReferenceLine).Return(new ReferenceLine()); var handler = mocks.Stub(); handler.Expect(h => h.Replace(Arg.Is.Same(assessmentSection), Arg.Is.NotNull)) @@ -157,6 +160,7 @@ // Setup var mocks = new MockRepository(); var assessmentSection = mocks.Stub(); + assessmentSection.Stub(a => a.ReferenceLine).Return(new ReferenceLine()); var handler = mocks.StrictMock(); handler.Expect(h => h.ConfirmReplace()) .Repeat.Never(); @@ -187,6 +191,7 @@ // Setup var mocks = new MockRepository(); var assessmentSection = mocks.Stub(); + assessmentSection.Stub(a => a.ReferenceLine).Return(new ReferenceLine()); var handler = mocks.StrictMock(); handler.Expect(h => h.ConfirmReplace()) .Repeat.Never(); @@ -215,11 +220,9 @@ public void Import_CancelingImport_ReturnFalseAndNoChanges() { // Setup - var originalReferenceLine = new ReferenceLine(); - var mocks = new MockRepository(); var assessmentSection = mocks.Stub(); - assessmentSection.Stub(a => a.ReferenceLine).Return(originalReferenceLine); + assessmentSection.Stub(a => a.ReferenceLine).Return(ReferenceLineTestFactory.CreateReferenceLineWithGeometry()); var handler = mocks.StrictMock(); handler.Expect(h => h.ConfirmReplace()).Return(false); handler.Expect(h => h.Replace(null, null)) @@ -246,11 +249,10 @@ { // Setup string path = TestHelper.GetTestDataPath(TestDataPath.Ringtoets.Common.IO, "traject_10-2.shp"); - var originalReferenceLine = new ReferenceLine(); var mocks = new MockRepository(); var assessmentSection = mocks.Stub(); - assessmentSection.Stub(a => a.ReferenceLine).Return(originalReferenceLine); + assessmentSection.Stub(a => a.ReferenceLine).Return(ReferenceLineTestFactory.CreateReferenceLineWithGeometry()); var handler = mocks.StrictMock(); var importer = new ReferenceLineImporter(assessmentSection, handler, path); handler.Expect(h => h.ConfirmReplace()) @@ -277,11 +279,10 @@ { // Setup string path = TestHelper.GetTestDataPath(TestDataPath.Ringtoets.Common.IO, Path.Combine("ReferenceLine", "traject_10-2.shp")); - var originalReferenceLine = new ReferenceLine(); var mocks = new MockRepository(); var assessmentSection = mocks.Stub(); - assessmentSection.Stub(a => a.ReferenceLine).Return(originalReferenceLine); + assessmentSection.Stub(a => a.ReferenceLine).Return(new ReferenceLine()); var handler = mocks.Stub(); handler.Stub(h => h.ConfirmReplace()) .Return(true); @@ -312,11 +313,10 @@ { // Setup string path = TestHelper.GetTestDataPath(TestDataPath.Ringtoets.Common.IO, Path.Combine("ReferenceLine", "traject_10-2.shp")); - var originalReferenceLine = new ReferenceLine(); var mocks = new MockRepository(); var assessmentSection = mocks.Stub(); - assessmentSection.Stub(a => a.ReferenceLine).Return(originalReferenceLine); + assessmentSection.Stub(a => a.ReferenceLine).Return(new ReferenceLine()); var handler = mocks.Stub(); handler.Stub(h => h.ConfirmReplace()) .Return(true); @@ -347,11 +347,12 @@ } [Test] - public void Import_ReusingCanceledImporterForContextWithoutReferenceLine_ImportReferenceLineToAssessmentSection() + public void Import_ReusingCanceledImporterForContextWithReferenceLineWithoutGeometry_ImportReferenceLineToAssessmentSection() { // Setup var mocks = new MockRepository(); var assessmentSection = mocks.Stub(); + assessmentSection.Stub(a => a.ReferenceLine).Return(new ReferenceLine()); var handler = mocks.StrictMock(); handler.Expect(h => h.ConfirmReplace()) .Repeat.Never(); @@ -388,17 +389,15 @@ } [Test] - public void DoPostImportUpdates_AssessmentSectionAlreadyHasReferenceLineAndAnswerDialogToContinue_NotifyObserversOfTargetContextAndClearedObjects() + public void DoPostImportUpdates_AssessmentSectionAlreadyHasReferenceLineWithGeometryAndAnswerDialogToContinue_NotifyObserversOfTargetContextAndClearedObjects() { // Setup - var originalReferenceLine = new ReferenceLine(); - var mocks = new MockRepository(); var contextObserver = mocks.Stub(); contextObserver.Expect(o => o.UpdateObserver()); var assessmentSection = mocks.Stub(); - assessmentSection.Stub(a => a.ReferenceLine).Return(originalReferenceLine); + assessmentSection.Stub(a => a.ReferenceLine).Return(ReferenceLineTestFactory.CreateReferenceLineWithGeometry()); assessmentSection.Expect(section => section.Attach(contextObserver)); assessmentSection.Expect(section => section.NotifyObservers()).Do((Action) (() => contextObserver.UpdateObserver())); @@ -444,12 +443,11 @@ { // Setup string path = TestHelper.GetTestDataPath(TestDataPath.Ringtoets.Common.IO, "traject_10-2.shp"); - var originalReferenceLine = new ReferenceLine(); var mocks = new MockRepository(); var contextObserver = mocks.StrictMock(); var assessmentSection = mocks.Stub(); - assessmentSection.Stub(a => a.ReferenceLine).Return(originalReferenceLine); + assessmentSection.Stub(a => a.ReferenceLine).Return(ReferenceLineTestFactory.CreateReferenceLineWithGeometry()); assessmentSection.Expect(section => section.Attach(contextObserver)); var handler = mocks.StrictMock();