Index: Riskeer/Integration/src/Riskeer.Integration.Service/AssessmentSectionHydraulicBoundaryLocationCalculationActivityFactory.cs =================================================================== diff -u -rc91b12bdb15db0adebe7d24d98613377e65d0147 -r12a3072cbaf39329e8f7a6c96de24be7da43a896 --- Riskeer/Integration/src/Riskeer.Integration.Service/AssessmentSectionHydraulicBoundaryLocationCalculationActivityFactory.cs (.../AssessmentSectionHydraulicBoundaryLocationCalculationActivityFactory.cs) (revision c91b12bdb15db0adebe7d24d98613377e65d0147) +++ Riskeer/Integration/src/Riskeer.Integration.Service/AssessmentSectionHydraulicBoundaryLocationCalculationActivityFactory.cs (.../AssessmentSectionHydraulicBoundaryLocationCalculationActivityFactory.cs) (revision 12a3072cbaf39329e8f7a6c96de24be7da43a896) @@ -74,20 +74,20 @@ var activities = new List(); - double signalingNorm = assessmentSection.FailureMechanismContribution.SignalingNorm; - activities.AddRange(HydraulicBoundaryLocationCalculationActivityFactory.CreateDesignWaterLevelCalculationActivities( - assessmentSection.WaterLevelCalculationsForSignalingNorm, - assessmentSection, - signalingNorm, - noProbabilityValueDoubleConverter.ConvertToString(signalingNorm))); - double lowerLimitNorm = assessmentSection.FailureMechanismContribution.LowerLimitNorm; activities.AddRange(HydraulicBoundaryLocationCalculationActivityFactory.CreateDesignWaterLevelCalculationActivities( assessmentSection.WaterLevelCalculationsForLowerLimitNorm, assessmentSection, lowerLimitNorm, noProbabilityValueDoubleConverter.ConvertToString(lowerLimitNorm))); + double signalingNorm = assessmentSection.FailureMechanismContribution.SignalingNorm; + activities.AddRange(HydraulicBoundaryLocationCalculationActivityFactory.CreateDesignWaterLevelCalculationActivities( + assessmentSection.WaterLevelCalculationsForSignalingNorm, + assessmentSection, + signalingNorm, + noProbabilityValueDoubleConverter.ConvertToString(signalingNorm))); + return activities; } Index: Riskeer/Integration/test/Riskeer.Integration.Service.Test/AssessmentSectionHydraulicBoundaryLocationCalculationActivityFactoryTest.cs =================================================================== diff -u -rc91b12bdb15db0adebe7d24d98613377e65d0147 -r12a3072cbaf39329e8f7a6c96de24be7da43a896 --- Riskeer/Integration/test/Riskeer.Integration.Service.Test/AssessmentSectionHydraulicBoundaryLocationCalculationActivityFactoryTest.cs (.../AssessmentSectionHydraulicBoundaryLocationCalculationActivityFactoryTest.cs) (revision c91b12bdb15db0adebe7d24d98613377e65d0147) +++ Riskeer/Integration/test/Riskeer.Integration.Service.Test/AssessmentSectionHydraulicBoundaryLocationCalculationActivityFactoryTest.cs (.../AssessmentSectionHydraulicBoundaryLocationCalculationActivityFactoryTest.cs) (revision 12a3072cbaf39329e8f7a6c96de24be7da43a896) @@ -60,6 +60,39 @@ } [Test] + public void CreateWaterLevelCalculationActivitiesForNormTargetProbabilities_AssessmentSectionNull_ThrowsArgumentNullException() + { + // Call + void Call() => AssessmentSectionHydraulicBoundaryLocationCalculationActivityFactory.CreateWaterLevelCalculationActivitiesForNormTargetProbabilities(null); + + // Assert + var exception = Assert.Throws(Call); + Assert.AreEqual("assessmentSection", exception.ParamName); + } + + [Test] + public void CreateWaterLevelCalculationActivitiesForUserDefinedTargetProbabilities_AssessmentSectionNull_ThrowsArgumentNullException() + { + // Call + void Call() => AssessmentSectionHydraulicBoundaryLocationCalculationActivityFactory.CreateWaterLevelCalculationActivitiesForUserDefinedTargetProbabilities(null); + + // Assert + var exception = Assert.Throws(Call); + Assert.AreEqual("assessmentSection", exception.ParamName); + } + + [Test] + public void CreateWaveHeightCalculationActivitiesForUserDefinedTargetProbabilities_AssessmentSectionNull_ThrowsArgumentNullException() + { + // Call + void Call() => AssessmentSectionHydraulicBoundaryLocationCalculationActivityFactory.CreateWaveHeightCalculationActivitiesForUserDefinedTargetProbabilities(null); + + // Assert + var exception = Assert.Throws(Call); + Assert.AreEqual("assessmentSection", exception.ParamName); + } + + [Test] [TestCase(true)] [TestCase(false)] public void CreateHydraulicBoundaryLocationCalculationActivities_WithValidDataAndUsePreprocessorStates_ExpectedInputSetToActivities(bool usePreprocessor) @@ -84,31 +117,31 @@ HydraulicBoundaryDatabase hydraulicBoundaryDatabase = assessmentSection.HydraulicBoundaryDatabase; - double signalingNorm = assessmentSection.FailureMechanismContribution.SignalingNorm; - string signalingNormText = noProbabilityValueDoubleConverter.ConvertToString(signalingNorm); double lowerLimitNorm = assessmentSection.FailureMechanismContribution.LowerLimitNorm; string lowerLimitNormText = noProbabilityValueDoubleConverter.ConvertToString(lowerLimitNorm); + double signalingNorm = assessmentSection.FailureMechanismContribution.SignalingNorm; + string signalingNormText = noProbabilityValueDoubleConverter.ConvertToString(signalingNorm); AssertDesignWaterLevelCalculationActivity(activities.ElementAt(0), hydraulicBoundaryLocation1, - signalingNorm, - signalingNormText, + lowerLimitNorm, + lowerLimitNormText, hydraulicBoundaryDatabase); AssertDesignWaterLevelCalculationActivity(activities.ElementAt(1), hydraulicBoundaryLocation2, - signalingNorm, - signalingNormText, + lowerLimitNorm, + lowerLimitNormText, hydraulicBoundaryDatabase); AssertDesignWaterLevelCalculationActivity(activities.ElementAt(2), hydraulicBoundaryLocation1, - lowerLimitNorm, - lowerLimitNormText, + signalingNorm, + signalingNormText, hydraulicBoundaryDatabase); AssertDesignWaterLevelCalculationActivity(activities.ElementAt(3), hydraulicBoundaryLocation2, - lowerLimitNorm, - lowerLimitNormText, + signalingNorm, + signalingNormText, hydraulicBoundaryDatabase); double firstWaterLevelTargetProbability = assessmentSection.WaterLevelCalculationsForUserDefinedTargetProbabilities[0].TargetProbability; @@ -167,17 +200,6 @@ } [Test] - public void CreateWaterLevelCalculationActivitiesForNormTargetProbabilities_AssessmentSectionNull_ThrowsArgumentNullException() - { - // Call - void Call() => AssessmentSectionHydraulicBoundaryLocationCalculationActivityFactory.CreateWaterLevelCalculationActivitiesForNormTargetProbabilities(null); - - // Assert - var exception = Assert.Throws(Call); - Assert.AreEqual("assessmentSection", exception.ParamName); - } - - [Test] [TestCase(true)] [TestCase(false)] public void CreateWaterLevelCalculationActivitiesForNormTargetProbabilities_WithValidDataAndUsePreprocessorStates_ExpectedInputSetToActivities(bool usePreprocessor) @@ -231,17 +253,6 @@ } [Test] - public void CreateWaterLevelCalculationActivitiesForUserDefinedTargetProbabilities_AssessmentSectionNull_ThrowsArgumentNullException() - { - // Call - void Call() => AssessmentSectionHydraulicBoundaryLocationCalculationActivityFactory.CreateWaterLevelCalculationActivitiesForUserDefinedTargetProbabilities(null); - - // Assert - var exception = Assert.Throws(Call); - Assert.AreEqual("assessmentSection", exception.ParamName); - } - - [Test] [TestCase(true)] [TestCase(false)] public void CreateWaterLevelCalculationActivitiesForUserDefinedTargetProbabilities_WithValidDataAndUsePreprocessorStates_ExpectedInputSetToActivities(bool usePreprocessor) @@ -295,17 +306,6 @@ } [Test] - public void CreateWaveHeightCalculationActivitiesForUserDefinedTargetProbabilities_AssessmentSectionNull_ThrowsArgumentNullException() - { - // Call - void Call() => AssessmentSectionHydraulicBoundaryLocationCalculationActivityFactory.CreateWaveHeightCalculationActivitiesForUserDefinedTargetProbabilities(null); - - // Assert - var exception = Assert.Throws(Call); - Assert.AreEqual("assessmentSection", exception.ParamName); - } - - [Test] [TestCase(true)] [TestCase(false)] public void CreateWaveHeightCalculationActivitiesForUserDefinedTargetProbabilities_WithValidDataAndUsePreprocessorStates_ExpectedInputSetToActivities(bool usePreprocessor)