Index: Ringtoets/StabilityPointStructures/src/Ringtoets.StabilityPointStructures.Forms/PropertyClasses/StabilityPointStructuresFailureMechanismProperties.cs =================================================================== diff -u -r6ac1d016e76120e778964de3ad7e2c0d6c837669 -r132c4ee6a0ed99729bb298c1d62fcd9b3f5bdf9a --- Ringtoets/StabilityPointStructures/src/Ringtoets.StabilityPointStructures.Forms/PropertyClasses/StabilityPointStructuresFailureMechanismProperties.cs (.../StabilityPointStructuresFailureMechanismProperties.cs) (revision 6ac1d016e76120e778964de3ad7e2c0d6c837669) +++ Ringtoets/StabilityPointStructures/src/Ringtoets.StabilityPointStructures.Forms/PropertyClasses/StabilityPointStructuresFailureMechanismProperties.cs (.../StabilityPointStructuresFailureMechanismProperties.cs) (revision 132c4ee6a0ed99729bb298c1d62fcd9b3f5bdf9a) @@ -88,12 +88,8 @@ } set { - IEnumerable affectedObjects = propertyChangeHandler.SetPropertyValueAfterConfirmation( - data, - value, - (f, v) => f.GeneralInput.N = v); - - NotifyAffectedObjects(affectedObjects); + data.GeneralInput.N = value; + data.NotifyObservers(); } } @@ -102,21 +98,9 @@ [DynamicVisibleValidationMethod] public bool DynamicVisibleValidationMethod(string propertyName) { - if (!data.IsRelevant && ShouldHidePropertyWhenFailureMechanismIrrelevant(propertyName)) - { - return false; - } - return true; + return data.IsRelevant || !ShouldHidePropertyWhenFailureMechanismIrrelevant(propertyName); } - private static void NotifyAffectedObjects(IEnumerable affectedObjects) - { - foreach (IObservable affectedObject in affectedObjects) - { - affectedObject.NotifyObservers(); - } - } - private bool ShouldHidePropertyWhenFailureMechanismIrrelevant(string propertyName) { return nameof(N).Equals(propertyName) Index: Ringtoets/StabilityPointStructures/test/Ringtoets.StabilityPointStructures.Forms.Test/PropertyClasses/StabilityPointStructuresFailureMechanismPropertiesTest.cs =================================================================== diff -u -r65ce8c5ab171b234e33e2291998c9d89276db896 -r132c4ee6a0ed99729bb298c1d62fcd9b3f5bdf9a --- Ringtoets/StabilityPointStructures/test/Ringtoets.StabilityPointStructures.Forms.Test/PropertyClasses/StabilityPointStructuresFailureMechanismPropertiesTest.cs (.../StabilityPointStructuresFailureMechanismPropertiesTest.cs) (revision 65ce8c5ab171b234e33e2291998c9d89276db896) +++ Ringtoets/StabilityPointStructures/test/Ringtoets.StabilityPointStructures.Forms.Test/PropertyClasses/StabilityPointStructuresFailureMechanismPropertiesTest.cs (.../StabilityPointStructuresFailureMechanismPropertiesTest.cs) (revision 132c4ee6a0ed99729bb298c1d62fcd9b3f5bdf9a) @@ -264,18 +264,16 @@ { // Setup var mockRepository = new MockRepository(); - var observable = mockRepository.StrictMock(); + var observer = mockRepository.StrictMock(); mockRepository.ReplayAll(); var failureMechanism = new StabilityPointStructuresFailureMechanism(); + failureMechanism.Attach(observer); var changeHandler = new FailureMechanismSetPropertyValueAfterConfirmationParameterTester( failureMechanism, value, - new[] - { - observable - }); + new IObservable[0]); var properties = new StabilityPointStructuresFailureMechanismProperties(failureMechanism, changeHandler); @@ -285,7 +283,6 @@ // Assert const string expectedMessage = "De waarde voor 'N' moet in het bereik [1,00, 20,00] liggen."; TestHelper.AssertThrowsArgumentExceptionAndTestMessage(test, expectedMessage); - Assert.IsTrue(changeHandler.Called); mockRepository.VerifyAll(); } @@ -297,19 +294,17 @@ { // Setup var mockRepository = new MockRepository(); - var observable = mockRepository.StrictMock(); - observable.Expect(o => o.NotifyObservers()); - + var observer = mockRepository.StrictMock(); + observer.Expect(o => o.UpdateObserver()); mockRepository.ReplayAll(); var failureMechanism = new StabilityPointStructuresFailureMechanism(); + failureMechanism.Attach(observer); + var changeHandler = new FailureMechanismSetPropertyValueAfterConfirmationParameterTester( failureMechanism, value, - new[] - { - observable - }); + new IObservable[0]); var properties = new StabilityPointStructuresFailureMechanismProperties(failureMechanism, changeHandler); @@ -318,7 +313,6 @@ // Assert Assert.AreEqual(value, failureMechanism.GeneralInput.N, failureMechanism.GeneralInput.N.GetAccuracy()); - Assert.IsTrue(changeHandler.Called); mockRepository.VerifyAll(); }