Index: Riskeer/AssemblyTool/src/Riskeer.AssemblyTool.IO/Model/DataTypes/SerializableCombinedFailureMechanismSectionAssemblyResult.cs
===================================================================
diff -u -r40f13c78443ab9b208cdd1e877198aa89c237a44 -r2dc6ed57b83ae3eef313400ff41ac5cb369f9bc9
--- Riskeer/AssemblyTool/src/Riskeer.AssemblyTool.IO/Model/DataTypes/SerializableCombinedFailureMechanismSectionAssemblyResult.cs (.../SerializableCombinedFailureMechanismSectionAssemblyResult.cs) (revision 40f13c78443ab9b208cdd1e877198aa89c237a44)
+++ Riskeer/AssemblyTool/src/Riskeer.AssemblyTool.IO/Model/DataTypes/SerializableCombinedFailureMechanismSectionAssemblyResult.cs (.../SerializableCombinedFailureMechanismSectionAssemblyResult.cs) (revision 2dc6ed57b83ae3eef313400ff41ac5cb369f9bc9)
@@ -43,17 +43,17 @@
/// Creates a new instance of .
///
/// The method used to assemble this result.
- /// The generic failure mechanism type this result is assembled for.
+ /// The generic failure mechanism code this result is assembled for.
/// The group of this assembly result.
public SerializableCombinedFailureMechanismSectionAssemblyResult(
SerializableAssemblyMethod assemblyMethod,
- SerializableFailureMechanismType genericFailureMechanismType,
+ string code,
SerializableFailureMechanismSectionAssemblyGroup assemblyGroup)
: this()
{
AssemblyGroup = assemblyGroup;
AssemblyMethod = assemblyMethod;
- GenericFailureMechanism = genericFailureMechanismType;
+ GenericFailureMechanismCode = code;
}
///
@@ -69,10 +69,10 @@
public string FailureMechanismType { get; set; }
///
- /// Gets or sets the generic failure mechanism type of this assembly result.
+ /// Gets or sets the generic failure mechanism code of this assembly result.
///
[XmlElement(AssemblyXmlIdentifiers.GenericFailureMechanism)]
- public SerializableFailureMechanismType GenericFailureMechanism { get; set; }
+ public string GenericFailureMechanismCode { get; set; }
///
/// Gets or sets the group of this assembly result.
Index: Riskeer/AssemblyTool/src/Riskeer.AssemblyTool.IO/Model/Enums/AssemblyXmlEnumIdentifiers.cs
===================================================================
diff -u -re96e57c22f4383cd69fa73661c0f0f37afe1baff -r2dc6ed57b83ae3eef313400ff41ac5cb369f9bc9
--- Riskeer/AssemblyTool/src/Riskeer.AssemblyTool.IO/Model/Enums/AssemblyXmlEnumIdentifiers.cs (.../AssemblyXmlEnumIdentifiers.cs) (revision e96e57c22f4383cd69fa73661c0f0f37afe1baff)
+++ Riskeer/AssemblyTool/src/Riskeer.AssemblyTool.IO/Model/Enums/AssemblyXmlEnumIdentifiers.cs (.../AssemblyXmlEnumIdentifiers.cs) (revision 2dc6ed57b83ae3eef313400ff41ac5cb369f9bc9)
@@ -139,85 +139,6 @@
#endregion
- #region SerializableFailureMechanismType
-
- ///
- /// Identifier for .
- ///
- public const string SerializableFailureMechanismTypeSTBI = "STBI";
-
- ///
- /// Identifier for .
- ///
- public const string SerializableFailureMechanismTypeSTPH = "STPH";
-
- ///
- /// Identifier for .
- ///
- public const string SerializableFailureMechanismTypeSTMI = "STMI";
-
- ///
- /// Identifier for .
- ///
- public const string SerializableFailureMechanismTypeAGK = "AGK";
-
- ///
- /// Identifier for .
- ///
- public const string SerializableFailureMechanismTypeAWO = "AWO";
-
- ///
- /// Identifier for .
- ///
- public const string SerializableFailureMechanismTypeGEBU = "GEBU";
-
- ///
- /// Identifier for .
- ///
- public const string SerializableFailureMechanismTypeGABU = "GABU";
-
- ///
- /// Identifier for .
- ///
- public const string SerializableFailureMechanismTypeGEKB = "GEKB";
-
- ///
- /// Identifier for .
- ///
- public const string SerializableFailureMechanismTypeGABI = "GABI";
-
- ///
- /// Identifier for .
- ///
- public const string SerializableFailureMechanismTypeZST = "ZST";
-
- ///
- /// Identifier for .
- ///
- public const string SerializableFailureMechanismTypeDA = "DA";
-
- ///
- /// Identifier for .
- ///
- public const string SerializableFailureMechanismTypeHTKW = "HTKW";
-
- ///
- /// Identifier for .
- ///
- public const string SerializableFailureMechanismTypeBSKW = "BSKW";
-
- ///
- /// Identifier for .
- ///
- public const string SerializableFailureMechanismTypePKW = "PKW";
-
- ///
- /// Identifier for .
- ///
- public const string SerializableFailureMechanismTypeSTKWp = "STKWp";
-
- #endregion
-
#region SerializableFailureMechanismSectionType
///
Fisheye: Tag 2dc6ed57b83ae3eef313400ff41ac5cb369f9bc9 refers to a dead (removed) revision in file `Riskeer/AssemblyTool/src/Riskeer.AssemblyTool.IO/Model/Enums/SerializableFailureMechanismType.cs'.
Fisheye: No comparison available. Pass `N' to diff?
Index: Riskeer/AssemblyTool/src/Riskeer.AssemblyTool.IO/Model/SerializableFailureMechanism.cs
===================================================================
diff -u -ra1090298a1bbfca8db1877eed50cab25a1d00cc8 -r2dc6ed57b83ae3eef313400ff41ac5cb369f9bc9
--- Riskeer/AssemblyTool/src/Riskeer.AssemblyTool.IO/Model/SerializableFailureMechanism.cs (.../SerializableFailureMechanism.cs) (revision a1090298a1bbfca8db1877eed50cab25a1d00cc8)
+++ Riskeer/AssemblyTool/src/Riskeer.AssemblyTool.IO/Model/SerializableFailureMechanism.cs (.../SerializableFailureMechanism.cs) (revision 2dc6ed57b83ae3eef313400ff41ac5cb369f9bc9)
@@ -22,7 +22,6 @@
using System;
using System.Xml.Serialization;
using Riskeer.AssemblyTool.IO.Model.DataTypes;
-using Riskeer.AssemblyTool.IO.Model.Enums;
using Riskeer.AssemblyTool.IO.Model.Helpers;
using Riskeer.AssemblyTool.IO.Properties;
@@ -47,12 +46,12 @@
///
/// The unique ID of the assembly result.
/// The total assembly result the failure mechanism belongs to.
- /// The type of the failure mechanism.
+ /// The code of the failure mechanism.
/// The total failure mechanism assembly result.
/// Thrown when any parameter except is null.
/// Thrown when is invalid.
public SerializableFailureMechanism(string id, SerializableTotalAssemblyResult totalAssemblyResult,
- SerializableFailureMechanismType failureMechanismType,
+ string code,
SerializableFailureMechanismAssemblyResult failureMechanismAssemblyResult)
: this()
{
@@ -73,7 +72,7 @@
Id = id;
TotalAssemblyResultId = totalAssemblyResult.Id;
- GenericFailureMechanism = failureMechanismType;
+ GenericFailureMechanismCode = code;
FailureMechanismAssemblyResult = failureMechanismAssemblyResult;
}
@@ -96,10 +95,10 @@
public string FailureMechanismType { get; set; }
///
- /// Gets or sets the generic failure mechanism type.
+ /// Gets or sets the generic failure mechanism code.
///
[XmlElement(AssemblyXmlIdentifiers.GenericFailureMechanism)]
- public SerializableFailureMechanismType GenericFailureMechanism { get; set; }
+ public string GenericFailureMechanismCode { get; set; }
///
/// Gets or sets the total failure mechanism assembly result.
Index: Riskeer/AssemblyTool/test/Riskeer.AssemblyTool.IO.Test/Model/DataTypes/SerializableCombinedFailureMechanismSectionAssemblyResultTest.cs
===================================================================
diff -u -ra1090298a1bbfca8db1877eed50cab25a1d00cc8 -r2dc6ed57b83ae3eef313400ff41ac5cb369f9bc9
--- Riskeer/AssemblyTool/test/Riskeer.AssemblyTool.IO.Test/Model/DataTypes/SerializableCombinedFailureMechanismSectionAssemblyResultTest.cs (.../SerializableCombinedFailureMechanismSectionAssemblyResultTest.cs) (revision a1090298a1bbfca8db1877eed50cab25a1d00cc8)
+++ Riskeer/AssemblyTool/test/Riskeer.AssemblyTool.IO.Test/Model/DataTypes/SerializableCombinedFailureMechanismSectionAssemblyResultTest.cs (.../SerializableCombinedFailureMechanismSectionAssemblyResultTest.cs) (revision 2dc6ed57b83ae3eef313400ff41ac5cb369f9bc9)
@@ -39,7 +39,7 @@
// Assert
Assert.AreEqual((SerializableAssemblyMethod) 0, assemblyResult.AssemblyMethod);
- Assert.AreEqual((SerializableFailureMechanismType) 0, assemblyResult.GenericFailureMechanism);
+ Assert.IsNull( assemblyResult.GenericFailureMechanismCode);
Assert.AreEqual((SerializableFailureMechanismSectionAssemblyGroup) 0, assemblyResult.AssemblyGroup);
Assert.AreEqual("VOLLDG", assemblyResult.Status);
Assert.AreEqual("GENRK", assemblyResult.FailureMechanismType);
@@ -49,7 +49,7 @@
SerializableAttributeTestHelper.AssertXmlElementAttribute(
nameof(SerializableCombinedFailureMechanismSectionAssemblyResult.AssemblyGroup), "duidingsklasse");
SerializableAttributeTestHelper.AssertXmlElementAttribute(
- nameof(SerializableCombinedFailureMechanismSectionAssemblyResult.GenericFailureMechanism), "generiekFaalmechanisme");
+ nameof(SerializableCombinedFailureMechanismSectionAssemblyResult.GenericFailureMechanismCode), "generiekFaalmechanisme");
SerializableAttributeTestHelper.AssertXmlElementAttribute(
nameof(SerializableCombinedFailureMechanismSectionAssemblyResult.FailureMechanismType), "typeFaalmechanisme");
SerializableAttributeTestHelper.AssertXmlElementAttribute(
@@ -62,16 +62,16 @@
// Setup
var random = new Random(39);
var assemblyMethod = random.NextEnumValue();
- var genericFailureMechanism = random.NextEnumValue();
+ const string code = "code";
var assemblyGroup = random.NextEnumValue();
// Call
- var assemblyResult = new SerializableCombinedFailureMechanismSectionAssemblyResult(assemblyMethod, genericFailureMechanism, assemblyGroup);
+ var assemblyResult = new SerializableCombinedFailureMechanismSectionAssemblyResult(assemblyMethod, code, assemblyGroup);
// Assert
Assert.AreEqual(assemblyMethod, assemblyResult.AssemblyMethod);
Assert.AreEqual(assemblyGroup, assemblyResult.AssemblyGroup);
- Assert.AreEqual(genericFailureMechanism, assemblyResult.GenericFailureMechanism);
+ Assert.AreEqual(code, assemblyResult.GenericFailureMechanismCode);
Assert.AreEqual("VOLLDG", assemblyResult.Status);
Assert.AreEqual("GENRK", assemblyResult.FailureMechanismType);
}
Index: Riskeer/AssemblyTool/test/Riskeer.AssemblyTool.IO.Test/Model/Enums/AssemblyXmlEnumIdentifiersTest.cs
===================================================================
diff -u -re96e57c22f4383cd69fa73661c0f0f37afe1baff -r2dc6ed57b83ae3eef313400ff41ac5cb369f9bc9
--- Riskeer/AssemblyTool/test/Riskeer.AssemblyTool.IO.Test/Model/Enums/AssemblyXmlEnumIdentifiersTest.cs (.../AssemblyXmlEnumIdentifiersTest.cs) (revision e96e57c22f4383cd69fa73661c0f0f37afe1baff)
+++ Riskeer/AssemblyTool/test/Riskeer.AssemblyTool.IO.Test/Model/Enums/AssemblyXmlEnumIdentifiersTest.cs (.../AssemblyXmlEnumIdentifiersTest.cs) (revision 2dc6ed57b83ae3eef313400ff41ac5cb369f9bc9)
@@ -53,22 +53,6 @@
Assert.AreEqual("WBI-3C-1", AssemblyXmlEnumIdentifiers.SerializableAssemblyMethodWBI3C1);
Assert.AreEqual("Handmatig", AssemblyXmlEnumIdentifiers.SerializableAssemblyMethodManual);
- Assert.AreEqual("STBI", AssemblyXmlEnumIdentifiers.SerializableFailureMechanismTypeSTBI);
- Assert.AreEqual("STPH", AssemblyXmlEnumIdentifiers.SerializableFailureMechanismTypeSTPH);
- Assert.AreEqual("STMI", AssemblyXmlEnumIdentifiers.SerializableFailureMechanismTypeSTMI);
- Assert.AreEqual("AGK", AssemblyXmlEnumIdentifiers.SerializableFailureMechanismTypeAGK);
- Assert.AreEqual("AWO", AssemblyXmlEnumIdentifiers.SerializableFailureMechanismTypeAWO);
- Assert.AreEqual("GEBU", AssemblyXmlEnumIdentifiers.SerializableFailureMechanismTypeGEBU);
- Assert.AreEqual("GABU", AssemblyXmlEnumIdentifiers.SerializableFailureMechanismTypeGABU);
- Assert.AreEqual("GEKB", AssemblyXmlEnumIdentifiers.SerializableFailureMechanismTypeGEKB);
- Assert.AreEqual("GABI", AssemblyXmlEnumIdentifiers.SerializableFailureMechanismTypeGABI);
- Assert.AreEqual("ZST", AssemblyXmlEnumIdentifiers.SerializableFailureMechanismTypeZST);
- Assert.AreEqual("DA", AssemblyXmlEnumIdentifiers.SerializableFailureMechanismTypeDA);
- Assert.AreEqual("HTKW", AssemblyXmlEnumIdentifiers.SerializableFailureMechanismTypeHTKW);
- Assert.AreEqual("BSKW", AssemblyXmlEnumIdentifiers.SerializableFailureMechanismTypeBSKW);
- Assert.AreEqual("PKW", AssemblyXmlEnumIdentifiers.SerializableFailureMechanismTypePKW);
- Assert.AreEqual("STKWp", AssemblyXmlEnumIdentifiers.SerializableFailureMechanismTypeSTKWp);
-
Assert.AreEqual("FAALMVK", AssemblyXmlEnumIdentifiers.SerializableFailureMechanismSectionTypeFailureMechanism);
Assert.AreEqual("DEELVK", AssemblyXmlEnumIdentifiers.SerializableFailureMechanismSectionTypeCombined);
}
Fisheye: Tag 2dc6ed57b83ae3eef313400ff41ac5cb369f9bc9 refers to a dead (removed) revision in file `Riskeer/AssemblyTool/test/Riskeer.AssemblyTool.IO.Test/Model/Enums/SerializableFailureMechanismTypeTest.cs'.
Fisheye: No comparison available. Pass `N' to diff?
Index: Riskeer/AssemblyTool/test/Riskeer.AssemblyTool.IO.Test/Model/SerializableFailureMechanismSectionAssemblyTest.cs
===================================================================
diff -u -r4944cd3d81cde6827703ce8a475f8c51935b4bc9 -r2dc6ed57b83ae3eef313400ff41ac5cb369f9bc9
--- Riskeer/AssemblyTool/test/Riskeer.AssemblyTool.IO.Test/Model/SerializableFailureMechanismSectionAssemblyTest.cs (.../SerializableFailureMechanismSectionAssemblyTest.cs) (revision 4944cd3d81cde6827703ce8a475f8c51935b4bc9)
+++ Riskeer/AssemblyTool/test/Riskeer.AssemblyTool.IO.Test/Model/SerializableFailureMechanismSectionAssemblyTest.cs (.../SerializableFailureMechanismSectionAssemblyTest.cs) (revision 2dc6ed57b83ae3eef313400ff41ac5cb369f9bc9)
@@ -119,7 +119,7 @@
var random = new Random(39);
var failureMechanism = new SerializableFailureMechanism("failureMechanismID",
new SerializableTotalAssemblyResult(),
- random.NextEnumValue(),
+ "code",
new SerializableFailureMechanismAssemblyResult());
var section = new SerializableFailureMechanismSection("sectionID",
new SerializableFailureMechanismSectionCollection(),
Index: Riskeer/AssemblyTool/test/Riskeer.AssemblyTool.IO.Test/Model/SerializableFailureMechanismTest.cs
===================================================================
diff -u -r16ecb0ef67f466c0678dbccbdfdefce0f0230b94 -r2dc6ed57b83ae3eef313400ff41ac5cb369f9bc9
--- Riskeer/AssemblyTool/test/Riskeer.AssemblyTool.IO.Test/Model/SerializableFailureMechanismTest.cs (.../SerializableFailureMechanismTest.cs) (revision 16ecb0ef67f466c0678dbccbdfdefce0f0230b94)
+++ Riskeer/AssemblyTool/test/Riskeer.AssemblyTool.IO.Test/Model/SerializableFailureMechanismTest.cs (.../SerializableFailureMechanismTest.cs) (revision 2dc6ed57b83ae3eef313400ff41ac5cb369f9bc9)
@@ -24,7 +24,6 @@
using NUnit.Framework;
using Riskeer.AssemblyTool.IO.Model;
using Riskeer.AssemblyTool.IO.Model.DataTypes;
-using Riskeer.AssemblyTool.IO.Model.Enums;
using Riskeer.AssemblyTool.IO.TestUtil;
namespace Riskeer.AssemblyTool.IO.Test.Model
@@ -43,7 +42,7 @@
Assert.IsNull(failureMechanism.Id);
Assert.IsNull(failureMechanism.TotalAssemblyResultId);
Assert.IsNull(failureMechanism.FailureMechanismAssemblyResult);
- Assert.AreEqual((SerializableFailureMechanismType) 0, failureMechanism.GenericFailureMechanism);
+ Assert.IsNull(failureMechanism.GenericFailureMechanismCode);
Assert.AreEqual("GENRK", failureMechanism.FailureMechanismType);
SerializableAttributeTestHelper.AssertXmlTypeAttribute(typeof(SerializableFailureMechanism), "Faalmechanisme");
@@ -54,7 +53,7 @@
nameof(SerializableFailureMechanism.TotalAssemblyResultId), "VeiligheidsoordeelIDRef");
SerializableAttributeTestHelper.AssertXmlElementAttribute(
- nameof(SerializableFailureMechanism.GenericFailureMechanism), "generiekFaalmechanisme");
+ nameof(SerializableFailureMechanism.GenericFailureMechanismCode), "generiekFaalmechanisme");
SerializableAttributeTestHelper.AssertXmlElementAttribute(
nameof(SerializableFailureMechanism.FailureMechanismType), "typeFaalmechanisme");
SerializableAttributeTestHelper.AssertXmlElementAttribute(
@@ -65,13 +64,9 @@
[TestCaseSource(typeof(InvalidIdTestHelper), nameof(InvalidIdTestHelper.InvalidIdCases))]
public void Constructor_InvalidId_ThrowsArgumentException(string invalidId)
{
- // Setup
- var random = new Random(39);
-
// Call
void Call() => new SerializableFailureMechanism(invalidId, new SerializableTotalAssemblyResult(),
- random.NextEnumValue(),
- new SerializableFailureMechanismAssemblyResult());
+ "code", new SerializableFailureMechanismAssemblyResult());
// Assert
const string expectedMessage = "'id' must have a value and consist only of alphanumerical characters, '-', '_' or '.'.";
@@ -81,11 +76,8 @@
[Test]
public void Constructor_TotalAssemblyResultNull_ThrowsArgumentNullException()
{
- // Setup
- var random = new Random(39);
-
// Call
- void Call() => new SerializableFailureMechanism("id", null, random.NextEnumValue(),
+ void Call() => new SerializableFailureMechanism("id", null, "code",
new SerializableFailureMechanismAssemblyResult());
// Assert
@@ -96,12 +88,9 @@
[Test]
public void Constructor_FailureMechanismAssemblyResultNull_ThrowsArgumentNullException()
{
- // Setup
- var random = new Random(39);
-
// Call
void Call() => new SerializableFailureMechanism("id", new SerializableTotalAssemblyResult(),
- random.NextEnumValue(), null);
+ "code", null);
// Assert
var exception = Assert.Throws(Call);
@@ -115,22 +104,19 @@
const string id = "sectionId";
const string totalResultId = "totalResultId";
- var random = new Random(39);
- var type = random.NextEnumValue();
+ const string code = "code";
var assemblyResult = new SerializableFailureMechanismAssemblyResult();
// Call
- var failureMechanism = new SerializableFailureMechanism(id,
- new SerializableTotalAssemblyResult(totalResultId,
- new SerializableAssessmentProcess(),
- new SerializableAssessmentSectionAssemblyResult()),
- type,
- assemblyResult);
+ var failureMechanism = new SerializableFailureMechanism(
+ id, new SerializableTotalAssemblyResult(
+ totalResultId, new SerializableAssessmentProcess(), new SerializableAssessmentSectionAssemblyResult()),
+ code, assemblyResult);
// Assert
Assert.AreEqual(id, failureMechanism.Id);
Assert.AreEqual(totalResultId, failureMechanism.TotalAssemblyResultId);
- Assert.AreEqual(type, failureMechanism.GenericFailureMechanism);
+ Assert.AreEqual(code, failureMechanism.GenericFailureMechanismCode);
Assert.AreSame(assemblyResult, failureMechanism.FailureMechanismAssemblyResult);
}
}
Index: Riskeer/AssemblyTool/test/Riskeer.AssemblyTool.IO.Test/SerializableAssemblyWriterTest.cs
===================================================================
diff -u -r0102f161e02186c2fb3d2990d168d7271c1b1085 -r2dc6ed57b83ae3eef313400ff41ac5cb369f9bc9
--- Riskeer/AssemblyTool/test/Riskeer.AssemblyTool.IO.Test/SerializableAssemblyWriterTest.cs (.../SerializableAssemblyWriterTest.cs) (revision 0102f161e02186c2fb3d2990d168d7271c1b1085)
+++ Riskeer/AssemblyTool/test/Riskeer.AssemblyTool.IO.Test/SerializableAssemblyWriterTest.cs (.../SerializableAssemblyWriterTest.cs) (revision 2dc6ed57b83ae3eef313400ff41ac5cb369f9bc9)
@@ -284,8 +284,8 @@
var failureMechanism = new SerializableFailureMechanism(
"toetsspoorGABI",
totalAssemblyResult,
- SerializableFailureMechanismType.GABI,
- new SerializableFailureMechanismAssemblyResult(0.08419, false));
+ "GABI",
+ new SerializableFailureMechanismAssemblyResult(0.08419, false));
var sections1 = new SerializableFailureMechanismSectionCollection("vakindelingGABI");
var section1 = new SerializableFailureMechanismSection(
@@ -325,10 +325,10 @@
new[]
{
new SerializableCombinedFailureMechanismSectionAssemblyResult(
- SerializableAssemblyMethod.WBI3B1, SerializableFailureMechanismType.HTKW,
+ SerializableAssemblyMethod.WBI3B1, "HTKW",
SerializableFailureMechanismSectionAssemblyGroup.III),
new SerializableCombinedFailureMechanismSectionAssemblyResult(
- SerializableAssemblyMethod.WBI3B1, SerializableFailureMechanismType.STPH,
+ SerializableAssemblyMethod.WBI3B1, "STPH",
SerializableFailureMechanismSectionAssemblyGroup.II)
},
new SerializableFailureMechanismSectionAssemblyResult(