Index: Ringtoets/Common/src/Ringtoets.Common.IO/FileImporters/HydraulicBoundaryDatabaseImporter.cs =================================================================== diff -u -re2892835ceb1c916be9a9122ba372858f20b981a -r3147d2f42ddbf18f08e0015f71aeeec2de60dd89 --- Ringtoets/Common/src/Ringtoets.Common.IO/FileImporters/HydraulicBoundaryDatabaseImporter.cs (.../HydraulicBoundaryDatabaseImporter.cs) (revision e2892835ceb1c916be9a9122ba372858f20b981a) +++ Ringtoets/Common/src/Ringtoets.Common.IO/FileImporters/HydraulicBoundaryDatabaseImporter.cs (.../HydraulicBoundaryDatabaseImporter.cs) (revision 3147d2f42ddbf18f08e0015f71aeeec2de60dd89) @@ -172,7 +172,7 @@ bool canUsePreprocessor = hydraulicLocationConfigurationDatabaseReader.GetCanUsePreprocessorByTrackId(trackId); HydraulicBoundaryDatabase hydraulicBoundaryDatabase = canUsePreprocessor - ? new HydraulicBoundaryDatabase(true, Path.Combine(Path.GetDirectoryName(hydraulicBoundaryDatabaseFilePath))) + ? new HydraulicBoundaryDatabase(true, Path.GetDirectoryName(hydraulicBoundaryDatabaseFilePath)) : new HydraulicBoundaryDatabase(); hydraulicBoundaryDatabase.FilePath = hydraulicBoundaryDatabaseFilePath; Index: Ringtoets/Common/test/Ringtoets.Common.IO.Test/FileImporters/HydraulicBoundaryDatabaseImporterTest.cs =================================================================== diff -u -rf8c28b3b04cdabb62ea37772efcb1f4ebbbf2b9e -r3147d2f42ddbf18f08e0015f71aeeec2de60dd89 --- Ringtoets/Common/test/Ringtoets.Common.IO.Test/FileImporters/HydraulicBoundaryDatabaseImporterTest.cs (.../HydraulicBoundaryDatabaseImporterTest.cs) (revision f8c28b3b04cdabb62ea37772efcb1f4ebbbf2b9e) +++ Ringtoets/Common/test/Ringtoets.Common.IO.Test/FileImporters/HydraulicBoundaryDatabaseImporterTest.cs (.../HydraulicBoundaryDatabaseImporterTest.cs) (revision 3147d2f42ddbf18f08e0015f71aeeec2de60dd89) @@ -329,7 +329,7 @@ } [Test] - public void Import_ImportingToValidTargetWithValidFileUsePreprocessorTrue_ImportHydraulicBoundaryLocationsToCollectionAndAssessmentSectionNotified() + public void Import_ImportingToValidTargetWithValidFileCanUsePreprocessorTrue_ImportHydraulicBoundaryLocationsToCollectionAndAssessmentSectionNotified() { // Setup var mocks = new MockRepository(); @@ -355,6 +355,7 @@ }); Assert.IsTrue(importResult); Assert.IsTrue(assessmentSection.HydraulicBoundaryDatabase.CanUsePreprocessor); + Assert.IsTrue(assessmentSection.HydraulicBoundaryDatabase.UsePreprocessor); Assert.AreEqual(directory, assessmentSection.HydraulicBoundaryDatabase.PreprocessorDirectory); ICollection importedLocations = assessmentSection.HydraulicBoundaryDatabase.Locations; Assert.AreEqual(106, importedLocations.Count); @@ -364,7 +365,7 @@ } [Test] - public void Import_ImportingToValidTargetWithValidFileUsePreprocessorFalse_ImportHydraulicBoundaryLocationsToCollectionAndAssessmentSectionNotified() + public void Import_ImportingToValidTargetWithValidFileCanUsePreprocessorFalse_ImportHydraulicBoundaryLocationsToCollectionAndAssessmentSectionNotified() { // Setup var mocks = new MockRepository(); @@ -389,7 +390,6 @@ }); Assert.IsTrue(importResult); Assert.IsFalse(assessmentSection.HydraulicBoundaryDatabase.CanUsePreprocessor); - Assert.IsNull(assessmentSection.HydraulicBoundaryDatabase.PreprocessorDirectory); ICollection importedLocations = assessmentSection.HydraulicBoundaryDatabase.Locations; Assert.AreEqual(9, importedLocations.Count); CollectionAssert.AllItemsAreNotNull(importedLocations); Index: Ringtoets/HydraRing/src/Ringtoets.HydraRing.IO/HydraulicLocationConfigurationDatabaseContext/HydraulicLocationConfigurationSqLiteDatabaseReader.cs =================================================================== diff -u -rf8c28b3b04cdabb62ea37772efcb1f4ebbbf2b9e -r3147d2f42ddbf18f08e0015f71aeeec2de60dd89 --- Ringtoets/HydraRing/src/Ringtoets.HydraRing.IO/HydraulicLocationConfigurationDatabaseContext/HydraulicLocationConfigurationSqLiteDatabaseReader.cs (.../HydraulicLocationConfigurationSqLiteDatabaseReader.cs) (revision f8c28b3b04cdabb62ea37772efcb1f4ebbbf2b9e) +++ Ringtoets/HydraRing/src/Ringtoets.HydraRing.IO/HydraulicLocationConfigurationDatabaseContext/HydraulicLocationConfigurationSqLiteDatabaseReader.cs (.../HydraulicLocationConfigurationSqLiteDatabaseReader.cs) (revision 3147d2f42ddbf18f08e0015f71aeeec2de60dd89) @@ -56,8 +56,8 @@ /// /// Gets the location ids from the database, based upon . /// - /// Hydraulic boundary track id. - /// List of location id and Hrd location id found in the database. + /// The hydraulic boundary track id. + /// A dictionary with pairs of Hrd location id (key) and location id (value) as found in the database. /// Thrown when the database query failed. /// Thrown when the database returned incorrect values for /// required properties. @@ -89,10 +89,10 @@ /// /// Gets whether the preprocessor can be used for the given . /// - /// Hydraulic boundary track id. + /// The hydraulic boundary track id. /// The value found in the database; or false when the database - /// is valid but outdated (no usePreprocessor column present). - /// Thrown when the database query failed. + /// is valid but outdated (no UsePreprocessor column present). + /// Thrown when the database query failed or when no results could be found. /// Thrown when the database returned incorrect values for /// required properties. public bool GetCanUsePreprocessorByTrackId(long trackId) @@ -123,8 +123,8 @@ /// /// Gets the location ids from the database, based upon . /// - /// Hydraulic boundary track id. - /// List of location id and Hrd location id found in the database. + /// A parameter containing the hydraulic boundary track id. + /// A dictionary with pairs of Hrd location id (key) and location id (value) as found in the database. /// Thrown when the database query failed. /// Thrown when the database returned incorrect values for /// required properties. @@ -156,9 +156,9 @@ /// /// Gets whether the preprocessor can be used for the given . /// - /// Hydraulic boundary track id. + /// A parameter containing the hydraulic boundary track id. /// The value found in the database; or false when the database - /// is valid but outdated (no usePreprocessor column present). + /// is valid but outdated (no UsePreprocessor column present). /// Thrown when the database query failed. /// Thrown when the database returned incorrect values for /// required properties.