Index: Ringtoets/Common/src/Ringtoets.Common.Forms/TreeNodeInfos/RingtoetsContextMenuItemFactory.cs =================================================================== diff -u -r09c09d852a24510f1c63db1065a50ebc20471f55 -r31a41fbf921e5ef9b61fbd1e1f07ae919c8aadca --- Ringtoets/Common/src/Ringtoets.Common.Forms/TreeNodeInfos/RingtoetsContextMenuItemFactory.cs (.../RingtoetsContextMenuItemFactory.cs) (revision 09c09d852a24510f1c63db1065a50ebc20471f55) +++ Ringtoets/Common/src/Ringtoets.Common.Forms/TreeNodeInfos/RingtoetsContextMenuItemFactory.cs (.../RingtoetsContextMenuItemFactory.cs) (revision 31a41fbf921e5ef9b61fbd1e1f07ae919c8aadca) @@ -377,6 +377,10 @@ /// The created . public static StrictContextMenuItem CreateRemoveAllChildrenFromGroupItem(CalculationGroup calculationGroup, IViewCommands viewCommands) { + if (viewCommands == null) + { + throw new ArgumentNullException("viewCommands"); + } var menuItem = new StrictContextMenuItem( Resources.CalculationGroup_RemoveAllChildrenFromGroup_Remove_all, Resources.CalculationGroup_RemoveAllChildrenFromGroup_Remove_all_Tooltip, Index: Ringtoets/GrassCoverErosionInwards/test/Ringtoets.GrassCoverErosionInwards.Forms.Test/TreeNodeInfos/GrassCoverErosionInwardsCalculationGroupContextTreeNodeInfoTest.cs =================================================================== diff -u -r1141016ecbde1e84658f0a617eed864a547dd1ac -r31a41fbf921e5ef9b61fbd1e1f07ae919c8aadca --- Ringtoets/GrassCoverErosionInwards/test/Ringtoets.GrassCoverErosionInwards.Forms.Test/TreeNodeInfos/GrassCoverErosionInwardsCalculationGroupContextTreeNodeInfoTest.cs (.../GrassCoverErosionInwardsCalculationGroupContextTreeNodeInfoTest.cs) (revision 1141016ecbde1e84658f0a617eed864a547dd1ac) +++ Ringtoets/GrassCoverErosionInwards/test/Ringtoets.GrassCoverErosionInwards.Forms.Test/TreeNodeInfos/GrassCoverErosionInwardsCalculationGroupContextTreeNodeInfoTest.cs (.../GrassCoverErosionInwardsCalculationGroupContextTreeNodeInfoTest.cs) (revision 31a41fbf921e5ef9b61fbd1e1f07ae919c8aadca) @@ -188,6 +188,7 @@ using (var treeViewControl = new TreeViewControl()) { guiMock.Expect(cmp => cmp.Get(groupContext, treeViewControl)).Return(menuBuilderMock); + guiMock.Stub(cmp => cmp.ViewCommands).Return(mocks.Stub()); mocks.ReplayAll(); // Call @@ -213,6 +214,7 @@ var menuBuilder = new CustomItemsOnlyContextMenuBuilder(); guiMock.Expect(g => g.Get(groupContext, treeViewControl)).Return(menuBuilder); + guiMock.Stub(cmp => cmp.ViewCommands).Return(mocks.Stub()); mocks.ReplayAll(); @@ -383,6 +385,7 @@ nodeData, treeViewControl); guiMock.Expect(g => g.Get(nodeData, treeViewControl)).Return(menuBuilder); + guiMock.Stub(cmp => cmp.ViewCommands).Return(mocks.Stub()); mocks.ReplayAll(); // Call @@ -437,6 +440,7 @@ nodeData, treeViewControl); guiMock.Expect(g => g.Get(nodeData, treeViewControl)).Return(menuBuilder); + guiMock.Stub(cmp => cmp.ViewCommands).Return(mocks.Stub()); mocks.ReplayAll(); // Call @@ -491,6 +495,7 @@ nodeData, treeViewControl); guiMock.Expect(g => g.Get(nodeData, treeViewControl)).Return(menuBuilder); + guiMock.Stub(cmp => cmp.ViewCommands).Return(mocks.Stub()); mocks.ReplayAll(); // Call @@ -544,6 +549,7 @@ using (var treeViewControl = new TreeViewControl()) { guiMock.Expect(g => g.Get(nodeData, treeViewControl)).Return(menuBuilder); + guiMock.Stub(cmp => cmp.ViewCommands).Return(mocks.Stub()); mocks.ReplayAll(); @@ -575,6 +581,7 @@ { var menuBuilder = new CustomItemsOnlyContextMenuBuilder(); guiMock.Expect(g => g.Get(nodeData, treeViewControl)).Return(menuBuilder); + guiMock.Stub(cmp => cmp.ViewCommands).Return(mocks.Stub()); mocks.ReplayAll(); @@ -608,6 +615,7 @@ { var menuBuilder = new CustomItemsOnlyContextMenuBuilder(); guiMock.Expect(g => g.Get(nodeData, treeViewControl)).Return(menuBuilder); + guiMock.Stub(cmp => cmp.ViewCommands).Return(mocks.Stub()); mocks.ReplayAll(); @@ -670,6 +678,7 @@ using (var treeViewControl = new TreeViewControl()) { guiMock.Expect(g => g.Get(groupContext, treeViewControl)).Return(menuBuilder); + guiMock.Stub(cmp => cmp.ViewCommands).Return(mocks.Stub()); mocks.ReplayAll(); @@ -742,6 +751,7 @@ { guiMock.Expect(g => g.Get(groupContext, treeViewControl)).Return(menuBuilder); guiMock.Expect(g => g.MainWindow).Return(mainWindowStub); + guiMock.Stub(cmp => cmp.ViewCommands).Return(mocks.Stub()); mocks.ReplayAll(); @@ -799,6 +809,7 @@ using (var treeViewControl = new TreeViewControl()) { guiMock.Expect(cmp => cmp.Get(nodeData, treeViewControl)).Return(menuBuilder); + guiMock.Stub(cmp => cmp.ViewCommands).Return(mocks.Stub()); mocks.ReplayAll(); @@ -843,6 +854,7 @@ using (var treeViewControl = new TreeViewControl()) { guiMock.Expect(cmp => cmp.Get(nodeData, treeViewControl)).Return(menuBuilder); + guiMock.Stub(cmp => cmp.ViewCommands).Return(mocks.Stub()); mocks.ReplayAll(); @@ -872,11 +884,12 @@ // Setup using (var treeViewControl = new TreeViewControl()) { + var calculation = mocks.Stub(); var group = new CalculationGroup { Children = { - mocks.Stub() + calculation } }; @@ -887,13 +900,15 @@ assessmentSectionMock); var menuBuilder = new CustomItemsOnlyContextMenuBuilder(); + var viewCommandsMock = mocks.StrictMock(); + viewCommandsMock.Expect(vc => vc.RemoveAllViewsForItem(calculation)); - var gui = mocks.StrictMock(); - gui.Expect(cmp => cmp.Get(nodeData, treeViewControl)).Return(menuBuilder); + guiMock.Expect(cmp => cmp.Get(nodeData, treeViewControl)).Return(menuBuilder); + guiMock.Stub(cmp => cmp.ViewCommands).Return(viewCommandsMock); mocks.ReplayAll(); - plugin.Gui = gui; + plugin.Gui = guiMock; DialogBoxHandler = (name, wnd) => { @@ -938,13 +953,13 @@ var menuBuilder = new CustomItemsOnlyContextMenuBuilder(); var mainWindow = mocks.Stub(); - var gui = mocks.StrictMock(); - gui.Expect(cmp => cmp.Get(nodeData, treeViewControl)).Return(menuBuilder); - gui.Expect(g => g.MainWindow).Return(mainWindow); + guiMock.Expect(cmp => cmp.Get(nodeData, treeViewControl)).Return(menuBuilder); + guiMock.Expect(g => g.MainWindow).Return(mainWindow); + guiMock.Stub(cmp => cmp.ViewCommands).Return(mocks.Stub()); mocks.ReplayAll(); - plugin.Gui = gui; + plugin.Gui = guiMock; DialogBoxHandler = (name, wnd) => { @@ -994,13 +1009,13 @@ var menuBuilder = new CustomItemsOnlyContextMenuBuilder(); var mainWindow = mocks.Stub(); - var gui = mocks.StrictMock(); - gui.Expect(cmp => cmp.Get(nodeData, treeViewControl)).Return(menuBuilder); - gui.Expect(g => g.MainWindow).Return(mainWindow); + guiMock.Expect(cmp => cmp.Get(nodeData, treeViewControl)).Return(menuBuilder); + guiMock.Expect(g => g.MainWindow).Return(mainWindow); + guiMock.Stub(cmp => cmp.ViewCommands).Return(mocks.Stub()); mocks.ReplayAll(); - plugin.Gui = gui; + plugin.Gui = guiMock; DialogBoxHandler = (name, wnd) => { @@ -1058,13 +1073,13 @@ var menuBuilder = new CustomItemsOnlyContextMenuBuilder(); var mainWindow = mocks.Stub(); - var gui = mocks.StrictMock(); - gui.Expect(cmp => cmp.Get(nodeData, treeViewControl)).Return(menuBuilder); - gui.Expect(g => g.MainWindow).Return(mainWindow); + guiMock.Expect(cmp => cmp.Get(nodeData, treeViewControl)).Return(menuBuilder); + guiMock.Expect(g => g.MainWindow).Return(mainWindow); + guiMock.Stub(cmp => cmp.ViewCommands).Return(mocks.Stub()); mocks.ReplayAll(); - plugin.Gui = gui; + plugin.Gui = guiMock; DialogBoxHandler = (name, wnd) => { Index: Ringtoets/HeightStructures/test/Ringtoets.HeightStructures.Forms.Test/TreeNodeInfos/HeightStructuresCalculationGroupContextTreeNodeInfoTest.cs =================================================================== diff -u -r1141016ecbde1e84658f0a617eed864a547dd1ac -r31a41fbf921e5ef9b61fbd1e1f07ae919c8aadca --- Ringtoets/HeightStructures/test/Ringtoets.HeightStructures.Forms.Test/TreeNodeInfos/HeightStructuresCalculationGroupContextTreeNodeInfoTest.cs (.../HeightStructuresCalculationGroupContextTreeNodeInfoTest.cs) (revision 1141016ecbde1e84658f0a617eed864a547dd1ac) +++ Ringtoets/HeightStructures/test/Ringtoets.HeightStructures.Forms.Test/TreeNodeInfos/HeightStructuresCalculationGroupContextTreeNodeInfoTest.cs (.../HeightStructuresCalculationGroupContextTreeNodeInfoTest.cs) (revision 31a41fbf921e5ef9b61fbd1e1f07ae919c8aadca) @@ -26,6 +26,7 @@ using Core.Common.Base.Geometry; using Core.Common.Controls.TreeView; using Core.Common.Gui; +using Core.Common.Gui.Commands; using Core.Common.Gui.ContextMenu; using Core.Common.Gui.Forms.MainWindow; using Core.Common.Gui.TestUtil.ContextMenu; @@ -181,6 +182,7 @@ using (var treeViewControl = new TreeViewControl()) { guiMock.Expect(cmp => cmp.Get(groupContext, treeViewControl)).Return(menuBuilderMock); + guiMock.Stub(cmp => cmp.ViewCommands).Return(mocks.Stub()); mocks.ReplayAll(); @@ -203,12 +205,13 @@ assessmentSectionMock); var menuBuilder = new CustomItemsOnlyContextMenuBuilder(); - mocks.ReplayAll(); - using (var treeViewControl = new TreeViewControl()) { guiMock.Expect(g => g.Get(groupContext, treeViewControl)).Return(menuBuilder); + guiMock.Stub(cmp => cmp.ViewCommands).Return(mocks.Stub()); + mocks.ReplayAll(); + // Call ContextMenuStrip menu = info.ContextMenuStrip(groupContext, null, treeViewControl); @@ -371,6 +374,7 @@ using (var treeViewControl = new TreeViewControl()) { guiMock.Expect(g => g.Get(nodeData, treeViewControl)).Return(menuBuilder); + guiMock.Stub(cmp => cmp.ViewCommands).Return(mocks.Stub()); mocks.ReplayAll(); @@ -417,6 +421,7 @@ using (var treeViewControl = new TreeViewControl()) { guiMock.Expect(g => g.Get(nodeData, treeViewControl)).Return(menuBuilder); + guiMock.Stub(cmp => cmp.ViewCommands).Return(mocks.Stub()); mocks.ReplayAll(); @@ -463,6 +468,7 @@ using (var treeViewControl = new TreeViewControl()) { guiMock.Expect(g => g.Get(nodeData, treeViewControl)).Return(menuBuilder); + guiMock.Stub(cmp => cmp.ViewCommands).Return(mocks.Stub()); mocks.ReplayAll(); @@ -518,6 +524,7 @@ using (var treeViewControl = new TreeViewControl()) { guiMock.Expect(g => g.Get(nodeData, treeViewControl)).Return(menuBuilder); + guiMock.Stub(cmp => cmp.ViewCommands).Return(mocks.Stub()); mocks.ReplayAll(); @@ -556,6 +563,7 @@ using (var treeViewControl = new TreeViewControl()) { guiMock.Expect(g => g.Get(nodeData, treeViewControl)).Return(menuBuilder); + guiMock.Stub(cmp => cmp.ViewCommands).Return(mocks.Stub()); mocks.ReplayAll(); @@ -602,6 +610,7 @@ using (var treeViewControl = new TreeViewControl()) { guiMock.Expect(g => g.Get(nodeData, treeViewControl)).Return(menuBuilder); + guiMock.Stub(cmp => cmp.ViewCommands).Return(mocks.Stub()); mocks.ReplayAll(); @@ -648,6 +657,7 @@ using (var treeViewControl = new TreeViewControl()) { guiMock.Expect(g => g.Get(nodeData, treeViewControl)).Return(menuBuilder); + guiMock.Stub(cmp => cmp.ViewCommands).Return(mocks.Stub()); mocks.ReplayAll(); @@ -703,6 +713,7 @@ using (var treeViewControl = new TreeViewControl()) { guiMock.Expect(g => g.Get(nodeData, treeViewControl)).Return(menuBuilder); + guiMock.Stub(cmp => cmp.ViewCommands).Return(mocks.Stub()); mocks.ReplayAll(); @@ -765,6 +776,7 @@ { guiMock.Expect(g => g.Get(groupContext, treeViewControl)).Return(menuBuilder); guiMock.Expect(g => g.MainWindow).Return(mainWindowStub); + guiMock.Stub(cmp => cmp.ViewCommands).Return(mocks.Stub()); mocks.ReplayAll(); @@ -847,6 +859,7 @@ using (var treeViewControl = new TreeViewControl()) { guiMock.Expect(g => g.Get(groupContext, treeViewControl)).Return(menuBuilder); + guiMock.Stub(cmp => cmp.ViewCommands).Return(mocks.Stub()); mocks.ReplayAll(); @@ -890,6 +903,7 @@ using (var treeViewControl = new TreeViewControl()) { guiMock.Expect(cmp => cmp.Get(nodeData, treeViewControl)).Return(menuBuilder); + guiMock.Stub(cmp => cmp.ViewCommands).Return(mocks.Stub()); mocks.ReplayAll(); @@ -934,6 +948,7 @@ using (var treeViewControl = new TreeViewControl()) { guiMock.Expect(cmp => cmp.Get(nodeData, treeViewControl)).Return(menuBuilder); + guiMock.Stub(cmp => cmp.ViewCommands).Return(mocks.Stub()); mocks.ReplayAll(); @@ -972,20 +987,23 @@ { Name = "Nieuwe berekening" }; + var viewCommandsMock = mocks.StrictMock(); + viewCommandsMock.Expect(vc => vc.RemoveAllViewsForItem(calculation)); + var observerMock = mocks.StrictMock(); observerMock.Expect(o => o.UpdateObserver()); using (var treeViewControl = new TreeViewControl()) { - var gui = mocks.StrictMock(); - gui.Expect(cmp => cmp.Get(nodeData, treeViewControl)).Return(menuBuilder); + guiMock.Expect(cmp => cmp.Get(nodeData, treeViewControl)).Return(menuBuilder); + guiMock.Stub(cmp => cmp.ViewCommands).Return(viewCommandsMock); mocks.ReplayAll(); group.Children.Add(calculation); nodeData.Attach(observerMock); - plugin.Gui = gui; + plugin.Gui = guiMock; DialogBoxHandler = (name, wnd) => { Index: Ringtoets/Piping/test/Ringtoets.Piping.Forms.Test/TreeNodeInfos/PipingCalculationGroupContextTreeNodeInfoTest.cs =================================================================== diff -u -rcafc06addb418979c7ad697501da676973732b21 -r31a41fbf921e5ef9b61fbd1e1f07ae919c8aadca --- Ringtoets/Piping/test/Ringtoets.Piping.Forms.Test/TreeNodeInfos/PipingCalculationGroupContextTreeNodeInfoTest.cs (.../PipingCalculationGroupContextTreeNodeInfoTest.cs) (revision cafc06addb418979c7ad697501da676973732b21) +++ Ringtoets/Piping/test/Ringtoets.Piping.Forms.Test/TreeNodeInfos/PipingCalculationGroupContextTreeNodeInfoTest.cs (.../PipingCalculationGroupContextTreeNodeInfoTest.cs) (revision 31a41fbf921e5ef9b61fbd1e1f07ae919c8aadca) @@ -297,6 +297,7 @@ nodeData, treeViewControl); gui.Expect(g => g.Get(nodeData, treeViewControl)).Return(menuBuilder); + gui.Stub(cmp => cmp.ViewCommands).Return(mocks.Stub()); viewCommandsHandler.Expect(vc => vc.CanOpenViewFor(nodeData)).Return(true); mocks.ReplayAll(); @@ -387,6 +388,7 @@ var gui = mocks.StrictMock(); gui.Expect(g => g.Get(nodeData, treeViewControl)).Return(menuBuilder); + gui.Stub(cmp => cmp.ViewCommands).Return(mocks.Stub()); mocks.ReplayAll(); @@ -428,6 +430,7 @@ var gui = mocks.StrictMock(); gui.Expect(g => g.Get(nodeData, treeViewControl)).Return(menuBuilder); + gui.Stub(cmp => cmp.ViewCommands).Return(mocks.Stub()); mocks.ReplayAll(); @@ -472,6 +475,7 @@ var gui = mocks.StrictMock(); gui.Expect(g => g.Get(nodeData, treeViewControl)).Return(menuBuilder); + gui.Stub(cmp => cmp.ViewCommands).Return(mocks.Stub()); mocks.ReplayAll(); @@ -552,6 +556,7 @@ var gui = mocks.StrictMock(); gui.Expect(cmp => cmp.Get(nodeData, treeViewControl)).Return(menuBuilder); + gui.Stub(cmp => cmp.ViewCommands).Return(mocks.Stub()); mocks.ReplayAll(); @@ -593,6 +598,7 @@ var gui = mocks.StrictMock(); gui.Expect(cmp => cmp.Get(nodeData, treeViewControl)).Return(menuBuilder); + gui.Stub(cmp => cmp.ViewCommands).Return(mocks.Stub()); mocks.ReplayAll(); @@ -982,6 +988,7 @@ var gui = mocks.StrictMock(); gui.Expect(cmp => cmp.Get(nodeData, treeViewControl)).Return(menuBuilder); gui.Expect(g => g.MainWindow).Return(mainWindow); + gui.Stub(cmp => cmp.ViewCommands).Return(mocks.Stub()); mocks.ReplayAll(); @@ -1016,11 +1023,12 @@ // Setup using (var treeViewControl = new TreeViewControl()) { + var calculation = mocks.Stub(); var group = new CalculationGroup { Children = { - mocks.Stub() + calculation } }; @@ -1033,9 +1041,12 @@ assessmentSectionMock); var menuBuilder = new CustomItemsOnlyContextMenuBuilder(); + var viewCommandsMock = mocks.StrictMock(); + viewCommandsMock.Expect(vc => vc.RemoveAllViewsForItem(calculation)); var gui = mocks.StrictMock(); gui.Expect(cmp => cmp.Get(nodeData, treeViewControl)).Return(menuBuilder); + gui.Stub(cmp => cmp.ViewCommands).Return(viewCommandsMock); mocks.ReplayAll(); @@ -1130,6 +1141,7 @@ var gui = mocks.StrictMock(); gui.Expect(cmp => cmp.Get(nodeData, treeViewControl)).Return(menuBuilder); gui.Expect(g => g.MainWindow).Return(mainWindow); + gui.Stub(cmp => cmp.ViewCommands).Return(mocks.Stub()); mocks.ReplayAll(); @@ -1241,6 +1253,7 @@ var gui = mocks.StrictMock(); gui.Expect(cmp => cmp.Get(nodeData, treeViewControl)).Return(menuBuilder); gui.Expect(g => g.MainWindow).Return(mainWindow); + gui.Stub(cmp => cmp.ViewCommands).Return(mocks.Stub()); mocks.ReplayAll();