Index: Ringtoets/Common/test/Ringtoets.Common.Forms.Test/GuiServices/HydraulicBoundaryLocationCalculationGuiServiceTest.cs =================================================================== diff -u -r58bb28c3d0e0ccfc1a3cfcd29bd4f5e5ead4d0a9 -r32f5a8663400beb92dc30ab135890d999040cbe9 --- Ringtoets/Common/test/Ringtoets.Common.Forms.Test/GuiServices/HydraulicBoundaryLocationCalculationGuiServiceTest.cs (.../HydraulicBoundaryLocationCalculationGuiServiceTest.cs) (revision 58bb28c3d0e0ccfc1a3cfcd29bd4f5e5ead4d0a9) +++ Ringtoets/Common/test/Ringtoets.Common.Forms.Test/GuiServices/HydraulicBoundaryLocationCalculationGuiServiceTest.cs (.../HydraulicBoundaryLocationCalculationGuiServiceTest.cs) (revision 32f5a8663400beb92dc30ab135890d999040cbe9) @@ -221,9 +221,10 @@ calculatorFactory.Expect(cf => cf.CreateDesignWaterLevelCalculator(Arg.Is.NotNull)) .WhenCalled(invocation => { - var settings = (HydraRingCalculationSettings) invocation.Arguments[0]; - Assert.AreEqual(validFilePath, settings.HlcdFilePath); - Assert.IsEmpty(settings.PreprocessorDirectory); + var hydraRingCalculationSettings = (HydraRingCalculationSettings) invocation.Arguments[0]; + HydraRingCalculationSettingsTestHelper.AssertHydraRingCalculationSettings( + HydraulicBoundaryCalculationSettingsFactory.CreateSettings(assessmentSection.HydraulicBoundaryDatabase), + hydraRingCalculationSettings); }) .Return(new TestDesignWaterLevelCalculator()); mockRepository.ReplayAll(); @@ -420,7 +421,7 @@ calculatorFactory.Expect(cf => cf.CreateWaveHeightCalculator(Arg.Is.NotNull)) .WhenCalled(invocation => { - var settings = (HydraRingCalculationSettings)invocation.Arguments[0]; + var settings = (HydraRingCalculationSettings) invocation.Arguments[0]; Assert.AreEqual(validFilePath, settings.HlcdFilePath); Assert.IsEmpty(settings.PreprocessorDirectory); }) Index: Ringtoets/Integration/test/Ringtoets.Integration.Service.Test/AssessmentSectionCalculationActivityFactoryTest.cs =================================================================== diff -u -r9803198f06f973be83afa835837bc05958d94723 -r32f5a8663400beb92dc30ab135890d999040cbe9 --- Ringtoets/Integration/test/Ringtoets.Integration.Service.Test/AssessmentSectionCalculationActivityFactoryTest.cs (.../AssessmentSectionCalculationActivityFactoryTest.cs) (revision 9803198f06f973be83afa835837bc05958d94723) +++ Ringtoets/Integration/test/Ringtoets.Integration.Service.Test/AssessmentSectionCalculationActivityFactoryTest.cs (.../AssessmentSectionCalculationActivityFactoryTest.cs) (revision 32f5a8663400beb92dc30ab135890d999040cbe9) @@ -34,6 +34,7 @@ using Ringtoets.Common.Data.Hydraulics; using Ringtoets.Common.Data.TestUtil; using Ringtoets.Common.Service; +using Ringtoets.Common.Service.TestUtil; using Ringtoets.DuneErosion.Data.TestUtil; using Ringtoets.GrassCoverErosionInwards.Data; using Ringtoets.GrassCoverErosionOutwards.Data; @@ -102,14 +103,15 @@ var mocks = new MockRepository(); var calculatorFactory = mocks.StrictMock(); + HydraulicBoundaryCalculationSettings expectedCalculationSettings = HydraulicBoundaryCalculationSettingsFactory.CreateSettings(assessmentSection.HydraulicBoundaryDatabase); using (mocks.Ordered()) { calculatorFactory.Expect(cf => cf.CreateDesignWaterLevelCalculator(Arg.Is.NotNull)) .WhenCalled(invocation => { - var settings = (HydraRingCalculationSettings) invocation.Arguments[0]; - Assert.AreEqual(hydraulicBoundaryDatabaseFilePath, settings.HlcdFilePath); - Assert.IsEmpty(settings.PreprocessorDirectory); + var hydraRingCalculationSettings = (HydraRingCalculationSettings) invocation.Arguments[0]; + HydraRingCalculationSettingsTestHelper.AssertHydraRingCalculationSettings(expectedCalculationSettings, + hydraRingCalculationSettings); }) .Return(new TestDesignWaterLevelCalculator { @@ -145,19 +147,19 @@ calculatorFactory.Expect(cf => cf.CreateDesignWaterLevelCalculator(Arg.Is.NotNull)) .WhenCalled(invocation => { - var settings = (HydraRingCalculationSettings) invocation.Arguments[0]; - Assert.AreEqual(hydraulicBoundaryDatabaseFilePath, settings.HlcdFilePath); - Assert.IsEmpty(settings.PreprocessorDirectory); + var hydraRingCalculationSettings = (HydraRingCalculationSettings)invocation.Arguments[0]; + HydraRingCalculationSettingsTestHelper.AssertHydraRingCalculationSettings(expectedCalculationSettings, + hydraRingCalculationSettings); }) .Return(new TestDesignWaterLevelCalculator()).Repeat.Times(3); calculatorFactory.Expect(cf => cf.CreateWaveHeightCalculator(Arg.Is.NotNull)) .WhenCalled(invocation => { - var settings = (HydraRingCalculationSettings)invocation.Arguments[0]; + var settings = (HydraRingCalculationSettings) invocation.Arguments[0]; Assert.AreEqual(hydraulicBoundaryDatabaseFilePath, settings.HlcdFilePath); Assert.IsEmpty(settings.PreprocessorDirectory); }) - .Return(new TestWaveHeightCalculator()).Repeat.Times(3); + .Return(new TestWaveHeightCalculator()).Repeat.Times(3); calculatorFactory.Expect(cf => cf.CreateWaveConditionsCosineCalculator(Arg.Is.NotNull)) .WhenCalled(invocation => @@ -201,9 +203,9 @@ calculatorFactory.Expect(cf => cf.CreateDunesBoundaryConditionsCalculator(Arg.Is.NotNull)) .WhenCalled(invocation => { - var settings = (HydraRingCalculationSettings) invocation.Arguments[0]; - Assert.AreEqual(testDataPath, settings.HlcdFilePath); - Assert.IsEmpty(settings.PreprocessorDirectory); + var hydraRingCalculationSettings = (HydraRingCalculationSettings)invocation.Arguments[0]; + HydraRingCalculationSettingsTestHelper.AssertHydraRingCalculationSettings(expectedCalculationSettings, + hydraRingCalculationSettings); }) .Return(new TestDunesBoundaryConditionsCalculator()).Repeat.Times(5); } Index: Ringtoets/Integration/test/Ringtoets.Integration.Service.Test/AssessmentSectionHydraulicBoundaryLocationCalculationActivityFactoryTest.cs =================================================================== diff -u -r9803198f06f973be83afa835837bc05958d94723 -r32f5a8663400beb92dc30ab135890d999040cbe9 --- Ringtoets/Integration/test/Ringtoets.Integration.Service.Test/AssessmentSectionHydraulicBoundaryLocationCalculationActivityFactoryTest.cs (.../AssessmentSectionHydraulicBoundaryLocationCalculationActivityFactoryTest.cs) (revision 9803198f06f973be83afa835837bc05958d94723) +++ Ringtoets/Integration/test/Ringtoets.Integration.Service.Test/AssessmentSectionHydraulicBoundaryLocationCalculationActivityFactoryTest.cs (.../AssessmentSectionHydraulicBoundaryLocationCalculationActivityFactoryTest.cs) (revision 32f5a8663400beb92dc30ab135890d999040cbe9) @@ -31,6 +31,7 @@ using Ringtoets.Common.Data.Hydraulics; using Ringtoets.Common.Data.TestUtil; using Ringtoets.Common.Service; +using Ringtoets.Common.Service.TestUtil; using Ringtoets.HydraRing.Calculation.Calculator.Factory; using Ringtoets.HydraRing.Calculation.Data.Input; using Ringtoets.HydraRing.Calculation.Data.Input.Hydraulics; @@ -89,49 +90,50 @@ double lowerLimitNorm = assessmentSection.FailureMechanismContribution.LowerLimitNorm; double factorizedLowerLimitNorm = lowerLimitNorm * 30; + var hydraulicBoundaryDatabase = assessmentSection.HydraulicBoundaryDatabase; AssertDesignWaterLevelCalculationActivity(activities.ElementAt(0), hydraulicBoundaryLocation1, factorizedSignalingNorm, expectedCategoryBoundaryName1, - usePreprocessor); + hydraulicBoundaryDatabase); AssertDesignWaterLevelCalculationActivity(activities.ElementAt(1), hydraulicBoundaryLocation2, factorizedSignalingNorm, expectedCategoryBoundaryName1, - usePreprocessor); + hydraulicBoundaryDatabase); AssertDesignWaterLevelCalculationActivity(activities.ElementAt(2), hydraulicBoundaryLocation1, signalingNorm, expectedCategoryBoundaryName2, - usePreprocessor); + hydraulicBoundaryDatabase); AssertDesignWaterLevelCalculationActivity(activities.ElementAt(3), hydraulicBoundaryLocation2, signalingNorm, expectedCategoryBoundaryName2, - usePreprocessor); + hydraulicBoundaryDatabase); AssertDesignWaterLevelCalculationActivity(activities.ElementAt(4), hydraulicBoundaryLocation1, lowerLimitNorm, expectedCategoryBoundaryName3, - usePreprocessor); + hydraulicBoundaryDatabase); AssertDesignWaterLevelCalculationActivity(activities.ElementAt(5), hydraulicBoundaryLocation2, lowerLimitNorm, expectedCategoryBoundaryName3, - usePreprocessor); + hydraulicBoundaryDatabase); AssertDesignWaterLevelCalculationActivity(activities.ElementAt(6), hydraulicBoundaryLocation1, factorizedLowerLimitNorm, expectedCategoryBoundaryName4, - usePreprocessor); + hydraulicBoundaryDatabase); AssertDesignWaterLevelCalculationActivity(activities.ElementAt(7), hydraulicBoundaryLocation2, factorizedLowerLimitNorm, expectedCategoryBoundaryName4, - usePreprocessor); + hydraulicBoundaryDatabase); AssertWaveHeightCalculationActivity(activities.ElementAt(8), hydraulicBoundaryLocation1, @@ -217,49 +219,50 @@ double lowerLimitNorm = assessmentSection.FailureMechanismContribution.LowerLimitNorm; double factorizedLowerLimitNorm = lowerLimitNorm * 30; + var hydraulicBoundaryDatabase = assessmentSection.HydraulicBoundaryDatabase; AssertDesignWaterLevelCalculationActivity(activities.ElementAt(0), hydraulicBoundaryLocation1, factorizedSignalingNorm, expectedCategoryBoundaryName1, - usePreprocessor); + hydraulicBoundaryDatabase); AssertDesignWaterLevelCalculationActivity(activities.ElementAt(1), hydraulicBoundaryLocation2, factorizedSignalingNorm, expectedCategoryBoundaryName1, - usePreprocessor); + hydraulicBoundaryDatabase); AssertDesignWaterLevelCalculationActivity(activities.ElementAt(2), hydraulicBoundaryLocation1, signalingNorm, expectedCategoryBoundaryName2, - usePreprocessor); + hydraulicBoundaryDatabase); AssertDesignWaterLevelCalculationActivity(activities.ElementAt(3), hydraulicBoundaryLocation2, signalingNorm, expectedCategoryBoundaryName2, - usePreprocessor); + hydraulicBoundaryDatabase); AssertDesignWaterLevelCalculationActivity(activities.ElementAt(4), hydraulicBoundaryLocation1, lowerLimitNorm, expectedCategoryBoundaryName3, - usePreprocessor); + hydraulicBoundaryDatabase); AssertDesignWaterLevelCalculationActivity(activities.ElementAt(5), hydraulicBoundaryLocation2, lowerLimitNorm, expectedCategoryBoundaryName3, - usePreprocessor); + hydraulicBoundaryDatabase); AssertDesignWaterLevelCalculationActivity(activities.ElementAt(6), hydraulicBoundaryLocation1, factorizedLowerLimitNorm, expectedCategoryBoundaryName4, - usePreprocessor); + hydraulicBoundaryDatabase); AssertDesignWaterLevelCalculationActivity(activities.ElementAt(7), hydraulicBoundaryLocation2, factorizedLowerLimitNorm, expectedCategoryBoundaryName4, - usePreprocessor); + hydraulicBoundaryDatabase); } [Test] @@ -362,18 +365,18 @@ HydraulicBoundaryLocation hydraulicBoundaryLocation, double norm, string categoryBoundaryName, - bool usePreprocessor) + HydraulicBoundaryDatabase hydraulicBoundaryDatabase) { var mocks = new MockRepository(); var designWaterLevelCalculator = new TestDesignWaterLevelCalculator(); var calculatorFactory = mocks.Stub(); - string preprocessorDirectory = usePreprocessor ? validPreprocessorDirectory : string.Empty; calculatorFactory.Expect(cf => cf.CreateDesignWaterLevelCalculator(Arg.Is.NotNull)) .WhenCalled(invocation => { - var settings = (HydraRingCalculationSettings) invocation.Arguments[0]; - Assert.AreEqual(validFilePath, settings.HlcdFilePath); - Assert.AreEqual(preprocessorDirectory, settings.PreprocessorDirectory); + var hydraRingCalculationSettings = (HydraRingCalculationSettings) invocation.Arguments[0]; + HydraRingCalculationSettingsTestHelper.AssertHydraRingCalculationSettings( + HydraulicBoundaryCalculationSettingsFactory.CreateSettings(hydraulicBoundaryDatabase), + hydraRingCalculationSettings); }) .Return(designWaterLevelCalculator); mocks.ReplayAll(); Index: Ringtoets/Integration/test/Ringtoets.Integration.Service.Test/Ringtoets.Integration.Service.Test.csproj =================================================================== diff -u -ra239b3f889a32a47cd41578a760febc9eb3e6ade -r32f5a8663400beb92dc30ab135890d999040cbe9 --- Ringtoets/Integration/test/Ringtoets.Integration.Service.Test/Ringtoets.Integration.Service.Test.csproj (.../Ringtoets.Integration.Service.Test.csproj) (revision a239b3f889a32a47cd41578a760febc9eb3e6ade) +++ Ringtoets/Integration/test/Ringtoets.Integration.Service.Test/Ringtoets.Integration.Service.Test.csproj (.../Ringtoets.Integration.Service.Test.csproj) (revision 32f5a8663400beb92dc30ab135890d999040cbe9) @@ -68,6 +68,10 @@ {4843d6e5-066f-4795-94f5-1d53932dd03c} Ringtoets.Common.Data.TestUtil + + {52093DA6-D545-476A-ADFD-12F56625E36B} + Ringtoets.Common.Service.TestUtil + {D1068432-C172-4AA6-847B-D9DEB4C6DE26} Ringtoets.DuneErosion.Data