Index: Ringtoets/GrassCoverErosionOutwards/test/Ringtoets.GrassCoverErosionOutwards.Plugin.Test/TreeNodeInfos/GrassCoverErosionOutwardsFailureMechanismContextTreeNodeInfoTest.cs =================================================================== diff -u -r8cb74c6836f9d1903069a0720d4524b8304555cc -r3c851a1c7bae12523ca12e22d63dd9950bbe163f --- Ringtoets/GrassCoverErosionOutwards/test/Ringtoets.GrassCoverErosionOutwards.Plugin.Test/TreeNodeInfos/GrassCoverErosionOutwardsFailureMechanismContextTreeNodeInfoTest.cs (.../GrassCoverErosionOutwardsFailureMechanismContextTreeNodeInfoTest.cs) (revision 8cb74c6836f9d1903069a0720d4524b8304555cc) +++ Ringtoets/GrassCoverErosionOutwards/test/Ringtoets.GrassCoverErosionOutwards.Plugin.Test/TreeNodeInfos/GrassCoverErosionOutwardsFailureMechanismContextTreeNodeInfoTest.cs (.../GrassCoverErosionOutwardsFailureMechanismContextTreeNodeInfoTest.cs) (revision 3c851a1c7bae12523ca12e22d63dd9950bbe163f) @@ -579,19 +579,19 @@ calculatorFactory.Expect(cf => cf.CreateDesignWaterLevelCalculator(Arg.Is.NotNull)) .WhenCalled(invocation => { - var hydraRingCalculationSettings = (HydraRingCalculationSettings)invocation.Arguments[0]; - HydraRingCalculationSettingsTestHelper.AssertHydraRingCalculationSettings(expectedCalculationSettings, - hydraRingCalculationSettings); + HydraRingCalculationSettingsTestHelper.AssertHydraRingCalculationSettings( + expectedCalculationSettings, + (HydraRingCalculationSettings) invocation.Arguments[0]); }) .Return(designWaterLevelCalculator) .Repeat .Times(5); calculatorFactory.Expect(cf => cf.CreateWaveHeightCalculator(Arg.Is.NotNull)) .WhenCalled(invocation => { - var settings = (HydraRingCalculationSettings)invocation.Arguments[0]; - Assert.AreEqual(validFilePath, settings.HlcdFilePath); - Assert.IsEmpty(settings.PreprocessorDirectory); + HydraRingCalculationSettingsTestHelper.AssertHydraRingCalculationSettings( + expectedCalculationSettings, + (HydraRingCalculationSettings)invocation.Arguments[0]); }) .Return(waveHeightCalculator) .Repeat Index: Ringtoets/GrassCoverErosionOutwards/test/Ringtoets.GrassCoverErosionOutwards.Plugin.Test/TreeNodeInfos/GrassCoverErosionOutwardsHydraulicBoundaryDatabaseContextTreeNodeInfoTest.cs =================================================================== diff -u -r8cb74c6836f9d1903069a0720d4524b8304555cc -r3c851a1c7bae12523ca12e22d63dd9950bbe163f --- Ringtoets/GrassCoverErosionOutwards/test/Ringtoets.GrassCoverErosionOutwards.Plugin.Test/TreeNodeInfos/GrassCoverErosionOutwardsHydraulicBoundaryDatabaseContextTreeNodeInfoTest.cs (.../GrassCoverErosionOutwardsHydraulicBoundaryDatabaseContextTreeNodeInfoTest.cs) (revision 8cb74c6836f9d1903069a0720d4524b8304555cc) +++ Ringtoets/GrassCoverErosionOutwards/test/Ringtoets.GrassCoverErosionOutwards.Plugin.Test/TreeNodeInfos/GrassCoverErosionOutwardsHydraulicBoundaryDatabaseContextTreeNodeInfoTest.cs (.../GrassCoverErosionOutwardsHydraulicBoundaryDatabaseContextTreeNodeInfoTest.cs) (revision 3c851a1c7bae12523ca12e22d63dd9950bbe163f) @@ -302,19 +302,19 @@ calculatorFactory.Expect(cf => cf.CreateDesignWaterLevelCalculator(Arg.Is.NotNull)) .WhenCalled(invocation => { - var hydraRingCalculationSettings = (HydraRingCalculationSettings) invocation.Arguments[0]; - HydraRingCalculationSettingsTestHelper.AssertHydraRingCalculationSettings(expectedCalculationSettings, - hydraRingCalculationSettings); + HydraRingCalculationSettingsTestHelper.AssertHydraRingCalculationSettings( + expectedCalculationSettings, + (HydraRingCalculationSettings) invocation.Arguments[0]); }) .Return(designWaterLevelCalculator) .Repeat .Times(5); calculatorFactory.Expect(cf => cf.CreateWaveHeightCalculator(Arg.Is.NotNull)) .WhenCalled(invocation => { - var settings = (HydraRingCalculationSettings) invocation.Arguments[0]; - Assert.AreEqual(validFilePath, settings.HlcdFilePath); - Assert.IsEmpty(settings.PreprocessorDirectory); + HydraRingCalculationSettingsTestHelper.AssertHydraRingCalculationSettings( + expectedCalculationSettings, + (HydraRingCalculationSettings) invocation.Arguments[0]); }) .Return(waveHeightCalculator) .Repeat Index: Ringtoets/GrassCoverErosionOutwards/test/Ringtoets.GrassCoverErosionOutwards.Plugin.Test/TreeNodeInfos/GrassCoverErosionOutwardsWaveHeightCalculationsContextTreeNodeInfoTest.cs =================================================================== diff -u -rd149137378015c9050e5be4c0ea6c050966cd4a6 -r3c851a1c7bae12523ca12e22d63dd9950bbe163f --- Ringtoets/GrassCoverErosionOutwards/test/Ringtoets.GrassCoverErosionOutwards.Plugin.Test/TreeNodeInfos/GrassCoverErosionOutwardsWaveHeightCalculationsContextTreeNodeInfoTest.cs (.../GrassCoverErosionOutwardsWaveHeightCalculationsContextTreeNodeInfoTest.cs) (revision d149137378015c9050e5be4c0ea6c050966cd4a6) +++ Ringtoets/GrassCoverErosionOutwards/test/Ringtoets.GrassCoverErosionOutwards.Plugin.Test/TreeNodeInfos/GrassCoverErosionOutwardsWaveHeightCalculationsContextTreeNodeInfoTest.cs (.../GrassCoverErosionOutwardsWaveHeightCalculationsContextTreeNodeInfoTest.cs) (revision 3c851a1c7bae12523ca12e22d63dd9950bbe163f) @@ -38,6 +38,7 @@ using Ringtoets.Common.Data.AssessmentSection; using Ringtoets.Common.Data.Hydraulics; using Ringtoets.Common.Data.TestUtil; +using Ringtoets.Common.Service.TestUtil; using Ringtoets.GrassCoverErosionOutwards.Data; using Ringtoets.GrassCoverErosionOutwards.Forms.PresentationObjects; using Ringtoets.HydraRing.Calculation.Calculator.Factory; @@ -463,9 +464,9 @@ calculatorFactory.Expect(cf => cf.CreateWaveHeightCalculator(Arg.Is.NotNull)) .WhenCalled(invocation => { - var settings = (HydraRingCalculationSettings) invocation.Arguments[0]; - Assert.AreEqual(validFilePath, settings.HlcdFilePath); - Assert.IsEmpty(settings.PreprocessorDirectory); + HydraRingCalculationSettingsTestHelper.AssertHydraRingCalculationSettings( + HydraulicBoundaryCalculationSettingsFactory.CreateSettings(assessmentSection.HydraulicBoundaryDatabase), + (HydraRingCalculationSettings) invocation.Arguments[0]); }) .Return(waveHeightCalculator); mockRepository.ReplayAll(); @@ -531,9 +532,9 @@ calculatorFactory.Expect(cf => cf.CreateWaveHeightCalculator(Arg.Is.NotNull)) .WhenCalled(invocation => { - var settings = (HydraRingCalculationSettings) invocation.Arguments[0]; - Assert.AreEqual(validFilePath, settings.HlcdFilePath); - Assert.AreEqual(preprocessorDirectory, settings.PreprocessorDirectory); + HydraRingCalculationSettingsTestHelper.AssertHydraRingCalculationSettings( + HydraulicBoundaryCalculationSettingsFactory.CreateSettings(assessmentSection.HydraulicBoundaryDatabase), + (HydraRingCalculationSettings) invocation.Arguments[0]); }) .Return(waveHeightCalculator); mockRepository.ReplayAll(); @@ -598,9 +599,9 @@ calculatorFactory.Expect(cf => cf.CreateWaveHeightCalculator(Arg.Is.NotNull)) .WhenCalled(invocation => { - var settings = (HydraRingCalculationSettings) invocation.Arguments[0]; - Assert.AreEqual(validFilePath, settings.HlcdFilePath); - Assert.IsEmpty(settings.PreprocessorDirectory); + HydraRingCalculationSettingsTestHelper.AssertHydraRingCalculationSettings( + HydraulicBoundaryCalculationSettingsFactory.CreateSettings(assessmentSection.HydraulicBoundaryDatabase), + (HydraRingCalculationSettings) invocation.Arguments[0]); }) .Return(waveHeightCalculator); mockRepository.ReplayAll(); Index: Ringtoets/GrassCoverErosionOutwards/test/Ringtoets.GrassCoverErosionOutwards.Plugin.Test/TreeNodeInfos/GrassCoverErosionOutwardsWaveHeightCalculationsGroupContextTreeNodeInfoTest.cs =================================================================== diff -u -rd149137378015c9050e5be4c0ea6c050966cd4a6 -r3c851a1c7bae12523ca12e22d63dd9950bbe163f --- Ringtoets/GrassCoverErosionOutwards/test/Ringtoets.GrassCoverErosionOutwards.Plugin.Test/TreeNodeInfos/GrassCoverErosionOutwardsWaveHeightCalculationsGroupContextTreeNodeInfoTest.cs (.../GrassCoverErosionOutwardsWaveHeightCalculationsGroupContextTreeNodeInfoTest.cs) (revision d149137378015c9050e5be4c0ea6c050966cd4a6) +++ Ringtoets/GrassCoverErosionOutwards/test/Ringtoets.GrassCoverErosionOutwards.Plugin.Test/TreeNodeInfos/GrassCoverErosionOutwardsWaveHeightCalculationsGroupContextTreeNodeInfoTest.cs (.../GrassCoverErosionOutwardsWaveHeightCalculationsGroupContextTreeNodeInfoTest.cs) (revision 3c851a1c7bae12523ca12e22d63dd9950bbe163f) @@ -41,6 +41,7 @@ using Ringtoets.Common.Data.TestUtil; using Ringtoets.Common.Plugin.TestUtil; using Ringtoets.Common.Service; +using Ringtoets.Common.Service.TestUtil; using Ringtoets.GrassCoverErosionOutwards.Data; using Ringtoets.GrassCoverErosionOutwards.Forms.PresentationObjects; using Ringtoets.HydraRing.Calculation.Calculator; @@ -350,9 +351,9 @@ calculatorFactory.Expect(cf => cf.CreateWaveHeightCalculator(Arg.Is.NotNull)) .WhenCalled(invocation => { - var settings = (HydraRingCalculationSettings)invocation.Arguments[0]; - Assert.AreEqual(filePath, settings.HlcdFilePath); - Assert.IsEmpty(settings.PreprocessorDirectory); + HydraRingCalculationSettingsTestHelper.AssertHydraRingCalculationSettings( + HydraulicBoundaryCalculationSettingsFactory.CreateSettings(assessmentSection.HydraulicBoundaryDatabase), + (HydraRingCalculationSettings) invocation.Arguments[0]); }) .Return(waveHeightCalculator).Repeat.Times(5); mockRepository.ReplayAll(); Index: Ringtoets/GrassCoverErosionOutwards/test/Ringtoets.GrassCoverErosionOutwards.Service.Test/GrassCoverErosionOutwardsCalculationActivityFactoryTest.cs =================================================================== diff -u -r8cb74c6836f9d1903069a0720d4524b8304555cc -r3c851a1c7bae12523ca12e22d63dd9950bbe163f --- Ringtoets/GrassCoverErosionOutwards/test/Ringtoets.GrassCoverErosionOutwards.Service.Test/GrassCoverErosionOutwardsCalculationActivityFactoryTest.cs (.../GrassCoverErosionOutwardsCalculationActivityFactoryTest.cs) (revision 8cb74c6836f9d1903069a0720d4524b8304555cc) +++ Ringtoets/GrassCoverErosionOutwards/test/Ringtoets.GrassCoverErosionOutwards.Service.Test/GrassCoverErosionOutwardsCalculationActivityFactoryTest.cs (.../GrassCoverErosionOutwardsCalculationActivityFactoryTest.cs) (revision 3c851a1c7bae12523ca12e22d63dd9950bbe163f) @@ -150,24 +150,29 @@ AssertWaveHeightCalculationActivity(activities.ElementAt(5), hydraulicBoundaryLocation, mechanismSpecificFactorizedSignalingNorm, - "Iv"); + "Iv", + hydraulicBoundaryDatabase); AssertWaveHeightCalculationActivity(activities.ElementAt(6), hydraulicBoundaryLocation, mechanismSpecificSignalingNorm, - "IIv"); + "IIv", + hydraulicBoundaryDatabase); AssertWaveHeightCalculationActivity(activities.ElementAt(7), hydraulicBoundaryLocation, mechanismSpecificLowerLimitNorm, - "IIIv"); + "IIIv", + hydraulicBoundaryDatabase); AssertWaveHeightCalculationActivity(activities.ElementAt(8), hydraulicBoundaryLocation, lowerLimitNorm, - "IVv"); + "IVv", + hydraulicBoundaryDatabase); AssertWaveHeightCalculationActivity(activities.ElementAt(9), hydraulicBoundaryLocation, factorizedLowerLimitNorm, - "Vv"); + "Vv", + hydraulicBoundaryDatabase); var hydraulicBoundaryLocationCalculationOutput = new TestHydraulicBoundaryLocationCalculationOutput(2.0); failureMechanism.WaterLevelCalculationsForMechanismSpecificFactorizedSignalingNorm.Single().Output = hydraulicBoundaryLocationCalculationOutput; @@ -263,16 +268,16 @@ AssertWaveHeightCalculationActivity(activities.ElementAt(3), hydraulicBoundaryLocation, mechanismSpecificFactorizedSignalingNorm, - "Iv"); + "Iv", hydraulicBoundaryDatabase); AssertWaveHeightCalculationActivity(activities.ElementAt(4), hydraulicBoundaryLocation, mechanismSpecificSignalingNorm, - "IIv"); + "IIv", hydraulicBoundaryDatabase); AssertWaveHeightCalculationActivity(activities.ElementAt(5), hydraulicBoundaryLocation, mechanismSpecificLowerLimitNorm, - "IIIv"); + "IIIv", hydraulicBoundaryDatabase); var hydraulicBoundaryLocationCalculationOutput = new TestHydraulicBoundaryLocationCalculationOutput(2.0); failureMechanism.WaterLevelCalculationsForMechanismSpecificFactorizedSignalingNorm.Single().Output = hydraulicBoundaryLocationCalculationOutput; @@ -721,54 +726,66 @@ double mechanismSpecificFactorizedSignalingNorm = GetExpectedNorm(failureMechanism, assessmentSection.FailureMechanismContribution.SignalingNorm / 30); + + HydraulicBoundaryDatabase hydraulicBoundaryDatabase = assessmentSection.HydraulicBoundaryDatabase; AssertWaveHeightCalculationActivity(activities.First(), hydraulicBoundaryLocation1, mechanismSpecificFactorizedSignalingNorm, - "Iv"); + "Iv", + hydraulicBoundaryDatabase); AssertWaveHeightCalculationActivity(activities.ElementAt(1), hydraulicBoundaryLocation2, mechanismSpecificFactorizedSignalingNorm, - "Iv"); + "Iv", + hydraulicBoundaryDatabase); double mechanismSpecificSignalingNorm = GetExpectedNorm(failureMechanism, assessmentSection.FailureMechanismContribution.SignalingNorm); AssertWaveHeightCalculationActivity(activities.ElementAt(2), hydraulicBoundaryLocation1, mechanismSpecificSignalingNorm, - "IIv"); + "IIv", + hydraulicBoundaryDatabase); AssertWaveHeightCalculationActivity(activities.ElementAt(3), hydraulicBoundaryLocation2, mechanismSpecificSignalingNorm, - "IIv"); + "IIv", + hydraulicBoundaryDatabase); double mechanismSpecificLowerLimitNorm = GetExpectedNorm(failureMechanism, assessmentSection.FailureMechanismContribution.LowerLimitNorm); AssertWaveHeightCalculationActivity(activities.ElementAt(4), hydraulicBoundaryLocation1, mechanismSpecificLowerLimitNorm, - "IIIv"); + "IIIv", + hydraulicBoundaryDatabase); AssertWaveHeightCalculationActivity(activities.ElementAt(5), hydraulicBoundaryLocation2, mechanismSpecificLowerLimitNorm, - "IIIv"); + "IIIv", + hydraulicBoundaryDatabase); double lowerLimitNorm = assessmentSection.FailureMechanismContribution.LowerLimitNorm; AssertWaveHeightCalculationActivity(activities.ElementAt(6), hydraulicBoundaryLocation1, lowerLimitNorm, - "IVv"); + "IVv", + hydraulicBoundaryDatabase); AssertWaveHeightCalculationActivity(activities.ElementAt(7), hydraulicBoundaryLocation2, lowerLimitNorm, - "IVv"); + "IVv", + hydraulicBoundaryDatabase); double factorizedLowerLimitNorm = lowerLimitNorm * 30; AssertWaveHeightCalculationActivity(activities.ElementAt(8), hydraulicBoundaryLocation1, factorizedLowerLimitNorm, - "Vv"); + "Vv", + hydraulicBoundaryDatabase); AssertWaveHeightCalculationActivity(activities.ElementAt(9), hydraulicBoundaryLocation2, factorizedLowerLimitNorm, - "Vv"); + "Vv", + hydraulicBoundaryDatabase); } private static void AssertDesignWaterLevelCalculationActivity(Activity activity, @@ -783,10 +800,9 @@ calculatorFactory.Expect(cf => cf.CreateDesignWaterLevelCalculator(Arg.Is.NotNull)) .WhenCalled(invocation => { - var hydraRingCalculationSettings = (HydraRingCalculationSettings) invocation.Arguments[0]; HydraRingCalculationSettingsTestHelper.AssertHydraRingCalculationSettings( HydraulicBoundaryCalculationSettingsFactory.CreateSettings(hydraulicBoundaryDatabase), - hydraRingCalculationSettings); + (HydraRingCalculationSettings) invocation.Arguments[0]); }) .Return(designWaterLevelCalculator); mocks.ReplayAll(); @@ -809,17 +825,18 @@ private static void AssertWaveHeightCalculationActivity(Activity activity, HydraulicBoundaryLocation hydraulicBoundaryLocation, double norm, - string categoryBoundaryName) + string categoryBoundaryName, + HydraulicBoundaryDatabase hydraulicBoundaryDatabase) { var mocks = new MockRepository(); var waveHeightCalculator = new TestWaveHeightCalculator(); var calculatorFactory = mocks.Stub(); calculatorFactory.Expect(cf => cf.CreateWaveHeightCalculator(Arg.Is.NotNull)) .WhenCalled(invocation => { - var settings = (HydraRingCalculationSettings) invocation.Arguments[0]; - Assert.AreEqual(validFilePath, settings.HlcdFilePath); - Assert.IsEmpty(settings.PreprocessorDirectory); + HydraRingCalculationSettingsTestHelper.AssertHydraRingCalculationSettings( + HydraulicBoundaryCalculationSettingsFactory.CreateSettings(hydraulicBoundaryDatabase), + (HydraRingCalculationSettings) invocation.Arguments[0]); }) .Return(waveHeightCalculator); mocks.ReplayAll();